github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

chore: omit superceded Chromium updates from notes (#19406)

Browse Source 
* feat: omit superceded Chromium updates from notes

* chore: simplify changed code
This commit is contained in:
trop[bot]
2019-07-29 19:42:06 -07:00
committed by Shelley Vohr
parent 261f7fd3be
commit c55bc8106f
1 changed files with 16 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
script/release-notes/notes.js
View File

@@ -581,6 +581,8 @@ const getNotes = async (fromRef, toRef, newVersion) => {
})
}
pool.commits = removeSupercededChromiumUpdates(pool.commits)
const notes = {
breaking: [],
docs: [],
@@ -613,6 +615,20 @@ const getNotes = async (fromRef, toRef, newVersion) => {
return notes
}
const removeSupercededChromiumUpdates = (commits) => {
const chromiumRegex = /^Updated Chromium to \d+\.\d+\.\d+\.\d+/
const updates = commits.filter(commit => (commit.note || commit.subject).match(chromiumRegex))
const keepers = commits.filter(commit => !updates.includes(commit))
// keep the newest update.
if (updates.length) {
updates.sort((a, b) => a.originalPr.number - b.originalPr.number)
keepers.push(updates.pop())
}
return keepers
}
/***
**** Render
***/