github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: compile error in netlog (#18443)

Browse Source
This commit is contained in:
Jeremy Apthorp
2019-05-24 10:54:32 -07:00
committed by GitHub
parent 54cbe5f749
commit cbc177708e
2 changed files with 9 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
atom/browser/api/atom_api_net_log.cc
View File

@@ -92,7 +92,7 @@ v8::Local<v8::Promise> NetLog::StartLogging(mate::Arguments* args) {
// TODO(deepak1556): Provide more flexibility to this module
// by allowing customizations on the capturing options.
auto capture_mode = network::mojom::NetLogCaptureMode::DEFAULT;
auto capture_mode = net::NetLogCaptureMode::Default();
auto max_file_size = network::mojom::NetLogExporter::kUnlimitedFileSize;
base::PostTaskAndReplyWithResult(
@@ -105,11 +105,10 @@ v8::Local<v8::Promise> NetLog::StartLogging(mate::Arguments* args) {
return handle;
}
void NetLog::StartNetLogAfterCreateFile(
network::mojom::NetLogCaptureMode capture_mode,
uint64_t max_file_size,
base::Value custom_constants,
base::File output_file) {
void NetLog::StartNetLogAfterCreateFile(net::NetLogCaptureMode capture_mode,
uint64_t max_file_size,
base::Value custom_constants,
base::File output_file) {
if (!net_log_exporter_) {
// Theoretically the mojo pipe could have been closed by the time we get
// here via the connection error handler. If so, the promise has already

9
atom/browser/api/atom_api_net_log.h
View File

@@ -41,11 +41,10 @@ class NetLog : public mate::TrackableObject<NetLog> {
void OnConnectionError();
void StartNetLogAfterCreateFile(
network::mojom::NetLogCaptureMode capture_mode,
uint64_t max_file_size,
base::Value custom_constants,
base::File output_file);
void StartNetLogAfterCreateFile(net::NetLogCaptureMode capture_mode,
uint64_t max_file_size,
base::Value custom_constants,
base::File output_file);
void NetLogStarted(int32_t error);
private: