build: fix Linux binary strip on publish, Linux x64 PrintInPDF test flake (#42877)

* build: fix up strip Linux binaries

* test: skip flaky Linux x64 test

* test: disable test-domain-error-types

this test is also disabled in main and other release branches

.github/actions/build-electron/action.yml

@@ -17,6 +17,9 @@ inputs:
   is-release:
     description: 'Is release build'
     required: true
+  strip-binaries:
+    description: 'Strip binaries (Linux only)'
+    required: false
   generate-symbols:
     description: 'Generate symbols'
     required: true

.github/workflows/linux-publish.yml

@@ -49,6 +49,7 @@ jobs:
       is-release: true
       gn-build-type: release
       generate-symbols: true
+      strip-binaries: true
       upload-to-storage: ${{ inputs.upload-to-storage }}
     secrets: inherit
 
@@ -64,6 +65,7 @@ jobs:
       is-release: true
       gn-build-type: release
       generate-symbols: true
+      strip-binaries: true
       upload-to-storage: ${{ inputs.upload-to-storage }}
     secrets: inherit
 
@@ -79,5 +81,6 @@ jobs:
       is-release: true
       gn-build-type: release
       generate-symbols: true
+      strip-binaries: true
       upload-to-storage: ${{ inputs.upload-to-storage }}
     secrets: inherit

.github/workflows/pipeline-segment-electron-build.yml

@@ -44,6 +44,11 @@ on:
         required: true
         type: string
         default: '0'
+      strip-binaries: 
+        description: 'Strip the binaries before release (Linux only)'
+        required: false
+        type: boolean
+        default: false
       is-asan: 
         description: 'Building the Address Sanitizer (ASan) Linux build'
         required: false
@@ -191,6 +196,7 @@ jobs:
         artifact-platform: ${{ inputs.target-platform == 'linux' && 'linux' || 'darwin' }}
         is-release: '${{ inputs.is-release }}'
         generate-symbols: '${{ inputs.generate-symbols }}'
+        strip-binaries: '${{ inputs.strip-binaries }}'
         upload-to-storage: '${{ inputs.upload-to-storage }}'
         is-asan: '${{ inputs.is-asan }}'
     - name: Set GN_EXTRA_ARGS for MAS Build

script/node-disabled-tests.json

@@ -19,6 +19,7 @@
   "parallel/test-crypto-padding-aes256",
   "parallel/test-crypto-secure-heap",
   "parallel/test-dgram-send-cb-quelches-error",
+  "parallel/test-domain-error-types",
   "parallel/test-fs-utimes-y2K38",
   "parallel/test-http2-clean-output",
   "parallel/test-http2-https-fallback.js",

spec/webview-spec.ts

@@ -1988,7 +1988,8 @@ describe('<webview> tag', function () {
     });
 
     ifdescribe(features.isPrintingEnabled())('<webview>.printToPDF()', () => {
-      it('rejects on incorrectly typed parameters', async () => {
+      // FIXME: This test is flaky on Linux x64 only in 29-x-y, skip it there.
+      ifit(process.platform !== 'linux' && process.arch !== 'x64')('rejects on incorrectly typed parameters', async () => {
         const badTypes = {
           landscape: [],
           displayHeaderFooter: '123',