github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: use RenderViewReady to call InstallTransparency (#24390)

Browse Source 
this fixes a crash with transparent OSR when GPU acceleration is
disabled
This commit is contained in:
Andy Dill
2020-07-06 11:57:14 -07:00
committed by GitHub
parent 99079c3bc7
commit cf74ee3d83
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
shell/browser/osr/osr_render_widget_host_view.cc
View File

@@ -222,7 +222,6 @@ OffScreenRenderWidgetHostView::OffScreenRenderWidgetHostView(
ResizeRootLayer(false);
render_widget_host_->SetView(this);
InstallTransparency();
if (content::GpuDataManager::GetInstance()->HardwareAccelerationEnabled()) {
video_consumer_ = std::make_unique<OffScreenVideoConsumer>(

5
shell/browser/osr/osr_web_contents_view.cc
View File

@@ -143,7 +143,10 @@ OffScreenWebContentsView::CreateViewForChildWidget(
void OffScreenWebContentsView::SetPageTitle(const base::string16& title) {}
void OffScreenWebContentsView::RenderViewReady() {}
void OffScreenWebContentsView::RenderViewReady() {
if (GetView())
GetView()->InstallTransparency();
}
void OffScreenWebContentsView::RenderViewHostChanged(
content::RenderViewHost* old_host,