github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix 'npm lint' errors

Browse Source
This commit is contained in:
Charles Kerr
2018-01-22 15:21:39 -06:00
parent e7074c5cdb
commit d2a9ea4684
2 changed files with 9 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
atom/app/atom_main.cc
View File

@@ -128,7 +128,7 @@ int APIENTRY wWinMain(HINSTANCE instance, HINSTANCE, wchar_t* cmd, int) {
return crash_service::Main(cmd);
}
if(!atom::CheckCommandLineArguments(arguments.argc, arguments.argv))
if (!atom::CheckCommandLineArguments(arguments.argc, arguments.argv))
return -1;
sandbox::SandboxInterfaceInfo sandbox_info = {0};

17
spec/api-app-spec.js
View File

@@ -499,15 +499,14 @@ describe('app module', function () {
})
describe('app launch through uri', () => {
before(function () {
if (process.platform !== 'win32') {
this.skip()
}
})
it('does not launch for blacklisted argument', function(done) {
const appPath = path.join(__dirname,'fixtures', 'api','quit-app')
it('does not launch for blacklisted argument', function (done) {
const appPath = path.join(__dirname, 'fixtures', 'api', 'quit-app')
// App should exit with non 123 code.
const first = ChildProcess.spawn(remote.process.execPath, [appPath, 'electron-test://?', '--no-sandbox', '--gpu-launcher=cmd.exe /c start calc'])
first.once('exit', (code) => {
@@ -516,8 +515,8 @@ describe('app module', function () {
})
})
it('launches successfully for multiple uris in cmd args', function(done) {
const appPath = path.join(__dirname,'fixtures', 'api','quit-app')
it('launches successfully for multiple uris in cmd args', function (done) {
const appPath = path.join(__dirname, 'fixtures', 'api', 'quit-app')
// App should exit with code 123.
const first = ChildProcess.spawn(remote.process.execPath, [appPath, 'http://electronjs.org', 'electron-test://testdata'])
first.once('exit', (code) => {
@@ -526,8 +525,8 @@ describe('app module', function () {
})
})
it('does not launch for encoded space', function(done) {
const appPath = path.join(__dirname,'fixtures', 'api','quit-app')
it('does not launch for encoded space', function (done) {
const appPath = path.join(__dirname, 'fixtures', 'api', 'quit-app')
// App should exit with non 123 code.
const first = ChildProcess.spawn(remote.process.execPath, [appPath, 'electron-test://?', '--no-sandbox', '--gpu-launcher%20"cmd.exe /c start calc'])
first.once('exit', (code) => {
@@ -536,8 +535,8 @@ describe('app module', function () {
})
})
it('launches successfully for argnames similar to blacklisted ones', function(done) {
const appPath = path.join(__dirname,'fixtures', 'api','quit-app')
it('launches successfully for argnames similar to blacklisted ones', function (done) {
const appPath = path.join(__dirname, 'fixtures', 'api', 'quit-app')
// inspect is blacklisted, but inspector should work, and app launch should succeed
const first = ChildProcess.spawn(remote.process.execPath, [appPath, 'electron-test://?', '--inspector'])
first.once('exit', (code) => {