test: skip methodswithdata-test.js nan test

.gitattributes

@@ -2,8 +2,6 @@
 # files to be checked out with LF endings even if core.autocrlf is true.
 *.patch text eol=lf
 patches/**/.patches merge=union
-# Target file for patch has CRLF line endings
-patches/nan/apply_allcan_read_write_test.patch eol=crlf
 
 # Source code and markdown files should always use LF as line ending.
 *.c text eol=lf

patches/nan/.patches

@@ -3,4 +3,3 @@ fix_define_nan_copyablepersistenttraits_for_v8_12_5.patch
 remove_deprecated_v8_isolate_idlenotificationdeadline.patch
 remove_several_apis_deprecated_in_version_12_6.patch
 apply_allcan_read_write.patch
-apply_allcan_read_write_test.patch

patches/nan/apply_allcan_read_write_test.patch

@@ -1,34 +0,0 @@
-From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
-From: Alice Zhao <alice@makenotion.com>
-Date: Thu, 20 Jun 2024 14:50:13 -0700
-Subject: test: patch CRLF test file for allcan_read_write patch
-
-Refs https://chromium-review.googlesource.com/c/v8/v8/+/5006387
-Should be upstreamed.
-
-This patch is seperated from the apply_allcan_read_write.patch
-because the file itself has CRLF line endings and need to be patched
-seperately. When this patch is removed, also remove the eol=crlf
-exception in .gitattributes.
-
-diff --git a/test/js/methodswithdata-test.js b/test/js/methodswithdata-test.js
-index 9f4fc5246f1ca3d8faadc9a72d49e14a6a190e32..795538510431fb3b633be37f916d4ce1955c808a 100644
---- a/test/js/methodswithdata-test.js
-+++ b/test/js/methodswithdata-test.js
-@@ -16,7 +16,7 @@ test('SetMethod with data', function (t) {
- });
- 
- test('accessors with data', function (t) {
--    t.plan(7)
-+    t.plan(6)
-     var settergetter = bindings.create()
-     t.equal(settergetter.prop1, 'this is property 1')
-     t.ok(settergetter.prop2 === '')
-@@ -33,6 +33,5 @@ test('accessors with data', function (t) {
-     t.equal(derived.prop1, 'this is property 1')
-     derived.prop2 = 'setting a new value'
-     t.equal(derived.prop2, 'setting a new value')
--    t.equal(settergetter.prop2, 'setting a new value')
-   })
-   
-\ No newline at end of file

script/nan-spec-runner.js

@@ -118,7 +118,9 @@ async function main () {
 
   const DISABLED_TESTS = new Set([
     'nannew-test.js',
-    'buffer-test.js'
+    'buffer-test.js',
+    // we can't patch this test because it uses CRLF line endings
+    'methodswithdata-test.js'
   ]);
   const testsToRun = fs.readdirSync(path.resolve(NAN_DIR, 'test', 'js'))
     .filter(test => !DISABLED_TESTS.has(test))