Memory safety

This commit is contained in:
Zhuo Lu
2018-05-08 14:59:08 -07:00
parent 79caff69f5
commit dd89aa6c77

View File

@@ -20,7 +20,7 @@ using content::BrowserThread;
namespace {
static NSMenu* applicationMenu_ = nil;
static scoped_nsobject<NSMenu> applicationMenu_;
} // namespace
@@ -146,7 +146,7 @@ void Menu::SetApplicationMenu(Menu* base_menu) {
[currentRunLoop cancelPerformSelector:@selector(setMainMenu:)
target:NSApp
argument:applicationMenu_];
applicationMenu_ = [menu_controller menu];
applicationMenu_.reset([[menu_controller menu] retain]);
[[NSRunLoop currentRunLoop]
performSelector:@selector(setMainMenu:)
target:NSApp