github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-08 23:18:06 -05:00
Code Issues Packages Projects Releases Wiki Activity

fixup advance deprecation of v8::ReturnValue<void>::Set(Local<S>)

Browse Source
This commit is contained in:
John Kleinschmidt
2025-12-01 12:06:06 -05:00
parent ece18acced
commit e5385b4155
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
patches/nan/chore_handle_deprecation_of_v8_returnvalue_void_set_local_s.patch
View File

@@ -8,10 +8,10 @@ v8::ReturnValue<void>::Set(Local<S>) is now deprecated.
See http://crbug.com/348660658 for details.
diff --git a/nan_callbacks_12_inl.h b/nan_callbacks_12_inl.h
index e40383c095ab329b2e20b7e68ade507788a79fb6..9688e933a7d8e31629b507def483024ba7705b26 100644
index e40383c095ab329b2e20b7e68ade507788a79fb6..24979fb0d66595f5e80f493c78291d6600bfc34a 100644
--- a/nan_callbacks_12_inl.h
+++ b/nan_callbacks_12_inl.h
@@ -26,7 +26,23 @@ class ReturnValue {
@@ -26,7 +26,24 @@ class ReturnValue {
// Handle setters
template <typename S> inline void Set(const v8::Local<S> &handle) {
TYPE_CHECK(T, S);
@@ -22,7 +22,8 @@ index e40383c095ab329b2e20b7e68ade507788a79fb6..9688e933a7d8e31629b507def483024b
+ // For V8 14.4.230+, avoid deprecated Set method for ReturnValue<void>
+ if constexpr (std::is_void_v<T>) {
+ if (handle.IsEmpty()) {
+ value_.SetDefaultValue();
+ // For void return type, do nothing to indicate success
+ // as per V8 deprecation guidance
+ } else {
+ value_.Set(handle->BooleanValue(value_.GetIsolate()));
+ }