mirror of
https://github.com/electron/electron.git
synced 2026-01-08 23:18:06 -05:00
chore: stop disabling kWinDelaySpellcheckServiceInit
[cleanup] Remove feature WinDelaySpellcheckServiceInit | https://chromium-review.googlesource.com/c/chromium/src/+/7012087 This flag has been removed upstream. We've used it sincec2d7164(#38248) to fix a crash originally described in97b353a(#34993): > Delaying spell check initialization is causing specs for > 'custom dictionary word list API' to fail in Electron. Since we haven't touched this in a few years, and since there's a clear success criteria (a passing/failing spec), and since the patch to restore this flag would be pretty large (~750 lines), I'm going to try just removing the flag from our source to see if the spec passes or fails.
This commit is contained in:
@@ -10,7 +10,6 @@
|
||||
#include "base/command_line.h"
|
||||
#include "base/feature_list.h"
|
||||
#include "base/metrics/field_trial.h"
|
||||
#include "components/spellcheck/common/spellcheck_features.h"
|
||||
#include "content/common/features.h"
|
||||
#include "content/public/common/content_features.h"
|
||||
#include "electron/buildflags/buildflags.h"
|
||||
@@ -64,10 +63,6 @@ void InitializeFeatureList() {
|
||||
std::string(",") + network::features::kLocalNetworkAccessChecks.name;
|
||||
|
||||
#if BUILDFLAG(IS_WIN)
|
||||
disable_features +=
|
||||
// Delayed spellcheck initialization is causing the
|
||||
// 'custom dictionary word list API' spec to crash.
|
||||
std::string(",") + spellcheck::kWinDelaySpellcheckServiceInit.name;
|
||||
// Refs https://issues.chromium.org/issues/401996981
|
||||
// TODO(deepak1556): Remove this once test added in
|
||||
// https://github.com/electron/electron/pull/12904
|
||||
|
||||
Reference in New Issue
Block a user