github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-09 15:38:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

chore: stop disabling kWinDelaySpellcheckServiceInit

Browse Source 
[cleanup] Remove feature WinDelaySpellcheckServiceInit | https://chromium-review.googlesource.com/c/chromium/src/+/7012087

This flag has been removed upstream. We've used it since c2d7164 (#38248)
to fix a crash originally described in 97b353a (#34993):

> Delaying spell check initialization is causing specs for
> 'custom dictionary word list API' to fail in Electron.

Since we haven't touched this in a few years, and since there's a
clear success criteria (a passing/failing spec), and since the patch
to restore this flag would be pretty large (~750 lines), I'm going
to try just removing the flag from our source to see if the spec
passes or fails.
This commit is contained in:
Charles Kerr
2025-10-21 21:49:06 -05:00
parent 93d53b9ad4
commit e688880396
1 changed files with 0 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
shell/browser/feature_list.cc
View File

@@ -10,7 +10,6 @@
#include "base/command_line.h" #include "base/command_line.h"
#include "base/feature_list.h" #include "base/feature_list.h"
#include "base/metrics/field_trial.h" #include "base/metrics/field_trial.h"
#include "components/spellcheck/common/spellcheck_features.h"
#include "content/common/features.h" #include "content/common/features.h"
#include "content/public/common/content_features.h" #include "content/public/common/content_features.h"
#include "electron/buildflags/buildflags.h" #include "electron/buildflags/buildflags.h"
@@ -64,10 +63,6 @@ void InitializeFeatureList() {
std::string(",") + network::features::kLocalNetworkAccessChecks.name; std::string(",") + network::features::kLocalNetworkAccessChecks.name;
#if BUILDFLAG(IS_WIN) #if BUILDFLAG(IS_WIN)
disable_features +=
// Delayed spellcheck initialization is causing the
// 'custom dictionary word list API' spec to crash.
std::string(",") + spellcheck::kWinDelaySpellcheckServiceInit.name;
// Refs https://issues.chromium.org/issues/401996981 // Refs https://issues.chromium.org/issues/401996981
// TODO(deepak1556): Remove this once test added in // TODO(deepak1556): Remove this once test added in
// https://github.com/electron/electron/pull/12904 // https://github.com/electron/electron/pull/12904