github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

chore: change some for loops to range-based (#26264)

Browse Source
This commit is contained in:
David Sanders
2020-10-29 20:51:59 -07:00
committed by GitHub
parent a9b1f2fd0e
commit e6b24a21e4
5 changed files with 11 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
chromium_src/chrome/browser/process_singleton_posix.cc
View File

@@ -827,10 +827,9 @@ ProcessSingleton::NotifyResult ProcessSingleton::NotifyOtherProcessWithTimeout(
to_send.append(current_dir.value());
const std::vector<std::string>& argv = electron::ElectronCommandLine::argv();
for (std::vector<std::string>::const_iterator it = argv.begin();
it != argv.end(); ++it) {
for (const auto& arg : argv) {
to_send.push_back(kTokenDelimiter);
to_send.append(*it);
to_send.append(arg);
}
// Send the message

5
chromium_src/chrome/browser/ui/views/frame/global_menu_bar_registrar_x11.cc
View File

@@ -122,8 +122,7 @@ void GlobalMenuBarRegistrarX11::OnNameOwnerChanged(GObject* /* ignored */,
GParamSpec* /* ignored */) {
// If the name owner changed, we need to reregister all the live xids with
// the system.
for (std::set<unsigned long>::const_iterator it = live_xids_.begin();
it != live_xids_.end(); ++it) {
RegisterXID(*it);
for (auto xid : live_xids_) {
RegisterXID(xid);
}
}

6
shell/browser/api/electron_api_app.cc
View File

@@ -487,10 +487,10 @@ void OnClientCertificateSelected(
data.c_str(), data.length(), net::X509Certificate::FORMAT_AUTO);
if (!certs.empty()) {
scoped_refptr<net::X509Certificate> cert(certs[0].get());
for (size_t i = 0; i < identities->size(); ++i) {
if (cert->EqualsExcludingChain((*identities)[i]->certificate())) {
for (auto& identity : *identities) {
if (cert->EqualsExcludingChain(identity->certificate())) {
net::ClientCertIdentity::SelfOwningAcquirePrivateKey(
std::move((*identities)[i]),
std::move(identity),
base::BindRepeating(&GotPrivateKey, delegate, std::move(cert)));
break;
}

6
shell/common/api/electron_api_v8_util.cc
View File

@@ -127,9 +127,9 @@ void ClearWeaklyTrackedValues() {
std::vector<v8::Local<v8::Value>> GetWeaklyTrackedValues(v8::Isolate* isolate) {
std::vector<v8::Local<v8::Value>> locals;
for (size_t i = 0; i < weakly_tracked_values.size(); i++) {
if (!weakly_tracked_values[i].IsEmpty())
locals.push_back(weakly_tracked_values[i].Get(isolate));
for (const auto& value : weakly_tracked_values) {
if (!value.IsEmpty())
locals.push_back(value.Get(isolate));
}
return locals;
}

5
shell/common/api/electron_bindings.cc
View File

@@ -135,10 +135,7 @@ void ElectronBindings::ActivateUVLoop(v8::Isolate* isolate) {
// static
void ElectronBindings::OnCallNextTick(uv_async_t* handle) {
auto* self = static_cast<ElectronBindings*>(handle->data);
for (std::list<node::Environment*>::const_iterator it =
self->pending_next_ticks_.begin();
it != self->pending_next_ticks_.end(); ++it) {
node::Environment* env = *it;
for (auto* env : self->pending_next_ticks_) {
gin_helper::Locker locker(env->isolate());
v8::Context::Scope context_scope(env->context());
node::InternalCallbackScope scope(