fix remote setInterval flake (#12265)

This commit is contained in:
Samuel Attard
2018-03-14 15:42:44 +09:00
committed by Charles Kerr
parent c00b1ac669
commit e8a7cc576e

View File

@@ -183,10 +183,17 @@ describe('node feature', () => {
describe('setInterval called under Chromium event loop in browser process', () => {
it('can be scheduled in time', (done) => {
let clear
let interval
clear = () => {
let interval = null
let clearing = false
const clear = () => {
if (interval === null || clearing) {
return
}
// interval might trigger while clearing (remote is slow sometimes)
clearing = true
remote.getGlobal('clearInterval')(interval)
clearing = false
interval = null
done()
}
interval = remote.getGlobal('setInterval')(clear, 10)