github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

refactor: use span instead of node::Buffer::Length() in NodeStreamLoader::ReadMore()

Browse Source
This commit is contained in:
Charles Kerr
2024-10-14 22:48:51 -05:00
parent 9ecb848c67
commit ebae57f183
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
shell/browser/net/node_stream_loader.cc
View File

@@ -10,6 +10,7 @@
#include "mojo/public/cpp/system/string_data_source.h"
#include "shell/common/gin_converters/callback_converter.h"
#include "shell/common/node_includes.h"
#include "shell/common/node_util.h"
namespace electron {
@@ -138,14 +139,14 @@ void NodeStreamLoader::ReadMore() {
// Hold the buffer until the write is done.
buffer_.Reset(isolate_, buffer);
bytes_written_ += node::Buffer::Length(buffer);
const auto buffer_span = electron::util::as_byte_span(buffer);
bytes_written_ += buffer_span.size();
// Write buffer to mojo pipe asynchronously.
is_reading_ = false;
is_writing_ = true;
producer_->Write(std::make_unique<mojo::StringDataSource>(
std::string_view{node::Buffer::Data(buffer),
node::Buffer::Length(buffer)},
base::as_chars(buffer_span),
mojo::StringDataSource::AsyncWritingMode::
STRING_STAYS_VALID_UNTIL_COMPLETION),
base::BindOnce(&NodeStreamLoader::DidWrite, weak));