github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-27 08:18:28 -05:00
Code Issues Packages Projects Releases Wiki Activity

Unsubscribe from NSNotificationCenter when WebContents is destroyed

Browse Source 
Due to ref-counted references the NSView is not destroyed immediately
when WebContents is destroyed, so it is not reliable to do this in
the destructor.
This commit is contained in:
Cheng Zhao
2015-09-17 11:19:08 +08:00
parent fa588f104c
commit fc33eb99f7
3 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
brightray/browser/inspectable_web_contents_view_mac.mm
View File

@@ -19,6 +19,7 @@ InspectableWebContentsViewMac::InspectableWebContentsViewMac(InspectableWebConte
}
InspectableWebContentsViewMac::~InspectableWebContentsViewMac() {
[view_ removeObservers];
CloseDevTools();
}

1
brightray/browser/mac/bry_inspectable_web_contents_view.h
View File

@@ -24,6 +24,7 @@ using brightray::InspectableWebContentsViewMac;
}
- (instancetype)initWithInspectableWebContentsViewMac:(InspectableWebContentsViewMac*)view;
- (void)removeObservers;
- (void)notifyDevToolsFocused;
- (void)setDevToolsVisible:(BOOL)visible;
- (BOOL)isDevToolsVisible;

3
brightray/browser/mac/bry_inspectable_web_contents_view.mm
View File

@@ -45,9 +45,8 @@ using namespace brightray;
return self;
}
- (void)dealloc {
- (void)removeObservers {
[[NSNotificationCenter defaultCenter] removeObserver:self];
[super dealloc];
}
- (void)resizeSubviewsWithOldSize:(NSSize)oldBoundsSize {