github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

refactor: remove unused gin_helper::WrappableBase::GetWrapper(v8::Isolate*) (#45809)

Browse Source 
refactor: remove unused EventEmitter::GetWrapper(v8::Isolate*)

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
This commit is contained in:
trop[bot]
2025-02-25 22:51:17 -06:00
committed by GitHub
parent 3225fd9af5
commit ff3793aa71
2 changed files with 0 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
shell/common/gin_helper/wrappable.cc
View File

@@ -30,14 +30,6 @@ v8::Local<v8::Object> WrappableBase::GetWrapper() const {
return {};
}
v8::MaybeLocal<v8::Object> WrappableBase::GetWrapper(
v8::Isolate* isolate) const {
if (!wrapper_.IsEmpty())
return {v8::Local<v8::Object>::New(isolate, wrapper_)};
else
return {};
}
void WrappableBase::InitWithArgs(gin::Arguments* args) {
v8::Local<v8::Object> holder;
args->GetHolder(&holder);

1
shell/common/gin_helper/wrappable_base.h
View File

@@ -39,7 +39,6 @@ class WrappableBase {
// Retrieve the v8 wrapper object corresponding to this object.
v8::Local<v8::Object> GetWrapper() const;
v8::MaybeLocal<v8::Object> GetWrapper(v8::Isolate* isolate) const;
// Returns the Isolate this object is created in.
v8::Isolate* isolate() const { return isolate_; }