`chrome://flash` doesn't seem to exist anymore, but similar information
appears at `chrome://version`.
Co-authored-by: Joe Duncko <JoeDuncko@users.noreply.github.com>
* fix: prevent destroyed view references from causing crashes
* Remove extraneous comments
* Relocate crash test to proper location
* Add WebContentsObserver
* Add nullptr check and inspectable observer
* Remote initial test file
* Add test cases to test file
* Rename and move testing file
* Fix linting errors
* Make functions exit early on check
* Fix setBackgroundColor function call in test file
* Fix styling of test file
* Fix mac name mismatch and make variable name more clear
Co-authored-by: Michaela Laurencin <mlaurencin@microsoft.com>
* fix: call node::Stop on exit
* also call Stop in node_main
* oop, we were already calling set_can_call_into_js(false)??
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
* Ensure electron delay loads the appropriate modules as chromium on windows
This change adds the same module delay load list that chromium uses for electron. Some modules were already getting delay loaded from other build files in chromium but not the main list via //build/config/win:delayloads. We do not include the list of delay loads in delayloads_not_for_child_dll as those have issues being loaded in sandboxes processes. This will reduce the overall reference set impact of the electron processes.
* fix: Ensure win modules are properly delayloaded
* chore: fix linting
Co-authored-by: Chris Davis <chrisdavis@outlook.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
refactor(extensions): remove unused InitWithBrowserContext method
fix(extensions): release background page WebContents to avoid crash
The background page WebContents instance is managed by the ExtensionHost.
fix(extensions): open background page devtools detached by default
test(extensions): add background page devtools test
chore: test fix for null web_contents()
fix: close background page devtools in test after opening
Co-authored-by: samuelmaddock <samuel.maddock@gmail.com>
* chore: graceful handling of notes with sub-lists
Handle multine release notes that contain their own bullet points.
Also, if a release note begins with a bullet point, remove it because it
will confuse the markdown parser to have two bullet points.
* chore: make lint happy
* test: add tests for release note changes
* chore: only target current octokit
* chore: add commits to release-notes test cache
No behavior change; just includes files that ought to be cached to prevent
hitting octokit for them.
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* ci: cleanup up test app directories
* ci: use electron prefix for a testing apps so that the can be cleaned up
* Revert "ci: cleanup up test app directories"
This reverts commit a47daba812.
* fixup test due to app name change
Co-authored-by: John Kleinschmidt <jkleinsc@github.com>
