Shelley Vohr
13e84e6868
fix: abort more descriptively for beforeunload ( #48960 )
2025-11-18 12:16:08 -05:00
Charles Kerr
519187db1d
refactor: decouple api::WebRequest from api::BrowserContext ( #48848 )
...
* refactor: rename api::Session::CreateFrom() to api::Session::FromOrCreate()
This is both clearer and more consistent with other classes
* refactor: add Session::FromOrCreate(content::BrowserContext*)
* refactor: reimplement api::WebRequest::FromOrCreate() using api::Session::FromOrCreate()
* refactor: use base::PassKey to ensure WebRequest is only instantiated by Session
* refactor: remove WebRequest::From()
no longer needed; Session already guarantees uniqueness
* refactor: remove unused isolate arg from WebRequest ctor
* refactor: do not attach WebRequest to BrowserContext
no longer needed now that access goes through Session
2025-11-09 08:07:25 -06:00
electron-roller[bot]
595920a308
chore: bump chromium to 144.0.7512.1 (main) ( #48768 )
...
* chore: bump chromium in DEPS to 144.0.7507.0
* chore: bump chromium in DEPS to 144.0.7508.0
* chore: update patches
* 7101838: [pathbuilder] Enforce immutable SkPath APIs globally
https://chromium-review.googlesource.com/c/chromium/src/+/7101838
* chore: update filenames.libcxx.gni
* [pathbuilder] Enforce immutable SkPath APIs globally
https://chromium-review.googlesource.com/c/chromium/src/+/7101838
* Reduce service_worker_info.h includes in headers
https://chromium-review.googlesource.com/c/chromium/src/+/7108401
* chore: bump chromium in DEPS to 144.0.7510.0
* chore: update patches
* Use internal popup menus for tabs in actor-controlled states
https://chromium-review.googlesource.com/c/chromium/src/+/7074751
* [api] Delete deprecated fields on v8::Isolate
https://chromium-review.googlesource.com/c/v8/v8/+/7081397
xref: 98d243aea0
* Fixup Reduce service_worker_info.h includes in headers
* Promote deprecation of v8::Context and v8::Object API methods
https://chromium-review.googlesource.com/c/v8/v8/+/7087956
* fixup Promote deprecation of v8::Context and v8::Object API methods
* chore: bump chromium in DEPS to 144.0.7512.1
* chore: update patches
* fixup [pathbuilder] Enforce immutable SkPath APIs global
* chore: update filenames.hunspell.gni
* fix deprecation of v8::Context and v8::Object API methods for nan
https://chromium-review.googlesource.com/c/v8/v8/+/7087956
* [PDF] Implement PdfHelpBubbleHandlerFactory
https://chromium-review.googlesource.com/c/chromium/src/+/7056325
also: [PDF Ink Signatures] Hook up IPH
https://chromium-review.googlesource.com/c/chromium/src/+/7056207
* Remove base/hash/md5.h
https://chromium-review.googlesource.com/c/chromium/src/+/7113738
* fixup for lint
* Remove deprecated interceptor callback types and AccessControl enum
https://chromium-review.googlesource.com/c/v8/v8/+/7112747
* fixup for lint
* fixup [PDF] Implement PdfHelpBubbleHandlerFactory
* use base::SHA1HashString instead of std::hash
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-11-07 10:13:45 -05:00
electron-roller[bot]
9235dc0159
chore: bump chromium to 143.0.7485.0 (main) ( #48618 )
...
* chore: bump chromium in DEPS to 143.0.7485.0
* chore: update allow_disabling_blink_scheduler_throttling_per_renderview.patch
Move SetSupportsDraggableRegions mojom IPC from chrome/ and extensions/ to blink/ | https://chromium-review.googlesource.com/c/chromium/src/+/7043264
Patch applied manually due to context shear
* Move SetSupportsDraggableRegions mojom IPC from chrome/ and extensions/ to blink/ | https://chromium-review.googlesource.com/c/chromium/src/+/7043264
* chore: e patches all
* chore: check for file existence before setting utime
* chore: stop disabling kWinDelaySpellcheckServiceInit
[cleanup] Remove feature WinDelaySpellcheckServiceInit | https://chromium-review.googlesource.com/c/chromium/src/+/7012087
This flag has been removed upstream. We've used it since c2d7164 (#38248 )
to fix a crash originally described in 97b353a (#34993 ):
> Delaying spell check initialization is causing specs for
> 'custom dictionary word list API' to fail in Electron.
Since we haven't touched this in a few years, and since there's a
clear success criteria (a passing/failing spec), and since the patch
to restore this flag would be pretty large (~750 lines), I'm going
to try just removing the flag from our source to see if the spec
passes or fails.
* Revert "chore: stop disabling kWinDelaySpellcheckServiceInit"
This reverts commit e688880396 .
Unfortunately, the crash persists.
* Revert [cleanup] Remove feature WinDelaySpellcheckServiceInit | https://chromium-review.googlesource.com/c/chromium/src/+/7012087
We currently need this feature
* fixup! chore: check for file existence before setting utime
* fixup! Move SetSupportsDraggableRegions mojom IPC from chrome/ and extensions/ to blink/ | https://chromium-review.googlesource.com/c/chromium/src/+/7043264
Address Robo's code review @ 64c7fd21ed
* fixup! fixup! chore: check for file existence before setting utime
fix: oops typo
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-10-23 08:30:29 -05:00
electron-roller[bot]
00a3031357
chore: bump chromium to 143.0.7483.0 (main) ( #48590 )
...
* chore: bump chromium in DEPS to 143.0.7482.0
* chore: bump chromium in DEPS to 143.0.7483.0
* [CodeHealth] Remove RenderWidgetHostImpl::is_hidden() | https://chromium-review.googlesource.com/c/chromium/src/+/7050059
* chore: update mas_avoid_private_macos_api_usage.patch.patch
[graphite] Refactor backpressure fences on Mac to avoid GLContext | https://chromium-review.googlesource.com/c/chromium/src/+/7047167
* chore: update disable_compositor_recycling.patch
no manual changes; patch applied with fuzz
[CodeHealth] Remove RenderWidgetHostImpl::is_hidden() | https://chromium-review.googlesource.com/c/chromium/src/+/7050059
* chore: update allow_disabling_blink_scheduler_throttling_per_renderview.patch
[CodeHealth] Remove RenderWidgetHostImpl::is_hidden() | https://chromium-review.googlesource.com/c/chromium/src/+/7050059
* chore: update feat_allow_code_cache_in_custom_schemes.patch
[url] Change Add*Scheme*(...) functions to accept std::string_view | https://chromium-review.googlesource.com/c/chromium/src/+/7046471
* chore: e patches all
* [memory] Replace bool success with MemoryDumpRequestOutcome enum. | https://chromium-review.googlesource.com/c/chromium/src/+/7029767
* [CodeHealth] Remove RenderWidgetHostImpl::is_hidden() | https://chromium-review.googlesource.com/c/chromium/src/+/7050059
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-10-21 08:11:09 -05:00
electron-roller[bot]
471a14432f
chore: bump chromium to 143.0.7469.0 (main) ( #48548 )
...
* chore: bump chromium in DEPS to 143.0.7469.0
* 7021651: [//gpu] Fold handle creation into D3DImageBackingFactory
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7021651
* 7013047: Fix various C++23 build errors in //chrome
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7013047
* 7010850: [//ui] Port screen_mac.mm's calls to DisplayColorSpaces
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7010850
* 7007933: Remove superfluous mojom includes in //content/public headers
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7007933
* 7023196: Trim os_crypt/sync visibility list
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7023196
* 7008912: Remove GURL::*_piece() method
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7008912
* 7003989: Add wrapper struct for CopyFromSurface output
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7003989
* 7017889: [MemoryPressureListener] Remove type aliases
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7017889
* 7027780: Delete viz::ResourceSizes
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7027780
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6989572
* 6495189: [api] Delete old String::Write* APIs
Refs https://chromium-review.googlesource.com/c/v8/v8/+/6495189
* chore: update patches
* chore: run script/gen-libc++-filenames.js
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2025-10-15 14:10:10 -07:00
electron-roller[bot]
d920c82fc4
chore: bump chromium to 143.0.7451.0 (main) ( #48362 )
...
* chore: bump chromium in DEPS to 142.0.7429.0
* chore: bump chromium in DEPS to 142.0.7430.0
* 6954508: Reland Migrate WrappableWithNamedPropertyInterceptor to gin::Wrappable | https://chromium-review.googlesource.com/c/chromium/src/+/6954508
* https://chromium-review.googlesource.com/c/chromium/src/+/6955633
* 5584820: Fix font face resolution when renderer is blocked | https://chromium-review.googlesource.com/c/chromium/src/+/5584820
* chore: export patches
* chore: remove patch that keeley says is ok to remove in comments
* chore: bump chromium in DEPS to 142.0.7432.0
* chore: export patches
* chore: bump chromium in DEPS to 142.0.7434.0
* 6973697: Use type tags for data stored in V8 internal fields | https://chromium-review.googlesource.com/c/chromium/src/+/6973697
* 6976272: Revert Reland mac: click through content area in main window | https://chromium-review.googlesource.com/c/chromium/src/+/6976272
* chore: export patches
* 6938086: Rename native_widget_types.h -> native_ui_types.h | https://chromium-review.googlesource.com/c/chromium/src/+/6938086
* 6951252: Correct PersistentCache backed code cache context grouping
* chore: bump chromium in DEPS to 142.0.7436.0
* 6981628: Reland Use unordered_map in AcceleratorMap | https://chromium-review.googlesource.com/c/chromium/src/+/6981628
* chore: export patches
* chore: resolve patch conflict with main
* chore: merge conflict with main
* chore: bump chromium in DEPS to 142.0.7438.0
* chore: bump chromium in DEPS to 142.0.7440.0
* chore: bump chromium in DEPS to 142.0.7442.0
* chore: bump chromium in DEPS to 142.0.7444.0
* chore: bump chromium in DEPS to 143.0.7445.0
* chore: bump chromium in DEPS to 143.0.7447.0
* chore: bump chromium in DEPS to 143.0.7449.0
* chore: bump chromium in DEPS to 143.0.7451.0
* 7001364: Migrate GURL accessors to Get* variants in //content | https://chromium-review.googlesource.com/c/chromium/src/+/7001364
* 6986521: Implicit second value 'any' instead of 'span-all' for fallback query | https://chromium-review.googlesource.com/c/chromium/src/+/6986521
* chore: update chromium patches
* chore: update chromium patches
* chore: update patches
* fix: parse macOS SDK version across line break
https://chromium-review.googlesource.com/c/chromium/src/+/6980166
* fix: replace v8::Object::SetPrototype() usage
https://chromium-review.googlesource.com/c/v8/v8/+/6983465
https://github.com/nodejs/node/pull/55453
* fix: regenerate filenames.libcxx.gni
https://chromium-review.googlesource.com/c/chromium/src/+/6980307
* fix: replace additional usages of SetPrototype
https://chromium-review.googlesource.com/c/v8/v8/+/6983465
* build: use macos 15 minimum
https://chromium-review.googlesource.com/c/chromium/src/+/6980166
* ci: ignore missing dir for strip_universal_deep
* fix: js2c compilation failure
https://chromium-review.googlesource.com/c/chromium/src/+/6950738
See patch description explaining MacOS 26 SDK headers incompatibility.
* fixup! chore: export patches
* feat: add new memory-eviction exit reason
https://chromium-review.googlesource.com/c/chromium/src/+/6991933
* fix: set JSON reader parsing options
https://chromium-review.googlesource.com/c/chromium/src/+/6992114
* fix: provide DeviceEmulationCacheBehavior param
https://chromium-review.googlesource.com/c/chromium/src/+/6965238
* fix: views::NonClientFrameView -> views::FrameView
https://chromium-review.googlesource.com/c/chromium/src/+/7005027
https://chromium-review.googlesource.com/c/chromium/src/+/6966937
* fix: check new forced colors enum value
https://chromium-review.googlesource.com/c/chromium/src/+/6944403
* fix: migrate NetworkConditions -> MatchedNetworkConditions
https://chromium-review.googlesource.com/c/chromium/src/+/6827307
* fix: migrate GURL string methods to Get*()
https://chromium-review.googlesource.com/c/chromium/src/+/7007010
* fix: disable C++ modules in electron_lib builds
https://chromium-review.googlesource.com/c/chromium/src/+/6950738
* fix: partially revert is_headless_mode removal
https://chromium-review.googlesource.com/c/chromium/src/+/6955633
This patch should likely be reworked. For now, this partially reverts the
removal of a required class property to restore behavior.
* Revert "build: use macos 15 minimum"
This reverts commit 2fc12d6acc .
Initially this change was made to test if it fixes libcxx
compilation issues. As that's now resolved by disabling libcxx
modules, this can be reverted.
* fix: disable C++ modules in libnode builds
* fixup! fix: replace v8::Object::SetPrototype() usage https://chromium-review.googlesource.com/c/v8/v8/+/6983465 https://github.com/nodejs/node/pull/55453
* fixup! fix: replace v8::Object::SetPrototype() usage https://chromium-review.googlesource.com/c/v8/v8/+/6983465 https://github.com/nodejs/node/pull/55453
* build: switch to macos-15 runner
build/mac/find_sdk.py now requires macOS 15 SDK as a minimum version. The
macos 15 runners default to an Xcode using the 15 SDK and removes older
versions.
* fixup! fix: check new forced colors enum value https://chromium-review.googlesource.com/c/chromium/src/+/6944403
* fixup! fix: migrate GURL string methods to Get*() https://chromium-review.googlesource.com/c/chromium/src/+/7007010
* fix: use std::u16string for Extension::Create() error parameter
https://chromium-review.googlesource.com/c/chromium/src/+/6975452
* fix: add missing image_skia include
https://chromium-review.googlesource.com/c/chromium/src/+/6986762
* fixup! fix: add missing image_skia include https://chromium-review.googlesource.com/c/chromium/src/+/6986762
* fix: remove outdated V8 flag
https://chromium-review.googlesource.com/c/v8/v8/+/6948286
* fix: disable protocol handler DCHECK
https://chromium-review.googlesource.com/c/chromium/src/+/6727594
Ignore the extension custom protocol handler registry DCHECK until
we invest in supporting it. Replacing this DCHECK seems harmless
and will unblock the roll.
* fix: replace deprecated usage of SetPrototype
https://chromium-review.googlesource.com/c/v8/v8/+/6983465
* fixup! fix: migrate NetworkConditions -> MatchedNetworkConditions https://chromium-review.googlesource.com/c/chromium/src/+/6827307
* fixup! fix: migrate GURL string methods to Get*() https://chromium-review.googlesource.com/c/chromium/src/+/7007010
* chore: remove patch already included in roll
* chore: remove extraneous formatting added to patch
* chore: remove fix_harden_blink_scriptstate_maybefrom.patch
https://chromium-review.googlesource.com/c/chromium/src/+/6973697
No longer needed since the above CL landed.
* 6973697: Use type tags for data stored in V8 internal fields
https://chromium-review.googlesource.com/c/chromium/src/+/6973697
* chore: update patches
* fixup! chore: export patches
* chore: restore electron embedder data tag patch
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Alice Zhao <alicelovescake@anthropic.com >
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-10-13 12:21:54 -04:00
reito
9e46efb8f7
feat: offscreen rendering support rgbaf16 hdr output format. ( #48265 )
...
* feat: offscreen rendering support rgbaf16
* docs: update doc
* docs: update doc.
2025-10-09 10:33:34 +02:00
Charles Kerr
6661457cdf
refactor: prefer upstream gin::Arguments::ThrowTypeError() over gin_helper ( #48368 )
...
* refactor: use gin::Arguments::ThrowTypeError() in AutoUpdater::SetFeedURL()
* refactor: use gin::Arguments::ThrowTypeError() in Browser::Focus()
* refactor: use gin::Arguments::ThrowTypeError() in SystemPreferences::SetUserDefault()
* refactor: use gin::Arguments::ThrowTypeError() in UtilityProcessWrapper::Create()
* refactor: use gin::Arguments::ThrowTypeError() in UtilityProcessWrapper::PostMessage()
* refactor: use gin::Arguments::ThrowTypeError() in ElectronBundleMover::ShouldContinueMove()
* refactor: use gin::Arguments::ThrowTypeError() in OnClientCertificateSelected()
* refactor: use gin::Arguments::ThrowTypeError() in Session::ClearData()
* refactor: use gin::Arguments::ThrowTypeError() in ElectronBrowserContext::DisplayMediaDeviceChosen()
* refactor: use gin::Arguments::ThrowTypeError() in WebContents::ReplaceMisspelling()
* refactor: use gin::Arguments::ThrowTypeError() in WebContents::Print()
* chore: iwyu shell/common/gin_helper/error_thrower.h
2025-09-24 19:10:05 -05:00
electron-roller[bot]
1fda08b8c8
chore: bump chromium to 142.0.7417.0 (main) ( #48275 )
...
* chore: bump chromium in DEPS to 142.0.7401.0
* 6911185: Reland "Send touch moves async immediately after scroll starts."
https://chromium-review.googlesource.com/c/chromium/src/+/6911185
* 6906887: mac: click through content area in main window
https://chromium-review.googlesource.com/c/chromium/src/+/6906887
* 6916667: Expose helper to eliminate duplicate recipes.
https://chromium-review.googlesource.com/c/chromium/src/+/6916667
* 6909842: Switch LegacyRenderWidgetHostHWND from atlcrack.h to msg_util.h.
https://chromium-review.googlesource.com/c/chromium/src/+/6909842
* 6884056: Remove the SecKeychain implementation for the Keychain interface
https://chromium-review.googlesource.com/c/chromium/src/+/6884056
* 6904906: Remove `WTF::` in renderer/core/[p-x].*/
https://chromium-review.googlesource.com/c/chromium/src/+/6904906
* 6556585: [persistent_cache]: PersistentCache for CodeCache
https://chromium-review.googlesource.com/c/chromium/src/+/6556585
* 6904864: Layout: Support abort on the text placeholder layout
https://chromium-review.googlesource.com/c/chromium/src/+/6904864
* chore: fixup patch indices
* chore: bump chromium in DEPS to 142.0.7402.0
* fixup! 6556585: [persistent_cache]: PersistentCache for CodeCache
* chore: fixup patch indices
* 6905244: [api] Remove deprecated `GetIsolate`
https://chromium-review.googlesource.com/c/v8/v8/+/6905244
* 6897694: Remove NativeTheme::UserHasContrastPreference().
https://chromium-review.googlesource.com/c/chromium/src/+/6897694
* 6897477: Remove GetPlatformHighContrastColorScheme() and enum.
https://chromium-review.googlesource.com/c/chromium/src/+/6897477
* 6918198: Reland "Rename display::Screen::GetScreen() to display::Screen::Get()"
https://chromium-review.googlesource.com/c/chromium/src/+/6918198
* 6907147: [LNA] add use counter for websocket mixed-content issues
https://chromium-review.googlesource.com/c/chromium/src/+/6907147
* 6914538: Replace WTF::String with blink::String
https://chromium-review.googlesource.com/c/website/+/6914538
* 6892538: [video pip] Allow touchscreen users to toggle live caption
https://chromium-review.googlesource.com/c/chromium/src/+/6892538
* chore: fix patch
* chore: bump chromium in DEPS to 142.0.7403.0
* build: remove ninja logs
* chore: fixup patch indices
* 6920670: [PDF] Change pdf_extension_util to return dictionaries
https://chromium-review.googlesource.com/c/chromium/src/+/6920670
* 6917864: Devirtualize and inline various NativeTheme getters.
https://chromium-review.googlesource.com/c/chromium/src/+/6917864
* 6920873: [PDF] Simplify PDFDocumentHelperClient::OnSaveURL()
https://chromium-review.googlesource.com/c/chromium/src/+/6920873
* build: don't kill blink/web_tests
* 6923655: Roll libc++ from 954086abf121 to b87b2bb112f8 (4 revisions)
https://chromium-review.googlesource.com/c/chromium/src/+/6923655
* 6905242: Reland "[CSP] Clarify report-only console messages."
https://chromium-review.googlesource.com/c/chromium/src/+/6905242
* fixup! 6897694: Remove NativeTheme::UserHasContrastPreference().
* chore: bump chromium in DEPS to 142.0.7405.0
* 6910012: [LNA] Enable LNA enforcement by default
https://chromium-review.googlesource.com/c/chromium/src/+/6910012
* 6929444: Combine GetInstanceForXXX() implementations.
https://chromium-review.googlesource.com/c/chromium/src/+/6929444
* 6927873: Rename native_widget_types.h -> native_ui_types.h
https://chromium-review.googlesource.com/c/chromium/src/+/6927873
* 6853978: Init perfetto really early in WebView
https://chromium-review.googlesource.com/c/chromium/src/+/6853978
* 6874886: Use only one picker observer to avoid getting duplicate notifications
https://chromium-review.googlesource.com/c/chromium/src/+/6874886
* chore: fixup patch indices
* fix: Protocol complex inline dtor
* chore: bump chromium in DEPS to 142.0.7407.0
* chore: bump chromium in DEPS to 142.0.7409.0
* chore: bump chromium in DEPS to 142.0.7411.0
* chore: bump chromium in DEPS to 142.0.7413.0
* fixup! 6905242: Reland "[CSP] Clarify report-only console messages."
* 6927233: Remove NativeTheme "use dark colors" bit.
https://chromium-review.googlesource.com/c/chromium/src/+/6927233
* chore: fixup patch indices
* 6899206: [PermissionOptions] Multi-state permission subscriptions & setting changes
https://chromium-review.googlesource.com/c/chromium/src/+/6899206
* chore: bump chromium in DEPS to 142.0.7415.0
* 6936895: [headless] Remove headless flag from views::Widget class
https://chromium-review.googlesource.com/c/chromium/src/+/6936895
We should probably followup on this to see if there is a way to do this without reverting this CL.
* 6937023: Reland "Use new DBus type system in dbus_xdg::Request"
https://chromium-review.googlesource.com/c/chromium/src/+/6937023
* chore: update patches
* 6944749: Add GN visibility list to //components/os_crypt/sync
https://chromium-review.googlesource.com/c/chromium/src/+/6944749
* Further replace sub_capture_target_version with CaptureVersion
https://chromium-review.googlesource.com/c/chromium/src/+/6935455
* fixup for lint
* chore: update filenames.libcxx.gni
* chore: bump chromium in DEPS to 142.0.7417.0
* 6944136: Reorder NativeTheme headers/.cc files.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6944136
* 6939701: [DSSC][4] Make FSVCI objects aware of their capture-version-source
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6939701
* 6944404: Remove extraneous callback call
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6944404
* 6936124: [FPF-CI]: Introduce blink::NoiseToken for fingerprinting protection
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6936124
* chore: update patches
* fixup! 6927233: Remove NativeTheme "use dark colors" bit.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6927233
* fixup! 6917864: Devirtualize and inline various NativeTheme getters.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6917864
* 6937588: Add initial OsSettingsProvider object, supplying caret blink interval.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6937588
* fixup! 6905242: Reland "[CSP] Clarify report-only console messages."
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6905242
* 6907515: Replace SingletonHwndObserver with a CallbackList on SingletonHwnd.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6907515
* 6910482: [Save to Drive] Implement retry functionality
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6910482
* fixup! 6927233: Remove NativeTheme "use dark colors" bit.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6927233
* Revert "build: remove ninja logs"
This reverts commit 72874740fd .
* test: fix flakey test picked from PR 48205
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
Co-authored-by: Alice Zhao <alicelovescake@anthropic.com >
2025-09-22 20:16:27 -07:00
Robo
048d620701
fix: remove unneeded handlescope from JS callbacks ( #48318 )
...
fix: remove handlescope from JS callbacks
2025-09-16 06:56:38 +09:00
Charles Kerr
a468ed7f10
refactor: narrow or remove gin arguments ( #48300 )
...
* refactor: narrow App:SetJumpList() arg from gin::Arguments* to v8::Isolate*
* refactor: narrow WebContents::AddWorkSpace() arg from gin::Arguments* to v8::Isolate*
* refactor: narrow ShowMessageBox() arg from gin::Arguments* to v8::Isolate*
* refactor: narrow ShowOpenDialog() arg from gin::Arguments* to v8::Isolate*
* refactor: remove unused gin::Arguments* arg from OverrideGlobalPropertyFromIsolatedWorld()
* refactor: narrow WebContents::StartDrag() arg from gin::Arguments* to v8::Isolate*
* refactor: narrow NetLog::StopLogging() arg from gin::Arguments* to v8::Isolate*
* refactor: narrow Protocol::IsProtocolHandled() arg from gin::Arguments* to v8::Isolate*
2025-09-13 08:19:07 +09:00
Charles Kerr
a6959ca97b
refactor: allocate api::Debugger on cpp heap ( #48266 )
...
* refactor: remove unused isolate arg from Debugger ctor
* refactor: make Debugger ctor, dtor public
needed for cppgc::MakeGarbageCollected()
This is what upstream does, e.g. https://chromium-review.googlesource.com/c/chromium/src/+/6722236
* fixup! refactor: remove unused isolate arg from Debugger ctor
mark Debugger ctor as explicit
* refactor: in EventEmitterMixin, handle both old and new WrapperInfo types
* refactor: make electron::api::Debugger inherit from gin::Wrappable
* refactor: add api::Debugger::GetTypeName()
* refactor: add api::Debugger::GetClassName()
2025-09-11 16:03:17 -04:00
electron-roller[bot]
793565e4be
chore: bump chromium to 141.0.7390.7 (main) ( #48212 )
...
* chore: bump chromium in DEPS to 141.0.7381.3
* chore: update patches
* chore: bump chromium in DEPS to 141.0.7382.0
* chore: update patches
* chore: bump chromium in DEPS to 141.0.7384.0
* chore: bump chromium in DEPS to 141.0.7386.0
* [Extensions] Move devtools_page and chrome_url_overrides handlers
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6862700
* Reland "[api] Advance deprecation of GetIsolate"
Refs https://chromium-review.googlesource.com/c/v8/v8/+/6875273
* Move "system integrated UI" concept out of NativeTheme.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6867375
* chore: update patches
* Reland "[PermissionOptions] Return PermissionResult in callback for requests"
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6851838
* Reland "[exit-time-destructors] Enable by default"
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6859042
* chore: update patches
* [FSA] Revoke Read access after removing file via FileSystemAccess API
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6677249
* chore: IWYU
* [DevToolsUIBindings] Accept an object for `dispatchHttpRequest` params
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6877528
* chore: IWYU
* Pass navigation UI parameters on EnterFullscreen in EAM
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6874923
* chore: rm band-aid_over_an_issue_with_using_deprecated_nsopenpanel_api.patch
* Remove unused PreHandleMouseEvent
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6880411
* 6878583: siso: update to version 1.4.1
https://chromium-review.googlesource.com/c/chromium/src/+/6878583
* Fold native_theme_browser into native_theme.
https://chromium-review.googlesource.com/c/chromium/src/+/6882627
* fixup: Reland "[exit-time-destructors] Enable by default
https://chromium-review.googlesource.com/c/chromium/src/+/6859042
* chore: update filenames.libcxx.gni
* chore: IWYU
* fixup: chore: IWYU
* fixup: Reland "[exit-time-destructors] Enable by default
* fixup: Reland "[exit-time-destructors] Enable by default
* Remove common_theme.*; place its method in NativeTheme instead.
https://chromium-review.googlesource.com/c/chromium/src/+/6886029
* fixup: Reland "[exit-time-destructors] Enable by default
* Better track when WebPreferences need updates for color-related changes.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6886797
* chore: bump chromium in DEPS to 141.0.7390.7
* 6904664: Reland "Make BrowserContext::GetPath() const"
https://chromium-review.googlesource.com/c/chromium/src/+/6904664
* Restore read access after certain file modification operations
https://chromium-review.googlesource.com/c/chromium/src/+/6861041
* fixup: Move "system integrated UI" concept out of NativeTheme.
* fixup: Reland "[exit-time-destructors] Enable by default
* chore: update patches
* 6906096: Remove GetSysSkColor().
https://chromium-review.googlesource.com/c/chromium/src/+/6906096
* Inline implementation of SysColorChangeListener into the lone user.
https://chromium-review.googlesource.com/c/chromium/src/+/6905083
Also 6906096: Remove GetSysSkColor(). | https://chromium-review.googlesource.com/c/chromium/src/+/6906096
* fixup: 6906096: Remove GetSysSkColor()
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-09-08 12:57:15 +02:00
Robo
e0db4046b2
refactor: allocate gin_helper::internal::Event on cpp heap ( #48161 )
2025-08-27 09:30:50 +09:00
Robo
3ccb1bc0a8
refactor: allocate api::Session on cpp heap ( #48141 )
2025-08-25 18:52:06 +09:00
Shelley Vohr
afb0ee418c
fix: re-entrancy issues in webContents.loadURL() ( #48004 )
...
fix: re-entrancy issues in webContents.loadURL()
2025-08-11 11:20:35 -04:00
Shelley Vohr
8806499904
fix: offscreen mode under window.open creation ( #47868 )
...
fix: offscreen mode under new window creation
2025-08-05 14:56:33 +02:00
Robo
4ca10a1056
chore: move gin::Handle to gin_helper ( #47959 )
...
* chore: move gin::Handle to gin_helper
* chore: fix lint
2025-08-05 02:03:06 +09:00
Shelley Vohr
4232ed2814
fix: crash on window.close() with webContents on blur ( #47933 )
...
fix: crash on window.close with WebContentsView on blur
2025-08-04 10:35:29 +02:00
Charles Kerr
2255bb620a
refactor: avoid deprecated v8::Context::GetIsolate() calls (pt 2) ( #47879 )
...
* refactor: add a v8::Isolate* arg to Constructible::GetConstructor()
* refactor: add a v8::Isolate* arg to NodeBindings::Initialize()
This is needed for the GetConstructor() call
* refactor: avoid v8::Context::GetIsolate() call in GetIpcObject() by taking it as an arg
* refactor: avoid v8::Context::GetIsolate() call in ipc_native::EmitIPCEvent() by taking it as an arg
2025-07-28 10:22:27 -05:00
xufuhang
b39a1fb877
fix: webContents.downloadURL() did not support referer header ( #47625 )
...
Signed-off-by: xufuhang <576484918@qq.com >
2025-07-23 10:37:24 +02:00
Charles Kerr
39cca586f6
refactor: avoid deprecated v8::Context::GetIsolate() calls (pt 1) ( #47760 )
...
* refactor: avoid redundant GetIsolate() calls in NodeBindings::CreateEnvironment()
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/6563615
* refactor: use v8::Isolate::GetCurrent() in Initialize() methods
* refactor: add v8::Isolate* arg to NodeBindings::CreateEnvironment()
* fixup! refactor: use v8::Isolate::GetCurrent() in Initialize() methods
* refactor: add v8::Isolate* arg to RendererClientBase::DidCreateScriptContext()
* fixup! refactor: add v8::Isolate* arg to NodeBindings::CreateEnvironment()
* fixup! fixup! refactor: use v8::Isolate::GetCurrent() in Initialize() methods
refactor: prefer JavascriptEnvironment::GetIsolate() in the browser layer
2025-07-21 16:34:38 +02:00
electron-roller[bot]
603cafad7e
chore: bump chromium to 140.0.7281.0 (main) ( #47616 )
...
* chore: bump chromium in DEPS to 140.0.7269.2
* chore: bump chromium in DEPS to 140.0.7270.0
* chore: bump chromium in DEPS to 140.0.7271.0
* chore: bump chromium in DEPS to 140.0.7273.0
* 6516731: [ExclusiveAccessForAndroid] remove unneeded includes & deps | https://chromium-review.googlesource.com/c/chromium/src/+/6516731
* 6694809: dbus: Ensure systemd scope is started before using any portal services | https://chromium-review.googlesource.com/c/chromium/src/+/6694809
* chore: patch chromium
* chore: export patches
* chore: bump chromium in DEPS to 140.0.7275.0
* 6677511: [pepper] More pepper removal | https://chromium-review.googlesource.com/c/chromium/src/+/6677511
* 6513641: [gin] Rename gin::Wrappable to gin::DeprecatedWrappable | https://chromium-review.googlesource.com/c/chromium/src/+/6513641
* chore: export chromium patches
* 6513641: [gin] Rename gin::Wrappable to gin::DeprecatedWrappable | https://chromium-review.googlesource.com/c/chromium/src/+/6513641
* chore: bump chromium in DEPS to 140.0.7277.0
* chore: bump chromium in DEPS to 140.0.7279.0
* chore: bump chromium in DEPS to 140.0.7281.0
* 6677314: Plumb enabled client hints in the network requestion to network layer
https://chromium-review.googlesource.com/c/chromium/src/+/6677314
* 6351556: [source-phase-imports] Support Wasm Source Phase Imports
https://chromium-review.googlesource.com/c/chromium/src/+/6351556
* 6700077: [renderer] Avoid calls to deprecated GetIsolate methods
https://chromium-review.googlesource.com/c/chromium/src/+/6700077
* 6692873: Reland "Reland "FSA: Only normalize the hardcoded rules once during initialization""
https://chromium-review.googlesource.com/c/chromium/src/+/6692873
* 6686234: [gin] Cleanup NamedPropertyInterceptor for Wrappable
https://chromium-review.googlesource.com/c/chromium/src/+/6686234
* chore: export patches
* 6667723: Remove content_enable_legacy_ipc GN arg.
https://chromium-review.googlesource.com/c/chromium/src/+/6667723
* 6646566: ui: Move NativeWindowTracker to its own directory
https://chromium-review.googlesource.com/c/chromium/src/+/6646566
* fix: add missing includes
* 6580522: [WAR, DNR] Fix unsafe redirect error to web accessible resource
https://chromium-review.googlesource.com/c/chromium/src/+/6580522
* 6680477: Implement `completeCode` endpoint and expose to DevTools
https://chromium-review.googlesource.com/c/chromium/src/+/6680477
* 6677511: [pepper] More pepper removal
https://chromium-review.googlesource.com/c/chromium/src/+/6677511
* 6696689: Rename views::WidgetFocusManager -> NativeViewFocusManager
https://chromium-review.googlesource.com/c/chromium/src/+/6696689
* 6702812: Move wtf/text/string_impl*.* to "blink" namespace
https://chromium-review.googlesource.com/c/chromium/src/+/6702812
* chore: fix dialog patch
* 6702431: [animation-trigger] Parse timeline-trigger-name
https://chromium-review.googlesource.com/c/chromium/src/+/6702431
* chore: fixup patch indices
* feat: replace webFrame.routingId with webFrame.frameToken
* feat: WebFrameMain.prototype.frameToken
* test: refactor to use replacement APIs
* chore: fixup pip patch
* test: adjust webFrame tests for frameToken changes
* 6703757: Reland "Enable -fsanitize=array-bounds in non-UBSan builds"
https://chromium-review.googlesource.com/c/chromium/src/+/6703757
* test: switch to frameTokens
* test: routingId is fine to test in the main process
* docs: add routingId to breaking changes
* docs: update plugin-crashed event
* chore: fixup linux dialog patch
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: alice <alice@makenotion.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
2025-07-14 13:42:37 -07:00
Shelley Vohr
31bc5ca903
fix: default to system accent color on invalid user color ( #47660 )
...
fix: default to system accent color on invalid user color"
2025-07-08 11:15:13 +02:00
Charles Kerr
bc585b6a3f
refactor: avoid a few unnecessary strings ( #47644 )
...
* perf: replace string temporary with string_view in GetXdgAppId()
* perf: replace string temporary with string_view in ToV8(WindowOpenDisposition)
* perf: replace string temporary with string_view in ToV8(electron::api::WebContents::Type)
2025-07-03 11:08:59 -05:00
Charles Kerr
6f915e85e2
refactor: have ShowSaveDialogSync() return a std::optional<base::FilePath> ( #47428 )
...
* refactor: have ShowSaveDialogSync() return a std::optional<base::FilePath>
* fixup! refactor: have ShowSaveDialogSync() return a std::optional<base::FilePath>
2025-06-12 12:25:40 +02:00
Shelley Vohr
09a0926c5b
fix: printing PDF via webContents.print() ( #47377 )
...
fix: printing PDF via webContents.print()
2025-06-06 14:20:37 -04:00
Shelley Vohr
fbb3fa7503
feat: allow intercepting mouse events ( #47280 )
...
* feat: allow intercepting mouse events
* test: add specs
* Update spec/api-web-contents-spec.ts
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2025-06-04 14:10:33 +02:00
Shelley Vohr
c6f368acc6
chore: debug crash on DevTools SetOwnerWindow ( #47243 )
2025-05-26 09:45:43 +02:00
Charles Kerr
211faed848
refactor: add NativeWindow::IsActive() ( #47148 )
...
this was already present on macOS; use in NativeWindowViews too
2025-05-20 11:08:44 -04:00
electron-roller[bot]
e3e647d21e
chore: bump chromium to 138.0.7175.0 (main) ( #46986 )
...
* chore: bump chromium in DEPS to 138.0.7166.0
* chore: bump chromium in DEPS to 138.0.7166.2
* 6508373: Add WebContents, Tab getters for future Clank navigation capture rework
https://chromium-review.googlesource.com/c/chromium/src/+/6508373
* 6470924: Introduce auto-populated Search Engine icons.
https://chromium-review.googlesource.com/c/chromium/src/+/6470924
* 6502977: Force same tab navigation while actor coordinator is acting on a tab
https://chromium-review.googlesource.com/c/chromium/src/+/6502977
* chore: bump chromium in DEPS to 138.0.7168.0
* chore: update patches
* fix grit patch
* chore: bump Chromium to 138.0.7169.2
* fixup! 6508373: Add WebContents, Tab getters for future Clank navigation capture rework
* 6493688: NavigationThrottleRunner2: void CreateThrottlesForNavigation
https://chromium-review.googlesource.com/c/chromium/src/+/6493688
* 6488755: Reland "WebSQL: Remove WebPreference"
https://chromium-review.googlesource.com/c/chromium/src/+/6488755
* 6428707: FSA: Only normalize the hardcoded rules once during initialization
https://chromium-review.googlesource.com/c/chromium/src/+/6428707
* chore: fixup patch indices
* chore: bump chromium in DEPS to 138.0.7170.0
* 6514121: Remove origin calculation debug info and related methods
https://chromium-review.googlesource.com/c/chromium/src/+/6514121
* chore: bump chromium in DEPS to 138.0.7172.0
* chore: bump chromium in DEPS to 138.0.7173.0
* chore: bump chromium in DEPS to 138.0.7175.0
* fixup! 6514121: Remove origin calculation debug info and related methods
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6514121
* 6531585: Don't retry LayerTreeSink creation on the high priority queue
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6531585
* 6512253: Modernize base::apple's base bundle ID
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6512253
* fixup! 6428707: FSA: Only normalize the hardcoded rules once during initialization
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6428707
* fixup! 6508373: Add WebContents, Tab getters for future Clank navigation capture rework
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6508373
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2025-05-13 14:51:20 -04:00
Charles Kerr
2cbd968da5
refactor: use gin_helper::Dictionary::ValueOrDefault() ( #46982 )
...
* refactor: use ValueOrDefault() in electron_api_web_contents.cc
* refactor: use ValueOrDefault() in electron_api_url_loader.cc
* refactor: use ValueOrDefault() in electron_download_manager_delegate.cc
* refactor: use ValueOrDefault() in electron_touch_bar.mm
* refactor: use ValueOrDefault() in electron_url_loader_factory.cc
* refactor: use ValueOrDefault() in electron_browser_context.cc
* refactor: use ValueOrDefault() in electron_touch_bar.mm
* refactor: use ValueOrDefault() in blink_converter.cc
* feat: add ValueOrDefault() to PersistentDictionary
* empty commit
* refactor: use ValueOrDefault() in blink_converter.cc
* refactor: inline the rectangle base::Value::Dict
* refactor: remove has_scroll temporary
---------
Co-authored-by: Deepak Mohan <hop2deep@gmail.com >
2025-05-08 14:17:22 -05:00
Shelley Vohr
c16ea8d54e
fix: printing when no mediaSize specified ( #46937 )
...
fix: printing when no mediaSize specified
2025-05-06 19:12:25 -05:00
Charles Kerr
2e2776611f
refactor: simplify NativeWindow::FullScreenTransitionState ( #46918 )
...
* refactor: make NativeWindow::fullscreen_transition_state_ private
* refactor: add NativeWindow::is_transitioning_fullscreen() helper
* refactor: remove unused NativeWindow::fullscreen_transition_state()
* refactor: replace NativeWindow::set_fullscreen_transition_state() with NativeWindow::set_is_transitioning_fullscreen()
refactor: remove unused NativeWindow::FullScreenTransitionState
2025-05-05 09:28:29 -05:00
Charles Kerr
f6b297a06a
refactor: use base::ObserverList::Notify() ( #46875 )
...
* refactor: use ObserverList::Notify() in shell/browser/window_list.cc
* refactor: use ObserverList::Notify() in shell/browser/web_contents_zoom_controller.cc
* refactor: use ObserverList::Notify() in shell/browser/usb/usb_chooser_context.cc
* refactor: use ObserverList::Notify() in shell/browser/usb/electron_usb_delegate.cc
* refactor: use ObserverList::Notify() in shell/browser/ui/views/menu_delegate.cc
* refactor: use ObserverList::Notify() in shell/browser/ui/tray_icon.cc
* refactor: use ObserverList::Notify() in shell/browser/ui/electron_menu_model.cc
* refactor: use ObserverList::Notify() in shell/browser/serial/serial_chooser_context.cc
* refactor: use ObserverList::Notify() in shell/browser/native_window.cc
* refactor: use ObserverList::Notify() in shell/browser/serial/electron_serial_delegate.cc
* refactor: use ObserverList::Notify() in shell/browser/browser.cc
* refactor: use ObserverList::Notify() in shell/browser/api/electron_api_web_contents.cc
* refactor: use ObserverList::Notify() in shell/browser/hid/electron_hid_delegate.cc
* refactor: use ObserverList::Notify() in shell/browser/hid/hid_chooser_context.cc
2025-05-02 11:10:52 +02:00
Charles Kerr
06a99d6770
refactor: make node Buffers more friendly to base::span / std::span ( #46724 )
...
* refactor: add electron::Buffer namespace; move the Buffer as_byte_span() into it
* feat: add electron::Buffer::Copy()
a span-friendly version of node::Buffer::Copy()
* refactor: use electron::Buffer::Copy() in electron_api_base_window.cc
* refactor: use electron::Buffer::Copy() in electron_api_data_pipe_holder.cc
* refactor: use electron::Buffer::Copy() in electron_api_safe_storage.cc
* refactor: use electron::Buffer::Copy() in electron_api_clipboard.cc
* refactor: use electron::Buffer::Copy() in osr_converter.cc
* refactor: use electron::Buffer::Copy() in electron_api_native_image.cc
* refactor: use electron::Buffer::Copy() in net_converter.cc
* refactor: use electron::Buffer::Copy() in electron_api_web_contents.cc
* refactor: make NewEmptyBuffer() return a Local<Value>
2025-04-25 08:00:09 -05:00
wujinli
3e78bbde6a
fix: crash when renderer process crashes while webview is reloading ( #46735 )
...
WebView uses WebContentsViewChildFrame, which doesn't have a Focus impl
and triggers a fatal NOTREACHED.
2025-04-25 10:10:27 +02:00
Charles Kerr
e9f279afd1
chore: remove WebContents.getNativeView() ( #46734 )
...
chore: remove never-used WebContents.getNativeView().
This was added in https://github.com/electron/electron/pull/10308 but
was never used and never documented, not even as experimental API.
2025-04-23 20:33:50 -05:00
Charles Kerr
c7b0bdab7e
fix: explicitly call GetNativeNSView() on macOS ( #46733 )
...
* fix: explicitly call GetNativeNSView() on macOS
* chore: move macOS impl to a .mm file
This is needed in order to access gfx::NativeView::GetNativeNSView()
2025-04-23 17:55:18 -05:00
Shelley Vohr
3064b24c9d
refactor: use default printing path when no user options ( #46587 )
2025-04-11 10:14:29 -04:00
Charles Kerr
41d8f90d68
refactor: use base::flat_set in WebContents::DidUpdateFaviconUrl() ( #46475 )
...
* refactor: add gin::Converter<std::span>::ToV8()
* feat: add ToV8(const base::flat_set<T>&)
* perf: use a flat_set in WebContents::TitleWasSet()
* refactor: add gin::Converter<std::array>::ToV8()
2025-04-07 10:16:02 +02:00
Charles Kerr
4e33d1690d
refactor: instantiate navigation_entries local variable on the stack ( #46453 )
...
* refactor: instantiate navigation_entries on the stack instead of the heap
* refactor: reserve the full size of navigation_entries
* refactor: use emplace_back to simplify the code a little
2025-04-04 16:55:27 -05:00
Charles Kerr
a21c805ece
perf: avoid redundant call to virtual methods GetProcess() and GetID() ( #46409 )
2025-04-02 11:57:09 -05:00
Charles Kerr
3ae285b614
perf: avoid std::map temporaries in WebContents::DevToolsRequestFileSystems() ( #46268 )
...
* perf: move the GetDevToolsWebContents() call outside of the loop
* perf: remove std::map temporary in WebContents::DevToolsRequestFileSystems()
* refactor: remove unused GetAddedFileSystemPaths()
* perf: remove std::vector temporary in WebContents::DevToolsRequestFileSystems()
2025-03-26 16:26:56 -05:00
Shelley Vohr
3212f60d69
fix: set userAgent on navigationHistory.restore() ( #46260 )
...
fix: set userAgent on navigationHistory restore
2025-03-26 10:59:19 -05:00
Charles Kerr
a5076a663b
perf: avoid redundant map lookup in WebContents::DevToolsIndexPath() ( #46254 )
...
perf: avoid double map lookup in WebContents::DevToolsIndexPath()
2025-03-26 10:30:02 -05:00
Charles Kerr
48a38c0289
fix: build failure when printing is disabled ( #46283 )
...
fix: ftbfs when printing is disabled
2025-03-26 10:04:39 +01:00
Charles Kerr
ced8fdbce8
perf: avoid std::map temporaries in IsDevToolsFileSystemAdded() ( #46230 )
...
* refactor: extract-method GetAddedFileSystems()
* refactor: use GetAddedFileSystems() in GetAddedFileSystemPaths()
* refactor: use GetAddedFileSystems() in IsDevToolsFileSystemAdded()
2025-03-25 11:42:58 -05:00
Shelley Vohr
1d6cb348b4
fix: webContents.printToPDF() with cross-process subframes ( #46218 )
...
fix: webContents.printToPDF() with cross-process subframes
2025-03-25 08:16:47 -05:00