Jeremy Rose
502d4c19ce
feat: allow omitting submitURL when uploadToServer is false ( #28105 )
2021-03-18 14:15:19 -07:00
Samuel Attard
f35fc93080
chore: rename process.contextIsolation to process.contextIsolated ( #28259 )
...
* chore: rename process.contextIsolation to process.contextIsolated
* thing
2021-03-18 14:00:19 -07:00
Samuel Maddock
4057e6b56e
fix: DesktopCapturer gc'd prior to capture completion ( #28273 )
...
desktopCapture.getSources() returns a promise which should resolve
when capturing finishes. Internally it creates an instance of
DesktopCapturer which is responsible for resolving or rejecting
the promise.
Between the time DesktopCapturer starts capturing frames and when
it finishes, it's possible for its handle to be GC'd leading to
it never resolving.
These changes pin the instance of DesktopCapturer until it either
finishes or errors.
fixes #25595
2021-03-18 13:43:35 -07:00
Jeremy Rose
b52ccc9726
fix: bad menu position when no positioning item specified ( #28224 )
2021-03-18 13:37:14 -07:00
Karel Braeckman
8476bed36e
Change example to work with latest versions of selenium-webdriver ( #28231 )
...
See https://github.com/SeleniumHQ/selenium/issues/9286
The existing snippet works with selenium-webdriver <= 3.6.0, but any more recent version seems to require using 'goog:chromeOptions' and forBrowser('chrome').
2021-03-18 13:35:04 -07:00
Electron Bot
baadcd48df
Bump v14.0.0-nightly.20210318
2021-03-18 07:32:19 -07:00
Will Anderson
14acf00ba9
docs: add missing curly brace to quick start example code ( #28253 )
2021-03-18 00:58:03 -07:00
Milan Burda
fc7f2042ec
feat: add process.contextIsolation property ( #28030 )
2021-03-17 11:23:29 -07:00
Milan Burda
485fa5bea9
feat: add process.contextId used by @electron/remote ( #28007 )
2021-03-17 11:23:03 -07:00
Electron Bot
54bc21929a
Bump v14.0.0-nightly.20210317
2021-03-17 07:31:38 -07:00
Will Anderson
b6ff12ef7f
docs: update Quick Start Guide for Electron 12 ( #28223 )
...
* docs: Update Quick Start Guide for Electron 12
With `contextIsolation` enabled by default in Electron 12, the Getting Started Guide no longer works as it is written. In order for the basic example to display values from `process.versions`, we need to add a `preload.js` to the example.
* fix: annotate preload code block with a language
* docs: update quick-start Fiddle example to use preload to provide version info
* fix: ensure example files end in a newline
* docs: add security warning to instructions for turning off contextIsolation
Co-authored-by: John Kleinschmidt <jkleinsc@github.com >
* docs: treat preload as an adjective instead of a noun
Co-authored-by: John Kleinschmidt <jkleinsc@github.com >
Co-authored-by: John Kleinschmidt <jkleinsc@github.com >
2021-03-16 19:45:38 -04:00
Cheng Zhao
80f89a3472
test: disable some tests under ASan which might receive SIGKILL because of OOM ( #28156 )
...
* test: running child app under ASan might receive SIGKILL
* test: renderer process of webview might receive SIGKILL under ASan
* test: increase timeout for asan build
2021-03-16 17:02:47 -04:00
John Kleinschmidt
29dc5a2f83
docs: remove no longer relevant link ( #28196 )
2021-03-16 11:41:49 -04:00
Electron Bot
4a6bc7a42f
Bump v14.0.0-nightly.20210316
2021-03-16 07:34:16 -07:00
Shelley Vohr
fdc2e2bc57
fix: recalibrate simpleFullscreen when display metrics change ( #28150 )
...
* fix: recalibrate simpleFullscreen when display metrics change
* Address review feedback
* fix: compilation issues
* Address feedback from review
2021-03-16 02:41:59 -07:00
Samuel Attard
b045d42b0e
docs: document the parameter structure of hookWindowMessage ( #28189 )
...
Fixes #28178
2021-03-16 17:54:41 +09:00
Jeremy Rose
d27ad0d182
fix: revert "refactor: mmap asar files ( #24470 )" ( #28137 )
...
This reverts commit 01a2e23194
2021-03-15 11:42:54 -07:00
Electron Bot
b023b33c05
Bump v14.0.0-nightly.20210315
2021-03-15 07:33:00 -07:00
Gerrit Niezen
45c4dd529f
docs: remove unnecessary enableBlinkFeatures ( #28129 )
...
* docs: remove unnecessary enableBlinkFeatures
* docs: remove trailing comma
2021-03-15 10:29:10 +09:00
Jeremy Rose
41fdf450b2
docs: expand OS version prompt in issue template ( #28135 )
...
* docs: expand OS version prompt in issue template
* Update bug_report.yml
2021-03-15 10:26:27 +09:00
Samuel Attard
8dfe4abd14
fix: handle a nil backgroundColor in win.getBackgroundColor() ( #28120 )
...
* fix: handle a nil backgroundColor in win.getBackgroundColor()
* spec: add crash case
* fix: update to fix native_views transparent color
* chore: fix lint
2021-03-14 17:26:47 -07:00
Samuel Attard
f73256651b
fix: convert system colors to device color space in systemPreferences ( #28121 )
2021-03-12 23:31:08 -08:00
Binyamin Aron Green
a442f11574
fixed typo in docs/api/window-open.md ( #28117 )
2021-03-13 10:47:33 +09:00
Jeremy Rose
b8926cb4e8
docs: remove "Additional information" section from issue template ( #28136 )
2021-03-12 17:39:47 -08:00
Jeremy Rose
b7eb521cec
docs: about->description in issue template ( #28144 )
2021-03-12 09:23:13 -08:00
Jeremy Rose
ab74cf4e1a
docs: add bug label to bug reports ( #28145 )
2021-03-12 09:22:51 -08:00
Jeremy Rose
8d38e9dd54
docs: use :syntax: for emoji in feature request template ( #28146 )
2021-03-12 09:22:15 -08:00
Electron Bot
4d1d6c8a3a
Bump v14.0.0-nightly.20210312
2021-03-12 06:32:18 -08:00
Mark Lee
40d779a7f3
docs(breaking-changes): contextIsolation disables require in renderer ( #28087 )
...
* docs(breaking-changes): contextIsolation disables require in renderer
* docs: consistency
2021-03-12 16:42:15 +09:00
Mark Lee
6bce814736
docs(quick-start): make import command npm 7-compatible ( #28077 )
...
With npm 7, just running `npx @electron-forge/cli import` results in:
```
npm ERR! could not determine executable to run
```
2021-03-12 16:38:58 +09:00
Cheng Zhao
5b710519cf
test: reliably wait for spellchecker to load ( #28118 )
2021-03-12 16:35:57 +09:00
Milan Burda
6c90411e21
fix: change #if defined(OS_MACOSX) to #if defined(OS_MAC) ( #28102 )
2021-03-11 21:07:21 -08:00
Samuel Attard
74e7f98572
docs: fix cookies event documentation for type generation ( #28115 )
2021-03-11 12:14:16 -08:00
Electron Bot
8badc6583f
Bump v14.0.0-nightly.20210311
2021-03-11 06:31:59 -08:00
Samuel Attard
089ac8180f
fix: ensure child window transparency works ( #28054 )
...
* fix: ensure child window transparency works
Windows opened via window.open and intecepted via setWindowOpenHandler
or the `new-window` event should (a) have the correct background color
and (b) that background color should be transparent if specified.
The changes in api_web_contents fix (a) and the changes in
web_contents_preferences fix (b).
Notes: Child windows with specified background colors or transpency now
work as intended
* fix: set background_color in blink prefs apply logic
* chore: update for PR comments
2021-03-10 12:44:36 -08:00
Robo
102a3740ea
chore: cherry-pick 1fe571a from node ( #28067 )
...
Backports https://github.com/nodejs/node/pull/37000
2021-03-10 11:44:16 -08:00
Cheng Zhao
32ec7e1e21
test: enable locale test for asan build ( #28085 )
2021-03-10 13:04:57 -05:00
John Kleinschmidt
73d0a16ae2
chore: convert Mac App Store Private API Rejection template to form ( #28100 )
2021-03-10 13:03:25 -05:00
Electron Bot
5df13e7c8a
Bump v14.0.0-nightly.20210310
2021-03-10 06:32:06 -08:00
Milan Burda
5b205731f6
chore: remove deprecated remote module ( #25734 )
...
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2021-03-09 17:12:40 -08:00
Shelley Vohr
d274df7e3a
chore: convert bug report template to form ( #27971 )
...
* chore: update feature_request for checkboxes
* chore: convert bug report template
* Update .github/ISSUE_TEMPLATE/bug_report.yml
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* Update .github/ISSUE_TEMPLATE/feature_request.yml
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* Update .github/ISSUE_TEMPLATE/bug_report.yml
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* Update .github/ISSUE_TEMPLATE/bug_report.yml
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* Update .github/ISSUE_TEMPLATE/bug_report.yml
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* Update .github/ISSUE_TEMPLATE/bug_report.yml
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* Update .github/ISSUE_TEMPLATE/bug_report.yml
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* Update .github/ISSUE_TEMPLATE/bug_report.yml
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* Address review feedback
* Update .github/ISSUE_TEMPLATE/bug_report.yml
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* Update .github/ISSUE_TEMPLATE/bug_report.yml
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2021-03-09 16:30:32 -05:00
Electron Bot
aadf2f4a7c
Bump v14.0.0-nightly.20210309
2021-03-09 06:33:36 -08:00
Shelley Vohr
d9997c303f
fix: capturePage not resolving with hidden windows ( #27883 )
2021-03-09 05:51:44 -08:00
Cheng Zhao
f6949dd197
test: show full object diff ( #28062 )
2021-03-09 16:05:02 +09:00
John Kleinschmidt
e27b7ed248
build: call goma_ctl.py ensure_start directly ( #28053 )
2021-03-09 09:17:42 +09:00
Shelley Vohr
41b5cd1a84
chore: remove obsolete native node module patch ( #23760 )
2021-03-08 14:21:07 -08:00
Cheng Zhao
7e22523ed2
test: print more infomation in locale test ( #28040 )
2021-03-08 11:23:55 -05:00
Cheng Zhao
3270613bf7
test: ignore the ready event from PDF Viewer ( #28039 )
2021-03-08 11:15:39 -05:00
Electron Bot
0505beb43d
Bump v14.0.0-nightly.20210308
2021-03-08 06:31:58 -08:00
Konstantin Pschera
5b50c88508
docs: auto update downloading multiple times ( #27888 )
2021-03-08 10:03:34 +09:00
