github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity
24,996 Commits 423 Branches 3,573 Tags
52cddbcd9290a0bc55053896cb27cdbdf8131472
Commit Graph

24996 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
trop[bot]
52cddbcd92 docs: add <webview> 'did-attach' event documentation (#30129) 
Co-authored-by: Milan Burda <milan.burda@gmail.com>
 2021-07-15 10:40:33 +09:00
trop[bot]
6d0feb8b79 docs: fix fiddle path (#30144) 
This is breaking the build in `electron/electronjs.org-new` and will
most likely not work when clicking the "Fiddle" button.

Rel: https://github.com/electron/electronjs.org-new/pull/65

Co-authored-by: Antón Molleda <amolleda@gmail.com>
 2021-07-14 17:51:08 -04:00
trop[bot]
2e096ac6bc fix: adjust initial webContents focus calculation (#29234) 
* fix: adjust initial webContents focus calculation

* fix: active window check on mac

* fix: about:blank focus behavior

* chore: add spec

* fix: window ordering on mac

* chore: focus <webview> after navigation

* chore: fix flaky fullscreen inheritance test

* chore: disable fullscreen test on mac arm

* chore: simplify found-in-page spec

* chore: fix lint

* chore: move found-in-page spec to main process

* chore: fix lint

* chore: remove focus workaround

* chore: improve found-in-page spec

Co-authored-by: Raymond Zhao <raymondzhao@microsoft.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
 2021-07-14 11:03:01 -07:00
trop[bot]
3afe390805 chore: update releases to 8 weeks in CONTRIBUTING (#30119) 
* chore: update releases to 8 weeks in CONTRIBUTING

* chore: update support.md for four version support

Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>
Co-authored-by: VerteDinde <khammond@slack-corp.com>
 2021-07-14 08:09:55 -07:00
trop[bot]
d5097dd2e6 docs: Update timeline for E15 alpha announcement (#30117) 
* docs: Update timeline for E15 alpha announcement

* fix line break

Co-authored-by: Sofia Nguy <sofianguy@gmail.com>
 2021-07-14 08:09:28 -07:00
trop[bot]
257b214cb5 docs: update quick-start.md (#30133) 
Change app-quit link definition, so both window-all-closed and app-quit redirects to appropriate sites.

Co-authored-by: Davenury <57959794+Davenury@users.noreply.github.com>
 2021-07-14 22:26:30 +09:00
Jeremy Rose
945ecdd709 fix: crash when invoking login callback synchronously (#30068) (#30091) 2021-07-14 20:48:16 +09:00
trop[bot]
cb614d15aa build: decode error output as utf8 (#30094) 
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
 2021-07-14 20:46:39 +09:00
trop[bot]
5fbcee074d fix: return RGBA values from getSystemColor (#30088) 
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
 2021-07-14 20:46:08 +09:00
trop[bot]
dc14161a98 test: disable failing node tests (#30098) 
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
 2021-07-13 09:05:14 -07:00
trop[bot]
299fa3a3c4 chore: cherry-pick 9bab573a37 from chromium (#30100) 
* chore: cherry-pick 9bab573a37 from chromium

Refs https://chromium-review.googlesource.com/c/chromium/src/+/3010140

* chore: update patches

Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
 2021-07-12 22:07:50 -07:00
trop[bot]
d09e7f851b docs: modernize protocol-handler docs (#30057) 
* docs: modernize protocol-handler docs

* docs: iadd contextIsolation

* docs: add guide for launch-app-from-URL-in-other-app

* docs: address comments

* chore: fix brackets

* chore: add escaped brackets

Co-authored-by: George Xu <gxu@slack-corp.com>
 2021-07-09 14:36:51 -04:00
Shelley Vohr
84eea6fa79 fix: fsPromises.readFile renderer crash (#29928) 2021-07-06 10:36:31 +09:00
trop[bot]
0cd80cd424 docs: remove requestHeaders in webRequest.onHeadersReceived (#29933) 
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
 2021-07-06 10:34:58 +09:00
trop[bot]
78f037f639 fix: honor user-defined Downloads directory (#29968) 
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2021-07-05 15:53:55 -04:00
trop[bot]
fc75bf0a9e fix: webview should maximize on requestFullscreen (#29987) 
* fix: webview should maximize on requestFullscreen

* chore: update patches

Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
 2021-07-05 14:36:39 -04:00
Electron Bot
ddc44e1af4 Bump v13.1.6 v13.1.6 2021-07-05 11:12:13 -07:00
trop[bot]
5ab2749acc fix: do not leak NSUUID (#30009) 
* fix: do not leak NSUUID

* Fix build error

Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
 2021-07-05 12:53:04 -04:00
trop[bot]
642c458c31 docs: remove Experimental from contextBridge.exposeInMainWorld (#30010) 
The API has been around for about 3 years. It should no longer be
considered experimental.

Co-authored-by: Antón Molleda <amolleda@gmail.com>
 2021-07-05 15:28:56 +09:00
trop[bot]
2195890a46 fix: self.module.paths not working in web workers (#30013) 
* fix: global.module.paths in workers

* spec: add a regression test

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2021-07-05 15:27:20 +09:00
Samuel Attard
3413e89572 chore: cherry-pick cc20b36a5845 from chromium (#29997) 
* chore: cherry-pick cc20b36a5845 from chromium

* chore: update patches

Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
 2021-07-05 08:45:52 +09:00
trop[bot]
7bf69ce4ee docs: remove mention of node-mac-notifier (#30002) 
Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
 2021-07-05 08:44:20 +09:00
trop[bot]
49f5006ef0 fix: crash when clicking links with target=_blank from webview (#29951) 
Co-authored-by: deepak1556 <hop2deep@gmail.com>
 2021-07-01 19:57:59 -07:00
trop[bot]
fea59c5601 fix: correctly propagate title updates for window with no navigation entries (#29958) 
* fix: correctly propagate title updates for window with no navigation entries

* test

Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
 2021-07-02 09:49:58 +09:00
trop[bot]
6feed17387 fix: potential crash on macOS app exit (#29961) 
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2021-07-02 08:43:22 +09:00
Electron Bot
ec0fa836d2 Bump v13.1.5 v13.1.5 2021-07-01 11:36:42 -07:00
trop[bot]
56a34d3b10 build: add support for spawning builds for a specific commit on appveyor (#29971) (#29983) 
Co-authored-by: Samuel Attard <sam@electronjs.org>
 2021-07-01 10:53:33 -07:00
Shelley Vohr
bde3d403a8 fix: child window alwaysOnTop level persistence (#29956) 2021-07-01 10:22:37 -04:00
John Kleinschmidt
8779a3ac0f ci: fixup arm testing (#29927) 
* ci: fixup arm testing

* update patch for 13-x-y

* also check against kPartitionAllocPCScan
 2021-06-30 14:12:47 -04:00
Omar Kilani
b465ee721e fix: geolocation crashes electron on macOS (#29343) (#29912) 2021-06-28 20:31:04 -07:00
trop[bot]
50b0750df3 docs: fix broken markdown in dialog.md (#29848) 
* docs: fix broken markdown in dialog.md

* &#32;

Co-authored-by: Jeremy Rose <jeremya@chromium.org>
 2021-06-29 09:15:47 +09:00
electron-roller[bot]
1a3da54563 chore: bump chromium to 91.0.4472.124 (13-x-y) (#29774) 
* chore: bump chromium in DEPS to 91.0.4472.114

* chore: bump chromium in DEPS to 91.0.4472.124

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
 2021-06-28 14:06:13 -04:00
trop[bot]
fa3767564a fix: stop window.open from hanging when prevented (#29882) 
* fix: stop window.open from hanging when prevented

* add test

Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
 2021-06-28 15:24:18 +09:00
trop[bot]
85db7e7077 fix: properly order out child windows (#29888) 
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2021-06-25 17:55:45 +09:00
trop[bot]
9b1d2d5b88 fix: Inspector method overrides when contextIsolation enabled (#29885) 
* fix: Inspector method overrides when contextIsolation enabled

* fix: handle DevToolsAPI call

* refactor: always use webFrame.executeJavaScript

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2021-06-25 17:50:39 +09:00
trop[bot]
e8621de3f5 fix: properly handle optional requestHeaders with onBeforeSendHeaders (#29836) 
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
 2021-06-23 10:09:25 +09:00
Electron Bot
9942b2ba80 Bump v13.1.4 v13.1.4 2021-06-22 10:20:05 -07:00
trop[bot]
2bf125f82a fix: allow ppapi processes access to resource bundle on all platforms (#29830) 
* wip: debug resource bundle failure

* fix: include ppapi subprocesses for windows resource bundle

* fix: allow ppapi plugin processes access to resource bundle on all platforms.

Aligns with chrome_main_delegate here: https://chromium-review.googlesource.com/c/chromium/src/+/2619003

* chore: remove incorrectly backported patches

Co-authored-by: VerteDinde <keeleymhammond@gmail.com>
Co-authored-by: VerteDinde <khammond@slack-corp.com>
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>
 2021-06-22 14:59:06 +09:00
John Kleinschmidt
69493ac51e ci: run linux arm tests on CircleCI (#29766) 
* ci: run linux arm tests on CircleCI

* cleanup electron dirs after testing

(cherry picked from commit 1c0a6045fb)

* use start-stop-daemon to kill Xvfb

(cherry picked from commit 1d10a68c31)
 2021-06-22 14:58:07 +09:00
Electron Bot
6504c4bbc8 Bump v13.1.3 v13.1.3 2021-06-21 10:03:02 -07:00
trop[bot]
5c1e1ee5ec fix: do not cancel CORS preflight request on proxy auth. (#29811) 
* fix: do not cancel CORS preflight request on proxy auth. (#29266)

* fix: do not cancel CORS preflight request on proxy auth.

If connecting via proxy, preflight request can receive 407
header response from proxy. This does not mean request
was finished even though it received headers (from proxy,
not the destination server), so prevent "completing"
and most importantly deleting it, which causes request
to be canceled in network layer. Just continue to monitor it
and await proper response from server. Also add circut breaker
to cancel request if proxy auth failed 3 times (for example
user keeps cancelling auth). This behavior happens only
when app registered WebRequest api listeners.

* Port chromium webrequest changes to electron code.

Move relevant parts of chromium WebRequestProxyingURLLoaderFactory from
https://chromium-review.googlesource.com/c/chromium/src/+/2011781
into electron ProxyingURLLoaderFactory.

* Update code to upstreamed version and remove retyr count failsafe.

Co-authored-by: Milan Burda <milan.burda@gmail.com>

* chore: add required header

Co-authored-by: marekharanczyk <48673767+marekharanczyk@users.noreply.github.com>
Co-authored-by: Milan Burda <milan.burda@gmail.com>
Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
 2021-06-21 21:20:05 +09:00
trop[bot]
f39ac0764d fix: update Squirel.Mac to fix CPU spin during update (#29805) 
* fix: update Squirel.Mac to fix CPU spin during update

Refs: https://github.com/Squirrel/Squirrel.Mac/pull/259
Closes: #29119

* chore: update patches

Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
 2021-06-21 19:06:06 +09:00
trop[bot]
252805ddb4 fix: microtasks policy in CreateEnvironment (#29808) 
* fix: microtasks policy in CreateEnvironment

Microtasks policy should not be updated for the renderer because
`NodeBindings::CreateEnvironment` might be entered with or without
`UvRunOnce()` on stack. One of the examples of such calls is
`window.open()` which is possible to invoke while `uv_run()` is still
running (e.g. with `setImmediate()`).

All in all, it doesn't matter that much which policy we use since
`v8::MicrotasksScope` has a check for the policy in its destructor and
no commits will be made if the policy is `kExplicit`. It is important,
however, to not change the policy in the middle of `UvRunOnce()` so we
should respect whatever we currently have and move on.

Fix: #29463

* Move test to a better place

* Update spec-main/fixtures/crash-cases/setimmediate-window-open-crash/index.html

Co-authored-by: Jeremy Rose <nornagon@nornagon.net>

* Update spec-main/fixtures/crash-cases/setimmediate-window-open-crash/index.html

Co-authored-by: Jeremy Rose <nornagon@nornagon.net>

* simplify crash-case

* comment

* fix comment

Co-authored-by: Fedor Indutny <fedor@indutny.com>
Co-authored-by: Fedor Indutny <79877362+indutny-signal@users.noreply.github.com>
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
Co-authored-by: Fedor Indutny <indutny@signal.org>
 2021-06-21 15:49:17 +09:00
trop[bot]
df27597c05 docs: fix frontmatter for Tray tutorial (#29803) 
Co-authored-by: Erick Zhao <erick@hotmail.ca>
 2021-06-21 14:00:25 +09:00
trop[bot]
fa683ef8b7 fix: fix hover state not clear bug when BrowserWindow is not resizable (#611) (#29800) 
Co-authored-by: sssooonnnggg <sssooonnnggg111@gmail.com>
 2021-06-21 13:59:36 +09:00
trop[bot]
16b09a676f docs: clarify use of ELECTRON_SKIP_BINARY_DOWNLOAD (#29745) 
Co-authored-by: Erick Zhao <erick@hotmail.ca>
 2021-06-21 10:10:05 +09:00
George Xu
301108ece4 docs: Add clarification for Visual Zoom behavior (#28860) (#29764) 
* Add clarification for visual zoom documentation

Co-authored-by: Michael Kozakov <michael.kozakov@snapchat.com>
 2021-06-18 11:02:42 -07:00
Keeley Hammond
5d36cdf485 fix: color select eyedropper not working within DevTools (#29729) (#29760) 
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2021-06-18 11:34:03 +02:00
George Xu
c94ab729dd docs: added guide and updated docs for Tray (#29385) (#29762) 
* docs: added guide and updated docs for Tray

* docs: improve clarity
 2021-06-17 14:03:07 -07:00
trop[bot]
b35f904e58 fix: ensure detached devtools are not always draggable (#29737) 
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
 2021-06-17 15:29:27 +09:00