electron-roller[bot]
d920c82fc4
chore: bump chromium to 143.0.7451.0 (main) ( #48362 )
...
* chore: bump chromium in DEPS to 142.0.7429.0
* chore: bump chromium in DEPS to 142.0.7430.0
* 6954508: Reland Migrate WrappableWithNamedPropertyInterceptor to gin::Wrappable | https://chromium-review.googlesource.com/c/chromium/src/+/6954508
* https://chromium-review.googlesource.com/c/chromium/src/+/6955633
* 5584820: Fix font face resolution when renderer is blocked | https://chromium-review.googlesource.com/c/chromium/src/+/5584820
* chore: export patches
* chore: remove patch that keeley says is ok to remove in comments
* chore: bump chromium in DEPS to 142.0.7432.0
* chore: export patches
* chore: bump chromium in DEPS to 142.0.7434.0
* 6973697: Use type tags for data stored in V8 internal fields | https://chromium-review.googlesource.com/c/chromium/src/+/6973697
* 6976272: Revert Reland mac: click through content area in main window | https://chromium-review.googlesource.com/c/chromium/src/+/6976272
* chore: export patches
* 6938086: Rename native_widget_types.h -> native_ui_types.h | https://chromium-review.googlesource.com/c/chromium/src/+/6938086
* 6951252: Correct PersistentCache backed code cache context grouping
* chore: bump chromium in DEPS to 142.0.7436.0
* 6981628: Reland Use unordered_map in AcceleratorMap | https://chromium-review.googlesource.com/c/chromium/src/+/6981628
* chore: export patches
* chore: resolve patch conflict with main
* chore: merge conflict with main
* chore: bump chromium in DEPS to 142.0.7438.0
* chore: bump chromium in DEPS to 142.0.7440.0
* chore: bump chromium in DEPS to 142.0.7442.0
* chore: bump chromium in DEPS to 142.0.7444.0
* chore: bump chromium in DEPS to 143.0.7445.0
* chore: bump chromium in DEPS to 143.0.7447.0
* chore: bump chromium in DEPS to 143.0.7449.0
* chore: bump chromium in DEPS to 143.0.7451.0
* 7001364: Migrate GURL accessors to Get* variants in //content | https://chromium-review.googlesource.com/c/chromium/src/+/7001364
* 6986521: Implicit second value 'any' instead of 'span-all' for fallback query | https://chromium-review.googlesource.com/c/chromium/src/+/6986521
* chore: update chromium patches
* chore: update chromium patches
* chore: update patches
* fix: parse macOS SDK version across line break
https://chromium-review.googlesource.com/c/chromium/src/+/6980166
* fix: replace v8::Object::SetPrototype() usage
https://chromium-review.googlesource.com/c/v8/v8/+/6983465
https://github.com/nodejs/node/pull/55453
* fix: regenerate filenames.libcxx.gni
https://chromium-review.googlesource.com/c/chromium/src/+/6980307
* fix: replace additional usages of SetPrototype
https://chromium-review.googlesource.com/c/v8/v8/+/6983465
* build: use macos 15 minimum
https://chromium-review.googlesource.com/c/chromium/src/+/6980166
* ci: ignore missing dir for strip_universal_deep
* fix: js2c compilation failure
https://chromium-review.googlesource.com/c/chromium/src/+/6950738
See patch description explaining MacOS 26 SDK headers incompatibility.
* fixup! chore: export patches
* feat: add new memory-eviction exit reason
https://chromium-review.googlesource.com/c/chromium/src/+/6991933
* fix: set JSON reader parsing options
https://chromium-review.googlesource.com/c/chromium/src/+/6992114
* fix: provide DeviceEmulationCacheBehavior param
https://chromium-review.googlesource.com/c/chromium/src/+/6965238
* fix: views::NonClientFrameView -> views::FrameView
https://chromium-review.googlesource.com/c/chromium/src/+/7005027
https://chromium-review.googlesource.com/c/chromium/src/+/6966937
* fix: check new forced colors enum value
https://chromium-review.googlesource.com/c/chromium/src/+/6944403
* fix: migrate NetworkConditions -> MatchedNetworkConditions
https://chromium-review.googlesource.com/c/chromium/src/+/6827307
* fix: migrate GURL string methods to Get*()
https://chromium-review.googlesource.com/c/chromium/src/+/7007010
* fix: disable C++ modules in electron_lib builds
https://chromium-review.googlesource.com/c/chromium/src/+/6950738
* fix: partially revert is_headless_mode removal
https://chromium-review.googlesource.com/c/chromium/src/+/6955633
This patch should likely be reworked. For now, this partially reverts the
removal of a required class property to restore behavior.
* Revert "build: use macos 15 minimum"
This reverts commit 2fc12d6acchttps://chromium-review.googlesource.com/c/v8/v8/+/6983465 https://github.com/nodejs/node/pull/55453
* fixup! fix: replace v8::Object::SetPrototype() usage https://chromium-review.googlesource.com/c/v8/v8/+/6983465 https://github.com/nodejs/node/pull/55453
* build: switch to macos-15 runner
build/mac/find_sdk.py now requires macOS 15 SDK as a minimum version. The
macos 15 runners default to an Xcode using the 15 SDK and removes older
versions.
* fixup! fix: check new forced colors enum value https://chromium-review.googlesource.com/c/chromium/src/+/6944403
* fixup! fix: migrate GURL string methods to Get*() https://chromium-review.googlesource.com/c/chromium/src/+/7007010
* fix: use std::u16string for Extension::Create() error parameter
https://chromium-review.googlesource.com/c/chromium/src/+/6975452
* fix: add missing image_skia include
https://chromium-review.googlesource.com/c/chromium/src/+/6986762
* fixup! fix: add missing image_skia include https://chromium-review.googlesource.com/c/chromium/src/+/6986762
* fix: remove outdated V8 flag
https://chromium-review.googlesource.com/c/v8/v8/+/6948286
* fix: disable protocol handler DCHECK
https://chromium-review.googlesource.com/c/chromium/src/+/6727594
Ignore the extension custom protocol handler registry DCHECK until
we invest in supporting it. Replacing this DCHECK seems harmless
and will unblock the roll.
* fix: replace deprecated usage of SetPrototype
https://chromium-review.googlesource.com/c/v8/v8/+/6983465
* fixup! fix: migrate NetworkConditions -> MatchedNetworkConditions https://chromium-review.googlesource.com/c/chromium/src/+/6827307
* fixup! fix: migrate GURL string methods to Get*() https://chromium-review.googlesource.com/c/chromium/src/+/7007010
* chore: remove patch already included in roll
* chore: remove extraneous formatting added to patch
* chore: remove fix_harden_blink_scriptstate_maybefrom.patch
https://chromium-review.googlesource.com/c/chromium/src/+/6973697
No longer needed since the above CL landed.
* 6973697: Use type tags for data stored in V8 internal fields
https://chromium-review.googlesource.com/c/chromium/src/+/6973697
* chore: update patches
* fixup! chore: export patches
* chore: restore electron embedder data tag patch
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Alice Zhao <alicelovescake@anthropic.com >
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-10-13 12:21:54 -04:00
zoy
3a53c71324
fix: broken transparent window styles on resizable change ( #48378 )
...
* fix: wrong api call
* fix: consistency of the resize state
* fix: edge cases
* chore: add detailed comments
* fix: lint
* chore: only windows
* chore: use transparent
2025-10-09 09:49:20 +02:00
Charles Kerr
235fdc41f6
refactor: use gin::Arguments in BaseWindow ( #48355 )
...
* refactor: make api::Clipboard::GetClipboardBuffer() private
* refactor: move GetClipboadBuffer() into anonymous namespace
* refactor: use gin::Arguments in BaseWindow::MoveAbove()
refactor: use gin::Arguments in BaseWindow::SetAlwaysOnTop()
refactor: use gin::Arguments in BaseWindow::SetIgnoreMouseEvent()
* refactor: use gin::Arguments in BaseWindow::SetProgresBar()
* refactor: use gin::Arguments in BaseWindow::SetVisibleOnAllWorkspaces()
* refactor: use gin::Arguments in BaseWindow::SetVibrancy()
* refactor: use gin::Arguments in BaseWindow::SetAspectRatio()
* refactor: use gin::Arguments in BaseWindow::PreviewFile()
* refactor: use gin::Arguments in BaseWindow::SetThumbarButtons()
* refactor: use gin::Arguments in BaseWindow::SetBounds()
* refactor: use gin::Arguments in BaseWindow::SetContentBounds()
* refactor: use gin::Arguments in BaseWindow::SetSize()
* refactor: use gin::Arguments in BaseWindow::SetContentSize()
* refactor: use gin::Arguments in BaseWindow::SetSheetOffset()
* refactor: use gin::Arguments in BaseWindow::SetPosition()
* refactor: use gin::Arguments in BaseWindow::AddTabbedWindow()
* refactor: use gin::Arguments in BaseWindow::SetParentWindow()
* refactor: use gin::Arguments in BaseWindow::BaseWindow()
* refactor: use gin::Arguments in BaseWindow::SetAccentColor()
* refactor: use gin::Arguments in BaseWindow::SetTitleBarOverlay()
2025-09-24 09:39:16 -04:00
electron-roller[bot]
793565e4be
chore: bump chromium to 141.0.7390.7 (main) ( #48212 )
...
* chore: bump chromium in DEPS to 141.0.7381.3
* chore: update patches
* chore: bump chromium in DEPS to 141.0.7382.0
* chore: update patches
* chore: bump chromium in DEPS to 141.0.7384.0
* chore: bump chromium in DEPS to 141.0.7386.0
* [Extensions] Move devtools_page and chrome_url_overrides handlers
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6862700
* Reland "[api] Advance deprecation of GetIsolate"
Refs https://chromium-review.googlesource.com/c/v8/v8/+/6875273
* Move "system integrated UI" concept out of NativeTheme.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6867375
* chore: update patches
* Reland "[PermissionOptions] Return PermissionResult in callback for requests"
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6851838
* Reland "[exit-time-destructors] Enable by default"
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6859042
* chore: update patches
* [FSA] Revoke Read access after removing file via FileSystemAccess API
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6677249
* chore: IWYU
* [DevToolsUIBindings] Accept an object for `dispatchHttpRequest` params
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6877528
* chore: IWYU
* Pass navigation UI parameters on EnterFullscreen in EAM
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6874923
* chore: rm band-aid_over_an_issue_with_using_deprecated_nsopenpanel_api.patch
* Remove unused PreHandleMouseEvent
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6880411
* 6878583: siso: update to version 1.4.1
https://chromium-review.googlesource.com/c/chromium/src/+/6878583
* Fold native_theme_browser into native_theme.
https://chromium-review.googlesource.com/c/chromium/src/+/6882627
* fixup: Reland "[exit-time-destructors] Enable by default
https://chromium-review.googlesource.com/c/chromium/src/+/6859042
* chore: update filenames.libcxx.gni
* chore: IWYU
* fixup: chore: IWYU
* fixup: Reland "[exit-time-destructors] Enable by default
* fixup: Reland "[exit-time-destructors] Enable by default
* Remove common_theme.*; place its method in NativeTheme instead.
https://chromium-review.googlesource.com/c/chromium/src/+/6886029
* fixup: Reland "[exit-time-destructors] Enable by default
* Better track when WebPreferences need updates for color-related changes.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6886797
* chore: bump chromium in DEPS to 141.0.7390.7
* 6904664: Reland "Make BrowserContext::GetPath() const"
https://chromium-review.googlesource.com/c/chromium/src/+/6904664
* Restore read access after certain file modification operations
https://chromium-review.googlesource.com/c/chromium/src/+/6861041
* fixup: Move "system integrated UI" concept out of NativeTheme.
* fixup: Reland "[exit-time-destructors] Enable by default
* chore: update patches
* 6906096: Remove GetSysSkColor().
https://chromium-review.googlesource.com/c/chromium/src/+/6906096
* Inline implementation of SysColorChangeListener into the lone user.
https://chromium-review.googlesource.com/c/chromium/src/+/6905083
Also 6906096: Remove GetSysSkColor(). | https://chromium-review.googlesource.com/c/chromium/src/+/6906096
* fixup: 6906096: Remove GetSysSkColor()
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-09-08 12:57:15 +02:00
Shelley Vohr
0917ed5f6f
fix: snapped restoration after minimization ( #48142 )
2025-08-22 14:37:45 -04:00
Shelley Vohr
5c98e3609f
feat: add {get|set}AccentColor on Windows ( #47741 )
...
* feat: add setAccentColor on Windows
* refactor: unify GetSystemAccentColor
* refactor: remove redundant parsing
* chore: fixup documentation
* Update docs/api/browser-window.md
Co-authored-by: Will Anderson <andersonw@dropbox.com >
* Update docs/api/base-window.md
Co-authored-by: Will Anderson <andersonw@dropbox.com >
---------
Co-authored-by: Will Anderson <andersonw@dropbox.com >
2025-08-01 22:29:02 +02:00
Shelley Vohr
01faaa30ea
fix: window content protection on older Windows versions ( #47856 )
2025-07-24 12:05:28 -07:00
Shelley Vohr
31725b4a86
fix: window accentColor should adhere to native window behavior ( #47740 )
...
* fix: window accentColor should adhere to native window behavior
* fix: address review feedback
* chore: remove duplicate UpdateWindowAccentColor call in ctor
2025-07-17 10:59:42 +02:00
Shelley Vohr
5ef6897bc7
fix: accent color should reflect system settings without restart ( #47629 )
...
fix: accentColor should reflect system settings without restart
2025-07-03 18:13:39 +02:00
Shelley Vohr
3e8e87d186
feat: support customizing window accent color on Windows ( #47285 )
2025-06-24 14:43:02 +02:00
Keeley Hammond
3536d4976a
fix: revert moving IsClosed() and IsClosable() into NativeWindow::Close() ( #47482 )
...
Revert "refactor: move `IsClosed()` and `IsClosable()` tests into `NativeWindow::Close()` (#46888 )"
This reverts commit 3faddd5ae2
2025-06-16 16:41:19 -07:00
Charles Kerr
21155679a0
refactor: add NativeWindowViews::GetClientFrameViewLinux() ( #47130 )
...
* refactor: add NativeWindowViews::GetClientFrameViewLinux()
* chore: clarify code comment
2025-05-20 14:15:06 -05:00
Charles Kerr
211faed848
refactor: add NativeWindow::IsActive() ( #47148 )
...
this was already present on macOS; use in NativeWindowViews too
2025-05-20 11:08:44 -04:00
Charles Kerr
687e50b4f3
refactor: add NativeWindowViews::SetTitleBarOverlay() ( #47126 )
...
* refactor: move SetTitleBarOverlay() impl to NativeWindowViews
* refactor: make NativeWindowViews::set_overlay_button_color() private
refactor: make NativeWindowViews::set_overlay_symbol_color() private
refactor: make NativeWindow::set_titlebar_overlay_height() protected
* refactor: simplify downcasting in NativeWindowViews::SetTitleBarOverlay()
2025-05-19 08:19:03 -05:00
Charles Kerr
3faddd5ae2
refactor: move IsClosed() and IsClosable() tests into NativeWindow::Close() ( #46888 )
...
refactor: devirtualize NativeWindow::IsClosed()
2025-05-02 13:21:29 -05:00
electron-roller[bot]
2b07e6450c
chore: bump chromium to 138.0.7154.0 (main) ( #46872 )
...
* chore: bump chromium in DEPS to 138.0.7152.0
* chore: update patches
* chore: bump chromium in DEPS to 138.0.7154.0
* chore: update patches
* ozone/wayland: Fix bookmark dropdown right click context menu
https://chromium-review.googlesource.com/c/chromium/src/+/6488801
* Use base::cstring_view in base::Environment
https://chromium-review.googlesource.com/c/chromium/src/+/6494292
* [A11yPerformance] Remove Add/Remove AXMode methods
https://chromium-review.googlesource.com/c/chromium/src/+/6418444
xref: https://chromium-review.googlesource.com/c/chromium/src/+/6383275
* build: update filenames.libcxx.gni
* Use base::cstring_view in base::Environment
https://chromium-review.googlesource.com/c/chromium/src/+/6494292
* Use getters to expose NativePixmapHandle from GpuMemoryBufferHandle
https://chromium-review.googlesource.com/c/chromium/src/+/6374406
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-05-01 23:53:40 -05:00
Keeley Hammond
63114e2b8e
fix: revert macOS content protection logic refactor ( #46886 )
...
Revert "refactor: use upstream content protection logic on macOS (#46813 )"
This reverts commit 34adb976b6
2025-05-01 13:49:55 -07:00
Charles Kerr
25d77fd1ce
refactor: use WidgetDelegate's title property ( #46849 )
...
* refactor: use WidgetDelegate::SetTitle()
* Make NativeWindow::SetTitle() and NativeWindow::GetTitle() non-virtual.
Use WidgetDelegate for their implementation.
* Add NativeWindow::OnTitleChanged(), a new protected virtual method to update
subclasses (e.g. NativeWindowMac needs to redraw the button proxy).
* In NativeWindowMac, replace SetTitle() and GetTitle() with OnTitleChanged().
* In NativeWindowViews, replace SetTitle() and GetTitle() with OnTitleChanged().
* test: enable BrowserWindow.title tests on Linux
* test: add a test to confirm win.title changes when document.title is set in the renderer
2025-04-30 08:22:27 -07:00
zoy
4641bc9619
fix: fullscreen fillet / recovery is incorrect ( #46641 )
...
* fix: fullscreen fillet / recovery is incorrect
Signed-off-by: ZOY\zoy-l <zoy-l@outlook.com >
* fix: maintain frameless consistency on windows 11
* fix: maintain frameless consistency on windows 11
* chore: modify the comments
---------
Signed-off-by: ZOY\zoy-l <zoy-l@outlook.com >
2025-04-28 16:54:08 -04:00
Shelley Vohr
b03c71213e
refactor: use upstream content protection logic on macOS ( #46780 )
...
* refactor: use upstream content protection logic on macOS
* Update shell/browser/native_window.h
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-04-26 11:31:30 -05:00
Charles Kerr
6f24dbaab4
perf: prefer absl::flat_hash_set over std::set when sorted order is not needed ( #46410 )
...
* perf: use an absl::flat_hash_set for UsbChooserContext::ephemeral_devices_
* perf: use an absl::flat_hash_set for GlobalMenuBarRegistrarX11::live_windows_
* perf: use an absl::flat_hash_set for NativeWindowViews::forwarding_windows_
* perf: use an absl::flat_hash_set for OffScreenRenderWidgetHostView::guest_host_views_
perf: use an absl::flat_hash_set for OffScreenRenderWidgetHostView::proxy_views_
* perf: use an absl::flat_hash_set for NativeWindow::injected_frames_
* perf: use an absl::flat_hash_set for NativeWindow::background_throttling_sources_
2025-04-02 11:03:36 -05:00
Shelley Vohr
9ec14b91e7
feat: add BrowserWindow.isSnapped() ( #46079 )
...
* feat: add BrowserWindow.isSnapped() on Windows
* docs: mark _Readonly_
2025-03-24 12:09:14 +01:00
Shelley Vohr
99c943df23
fix: setContentProtection(true) after hide on Windows ( #45868 )
...
fix: content protection after hide on Windows
https://chromium-review.googlesource.com/c/chromium/src/+/5789117
2025-03-04 16:39:59 -05:00
co63oc
36ec9d7236
docs: fix spelling errors in code comments ( #45842 )
...
chore: Fix typos
2025-02-28 12:24:00 +01:00
Charles Kerr
aa06b065c0
chore: bump chromium to 134.0.6998.10 (main) ( #45564 )
...
* chore: bump chromium to 134.0.6992.0
* chore: add BrowserProcessImpl::CreateGlobalFeaturesForTesting() stub
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6216193
Remove GlobalFeatures from TestingBrowserProcess::Init
* chore: bump chromium to 134.0.6994.0
* 6208630: Mac sandbox: don't use protobuf for policy serialization | https://chromium-review.googlesource.com/c/chromium/src/+/6208630
* [PDF] Remove HasUnsupportedFeature Mojo interface
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6220800
* 6217444: Remove scoped_gdi_object.h type aliases. | https://chromium-review.googlesource.com/c/chromium/src/+/6217444
* chore: bump chromium to 134.0.6998.10
* 6221378: Revert [OBC] Exclude Aliasing Cookies in FilterCookiesWithOptions() | https://chromium-review.googlesource.com/c/chromium/src/+/6221378
* Update ExtensionPrefs::GetDisableReasons to return DisableReasonSet
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6218840
change copied from 6218840 extensions/shell/browser/shell_extension_loader.cc
* 6218402: Typemap ui.gfx.DXGIHandle <=> gfx::DXGIHandle | https://chromium-review.googlesource.com/c/chromium/src/+/6218402
* chore: disable flaky contentTracing test
not new to this roll; it is happening in main as well
* fixup! chore: disable flaky contentTracing test
---------
Co-authored-by: alice <alice@makenotion.com >
2025-02-11 17:26:39 -06:00
Shelley Vohr
9199d5c610
fix: window maximizing with Mica ( #45456 )
...
* fix: window maximizing with Mica
* Fix rounded corners after restore
2025-02-07 15:00:36 -05:00
electron-roller[bot]
af58931efa
chore: bump chromium to 131.0.6744.0 (main) ( #43948 )
...
* chore: bump chromium in DEPS to 131.0.6738.0
* chore: bump chromium in DEPS to 131.0.6740.0
* 5889025: [LaCrOS] Remove LaCrOS screen capturer. | https://chromium-review.googlesource.com/c/chromium/src/+/5889025
* https://boringssl.googlesource.com/boringssl.git/+/40dd94116ba03678226443ba20c5887459c9bf16/crypto/fipsmodule/digest/digests.c.inc
* chore: update patches
* 5878695: Add IsolationInfo for embedders handling external protocols | https://chromium-review.googlesource.com/c/chromium/src/+/5878695
* 5854304: [UI] Remove alias of mojom | https://chromium-review.googlesource.com/c/chromium/src/+/5854304
* chore: bump chromium in DEPS to 131.0.6742.0
* chore: update patches
* chore: bump chromium in DEPS to 131.0.6744.0
* fixup! 5889025: [LaCrOS] Remove LaCrOS screen capturer. | https://chromium-review.googlesource.com/c/chromium/src/+/5889025
* chore: e patches all
* chore: update chore_provide_iswebcontentscreationoverridden_with_full_params.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5894233
* [UI] Remove alias of mojom 'WindowShowState'
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5854304
* chore: gen-libc++-filenames.js
* chore: partially revert https://chromium-review.googlesource.com/c/chromium/src/+/5894233
see patch commit message for description
* Clean up stale base::Feature "kFileSystemAccessLocalUNCPathBlock"
This feature is always on by default and doesn't have active finch
experiments.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5881253
* fix: asar integrity test recognizes SIGABRT as a crash
https://chromium-review.googlesource.com/c/chromium/src/+/5882758
ValidateIntegrityOrDie() exits via LOG(FATAL)'s call to
base::ImmediateCrash(). There's been churn there upstream between
5332940 and 5882758 on whether to use SIGTRAP or SIGABRT. For now,
let's accept both until the churn is done.
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: alice <alice@makenotion.com >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-09-30 14:54:44 +02:00
Charles Kerr
23bcca3ffc
refactor: put empty virtual function definitions in header ( #43285 )
...
* refactor: in FramelessView, move empty function decls to header
* refactor: in electron::api::WebContents, move empty function decls to header
* refactor: in electron::api::NativeWindow, move empty function decls to header
* refactor: in electron::OffScreenWebContentsView, move empty function decls to header
* refactor: in electron::OffScreenRenderWidgetHostView, move empty function decls to header
* refactor: in auto_updater::AutoUpdater, move empty function decls to header
* refactor: in electorn::api::FrameSubscriber, move empty function decls to header
* refactor: in electorn::api::SimpleURLLoaderWrapper, move empty function decls to header
* refactor: in electorn::InspectableWebContents, move empty function decls to header
* refactor: in electorn::OffScreenVideoConsumer, move empty function decls to header
* refactor: in electron::OffScreenWebContentsView, move empty function decls to header
* refactor: in electron::TrayIcon, move empty function decls to header
* refactor: in electron::ViewsDelegate, move empty function decls to header
* refactor: in electron::MediaCaptureDevicesDispatcher, move empty function decls to header
* refactor: in electron::UsbChooserContext::DeviceObserver, move empty function decls to header
* refactor: in electron::ProxyingWebSocket, move empty function decls to header
* refactor: in electron::Notification, move empty function decls to header
* refactor: in electron::PlatformNotificationService, move empty function decls to header
* Revert "refactor: in electron::PlatformNotificationService, move empty function decls to header"
This reverts commit 9103750d03b9ba1ceccba43d11dfdc2404ff6191.
* refactor: in electron::ElectronPDFDocumentHelperClient, move empty function decls to header
* refactor: in electron::api::SpellCheckClient, move empty function decls to header
* refactor: in electron::ElectronExtensionHostDelegate, move empty function decls to header
* refactor: in electron::PlatformNotificationService, move empty function decls to header
* refactor: in electron::NativeWindowViews, move empty function decls to header
* chore: move SetTouchBar() back to cc
* Revert "refactor: in auto_updater::AutoUpdater, move empty function decls to header"
This reverts commit c43d6862d3
2024-08-12 09:56:51 +02:00
Shelley Vohr
32e5012017
feat: enable Windows Control Overlay on Linux ( #41769 )
2024-06-27 14:56:36 +02:00
electron-roller[bot]
c3b4cd987c
chore: bump chromium to 127.0.6521.0 (main) ( #42118 )
...
* chore: bump chromium in DEPS to 126.0.6470.0
* 5492605: Migrate TODOs referencing old crbug IDs to the new issue tracker IDs | https://chromium-review.googlesource.com/c/chromium/src/+/5492605
* 5513277: Move subresource-filter-ruleset to GCS | https://chromium-review.googlesource.com/c/chromium/src/+/5513277
* 5512656: Remove CustomizeChromeSupportsChromeRefresh2023 | https://chromium-review.googlesource.com/c/chromium/src/+/5512656
* 5516009: Accept mouse events in inactive window for Top Chrome WebUIs | https://chromium-review.googlesource.com/c/chromium/src/+/5516009
* 5376861: Change references to RWHVB in RWHIER and RenderWidgetTargeter to RWHVI. | https://chromium-review.googlesource.com/c/chromium/src/+/5376861
* 5490530: Use partition_alloc PA_BUILDFLAG(...) outside PA. #cleanup | https://chromium-review.googlesource.com/c/chromium/src/+/5490530
* 5296870: network: Allow trusted loaders to learn the sent request cookies. | https://chromium-review.googlesource.com/c/chromium/src/+/5296870
* 5453438: Delegate delegated ink trails to RWHI from RWHIER. | https://chromium-review.googlesource.com/c/chromium/src/+/5453438
* chore: update patches
* chore: bump chromium in DEPS to 126.0.6472.0
* chore: bump chromium in DEPS to 126.0.6474.0
* chore: update patches
* chore: bump chromium in DEPS to 126.0.6476.0
* chore: bump chromium in DEPS to 126.0.6478.0
* chore: bump chromium in DEPS to 126.0.6478.3
* chore: bump chromium in DEPS to 126.0.6478.8
* update patches
* only disable enterprise_cloud_content_analysis
* 5403888: [api] support v8::Data in v8::TracedReference and v8::EmbedderGraph
https://chromium-review.googlesource.com/c/v8/v8/+/5403888
* chore: bump chromium in DEPS to 127.0.6484.0
* chore: bump chromium in DEPS to 127.0.6485.0
* 5539004: Use NOTREACHED_IN_MIGRATION() in remaining chrome/ | https://chromium-review.googlesource.com/c/chromium/src/+/5539004
* src: cast to v8::Value before using v8::EmbedderGraph::V8Node | https://github.com/nodejs/node/pull/52638/files
* chore: update patches
* chore: update v8 patches
* chore: bump chromium in DEPS to 127.0.6486.0
* chore: bump chromium in DEPS to 127.0.6488.0
* chore: bump chromium in DEPS to 127.0.6490.0
* chore: bump chromium in DEPS to 127.0.6492.0
* chore: update patches
For some reason, `feat_expose_raw_response_headers_from_urlloader.patch` got messed up in an earlier commit.
* chore: update patches
printing.patch was updated due to https://chromium-review.googlesource.com/c/chromium/src/+/5535938
* 5527572: Move Connectors prefs files to components/enterprise/connectors/
https://chromium-review.googlesource.com/c/chromium/src/+/5527572
* chore: bump chromium in DEPS to 127.0.6494.0
* chore: bump chromium in DEPS to 127.0.6495.0
* chore: bump chromium in DEPS to 127.0.6496.0
* 5465511: [api] Mark v8::ObjectTemplate::SetAccessor(..) for deprecation
https://chromium-review.googlesource.com/c/v8/v8/+/5465511
* chore: revert v8 deprecation
See patch message for more details.
https://chromium-review.googlesource.com/c/v8/v8/+/5526611
* chore: update patches
* 5538771: Remove srcdoc else-if block in CalculateOrigin()
https://chromium-review.googlesource.com/c/chromium/src/+/5538771
* 5522321: [devtools] Support saving base64 encoded files via host bindings
https://chromium-review.googlesource.com/c/chromium/src/+/5522321
* 5376861: Change references to RWHVB in RWHIER and RenderWidgetTargeter to RWHVI.
https://chromium-review.googlesource.com/c/chromium/src/+/5376861
* 5530163: [media] Use VideoFrame::Plane typed enum instead of nameless enum
https://chromium-review.googlesource.com/c/chromium/src/+/5530163
* 5463431: iwa: Only create IsolatedWebAppURLLoaderFactory for subresources in IWAs
https://chromium-review.googlesource.com/c/chromium/src/+/5463431
* fixup! 5465511: [api] Mark v8::ObjectTemplate::SetAccessor(..) for deprecation https://chromium-review.googlesource.com/c/v8/v8/+/5465511
* 5512176: Remove OnEnvironmentEstimationComplete()
https://chromium-review.googlesource.com/c/chromium/src/+/5512176
* 5528282: Move Web Speech API .mojom files to //media/mojo/mojom
https://chromium-review.googlesource.com/c/chromium/src/+/5528282
* 5513740: Reland "[Extensions] Restructure extensions::ProcessMap"
https://chromium-review.googlesource.com/c/chromium/src/+/5513740
* 5483406: [PEPC] Make PEPC permission subscription take into account device status
https://chromium-review.googlesource.com/c/chromium/src/+/5483406
* 5526034: [DoH] Remove kDnsOverHttps feature flag
https://chromium-review.googlesource.com/c/chromium/src/+/5526034
The title is a bit misleading. They removed handling for the feature flag and generally intend to remove it but haven't yet.
I only changed our code to address the flag that was removed. A quick search on GitHub for `DnsOverHttpsFallback` yielded a few results, but they were all C++ chromium code or patches, 0 app code or discussion results. Since I couldn't find any evidence of this flag being used in developer applications, I've chosen to exclude this change from the breaking changes docs.
* chore: revert v8 removal
https://chromium-review.googlesource.com/c/v8/v8/+/5497515
See patch message for more details.
* chore: cherry-pick Node.js patch for V8 API removal fix
Node.js PR: https://github.com/nodejs/node/pull/52996
V8 API Removal CL: https://chromium-review.googlesource.com/c/v8/v8/+/5539888
See the patch description for more details.
* 5492183: Extensions: CodeHealth: Give enums some class
https://chromium-review.googlesource.com/c/chromium/src/+/5492183
* fixup! 5528282: Move Web Speech API .mojom files to //media/mojo/mojom https://chromium-review.googlesource.com/c/chromium/src/+/5528282
* 5514687: Reland "Add a secret handshake to the base::Feature constructor"
https://chromium-review.googlesource.com/c/chromium/src/+/5514687
* fixup! 5530163: [media] Use VideoFrame::Plane typed enum instead of nameless enum https://chromium-review.googlesource.com/c/chromium/src/+/5530163
* 5466238: PDF Viewer: add metrics to record if PDF is opened with a11y
https://chromium-review.googlesource.com/c/chromium/src/+/5466238
* 5502081: Migrate OnDisplayRemoved to OnDisplaysRemoved
https://chromium-review.googlesource.com/c/chromium/src/+/5502081
* 5539888: [api] Remove several APIs deprecated in version 12.6
https://chromium-review.googlesource.com/c/v8/v8/+/5539888
This commit essentially only removes the `only_terminate_in_safe_scope` isolate creation parameter. This undoes some work that was originally done in #35766 .
* 5498236: Make browser_tests force full async initialization for OSCrypt Async
https://chromium-review.googlesource.com/c/chromium/src/+/5498236
* fixup! 5528282: Move Web Speech API .mojom files to //media/mojo/mojom https://chromium-review.googlesource.com/c/chromium/src/+/5528282
* 5545807: Migrate most remaining NOTREACHED()
https://chromium-review.googlesource.com/c/chromium/src/+/5545807
I took a systematic approach to modifying all of our uses of `NOTREACHED` that were causing errors:
* If there was a `return` or `break` (etc.) immediately after `NOTREACHED`, I removed the control flow instruction and left the `NOTREACHED` unmodified
* All other instances were migrated to `NOTREACHED_IN_MIGRATION`
We should revisit pretty much all usage of `NOTREACHED` as an upgrade follow-up item.
* fixup! 5526034: [DoH] Remove kDnsOverHttps feature flag https://chromium-review.googlesource.com/c/chromium/src/+/5526034
Turns out the feature flags were removed in the `.cc` file, but not the
`.h` feature list file. This means that the feature flags are pretty
much officially gone. (The leftover symbols in the header are likely an
oversight from what I can gather.)
We may potentially decide to put this in the breaking changes doc if we
decide this feature flag is important enough to highlight.
* chore: bump chromium in DEPS to 127.0.6498.3
* chore: bump chromium in DEPS to 127.0.6500.0
* chore: bump chromium in DEPS to 127.0.6502.0
* chore: bump chromium in DEPS to 127.0.6504.0
* chore: bump chromium in DEPS to 127.0.6505.0
* chore: bump chromium in DEPS to 127.0.6508.0
* build: use Sha256Sum in script/sysroots.json
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5506275
* chore: update chore_add_electron_deps_to_gitignores.patch
Xref: no manual changes; patch applied with fuzz 2
* chore: update feat_allow_code_cache_in_custom_schemes.patch
Xref: no manual changes; patch applied with fuzz 1
* chore: e patches all
* fixup! build: use Sha256Sum in script/sysroots.json
`sync` succeeds now
* chore: replace absl::optional with std::optional
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5253843
* chore: update CalculatePreferredSize() to new upstream semantics
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5459174
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5541220
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5514708
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5504212
Xref: https://chromium-review.googlesource.com/516542
* chore: replace absl::optional with std::optional
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5296147
* chore: add kPip to enumeration as a no-op
https://chromium-review.googlesource.com/c/chromium/src/+/5546257
* [Autofill] Remove RenderFrame::ElementBoundsInWindow()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5553982
* chore: fix feat_add_streaming-protocol_registry_to_multibuffer_data_source.patch
need new header to pick up definition of BLINK_PLATFORM_EXPORT macro
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5463143
* chore: bump chromium in DEPS to 127.0.6510.0
* chore: update patches
* chore: fix include path for native_web_keyboard_event.h
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5541976
* chore: add currently-unused should_include_device_status arg to GetPermissionStatusForCurrentDocument()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5545382
* chore: bump chromium in DEPS to 127.0.6512.0
* chore: update mas_avoid_private_macos_api_usage.patch.patch
No manual changes; patch applied with fuzz 1
* chore: update feat_add_streaming-protocol_registry_to_multibuffer_data_source.patch
No manual changes; patch applied with fuzz 1
* chore: update webview_fullscreen.patch
No manual changes; patch applied with fuzz 1
* chore=: remove cherry-pick-22db6918bac9.patch
already present upstream
* chore: remove nonexistent patchfiles from .patches
* chore: remove cherry-pick-3e037e195e50.patch
no longer needed; merged upstream
* Update namespace for files moved to //components/input
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5563251
* Require client for InitParams to always specify an ownership mode.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5532482
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5578714
* chore: e patches all
* fixup! Update namespace for files moved to //components/input
* chore: remove profile_keyed_service_factory, profile_selections from chromium_src
already being linked in via chrome browser for printing
* chore: bump chromium in DEPS to 127.0.6515.0
* chore: bump chromium in DEPS to 127.0.6516.0
* chore: update render_widget_host_view_base.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5547803
patch applied manually due to simple upstream shear
* chore: update feat_allow_code_cache_in_custom_schemes.patch
No manual changes; patch applied with fuzz 1
* chore: e patches all
* Pull RWHIER and RWT to //content/common/input.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5397681
* chore: bump chromium in DEPS to 127.0.6517.0
* chore: update patches
* fixup: Update namespace for files moved to //components/input
* Remove 0-arg (default) constructor for views::Widget::InitParams.
https://chromium-review.googlesource.com/c/chromium/src/+/5578714
* fixup: only disable enterprise_cloud_content_analysis
The original commit a5480accc2https://chromium-review.googlesource.com/c/chromium/src/+/5527572
* chore: bump chromium in DEPS to 127.0.6519.0
* chore: update patches
* src: do not use deprecated V8 API
https://github.com/nodejs/node/pull/53084
* src: remove dependency on wrapper-descriptor-based cpp heap
https://github.com/nodejs/node/pull/53086
* 5344413: [DevTools] Add `getHostConfig` UI binding for sending status of `base::Features` to DevTools
https://chromium-review.googlesource.com/c/chromium/src/+/5344413
* 5585788: Extensions: ManifestHandler: Separate Registry like ExtensionRegistry
https://chromium-review.googlesource.com/c/chromium/src/+/5585788
* chore: update filenames.libcxx.gni
* 5506857: Reland "Migrate clang-format to gcs first class deps"
https://chromium-review.googlesource.com/c/chromium/src/+/5506857
* fixup: 5539888: [api] Remove several APIs deprecated in version 12.6
* fixup: 5506857: Reland Migrate clang-format to gcs first class deps
* chore: bump chromium in DEPS to 127.0.6521.0
* chore: update patches
* spec: update navigator.keyboard should lock the keyboard
* Block or allow all MIDI using the existing SysEx permission
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5154368
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5499157
* spec: update test/parallel/test-v8-stats
* views: remove CalculatePreferredSize()
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5504212
* chore: update patches after rebase
* 5560288: Re-enable ChromeOS XNNPack on Intel only
https://chromium-review.googlesource.com/c/chromium/src/+/5560288
* chore: add nan patches for v8 changes
Refs
5539888: [api] Remove several APIs deprecated in version 12.6 | https://chromium-review.googlesource.com/c/v8/v8/+/5539888
and
5539852: [heap][api] Remove deprecated v8::Isolate::IdleNotificationDeadline | https://chromium-review.googlesource.com/c/v8/v8/+/5539852
* 5573603: Modularize //chrome/browser/themes
https://chromium-review.googlesource.com/c/chromium/src/+/5573603
* 5539888: [api] Remove several APIs deprecated in version 12.6
https://chromium-review.googlesource.com/c/v8/v8/+/5539888
* chore: update patches
* test: fixup navigator.keyboard.lock on Windows
* chore: remove unneeded profile target
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
Co-authored-by: clavin <clavin@electronjs.org >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2024-06-07 17:18:35 -04:00
Charles Kerr
ae0c55c0b1
refactor: inherit Observer classes privately, pt. 2 ( #42237 )
...
* refactor: use private inheritance in PushNotifications
* refactor: use private inheritance in electron::api::App
* refactor: use private inheritance in electron::api::BrowserWindow
* refactor: use private inheritance in electron::api::NativeTheme
* refactor: use private inheritance in electron::api::Tray
* refactor: use private inheritance in electron::api::Session
* refactor: use private inheritance in electron::api::WebContents
* refactor: use private inheritance in electron::api::DownloadItem
* refactor: use private inheritance in electron::api::MenuBar
* refactor: use private inheritance in ClearDataOperation
* refactor: use private inheritance in electron::api::Screen
* refactor: use private inheritance in electron::ElectronDesktopWindowTreeHostLinux
* refactor: use private inheritance in SpellCheckerHolder
* refactor: use private inheritance in electron::api::PowerMonitor
* refactor: use private inheritance in electron::api::BaseWindow
* refactor: use private inheritance in electron::api::AutoUpdater
* refactor: use private inheritance in electron::api::Menu
* refactor: use private inheritance in electron::api::NativeWindowViews
* refactor: use private inheritance in electron::ElectronBrowserClient
* refactor: use private inheritance in electron::AutofillPopupView
* refactor: use private inheritance in GtkMessageBox
* refactor: use private inheritance in electron::OffScreenRenderWidgetHostView
* refactor: use private inheritance in electron::InspectableWebContents
* refactor: use private inheritance in electron::ElectronUsbDelegate
* refactor: use private inheritance in electron::LoginHandler
* refactor: use private inheritance in WebFrameRenderer
* refactor: use private inheritance in electron::ElectronSerialDelegate
* refactor: use private inheritance in electron::ClientFrameViewLinux
* refactor: use private inheritance in electron::ElectronHidDelegate
* refactor: use private inheritance in IPCRenderer
* refactor: use private inheritance in electron::WinCaptionButtonContainer
* refactor: use private inheritance in electron::ElectronApiIPCHandlerImpl
* refactor: use private inheritance in electron::api::ServiceWorkerContext
* refactor: use private inheritance in ui::FileSelectHelper
* refactor: use private inheritance in electron::api::WebContentsView
* refactor: use private inheritance in electron::api::SimpleURLLoaderWrapper
* refactor: use private inheritance in electron::api::InAppPurchase
* refactor: use private inheritance in electron::api::Debugger
* refactor: use private inheritance in electron::ElectronWebContentsUtilityHandlerImpl
* refactor: use private inheritance in electron::OffScreenWebContentsView
2024-05-29 13:07:02 -05:00
Shelley Vohr
5f785f213e
revert: add BrowserWindow.isOccluded()
...
This reverts commit 768ece6b54
2024-02-12 09:35:34 +01:00
Shelley Vohr
768ece6b54
feat: add BrowserWindow.isOccluded() ( #38982 )
...
feat: add BrowserWindow.isOccluded()
2024-02-06 11:30:35 +01:00
Milan Burda
892c9d78a3
chore: replace absl::optional<T> with std::optional<T> ( #40928 )
...
* chore: replace absl::optional<T> with std::optional<T>
* IWYU
2024-01-10 16:23:35 -06:00
Charles Kerr
f229201f41
refactor: make NativeWindow getter methods const ( #40804 )
...
* refactor: make NativeWindow getter methods const
* fixup! refactor: make NativeWindow getter methods const
make GetZOrderLevel() const
* fixup! refactor: make NativeWindow getter methods const
fix oops
2024-01-04 09:51:59 -06:00
electron-roller[bot]
8c89137ecd
chore: bump chromium to 122.0.6194.0 (main) ( #40750 )
...
* chore: bump chromium in DEPS to 122.0.6180.0
* chore: update render_widget_host_view_base.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5079532
minor manual changes to match upstream changes
* chore: update printing.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5094777
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5054299
Update patch to upstream changes in print_view_manager_base.cc.
CC @codebytere for 👀
* chore: update feat_add_onclose_to_messageport.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5083156
no manual changes; patch applied with fuzz 1
* chore: update build_do_not_depend_on_packed_resource_integrity.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5087072
minor manual changes to match upstream changes
* chore: update port_autofill_colors_to_the_color_pipeline.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4960481
no manual changes; patch applied with fuzz 2
* chore: update revert_api_dcheck-fail_when_we_reenter_v8_while_terminating.patch
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/5076902
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/5096253
The `bailout_value` variable, which allowed us to fail gracefully in
these macros, has been removed upstream. This raises the temperature
on https://github.com/electron/electron/issues/40741 ...
Since we don't have a bailout value, return a default-constructed
instance of whatever the return type is of the function that invokes
the macro.
* Remove performActionOnRemotePage
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5068017
It appears it is not used by anything within Chromium or outside.
* perf: in SubmenuButton ctor, move() the PressedCallback
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5066872
The copy construtor is more expensive and has been removed upstream
* chore: update constructor call for ElectronExtensionsRendererClient::dispatcher_
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5055146
* chore: handle CAPTURED_SURFACE_CONTROL in Converter<blink::PermissionType>::ToV8()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5096614
* chore: e patches all
* chore: bump chromium to 122.0.6181.0
* chore: e patches all
* refactor: Add lookup for per-RenderFrame SpellCheckProvider
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5075094
Previously we could pass a routing ID into the spellcheck methods.
This ID arg has been replaced with a SpellCheckHost& arg.
We can get the SpellCheckHost from an accessor in SpellCheckProvider,
which was already being created on a per-render-frame basis in
RenderClientBase.
This commit adds a RenderFrame-to-SpellCheckProvider accessor
in RenderClientBase so that it can be used to get that needed
SpellCheckHost.
* chore: make lint happy
* chore: restore the will_cause_resize arg to WebContents::ExitFullscreen
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5074445
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5031312
upstream reverted this change
* chore: bump chromium in DEPS to 122.0.6182.0
* chore: update patches
* chore: fix virtual function names that were renamed upstream
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5115241
* chore: handle new blink::PermissionType::SMART_CARD in PermissionType converter
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5049989
* chore: node script/gen-libc++-filenames.js
* fixup! chore: update build_do_not_depend_on_packed_resource_integrity.patch
* chore: remove revert_api_dcheck-fail_when_we_reenter_v8_while_terminating.patch
The previous experiment of removing the DCHECK in 35093783 was a huge
failure. We either need to either:
A) use upstream as-is and fix the DCHECK failure, or
B) revert https://chromium-review.googlesource.com/c/v8/v8/+/5076902 too
C) find some other workaround
This commit is the first half of option A, removing the patch to use
upstream as-is.
* chore: bump chromium in DEPS to 122.0.6184.0
* chore: bump chromium in DEPS to 122.0.6186.0
* chore; update mas_avoid_private_macos_api_usage.patch.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5085619
minor manual changes to match upstream changes
* chore: update build_do_not_depend_on_packed_resource_integrity.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5120922
minor manual changes to match upstream changes
* chore: update fix_move_autopipsettingshelper_behind_branding_buildflag.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5041595
no manual changes; patch applied with fuzz 1
* chore: e patches all
* chore: add refactor_update_node-platform_to_match_v8-platform_api_changes.patch
* chore: bump chromium in DEPS to 122.0.6188.0
* chore: bump chromium in DEPS to 122.0.6190.0
* chore: bump chromium in DEPS to 122.0.6192.0
* chore: bump chromium in DEPS to 122.0.6194.0
* Remove an unnecessary DCHECK which causes Lacros to crash.
https://chromium-review.googlesource.com/c/chromium/src/+/5124880
* [FixIt Week] Add shared regular profile function that includes ash
https://chromium-review.googlesource.com/c/chromium/src/+/5100709
* Simplify the PrintManagerHost::ScriptedPrint() call
https://chromium-review.googlesource.com/c/chromium/src/+/5019703
* [local compile hints] Add tests
https://chromium-review.googlesource.com/c/chromium/src/+/5024173
* chore: update patches
* fixup! chore: add refactor_update_node-platform_to_match_v8-platform_api_changes.patch
* chore: node script/gen-libc++-filenames.js
* Remove //ui/ozone/buildflags.h
https://chromium-review.googlesource.com/c/chromium/src/+/5119048
* fixup! Remove //ui/ozone/buildflags.h
* fixup! Remove //ui/ozone/buildflags.h
* chore: update patches
* fixup! refactor: Add lookup for per-RenderFrame SpellCheckProvider
* fixup! Remove //ui/ozone/buildflags.h
* Add permission policy verification in PermissionControllerImpl
https://chromium-review.googlesource.com/c/chromium/src/+/5059112
* fix: ensure spellcheck interface is registered for frame
* [exceptions] Unify pending and scheduled exceptions
https://chromium-review.googlesource.com/c/v8/v8/+/5050065
* fix: dchecks in node.js tests
* fix: try adding termination check
* chore: document breaking iframe change
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-01-03 09:52:49 +01:00
Jeremy Rose
15c6014324
feat: replace BrowserView with WebContentsView ( #35658 )
2023-12-13 13:01:03 -08:00
Tomasz
3340bc1bf9
fix: maximized window bounds when toggle setResizable ( #40503 )
2023-11-22 15:21:18 +09:00
Milan Burda
04b2ba84cd
refactor: replace remaining NULL with nullptr ( #40053 )
...
refactor: use nullptr everywhere
2023-10-03 12:26:35 -07:00
tr2-harada
9937a2bbe8
fix: explorer restart does not recreated thumbnail toolbar buttons ( #39551 )
...
fix: explorer restart does not recreated thumbnail toolbar buttons.
2023-08-21 09:43:49 +09:00
Cheng Zhao
3fa15ebb7e
fix: use Chromium's way to compute min/max sizes ( #38974 )
2023-07-05 11:02:05 -04:00
Charles Kerr
5ad8b4b7d1
chore: remove unused std includes ( #38767 )
2023-06-14 11:07:18 -07:00
wgsheng
c8bdd014c8
fix: menu bar visibility when exiting full screen ( #38599 )
2023-06-08 12:19:34 +02:00
Charles Kerr
83d023747c
refactor: use direct aggregation in NativeWindowViews ( #38559 )
...
* refactor: in NativeWindowViews, aggregate root_view_ directly
* refactor: in NativeWindowViews, aggregate keyboard_event_handler_ directly
* refactor: make NativeWindowClientView::window_ a raw_ref
Xref: https://chromium.googlesource.com/chromium/src/+/main/styleguide/c++/c++.md\#non_owning-pointers-in-class-fields
Prefer const raw_ref<T> whenever the held pointer will never be null
* chore: make lint happy
2023-06-05 14:37:46 +09:00
Shelley Vohr
e19500fa03
feat: support Mica/Acrylic on Windows ( #38163 )
...
* feat: support Mica/Acrylic on Windows
* chore: feedback from review
2023-05-15 16:31:57 -04:00
John Kleinschmidt
3dbc0a365f
chore: enable check raw ptr fields ( #38167 )
2023-05-11 16:07:39 -04:00
Jeremy Rose
8a926ffde4
refactor: use views NonClientHitTest for draggable regions on mac ( #35603 )
...
* refactor: use views NonClientHitTest for draggable regions on mac
* iwyu
* add backport of 9bb5f0316
* chore: update patches
* remove some unneeded functions
* remove test for triggering when BW is focused
* chore: update patches
* simplify views/mac split now that the draggable logic is the same
* Apply suggestions from code review
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* Update shell/browser/native_window.h
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* fix build
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2022-10-12 12:05:45 -04:00
Shelley Vohr
b42fd1ddca
fix: handle WCO pressed state when going maximized -> minimized ( #35070 )
2022-07-26 13:30:15 -04:00
Marek Rusinowski
cdf2b3f4e4
fix: calling of X11 functions when running under Wayland ( #33355 )
...
* fix: don't call X11 functions in file dialog and message box
* refactor: remove unused GtkUiPlatform declaration
* fix: set gtk darktheme only when running under X11
* fix: replace X11 window state watcher with implementation using ozone
* fix: make sure global menu barr is used only when supported
* fix: don't call X11 function in native window views under wayland
* style: fix lint issues
* fix: use GtkUiPlatform::ShowGtkWindow instead of gtk_window_present directly
* refactor: extract CreateGlobalMenuBar into separate function
* refactor: move checking for WaylandWindowDecorations inside class
* fix: check if we run under X11 only in ozone build
* refactor: drop including unused ui/base/ui_base_features.h header
* fix: modify ui_gtk_public_header.patch to also export gtk_ui.h
* fix: refactor guarding of X11 calls
- Introduce patch exposing new electron_can_call_x11 property
- Replace defined(USE_OZONE) with BUILDFLAG(OZONE_PLATFORM_X11) flags
* fix: remove the last remaining usage of USE_X11
* fix: usage of BUILDFLAG(OZONE_PLATFORM_X11) not building on non ozone
* fix: call UpdateWindowState from OnBoundsChanged only under X11
2022-03-28 12:48:50 -04:00
electron-roller[bot]
7e59d784a0
chore: bump chromium to 102.0.4961.0 (main) ( #33091 )
...
* chore: bump chromium in DEPS to 101.0.4911.0
* chore: bump chromium in DEPS to 101.0.4913.0
* chore: bump chromium in DEPS to 101.0.4915.0
* chore: bump chromium in DEPS to 101.0.4917.0
* chore: bump chromium in DEPS to 101.0.4919.0
* chore: bump chromium in DEPS to 101.0.4921.0
* chore: bump chromium in DEPS to 101.0.4923.0
* chore: bump chromium in DEPS to 101.0.4925.0
* chore: bump chromium in DEPS to 101.0.4927.0
* chore: bump chromium in DEPS to 101.0.4929.0
* chore: update patches
* chore: bump chromium in DEPS to 101.0.4931.0
* chore: update patches
* 3475388: Remove mojo::InterfacePtr<T> and mojo::InterfacePtrInfo<T>
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3475388
Actual fixes in 1824792: Migrate DisplayClient to the new Mojo types | https://chromium-review.googlesource.com/c/chromium/src/+/1824792
* 3503874: Remove base::size(), base::empty(), and base::data().
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3503874
* chore: reconcile patches with main rebase
* chore: bump chromium in DEPS to 101.0.4933.0
* chore: update patches
* 3329593: [Fenced Frame] Ensure to support external protocols in a fenced frame
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3329593
* 3503874: Remove base::size(), base::empty(), and base::data().
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3503874
* 3446451: Use forward decl of ImageSkiaRep in //ui/gfx/image/image_skia.h
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3446451
* 3499818: partition_alloc: Rename AllocFlags to AllocWithFlags
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3499818
* chore: bump chromium in DEPS to 101.0.4935.0
* chore: update patches
* 3463286: partition_alloc: Move PartitionAlloc into the own namespaces (15 of N)
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3463286
* 3506590: Reland "Support ChromeOS external protocol dialog for Fenced Frame navigations"
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3506590
* 3475388: Remove mojo::InterfacePtr<T> and mojo::InterfacePtrInfo<T>
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3475388
Actual fixes in 1880987: Convert URLLoaderReqeust from //content to new Mojo types | https://chromium-review.googlesource.com/c/chromium/src/+/1880987 The change in the roll started causing the legacy types to fail
* chore: missing SkRegion include
* 3499600: Introduce blink::WebCssOrigin
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3499600
* fixup!: 3503874: Remove base::size(), base::empty(), and base::data().
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3503874
* chore: bump chromium in DEPS to 101.0.4937.0
* chore: update patches
* 3500826: [locales] Refactor locales for ios
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3500826
* 3509531: Make some public Blink media files private
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3509531
* 3497377: bluetooth: Add BluetoothDevice.forget()
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3497377
* chore: bump chromium in DEPS to 101.0.4939.0
* chore: bump chromium in DEPS to 101.0.4941.0
* 3514804: Deprecate all existing uses of mojo_base.mojom.{Dictionary,List}Value.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3514804
* 3502592: Delete PPAPI init/shutdown code in //pdf.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3502592
* chore: update patches
* fixup! 3502592: Delete PPAPI init/shutdown code in //pdf.
* chore: bump chromium in DEPS to 101.0.4943.0
* chore: fix lint, remove unneeded headers
* fixup! 3475388: Remove mojo::InterfacePtr<T> and mojo::InterfacePtrInfo<T>
* update mojo calls in offscreen patch
* update hunspell filenames
* chore: bump chromium in DEPS to 101.0.4945.0
* chore: update patches
* fix offscreen patch again
* chore: bump chromium in DEPS to 101.0.4947.0
* chore: update patches
* chore: bump chromium in DEPS to 101.0.4949.0
* support unseasoned pdf
* update patches
* chore: update patches
* chore: [IWYU] include missing skia headers
* chore: bump chromium in DEPS to 101.0.4951.0
* chore: update patches
* 3457645: media: Remove IsKeySystemsUpdateNeeded()
https://chromium-review.googlesource.com/c/chromium/src/+/3457645
* chore: bump chromium in DEPS to 102.0.4952.2
* chore: update patches
* 3488672: Add documentId as a parameter in tabs.connect() and tabs.sendMessage().
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3488672
* 3508375: Fix an issue dangerous dialog is not shown for some apk download
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3508375
* chore: bump chromium in DEPS to 102.0.4953.0
* chore: update patches
* 3510189: Harden up drag and drop support across same-process boundaries.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3510189
* 3526815: Remove hardcoded colors from chrome/browser/ui/views/overlay/.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3526815
* chore: bump chromium in DEPS to 102.0.4955.0
* build: add af and ur locale to manifests
3498914 [locales] Add af and ur to desktop
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3498914
* fixup! build: add af and ur locale to manifests
* chore: bump chromium in DEPS to 102.0.4957.0
* 3529090: gin: set JS flags before v8 initialization
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3529090
chore: fix code shear in chromium/gin_enable_disable_v8_platform.patch
* chore: update patches
* 3536433: [network] Rename data_path and http_cache_path from _path to _directory.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3536433
* 3111565: Relocated Page.printToPDF implementation to //components
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3111565
refactor: inject E args to PrintRequestedPages() and ScriptedPrintCallback
TODO: currently passes a placeholder for job_settings. We have other
code paths that inject settings from electron_api_web_contents.cc.
Should those be injected here as well? (CC @codebytere)
* fixup! 3111565: Relocated Page.printToPDF implementation to //components
* fixup! 3111565: Relocated Page.printToPDF implementation to //components
* 3520025: Make "libcxx_abi_unstable" not a gn arg
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3520025
build: since it is no longer a gn arg, patch it in
* chore: change usages of std::vector with const elements (#33373 )
* chore: bump chromium in DEPS to 102.0.4959.0
* chore: update patches
* build: iwyu base/threading/platform_thread.h
* 3525774: Add GPSForCurrentDocument() into PermissionControllerDelegate.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3525774
refactor: copy upstream impl of GetPermissionStatusForCurrentDocument into +ElectronPermissionManager
* use gclient_gn_args_from instead of hand-copying
* checkout mac on mac
* chore: update patches
* Revert "checkout mac on mac"
This reverts commit fe9ccf49ec6dfdf79b8chttps://reviews.llvm.org/D101458
Upstream added a CMakeLists.txt in an include dir ¯\_(ツ)_/¯ and
so it must be enumerated in filenames.libcxxabi.gni
* 3511268: Remove unused headers from cxx17_backports.h
https://chromium-review.googlesource.com/c/chromium/src/+/3511268
use std::size instead of base::size
* iwyu: SkPaint
3488428: [includes] Fix transitive includes of SkImageEncoder
* chore: [IWYU] include missing skia headers
* fixup! 3511268: Remove unused headers from cxx17_backports.h
* chore: bump chromium in DEPS to 102.0.4961.0
* chore: update patches
* fixup! 3475388: Remove mojo::InterfacePtr<T> and mojo::InterfacePtrInfo<T>
chore: remove unused #include
* fixup! 3510189: Harden up drag and drop support across same-process boundaries. | https://chromium-review.googlesource.com/c/chromium/src/+/3510189
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
Co-authored-by: VerteDinde <keeleymhammond@gmail.com >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2022-03-24 21:39:03 -04:00
