github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-09 15:38:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

refactor: in auto_updater::AutoUpdater, move empty function decls to header

Browse Source
This commit is contained in:
Charles Kerr
2024-08-09 13:21:41 -05:00
parent a732b3ef48
commit c43d6862d3
2 changed files with 3 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
shell/browser/auto_updater.cc
View File

@@ -22,12 +22,6 @@ std::string AutoUpdater::GetFeedURL() {
return "";
}
void AutoUpdater::SetFeedURL(gin::Arguments* args) {}
void AutoUpdater::CheckForUpdates() {}
void AutoUpdater::QuitAndInstall() {}
bool AutoUpdater::IsVersionAllowedForUpdate(const std::string& current_version,
const std::string& target_version) {
return false;

6
shell/browser/auto_updater.h
View File

@@ -64,9 +64,9 @@ class AutoUpdater {
// FIXME(zcbenz): We should not do V8 in this file, this method should only
// accept C++ struct as parameter, and atom_api_auto_updater.cc is responsible
// for parsing the parameter from JavaScript.
static void SetFeedURL(gin::Arguments* args);
static void CheckForUpdates();
static void QuitAndInstall();
static void SetFeedURL(gin::Arguments* args) {}
static void CheckForUpdates() {}
static void QuitAndInstall() {}
static bool IsVersionAllowedForUpdate(const std::string& current_version,
const std::string& target_version);