Shelley Vohr
5bbac9ae30
test: add tests for Storage Access API ( #41863 )
2024-04-15 13:03:33 -05:00
Alice Zhao
97eee463fa
feat: add navigationHistory.getEntryAtIndex(int index) method ( #41661 )
...
* feat: add `navigationHistory.getEntryAtIndex(int index)` method (#41577 )
* chore: remove code not related to this pr:
* test: fix flaky tests by replacing real urls with data urls
* test: remove hardcoded url
2024-04-04 13:09:19 -04:00
trop[bot]
fe4d3a2484
docs: add missing headers option to ClientRequest options ( #41730 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2024-04-01 11:33:37 -04:00
trop[bot]
f9e28e3e50
fix: Storage.{get|set|clear}Cookies via CDP not working ( #41739 )
...
* fix: Storage.{get|set|clear}Cookies via CDP not working
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: simplify BrowserContext plumbing
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-03-29 09:51:43 -05:00
trop[bot]
3b025ec0c7
test: add test and api_feature definition for chrome.scripting.globalParams ( #41699 )
...
chore: add test and api_feature for chrome.scripting.globalParams
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-03-27 10:20:29 +01:00
trop[bot]
9ce58dd0ea
ci: use CircleCI hosted macOS arm64 runners for testing ( #41655 )
...
* ci: use CircleCI hosted macOS arm64 runners for testing
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* chore: update patches
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2024-03-21 19:02:13 -04:00
trop[bot]
c00489396b
fix: chrome://process-internals failing to load ( #41542 )
...
fix: chrome://process-internals failing to load
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-03-12 20:35:47 +01:00
John Kleinschmidt
33e61a19ef
test: disable CapturableScreen tests on Windows x64 ( #41544 )
...
* test: disable CapturableScreen tests on Windows x64
(cherry picked from commit 60a288a2cad545ae049b
2024-03-08 09:29:28 -05:00
trop[bot]
fd2620bda4
fix: webContents.print options should be optional ( #41479 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-03-01 17:08:55 -05:00
trop[bot]
af47434dc8
feat: add support for configuring system network context proxies ( #41416 )
...
* feat: add support for configuring system network context proxies
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* chore: add specs
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* chore: fix lint
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* fix: address review feedback
Co-authored-by: deepak1556 <hop2deep@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2024-02-23 14:56:30 -06:00
Keeley Hammond
09fbee9998
fix: check for draggable regions outside of main frame ( #41388 )
...
* fix: check for draggable regions outside of main frame
* fix: add nut-js to optional spec deps
Co-authored-by: samuelmaddock <samuelmaddock@electronjs.org >
---------
Co-authored-by: samuelmaddock <samuelmaddock@electronjs.org >
2024-02-21 10:52:02 -05:00
trop[bot]
b6db80c1c4
fix: properly stream uploadData in protocol.handle() ( #41359 )
...
* refactor(protocol): extract file stream factory
Increase readability by moving the file stream creation logic out of the
`uploadData` to request body conversion function.
Co-authored-by: Henrik S. Gaßmann <BurningEnlightenment@users.noreply.github.com >
* fix: properly flatten streams in `protocol.handle()`
Refs: electron/electron#39658
Co-authored-by: Henrik S. Gaßmann <BurningEnlightenment@users.noreply.github.com >
* fix: `protocol.handle()` filter null origin header
Refs: electron/electron#40754
Co-authored-by: Henrik S. Gaßmann <BurningEnlightenment@users.noreply.github.com >
* fix: remove obsolete TODO comment
Refs: electron/electron#38929
Co-authored-by: Henrik S. Gaßmann <BurningEnlightenment@users.noreply.github.com >
* fix: forward `Blob` parts in `protocol.handle()`
Refs: electron/electron#40826
Co-authored-by: Henrik S. Gaßmann <BurningEnlightenment@users.noreply.github.com >
* fix: explicitly error out on unknown chunk parts
Co-authored-by: Henrik S. Gaßmann <BurningEnlightenment@users.noreply.github.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Henrik S. Gaßmann <BurningEnlightenment@users.noreply.github.com >
2024-02-19 12:23:14 -08:00
Shelley Vohr
9bb821a818
fix: check for Node.js-created module when contextIsolation disabled ( #41265 )
...
fix: check for Node.js-created module when contextIsolation disabled
2024-02-09 10:54:59 +09:00
Shelley Vohr
288ec2ed93
fix: validate printToPDF margins against pageSize ( #41266 )
...
fix: validate `printToPDF` `margins` against `pageSize` (#41157 )
fix: validate margins against pageSize
2024-02-08 11:15:45 +09:00
trop[bot]
16764199a7
fix: original-fs import replacement ( #41238 )
...
fix: original-fs import replacement
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-02-05 17:03:08 -05:00
trop[bot]
4113f9d6a6
fix: crash problem with message_port close event ( #41237 )
...
When worker_thread shutdown, it will destory context and close
message_port. In this case, it should not dispatch close event.
Because it forbid script running during NotifyContextDestroyed in
ContextLifecycleNotifier.
Now chromium has implemented close_event and will not crash,
so we remove the patch with #22532 and add one test.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Jinli Wu <wujinli@bytedance.com >
2024-02-05 10:47:02 +01:00
trop[bot]
31054d6d46
docs: document printToPDF generateDocumentOutline option ( #41167 )
...
* doc: document printToPDF generateDocumentOutline option
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* doc: ready event to whenReady
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-01-31 12:03:28 +01:00
trop[bot]
25f52d5d32
fix: potential async_hooks crash in NotifyWindowRestore on Windows ( #41146 )
...
* fix: potential async_hooks crash in NotifyWindowRestore on Windows
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fix: don't use CallbackScope for Error objects
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-01-29 10:11:46 +01:00
trop[bot]
d92ffceafb
fix: apply module search paths restriction on worker and child process ( #41138 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Cheng Zhao <zcbenz@gmail.com >
2024-01-26 09:28:26 -06:00
electron-roller[bot]
9daf416097
chore: bump chromium to 122.0.6261.6 (29-x-y) ( #40959 )
...
* chore: bump chromium in DEPS to 122.0.6240.1
* chore: bump chromium in DEPS to 122.0.6241.6
* chore: bump chromium in DEPS to 122.0.6245.1
* chore: bump chromium in DEPS to 122.0.6247.1
* chore: bump chromium in DEPS to 122.0.6249.1
* chore: bump chromium in DEPS to 122.0.6251.1
* chore: bump chromium in DEPS to 122.0.6253.1
* chore: bump chromium in DEPS to 122.0.6255.1
* chore: bump chromium in DEPS to 122.0.6257.1
* chore: bump chromium in DEPS to 122.0.6259.1
* chore: bump chromium in DEPS to 122.0.6259.3
* chore: bump chromium in DEPS to 122.0.6259.5
* chore: bump chromium in DEPS to 122.0.6260.0
* chore: bump chromium in DEPS to 122.0.6261.1
* chore: bump chromium in DEPS to 122.0.6261.6
* chore: update patches
(cherry picked from commit dde66c3589https://chromium-review.googlesource.com/c/chromium/src/+/5171926
(cherry picked from commit c7031d5c0595b04b1fcahttps://chromium-review.googlesource.com/c/chromium/src/+/5192010
(cherry picked from commit 55e5867614https://chromium-review.googlesource.com/c/chromium/src/+/5109767
(cherry picked from commit 7b2efc7586https://chromium-review.googlesource.com/c/chromium/src/+/5105227
(cherry picked from commit 10d61636c6d04ebc7b07https://chromium-review.googlesource.com/c/chromium/src/+/5180720
(cherry picked from commit 3dbbb67dbc18a5961e4e69e0bfefcchttps://chromium-review.googlesource.com/c/chromium/src/+/5186276
(cherry picked from commit 412f70681ae4d2a2ded0https://chromium-review.googlesource.com/c/chromium/src/+/5190661
(cherry picked from commit 6b41b72130https://chromium-review.googlesource.com/c/chromium/src/+/5206106
(cherry picked from commit 9a788c0c60https://chromium-review.googlesource.com/c/chromium/src/+/5202674
(cherry picked from commit 55daca952dhttps://chromium-review.googlesource.com/c/chromium/src/+/5109767
(cherry picked from commit 047898ba92715c534cd8https://chromium-review.googlesource.com/c/chromium/src/+/5207474
(cherry picked from commit 9a10062d8ca1f643b25ehttps://chromium-review.googlesource.com/c/chromium/src/+/5186276
(cherry picked from commit e3c40ed923https://chromium-review.googlesource.com/c/chromium/src/+/5191363
(cherry picked from commit 8037cef988https://chromium-review.googlesource.com/c/chromium/src/+/5186276
(cherry picked from commit e60c31dd4fhttps://chromium-review.googlesource.com/c/chromium/src/+/5207474
(cherry picked from commit b02108e0c096e8574115e0f51957be4057b5439chttps://chromium-review.googlesource.com/c/chromium/src/+/5181931
(cherry picked from commit 6ad8028fe8https://chromium-review.googlesource.com/c/chromium/src/+/5142354
(cherry picked from commit a871198a23https://chromium-review.googlesource.com/c/chromium/src/+/5171446
(cherry picked from commit ebf2efceddhttps://chromium-review.googlesource.com/c/chromium/src/+/5213708
(cherry picked from commit c361ded147https://chromium-review.googlesource.com/c/chromium/src/+/5202765
(cherry picked from commit 63d2773d15https://chromium-review.googlesource.com/c/chromium/src/+/5168626
(cherry picked from commit a4b5c9ce31979bde6683https://chromium-review.googlesource.com/c/chromium/src/+/5191363
(cherry picked from commit 759f1740a8https://chromium-review.googlesource.com/c/chromium/src/+/5167921
Also
5148392: PinnedState: Support pinned state in PlatformWindowState | https://chromium-review.googlesource.com/c/chromium/src/+/5148392
(cherry picked from commit 53d9c82a57https://chromium-review.googlesource.com/c/chromium/src/+/5180720
(cherry picked from commit e565db5095https://chromium-review.googlesource.com/c/chromium/src/+/5170669
(cherry picked from commit 5409118134https://chromium-review.googlesource.com/c/chromium/src/+/5178824
(cherry picked from commit 3d53a6ec013a6a335a05samuel.r.attard@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: VerteDinde <vertedinde@electronjs.org >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-01-25 15:19:31 -05:00
Keeley Hammond
12f4204824
revert: replace BrowserView with WebContentsView ( #41060 )
...
Revert "feat: replace BrowserView with WebContentsView (#40759 )"
This reverts commit bd304f7c9d
2024-01-22 08:53:02 -08:00
trop[bot]
b84beed666
chore: cleanup tests creating crashpad handler in the test runner process ( #41053 )
...
* chore: cleanup tests creating crashpad handler in the test runner process
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* ci: logging
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* ci: enable logging
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* ci: more logging
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* ci: run all tests
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* ci: more logging
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* ci: increase timeout
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* Revert "ci: increase timeout"
This reverts commit 870f74455dhop2deep@gmail.com >
* Revert "ci: more logging"
This reverts commit 46837f8b3ahop2deep@gmail.com >
* Revert "ci: run all tests"
This reverts commit 6a7889ce67hop2deep@gmail.com >
* Revert "ci: more logging"
This reverts commit 351473ab43hop2deep@gmail.com >
* Revert "ci: enable logging"
This reverts commit 194109ed5ahop2deep@gmail.com >
* Revert "ci: logging"
This reverts commit 9a3396fc7ahop2deep@gmail.com >
* chore: disable flaky ia32 tests
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* chore: fixup .patches after trop
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-01-19 09:53:20 +01:00
trop[bot]
ebeb8adaf4
fix: crash when dialog.showMessageBoxSync with missing buttons ( #41043 )
...
* fix: crash when dialog.showMessageBoxSync missing buttons
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: feedback from review
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-01-18 20:35:53 -05:00
trop[bot]
d5433ec0cc
test: fixup assertNotWindows ( #41048 )
...
* chore: fixup assertNotWindows
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* remove logging
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-01-18 16:19:52 -05:00
trop[bot]
02dfdce54a
fix: InAppPurchase pre-emptive deallocation ( #40957 )
...
* fix: InAppPurchase pre-emptive deallocation
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* test: try re-enabling IAP tests
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-01-11 19:41:36 +01:00
trop[bot]
bd304f7c9d
feat: replace BrowserView with WebContentsView ( #40759 )
...
* feat: replace BrowserView with WebContentsView
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
* Update appveyor.yml
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2024-01-11 13:10:11 -05:00
trop[bot]
ddb1c784d0
build: use container runner for arm tests ( #40934 )
...
* build: use aks arm64 test runners
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
* build: better image
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
* build: even more stuff
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
* build: arm par
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
* build: use aks arm32
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
* build: arm32 par
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
* build: get test timings from abs paths
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
* build: avoid realpath, use echo
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
* chore: fix contentTracing test
* cry
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
2024-01-11 00:27:47 +13:00
trop[bot]
5728d3b709
feat: add net module to utility process ( #40890 )
...
* chore: initial prototype of net api from utility process
* chore: update url loader to work on both browser and utility processes
* chore: add net files to utility process bundle
* chore: re-add app ready check but only on main process
* chore: replace browser thread dcheck's with sequence checker
* refactor: move url loader from browser to common
* refactor: move net-client-request.ts from browser to common
* docs: add utility process to net api docs
* refactor: move net module app ready check to browser only
* refactor: switch import from main to common after moving to common
* test: add basic net module test for utility process
* refactor: switch browser pid with utility pid
* refactor: move electron_api_net from browser to common
* chore: add fetch to utility net module
* chore: add isOnline and online to utility net module
* refactor: move net spec helpers into helper file
* refactor: break apart net module tests
Adds two additional net module test files: `api-net-session-spec.ts` for
tests that depend on a session being available (aka depend on running on
the main process) and `api-net-custom-protocols-spec.ts` for custom
protocol tests. This enables running `api-net-spec.ts` in the utility
process.
* test: add utility process mocha runner to run net module tests
* docs: add utility process to net module classes
* refactor: update imports in lib/utility to use electron/utility
* chore: check browser context before using in main process
Since the browser context supplied to the SimpleURLLoaderWrapper can now
be null for use in the UtilityProcess, adding a null check for the main
process before use to get a more sensible error if something goes wrong.
* chore: remove test debugging
* chore: remove unnecessary header include
* docs: add utility process net module limitations
* test: run net module tests in utility process individually
* refactor: clean up prior utility process net tests
* chore: add resolveHost to utility process net module
* chore: replace resolve host dcheck with sequence checker
* test: add net module tests for net.resolveHost
* docs: remove utility process limitation for resolveHost
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Devraj Mehta <devm33@github.com >
2024-01-08 15:39:56 -06:00
trop[bot]
0778cc70bb
fix: macOS maximize button shouldn't be disabled just because the window is non-fullscreenable ( #40897 )
...
* fix: macOS maximize button shouldn't be disabled just because the window is non-fullscreenable
Co-authored-by: Tamás Zahola <tzahola@gmail.com >
* add test
Co-authored-by: Tamás Zahola <tzahola@gmail.com >
* fix test by enabling maximize button if `resizable && (maximizable || fullscreenable)` instead of `(resizable && maximizable) && fullscreenable`
Co-authored-by: Tamás Zahola <tzahola@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Tamás Zahola <tzahola@gmail.com >
2024-01-08 21:24:57 +01:00
trop[bot]
e1ec17d641
chore: bump chromium to 122.0.6194.0 (29-x-y) ( #40872 )
...
* chore: bump chromium in DEPS to 122.0.6180.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: update render_widget_host_view_base.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5079532
minor manual changes to match upstream changes
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: update printing.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5094777
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5054299
Update patch to upstream changes in print_view_manager_base.cc.
CC @codebytere for 👀
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: update feat_add_onclose_to_messageport.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5083156
no manual changes; patch applied with fuzz 1
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: update build_do_not_depend_on_packed_resource_integrity.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5087072
minor manual changes to match upstream changes
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: update port_autofill_colors_to_the_color_pipeline.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4960481
no manual changes; patch applied with fuzz 2
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: update revert_api_dcheck-fail_when_we_reenter_v8_while_terminating.patch
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/5076902
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/5096253
The `bailout_value` variable, which allowed us to fail gracefully in
these macros, has been removed upstream. This raises the temperature
on https://github.com/electron/electron/issues/40741 ...
Since we don't have a bailout value, return a default-constructed
instance of whatever the return type is of the function that invokes
the macro.
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* Remove performActionOnRemotePage
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5068017
It appears it is not used by anything within Chromium or outside.
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* perf: in SubmenuButton ctor, move() the PressedCallback
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5066872
The copy construtor is more expensive and has been removed upstream
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: update constructor call for ElectronExtensionsRendererClient::dispatcher_
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5055146
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: handle CAPTURED_SURFACE_CONTROL in Converter<blink::PermissionType>::ToV8()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5096614
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: e patches all
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: bump chromium to 122.0.6181.0
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: e patches all
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: Add lookup for per-RenderFrame SpellCheckProvider
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5075094
Previously we could pass a routing ID into the spellcheck methods.
This ID arg has been replaced with a SpellCheckHost& arg.
We can get the SpellCheckHost from an accessor in SpellCheckProvider,
which was already being created on a per-render-frame basis in
RenderClientBase.
This commit adds a RenderFrame-to-SpellCheckProvider accessor
in RenderClientBase so that it can be used to get that needed
SpellCheckHost.
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: make lint happy
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: restore the will_cause_resize arg to WebContents::ExitFullscreen
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5074445
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5031312
upstream reverted this change
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: bump chromium in DEPS to 122.0.6182.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: update patches
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
* chore: fix virtual function names that were renamed upstream
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5115241
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: handle new blink::PermissionType::SMART_CARD in PermissionType converter
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5049989
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: node script/gen-libc++-filenames.js
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* fixup! chore: update build_do_not_depend_on_packed_resource_integrity.patch
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: remove revert_api_dcheck-fail_when_we_reenter_v8_while_terminating.patch
The previous experiment of removing the DCHECK in 35093783 was a huge
failure. We either need to either:
A) use upstream as-is and fix the DCHECK failure, or
B) revert https://chromium-review.googlesource.com/c/v8/v8/+/5076902 too
C) find some other workaround
This commit is the first half of option A, removing the patch to use
upstream as-is.
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: bump chromium in DEPS to 122.0.6184.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: bump chromium in DEPS to 122.0.6186.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore; update mas_avoid_private_macos_api_usage.patch.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5085619
minor manual changes to match upstream changes
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: update build_do_not_depend_on_packed_resource_integrity.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5120922
minor manual changes to match upstream changes
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: update fix_move_autopipsettingshelper_behind_branding_buildflag.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5041595
no manual changes; patch applied with fuzz 1
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: e patches all
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: add refactor_update_node-platform_to_match_v8-platform_api_changes.patch
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: bump chromium in DEPS to 122.0.6188.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: bump chromium in DEPS to 122.0.6190.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: bump chromium in DEPS to 122.0.6192.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: bump chromium in DEPS to 122.0.6194.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* Remove an unnecessary DCHECK which causes Lacros to crash.
https://chromium-review.googlesource.com/c/chromium/src/+/5124880
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* Add shared regular profile function that includes ash
https://chromium-review.googlesource.com/c/chromium/src/+/5100709
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* Simplify the PrintManagerHost::ScriptedPrint() call
https://chromium-review.googlesource.com/c/chromium/src/+/5019703
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* Add tests
https://chromium-review.googlesource.com/c/chromium/src/+/5024173
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* chore: update patches
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* fixup! chore: add refactor_update_node-platform_to_match_v8-platform_api_changes.patch
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* chore: node script/gen-libc++-filenames.js
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* Remove //ui/ozone/buildflags.h
https://chromium-review.googlesource.com/c/chromium/src/+/5119048
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* fixup! Remove //ui/ozone/buildflags.h
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* fixup! Remove //ui/ozone/buildflags.h
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* chore: update patches
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* fixup! refactor: Add lookup for per-RenderFrame SpellCheckProvider
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* fixup! Remove //ui/ozone/buildflags.h
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* Add permission policy verification in PermissionControllerImpl
https://chromium-review.googlesource.com/c/chromium/src/+/5059112
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* fix: ensure spellcheck interface is registered for frame
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* Unify pending and scheduled exceptions
https://chromium-review.googlesource.com/c/v8/v8/+/5050065
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* fix: dchecks in node.js tests
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* fix: try adding termination check
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: document breaking iframe change
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: update patches after trop
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-01-04 16:17:50 -05:00
trop[bot]
f589b73dee
fix: ignore all NODE_ envs from foreign parent in node process ( #40881 )
2024-01-04 11:52:03 +01:00
trop[bot]
44f29fc675
fix: make grant_file_protocol_extra_privileges fuse also block CORS fetches ( #40864 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2024-01-03 13:30:26 +01:00
Cheng Zhao
cb0da6ff34
fix: prevent node mode to be used as script runner by other apps ( #40579 )
2023-12-06 11:23:54 +09:00
Cheng Zhao
9aa73abe78
feat: enable code cache for custom protocols ( #40544 )
2023-12-06 11:22:41 +09:00
Jeremy Rose
85bc005cd6
refactor: move JS dialog handling to JS ( #40598 )
2023-12-05 17:36:23 -08:00
Robo
3a510a26d0
chore: cleanup global reject handler leaking into tests ( #40689 )
2023-12-05 12:56:51 +09:00
Shelley Vohr
10a165a9ff
fix: webview zoom level persistence on navigation ( #40650 )
2023-12-04 10:39:20 -05:00
Albert Xing
3609fc7402
fix: clean up devtools frontend_host on webcontents destroy ( #40666 )
...
* fix: clean up devtools frontend_host on destroy
* chore: use IsInPrimaryMainFrame instead of IsInMainFrame
* test: add a test for re-opening devtools
2023-12-01 11:37:52 -08:00
Tamás Zahola
39ee94089a
fix: add missing set_wants_to_be_visible(true) to NativeWindowMac::ShowInactive() ( #40546 )
...
* fix: add missing set_wants_to_be_visible(true) to NativeWindowMac::ShowInactive()
* add test
2023-11-30 12:43:22 +01:00
Tomasz
3340bc1bf9
fix: maximized window bounds when toggle setResizable ( #40503 )
2023-11-22 15:21:18 +09:00
Samuel Attard
d6bb9b40b0
feat: add webUtils module with getPathForFile method ( #38776 )
...
* feat: add blinkUtils module with getPathForFile method
This is designed to replace the File.path augmentation
we currently have in place to allow apps to get the filesystem
path for a file that blink has a representation of.
File.path is non-standard and messes with certain websites, using
a method like this is effectively 0-cost and removes one of the final
deviations we have with web standards.
* add error
* refactor: update per PR feedback
* chore: update patches
* oops
* chore: update patches
* chore: update patches
* feat: add blinkUtils module with getPathForFile method
This is designed to replace the File.path augmentation
we currently have in place to allow apps to get the filesystem
path for a file that blink has a representation of.
File.path is non-standard and messes with certain websites, using
a method like this is effectively 0-cost and removes one of the final
deviations we have with web standards.
* add error
* refactor: update per PR feedback
* chore: update patches
* oops
* chore: update patches
* chore: update patches
* chore: update patches
* fix: provide isolate to WebBlob::FromV8Value
* chore: add tests
* build: fix depshash mismatch on arm64 macOS
---------
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-11-20 15:59:36 -08:00
Milan Burda
67894f1493
test: convert a few more specs to async/await ( #40313 )
2023-11-17 10:44:03 +01:00
Shelley Vohr
471449d9f6
feat: add/update missing Display properties ( #40497 )
2023-11-17 10:43:04 +01:00
Samuel Maddock
088affd4a4
fix: emit will-navigate for links in chrome: pages ( #40390 )
...
* fix: emit will-navigate for links in chrome: pages
* test: will-navigate emitted from chrome: pages
* Update shell/browser/electron_navigation_throttle.cc
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2023-11-14 14:09:44 -08:00
electron-roller[bot]
0e4e9dc98c
chore: bump chromium to 121.0.6116.0 (main) ( #40490 )
...
* chore: bump chromium in DEPS to 121.0.6116.0
* chore: update patches
* Update webIDL to support close event.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4970653
* Remove uses of implicit conversion of ScopedTypeRef
Refs https://bugs.chromium.org/p/chromium/issues/detail?id=1495439
* Add GlobalRenderFrameHostToken
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5001743
* [DevTools] Console Insights: move from build flag to Feature API
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5002232
* [Extensions] Use script serialization in scripting API
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4968680
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4998265
* [api] Remove AllCan Read/Write
https://chromium-review.googlesource.com/c/v8/v8/+/5006387
* chore: update libcxx files
* chore: address nan compilation error
* spec: use nan dependency from third_party
It is easier to get fixes for spec modules depending on nan
* ci: publish nan artifact for woa
* fix: bad patch update
* chore: update nan resolution
* Revert "chore: update nan resolution"
This reverts commit 786cdb858chop2deep@gmail.com >
2023-11-14 13:21:32 -08:00
Shelley Vohr
7981d955b8
fix: chrome.action API registration ( #40500 )
2023-11-13 08:27:18 +01:00
Felix Rieseberg
b55d7f4a16
fix: Do not activate app when calling focus on inactive panel window ( #40307 )
...
* fix: Do not activate app when calling focus on inactive panel window
* Use activate
* Use "activate" for all windows
2023-11-06 13:38:12 -08:00
Samuel Attard
83892ab995
refactor: ensure IpcRenderer is not bridgable ( #40330 )
...
* refactor: ensure IpcRenderer is not bridgable
* chore: add notes to breaking-changes
* spec: fix test that bridged ipcrenderer
2023-10-31 17:29:40 -04:00
Shelley Vohr
fcdd5cba71
fix: navigator.keyboard.lock() fullscreen exit handling ( #40365 )
...
fix: navigator.keyboard.lock() fullscreen exit handling
2023-10-31 11:59:39 -04:00
Shelley Vohr
652f995128
refactor: remove DevTools legacy UI patching ( #40331 )
2023-10-26 14:36:04 -04:00
