Commit Graph

23106 Commits

Author SHA1 Message Date
Electron Bot
87fd06bc96 Bump v8.3.3 v8.3.3 2020-06-18 09:52:13 -07:00
Cheng Zhao
4079d60021 fix: do not use CONTEXT_MENU flag for tray menu (reland) (#24194) 2020-06-18 09:03:02 -07:00
Cheng Zhao
6cc75d9f92 fix: correctly handle nexttick scheduling in stream reads (#24133)
Co-authored-by: Paul Frazee <pfrazee@gmail.com>
2020-06-18 01:25:13 -07:00
trop[bot]
af5be47aa7 fix: make pasteandmatchstyle accelerator OS specific (#24184)
Co-authored-by: Elena Topaka <el1topa@gmail.com>
2020-06-17 21:48:07 -07:00
Pedro Pontes
b2454eeb52 chore: cherry-pick eac3d9283d11 from chromium (#24152)
* chore: cherry-pick eac3d9283d11 from chromium

* update patches

Co-authored-by: Electron Bot <anonymous@electronjs.org>
Co-authored-by: Robo <hop2deep@gmail.com>
2020-06-17 21:47:04 -07:00
Robo
1ee98b4a73 fix: let Node.js perform microtask checkpoint in the main process (#24131) (#24180)
* fix: let Node.js perform microtask checkpoint in the main process

* fix: don't specify v8::MicrotasksScope for explicit policy

* fix: remove checkpoint from some call-sites

We already perform checkpoint at the end of a task,
either through MicrotaskRunner or through NodeBindings.
There isn't a need to add them again when calling into JS
except when dealing with promises.

* fix: remove checkpoint from some call-sites

We already perform checkpoint at the end of a task,
either through MicrotaskRunner or through NodeBindings.
There isn't a need to add them again when calling into JS
except when dealing with promises.

* fix incorrect specs

* default constructor arguments are considered for explicit mark

* add regression spec
2020-06-17 16:00:41 -07:00
Robo
e74a402976 chore: cherry-pick c20afc96e36f57 from chromium (#24181) 2020-06-17 16:00:10 -07:00
trop[bot]
8e5a88799c docs: fix MenuItem click handler type (#24176)
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2020-06-17 11:30:14 -07:00
trop[bot]
0b846b2f13 chore: cherry-pick bc4df9dd11e609e from chromium (#24084)
* chore: cherry-pick bc4df9dd11e609e from chromium

* chore: update patches

Co-authored-by: deepak1556 <hop2deep@gmail.com>
2020-06-17 00:49:49 -07:00
trop[bot]
25539dcb73 fix: volume key globalShortcut deregistration (#24154)
Co-authored-by: Aleksei Kuzmin <alkuzmin@microsoft.com>
2020-06-16 13:52:39 -07:00
trop[bot]
2a4aaa9661 fix: emit 'shutdown' outside -[NSApplication terminate:] (#24140)
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2020-06-15 21:02:56 -07:00
trop[bot]
793da44151 fix: handle non-client area pointer events from pen on Win10 (#24101) 2020-06-15 18:58:05 -07:00
trop[bot]
4c28b23b06 fix: fs.readdir should support withFileTypes (#24107)
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2020-06-16 10:56:09 +09:00
Electron Bot
952603d9ae Bump v8.3.2 v8.3.2 2020-06-15 09:05:09 -07:00
Jeremy Rose
32b45e7783 fix: throw instead of crash when using ipcRenderer after context released (#23979)
* fix: throw instead of crash when using ipcRenderer after context released (#23917)

* meh

* Update api-ipc-renderer-spec.ts
2020-06-13 08:28:17 -07:00
trop[bot]
514c1e6d4b fix: showing certificate dialog with no window (#24120)
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2020-06-13 08:19:30 -07:00
trop[bot]
67b04b4040 chore: cherry-pick 867fcd45891e from chromium (#24088)
https://chromium-review.googlesource.com/c/chromium/src/+/2134037

Co-authored-by: deepak1556 <hop2deep@gmail.com>
2020-06-12 12:13:29 -07:00
Samuel Attard
415387cc2c Revert "fix: do not use CONTEXT_MENU flag for tray menu (#23886)" (#24079)
This reverts commit 91d1bd651e.
2020-06-11 11:28:02 -07:00
Electron Bot
0826770b20 Revert "Bump v8.3.2"
This reverts commit c2e22abf08.
2020-06-11 09:42:29 -07:00
Electron Bot
c2e22abf08 Bump v8.3.2 2020-06-11 09:24:35 -07:00
Milan Burda
9c28c8f637 chore: revert deprecated WebContents properties (#24071) 2020-06-11 09:16:33 -07:00
Milan Burda
478d405d42 chore: support props/fns for BrowserWindow (#24074) 2020-06-11 09:14:47 -07:00
Milan Burda
0b616b3e2e chore: more modules to dual prop/fn support (#22734) (#24075)
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
2020-06-11 11:06:54 -05:00
Milan Burda
49711d12f8 chore: update app module property support (#22747) (#24072)
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2020-06-11 08:56:28 -07:00
Cheng Zhao
fe56f1dda6 fix: add .paks for media-internals and webrtc-internals pages (#24063)
Co-authored-by: Gellert Hegyi <gellert.hegyi@around.co>
2020-06-11 08:38:49 -07:00
Shelley Vohr
f10c8e6dd5 chore: roll latest Node.js security release (#23953) 2020-06-09 11:55:34 -04:00
Charles Kerr
27c1fc87e3 fix: add missing isComposing KeyboardEvent property (#24015) 2020-06-08 17:45:57 -07:00
Shelley Vohr
be08ff1665 fix: nativeImage remote serialization (#23797)
* fix: nativeImage remote serialization (#23543)

We weren't serializing nativeImages properly in the remote module, leading to gin conversion errors when trying to, for example, create a new context menu in the renderer with icons using nativeImage. This fixes that by adding a new special case to handle them.

* refactor: correctly serialize nativeImage/buffer with typeUtils (#23666)

* refactor: correctly serialize nativeImage/buffer with typeUtils

* test: add serialization specs

* fix: construct from dataURL

* test: test for dataURL specificity

* refactor: use typeutils for nativeImage serialization

* fix: ensure nativeImage serialization main->renderer

* chore: fix FTBFS

Co-authored-by: Charles Kerr <charles@charleskerr.com>
2020-06-08 12:08:54 -07:00
Charles Kerr
547e50c699 docs: errors in isolated world are not dispatched (#24016)
* docs: errors in isolated world are not dispatched

* empty commit

* fix manual oops

Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
2020-06-08 14:51:39 -04:00
Shelley Vohr
a06170648c fix: compensate for lazy-loaded circular deps (#23955) 2020-06-08 10:09:40 -07:00
Milan Burda
88fdf8ccf5 fix: use acceptLanguages argument in session.setUserAgent() (#23944) (#23963)
Co-authored-by: Milan Burda <miburda@microsoft.com>
2020-06-08 09:19:32 -07:00
trop[bot]
d12be5d392 feat: add V8CacheOptions webpreference (#23869)
* feat: add V8CacheOptions webpreference

* address review comments

Co-authored-by: deepak1556 <hop2deep@gmail.com>
2020-06-08 11:07:44 -05:00
Cheng Zhao
e62cd6a5fa fix: read GTK dark theme setting on Linux (#23965) 2020-06-04 19:33:53 -07:00
Shelley Vohr
c412f7ddf1 fix: handle asynchronous URL loading in bw proxy (#23947) 2020-06-03 15:54:43 -07:00
Shelley Vohr
0afec38c81 fix: volume key globalShortcut registration (#23948) 2020-06-03 13:31:18 -07:00
Robo
38f0a8e85b fix: default to NTLM v2 in the network service for POSIX platforms (#23933)
* fix: default to NTLM v2 in the network service for POSIX platforms

* chore: update patch
2020-06-03 11:48:37 -07:00
Shelley Vohr
0aa7b7f712 test: skip 'handles Promise timeouts correctly' when ELECTRON_RUN_AS_NODE is disabled (#23949) 2020-06-03 14:18:07 -04:00
trop[bot]
23bd9166d7 fix: restore original GTK/appindicator implementation of tray icons (#23927)
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
2020-06-03 11:08:04 -07:00
Charles Kerr
c374f20fd1 fix: don't run environment bootstrapper (#23924)
* fix: don't prepareMainExecution twice

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2020-06-03 10:12:29 -05:00
trop[bot]
b5839f42a2 fix: correctly support the --inspect-brk-node flag (#23919)
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
2020-06-03 17:01:26 +09:00
trop[bot]
2dcfefa577 build: make electron renderer init scripts profilable (#23914)
The devtools profiler is not attached at the point we run out init scripts (or our apps preload scripts), we do not really want to change when we run these init scripts but for when a dev is doing performance work it makes sense to give them an option to make the devtools profiler actually work on both our init scripts and their preload script.  This PR adds that logic behind an environment variable ELECTRON_PROFILE_INIT_SCRIPTS.

Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
2020-06-02 12:28:27 -07:00
trop[bot]
b045ee77af fix: add patch to prevent crash during frame swap with ctx isolation enabled (#23894)
* fix: add patch to prevent crash during frame swap with ctx isolation enabled

* Update .patches

* chore: update patches

Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
Co-authored-by: Samuel Attard <sattard@slack-corp.com>
2020-06-02 10:54:35 -07:00
Biru Mohanathas
32c2736c07 fix: Make the --disable-color-correct-rendering switch work again (8-x-y) (#23827)
Backport of #23787

See that PR for details.

Notes: Fix disabling color correct rendering with `--disable-color-correct-rendering`
2020-06-02 13:50:35 -04:00
Charles Kerr
91d1bd651e fix: do not use CONTEXT_MENU flag for tray menu (#23886) 2020-06-02 11:11:35 +09:00
Electron Bot
c8177f8418 Bump v8.3.1 v8.3.1 2020-06-01 09:32:39 -07:00
trop[bot]
b8c086613f fix: weakly reference MenuModel from MenuController (#23807)
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2020-05-28 09:47:47 -07:00
Alexey Kuzmin
2e80a2e447 test: refactor how spec files are collected (#23815)
(cherry picked from commit 3a7775fa73)
2020-05-28 09:41:27 -07:00
Pedro Pontes
936a1659f6 chore: cherry-pick d795ac1209c8 and 919dd0c1244a from chromium (#23788)
* Onstate handler is allowed to close a PeerConnection.

Backports the 2-part fix to https://crbug.com/1068084

===

Avoid nullptr dereference in RTCPeerConnectionHandler

Bug: 1071327
Change-Id: Icf4189905dc5c95854b5af4b3e5e25e0607dd39e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153325
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759775}

===

Onstate handler is allowed to close a PeerConnection.

Bug: chromium:1068084
Change-Id: Icd3f70b6784ac22ef4e3bc1c99233f51145a917f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146542
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759242}

===

* update patches

Co-authored-by: Electron Bot <anonymous@electronjs.org>
2020-05-28 11:34:49 -04:00
Cheng Zhao
d7289cbb55 Revert "fix: trigger activate event when app is activated via app switcher (#23772)" (#23820)
This reverts commit e671c2c053.
2020-05-28 09:01:37 -04:00
trop[bot]
aab0c66817 fix: pass correct buffer length (#23799)
Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
2020-05-27 14:09:35 -07:00