Charles Kerr
a1e4550c9e
chore: disable flaky content tracing tests on Linux ( #45612 )
2025-02-14 10:18:42 +01:00
Charles Kerr
2b8706bf44
chore: change node test timeout from 20m to 30m ( #45611 )
2025-02-13 17:27:35 -06:00
Shelley Vohr
3a3595f2af
build: remove PDF edited saved files patch ( #45604 )
2025-02-13 14:52:31 -05:00
Shay Molcho
9a2ee763d0
docs: added missing period for consistency and readability ( #45333 )
...
Added missing period for consistency and readability
Added a missing period in a specific part of the text to maintain consistency across the document. This ensures a uniform writing style, improves readability, and aligns with the formatting used throughout the content.
2025-02-13 10:55:43 +01:00
Keeley Hammond
237429bb85
build: set chromium cookie on depot tools requests ( #45581 )
...
* build: set chromium cookie on depot tools requests
* build: correct secrets syntax
* build: handle windows cmd
2025-02-12 17:44:43 +01:00
Will Anderson
50d1c803dd
chore: remove var declarations from DEPS that no longer have any effect ( #45535 )
...
* chore: Remove checkout_google_benchmark var that no longer has any effect
This variable stopped having any effect in https://chromium-review.googlesource.com/c/chromium/src/+/4322306
It was removed from Chromium entirely in https://chromium-review.googlesource.com/c/chromium/src/+/4339138
* chore: remove checkout_oculus_sdk and checkout_libaom from DEPS
2025-02-12 10:51:11 +01:00
John Kleinschmidt
0d3e34d0be
test: disable unexpectedly quit dialog on macOS ( #45553 )
...
* test: disable unexpectedly quit dialog on macOS
* test: take screenshot before keyboard lock test
* Revert "test: take screenshot before keyboard lock test"
This reverts commit 3ba5c6984f
2025-02-11 21:08:38 -05:00
Charles Kerr
aa06b065c0
chore: bump chromium to 134.0.6998.10 (main) ( #45564 )
...
* chore: bump chromium to 134.0.6992.0
* chore: add BrowserProcessImpl::CreateGlobalFeaturesForTesting() stub
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6216193
Remove GlobalFeatures from TestingBrowserProcess::Init
* chore: bump chromium to 134.0.6994.0
* 6208630: Mac sandbox: don't use protobuf for policy serialization | https://chromium-review.googlesource.com/c/chromium/src/+/6208630
* [PDF] Remove HasUnsupportedFeature Mojo interface
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6220800
* 6217444: Remove scoped_gdi_object.h type aliases. | https://chromium-review.googlesource.com/c/chromium/src/+/6217444
* chore: bump chromium to 134.0.6998.10
* 6221378: Revert [OBC] Exclude Aliasing Cookies in FilterCookiesWithOptions() | https://chromium-review.googlesource.com/c/chromium/src/+/6221378
* Update ExtensionPrefs::GetDisableReasons to return DisableReasonSet
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6218840
change copied from 6218840 extensions/shell/browser/shell_extension_loader.cc
* 6218402: Typemap ui.gfx.DXGIHandle <=> gfx::DXGIHandle | https://chromium-review.googlesource.com/c/chromium/src/+/6218402
* chore: disable flaky contentTracing test
not new to this roll; it is happening in main as well
* fixup! chore: disable flaky contentTracing test
---------
Co-authored-by: alice <alice@makenotion.com >
2025-02-11 17:26:39 -06:00
Felix Rieseberg
9f47c9a051
feat: Restore webContents navigation history and page state ( #45433 )
...
* feat: Working navigationHistory.restore with just title/url
* feat: Restore page state, too
* chore: Docs, lint, tests
* Implement feedback
* More magic
* Make _awaitNextLoad truly private
* Implement API group feedback
* One more round of feedback
2025-02-11 15:09:38 -08:00
Will Anderson
6fdfca6e49
build: make gen-libc++-filenames.js produce the same results on Windows ( #45556 )
2025-02-11 12:56:05 +01:00
dependabot[bot]
196352bf0b
build(deps): bump github/codeql-action from 3.28.8 to 3.28.9 ( #45561 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.28.8 to 3.28.9.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](dd746615b3...9e8d0789d4support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-02-11 11:39:29 +01:00
Robo
46d316692d
fix: asan build on macOS ( #45541 )
...
* fix: asan build on macOS
* chore: fix build
2025-02-11 15:04:07 +09:00
Josh Jancourtz
2f288bc7cc
docs: fix grammar in preload tutorial summary ( #45522 )
2025-02-10 16:15:32 -05:00
Calvin
f5025b6246
fix: avoid IPC for renderer webFrame.getZoom... APIs ( #45499 )
...
* fix: avoid IPC for renderer `webFrame.getZoom...` APIs
* Remove `DoGetZoomLevel` IPC
* Fix synchronous behavior & nullptr deref
* Use local root
2025-02-10 16:09:11 -05:00
Milan Burda
e055ce7c39
chore: deprecate systemPreferences.isAeroGlassEnabled() ( #45434 )
2025-02-10 15:17:07 -05:00
John Kleinschmidt
14fe0932f0
test: make sure test window is on top for focus tests ( #45435 )
2025-02-10 13:40:27 -05:00
dependabot[bot]
3ba85878a5
build(deps): bump github/codeql-action from 3.28.6 to 3.28.8 ( #45453 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.28.6 to 3.28.8.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](17a820bf2e...dd746615b3support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-02-10 19:40:01 +01:00
Keeley Hammond
70168c8bdc
fix: fix mksnapshot gen/v8 path ( #45488 )
...
* fix: fix mksnapshot gen/v8 path
* build: use 7z compression
* build: unzip mksnapshot on Windows and update zip
* chore: escape backslashes
* chore: try another attempt
* chore: remove rmdir for now
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2025-02-10 10:21:29 -05:00
Sam Maddock
e4cd162433
docs: fix powerMonitor event types ( #45518 )
...
* fix: powerMonitor event types
* fix: thermal-state-change missing Returns
2025-02-10 10:13:11 -05:00
Calvin
4085185e2d
docs: transactions-updated event type ( #45527 )
...
fix: `transactions-updated` event type
2025-02-10 10:12:17 -05:00
Shelley Vohr
a141f68c83
refactor: use node::tracing::Agent() directly ( #45489 )
...
refactor: use node::tracing::Agent()
2025-02-09 21:36:42 +01:00
Shelley Vohr
9199d5c610
fix: window maximizing with Mica ( #45456 )
...
* fix: window maximizing with Mica
* Fix rounded corners after restore
2025-02-07 15:00:36 -05:00
michal-pichlinski-openfin
96460becf9
fix: Update widget visibility in NativeWindowMac::ShowInactive ( #45427 )
...
When using `views::WebView` on macOS `NativeWidgetMacNSWindowHost`
contains a layer and compositor responsible for drawing web contents.
To trigger drawing `NativeWidgetMacNSWindowHost::OnVisibilityChanged`
needs to be called and `[NSWindow orderFrontRegardless]` does not trigger
`[NSWindow orderWindow:relativeTo:]` which can change
`NativeWidgetMacNSWindowHost` visiblity with stack:
```
views::NativeWidgetMacNSWindowHost::OnVisibilityChanged(bool)
remote_cocoa::NativeWidgetNSWindowBridge::OnVisibilityChanged()
-[ViewsNSWindowDelegate onWindowOrderChanged:]
-[NativeWidgetMacNSWindow orderWindow:relativeTo:]
```
`views::Widget` has method for showing inactive window:
`views::Widget::ShowInactive` which triggers
`NativeWidgetMacNSWindowHost::OnVisibilityChanged` with stack:
```
views::NativeWidgetMacNSWindowHost::OnVisibilityChanged(bool)
remote_cocoa::NativeWidgetNSWindowBridge::SetVisibilityState(remote_cocoa::mojom::WindowVisibilityState)
views::NativeWidgetMacNSWindowHost::SetVisibilityState(remote_cocoa::mojom::WindowVisibilityState)
views::NativeWidgetMac::Show(ui::mojom::WindowShowState, gfx::Rect const&)
views::Widget::ShowInactive() + 168
```
However this call seems to be insufficient to bring window to front,
therefore `[NSWindow orderFrontRegardless]` still needs to be called.
Calling `views::Widget::ShowInactive` ensures that all logic related to
showing Chromium widget will be properly executed, but onfortunately it
does not call `[NSWindow orderWindow:relativeTo:]` which is used to
disabling headless mode by the `ElectronNSWindow`, therefore we need to
trigger it manually through exposed `[ElectronNSWindow disableHeadlessMode]`.
Fixes : #45415
2025-02-07 11:31:08 -08:00
Charles Kerr
d7c6fb8250
refactor: follow upstream's suggestions on when to use EmptyGURL() ( #45498 )
...
- Prefer GURL() when we want to return a non-reference empty URL.
- In ServiceWorkerMain::GetStorageKey(), use a reference instead
of instantiating a new temporary GURL.
From url/gurl.h:
> // Returns a reference to a singleton empty GURL. This object is for
> // callers who return references but don't have anything to return in
> // some cases. If you just want an empty URL for normal use, prefer
> // GURL().
2025-02-07 13:58:31 -05:00
Charles Kerr
3db691804b
chore: bump chromium 134.0.6990.0 ( #45507 )
...
* chore: update feat_add_support_for_missing_dialog_features_to_shell_dialogs.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6219304
Partially upstreamed by @codebytere
* chore: e patches all
2025-02-07 10:25:46 -06:00
David Sanders
4512b2b5c4
chore: remove remaining references to AppVeyor ( #45339 )
2025-02-07 12:57:36 +01:00
John Kleinschmidt
7bde100a1a
build: make sure there is at least 35GB free for source cache ( #45501 )
...
build: make sure there is at least 35GB free for cache
2025-02-07 12:03:38 +01:00
Kavindu Udara
d0110d897d
docs: remove width and height params ( #45331 )
...
remove width and height params
2025-02-07 11:42:16 +01:00
Charles Kerr
ef34892a76
chore: bump chromium 134.0.6989.0 ( #45506 )
...
* chore: bump chromium to 134.0.6989.0
* chore: update patches/chromium/cherry-pick-dd8e2822e507.patch
* chore: e patches all
2025-02-07 10:00:09 +01:00
Charles Kerr
67f5ac5bbc
fix: RenderFrameHost nullptr dereference ( #45487 )
...
* fix: add nullptr tests before using render_frame_
* refactor: extract-method HasRenderFrame()
2025-02-06 22:02:57 -06:00
Milan Burda
517935cd55
refactor: only pass v8::Context to gin_helper::MicrotasksScope constructor ( #45484 )
...
refactor: forward v8::Context to v8::MicrotasksScope constructor
2025-02-07 10:44:19 +09:00
Samuel Attard
326957009a
chore: cherry-pick dd8e2822e507 from chromium ( #45495 )
2025-02-06 14:33:42 -08:00
electron-roller[bot]
213165a467
chore: bump chromium to 134.0.6988.0 (main) ( #45334 )
...
* chore: bump chromium in DEPS to 134.0.6976.0
* chore: update mas_avoid_private_macos_api_usage.patch.patch
https://chromium-review.googlesource.com/c/chromium/src/+/6171046
process_info_mac.cc -> process_info_mac.mm
* chore: update build_do_not_depend_on_packed_resource_integrity.patch
https://chromium-review.googlesource.com/c/chromium/src/+/6196857
* chore: update feat_add_support_for_missing_dialog_features_to_shell_dialogs.patch
https://chromium-review.googlesource.com/c/chromium/src/+/6182296
https://chromium-review.googlesource.com/c/chromium/src/+/6183404
https://chromium-review.googlesource.com/c/chromium/src/+/6187853
A lot changed in the upstream implementation. There's a good chance I got
this wrong as threading has changed and moved some variables into globals.
* chore: remove build_remove_vr_directx_helpers_dependency.patch
https://chromium-review.googlesource.com/c/chromium/src/+/6186102
This landed upstream
* chore: e patches all
* chore: update net::CookieInclusionStatus::ExclusionReason enum
https://chromium-review.googlesource.com/c/chromium/src/+/6183252
https://chromium-review.googlesource.com/c/chromium/src/+/6185544
* chore: update content::WebAuthenticationDelegate import
https://chromium-review.googlesource.com/c/chromium/src/+/6189769
* Revert "chore: disable focus handling test due to win32/ia32 regression"
This reverts commit 1a57ba5d59https://chromium-review.googlesource.com/c/chromium/src/+/6196281
* 6196283: Delete PdfInternalPluginDelegate
https://chromium-review.googlesource.com/c/chromium/src/+/6196283
* chore: update patches
* chore: bump chromium in DEPS to 134.0.6986.0
* chore: update patches
* 6205762: Support option to use window.showSaveFilePicker() in PDF attachment code
https://chromium-review.googlesource.com/c/chromium/src/+/6205762
See also:
* https://issues.chromium.org/issues/373852607
* 5939153: [PDF] Add PdfUseShowSaveFilePicker feature flag | https://chromium-review.googlesource.com/c/chromium/src/+/5939153
* 6205761: Delete spurious Ink-specific code in pdf_viewer.ts | https://chromium-review.googlesource.com/c/chromium/src/+/6205761
* 6209609: Remove WebVector: Automatic changes
https://chromium-review.googlesource.com/c/chromium/src/+/6209609
* 6205488: UI: make QT5 optional
https://chromium-review.googlesource.com/c/chromium/src/+/6205488
* 6178281: Rename pak files from branding strings
https://chromium-review.googlesource.com/c/chromium/src/+/6178281
* fixup! 6209609: Remove WebVector: Automatic changes https://chromium-review.googlesource.com/c/chromium/src/+/6209609
* 6193249: Switch from safe_browsing::EventResult to enterprise_connectors:EventResult
https://chromium-review.googlesource.com/c/chromium/src/+/6193249
* 6197457: Remove Pause/ResumeReadingBodyFromNet IPCs
https://chromium-review.googlesource.com/c/chromium/src/+/6197457
* 6191230: Record total time spent on a picture in picture window
https://chromium-review.googlesource.com/c/chromium/src/+/6191230
* chore: bump chromium in DEPS to 134.0.6988.0
* chore: update patches
* 6215440: Remove base/ranges/.
https://chromium-review.googlesource.com/c/chromium/src/+/6215440
* Disable unsafe buffers error
Not sure what changed, but we're now seeing unsafe buffer errors in Chromium code, at least when using reclient. Will update this comment if we find out the cause.
* 6187853: SelectFileDialogLinuxPortal: Use dbus_xdg::Request and DbusType
https://chromium-review.googlesource.com/c/chromium/src/+/6187853
* fix `setDisplayMediaRequestHandler` test
Given how this test is written, I would expect this assertion to be false. It seems the oppositue was true before, but that was also acknowledged to be suprising. Seems that the underlying implementation is now fixed and works as expected.
* fixup! 6187853: SelectFileDialogLinuxPortal: Use dbus_xdg::Request and DbusType https://chromium-review.googlesource.com/c/chromium/src/+/6187853
* chore: udpate patches
* Multiple PRS: https://chromium-review.googlesource.com/c/chromium/src/+/6185544 | https://chromium-review.googlesource.com/c/chromium/src/+/6183252
* fix: cast enum class to numeric type
* fix: add 1 to MAX_EXCLUSION_REASON because enum values are zero-based, and we want the total count of reasons.
* Reapply "chore: disable focus handling test due to win32/ia32 regression"
This reverts commit 760b1a519bsmaddock@slack-corp.com >
Co-authored-by: clavin <clavin@electronjs.org >
Co-authored-by: alice <alice@makenotion.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-02-06 15:30:54 -05:00
David Sanders
3dad07f338
test: dump Electron process PID to path if environment variable set ( #45481 )
2025-02-06 09:15:10 -06:00
Anh Le
6adc737a89
docs: use correct headings in tutorial/security.md ( #45397 )
2025-02-06 11:16:24 +01:00
max54nj
c0282eb9c8
docs: style fixes ( #45458 )
...
* docs: fix code field
* docs: add missing space
2025-02-05 15:10:07 -05:00
Maria Alejandra Arias Frontanilla
471b1a873d
fix: fix typo in docs why-electron.md ( #45437 )
2025-02-05 09:26:47 -06:00
Shelley Vohr
aee8ea8b10
fix: WCO not working with some window configurations ( #45422 )
2025-02-05 12:48:51 +01:00
Shelley Vohr
57cf4fc846
fix: legacyMainResolve respecting permission model ( #45421 )
...
fix: legacyMainResolve respecting permission model
2025-02-05 12:48:34 +01:00
Charles Kerr
9fe12cd01b
fix: handle exclude aliasing in InclusionStatusToString() ( #45454 )
...
* refactor: use MakeFixedFlatMap() in InclusionStatusToString()
* fix: add log message for EXCLUDE_ALIASING
refactor: add static_assert() to ensure our messages stay
in sync with the CookieInclusion reasons in net/cookies/
2025-02-05 12:48:11 +01:00
Shelley Vohr
6486ce8191
build: remove debugger agent timeout patch ( #45457 )
2025-02-05 12:47:54 +01:00
Robo
bec6ddda70
feat: route deprecated sync clipboard read through permission checks ( #45377 )
...
* feat: route deprecated clipboard commands through permission checks
* docs: address review feedback
* fix: enable checks for child windows
2025-02-05 15:13:29 +09:00
Shelley Vohr
e9d5eeb118
build: try removing embedder exception patch ( #45429 )
2025-02-04 19:39:20 +01:00
Keeley Hammond
c147e4fa81
build: add win toolchain for release builds ( #45380 )
...
* build: add win toolchain for release builds
* build: fix installed_software.json script
* chore: run pwsh script within src
* build: fixup uploader arch
2025-02-03 22:06:01 -08:00
Niklas Wenzel
1d27a27813
docs: document deletion of databases directory ( #45412 )
2025-02-03 16:28:44 -05:00
Niklas Wenzel
d3bead5e0e
docs: mention C++20 requirement in breaking changes document ( #45413 )
...
* docs: mention C++20 requirement in breaking changes document
* chore: fix linter issue
2025-02-03 13:19:26 -08:00
David Sanders
9f1bb531ba
build: always use python3 in script/lib/get-version.js ( #45400 )
...
build: always use python3 in script/lib/get-version.js
2025-02-03 16:13:36 -05:00
Shelley Vohr
9971087678
build: remove outdated Node.js serdes patch ( #45401 )
...
build: remove outdates Node.js serdes patch
2025-02-03 14:09:02 +01:00
Shelley Vohr
e7fa5c709c
fix: incorrect WCO tooltip in RTL ( #45405 )
2025-02-03 10:50:50 +01:00
Shelley Vohr
7a1d410e0a
fix: default path not working on KDE Linux ( #45402 )
2025-02-03 09:49:48 +01:00
