Alice Zhao
a5b4339884
fix: add missing index arg in navigationHistory.canGoToOffset ( #44989 )
...
fix: add missing arg
2024-12-12 10:56:27 -05:00
Sam Maddock
6961e9458a
chore: update vm module warning ( #44985 )
...
* chore: update vm module warning
* Update lib/renderer/init.ts
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
---------
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
2024-12-11 17:22:50 -05:00
electron-appveyor-updater[bot]
2191e9b8e1
build: update appveyor image to latest version ( #44992 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-12-11 13:27:21 -05:00
Sam Maddock
2c698d3f75
fix: context-menu emitted twice ( #44978 )
...
* fix: context-menu emitted twice
* refactor: simplify disabling draggable regions
* cleanup
2024-12-11 11:42:48 -05:00
electron-roller[bot]
cf5a4640f5
chore: bump chromium to 133.0.6878.0 (main) ( #44831 )
...
* chore: bump chromium in DEPS to 133.0.6858.0
* chore: bump chromium in DEPS to 133.0.6860.0
* chore: update patches
v8/revert_fastapi_remove_dynamic_overload_resolution.patch had some additions due to https://chromium-review.googlesource.com/c/v8/v8/+/6023139
* 6044060: Reland "Moves shared GN templates into //build/config/apple."
https://chromium-review.googlesource.com/c/chromium/src/+/6044060
* Revert "6023139: [fastapi] Add support for attribute setters"
https://chromium-review.googlesource.com/c/v8/v8/+/6023139
* Update printing.patch
The removed include is present in the original source file now, just slightly before where it was being added.
6015430: Reduce platform-like buildflags in sandbox code
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/6015430
* 6039836: Migrate Command::IsMediaKey to be a member of ui::Accelerator
https://chromium-review.googlesource.com/c/chromium/src/+/6039836
* 6038659: [CodeHealth] Clean up the feature ZstdContentEncoding
https://chromium-review.googlesource.com/c/chromium/src/+/6038659
* chore: bump chromium in DEPS to 133.0.6862.0
* chore: update patches
* 72747: crypto: switch to C++
https://boringssl-review.googlesource.com/c/boringssl/+/72747
* fixup! 72747: crypto: switch to C++ https://boringssl-review.googlesource.com/c/boringssl/+/72747
* chore: gen libc++ filenames
* 6042601: [shared storage] Implement with_lock option for methods from response headers
https://chromium-review.googlesource.com/c/chromium/src/+/6042601
* chore: bump chromium in DEPS to 133.0.6864.0
* chore: bump chromium in DEPS to 133.0.6866.0
* chore: bump chromium in DEPS to 133.0.6868.0
* chore: bump chromium in DEPS to 133.0.6870.0
* chore: bump chromium in DEPS to 133.0.6872.0
* chore: bump chromium in DEPS to 133.0.6874.0
* chore: bump chromium in DEPS to 133.0.6876.0
* 6039992: Fix false activation logic for context menu. | https://chromium-review.googlesource.com/c/chromium/src/+/6039992
* chore: update patches
* chore: update patches
* chore: bump chromium in DEPS to 133.0.6878.0
* chore: update patches
* [Build] Organize //components/dbus into a single component
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6055280
* Merge //components/dbus/* into a single //components/dbus, which
matches how most components are organized. This avoids having
many small shared libraries which incurs unnecessary overhead.
* Limit visibility of //components/dbus/* to //components/dbus
* fixup! Update _LIBCPP_ABI_VERSION to always have a default value while keeping unstable false due to changes in llvm https://github.com/llvm/llvm-project/pull/112094
* 6040416: Let s know which widget the input came on. | https://chromium-review.googlesource.com/c/chromium/src/+/6040416
* 6056267: [MPArch guest view] Fix authentication for MPArch guests | https://chromium-review.googlesource.com/c/chromium/src/+/6056267
* make_span() is deprecated: https://issues.chromium.org/issues/341907909
* fixup: https://issues.chromium.org/issues/341907909
* chore: delete extra bracket from removing make_span commit
* fixup: 6059305: Make WTF::UTF8ConversionMode a scoped enum | https://chromium-review.googlesource.com/c/chromium/src/+/6059305
* 6051058: CookieInclusionStatus: Remove ctors which bypass invariants | https://chromium-review.googlesource.com/c/chromium/src/+/6051058
* 6038981: Remove most remaining CHECK(false)s | https://chromium-review.googlesource.com/c/chromium/src/+/6038981
* build: use third_party/simdutf in Node.js
* chore: node ./script/gen-libc++-filenames.js
* chore: fix strict-cast conversion error in subspan()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6044946
* chore: fix strict-cast conversion error in base::as_bytes()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6044946
* chore: fix strict-cast conversion error in span.split_at()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6044946
* chore: use shorthand target name
* chore: better docs in build_add_public_config_simdutf_config.patch
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org >
Co-authored-by: alice <alice@makenotion.com >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-12-10 13:16:07 -06:00
dependabot[bot]
3bd5f14cee
build(deps): bump github/codeql-action from 3.27.5 to 3.27.6 ( #44981 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.27.5 to 3.27.6.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](f09c1c0a94...aa57810251support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-12-10 11:52:27 +01:00
dependabot[bot]
7462d449e0
build(deps): bump mikefarah/yq from 4.44.5 to 4.44.6 ( #44980 )
...
Bumps [mikefarah/yq](https://github.com/mikefarah/yq ) from 4.44.5 to 4.44.6.
- [Release notes](https://github.com/mikefarah/yq/releases )
- [Changelog](https://github.com/mikefarah/yq/blob/master/release_notes.txt )
- [Commits](bc5b54cb1d...4839dbbf80support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-12-10 11:51:25 +01:00
Calvin
82ea3faae5
docs: update security scoped bookmarks info ( #44968 )
2024-12-09 10:44:43 -08:00
Charles Kerr
578c1e5dae
fix: build failure when PDF viewer is disabled ( #44960 )
...
* fix: unused variable warning when the PDF viewer is disabled
* fix: unused function error when PDF viewer is disabled
error: unused function ParseManifest [-Werror,-Wunused-function]
2024-12-06 17:54:04 +09:00
Shelley Vohr
208dc568d8
fix: context-menu event with BaseWindows ( #44940 )
...
fix: context-menu event with BaseWindows
2024-12-04 13:35:28 -08:00
Felix Rieseberg
687a59b43b
feat: Add shared dictionary management APIs ( #44750 )
...
* Add bare-bones GetSharedDictionaryUsageInfo
* Add GetSharedDictionaryInfo()
* Improve API, use isolation keys
* Add documentation
* Update docs/api/session.md
Co-authored-by: John Kleinschmidt <kleinschmidtorama@gmail.com >
* Update shell/browser/api/electron_api_session.cc
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
* Add tests
* Implement feedback <3
* Improve tests
* chore: lint
* docs: add note about clearing cache in ses.clearData
---------
Co-authored-by: John Kleinschmidt <kleinschmidtorama@gmail.com >
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
Co-authored-by: alice <alice@makenotion.com >
2024-12-04 12:25:11 -05:00
Charles Kerr
158a87d494
fix: modernize-use-equals-default warnings ( #44935 )
...
fix: use '= default' to define a trivial destructor [modernize-use-equals-default]
2024-12-03 16:25:48 -06:00
Shelley Vohr
229c2a8f50
chore: make version parsing more tolerant ( #44918 )
...
* chore: make version parsing more tolerant
* Update .github/workflows/issue-opened.yml
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
---------
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
2024-12-03 17:03:43 -05:00
Niklas Wenzel
5324c0e6c3
docs: fix grammar in app.relaunch docs ( #44920 )
2024-12-03 09:56:09 -08:00
Sam Maddock
2222920429
feat: WebFrameMain.collectJavaScriptCallStack() ( #44204 )
...
* feat: WebFrameMain.unresponsiveDocumentJSCallStack
* Revert "feat: WebFrameMain.unresponsiveDocumentJSCallStack"
This reverts commit e0612bc1a00a5282cba5df97da3c9c90e96ef244.
* feat: frame.collectJavaScriptCallStack()
* feat: frame.collectJavaScriptCallStack()
* Update web-frame-main.md
2024-12-03 13:32:24 +09:00
Charles Kerr
6d4c271268
chore: remove unused registry arg from GetPrivilegeRequiredByUrl() ( #44908 )
...
this has never been used; introduced by 91071570
2024-12-02 14:02:47 -05:00
Niklas Wenzel
c6b4bde7b5
docs: clarify what session.clearData() with data type 'cache' deletes ( #44852 )
...
* docs: clarify what session.clearData() with data type 'cache' deletes
* docs: include `shadercache`, too
Co-authored-by: John Kleinschmidt <kleinschmidtorama@gmail.com >
---------
Co-authored-by: John Kleinschmidt <kleinschmidtorama@gmail.com >
2024-12-02 13:50:35 -05:00
Niklas Wenzel
bba9ee1cb8
docs: clarify session.clearData() can delete more types than listed ( #44851 )
...
docs: warn that session.clearData() might delete more than expected
2024-12-02 13:29:25 -05:00
Charles Kerr
a7fa6e89b5
chore: remove unused arg from BaseWindow::GetBackgroundColor() ( #44906 )
...
chore: remove unused gin_helper::Arguments* arg from BaseWindow::GetBackgroundColor()
looks like this was added in db79734b
2024-12-02 11:39:10 -05:00
Charles Kerr
06612cf5d4
chore: remove unused isolate argument from Cookies constructor ( #44907 )
...
* chore: remove unused isolate argument from Cookies constructor
unused since the ginify cookies refactor in Mar 2020, commit 22202255
2024-12-02 11:34:21 -05:00
electron-appveyor-updater[bot]
49b294628c
build: update appveyor image to latest version ( #44840 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-12-02 11:14:41 -05:00
Charles Kerr
493e3c4537
fix: don't use deprecated ui::MouseEvent constructor ( #44868 )
...
* refactor: do not use deprecated gfx::Point constructor for MouseEvent
Deprecated in https://chromium-review.googlesource.com/c/1444251
* refactor: use WebInputEvent::GetTypeAsUiEventType() instead of rolling our own
Added in https://chromium-review.googlesource.com/c/chromium/src/+/2180291
2024-12-02 11:13:38 -05:00
Charles Kerr
b2ce5296af
fix: remove unused id argument from TranslateToStock() ( #44900 )
...
unused since fb537d91fc
2024-12-01 16:34:48 -06:00
illusory-dream
4e40b49d1a
docs: fix a syntax issue in document breaking changes ( #44841 )
...
fix: syntax issue in docs
2024-11-30 21:44:33 -08:00
Niklas Wenzel
d8149aa376
docs: specify default value for respondToAuthRequestsFromMainProcess ( #44855 )
...
docs: specify default value for respondToAuthRequestsFromMainProcess
2024-11-30 21:33:33 -08:00
Charles Kerr
033a0abb59
refactor: reduce scope of relauncher's internal constants ( #44860 )
...
* refactor: make kRelauncherArgSeparator private to relauncher.cc
* refactor: make kRelauncherTypeArg private to relauncher.cc
* refactor: remove unused type relauncher::CharType
* refactor: move private constants into standalone private namespace
* refactor: move kWaitEventName into the only function that uses it
2024-11-30 06:54:40 -06:00
Shelley Vohr
8f00cc9c0e
build: remove context-aware patch ( #44862 )
2024-11-29 11:45:33 -06:00
Charles Kerr
f7e823ac80
refactor: return-braced-init-list pt 2 of 2 ( #44870 )
...
* refactor: more return-braced-init-list, this time for v8 and gin objects
* refactor: more return-braced-init-list, this time for v8, gin, std, and base objects
2024-11-29 11:44:33 -06:00
Charles Kerr
4a695d07c6
fix: misc-use-internal-linkage warnings ( #44843 )
...
* refactor: misc-use-internal-linkage warnings in context bridge
move impl functions into anonymous namespace so that they're not visible
to other compilation units:
- ExposeAPIInWorld()
- IsCalledFromMainWorld()
- OverrideGlobalPropertyFromIsolatedWorld()
- OverrideGlobalValueFromIsolatedWorld()
- TraceKeyPath()
* refactor: misc-use-internal-linkage warnings in skia util
move impl details into anonymous namespace so that they're not visible
to other compilation units:
- struct ScaleFactorPair
- kScaleFactorPairs[]
- GetScaleFactorFromPath()
- AddImageSkiaRepFromPath()
* refactor: misc-use-internal-linkage warnings in printing util
move impl details into anonymous namespace so that they're not visible
to other compilation units:
- GetFullPagePlugin()
* refactor: misc-use-internal-linkage warnings in blijnk converter
move impl details into anonymous namespace so that they're not visible
to other compilation units:
- GetKeyLocationCode()
- ModifiersToArray()
* refactor: misc-use-internal-linkage warnings in extrension system
move impl details into anonymous namespace so that they're not visible
to other compilation units:
- ParseManifest()
* refactor: misc-use-internal-linkage warnings in skia util
move impl details into anonymous namespace so that they're not visible
to other compilation units:
- GetFrameTokenMap()
- GetFrameTreeNodeIdMap()
* refactor: misc-use-internal-linkage warnings in electron_api_utility_process.cc
move impl details into anonymous namespace so that they're not visible
to other compilation units:
- GetAllUtilityProcessWrappers()
* refactor: misc-use-internal-linkage warnings in electron_api_menu
move impl details into anonymous namespace so that they're not visible
to other compilation units:
- InvokeBoolMethod()
* refactor: misc-use-internal-linkage warnings in platform util
move impl details into anonymous namespace so that they're not visible
to other compilation units:
- struct TrashItemResult
- TrashItemOnBlockingThread()
2024-11-27 10:40:39 -06:00
Charles Kerr
4aa1855e39
refactor: use base::Extend in AddAdditionalSchemes() ( #44839 )
2024-11-27 07:55:54 -06:00
Charles Kerr
f595443a22
refactor: fix modernize-return-braced-init-list warnings ( #44838 )
...
* refactor: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
* refactor: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
NB: using the braced-initializer list uncovered an error here:
the float returned by std::floor() can't be implicitly cast to
an int. This is solved by using base::ClampFloor<int>() instead.
std::floor()
2024-11-27 09:41:46 +09:00
dependabot[bot]
9f1e23c405
build(deps): bump github/codeql-action from 3.27.4 to 3.27.5 ( #44837 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.27.4 to 3.27.5.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](ea9e4e3799...f09c1c0a94support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-26 11:26:35 +01:00
Charles Kerr
93f49d1189
fix: modernize-use-using clang-tidy warnings ( #44806 )
2024-11-25 10:50:33 -05:00
Charles Kerr
3c941c7e8f
fix: modernize-avoid-c-arrays ( #44813 )
...
use string_view for constants used in methods that take string_view args
2024-11-25 10:49:58 -05:00
Charles Kerr
024fee4e44
fix: modernize-use-nodiscard clang-tidy warnings ( #44808 )
2024-11-25 10:48:28 -05:00
electron-roller[bot]
7e7010dacf
chore: bump chromium to 133.0.6852.0 (main) ( #44748 )
...
* chore: bump chromium in DEPS to 133.0.6847.0
* chore: bump chromium in DEPS to 133.0.6848.0
* chore: update patches
* implement extensions::GlobalShortcutListener::ExecuteCommand stub
https://chromium-review.googlesource.com/c/chromium/src/+/5871484
* fix: ismediakey patch, oops
* fix: another missing bracket
* chore: bump chromium in DEPS to 133.0.6850.0
* chore: update patches
* SharedStorageOperationPtr -> SharedStorageModifierMethodPtr
https://chromium-review.googlesource.com/c/chromium/src/+/5990970
* build GlobalShortcutListenerLinux
https://chromium-review.googlesource.com/c/chromium/src/+/5871484
* chore: bump chromium in DEPS to 133.0.6851.0
* fix: include full type for network::mojom::SharedStorageModifierMethod
* chore: update patches
* chore: bump chromium in DEPS to 133.0.6852.0
* chore: update patches
* build: remove duplicated icudtl.dat and snapshot_blob.bin
https://chromium-review.googlesource.com/c/chromium/src/+/5999387
* fix: include static methods in node tests involving call stacks
https://chromium-review.googlesource.com/c/v8/v8/+/5907815
* revert: moved code in picture-in-picture.patch
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
2024-11-25 10:45:47 -05:00
Ajay Kemparaj
fbe01cdc16
docs: correct stable release dates for v34.0.0 ( #44807 )
...
* docs: correct stable release dates for v34.0.0
* docs: correct stable release dates for v34.0.0
2024-11-25 10:43:56 -05:00
Niklas Wenzel
b8b2e12c9c
docs: fix wording in auto-updater.md ( #44787 )
...
* docs: fix wording in auto-updater.md
* docs: update wording
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
---------
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
2024-11-24 13:00:42 -08:00
Charles Kerr
94a65df270
refactor: remove unnecessary constructor code ( #44816 )
2024-11-24 08:55:46 -06:00
Charles Kerr
24df5f96d7
fix: remove unused local variables ( #44815 )
...
* chore: remove unused local non-trivial variable relaunch_executable
became unused in June 2016 in 0d066de572a08926
2024-11-23 17:34:51 -06:00
David Sanders
4a3513377c
docs: update new GitHub issue link ( #44791 )
2024-11-22 11:48:59 -08:00
Savely Krasovsky
c5ea177b3d
feat: add query-session-end and improve session-end events on Windows ( #44598 )
...
* feat: add query-session-end event for Windows
* fix: remove debug line
* feat: notify with reason on session-end
* docs: add comments and return params
* docs: add same docs to the BrowserWindow
* fix: add shutdown reason if lParam == 0
* docs: remove 'force' word
* docs: revert multithreading.md change
* docs: add reasons documentation, reason variable renamed to reasons
* docs: improve 'shutdown' reason wording
* docs: reword with 'can be'
* fix: pass reasons by reference
* fix: use newer approach which expose reasons value directly on Event object
* docs: add escaping
* style: linter fixes
* fix: project now should compile
* fix: EmitWithoutEvent method added, EmitWithEvent moved to private again
* docs: typo fix
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com >
* docs: dedicated WindowSessionEndEvent type created
* docs: better wording for session-end event description
Co-authored-by: Will Anderson <will@itsananderson.com >
---------
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com >
Co-authored-by: Will Anderson <will@itsananderson.com >
2024-11-22 11:47:36 -08:00
Shelley Vohr
0285592d61
fix: crash calling shell.readShortcutLink ( #44784 )
...
fix: crash calling shell.readShortcutLink
2024-11-22 09:37:17 -05:00
Shelley Vohr
86e4529d26
fix: ensure context-menu emitted for draggable regions ( #44761 )
...
* fix: ensure context-menu emitted for draggable regions
* chore: address suggestions from review
2024-11-22 12:33:38 +01:00
Charles Kerr
4fd1b5b186
fix: big endian bug in V8 serialization ( #44776 )
2024-11-22 12:04:53 +01:00
BILL SHEN
1d55eb9a45
build: remove duplicate line in gn file ( #44786 )
...
style: remove duplicate line in gn file
2024-11-22 12:03:49 +01:00
Charles Kerr
0005ae9557
docs: sync 34.0.0 release date to Chromium 132 release date ( #44766 )
2024-11-21 10:51:19 -06:00
Charles Kerr
86962ba2c3
fix: clang-tidy performance-inefficient-vector-operation warnings ( #44743 )
...
* fix: performance-inefficient-vector-operation warning in Clipboard::WriteFilesForTesting()
* fix: performance-inefficient-vector-operation warning in GetUploadedReports()
2024-11-20 18:11:00 -06:00
Charles Kerr
6789431f74
fix: performance-no-automatic-move clang-tidy warnings ( #44742 )
...
* fix: performance-no-automatic-move in GetLogFileName()
remove `const` from log_filename.
Warning fixed by this commit:
../../electron/shell/common/logging.cc:40:12: warning: constness of 'log_filename' prevents automatic move [performance-no-automatic-move]
* fix: performance-no-automatic-move in GetBundleResourcePath()
remove `const` from request_relative_path.
Warning fixed by this commit:
electron/shell/browser/extensions/electron_extensions_browser_client.cc:187:10: warning: constness of 'request_relative_path' prevents automatic move [performance-no-automatic-move]
2024-11-20 18:10:30 -06:00
nilaoda
0ea64850af
fix: windows save dialog extension bug ( #44296 )
...
* fix: windows save dialog extension bug
* refactor: simplify firstSpec extraction
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: split when necessary
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com >
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com >
2024-11-20 17:27:49 -05:00
