Keeley Hammond
62b3a6b724
fix: ensure web_contents() is alive before grabbing view ( #30572 )
2021-08-17 14:08:25 -07:00
trop[bot]
b3eff8ef13
fix: handle nullish WebContentsView in UpdateDraggableRegions ( #30557 )
...
* fix: handle nullish WebContentsView in UpdateDraggableRegions
* build: nogncheck on webcontentsimpl include
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
2021-08-17 01:23:26 -07:00
trop[bot]
4a24a28467
fix: guard against missing native view ( #30326 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2021-08-02 09:57:25 +09:00
Cheng Zhao
c8ab43a766
fix: pressing ESC should exit fullscreen from webview ( #30128 )
2021-07-26 17:34:04 +09:00
trop[bot]
2e096ac6bc
fix: adjust initial webContents focus calculation ( #29234 )
...
* fix: adjust initial webContents focus calculation
* fix: active window check on mac
* fix: about:blank focus behavior
* chore: add spec
* fix: window ordering on mac
* chore: focus <webview> after navigation
* chore: fix flaky fullscreen inheritance test
* chore: disable fullscreen test on mac arm
* chore: simplify found-in-page spec
* chore: fix lint
* chore: move found-in-page spec to main process
* chore: fix lint
* chore: remove focus workaround
* chore: improve found-in-page spec
Co-authored-by: Raymond Zhao <raymondzhao@microsoft.com >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2021-07-14 11:03:01 -07:00
trop[bot]
5fbcee074d
fix: return RGBA values from getSystemColor ( #30088 )
...
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
2021-07-14 20:46:08 +09:00
trop[bot]
fc75bf0a9e
fix: webview should maximize on requestFullscreen ( #29987 )
...
* fix: webview should maximize on requestFullscreen
* chore: update patches
Co-authored-by: Cheng Zhao <zcbenz@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2021-07-05 14:36:39 -04:00
trop[bot]
fea59c5601
fix: correctly propagate title updates for window with no navigation entries ( #29958 )
...
* fix: correctly propagate title updates for window with no navigation entries
* test
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
2021-07-02 09:49:58 +09:00
Shelley Vohr
bde3d403a8
fix: child window alwaysOnTop level persistence ( #29956 )
2021-07-01 10:22:37 -04:00
trop[bot]
e8621de3f5
fix: properly handle optional requestHeaders with onBeforeSendHeaders ( #29836 )
...
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2021-06-23 10:09:25 +09:00
Keeley Hammond
5d36cdf485
fix: color select eyedropper not working within DevTools ( #29729 ) ( #29760 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2021-06-18 11:34:03 +02:00
trop[bot]
b143042c7f
fix: draggable regions with devtools open ( #29734 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2021-06-17 15:21:27 +09:00
trop[bot]
192fc3ee2c
fix: check DCHECK_IS_ON() instead of #ifdef DCHECK_IS_ON ( #29674 )
...
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
2021-06-14 21:00:20 +09:00
trop[bot]
e0e7b14bdc
fix: use correct spelling of attachment with Content-Disposition header ( #29672 )
...
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2021-06-14 20:59:05 +09:00
trop[bot]
30921548ed
fix: make intermediates work with 'select-client-certificate' ( #29569 )
...
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2021-06-08 11:40:09 +09:00
Cheng Zhao
9059a50f93
fix: keep shifted character in menu accelerator ( #29482 )
...
* fix: keep shifted character in menu accelerator
* chore: update patches
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2021-06-07 10:25:35 -04:00
trop[bot]
f0a9e56741
chore: return early on promise rejection ( #29538 )
...
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2021-06-07 10:17:15 +09:00
Jeremy Rose
6e169089f0
feat: support loading debug urls with loadURL() ( #29404 ) ( #29491 )
2021-06-02 17:03:01 -07:00
trop[bot]
f95d2bdfd1
chore: remove duplicate option get for CustomScheme ( #29453 )
...
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2021-06-01 19:12:51 +09:00
David Sanders
b44024d660
fix: add service worker schemes from command line in renderer ( #29425 ) ( #29446 )
2021-06-01 17:51:39 +09:00
trop[bot]
d0d6e88e5a
chore: use consistent parameter names ( #29442 )
...
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2021-06-01 15:25:32 +09:00
Keeley Hammond
c69d0eea2e
feat: add more info in setWindowOpenHandler details ( #28518 ) ( #29277 )
...
* fix: invoke the window open handler for _blank links
* feat: add disposition to setWindowOpenHandler details
* fix: pass postData to new-window event
* postData can be heterogeneous
* fix type of postBody
* fix type of UploadFile and UploadRawData to be discriminated unions
* exclude the empty string from additionalFeatures
* add a test
* add postBody and referrer to setWindowOpenHandler args
* appease typescript
* Update api-browser-window-spec.ts
* update snapshots
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2021-05-24 16:49:52 +09:00
trop[bot]
e261519469
fix: pdf viewer permissions ( #29252 )
2021-05-20 07:29:11 +02:00
trop[bot]
caac2e8fc7
fix: prevent crash on web-contents creation when error is thrown ( #29106 )
...
* fix: prevent crash when error occurs during event emitter CallMethod
* wip: emit error event within trycatch
* fix: handle uncaught exceptions within node on web_contents init
* fix: create gin_helper::CallMethodCatchException
* test: add web-contents create crash to test cases
* test: clean up test data for web-contents crash
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
* fix: convert CatchException to WebContents static helper method
* fix: restore try_catch to callsite
Co-authored-by: VerteDinde <keeleymhammond@gmail.com >
Co-authored-by: VerteDinde <khammond@slack-corp.com >
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2021-05-12 12:03:34 -07:00
Electron Bot
f72597be06
chore: bump chromium to 91.0.4472.33 (13-x-y) ( #28660 )
...
* chore: bump chromium in DEPS to 91.0.4472.5
* chore: rebuild chromium/dcheck.patch with import-patches -3
Mechanical only; no code changes
(cherry picked from commit 68e369c945https://chromium-review.googlesource.com/c/chromium/src/+/2725153
The function being patched (BrowserMainLoop::MainMessageLoopRun()) no
longer exists.
NB: if removing this introduces regressions the likely fix will be to
add a similar patch for ShellBrowserMainParts::WillRunMainMessageLoop()
which has similar code and was added at the same time this was removed.
(cherry picked from commit 52208297487613ca268ec0c5f45195ea6f3e096e8d9aa4f1f279e84fb72b543fb6dae7https://chromium-review.googlesource.com/c/v8/v8/+/2763874
This patch has been merged upstream
(cherry picked from commit d36de6e2d67c148e9102https://chromium-review.googlesource.com/c/chromium/src/+/2757969
Sync with removal of render_frame_id_
(cherry picked from commit fd954aefd4https://chromium-review.googlesource.com/c/chromium/src/+/2785841
SkColorFromColorId() no longer takes theme, scheme args
(cherry picked from commit f676453fb8https://chromium-review.googlesource.com/c/chromium/src/+/2772143
Change new calls to GetDarkSchemeColor to fit our patched call signature
(cherry picked from commit 27c5d9da5ehttps://chromium-review.googlesource.com/c/chromium/src/+/2757969
Sync with removal of render_frame_id_ in our mojom
(cherry picked from commit 285db29015https://chromium-review.googlesource.com/c/chromium/src/+/2740008
UrlInfo ctor now takes UrlInfo::OriginIsolationRequest instead of a bool
(cherry picked from commit 06ac6c5d6ahttps://chromium-review.googlesource.com/c/chromium/src/+/2755314
Upstream has removed `history_list_length_` which we were comparing to 0
to calculate our `is_initial_navigation` bool when calling ShouldFork().
ShouldFork() is ours and none of the code paths actually use that param,
so this commit removes it altogether.
(cherry picked from commit 2b0cb2ca2ahttps://chromium-review.googlesource.com/c/chromium/src/+/2789074
Replace all uses of APIPermission::ID enum with Mojo type
(cherry picked from commit bfe55a9c68https://chromium-review.googlesource.com/c/chromium/src/+/2725153
Used to return void; now returns an int errorcode.
Note: 2725153 also has some nice doc updates about Browser's "stages"
(cherry picked from commit 2622e91c44https://chromium-review.googlesource.com/c/chromium/src/+/2725153
RunMainMessageLoopParts has been replaced with WillRunMainMessageLoop
so `BrowserMainLoop::result_code_` is no longer available to us for our
exit_code_ pointer.
This variable held a dual role: (1) of course, hold the exit code, but
also (2) was a nullptr before the message loop was ready, indicating to
anyone calling SetExitCode() that we were still in startup and could
just exit() without any extra steps. exit_code_ still fulfills these two
roles but is now a base::Optional.
(cherry picked from commit 0497272fabhttps://chromium-review.googlesource.com/c/chromium/src/+/2725153
BrowserMainParts::BrowsePreDefaultMainMesssageLoopRun() has been
removed; move that work to the new WillRunMainMessageLoop().
(cherry picked from commit 77eacd8073https://chromium-review.googlesource.com/c/chromium/src/+/2785973
(cherry picked from commit 4bcf9d58b0https://chromium-review.googlesource.com/c/chromium/src/+/2773408
The upstream code is still in flux (e.g. reverts and re-lands) but the
tl;dr for this commit is (1) include thread_pool.h if you're using it
and (2) don't instantiate pools directly.
(cherry picked from commit 4e33ee0ad3https://chromium-review.googlesource.com/c/chromium/src/+/2762858
NB: One logic branch in ProxyingURLLoaderFactory::CreateLoaderAndStart
calls std::make_unique<InProgressRequest>, which needs a routing_id.
This PR uses the member field `routing_id_` since there's no longer one
being passed into CreateLoaderAndStart.
(cherry picked from commit 70759ad342https://chromium-review.googlesource.com/c/chromium/src/+/2771318
PartitionOptions' enums have changed.
(cherry picked from commit 48f437b478https://chromium-review.googlesource.com/c/chromium/src/+/2771320
tldr: s/Manifest::FOO/ManifestLocation::kFoo/
(cherry picked from commit 866e02999a4444596af5https://chromium-review.googlesource.com/c/chromium/src/+/2771320
- extensions::Manifest::COMPONENT
+ extensions::mojom::ManifestLocation::kExternalComponent
(cherry picked from commit c97cef7059https://chromium-review.googlesource.com/c/chromium/src/+/2740008
UrlInfo ctor now takes UrlInfo::OriginIsolationRequest instead of a bool
(cherry picked from commit 7effb909b6https://chromium-review.googlesource.com/c/chromium/src/+/2792623
python3 is being used in parts of the upstream build, but the copy of
convert_protocol_to_json.py invoked in v8/third_party/inspector_protocol
is not python3-friendly. Node has a py2+3-friendly version of it in its
tools directory, so call it instead.
(cherry picked from commit a237fc9affhttps://chromium-review.googlesource.com/c/chromium/src/+/2791122
tldr:
- extensions::APIPermission::kFoo
+ extensions::mojom::APIPermissionID::kFoo
(cherry picked from commit bf9ef3b636https://chromium-review.googlesource.com/c/chromium/src/+/2765737
Remove TLS v1.0 & 1.1 from our SSLProtocolVersionFromString() function.
This is the same change made upstream at
https://chromium-review.googlesource.com/c/chromium/src/+/2765737/8/chrome/browser/ssl/ssl_config_service_manager_pref.cc
(cherry picked from commit c4558b031df509f1b8cchttps://chromium-review.googlesource.com/c/chromium/src/+/2791431
tldr: {Subscribe,Unsubscribe}PermissionStatusChange's tag type used to
be an int; now it's the new SubscriptionId type (which is an IdType64).
(cherry picked from commit 11608d2745https://chromium-review.googlesource.com/c/chromium/src/+/2752635
tldr: PowerMonitor has been split into PowerStateObserver,
PowerSuspendObserver, and PowerThermalObserver to reduce number of tasks
posted to consumers who only need notifications for one of those things
instead of all of them.
(cherry picked from commit 2d4c79413bhttps://chromium-review.googlesource.com/c/chromium/src/+/2771318
(cherry picked from commit f69e95824f96195f845b5d64fa28d5https://chromium-review.googlesource.com/c/chromium/src/+/2795472
tldr: sync patch with upstream renamed variable & macro names.
(cherry picked from commit ce541697e5https://chromium-review.googlesource.com/c/chromium/src/+/2796200
tldr: no code changes; just updating the diff to apply cleanly.
note: ooh upstream Wayland hacking!
(cherry picked from commit 6ec5c72878https://chromium-review.googlesource.com/c/chromium/src/+/2710023
tldr: no code changes; just updating the diff to apply cleanly.
(cherry picked from commit 8ae0b0d740https://chromium-review.googlesource.com/c/chromium/src/+/2775573
tldr: no code changes; just updating the diff to apply cleanly.
(cherry picked from commit d5b017208b218952ec9dhttps://chromium-review.googlesource.com/c/chromium/src/+/2796511
tldr: NotifyObservers has been renamed to NotifyOnNativeThemeUpdated,
so update the invocation in our patch.
(cherry picked from commit 6fe734f5cahttps://chromium-review.googlesource.com/c/chromium/src/+/2797454
tldr: GetDevToolsManagerDelegate() was returning an owned raw pointer.
Replaced it with CreateDevToolsManagerDelegate() which uses unique_ptr<>.
(cherry picked from commit b760f7162bhttps://chromium-review.googlesource.com/c/chromium/src/+/2762201
`file-handling` string confirmed in https://chromium-review.googlesource.com/c/chromium/src/+/2762201/18/chrome/browser/ui/webui/settings/site_settings_helper.cc
(cherry picked from commit d9cdb18eb7https://chromium-review.googlesource.com/c/chromium/src/+/2762858
Part 1: the easiest ones
(cherry picked from commit 6ee282b27ahttps://chromium-review.googlesource.com/c/infra/luci/python-adb/+/2796724
(cherry picked from commit fbf5c04716https://chromium-review.googlesource.com/c/chromium/src/+/2668974
(cherry picked from commit 74577f2156https://chromium-review.googlesource.com/c/chromium/src/+/2802766
(cherry picked from commit 409328fc38https://chromium-review.googlesource.com/c/chromium/src/+/2802823
(cherry picked from commit 43658b0ed3https://chromium-review.googlesource.com/c/chromium/src/+/2803041
(cherry picked from commit 01f514f537https://chromium-review.googlesource.com/c/chromium/src/+/2798873
(cherry picked from commit 5384398823https://chromium-review.googlesource.com/c/chromium/src/+/2733595
(cherry picked from commit f6cf612ee3f078eddc2bhttps://chromium-review.googlesource.com/c/chromium/src/+/2795107
(cherry picked from commit 93077afbfb8f2abcee38https://chromium-review.googlesource.com/c/chromium/src/+/2710023
(cherry picked from commit 4a4da7ad6aa1f0bbb0b5186528aab93129ea403dhttps://chromium-review.googlesource.com/c/chromium/src/+/2724817
(cherry picked from commit dacbf3d60dhttps://chromium-review.googlesource.com/c/chromium/src/+/2797341
(cherry picked from commit 945890fcf9https://chromium-review.googlesource.com/c/chromium/src/+/2805553
(cherry picked from commit db74b380fd2804366https://chromium-review.googlesource.com/c/chromium/src/+/2804366
(cherry picked from commit deca961382https://chromium-review.googlesource.com/c/chromium/src/+/2784730
(cherry picked from commit 0fac051a0c01235ba336https://chromium-review.googlesource.com/c/chromium/src/+/2810174
(cherry picked from commit c8a7225cachttps://chromium-review.googlesource.com/c/chromium/src/+/2807829
(cherry picked from commit 39f0c263d7https://chromium-review.googlesource.com/c/chromium/src/+/2791362
(cherry picked from commit fa0d3a0f75https://chromium-review.googlesource.com/c/chromium/src/+/2797341
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2804366
(cherry picked from commit 28253c6ccc19c9e94014ae70252e0988baf8835c01a1c37999a203347075https://chromium-review.googlesource.com/c/chromium/src/+/2797341
(cherry picked from commit 9d31092db8https://chromium-review.googlesource.com/c/chromium/src/+/2628496
(cherry picked from commit 4985c57685ec782c1bdehttps://chromium-review.googlesource.com/c/chromium/src/+/2714464
(cherry picked from commit 2772241a2c186528aab92ce2f73a0c898f8448f82622e91c44f8f388573c93077afbfb20cd4cb875a1d19bc2124e33ee0ad33632067c10e455f68b6460cc150a17https://chromium-review.googlesource.com/c/chromium/src/+/2709931
(cherry picked from commit f835dd1c2ae0720df6d472ca89b31196027e018662faa304df52562150ca572987a15ff771dfe0abd4eb5efdb3https://chromium-review.googlesource.com/c/chromium/src/+/2478082
* run specs separately on WOA
* Update comment
* escape %
* specify files properly
* revert WOA testing changes
* chore: bump chromium in DEPS to 91.0.4472.33
* chore: update patches
* Trigger CI
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
Co-authored-by: Samuel Attard <sattard@slack-corp.com >
2021-05-03 20:09:30 -04:00
trop[bot]
5c12606b13
feat: add session.storagePath to get path on disk for session data ( #28866 )
...
* feat: add session.storagePath to get path on disk for session data
* spec: add session.storagePath tests
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
2021-05-03 12:14:53 -04:00
Electron Bot
66a2218723
chore: bump chromium to 91.0.4448.0 (13-x-y) ( #28127 )
...
* chore: bump chromium in DEPS to 90.0.4430.19
* build: add 'use_rts' definition
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2694187
(cherry picked from commit b820b4078d55e50a0879https://chromium-review.googlesource.com/c/chromium/src/+/2699022
(cherry picked from commit e715b9c921c8148febfahttps://chromium-review.googlesource.com/c/chromium/src/+/2710351
(cherry picked from commit 87df2766bahttps://chromium-review.googlesource.com/c/chromium/src/+/2667839
(cherry picked from commit e900271beahttps://chromium-review.googlesource.com/c/chromium/src/+/2689805
(cherry picked from commit eccfa516c5https://chromium-review.googlesource.com/c/chromium/src/+/2657617
(cherry picked from commit 2fed02556dhttps://chromium-review.googlesource.com/c/chromium/src/+/2680274
(cherry picked from commit 0d94e0d1d9https://chromium-review.googlesource.com/c/chromium/src/+/2071443
(cherry picked from commit 1a296e59c2https://chromium-review.googlesource.com/c/chromium/src/+/2710351
(cherry picked from commit dc36e8e6fchttps://chromium-review.googlesource.com/c/chromium/src/+/2685601
(cherry picked from commit 59669e99cbhttps://chromium-review.googlesource.com/c/chromium/src/+/2071443
(cherry picked from commit be627568b2https://chromium-review.googlesource.com/c/chromium/src/+/2698090
(cherry picked from commit 77ad17b383https://chromium-review.googlesource.com/c/chromium/src/+/2700637
(cherry picked from commit 4e02d9407ahttps://chromium-review.googlesource.com/c/chromium/src/+/2638372
(cherry picked from commit f51f42764659432fe30a54cc68dd7ae99e6a5a8a1e166065248f4e362d8f8008deb41cfae4d87a5ahttps://chromium-review.googlesource.com/c/chromium/src/+/2752406
(cherry picked from commit d4bec23bdehttps://chromium-review.googlesource.com/c/chromium/src/+/2752406
(cherry picked from commit 9e336f5d0chttps://chromium-review.googlesource.com/c/chromium/src/+/2752932
(cherry picked from commit 08036802cbhttps://chromium-review.googlesource.com/c/chromium/src/+/2651385
(cherry picked from commit 676f74f3dchttps://chromium-review.googlesource.com/c/chromium/src/+/2734095
(cherry picked from commit 76538d2d38003dd6c16c9f5e3f6685https://chromium-review.googlesource.com/c/chromium/src/+/2743594
(cherry picked from commit b15b820bcahttps://chromium-review.googlesource.com/c/chromium/src/+/2725403
(cherry picked from commit 185c343b22https://chromium-review.googlesource.com/c/chromium/src/+/2651385
(cherry picked from commit 88bbe2a352https://chromium-review.googlesource.com/c/chromium/src/+/2721718
(cherry picked from commit 3010dd93e3https://chromium-review.googlesource.com/c/chromium/src/+/2733070
(cherry picked from commit d54bee03d05fc298ee5fhttps://chromium-review.googlesource.com/c/chromium/src/+/2648046
(cherry picked from commit 2cd53eb46ahttps://chromium-review.googlesource.com/c/chromium/src/+/2752406
(cherry picked from commit f1bb6be4b93160e608e286d23cee40https://chromium-review.googlesource.com/c/chromium/src/+/2757472
(cherry picked from commit 22d8f22cfbhttps://chromium-review.googlesource.com/c/chromium/src/+/2757472
(cherry picked from commit ec893f8322https://chromium-review.googlesource.com/c/v8/v8/+/2720306
(cherry picked from commit d0989802bd29dfabadfd97b6868e9cb6d2ae04557e961d8a37c49bc282d5https://chromium-review.googlesource.com/c/chromium/src/+/2693008
(cherry picked from commit 3b183854ffhttps://chromium-review.googlesource.com/c/chromium/src/+/2757472
(cherry picked from commit 2d3c65becadeeb2de14b451e0931bf205f57218174318705c2ea62ecd1885b598037bb61cf1abd4d83d93bcbdc4f97b9303c7f7b1f6c8aaaf03765ed640a145112dd975328a0606fd87d1e01ca00ec82https://chromium-review.googlesource.com/c/chromium/src/+/2707696
(cherry picked from commit 3122820e581f575ca3af54e72fa8e30f3620099a9127cff58b1594c549339127cff58b9684d851010cc08813a6samuel.r.attard@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: John Kleinschmidt <jkleinsc@github.com >
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2021-04-13 11:29:10 -04:00
trop[bot]
250438c2d9
refactor: remove more uses of v8::Isolate::GetCurrent() ( #28429 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2021-03-30 00:29:28 -07:00
trop[bot]
32d3e82d88
fix: make sure service worker scheme is registered with allowServiceWorkers ( #28354 )
...
* Fix custom scheme not registered as service worker scheme
* ServiceWorker loaders do not have WebContents associated
* Add test for service worker
* Revert "Fix custom scheme not registered as service worker scheme"
This reverts commit a249235b22zcbenz@gmail.com >
2021-03-24 16:55:13 +09:00
trop[bot]
5b3c90e6c6
fix: DesktopCapturer gc'd prior to capture completion ( #28280 )
...
desktopCapture.getSources() returns a promise which should resolve
when capturing finishes. Internally it creates an instance of
DesktopCapturer which is responsible for resolving or rejecting
the promise.
Between the time DesktopCapturer starts capturing frames and when
it finishes, it's possible for its handle to be GC'd leading to
it never resolving.
These changes pin the instance of DesktopCapturer until it either
finishes or errors.
fixes #25595
Co-authored-by: samuelmaddock <samuel.maddock@gmail.com >
2021-03-22 11:03:24 +09:00
trop[bot]
5f07df4a3d
fix: bad menu position when no positioning item specified ( #28276 )
...
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
2021-03-19 10:20:35 +09:00
trop[bot]
7f4ab06f11
fix: convert system colors to device color space in systemPreferences ( #28173 )
...
Co-authored-by: Samuel Attard <sattard@slack-corp.com >
2021-03-13 05:00:50 -08:00
trop[bot]
c11d6813e4
fix: ensure child window transparency works ( #28112 )
...
* fix: ensure child window transparency works
Windows opened via window.open and intecepted via setWindowOpenHandler
or the `new-window` event should (a) have the correct background color
and (b) that background color should be transparent if specified.
The changes in api_web_contents fix (a) and the changes in
web_contents_preferences fix (b).
Notes: Child windows with specified background colors or transpency now
work as intended
* fix: set background_color in blink prefs apply logic
* chore: update for PR comments
Co-authored-by: Samuel Attard <sattard@slack-corp.com >
2021-03-12 09:18:41 -08:00
trop[bot]
c10274663c
fix: change #if defined(OS_MACOSX) to #if defined(OS_MAC) ( #28153 )
...
Co-authored-by: Milan Burda <milan.burda@gmail.com >
2021-03-12 16:44:25 +09:00
John Kleinschmidt
2ce64944ab
chore: bump chromium to 90.0.4415.0 (master) ( #27694 ) ( #28082 )
...
* chore: bump chromium in DEPS to 520c02b46668fc608927e0fcd79b6a90885a48bf
* chore: bump chromium in DEPS to 90.0.4414.0
* resolve chromium conflicts
* resolve v8 conflicts
* fix node gn files
* 2673502: Remove RenderViewCreated use from ExtensionHost.
https://chromium-review.googlesource.com/c/chromium/src/+/2673502
* 2676903: [mojo] Remove most legacy Binding classes.
https://chromium-review.googlesource.com/c/chromium/src/+/2676903
* 2644847: Move self-deleting URLLoaderFactory base into //services/network.
https://chromium-review.googlesource.com/c/chromium/src/+/2644847
* 2664006: Remove from mojo::DataPipe.
https://chromium-review.googlesource.com/c/chromium/src/+/2664006
* 2674530: Remove CertVerifierService feature
https://chromium-review.googlesource.com/c/chromium/src/+/2674530
* 2668748: Move OnSSLCertificateError to a new interface.
https://chromium-review.googlesource.com/c/chromium/src/+/2668748
* 2672923: Remove RAPPOR reporting infrastructure.
https://chromium-review.googlesource.com/c/chromium/src/+/2672923
* 2673502: Remove RenderViewCreated use from ExtensionHost.
https://chromium-review.googlesource.com/c/chromium/src/+/2673502
* 2655126: Convert FrameHostMsg_ContextMenu and FrameMsg_ContextMenuClosed|CustomContextMenuAction to Mojo
https://chromium-review.googlesource.com/c/chromium/src/+/2655126
* 2628705: Window Placement: Implement screen.isExtended and change event
https://chromium-review.googlesource.com/c/chromium/src/+/2628705
* 2643161: Refactor storage::kFileSystem*Native*
https://chromium-review.googlesource.com/c/chromium/src/+/2643161
* fix build
* only remove the biggest subdir of //ios
* chore: bump chromium in DEPS to 90.0.4415.0
* update patches
* update sysroots
* 2686147: Remove WebContentsObserver::RenderViewCreated().
https://chromium-review.googlesource.com/c/chromium/src/+/2686147
* 2596429: Fixing how extension's split and spanning modes affect OriginAccessList.
https://chromium-review.googlesource.com/c/chromium/src/+/2596429
* 2686026: [mojo] Delete AssociatedInterfacePtr (replaced by AssociatedRemote)
https://chromium-review.googlesource.com/c/chromium/src/+/2686026
* 2651705: Move ui/base/dragdrop/file_info to ui/base/clipboard
https://chromium-review.googlesource.com/c/chromium/src/+/2651705
* 358217: drawBitmap is deprecated
https://skia-review.googlesource.com/c/skia/+/358217
* fix gn check
* 2678098: Use gen/front_end as input to generate_devtools_grd
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2678098
* 2674530: Remove CertVerifierService feature
https://chromium-review.googlesource.com/c/chromium/src/+/2674530
* fixup 2664006: Remove from mojo::DataPipe.
https://chromium-review.googlesource.com/c/chromium/src/+/2664006
* fixup build_add_electron_tracing_category.patch
* 2673415: [base] Prepare CrashReporterClient for string16 switch
https://chromium-review.googlesource.com/c/chromium/src/+/2673415
* 2673413: Add CursorFactoryWin to handle Cursors on Windows
https://chromium-review.googlesource.com/c/chromium/src/+/2673413
* 2668748: Move OnSSLCertificateError to a new interface.
https://chromium-review.googlesource.com/c/chromium/src/+/2668748
* fix mas gn check
* update patch after merge
* Update node for .mjs files
* build: load v8_prof_processor dependencies as ESM
* chore: add patch to fix linux 32bit
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
(cherry picked from commit ca75bca667electron@github.com >
2021-03-10 10:24:58 -08:00
trop[bot]
e6e1372ea7
fix: capturePage not resolving with hidden windows ( #28076 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2021-03-09 13:13:33 -08:00
Cheng Zhao
ede8611937
fix: check web_contents() for destroyed WebContents ( #27815 )
2021-03-02 09:38:56 -08:00
Shelley Vohr
e5a9a1ebd7
fix: ensure owner window valid ( #27786 )
2021-03-01 13:26:23 -08:00
Keeley Hammond
84d0e827a3
chore: revert webFrameMain.executeJavaScriptInIsolatedWorld method ( #27926 )
2021-03-01 10:07:25 -05:00
John Kleinschmidt
d57fd6cef0
fix: navigator.bluetooth.requestDevice ( #27902 )
...
* fix: navigator.bluetooth.requestDevice
* cleanup lint and add test
* update bluetooth test to handle no bluetooth adapter available
* update bluetooth test to handle bluetooth permission denied
2021-02-26 11:10:27 -08:00
Calvin
64eb02b671
fix: restore window event redispatching on mac ( #27701 )
2021-02-18 10:31:53 +09:00
Michaela Laurencin
b0a6eb6a53
fix: add support for title change with window history navigation ( #27724 )
2021-02-17 10:23:45 -08:00
Cheng Zhao
7a7a27d9bc
fix: check WebContents before emitting render-process-gone event ( #27730 )
2021-02-17 21:19:17 +09:00
Samuel Maddock
3250ef551c
feat: support registering MV3 extension service workers ( #27562 )
...
* feat: support registering MV3 extension service workers
* feat: load chrome extension APIs in worker context
* feat: add more ContentRendererClient service worker overrides
* fix: lint error
* refactor: emit object for 'registration-completed'
* docs: clarify when registration-completed emits
2021-02-11 10:58:03 -05:00
marekharanczyk
87064e5b5e
fix: set WebContents background color ubiquitously #27592 ( #27593 )
...
Move it from LoadURL to RenderViewCreated which is present
in all window creation cases and is called early enough to be
relevant from user prespective and after RenderWidgetHostView
is already present.
2021-02-10 12:03:48 -08:00
Stewart Lord
5f5afaae27
feat: add win.setTopBrowserView() so that BrowserViews can be raised ( #27007 )
...
* feat: Raise a browser view via `BrowserWindow.setTopBrowserView()`.
This is similar to removing and re-adding a browser view, but avoids a visible flicker as the browser view is not removed from the window when using `setTopBrowserView`. Note: if the given browser view is not attached to the window, it will be added.
This commit contains the macOS implementation.
* feat: setTopBrowserView support for Windows and Linux
* docs: add info about setTopBrowserView
* docs: Clarify behavior when browserView is not yet attached.
* fix: throw en error when browserView is not attached to the window
* fix: build error
* fix: test
* fix: add test case
* fix: tests
* fix: reparenting
* fix: close second window in tests
Co-authored-by: sentialx <sentialx@gmail.com >
2021-02-10 16:23:35 +09:00
Shelley Vohr
e46446e7e4
chore: bump chromium to e836cbe709f3cd703f233de8eb6cc6ec99b72c9d ( #27475 )
...
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
2021-02-09 12:16:21 -08:00
Jeremy Rose
28599e5e7c
feat: add exit code to render-process-gone details ( #27580 )
2021-02-08 17:08:11 -08:00
Samuel Maddock
1bbfa934f0
fix: early GC of WebFrameMain instances ( #27648 )
2021-02-08 11:30:18 -08:00
Ikko Ashimine
b88f585066
chore: fix typo in electron_api_base_window.cc ( #27644 )
...
reseting -> resetting
2021-02-08 10:18:08 +09:00
