Cheng Zhao
736150672c
fix: move window buttons in-place on macOS ( #30393 )
2021-08-09 16:00:43 +09:00
Robo
3805e3c0fc
fix: update traffic lights position for macOS 11 ( #30319 )
...
Co-authored-by: Cheng Zhao <zcbenz@gmail.com >
2021-07-29 21:15:47 +09:00
trop[bot]
4da1162ffe
fix: allow colored tray titles when font type is specified ( #30163 )
...
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
2021-07-27 09:14:51 +09:00
trop[bot]
fa683ef8b7
fix: fix hover state not clear bug when BrowserWindow is not resizable ( #611 ) ( #29800 )
...
Co-authored-by: sssooonnnggg <sssooonnnggg111@gmail.com >
2021-06-21 13:59:36 +09:00
Keeley Hammond
5d36cdf485
fix: color select eyedropper not working within DevTools ( #29729 ) ( #29760 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2021-06-18 11:34:03 +02:00
trop[bot]
b35f904e58
fix: ensure detached devtools are not always draggable ( #29737 )
...
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
2021-06-17 15:29:27 +09:00
trop[bot]
b143042c7f
fix: draggable regions with devtools open ( #29734 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2021-06-17 15:21:27 +09:00
Cheng Zhao
9059a50f93
fix: keep shifted character in menu accelerator ( #29482 )
...
* fix: keep shifted character in menu accelerator
* chore: update patches
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2021-06-07 10:25:35 -04:00
trop[bot]
d0d6e88e5a
chore: use consistent parameter names ( #29442 )
...
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2021-06-01 15:25:32 +09:00
trop[bot]
c647007ccc
fix: correctly handle Alt+Key shortcuts ( #29443 )
...
Co-authored-by: Cheng Zhao <zcbenz@gmail.com >
2021-06-01 15:25:19 +09:00
Electron Bot
f72597be06
chore: bump chromium to 91.0.4472.33 (13-x-y) ( #28660 )
...
* chore: bump chromium in DEPS to 91.0.4472.5
* chore: rebuild chromium/dcheck.patch with import-patches -3
Mechanical only; no code changes
(cherry picked from commit 68e369c945https://chromium-review.googlesource.com/c/chromium/src/+/2725153
The function being patched (BrowserMainLoop::MainMessageLoopRun()) no
longer exists.
NB: if removing this introduces regressions the likely fix will be to
add a similar patch for ShellBrowserMainParts::WillRunMainMessageLoop()
which has similar code and was added at the same time this was removed.
(cherry picked from commit 52208297487613ca268ec0c5f45195ea6f3e096e8d9aa4f1f279e84fb72b543fb6dae7https://chromium-review.googlesource.com/c/v8/v8/+/2763874
This patch has been merged upstream
(cherry picked from commit d36de6e2d67c148e9102https://chromium-review.googlesource.com/c/chromium/src/+/2757969
Sync with removal of render_frame_id_
(cherry picked from commit fd954aefd4https://chromium-review.googlesource.com/c/chromium/src/+/2785841
SkColorFromColorId() no longer takes theme, scheme args
(cherry picked from commit f676453fb8https://chromium-review.googlesource.com/c/chromium/src/+/2772143
Change new calls to GetDarkSchemeColor to fit our patched call signature
(cherry picked from commit 27c5d9da5ehttps://chromium-review.googlesource.com/c/chromium/src/+/2757969
Sync with removal of render_frame_id_ in our mojom
(cherry picked from commit 285db29015https://chromium-review.googlesource.com/c/chromium/src/+/2740008
UrlInfo ctor now takes UrlInfo::OriginIsolationRequest instead of a bool
(cherry picked from commit 06ac6c5d6ahttps://chromium-review.googlesource.com/c/chromium/src/+/2755314
Upstream has removed `history_list_length_` which we were comparing to 0
to calculate our `is_initial_navigation` bool when calling ShouldFork().
ShouldFork() is ours and none of the code paths actually use that param,
so this commit removes it altogether.
(cherry picked from commit 2b0cb2ca2ahttps://chromium-review.googlesource.com/c/chromium/src/+/2789074
Replace all uses of APIPermission::ID enum with Mojo type
(cherry picked from commit bfe55a9c68https://chromium-review.googlesource.com/c/chromium/src/+/2725153
Used to return void; now returns an int errorcode.
Note: 2725153 also has some nice doc updates about Browser's "stages"
(cherry picked from commit 2622e91c44https://chromium-review.googlesource.com/c/chromium/src/+/2725153
RunMainMessageLoopParts has been replaced with WillRunMainMessageLoop
so `BrowserMainLoop::result_code_` is no longer available to us for our
exit_code_ pointer.
This variable held a dual role: (1) of course, hold the exit code, but
also (2) was a nullptr before the message loop was ready, indicating to
anyone calling SetExitCode() that we were still in startup and could
just exit() without any extra steps. exit_code_ still fulfills these two
roles but is now a base::Optional.
(cherry picked from commit 0497272fabhttps://chromium-review.googlesource.com/c/chromium/src/+/2725153
BrowserMainParts::BrowsePreDefaultMainMesssageLoopRun() has been
removed; move that work to the new WillRunMainMessageLoop().
(cherry picked from commit 77eacd8073https://chromium-review.googlesource.com/c/chromium/src/+/2785973
(cherry picked from commit 4bcf9d58b0https://chromium-review.googlesource.com/c/chromium/src/+/2773408
The upstream code is still in flux (e.g. reverts and re-lands) but the
tl;dr for this commit is (1) include thread_pool.h if you're using it
and (2) don't instantiate pools directly.
(cherry picked from commit 4e33ee0ad3https://chromium-review.googlesource.com/c/chromium/src/+/2762858
NB: One logic branch in ProxyingURLLoaderFactory::CreateLoaderAndStart
calls std::make_unique<InProgressRequest>, which needs a routing_id.
This PR uses the member field `routing_id_` since there's no longer one
being passed into CreateLoaderAndStart.
(cherry picked from commit 70759ad342https://chromium-review.googlesource.com/c/chromium/src/+/2771318
PartitionOptions' enums have changed.
(cherry picked from commit 48f437b478https://chromium-review.googlesource.com/c/chromium/src/+/2771320
tldr: s/Manifest::FOO/ManifestLocation::kFoo/
(cherry picked from commit 866e02999a4444596af5https://chromium-review.googlesource.com/c/chromium/src/+/2771320
- extensions::Manifest::COMPONENT
+ extensions::mojom::ManifestLocation::kExternalComponent
(cherry picked from commit c97cef7059https://chromium-review.googlesource.com/c/chromium/src/+/2740008
UrlInfo ctor now takes UrlInfo::OriginIsolationRequest instead of a bool
(cherry picked from commit 7effb909b6https://chromium-review.googlesource.com/c/chromium/src/+/2792623
python3 is being used in parts of the upstream build, but the copy of
convert_protocol_to_json.py invoked in v8/third_party/inspector_protocol
is not python3-friendly. Node has a py2+3-friendly version of it in its
tools directory, so call it instead.
(cherry picked from commit a237fc9affhttps://chromium-review.googlesource.com/c/chromium/src/+/2791122
tldr:
- extensions::APIPermission::kFoo
+ extensions::mojom::APIPermissionID::kFoo
(cherry picked from commit bf9ef3b636https://chromium-review.googlesource.com/c/chromium/src/+/2765737
Remove TLS v1.0 & 1.1 from our SSLProtocolVersionFromString() function.
This is the same change made upstream at
https://chromium-review.googlesource.com/c/chromium/src/+/2765737/8/chrome/browser/ssl/ssl_config_service_manager_pref.cc
(cherry picked from commit c4558b031df509f1b8cchttps://chromium-review.googlesource.com/c/chromium/src/+/2791431
tldr: {Subscribe,Unsubscribe}PermissionStatusChange's tag type used to
be an int; now it's the new SubscriptionId type (which is an IdType64).
(cherry picked from commit 11608d2745https://chromium-review.googlesource.com/c/chromium/src/+/2752635
tldr: PowerMonitor has been split into PowerStateObserver,
PowerSuspendObserver, and PowerThermalObserver to reduce number of tasks
posted to consumers who only need notifications for one of those things
instead of all of them.
(cherry picked from commit 2d4c79413bhttps://chromium-review.googlesource.com/c/chromium/src/+/2771318
(cherry picked from commit f69e95824f96195f845b5d64fa28d5https://chromium-review.googlesource.com/c/chromium/src/+/2795472
tldr: sync patch with upstream renamed variable & macro names.
(cherry picked from commit ce541697e5https://chromium-review.googlesource.com/c/chromium/src/+/2796200
tldr: no code changes; just updating the diff to apply cleanly.
note: ooh upstream Wayland hacking!
(cherry picked from commit 6ec5c72878https://chromium-review.googlesource.com/c/chromium/src/+/2710023
tldr: no code changes; just updating the diff to apply cleanly.
(cherry picked from commit 8ae0b0d740https://chromium-review.googlesource.com/c/chromium/src/+/2775573
tldr: no code changes; just updating the diff to apply cleanly.
(cherry picked from commit d5b017208b218952ec9dhttps://chromium-review.googlesource.com/c/chromium/src/+/2796511
tldr: NotifyObservers has been renamed to NotifyOnNativeThemeUpdated,
so update the invocation in our patch.
(cherry picked from commit 6fe734f5cahttps://chromium-review.googlesource.com/c/chromium/src/+/2797454
tldr: GetDevToolsManagerDelegate() was returning an owned raw pointer.
Replaced it with CreateDevToolsManagerDelegate() which uses unique_ptr<>.
(cherry picked from commit b760f7162bhttps://chromium-review.googlesource.com/c/chromium/src/+/2762201
`file-handling` string confirmed in https://chromium-review.googlesource.com/c/chromium/src/+/2762201/18/chrome/browser/ui/webui/settings/site_settings_helper.cc
(cherry picked from commit d9cdb18eb7https://chromium-review.googlesource.com/c/chromium/src/+/2762858
Part 1: the easiest ones
(cherry picked from commit 6ee282b27ahttps://chromium-review.googlesource.com/c/infra/luci/python-adb/+/2796724
(cherry picked from commit fbf5c04716https://chromium-review.googlesource.com/c/chromium/src/+/2668974
(cherry picked from commit 74577f2156https://chromium-review.googlesource.com/c/chromium/src/+/2802766
(cherry picked from commit 409328fc38https://chromium-review.googlesource.com/c/chromium/src/+/2802823
(cherry picked from commit 43658b0ed3https://chromium-review.googlesource.com/c/chromium/src/+/2803041
(cherry picked from commit 01f514f537https://chromium-review.googlesource.com/c/chromium/src/+/2798873
(cherry picked from commit 5384398823https://chromium-review.googlesource.com/c/chromium/src/+/2733595
(cherry picked from commit f6cf612ee3f078eddc2bhttps://chromium-review.googlesource.com/c/chromium/src/+/2795107
(cherry picked from commit 93077afbfb8f2abcee38https://chromium-review.googlesource.com/c/chromium/src/+/2710023
(cherry picked from commit 4a4da7ad6aa1f0bbb0b5186528aab93129ea403dhttps://chromium-review.googlesource.com/c/chromium/src/+/2724817
(cherry picked from commit dacbf3d60dhttps://chromium-review.googlesource.com/c/chromium/src/+/2797341
(cherry picked from commit 945890fcf9https://chromium-review.googlesource.com/c/chromium/src/+/2805553
(cherry picked from commit db74b380fd2804366https://chromium-review.googlesource.com/c/chromium/src/+/2804366
(cherry picked from commit deca961382https://chromium-review.googlesource.com/c/chromium/src/+/2784730
(cherry picked from commit 0fac051a0c01235ba336https://chromium-review.googlesource.com/c/chromium/src/+/2810174
(cherry picked from commit c8a7225cachttps://chromium-review.googlesource.com/c/chromium/src/+/2807829
(cherry picked from commit 39f0c263d7https://chromium-review.googlesource.com/c/chromium/src/+/2791362
(cherry picked from commit fa0d3a0f75https://chromium-review.googlesource.com/c/chromium/src/+/2797341
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2804366
(cherry picked from commit 28253c6ccc19c9e94014ae70252e0988baf8835c01a1c37999a203347075https://chromium-review.googlesource.com/c/chromium/src/+/2797341
(cherry picked from commit 9d31092db8https://chromium-review.googlesource.com/c/chromium/src/+/2628496
(cherry picked from commit 4985c57685ec782c1bdehttps://chromium-review.googlesource.com/c/chromium/src/+/2714464
(cherry picked from commit 2772241a2c186528aab92ce2f73a0c898f8448f82622e91c44f8f388573c93077afbfb20cd4cb875a1d19bc2124e33ee0ad33632067c10e455f68b6460cc150a17https://chromium-review.googlesource.com/c/chromium/src/+/2709931
(cherry picked from commit f835dd1c2ae0720df6d472ca89b31196027e018662faa304df52562150ca572987a15ff771dfe0abd4eb5efdb3https://chromium-review.googlesource.com/c/chromium/src/+/2478082
* run specs separately on WOA
* Update comment
* escape %
* specify files properly
* revert WOA testing changes
* chore: bump chromium in DEPS to 91.0.4472.33
* chore: update patches
* Trigger CI
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
Co-authored-by: Samuel Attard <sattard@slack-corp.com >
2021-05-03 20:09:30 -04:00
Shelley Vohr
232392ffa0
fix: handle async nature of [NSWindow -toggleFullScreen] ( #25470 ) ( #28763 )
2021-04-22 09:53:46 -04:00
Electron Bot
66a2218723
chore: bump chromium to 91.0.4448.0 (13-x-y) ( #28127 )
...
* chore: bump chromium in DEPS to 90.0.4430.19
* build: add 'use_rts' definition
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2694187
(cherry picked from commit b820b4078d55e50a0879https://chromium-review.googlesource.com/c/chromium/src/+/2699022
(cherry picked from commit e715b9c921c8148febfahttps://chromium-review.googlesource.com/c/chromium/src/+/2710351
(cherry picked from commit 87df2766bahttps://chromium-review.googlesource.com/c/chromium/src/+/2667839
(cherry picked from commit e900271beahttps://chromium-review.googlesource.com/c/chromium/src/+/2689805
(cherry picked from commit eccfa516c5https://chromium-review.googlesource.com/c/chromium/src/+/2657617
(cherry picked from commit 2fed02556dhttps://chromium-review.googlesource.com/c/chromium/src/+/2680274
(cherry picked from commit 0d94e0d1d9https://chromium-review.googlesource.com/c/chromium/src/+/2071443
(cherry picked from commit 1a296e59c2https://chromium-review.googlesource.com/c/chromium/src/+/2710351
(cherry picked from commit dc36e8e6fchttps://chromium-review.googlesource.com/c/chromium/src/+/2685601
(cherry picked from commit 59669e99cbhttps://chromium-review.googlesource.com/c/chromium/src/+/2071443
(cherry picked from commit be627568b2https://chromium-review.googlesource.com/c/chromium/src/+/2698090
(cherry picked from commit 77ad17b383https://chromium-review.googlesource.com/c/chromium/src/+/2700637
(cherry picked from commit 4e02d9407ahttps://chromium-review.googlesource.com/c/chromium/src/+/2638372
(cherry picked from commit f51f42764659432fe30a54cc68dd7ae99e6a5a8a1e166065248f4e362d8f8008deb41cfae4d87a5ahttps://chromium-review.googlesource.com/c/chromium/src/+/2752406
(cherry picked from commit d4bec23bdehttps://chromium-review.googlesource.com/c/chromium/src/+/2752406
(cherry picked from commit 9e336f5d0chttps://chromium-review.googlesource.com/c/chromium/src/+/2752932
(cherry picked from commit 08036802cbhttps://chromium-review.googlesource.com/c/chromium/src/+/2651385
(cherry picked from commit 676f74f3dchttps://chromium-review.googlesource.com/c/chromium/src/+/2734095
(cherry picked from commit 76538d2d38003dd6c16c9f5e3f6685https://chromium-review.googlesource.com/c/chromium/src/+/2743594
(cherry picked from commit b15b820bcahttps://chromium-review.googlesource.com/c/chromium/src/+/2725403
(cherry picked from commit 185c343b22https://chromium-review.googlesource.com/c/chromium/src/+/2651385
(cherry picked from commit 88bbe2a352https://chromium-review.googlesource.com/c/chromium/src/+/2721718
(cherry picked from commit 3010dd93e3https://chromium-review.googlesource.com/c/chromium/src/+/2733070
(cherry picked from commit d54bee03d05fc298ee5fhttps://chromium-review.googlesource.com/c/chromium/src/+/2648046
(cherry picked from commit 2cd53eb46ahttps://chromium-review.googlesource.com/c/chromium/src/+/2752406
(cherry picked from commit f1bb6be4b93160e608e286d23cee40https://chromium-review.googlesource.com/c/chromium/src/+/2757472
(cherry picked from commit 22d8f22cfbhttps://chromium-review.googlesource.com/c/chromium/src/+/2757472
(cherry picked from commit ec893f8322https://chromium-review.googlesource.com/c/v8/v8/+/2720306
(cherry picked from commit d0989802bd29dfabadfd97b6868e9cb6d2ae04557e961d8a37c49bc282d5https://chromium-review.googlesource.com/c/chromium/src/+/2693008
(cherry picked from commit 3b183854ffhttps://chromium-review.googlesource.com/c/chromium/src/+/2757472
(cherry picked from commit 2d3c65becadeeb2de14b451e0931bf205f57218174318705c2ea62ecd1885b598037bb61cf1abd4d83d93bcbdc4f97b9303c7f7b1f6c8aaaf03765ed640a145112dd975328a0606fd87d1e01ca00ec82https://chromium-review.googlesource.com/c/chromium/src/+/2707696
(cherry picked from commit 3122820e581f575ca3af54e72fa8e30f3620099a9127cff58b1594c549339127cff58b9684d851010cc08813a6samuel.r.attard@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: John Kleinschmidt <jkleinsc@github.com >
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2021-04-13 11:29:10 -04:00
trop[bot]
5ab8cb7482
fix: load source maps from custom protocols and asar bundles ( #28615 )
...
* fix: load source maps from custom protocols and asar bundles
* chore: fix lint
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2021-04-12 06:18:34 -07:00
trop[bot]
6f44fa6dbd
fix: dialog DCHECK on Linux ( #28534 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2021-04-07 09:49:17 +09:00
trop[bot]
114643a624
fix: reject task append to JumpList when description exceeds 260 characters ( #28526 )
...
* fix: reject task when description exceeds 260 characters
* Switched out wcslen() for size() [linear -> constant time]
* Included comment describing the need for the additional check
* Added information about character limit to documentation
* Added newline character to end of jump-list-category.md
Co-authored-by: SushiJackal <weingaben@gmail.com >
2021-04-05 23:57:18 -07:00
trop[bot]
50cc80c44e
fix: disappearing thumbar after win.hide() ( #28390 )
...
* fix: disappearing thumbar after win.hide()
* Add descriptive comment
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2021-03-25 12:16:13 -07:00
John Kleinschmidt
2ce64944ab
chore: bump chromium to 90.0.4415.0 (master) ( #27694 ) ( #28082 )
...
* chore: bump chromium in DEPS to 520c02b46668fc608927e0fcd79b6a90885a48bf
* chore: bump chromium in DEPS to 90.0.4414.0
* resolve chromium conflicts
* resolve v8 conflicts
* fix node gn files
* 2673502: Remove RenderViewCreated use from ExtensionHost.
https://chromium-review.googlesource.com/c/chromium/src/+/2673502
* 2676903: [mojo] Remove most legacy Binding classes.
https://chromium-review.googlesource.com/c/chromium/src/+/2676903
* 2644847: Move self-deleting URLLoaderFactory base into //services/network.
https://chromium-review.googlesource.com/c/chromium/src/+/2644847
* 2664006: Remove from mojo::DataPipe.
https://chromium-review.googlesource.com/c/chromium/src/+/2664006
* 2674530: Remove CertVerifierService feature
https://chromium-review.googlesource.com/c/chromium/src/+/2674530
* 2668748: Move OnSSLCertificateError to a new interface.
https://chromium-review.googlesource.com/c/chromium/src/+/2668748
* 2672923: Remove RAPPOR reporting infrastructure.
https://chromium-review.googlesource.com/c/chromium/src/+/2672923
* 2673502: Remove RenderViewCreated use from ExtensionHost.
https://chromium-review.googlesource.com/c/chromium/src/+/2673502
* 2655126: Convert FrameHostMsg_ContextMenu and FrameMsg_ContextMenuClosed|CustomContextMenuAction to Mojo
https://chromium-review.googlesource.com/c/chromium/src/+/2655126
* 2628705: Window Placement: Implement screen.isExtended and change event
https://chromium-review.googlesource.com/c/chromium/src/+/2628705
* 2643161: Refactor storage::kFileSystem*Native*
https://chromium-review.googlesource.com/c/chromium/src/+/2643161
* fix build
* only remove the biggest subdir of //ios
* chore: bump chromium in DEPS to 90.0.4415.0
* update patches
* update sysroots
* 2686147: Remove WebContentsObserver::RenderViewCreated().
https://chromium-review.googlesource.com/c/chromium/src/+/2686147
* 2596429: Fixing how extension's split and spanning modes affect OriginAccessList.
https://chromium-review.googlesource.com/c/chromium/src/+/2596429
* 2686026: [mojo] Delete AssociatedInterfacePtr (replaced by AssociatedRemote)
https://chromium-review.googlesource.com/c/chromium/src/+/2686026
* 2651705: Move ui/base/dragdrop/file_info to ui/base/clipboard
https://chromium-review.googlesource.com/c/chromium/src/+/2651705
* 358217: drawBitmap is deprecated
https://skia-review.googlesource.com/c/skia/+/358217
* fix gn check
* 2678098: Use gen/front_end as input to generate_devtools_grd
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2678098
* 2674530: Remove CertVerifierService feature
https://chromium-review.googlesource.com/c/chromium/src/+/2674530
* fixup 2664006: Remove from mojo::DataPipe.
https://chromium-review.googlesource.com/c/chromium/src/+/2664006
* fixup build_add_electron_tracing_category.patch
* 2673415: [base] Prepare CrashReporterClient for string16 switch
https://chromium-review.googlesource.com/c/chromium/src/+/2673415
* 2673413: Add CursorFactoryWin to handle Cursors on Windows
https://chromium-review.googlesource.com/c/chromium/src/+/2673413
* 2668748: Move OnSSLCertificateError to a new interface.
https://chromium-review.googlesource.com/c/chromium/src/+/2668748
* fix mas gn check
* update patch after merge
* Update node for .mjs files
* build: load v8_prof_processor dependencies as ESM
* chore: add patch to fix linux 32bit
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
(cherry picked from commit ca75bca667electron@github.com >
2021-03-10 10:24:58 -08:00
Erick Zhao
2d0ad0b96a
fix: make TouchBarPopover and TouchBarGroup work ( #27901 )
...
* fix: use correct `orderedItem` touchbar property
* fix: correct parent in touchbar group and popover
* fix: preserve property hook order
2021-03-01 13:34:00 -08:00
Charles Kerr
72127b2916
refactor: precache atoms in window-state-watcher ( #27575 )
2021-02-02 09:50:32 -08:00
Cheng Zhao
8bf66f8974
fix: clean up implementations of titleBarStyle ( #27489 )
...
* Rewrite titleBarStyle impls with WindowButtonsView
* Remove fullscreenWindowTitle option
* Make buttons show correctly under RTL
* Fix docs about traffic lights position
* Fix test on fullscreen resizable
* Fix button states with closabe/minimizable/fullscreenable
* Fix typo
* Deprecate the fullscreenWindowTitle option
2021-01-30 17:15:10 -06:00
Cheng Zhao
6edf6c6a95
fix: pass button callback in constructor ( #27545 )
2021-01-29 12:43:51 -08:00
Milan Burda
ddf3ef0a5f
refactor: use C++11 class member variable initialization ( #27477 )
2021-01-26 12:16:21 -06:00
Milan Burda
949fd0728f
refactor: replace base::Bind() with base::BindOnce() / base::BindRepeating() ( #27447 )
2021-01-25 10:27:40 +09:00
John Kleinschmidt
c5a41defbd
fix: enable navigator.setAppBadge/clearAppBadge ( #27067 )
2021-01-21 14:45:06 +09:00
Electron Bot
adf0a73543
chore: bump chromium to a264339194bfa02f5ecb3b8cba449 (master) ( #27111 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2021-01-12 15:31:23 -08:00
Cheng Zhao
5f99569b6c
feat: make win.setAspectRatio() work on Windows ( #26941 )
...
* feat: make win.setAspectRatio() work on Windows
* update patches
Co-authored-by: Electron Bot <electron@github.com >
2021-01-05 17:17:33 +09:00
Shelley Vohr
6307b52dc5
fix: default offset when no drag regions ( #27147 )
2021-01-04 14:01:32 -08:00
Electron Bot
8383c14aba
chore: bump chromium to 7264889ce3aad1568ff3d211c81fe (master) ( #27003 )
...
* chore: bump chromium in DEPS to 91c9f44297abe2844f593ec7956e6ce79c81f463
* chore: update chromium patches
* chore: update v8 patches
* build: service_names.mojom has been deleted
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2568681
* chore: add DISPLAY_CAPTURE permission to converter
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2551098
* chore: handle AXPropertyFilter::SCRIPT in accessibility_ui
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2563923
* refactor: web_isolated_world_ids.h has been deleted
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2585255
* refactor: ResourceType has been deprecated / removed in ExtensionsBrowserClient
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2562002
* chore: fix lint
* chore: remove deleted headers
* build: disable gn check for blink header
* fix: refactor X11 event handling
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2577887
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2585750
* chore: update patches
* chore: bump chromium in DEPS to bfd8e7dbd37af8b1bc40d887815edd5a29496fa3
* chore: update patches
* refactor: xeventobserver is now x11:eventobserver
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2585750
* refactor: remove UseWebUIBindingsForURL
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2583590
* chore: DidProcessXEvent has been removed
* chore: bump chromium in DEPS to b13e791d7244a08d9d61dbfa2bb2b6cdf1ff6294
* chore: update patches
* build: change gfx::GetAtom to x11:GetAtom
Refs: d972a0ae4ad972a0ae4ac38f8571a8https://chromium-review.googlesource.com/c/chromium/src/+/2572896
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
2020-12-22 14:14:44 -08:00
Electron Bot
4588a41161
chore: bump chromium to 096e5313aaf19dfa0c4710145c34d (master) ( #26535 )
...
* chore: bump chromium in DEPS to 1d6b29cd85c1c3cba093b8b69b2727cc26eaac97
* update patches
* chore: use 'libvulkan.so.1' in the linux manifests
CL: https://chromium-review.googlesource.com/c/angle/angle/+/2538430
Upstream renamed libvulkan.so to libvulkan.so.1, so sync our manifests.
* chore: update expected window-open default policy.
CL: https://chromium-review.googlesource.com/c/chromium/src/+/2429247
Upstream CL contiues the work to make `strict-origin-when-cross-origin`
the default referrer policy. This commit changes our window-open tests
to expect that policy over the previous `no-referrer-when-downgrade`.
* chore: bump chromium in DEPS to 69cb7c65ad845cdab1cd5f4256237e72fceba2dd
* chore: re-export chromium patches
No code changes; just line numbers. `git am` failed because the upstream
changes were just large enough to require patching to fail w/o fuzzing.
The broken patch was
patches/chromium/feat_allow_disabling_blink_scheduler_throttling_per_renderview.patch
* update patches
* chore: bump chromium in DEPS to c6d97a240d30e5f5166856f5ae6ee14d95b9a4f0
* update patches
* fixup! chore: update expected window-open default policy.
* chore: disallow copying CppHeapCreateParams
Experimental commit to resolve FTBS https://ci.appveyor.com/project/electron-bot/electron-ljo26/builds/36405680#L25345
which introduces a new struct CppHeapCreateParams that aggregates a
vector of unique_ptrs. Our Windows CI is unhappy that this struct
implicitly deletes its copy ctor, so this commit makes it explicit.
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/2536642
* update patches
* chore: bump chromium in DEPS to 0df9a85ffa0ad4711b41a089842e40b87ba88055
* update patches
* fixup! chore: bump chromium to ac06d6903a2c981ab90a8162f1ba0 (master) (#26499 )
* chore: update calls to gfx::RemoveAcceleratorChar.
The call signature for gfx::RemoveAccelerator changed in
https://chromium-review.googlesource.com/c/chromium/src/+/2546471 .
This commit updates use to match that.
* chore: bump chromium in DEPS to 43d6c496251e08d3781bfadbe9727688551f74a9
* update patches
* chore: bump chromium in DEPS to 1fb5c9825be4e2271c4fef0e802f5d970b32f62f
* update patches
* chore: bump chromium in DEPS to 8a1f078d67825e727a598b89a8924699df8d3850
* chore: bump chromium in DEPS to 28ff715b3a97d8cedc143bad671edb08b6de5fc2
* chore: update patches
* Remove most service manifest remnants from Content
https://chromium-review.googlesource.com/c/chromium/src/+/2296482
* Reland "Portals: Fix a11y for orphaned portals"
https://chromium-review.googlesource.com/c/chromium/src/+/2542812
* Convert CallbackList::Subscription to a standalone class.
https://chromium-review.googlesource.com/c/chromium/src/+/2522860
* fix: actually apply the zlib patch
* chore: bump chromium in DEPS to 75b464e6357190ca302ba9ce8f8c2bf5a3b709ae
* chore: update patches
* chore: bump chromium@b884b9b2f647c59a75f5d2055030afa33d50ca10
* chore: bump chromium in DEPS to 829261dadcefdc54ce5fdf7c5fac2929786a63ce
* chore: bump chromium in DEPS to 5df3e69605c7c0130374aaccb91fc4726a558db2
* chore: bump chromium in DEPS to 22db748d5b7b90f87e6e97ef4c92a727ac753ea4
* chore: bump chromium in DEPS to 1475df80282b7eeeb0e153d8375bfe651f083bf8
* chore: bump chromium in DEPS to 6d34fe9e9b7386edd90574617bfa4008de972d72
* chore: update patches
* Disable CertVerifierService for now
2559260: Enable CertVerifierService by default | https://chromium-review.googlesource.com/c/chromium/src/+/2559260
* Remove force_ignore_site_for_cookies until we figure out what to do instead
2499162: Remove |force_ignore_site_for_cookies| from IPCs (e.g. ResourceRequest). | https://chromium-review.googlesource.com/c/chromium/src/+/2499162
* chore: bump chromium in DEPS to 95aeb1c59ebc03d19ba077b0cd707463d1b2865e
* update patches
* Set site_for_cookies to request url so that URLLoader::ShouldForceIgnoreSiteForCookies returns true
* 2490383: a11y inspect reorg: implement accessible tree formatter factory
https://chromium-review.googlesource.com/c/chromium/src/+/2490383
* 2485887: [Extensions][web_accessible_resources] Use |matches|.
https://chromium-review.googlesource.com/c/chromium/src/+/2485887
* update v8 headers
* chore: bump chromium in DEPS to 38587dc379a8cf4d4a13e482a6e89f2fe681144e
* update patches
* 2555005: [api] Simplify ScriptOrigin
https://chromium-review.googlesource.com/c/v8/v8/+/2555005
* 2563553: Remove Flash from PermissionRequestTypes and PermissionTypes.
https://chromium-review.googlesource.com/c/chromium/src/+/2563553
* 2546146: Remove browser-hosted InterfaceProvider
https://chromium-review.googlesource.com/c/chromium/src/+/2546146
* Actually apply nan patch
* update patches
* chore: bump chromium in DEPS to 6718d4b50c9db975c5642ca5b68e8dc7ee1b7615
* update patches
* 2546146: Remove browser-hosted InterfaceProvider
https://chromium-review.googlesource.com/c/chromium/src/+/2546146
* chore: bump chromium in DEPS to 338cc300e3fe3a4cb4883e9ccdc34a32f3dfe034
* chore: bump chromium in DEPS to d9baeb1d192c23ceb1e1c4bbe6af98380b263bc1
* chore: bump chromium in DEPS to 3ca3051932683739b304e721cc394b6c66f841fe
* chore: bump chromium in DEPS to 89292a4ae29096e5313aaf19dfa0c4710145c34d
* 2571639: mac: Remove code to support OS X 10.10 in //sandbox
https://chromium-review.googlesource.com/c/chromium/src/+/2571639
* Fixup patch indices
* Do not build MTLManagedObjectAdapter
It's been removed in newer Mantle versions and uses a deprecated enum
* update patches
* Remove sendToAll
https://github.com/electron/electron/pull/26771
* 2569367: Remove dead fullscreen code in RenderWidgetHostView and friends
https://chromium-review.googlesource.com/c/chromium/src/+/2569367
* Remove deprecated performFileOperation usage
* 2568359: mac: Ignore Wdeprecated-declarations for LSSharedFileList* functions.
https://chromium-review.googlesource.com/c/chromium/src/+/2568359
* 2561401: Add OutputPresenterX11 which uses X11 present extension.
https://chromium-review.googlesource.com/c/chromium/src/+/2561401
* 2565511: [objects] Remove MakeExternal case for uncached internal strings
https://chromium-review.googlesource.com/c/v8/v8/+/2565511
* fixup: Add disconnect logic to ElectronBrowserHandlerImpl
* Allow local networking override for ATS
https://developer.apple.com/library/archive/documentation/General/Reference/InfoPlistKeyReference/Articles/CocoaKeys.html
* Refactor: clean up rfh getters in ElectronBrowserHandlerImpl
* Update patches
* Remove unneeded BindTo
* Don't assign ElectronBrowserHandlerImpl at all
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@github.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2020-12-14 10:57:36 -08:00
Mimi
9908cc363a
fix: message box missing an "OK" button in GTK ( #26857 )
2020-12-10 08:28:56 +09:00
Shelley Vohr
528b0f0e74
fix: draggable views on BrowserViews on Windows ( #26738 )
2020-12-01 15:03:00 -08:00
Erick Zhao
36af8022ca
fix: delay emitting NotifyIcon events on Windows ( #26668 )
...
* wip?
* attempt to use weakptr
* apply posttask change to other balloon events
* chore: add clarifying comment on weakptr
* refactor: move weakptr include to implementation
(it's not needed in the header file)
* refactor: use default initializer for weak factory
* refactor: move weakptr usage outside of loop
* fix: convert mouse events as well
* refactor: use member function for balloon events
* fix: check if wicon is truthy in callback
* refactor: bind mouse events with member function
* refactor: inline lparams
* refactor: inline getkeyboardmodifiers()
* chore: correct GetKeyboardModifiers typo
2020-11-30 16:49:30 +09:00
Shelley Vohr
ac35787bdb
fix: Cannot read property 'setDockSide' of undefined ( #26474 )
2020-11-16 10:26:35 -08:00
Electron Bot
e017d8714e
chore: bump chromium to adc5df74b86afdff676989ced8cd3 (master) ( #26223 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
Co-authored-by: John Kleinschmidt <jkleinsc@github.com >
2020-11-13 16:16:56 -08:00
Samuel Maddock
83d30c5c2a
feat: add 'resized' event to BrowserWindow ( #26216 )
...
Also adds 'moved' event to BrowserWindow on Windows.
2020-11-11 19:27:24 -05:00
Cheng Zhao
02a8c0a640
fix: make draggable regions work when devtools is opened on macOS ( #26361 )
...
* fix: make draggable region work when devtools is open
* fix: update draggable regions when resizing
2020-11-09 16:54:04 -05:00
Jeremy Rose
914aed6495
chore: don't self-include inspectable_web_contents.h ( #26236 )
2020-10-29 10:44:19 -07:00
Charles Kerr
f489e3054a
feat: honor nativeTheme.themeSource = 'dark' before creating BrowserWindow on Windows ( #25373 )
...
* fix: support 'dark' theme before creating windows.
2020-10-28 15:00:21 -05:00
Electron Bot
bf89237f60
chore: bump chromium to 9b2191ea59cba1e2f6da4dbb7dee0 (master) ( #25995 )
2020-10-27 17:33:04 -07:00
Shelley Vohr
7cdc42f43a
fix: draggable regions exclusively on BrowserViews ( #26145 )
2020-10-27 14:28:43 -07:00
Milan Burda
1c99a9b425
refactor: Chromium code style for enum classes ( #26165 )
2020-10-27 10:51:45 -07:00
David Sanders
4be10523e8
chore: use auto to avoid repeating type ( #26113 )
2020-10-26 11:56:31 -07:00
David Sanders
554ad93d45
chore: prefer empty() check for readability ( #26109 )
2020-10-22 13:24:59 -07:00
Cheng Zhao
e3c4bbd21f
fix: release NSAlert properly ( #26078 )
2020-10-22 15:46:58 +09:00
Valentin Hăloiu
c4525b4ea6
fix: add Wayland support ( #26022 )
2020-10-20 11:24:52 -07:00
Cheng Zhao
6b6ffbdd10
feat: add support for share menu on macOS ( #25629 )
2020-10-19 18:33:06 -07:00
Electron Bot
46f3491c7d
chore: bump chromium to 6b9fa6b352d824d052222e1abe541 (master) ( #25558 )
...
* chore: bump chromium in DEPS to d5c9bf9e2a18fa508201a88e5803bec1d107b1ae
* chore: bump chromium in DEPS to 45f1316afae33e52c92480b34bf4f7fe4a7db898
* update patches
* WillCreateURLLoaderFactory now gets a ukm_source_id
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2346803
* ink_drop_visible_opacity -> GetInkDropVisibleOpacity
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2415368
* chore: bump chromium in DEPS to ddb5b6db5e35ab1a7b5adbd9f15373af6c35ea2a
* 2418471: PDF Viewer update: Add missing aria-labels to various buttons.
https://chromium-review.googlesource.com/c/chromium/src/+/2418471
* update printing.patch given print settings mojoification
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2409467
* update patches
* content::BluetoothChooser::Event -> content::BluetoothChooserEvent
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2387901
* set_ink_drop_base_color -> SetInkDropBaseColor
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2419388
* chore: bump chromium in DEPS to ecf7c9ee830d4d85f300b461a2fa13aa40c79a4c
* update patches
* gfx::ConvertPointToPixel -> gfx::ConvertPointToPixels
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2418568
* remove ContentSettingsObserver::AllowStorage()
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2401847
* service_manager::kCrashDumpSignal -> kCrashDumpSignal
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2417073
* chore: bump chromium in DEPS to abdb7ebe5f8c8328b8f435283df90d0a3ecff7bd
* chore: bump chromium in DEPS to 2a7e138ab1066534ceb2622e8a9d2c8ebf574215
* chore: bump chromium in DEPS to ab1884e75ced904e4276851eb4e1ad89919ca93b
* chore: bump chromium in DEPS to a12413902380dcc2a73ac74d582328280a8af686
* Fixup printing patch
https://chromium-review.googlesource.com/c/chromium/src/+/2428623
* Fixup OSR patch
https://chromium-review.googlesource.com/c/chromium/src/+/2415128
* Make ExtensionURLLoaderFactory always owned by its |receivers_|.
https://chromium-review.googlesource.com/c/chromium/src/+/2357523
* Add deprecated_default_sources_assignment_filter variable
https://chromium-review.googlesource.com/c/chromium/src/+/2416496
* Fixup patch indices
* Remove several references to BrowserPlugin from content
https://chromium-review.googlesource.com/c/chromium/src/+/2401031
* Remove SurfaceEmbeddingTime and LocalSurfaceIdAllocation
https://chromium-review.googlesource.com/c/chromium/src/+/2415128
* Add DragOperation and AllowedDragOperations Mojo types
https://chromium-review.googlesource.com/c/chromium/src/+/2196167
* chore: bump chromium in DEPS to 378450342cf6aa160663d0ce3a178a11b570c25a
* Fixup patch indices
* Remove SurfaceEmbeddingTime and LocalSurfaceIdAllocation
https://chromium-review.googlesource.com/c/chromium/src/+/2415128
* Add DragOperation and AllowedDragOperations Mojo types
https://chromium-review.googlesource.com/c/chromium/src/+/2196167
* 2426564: Remove global sources assignment filter value
https://chromium-review.googlesource.com/c/chromium/src/+/2426564
* Fixup blink_local_frame.patch
* [XProto] Remove a subset of ui/gfx/x/x11.h
https://chromium-review.googlesource.com/c/chromium/src/+/2430328
* Fixup patch indices
* Remove several references to BrowserPlugin from content
https://chromium-review.googlesource.com/c/chromium/src/+/2401031
* Remove lossy ConvertSizeToPixel() methods
https://chromium-review.googlesource.com/c/chromium/src/+/2419534
* serial: Use USB driver name to disambiguate ports
https://chromium-review.googlesource.com/c/chromium/src/+/2413176
* Remove set_sources_filter import
* Fix ModMask usage
* [XProto] Remove usage of all Xlib headers
https://chromium-review.googlesource.com/c/chromium/src/+/2392140
* [XProto] Remove usage of Xlib Visuals
https://chromium-review.googlesource.com/c/chromium/src/+/2429933
* Skip Angle manifest file
https://chromium-review.googlesource.com/c/angle/angle/+/2425197
* Add whole src\third_party\angle\.git directory
This directory is needed in order to properly generate gen/angle/angle_commit.h
* [libvpx] Fix HighBD config on Windows ARM64
https://chromium-review.googlesource.com/c/chromium/src/+/2437745
* update patches
* fix: correct calling convention for Windows on Arm
https://chromium-review.googlesource.com/c/v8/v8/+/2440717
* Add third_party/angle/.git to the archive before adding the rest of the source
* fixup source caching on Windows
* Fixup erroneous close paren
* fixup for goma issues
* This should work
* chore: bump chromium roll manually
https://chromium-review.googlesource.com/c/chromium/src/+/2435142
This landed the day after we paused roller-bot and may resolve the
visibility test flakes that we're seeing. h/t to @jkleinsc for
finding this with me.
* chore: remove obsoleted cherry-pick fix for libvpx
https://chromium-review.googlesource.com/c/chromium/src/+/2437745
* chore: remove obsoleted cherry-pick libvpx patch
https://chromium-review.googlesource.com/c/chromium/src/+/2437745
* chore: re-export patches
* chore: add tracer comment to visibility-stat-spec.
The line numbers between the source and the CI runs don't seem to match
up, so this temp tracer is to help track the source of that difference.
* chore: bump chromium in DEPS to 7c2b8cc3b8638aee8abeb013042a6c1d15b2da6b
* update patches
* impl SortingLSH service
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2425327
* 2446525: [Flash] Remove some Flash APIs
https://chromium-review.googlesource.com/c/chromium/src/+/2446525
* 2440974: Reland "Delete service_manager/embedder/switches.h"
https://chromium-review.googlesource.com/c/chromium/src/+/2440974
* 2359402: Remove ContentBrowserClient::NonNetworkURLLoaderFactoryDeprecatedMap.
https://chromium-review.googlesource.com/c/chromium/src/+/2359402
* 2250506: Implement tabs.removeCSS
https://chromium-review.googlesource.com/c/chromium/src/+/2250506
* 2429143: Remove implicit-conversion-to-integer ConvertRectToPixel() methods.
https://chromium-review.googlesource.com/c/chromium/src/+/2429143
* 2444430: Remove DataElementType::kBlob
https://chromium-review.googlesource.com/c/chromium/src/+/2444430
* 2441964: Clean up WebView public API
https://chromium-review.googlesource.com/c/chromium/src/+/2441964
* 2357523: Make ExtensionURLLoaderFactory always owned by its |receivers_|.
https://chromium-review.googlesource.com/c/chromium/src/+/2357523
* 2461606: Use blink::mojom::PreferredColorScheme instead of blink::PreferredColorScheme
https://chromium-review.googlesource.com/c/chromium/src/+/2461606
* 2461235: a11y inspect reorg: move PropertyFilter struct to a new location
https://chromium-review.googlesource.com/c/chromium/src/+/2461235
* remove flash support
* fix frame_host_manager patch
* fix lint
* remove flash info from docs
* fix build
* fix osr
* chore: bump chromium in DEPS to 9269f9eb1d98d29564c2b2ab97f30c6e148c4e11
* fix visibilityState tests
* 2463049: Replace all uses of web_pref::AutoplayPolicy with mojom::AutoplayPolicy
https://chromium-review.googlesource.com/c/chromium/src/+/2463049
* update patches
* fix tests harder
* 2414921: Add Group and Ungroup functions to Tabs extension API
https://chromium-review.googlesource.com/c/chromium/src/+/2414921
* more test fix
* Remove all keyboard related usage of Xlib
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2436787
* fix linux build
* 2453807: [XProto] Remove usage of Xlib error handling
https://chromium-review.googlesource.com/c/chromium/src/+/2453807
* lint
* fixup! 2453807: [XProto] Remove usage of Xlib error handling
* disable CalculateNativeWinOcclusion on win ci
* remove UploadBlob from docs
* Update appveyor.yml
Co-authored-by: Andy Locascio <andy@slack-corp.com >
Co-authored-by: John Kleinschmidt <jkleinsc@github.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
Co-authored-by: Electron Bot <anonymous@electronjs.org >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2020-10-15 18:30:41 -07:00
Cheng Zhao
20c6677a9c
fix: maximized frameless window bleeding to other monitors ( #25940 )
2020-10-15 14:05:44 -07:00
David Sanders
b194030a34
chore: cleanup some typos in comments ( #25770 )
2020-10-13 10:25:21 -07:00
