Commit Graph

23969 Commits

Author SHA1 Message Date
Erick Zhao
fb4cd68f93 docs: update verb tenses for structured clone notes (#27520) 2021-01-27 11:49:16 -08:00
Electron Bot
7d3db3d7f8 Bump v10.3.1 v10.3.1 2021-01-27 11:18:22 -08:00
Pedro Pontes
9510e1f6e4 chore: cherry-pick f9add3b8e5 from chromium. (#27452)
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
2021-01-27 20:09:48 +09:00
Pedro Pontes
a396489101 chore: cherry-pick 4af9de9806 and 115eccc0c6 from chromium. (#27495)
* chore: cherry-pick 4af9de9806 and 115eccc0c6 from chromium.

* update patches

Co-authored-by: Electron Bot <electron@github.com>
2021-01-27 20:09:16 +09:00
Milan Burda
b90f5435a9 fix(asar): readdir(withFileTypes) fails on deep directory (#26865) (#27507)
when using readdirSync on a deep directory within the archive, the code fails to get the stats of child paths.

Co-authored-by: Avi Vahl <avi.vahl@wix.com>
2021-01-27 17:04:34 +09:00
Milan Burda
13a0757acb build: fix build with enable_printing=false (#27456) (#27505) 2021-01-27 16:35:38 +09:00
Pedro Pontes
a5a6f12e1d chore: cherry-pick 9ec949913373 from chromium (#27402)
* chore: cherry-pick 9ec949913373 from chromium

* update patches

Co-authored-by: Electron Bot <electron@github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2021-01-26 14:30:30 -08:00
Pedro Pontes
cef56e162f chore: cherry-pick 2c26785, b03de8b and a3c3ef6 from usrsctp. (#27492)
* chore: cherry-pick 2c26785, b03de8b and a3c3ef6 from usrsctp.

* update patches

Co-authored-by: Electron Bot <electron@github.com>
2021-01-26 14:13:44 -08:00
Pedro Pontes
a73163d09a chore: cherry-pick d74ba931c4b7 from chromium (#27407)
* chore: cherry-pick d74ba931c4b7 from chromium

* update patches

Co-authored-by: Electron Bot <electron@github.com>
2021-01-26 09:19:52 -08:00
trop[bot]
2e98e11364 fix: <webview> not working with Trusted Types (#27465)
Co-authored-by: Milan Burda <milan.burda@gmail.com>
2021-01-25 11:47:33 -08:00
tosmolka
0ead47ffea chore: cherry-pick 3ca3d70c7af5 from chromium (#27395)
* chore: cherry-pick 3ca3d70c7af5 from chromium

* update patches

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2021-01-25 11:29:54 -08:00
tosmolka
1897909a50 chore: cherry-pick 4794770cf175 from chromium (#27394)
* chore: cherry-pick 4794770cf175 from chromium

* update patches
2021-01-25 08:39:19 -08:00
trop[bot]
62b2243574 fix: CSP with unsafe-eval detection with Trusted Types (#27468)
Co-authored-by: Milan Burda <milan.burda@gmail.com>
2021-01-25 08:33:25 -08:00
tosmolka
6e35f2b7dd chore: cherry-pick 861253f1de98 from chromium (#27361)
* chore: cherry-pick 861253f1de98 from chromium

* update patches

Co-authored-by: Electron Bot <electron@github.com>
2021-01-25 13:34:22 +09:00
tosmolka
c4bf95576c chore: cherry-pick da9b5ec032ad from chromium (#27399)
* chore: cherry-pick da9b5ec032ad from chromium

* update patches

Co-authored-by: Electron Bot <electron@github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2021-01-22 11:35:28 -08:00
tosmolka
4005935937 chore: cherry-pick 79440c3a0675 from chromium (#27360)
* chore: cherry-pick 79440c3a0675 from chromium

* Resolve merge conflicts
2021-01-22 11:33:58 -08:00
Pedro Pontes
31fa081da1 chore: cherry-pick ffd6ff5a61b9 from v8 (#27412)
* chore: cherry-pick ffd6ff5a61b9 from v8

* update patches

Co-authored-by: Electron Bot <electron@github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2021-01-21 12:59:06 -08:00
trop[bot]
340b4a2c1e fix: actually clear pending requests in devtoolsagenthost (#27438)
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2021-01-21 12:51:03 -08:00
Pedro Pontes
fd269ec973 chore: cherry-pick 44d052c and 0919d75 from v8. (#27420) 2021-01-21 09:42:55 -08:00
tosmolka
d133ec709f chore: cherry-pick d866af575997 from chromium (#27393)
* chore: cherry-pick d866af575997 from chromium

* update patches
2021-01-21 09:33:52 -08:00
Milan Burda
2b76ac0848 fix: apply tzdata2020f to ICU (#27368)
Co-authored-by: Milan Burda <miburda@microsoft.com>
2021-01-21 15:43:21 +09:00
trop[bot]
726e3f9bb8 fix: Shutdown crash in DownloadItem callback (#27417)
The call stack for one of our top crashes looks like this:

```
node::Abort (node_errors.cc:241)
node::Assert (node_errors.cc:256)
node::MakeCallback (callback.cc:226)
gin_helper::internal::CallMethodWithArgs (event_emitter_caller.cc:23)
gin_helper::EmitEvent<T> (event_emitter_caller.h:51)
gin_helper::EventEmitterMixin<T>::Emit<T> (event_emitter_mixin.h:81)
electron::api::DownloadItem::OnDownloadUpdated (electron_api_download_item.cc:115)
download::DownloadItemImpl::UpdateObservers (download_item_impl.cc:482)
content::DownloadManagerImpl::Shutdown (download_manager_impl.cc:508)
content::BrowserContext::~BrowserContext (browser_context.cc:476)
```

Full stack here: https://sentry.io/share/issue/9b030a0601b547188181b543c16ecda2/

During browser shutdown, the `DownloadManager` was being cleaned up
*after* the Node environment had already been destroyed. This caused the
`DownloadItem::OnDownloadUpdated` callback to crash when trying to emit
the JS `done` event.

To prevent this, we now manually shut down the `DownloadManager`
earlier. This is also mentioned in the comment on
`DownloadManager::Shutdown`:

```
// Shutdown the download manager. Content calls this when BrowserContext is
// being destructed. If the embedder needs this to be called earlier, it can
// call it. In that case, the delegate's Shutdown() method will only be called
// once.
```

Co-authored-by: Biru Mohanathas <birunthan@mohanathas.com>
2021-01-21 15:29:50 +09:00
tosmolka
bc336e16ef chore: cherry-pick 63166010061d from v8 (#27397)
* chore: cherry-pick 63166010061d from v8

* update patches

Co-authored-by: Electron Bot <electron@github.com>
2021-01-20 11:34:02 -08:00
tosmolka
1faf18f2d4 chore: cherry-pick 19aeffd4d93f from chromium (#27396)
* chore: cherry-pick 19aeffd4d93f from chromium

* update patches

Co-authored-by: Electron Bot <electron@github.com>
2021-01-20 10:58:10 -08:00
Robo
4a1e299053 fix: increase stack size on windows (#27386) 2021-01-20 13:29:31 -05:00
trop[bot]
ae1f1f2dfa fix: prevent crash when keyboard event immediately precedes calling BrowserWindow.close() (#27358)
* fix: prevent crash when destroyed widget receives keyboard event

Activating a key to close a window will cause a silent crash. Handling the keyboard
event will lead to a nullptr dereferenced in Chromium code if the window widget has
already been destroyed.

* test: ensure BrowserWindow doesn't crash from keyboard events during close

Co-authored-by: samuelmaddock <samuel.maddock@gmail.com>
2021-01-19 15:50:43 +09:00
Shelley Vohr
fe4bc1d568 refactor: use platform-specific TaskRunner to print (#27328) 2021-01-19 15:24:09 +09:00
Electron Bot
d6d9d954b4 Bump v10.3.0 v10.3.0 2021-01-14 08:50:03 -08:00
Erick Zhao
2ee375c5bf docs: update devtools extension tutorial (#26326) (#27312)
* docs: update devtools extension tutorial

* Update docs/tutorial/devtools-extension.md

Co-authored-by: Jeremy Rose <nornagon@nornagon.net>

* update

Co-authored-by: Jeremy Rose <nornagon@nornagon.net>

Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
2021-01-14 14:55:12 +09:00
trop[bot]
c04ec2d332 build: fix installing of code-signing identity on macOS (#27293)
Co-authored-by: Milan Burda <milan.burda@gmail.com>
2021-01-13 13:46:13 -08:00
Keeley Hammond
4f9122647a ci: fix broken homebrew cache (#27308)
Backport of #27224
2021-01-13 11:11:30 -08:00
trop[bot]
846504af8e test: disable flaky reporting API test (#27272)
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
2021-01-12 10:12:17 +09:00
Shelley Vohr
5d97320ba3 Revert "Bump v10.2.1"
This reverts commit 2aaa5438cd.
2021-01-11 14:27:47 -08:00
Electron Bot
2aaa5438cd Bump v10.2.1 2021-01-11 09:33:58 -08:00
Shelley Vohr
08da5ee22a fix: handle BrowserView reparenting (#27220) 2021-01-11 10:49:56 +09:00
trop[bot]
f3a4b44662 test: skip PictureInPicture video when media not supported (#27234)
Co-authored-by: Milan Burda <milan.burda@gmail.com>
2021-01-07 21:39:04 -08:00
trop[bot]
424177164e test: skip media-started-playing media-paused events test when media not supported (#27238)
Co-authored-by: Milan Burda <milan.burda@gmail.com>
2021-01-07 18:46:19 -08:00
Shelley Vohr
079251f168 fix: draggable views on BrowserViews on Windows (#27222) 2021-01-07 13:11:07 -08:00
trop[bot]
17054405d8 docs: document frameId meaning (#27190)
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
2021-01-05 17:19:40 +09:00
trop[bot]
d1d8c9badd fix: default offset when no drag regions (#27185)
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2021-01-05 12:14:15 +09:00
Eryk Rakowski
700c410ec3 fix(extensions): implement missing web_request hooks (#27097)
* fix(extensions): implement missing web_request hooks (#22655)

Co-authored-by: Jeremy Apthorp <nornagon@nornagon.net>
Co-authored-by: samuelmaddock <samuel.maddock@gmail.com>

* fix: remove ukm_source_id

Co-authored-by: Jeremy Apthorp <nornagon@nornagon.net>
Co-authored-by: samuelmaddock <samuel.maddock@gmail.com>
2021-01-05 11:40:36 +09:00
Eryk Rakowski
d3f7ad2035 feat: add support for webContents option in BrowserView (#27094)
* feat: add support for webContents option in BrowserView (#26802)

* feat: add support for webContents option in BrowserView

* tests: add tests

* fix: missing webContents import

* fix: WebContents::New -> Create
2021-01-05 11:22:56 +09:00
Erick Zhao
f5deaedfaa docs: update OSR max FPS number (#27060) 2020-12-17 20:30:53 +09:00
trop[bot]
2717a48f30 fix: memory leak in desktopCapturer.getSources (#27057)
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
2020-12-16 20:47:47 -08:00
Jeremy Rose
fea41c6f6d fix: throw when using globalShortcut before ready (#27023)
* fix: throw when using globalShortcut before ready (#27002)

* add missing include
2020-12-17 10:07:44 +09:00
Michaela Laurencin
d58bfdcdfd chore: cherry-pick 2d18de63acf1 from chromium (#26953)
* chore: cherry-pick 2d18de63acf1 from chromium

* resolve conflict

* modified patches from CRLF to LF

* Update cherry-pick-2d18de63acf1.patch

Remove test from patch
2020-12-15 16:36:13 -05:00
trop[bot]
d0451832ed fix: add SafeForTerminationScopes for SIGINT interruptions (#26970)
* fix: add SafeForTerminationScopes for SIGINT interruptions

* update patches

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2020-12-14 11:02:48 -08:00
trop[bot]
22481aa347 ci: ignore failures on Ninja summary (#26993)
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2020-12-14 13:43:52 -05:00
Jeremy Rose
7b0bb0b637 fix: cherry-pick b84b4f3323b from chromium (#26963) 2020-12-14 13:01:43 -05:00
Michaela Laurencin
36f8e9daa2 chore: cherry-pick 6763a713f957 from skia (#26956) 2020-12-11 15:05:16 -08:00