trop[bot]
fc5a7dd023
fix: crash on nativeTheme change during context menu close ( #38839 )
...
* fix: crash on nativeTheme change during context menu close
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: fixup patches for backport
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-06-20 14:38:26 +02:00
Shelley Vohr
1cb343e079
fix: webContents.print() cancellation callback ( #38814 )
...
* fix: webContents.print() cancellation callback
* chore: update patches
---------
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-06-17 10:12:18 +02:00
trop[bot]
11c6f1f684
refactor: remove unused InspectableWebContentsView::GetWebView() ( #38821 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2023-06-16 12:43:10 -05:00
trop[bot]
c5e5b13003
test: disable flaky asar worker test on ASan build ( #38805 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org >
2023-06-15 09:43:43 -04:00
Charles Kerr
f44be42478
refactor: constexpr lookup tables ( #38800 )
...
* refactor: use a constexpr lookup table in GetPathConstant()
* refactor: use a constexpr lookup table in SystemPreferences::GetColor()
* refactor: use a constexpr lookup table in SimpleURLLoaderWrapper::Create()
2023-06-15 07:27:53 -05:00
trop[bot]
70fe0d9a07
feat: support node: prefixed requires in sandboxed renderer preloads ( #38729 )
...
feat: support node: prefixed requires in sandboxed renderer preloads
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Milan Burda <milan.burda@gmail.com >
2023-06-15 11:59:54 +02:00
electron-roller[bot]
cea70deb8a
chore: bump chromium to 114.0.5735.134 (25-x-y) ( #38782 )
...
chore: bump chromium in DEPS to 114.0.5735.134
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2023-06-14 15:12:06 -04:00
trop[bot]
31b0daaa91
fix: preferCSSPageSize error type ( #38791 )
...
fix: preferCSSPageSize error type
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-06-14 11:05:52 -07:00
trop[bot]
4249800e9c
refactor: use compile-time cli arg sets. ( #38768 )
...
* refactor: use compile-time cli arg sets.
We're currently building these on the heap with `std::set<std::string>`
but this can be a very small compile-time container instead.
Marking as 'refactor' rather than 'perf' since this isn't called often,
but moving from heap to compile-time is good and using this container
makes the code more readable.
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: restore missing comments
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2023-06-14 15:17:49 +09:00
trop[bot]
2ba9860a5a
docs: clarify supported accelerator punctuation ( #38755 )
...
doc: clarify supported accelerator punctuation
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-06-13 14:42:34 -04:00
trop[bot]
7c65388483
perf: prefer base::StringPiece over std::string for build-time strings ( #38737 )
...
* perf: use base::StringPiece in InclusionStatusToString()
The strings are all build-time constants and this is a private function
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* perf: use base::StringPiece in ErrorCodeToString()
The strings are all build-time constants and this is a private function
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* perf: use base::StringPiece in MessageSourceToString()
The strings are all build-time constants and this is a private function
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* perf: use base::StringPiece in CursorTypeToString()
The strings are all build-time constants and this is a private function
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* perf: use base::StringPiece in MediaStreamTypeToString()
The strings are all build-time constants and this is a private function
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* perf: use base::StringPiece in ModifiersToArray()
The strings are all build-time constants and this is a private function
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* perf: use base::StringPiece in WebFrameRenderer::MaybeGetRenderFrame()
The strings are all build-time constants and this is a private function
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2023-06-12 15:00:03 -05:00
trop[bot]
96ae5c107e
fix: menu bar visibility when exiting full screen ( #38682 )
...
* fix:visibility of menu bar when exiting full screen
Co-authored-by: wugaosheng <wugaosheng@kylinos.cn >
* format code
Co-authored-by: wugaosheng <wugaosheng@kylinos.cn >
* format code
Co-authored-by: wugaosheng <wugaosheng@kylinos.cn >
* Modify comments
Co-authored-by: wugaosheng <wugaosheng@kylinos.cn >
* add menu bar visibility test
Co-authored-by: wugaosheng <wugaosheng@kylinos.cn >
* format code
Co-authored-by: wugaosheng <wugaosheng@kylinos.cn >
* change code
Co-authored-by: wugaosheng <wugaosheng@kylinos.cn >
* platform related in test
Co-authored-by: wugaosheng <wugaosheng@kylinos.cn >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: wugaosheng <wugaosheng@kylinos.cn >
2023-06-12 11:15:02 +02:00
trop[bot]
6dc122fe5a
fix: webContents.print parameter validation error ( #38720 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-06-11 09:56:23 +02:00
trop[bot]
160d48f0f2
build: move uploadIndexJson to just before publishRelease ( #38699 )
...
* build: move uploadIndexJson to just before publishRelease
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* chore: move uploadNodeShasums as well
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* build: upload node checksums before validating them
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
2023-06-09 12:22:32 -07:00
trop[bot]
605d6c9f41
refactor: add SessionPreferences::CreateForBrowserContext() ( #38714 )
...
Copy the NativeWindowRelay::CreateForWebContents() idiom
to simplify SessionPreferences's constructor and lifecycle.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2023-06-09 12:21:52 -07:00
trop[bot]
b606a98b77
fix: WCO transparent background ( #38715 )
...
* fix: WCO transparency
Co-authored-by: samuelmaddock <samuel.maddock@gmail.com >
* doc: wco color transparency
Co-authored-by: samuelmaddock <samuel.maddock@gmail.com >
* fix: transparent buttons when calling setTitleBarOverlay
Co-authored-by: samuelmaddock <samuel.maddock@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: samuelmaddock <samuel.maddock@gmail.com >
2023-06-09 12:19:47 -07:00
Erick Zhao
4779d565d2
docs: use local img for contents.adjustSelection api ( #38696 )
...
docs: use local img for contents.adjustSelection api (#38655 )
* docs: use local img for contents.adjustSelection api
* fixup
2023-06-08 13:42:38 -07:00
trop[bot]
a7bb6de466
build: use upstream's presubmit cpplint filters. ( #38688 )
2023-06-08 14:15:53 -05:00
trop[bot]
8f9f1cc2fe
fix: reparenting UAF crash on macOS ( #38678 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-06-08 13:29:42 -04:00
trop[bot]
90040360c3
fix: dangling pointer warning when updating menus ( #38691 )
...
fix: dangling raw_ptr warning when updating menus
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2023-06-08 13:28:11 -04:00
trop[bot]
b452c7fab4
chore: clean up ElectronPermissionManager ( #38670 )
...
chore: clean up ElectronPermissionManager
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-06-08 12:19:04 +02:00
trop[bot]
b1cddb0dc8
fix: bad error passing webContents.print(null) ( #38642 )
...
fix: bad error passing webContents.print(null)
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-06-07 23:52:49 -07:00
trop[bot]
f755b2579f
refactor: remove unused OffScreenRenderWidgetHostView fields ( #38650 )
...
* refactor: remove unused field OffScreenRenderWidgetHostView::last_time_
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: remove unused field OffScreenRenderWidgetHostView::last_scroll_offset_
Unused since 1a9e253charles@charleskerr.com >
* refactor: remove unused field OffScreenRenderWidgetHostView::paint_callback_running_
assigned to, but unread, since 81bf158charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2023-06-07 23:50:55 -07:00
trop[bot]
7bca7f2c0f
build: improve error output in release.js ( #38663 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2023-06-07 23:48:03 -07:00
trop[bot]
ed328d8987
fix: validate response in protocol.handle() ( #38634 )
...
fix: validate response in protocol.handle()
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-06-07 10:44:43 -05:00
trop[bot]
1a7c546c3a
fix: sync api::Screen wrapper method sigs to upstream ( #38632 )
...
refactor: sync api::Screen getter sigs to upstream
ui::Display GetAllDisplays(), GetPrimaryDisplay(), GetDisplayMatching(),
and GetDisplayNearestPoint() methods are all const, so make our wrappers
const too.
ui::Display GetAllDisplays() returns a const reference, so make our
wrapper return a const reference too. This avoids creating a new
std::vector<display::Display> each time it's called.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2023-06-07 12:09:25 +02:00
trop[bot]
748c4bfbcb
docs: removed outdated Appveyor doc ( #38627 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-06-06 23:11:32 -07:00
trop[bot]
9ec8b1d21c
refactor: remove unused switches ( #38529 )
...
* refactor: remove unused declaration of electron::kSHA1Certificate
usage removed in 13a1d79charles@charleskerr.com >
* refactor: remove unused declaration of electron::kSHA1MajorDescription
usage removed in 13a1d79charles@charleskerr.com >
* refactor: remove unused declaration of electron::kSHA1MinorDescription
usage removed in 13a1d79charles@charleskerr.com >
* refactor: remove unused declaration of electron::kCertificateError
usage removed in 13a1d79charles@charleskerr.com >
* refactor: remove unused declaration of electron::kValidCertificate
usage removed in 13a1d79charles@charleskerr.com >
* refactor: remove unused declaration of electron::kValidCertificateDescription
usage removed in 13a1d79charles@charleskerr.com >
* refactor: remove unused declaration of electron::kSecureProtocol, kSecureProtocolDescription
usage removed in 497f5a1charles@charleskerr.com >
* refactor: remove electron::options::kPreloadScripts
removed in bad8d5e0charles@charleskerr.com >
* refactor: remove electron::options::kImageAnimationPolicy
removed in 385d0f5charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2023-06-06 17:27:12 -04:00
trop[bot]
32138c6405
refactor: remove redundant resizing strategy equality check ( #38619 )
...
* refactor: remove redundant resizing strategy equality check
Upstream already checks this.
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: remove devtools_settings.h from iwc header
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: remove unused <vectro> from iwc header
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2023-06-06 17:25:33 -04:00
trop[bot]
bc458c97dc
fix: account for BrowserView bounds in setting autofill popup bounds ( #38609 )
...
fix: account for BrowserView bounds in setting autofill popup bounds
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-06-06 21:50:47 +02:00
electron-roller[bot]
06ac9d989f
chore: bump chromium to 114.0.5735.106 (25-x-y) ( #38613 )
...
* chore: bump chromium in DEPS to 114.0.5735.106
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-06-06 14:15:39 -04:00
trop[bot]
e8ef5f4ae4
refactor: use process_util.h helpers ( #38605 )
...
refactor: use process_util.h helpers
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Milan Burda <milan.burda@gmail.com >
2023-06-06 14:29:39 +02:00
Charles Kerr
6c136d5582
refactor: in NativeWindowViews, aggregate fields directly ( #38595 )
...
Manual backport of #38559
Manual backport needed due to very minor code shear
2023-06-06 17:16:51 +09:00
trop[bot]
7ddb80fbb1
chore: type check JS in docs ( #38585 )
2023-06-05 11:55:37 +02:00
trop[bot]
3a2306d9e4
docs: clarify which electron modules are exposed in sandboxed renderers ( #38580 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Milan Burda <milan.burda@gmail.com >
2023-06-05 11:34:09 +02:00
trop[bot]
38d83cfefc
docs: fix SerialPort typing ( #38581 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2023-06-05 11:33:50 +02:00
Charles Kerr
d61f6309a2
chore: remove unused electron::api::View code ( #38572 )
...
chore: remove unused electron::api::View code (#38561 )
chore: remove unused electron::api::View methods
Remove code that was added in 2c8dc9e#38561 .
2023-06-05 10:15:25 +02:00
trop[bot]
126897bd6b
perf: avoid unnecessary base value clone ( #38563 )
2023-06-02 17:04:01 -05:00
trop[bot]
d3f0970964
build: fix doc-only early exit on Appveyor ( #38551 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-06-01 15:09:27 -04:00
trop[bot]
012774a0eb
feat: add USB protected classes handler ( #38493 )
...
* feat: add USB protected classes handler
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* chore: apply review suggestions
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* chore: update docs
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* chore: apply review suggestions
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* update doc per suggestion
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-06-01 10:15:56 -04:00
trop[bot]
a546545a53
feat: add USB protected classes handler ( #38493 )
...
* feat: add USB protected classes handler
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* chore: apply review suggestions
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* chore: update docs
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* chore: apply review suggestions
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* update doc per suggestion
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-06-01 10:13:07 -04:00
trop[bot]
742bd735e6
chore: make contentTracing.stopRecording() failure clearer ( #38519 )
...
chore: make contentTracing.stopRecording() failure clearer
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-05-31 16:06:59 -04:00
trop[bot]
a54725b6b5
build: combine and elaborate on exposed BoringSSL ciphers ( #38521 )
...
build: combine and elaborate on exposed BoringSSL ciphers
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-05-31 16:06:38 -04:00
electron-roller[bot]
be61126d30
chore: bump chromium to 114.0.5735.91 (25-x-y) ( #38516 )
...
chore: bump chromium in DEPS to 114.0.5735.91
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2023-05-31 15:52:02 -04:00
trop[bot]
7fbc867eaf
docs: add <webview> new-window event removal to breaking-changes.md ( #38523 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-05-31 15:51:42 -04:00
trop[bot]
0c4134fefe
ci: clean up docs only change logic ( #38495 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-05-31 20:58:55 +02:00
trop[bot]
b19a3a65a4
chore: cherry-pick 0e1cc35 from v8 ( #38510 )
...
* fix: v8 patch [mksnapshot] Set proper instruction start for builtins
Co-authored-by: mjhenkes <mjhenkes@gmail.com >
* update index
Co-authored-by: mjhenkes <mjhenkes@gmail.com >
* apply ci generated patch
Co-authored-by: mjhenkes <mjhenkes@gmail.com >
* chore: update patches
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: mjhenkes <mjhenkes@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-05-31 10:28:29 -04:00
trop[bot]
563a0622d9
fix: DCHECK minimizing parent window with non-modal child ( #38509 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-05-31 14:05:31 +02:00
trop[bot]
6a5bd8dc28
chore: process.mainModule -> require.main ( #38477 )
...
chore: process.mainModule -> require.main
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-05-29 09:42:50 -04:00
trop[bot]
b78c30a6d8
build: make ReactiveObjC/Mantle deps format consistent ( #38480 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-05-29 09:41:56 -04:00
