Shelley Vohr
38d126fb5c
fix: order menu items before filtering excess separators ( #25931 )
...
Co-authored-by: Samuel Attard <sattard@slack-corp.com >
2020-10-15 11:13:55 -04:00
trop[bot]
ac917b5573
fix: pass module resolution paths to wrapped function ( #25944 )
...
Co-authored-by: Matt Kane <matt@gatsbyjs.com >
2020-10-15 10:49:18 +09:00
Shelley Vohr
13722f83e3
fix: ensure ready-to-show event is fired ( #25932 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
2020-10-15 10:02:36 +09:00
trop[bot]
56a764d510
fix: suppress worldSafe warning emitted from security checks ( #25827 )
...
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
2020-10-08 20:20:09 -07:00
Milan Burda
7ae4b2b559
fix: session argument of app 'session-created' event ( #25798 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2020-10-08 16:32:26 -05:00
trop[bot]
de0ddd5b56
chore: tsify net-log ( #25670 )
...
* chore: tsify net-log
* comment
* gn
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
2020-09-29 12:56:54 -04:00
trop[bot]
4a0f2bede2
chore: improve renderer crash logging ( #25621 )
...
Co-authored-by: Milan Burda <milan.burda@gmail.com >
2020-09-24 13:23:41 -07:00
trop[bot]
21a46bc0eb
chore: log hint on renderer crash ( #25472 )
...
* chore: log hint on renderer crash
* Address feedback from review
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2020-09-15 14:01:49 -06:00
Samuel Attard
fa3652a14f
fix: only focus a webContents if the window was not initially hidden ( #25323 ) ( #25330 )
...
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
2020-09-08 16:55:46 +09:00
George Xu
d73b67f386
feat: add nativeImage.createThumbnailFromPath API ( #25072 )
...
* cherry-picking
* add documentation
* convert createThumbnailFromPath to async function
* windows impl protoype
* add tests
* clean up
* fix
* fix test
* update docs
* cleaning up code
* fix test
* refactor from app to native_image
* windows build
* lint
* lint
* add smart pointers, fix test
* change tests and update docs
* fix test, remove nolint
* add renderer-main process routing to fix tests
* lint
* thanks sam
* cherry-pick
* lint
* remove getApplicationInfoForProtocol code
* chore: fix filenames conflict
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
2020-08-26 16:18:28 -07:00
trop[bot]
bc4884788c
feat: add worldSafe flag for executeJS results ( #24711 )
...
* feat: add worldSafe flag for executeJS results
* chore: do not log warning for webContents.executeJS
* Apply suggestions from code review
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
* chore: apply PR feedback
* chore: split logic a bit
* chore: allow primitives through the world safe checl
* chore: clean up per PR feedback
* chore: flip boolean logic
* chore: update per PR feedback
* chore: fix typo
* chore: fix spec
* Update web-frame.ts
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
Co-authored-by: Samuel Attard <sattard@slack-corp.com >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2020-08-05 10:24:51 -07:00
Shelley Vohr
39edbd6af4
fix: always callback error with invalid print settings ( #24507 )
2020-07-13 08:55:30 -07:00
Electron Bot
d608a30015
chore: bump chromium to 85.0.4183.19 (10-x-y) ( #24299 )
...
* chore: bump chromium in DEPS to 85.0.4182.1
* chore: bump chromium in DEPS to 85.0.4183.2
* chore: bump chromium in DEPS to 85.0.4183.4
* chore: bump chromium in DEPS to 85.0.4183.5
* update patches
* chore: bump chromium in DEPS to 85.0.4183.6
* chore: bump chromium in DEPS to 85.0.4183.7
* update patches
* chore: bump chromium in DEPS to 85.0.4183.8
* remove chromeos-only TtsControllerDelegate
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2255314
(cherry picked from commit f975f84a3chttps://chromium-review.googlesource.com/c/chromium/src/+/2250224
(cherry picked from commit 014b487258https://chromium-review.googlesource.com/c/chromium/src/+/2264867
(cherry picked from commit 2c3b94f497https://chromium-review.googlesource.com/c/chromium/src/+/2240873
(cherry picked from commit 3cdaae146dhttps://chromium-review.googlesource.com/c/chromium/src/+/2252466
(cherry picked from commit e0d6dbcf1ehttps://chromium-review.googlesource.com/c/chromium/src/+/2264297
(cherry picked from commit 1407040133https://chromium-review.googlesource.com/c/chromium/src/+/2255527
(cherry picked from commit 8101d956f5https://chromium-review.googlesource.com/c/chromium/src/+/2262113
(cherry picked from commit 72b6f1195807b0b65c1df91c1ab162https://chromium-review.googlesource.com/c/chromium/src/+/2244124
(cherry picked from commit 3d45d7b78c#24452 )
(cherry picked from commit 004e29ad33https://chromium-review.googlesource.com/c/chromium/src/+/2257124
Co-authored-by: Andy Locascio <andy@slack-corp.com >
Co-authored-by: Electron Bot <anonymous@electronjs.org >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@github.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2020-07-09 10:04:19 -04:00
trop[bot]
72f2dad3a1
Make pasteandmatchstyle accelerator OS specific ( #24182 )
...
Co-authored-by: Elena Topaka <el1topa@gmail.com >
2020-06-17 21:47:47 -07:00
trop[bot]
57b766aa82
fix: showing certificate dialog with no window ( #24118 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2020-06-13 08:22:36 -07:00
trop[bot]
4b8295a24d
fix: fs.readdir should support withFileTypes ( #24106 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2020-06-12 13:42:17 -07:00
trop[bot]
79acd3e0ef
fix: expose electron/common and electron/renderer modules in sandboxed preloads ( #23893 )
...
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
2020-06-02 14:23:19 +09:00
Shelley Vohr
9d2aa93581
fix: ensure nativeImage serialization main->renderer ( #23794 )
...
* refactor: use typeutils for nativeImage serialization (#23693 )
* fix: ensure nativeImage serialization main->renderer
2020-05-28 12:07:33 -07:00
trop[bot]
eb93acc463
fix: handle asynchronous URL loading in bw proxy ( #23804 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2020-05-28 09:41:54 -07:00
trop[bot]
1fb11e1e76
fix: trigger about panel for about role on on win ( #23717 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2020-05-22 00:55:25 -07:00
Milan Burda
df53816eea
feat: expose the desktopCapturer module in the main process ( #23548 )
2020-05-20 20:25:49 -04:00
Shelley Vohr
4b23a85475
refactor: correctly serialize nativeImage/buffer with typeUtils ( #23666 )
...
* refactor: correctly serialize nativeImage/buffer with typeUtils
* test: add serialization specs
* fix: construct from dataURL
* test: test for dataURL specificity
2020-05-20 13:42:42 -07:00
LuoJinghua
9d851b8791
net: Don't ignore the referer header in net.request ( #23386 )
2020-05-20 13:28:38 -04:00
Jeremy Apthorp
8de06f0c57
feat: deprecate uncompressed crash uploads ( #23598 )
2020-05-19 13:47:21 -07:00
Jeremy Apthorp
de44d28c8e
refactor: ginify Session ( #23569 )
2020-05-19 10:18:12 -07:00
Jeremy Apthorp
7e841ceb5c
refactor: tsify net module ( #23618 )
2020-05-18 10:22:48 -07:00
Shelley Vohr
ee0f67d541
fix: nativeImage remote serialization ( #23543 )
...
We weren't serializing nativeImages properly in the remote module, leading to gin conversion errors when trying to, for example, create a new context menu in the renderer with icons using nativeImage. This fixes that by adding a new special case to handle them.
2020-05-18 09:29:24 -07:00
Milan Burda
52b50e6b33
feat: add app render-process-gone event ( #23560 )
2020-05-17 17:05:05 +02:00
Samuel Attard
9d7ba98209
refactor: remove the RenderFrameFunctionStore and use privates to memory manage ( #23592 )
2020-05-15 11:57:40 -07:00
Milan Burda
4afc756094
feat: add contents.getBackgroundThrottling() + backgroundThrottling property ( #21036 )
2020-05-14 15:11:45 +02:00
Milan Burda
85fae67966
perf: use type-utils for desktopCapturer.getSources() result serialization ( #23549 )
2020-05-13 19:05:53 +02:00
Samuel Attard
54ff423dac
fix: leave behind the unmodified XDG_CURRENT_DESKTOP variable ( #23512 )
2020-05-12 20:13:53 -07:00
Samuel Attard
34da3bc500
feat: add new render-process-gone event ( #23096 )
2020-05-11 13:42:24 -07:00
Samuel Attard
7f9b7b2e95
chore: clean up context bridge scopes and add specs for internal bridge ( #23334 )
...
* chore: clean up context bridge context scopes
* spec: add specs for internalContextBridge
2020-05-11 13:41:42 -07:00
Milan Burda
392ea320cf
build: allow use of BUILDFLAG directives from within JS code ( #20328 )
2020-05-11 01:06:07 +02:00
Jeremy Apthorp
06bf0d08dc
fix: crashReporter incompatible with sandbox on Linux ( #23265 )
2020-05-07 13:31:26 -07:00
Robo
a707a3eda3
feat: add enableWebSQL webpreference ( #23311 )
...
* feat: add enableWebSQL webpreference
* chore: update indexedDB test
2020-05-06 12:52:59 -07:00
shelley vohr
0f0cc51b35
refactor: return null when passing empty menu templates ( #23364 )
2020-05-04 08:19:21 -07:00
Robo
c438b93f18
fix: ensure guest-embedder map is updated when webview is removed ( #23342 )
...
There are use cases of webview where the container holding the webview is not
actually destroyed first, instead just webview gets removed from DOM, in such
situations the browser process map is not updated accordingly and holds reference
to stale guest contents, and any window operations like scroll, resize or keyboard
events that has to chain through browser embedder will lead to UAF crash.
Ref: https://github.com/microsoft/vscode/issues/92420
2020-04-30 21:33:14 -07:00
Milan Burda
4bbb2fbf1f
chore: remove unused ELECTRON_GET_CONTENT_SCRIPTS ipc handler ( #23371 )
2020-04-30 21:32:08 -07:00
Jeremy Apthorp
8d0a612265
refactor: remove code for non-native extensions shim ( #23340 )
2020-04-30 09:38:09 -07:00
shelley vohr
f50f725a9c
fix: prevent Menu.buildFromTemplate with empty array ( #23308 )
...
Prevent issues with menu creation and subsequent pane focus from menu bar by preventing menus from being created from an empty array. I can't conceive a valid use case for this, since if one wants to remove a menu they should be be passing null to win.setMenu() or calling win.removeMenu(). This issue is also specific to top-level menus, and not submenus, so the new check and exception is scoped to top-level menus.
2020-04-30 08:29:02 -07:00
Samuel Attard
7377bb3736
fix: do not add 104 to the history length ( #23301 )
2020-04-27 15:53:47 -07:00
Samuel Attard
abe5cf398c
refactor: port window.open and window.opener to use ctx bridge instead of hole punching ( #23235 )
...
* refactor: port window.open and window.opener to use ctx bridge instead of hole punching
* refactor: only run the isolated init bundle when webview is enabled
2020-04-27 12:46:04 -07:00
Cheng Zhao
cb6a1e2c5e
fix: set default menu in will-finish-launching event ( #23214 )
2020-04-23 10:51:31 -07:00
Samuel Attard
8262f24fd8
fix: do not mutate ipc instances across contexts ( #23236 )
2020-04-22 16:36:15 -07:00
Samuel Attard
375b793984
fix: do not allow child windows to specify their own preload script ( #23226 )
2020-04-22 12:43:21 -07:00
Samuel Attard
96bf9ce77f
refactor: port parts of window-setup to use ctx bridge instead of being run in the main world ( #23194 )
...
* refactor: port parts of window-setup to use ctx bridge instead of being run in the main world
* chore: update ctx bridge specs for new base numbers
2020-04-22 12:42:51 -07:00
Samuel Attard
9d60cfa6fc
fix: do not double-declare webPreferences ( #23223 )
2020-04-22 11:06:30 -07:00
Jeremy Apthorp
c798a6e5d1
fix: block custom window.open when nativeWindowOpen is true ( #23188 )
2020-04-22 10:48:54 -07:00
