Milan Burda
ab3e65ae34
fix: [webview] fix missing properties on events when contextIsolation: true ( #29143 )
...
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2021-05-13 23:39:16 +02:00
Milan Burda
29d8cf5423
fix: <webview> focus / blur events don't work with contextIsolation enabled ( #29004 ) ( #29026 )
2021-05-07 11:15:45 +09:00
Keeley Hammond
1f1ff0e51f
fix: documentEdited property on BrowserWindow ( #28159 )
2021-03-14 17:27:36 -07:00
Milan Burda
581b47582f
fix: warning when worldSafeExecuteJavaScript is disabled ( #27974 )
2021-03-05 10:15:37 +09:00
Michaela Laurencin
c6f8625947
fix: replace default frameName title with null check ( #27813 ) ( #27868 )
...
* fix: replace default frameName title with null check (#27521 )
* refactor: replace default frameName title with null check
* add isNativeWindowOpen check in makeBrowserWindowOptions
* modify snapshot test files
* replace title with frame-name again for proxy - not native open
* modify proxy snapshot title key-value to come after height key-value
* add nativewindowopen check to null title
* fix lint and json formatting
* reformat test cases for this branch
the merged changes included some rearrangements to the json items that
do not apply to this branch, so the items were reordered according to
this branch's previous files.
* remove default frameName title for native open call and modify test txts
2021-02-23 10:26:01 -05:00
trop[bot]
2345ff0644
fix: enableBlinkFeatures warning in webviews ( #27788 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2021-02-18 14:06:56 -08:00
Milan Burda
bd08155093
refactor: load preload script directly as a string ( #27741 )
2021-02-16 11:40:10 -08:00
Milan Burda
b90f5435a9
fix(asar): readdir(withFileTypes) fails on deep directory ( #26865 ) ( #27507 )
...
when using readdirSync on a deep directory within the archive, the code fails to get the stats of child paths.
Co-authored-by: Avi Vahl <avi.vahl@wix.com >
2021-01-27 17:04:34 +09:00
trop[bot]
2e98e11364
fix: <webview> not working with Trusted Types ( #27465 )
...
Co-authored-by: Milan Burda <milan.burda@gmail.com >
2021-01-25 11:47:33 -08:00
trop[bot]
62b2243574
fix: CSP with unsafe-eval detection with Trusted Types ( #27468 )
...
Co-authored-by: Milan Burda <milan.burda@gmail.com >
2021-01-25 08:33:25 -08:00
trop[bot]
2717a48f30
fix: memory leak in desktopCapturer.getSources ( #27057 )
...
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
2020-12-16 20:47:47 -08:00
Jeremy Rose
0bbd268eb4
fix: restrict sendToFrame to same-process frames by default ( #26875 ) ( #26927 )
...
* fix: restrict sendToFrame to same-process frames by default (#26875 )
* missed a conflict
* fix build
* fix build again
* fix usage of defer
2020-12-11 13:01:40 -08:00
Milan Burda
883b089e0f
fix: systemPreferences.effectiveAppearance returning systemPreferences.getAppLevelAppearance() ( #26852 ) ( #26882 )
2020-12-09 14:59:01 +09:00
trop[bot]
9562a92c5d
fix: handle security warnings promise when JS is disabled ( #26871 )
...
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
2020-12-07 13:03:37 -08:00
Milan Burda
f7a61c4592
fix: <webview> render-process-gone event dispatch ( #26577 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2020-11-18 17:56:44 -06:00
Milan Burda
83db340eb3
fix: ensure that internal messages are sent from the main process ( #26439 )
2020-11-16 15:32:00 +09:00
trop[bot]
ae3c79d6ce
refactor: store <webview> attributes as typed Map ( #26329 )
...
Co-authored-by: Milan Burda <milan.burda@gmail.com >
2020-11-05 11:25:53 -05:00
trop[bot]
fee2655061
fix: window.open not accepting size values with "px" at the end ( #26333 )
...
* fix: use parseInt to parse sizes
* fix: pass radix to parseInt
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
Co-authored-by: Abhishek Shingane <abhisheks@iitbhilai.ac.in >
Co-authored-by: Cheng Zhao <github@zcbenz.com >
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
2020-11-04 10:59:54 -08:00
Shelley Vohr
38d126fb5c
fix: order menu items before filtering excess separators ( #25931 )
...
Co-authored-by: Samuel Attard <sattard@slack-corp.com >
2020-10-15 11:13:55 -04:00
trop[bot]
ac917b5573
fix: pass module resolution paths to wrapped function ( #25944 )
...
Co-authored-by: Matt Kane <matt@gatsbyjs.com >
2020-10-15 10:49:18 +09:00
Shelley Vohr
13722f83e3
fix: ensure ready-to-show event is fired ( #25932 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
2020-10-15 10:02:36 +09:00
trop[bot]
56a764d510
fix: suppress worldSafe warning emitted from security checks ( #25827 )
...
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
2020-10-08 20:20:09 -07:00
Milan Burda
7ae4b2b559
fix: session argument of app 'session-created' event ( #25798 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2020-10-08 16:32:26 -05:00
trop[bot]
de0ddd5b56
chore: tsify net-log ( #25670 )
...
* chore: tsify net-log
* comment
* gn
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
2020-09-29 12:56:54 -04:00
trop[bot]
4a0f2bede2
chore: improve renderer crash logging ( #25621 )
...
Co-authored-by: Milan Burda <milan.burda@gmail.com >
2020-09-24 13:23:41 -07:00
trop[bot]
21a46bc0eb
chore: log hint on renderer crash ( #25472 )
...
* chore: log hint on renderer crash
* Address feedback from review
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2020-09-15 14:01:49 -06:00
Samuel Attard
fa3652a14f
fix: only focus a webContents if the window was not initially hidden ( #25323 ) ( #25330 )
...
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
2020-09-08 16:55:46 +09:00
George Xu
d73b67f386
feat: add nativeImage.createThumbnailFromPath API ( #25072 )
...
* cherry-picking
* add documentation
* convert createThumbnailFromPath to async function
* windows impl protoype
* add tests
* clean up
* fix
* fix test
* update docs
* cleaning up code
* fix test
* refactor from app to native_image
* windows build
* lint
* lint
* add smart pointers, fix test
* change tests and update docs
* fix test, remove nolint
* add renderer-main process routing to fix tests
* lint
* thanks sam
* cherry-pick
* lint
* remove getApplicationInfoForProtocol code
* chore: fix filenames conflict
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
2020-08-26 16:18:28 -07:00
trop[bot]
bc4884788c
feat: add worldSafe flag for executeJS results ( #24711 )
...
* feat: add worldSafe flag for executeJS results
* chore: do not log warning for webContents.executeJS
* Apply suggestions from code review
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
* chore: apply PR feedback
* chore: split logic a bit
* chore: allow primitives through the world safe checl
* chore: clean up per PR feedback
* chore: flip boolean logic
* chore: update per PR feedback
* chore: fix typo
* chore: fix spec
* Update web-frame.ts
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
Co-authored-by: Samuel Attard <sattard@slack-corp.com >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2020-08-05 10:24:51 -07:00
Shelley Vohr
39edbd6af4
fix: always callback error with invalid print settings ( #24507 )
2020-07-13 08:55:30 -07:00
Electron Bot
d608a30015
chore: bump chromium to 85.0.4183.19 (10-x-y) ( #24299 )
...
* chore: bump chromium in DEPS to 85.0.4182.1
* chore: bump chromium in DEPS to 85.0.4183.2
* chore: bump chromium in DEPS to 85.0.4183.4
* chore: bump chromium in DEPS to 85.0.4183.5
* update patches
* chore: bump chromium in DEPS to 85.0.4183.6
* chore: bump chromium in DEPS to 85.0.4183.7
* update patches
* chore: bump chromium in DEPS to 85.0.4183.8
* remove chromeos-only TtsControllerDelegate
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2255314
(cherry picked from commit f975f84a3c )
* rename GetHighContrastColorScheme -> GetPlatformHighContrastColorScheme
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2250224
(cherry picked from commit 014b487258 )
* add max_xcode_version build var
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2264867
(cherry picked from commit 2c3b94f497 )
* add empty floc blocklist to BrowserProcessImpl
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2240873
(cherry picked from commit 3cdaae146d )
* Move zygote from //services/service_manager back to //content
https://chromium-review.googlesource.com/c/chromium/src/+/2252466
(cherry picked from commit e0d6dbcf1e )
* Reland "[base] Stop including check.h, notreached.h, etc. in logging.h"
https://chromium-review.googlesource.com/c/chromium/src/+/2264297
(cherry picked from commit 1407040133 )
* Update mas private api patch
* Reland "Reland "New toolchain for Windows 10 19041 SDK""
https://chromium-review.googlesource.com/c/chromium/src/+/2255527
(cherry picked from commit 8101d956f5 )
* [XProto] Remove usage of Shape extension
https://chromium-review.googlesource.com/c/chromium/src/+/2262113
(cherry picked from commit 72b6f11958 )
* chore: bump chromium in DEPS to 85.0.4183.9
* chore: bump chromium in DEPS to 85.0.4183.10
* chore: bump chromium in DEPS to 85.0.4183.11
* chore: bump chromium in DEPS to 85.0.4183.12
* chore: bump chromium in DEPS to 85.0.4183.13
* update patches
* fixup! add empty floc blocklist to BrowserProcessImpl
(cherry picked from commit 07b0b65c1d )
* fixup! Reland "[base] Stop including check.h, notreached.h, etc. in logging.h"
(cherry picked from commit f91c1ab162 )
* Check for GDI exhaustion if window creation fails
https://chromium-review.googlesource.com/c/chromium/src/+/2244124
(cherry picked from commit 3d45d7b78c )
* chore: bump chromium in DEPS to 85.0.4183.14
* Fixup lint issue
* update patches
* fix: include missing header file
* chore: bump chromium in DEPS to 85.0.4183.19
* update patches
* refactor: match upstream print preview handling (#24452 )
(cherry picked from commit 004e29ad33 )
* use PrintHostMsg_DidPreviewPage_Params
https://chromium-review.googlesource.com/c/chromium/src/+/2257124
Co-authored-by: Andy Locascio <andy@slack-corp.com >
Co-authored-by: Electron Bot <anonymous@electronjs.org >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@github.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2020-07-09 10:04:19 -04:00
trop[bot]
72f2dad3a1
Make pasteandmatchstyle accelerator OS specific ( #24182 )
...
Co-authored-by: Elena Topaka <el1topa@gmail.com >
2020-06-17 21:47:47 -07:00
trop[bot]
57b766aa82
fix: showing certificate dialog with no window ( #24118 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2020-06-13 08:22:36 -07:00
trop[bot]
4b8295a24d
fix: fs.readdir should support withFileTypes ( #24106 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2020-06-12 13:42:17 -07:00
trop[bot]
79acd3e0ef
fix: expose electron/common and electron/renderer modules in sandboxed preloads ( #23893 )
...
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
2020-06-02 14:23:19 +09:00
Shelley Vohr
9d2aa93581
fix: ensure nativeImage serialization main->renderer ( #23794 )
...
* refactor: use typeutils for nativeImage serialization (#23693 )
* fix: ensure nativeImage serialization main->renderer
2020-05-28 12:07:33 -07:00
trop[bot]
eb93acc463
fix: handle asynchronous URL loading in bw proxy ( #23804 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2020-05-28 09:41:54 -07:00
trop[bot]
1fb11e1e76
fix: trigger about panel for about role on on win ( #23717 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2020-05-22 00:55:25 -07:00
Milan Burda
df53816eea
feat: expose the desktopCapturer module in the main process ( #23548 )
2020-05-20 20:25:49 -04:00
Shelley Vohr
4b23a85475
refactor: correctly serialize nativeImage/buffer with typeUtils ( #23666 )
...
* refactor: correctly serialize nativeImage/buffer with typeUtils
* test: add serialization specs
* fix: construct from dataURL
* test: test for dataURL specificity
2020-05-20 13:42:42 -07:00
LuoJinghua
9d851b8791
net: Don't ignore the referer header in net.request ( #23386 )
2020-05-20 13:28:38 -04:00
Jeremy Apthorp
8de06f0c57
feat: deprecate uncompressed crash uploads ( #23598 )
2020-05-19 13:47:21 -07:00
Jeremy Apthorp
de44d28c8e
refactor: ginify Session ( #23569 )
2020-05-19 10:18:12 -07:00
Jeremy Apthorp
7e841ceb5c
refactor: tsify net module ( #23618 )
2020-05-18 10:22:48 -07:00
Shelley Vohr
ee0f67d541
fix: nativeImage remote serialization ( #23543 )
...
We weren't serializing nativeImages properly in the remote module, leading to gin conversion errors when trying to, for example, create a new context menu in the renderer with icons using nativeImage. This fixes that by adding a new special case to handle them.
2020-05-18 09:29:24 -07:00
Milan Burda
52b50e6b33
feat: add app render-process-gone event ( #23560 )
2020-05-17 17:05:05 +02:00
Samuel Attard
9d7ba98209
refactor: remove the RenderFrameFunctionStore and use privates to memory manage ( #23592 )
2020-05-15 11:57:40 -07:00
Milan Burda
4afc756094
feat: add contents.getBackgroundThrottling() + backgroundThrottling property ( #21036 )
2020-05-14 15:11:45 +02:00
Milan Burda
85fae67966
perf: use type-utils for desktopCapturer.getSources() result serialization ( #23549 )
2020-05-13 19:05:53 +02:00
Samuel Attard
54ff423dac
fix: leave behind the unmodified XDG_CURRENT_DESKTOP variable ( #23512 )
2020-05-12 20:13:53 -07:00