trop[bot]
5ab5427b6e
fix: use StartUpdating method for PipeWire capturer ( #39049 )
...
* fix: use StartUpdating method for PipeWire capturer
Fixed a crash related to PipeWire capturer by adapting to Chromium's
interface changes. Chromium expects a call to
`NativeDesktopMediaList::StartUpdating` with an implementation of
`DesktopMediaListObserver` for delegated capturers like PipeWire. This
interface allows listening to user permission events and listing
sources only after the user has made a choice on the permission dialog.
The interface has been implemented by an inner class to allow listening
to screen and window capture permissions concurrently using two
instances of the class. A patch that was resetting the capturer on the
first refresh has been changed to exclude PipeWire. PipeWire capturer
object will follow the lifecycle of `NativeDesktopMediaList`, as is the
case in Chromium.
Fixes #37463
Co-authored-by: Athul Iddya <athul@iddya.com >
* fix: wait for thumbnails from PipeWire when necessary
The PipeWire stream starts after the dialog is dismissed. If the sources
are listed immediately afterwards, the thumbnail may not have been
generated by that time. Explicitly wait for both thumbnail generation
and a selection on the source dialog before listing sources.
Co-authored-by: Athul Iddya <athul@iddya.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Athul Iddya <athul@iddya.com >
2023-07-11 09:44:01 -07:00
trop[bot]
d463bf9c16
fix: remove types from GTK CSS selectors ( #39045 )
...
Remove types from GTK CSS selectors similar to Chromium's changes in CL
4289229.
Fixes #38786
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Athul Iddya <athul@iddya.com >
2023-07-11 10:19:41 +02:00
trop[bot]
33376fba39
fix: set prototype names on gin::Constructible classes ( #39036 )
...
* fix: set prototype names on gin::Constructible classes
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* test: add tests
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-07-10 15:58:18 +02:00
trop[bot]
b0b87b098e
revert: compensate for title bar height when setting bounds on BrowserView ( #39004 )
...
This reverts commit 75f9573e53shelley.vohr@gmail.com >
2023-07-10 15:57:55 +02:00
trop[bot]
13d224e816
fix: webview crash when removing in close event ( #39007 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-07-10 13:42:21 +02:00
trop[bot]
3cdd3d6518
fix: Notification 'Show' button visible when no actions exist ( #39013 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-07-07 09:58:38 +02:00
trop[bot]
2b254b1d6d
feat: add support for keyboard initialized menu popup ( #38954 )
...
* feat: add support for keyboard initialized menu popup
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
* Update docs/api/menu.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
Co-authored-by: Samuel Attard <sam@electronjs.org >
* fix: add patch to chromium for keyboard accessibility menu behavior
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
* refactor: s/initiatedByKeyboard/sourceType
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
* fix: ignore initial mouse event to retain keyboard initiated focus
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
* Update docs/api/menu.md
Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com >
Co-authored-by: Samuel Attard <sam@electronjs.org >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
Co-authored-by: Samuel Attard <sam@electronjs.org >
2023-07-05 16:30:19 -04:00
Charles Kerr
236272bf9f
refactor: more constexpr lookup tables ( #38895 )
...
* refactor: more constexpr lookup tables (#38886 )
* refactor: use constexpr lookup table in electron_api_web_contents.cc
* refactor: make KeyboardCodeFromStr() private
it is only used as a helper to KeyboardCodeFromStr()
* chore: savepoint
* chore: make lint happy
* fixup! refactor: make KeyboardCodeFromStr() private
* refactor: use constexpr lookup table in electron_url_loader_factory
* refactor: use constexpr lookup table in electron_api_tray
* refactor: use constexpr lookup table in web_contents_preferences.cc
* refactor: use constexpr lookup table in content_converter
* chore: fix clang-format
clang-format gets confused by ifdefs in the middle of an initializer list
2023-06-27 15:49:32 +09:00
trop[bot]
76f4291130
feat: allow headers to be sent with session.downloadURL() ( #38871 )
...
* feat: allow headers to be sent with session.downloadURL
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* Update shell/browser/api/electron_api_session.cc
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-06-22 14:40:11 -04:00
trop[bot]
16aac6da13
chore: bump chromium to 116.0.5845.0 (26-x-y) ( #38893 )
...
* chore: bump chromium in DEPS to 116.0.5835.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: update patches
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
* chore: bump chromium in DEPS to 116.0.5837.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: bump chromium in DEPS to 116.0.5839.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: bump chromium in DEPS to 116.0.5841.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: bump chromium in DEPS to 116.0.5843.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* Update patches
CLs that affected printing.patch:
- 4616791: Refactor PrintViewManagerBase::PrintNow()
https://chromium-review.googlesource.com/c/chromium/src/+/4616791
- 4602776: Make PrintNodeUnderContextMenu operation go through PrintViewManager
https://chromium-review.googlesource.com/c/chromium/src/+/4602776
Co-authored-by: clavin <clavin@electronjs.org >
* 4506614: geolocation: Add LocationProvider::FillDiagnostics https://chromium-review.googlesource.com/c/chromium/src/+/4506614
Co-authored-by: clavin <clavin@electronjs.org >
* chore: bump chromium in DEPS to 116.0.5845.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: update patches
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
* fixup! 4506614: geolocation: Add LocationProvider::FillDiagnostics https://chromium-review.googlesource.com/c/chromium/src/+/4506614
Co-authored-by: clavin <clavin@electronjs.org >
* 4609704: Remove gnome-keyring https://chromium-review.googlesource.com/c/chromium/src/+/4609704
Co-authored-by: clavin <clavin@electronjs.org >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org >
2023-06-22 13:57:04 -04:00
trop[bot]
479c2d8d4a
fix: crash calling BrowserWindow.removeBrowserView() with destroyed webContents ( #38885 )
...
fix: crash calling removeBrowserView() with destroyed webContents
https://github.com/electron/electron/issues/37642
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-06-22 12:56:33 +02:00
trop[bot]
6c05422a61
fix: set supported scale factors on startup ( #38861 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-06-21 10:19:41 +02:00
trop[bot]
a6d76efc9e
refactor: use constexpr lookup tables in gin helper ( #38835 )
...
* feat: add gin_helper::FromV8WithLookup()
feat: add gin_helper::FromV8WithLowerLookup()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: use constexpr lookup table in gin Converters
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2023-06-20 14:38:30 +02:00
trop[bot]
1e3837f4c3
refactor: remove unused InspectableWebContentsView::GetWebView() ( #38820 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2023-06-16 12:43:28 -05:00
electron-roller[bot]
c2e362d2d3
chore: bump chromium to 116.0.5833.0 (26-x-y) ( #38808 )
...
* chore: bump chromium in DEPS to 116.0.5833.0
* chore: update patches
* 4530656: Add DeviceLoginScreenWebHidAllowDevicesForUrls policy
https://chromium-review.googlesource.com/c/chromium/src/+/4530656
(cherry picked from commit 2c376c7f1ahttps://chromium-review.googlesource.com/c/chromium/src/+/4596317
(cherry picked from commit 1e2f7ef605jkleinsc@electronjs.org >
2023-06-15 16:37:27 -04:00
trop[bot]
7ad80e414a
refactor: constexpr lookup tables ( #38797 )
...
* refactor: use a constexpr lookup table in GetPathConstant()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: use a constexpr lookup table in SystemPreferences::GetColor()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: use a constexpr lookup table in SimpleURLLoaderWrapper::Create()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2023-06-14 22:08:54 -05:00
trop[bot]
e5419bcf5a
chore: remove unused std includes ( #38795 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2023-06-14 17:35:49 -04:00
trop[bot]
77d4ab0701
chore: bump chromium to 116.0.5829.0 (26-x-y) ( #38765 )
...
* chore: bump chromium in DEPS to 116.0.5823.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: update patches
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
* chore: bump chromium in DEPS to 116.0.5825.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: update patches
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
* chore: bump chromium in DEPS to 116.0.5827.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: update patches
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
* 4568811: Integrate Search Prefetch with Extensions.
https://chromium-review.googlesource.com/c/chromium/src/+/4568811
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* 4567511: [DevTools] Add recordCountHistogram API.
https://chromium-review.googlesource.com/c/chromium/src/+/4567511
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* 4507692: Delete base/guid.h
https://chromium-review.googlesource.com/c/chromium/src/+/4507692
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* 4589551: Convert some of /base to use ARC
https://chromium-review.googlesource.com/c/chromium/src/+/4589551
Also:
4601769: Convert immersive mode controllers to use ARC
https://chromium-review.googlesource.com/c/chromium/src/+/4601769
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* Convert MaybeSizeInBytes() to take in SharedImageFormat
https://chromium-review.googlesource.com/c/chromium/src/+/4594677
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* 4564108: [BRP] Enable check_raw_ptr_fields for Mac
https://chromium-review.googlesource.com/c/chromium/src/+/4564108
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* chore: bump chromium in DEPS to 116.0.5828.0
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* chore: bump chromium in DEPS to 116.0.5829.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: update patches
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2023-06-14 07:47:10 -04:00
electron-roller[bot]
cddfdf3ba2
chore: bump chromium to 116.0.5817.0 (26-x-y) ( #38546 )
...
* chore: bump chromium in DEPS to 116.0.5805.2
* chore: bump chromium in DEPS to 116.0.5807.0
* chore: update patches
* chore: bump chromium in DEPS to 116.0.5809.2
* chore: bump chromium in DEPS to 116.0.5811.0
* chore: bump chromium in DEPS to 116.0.5813.0
* chore: bump chromium in DEPS to 116.0.5815.0
* chore: bump chromium in DEPS to 116.0.5817.0
* chore: bump chromium in DEPS to 116.0.5819.0
* chore: bump chromium in DEPS to 116.0.5821.0
* chore: bump chromium in DEPS to 116.0.5823.0
* chore: bump chromium in DEPS to 116.0.5825.0
* chore: bump chromium in DEPS to 116.0.5827.0
* chore: bump chromium to 116.0.5817.0
cherry picked from fd5e6fbc14#38621 )
(cherry picked from commit 9a9d8ae5eajkleinsc@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-06-12 18:29:28 -04:00
trop[bot]
e6a631f078
perf: prefer base::StringPiece over std::string for build-time strings ( #38738 )
...
* perf: use base::StringPiece in InclusionStatusToString()
The strings are all build-time constants and this is a private function
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* perf: use base::StringPiece in ErrorCodeToString()
The strings are all build-time constants and this is a private function
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* perf: use base::StringPiece in MessageSourceToString()
The strings are all build-time constants and this is a private function
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* perf: use base::StringPiece in CursorTypeToString()
The strings are all build-time constants and this is a private function
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* perf: use base::StringPiece in MediaStreamTypeToString()
The strings are all build-time constants and this is a private function
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* perf: use base::StringPiece in ModifiersToArray()
The strings are all build-time constants and this is a private function
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* perf: use base::StringPiece in WebFrameRenderer::MaybeGetRenderFrame()
The strings are all build-time constants and this is a private function
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2023-06-12 12:21:08 -05:00
trop[bot]
29d776400a
refactor: api web contents ownership ( #38723 )
...
* refactor: aggregate api::WebContents::exclusive_access_manager_ directly
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: make WebContents::devtools_file_system_indexer_ scoped_refptr const
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: make WebContents::file_task_runner_ scoped_refptr const
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: make WebContents::print_task_runner_ scoped_refptr const
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2023-06-09 18:57:32 -05:00
trop[bot]
744b8dfc31
refactor: add SessionPreferences::CreateForBrowserContext() ( #38713 )
...
Copy the NativeWindowRelay::CreateForWebContents() idiom
to simplify SessionPreferences's constructor and lifecycle.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2023-06-09 12:21:30 -07:00
trop[bot]
9a64d47132
fix: WCO transparent background ( #38716 )
...
* fix: WCO transparency
Co-authored-by: samuelmaddock <samuel.maddock@gmail.com >
* doc: wco color transparency
Co-authored-by: samuelmaddock <samuel.maddock@gmail.com >
* fix: transparent buttons when calling setTitleBarOverlay
Co-authored-by: samuelmaddock <samuel.maddock@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: samuelmaddock <samuel.maddock@gmail.com >
2023-06-09 12:19:31 -07:00
trop[bot]
7acdcae772
fix: menu bar visibility when exiting full screen ( #38683 )
...
* fix:visibility of menu bar when exiting full screen
Co-authored-by: wugaosheng <wugaosheng@kylinos.cn >
* format code
Co-authored-by: wugaosheng <wugaosheng@kylinos.cn >
* format code
Co-authored-by: wugaosheng <wugaosheng@kylinos.cn >
* Modify comments
Co-authored-by: wugaosheng <wugaosheng@kylinos.cn >
* add menu bar visibility test
Co-authored-by: wugaosheng <wugaosheng@kylinos.cn >
* format code
Co-authored-by: wugaosheng <wugaosheng@kylinos.cn >
* change code
Co-authored-by: wugaosheng <wugaosheng@kylinos.cn >
* platform related in test
Co-authored-by: wugaosheng <wugaosheng@kylinos.cn >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: wugaosheng <wugaosheng@kylinos.cn >
2023-06-09 13:59:15 +02:00
trop[bot]
67f9b1f88d
fix: dangling pointer warning when updating menus ( #38690 )
...
fix: dangling raw_ptr warning when updating menus
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2023-06-08 16:40:52 -04:00
trop[bot]
fc241977fe
fix: reparenting UAF crash on macOS ( #38679 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-06-08 13:29:17 -04:00
trop[bot]
9d3c1d993a
chore: clean up ElectronPermissionManager ( #38669 )
...
chore: clean up ElectronPermissionManager
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-06-08 12:19:01 +02:00
trop[bot]
53b398d7c3
refactor: remove unused OffScreenRenderWidgetHostView fields ( #38649 )
...
* refactor: remove unused field OffScreenRenderWidgetHostView::last_time_
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: remove unused field OffScreenRenderWidgetHostView::last_scroll_offset_
Unused since 1a9e253charles@charleskerr.com >
* refactor: remove unused field OffScreenRenderWidgetHostView::paint_callback_running_
assigned to, but unread, since 81bf158charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2023-06-07 23:51:07 -07:00
trop[bot]
455458ace8
fix: sync api::Screen wrapper method sigs to upstream ( #38633 )
...
refactor: sync api::Screen getter sigs to upstream
ui::Display GetAllDisplays(), GetPrimaryDisplay(), GetDisplayMatching(),
and GetDisplayNearestPoint() methods are all const, so make our wrappers
const too.
ui::Display GetAllDisplays() returns a const reference, so make our
wrapper return a const reference too. This avoids creating a new
std::vector<display::Display> each time it's called.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2023-06-07 12:09:23 +02:00
trop[bot]
0e2fd41733
refactor: remove redundant resizing strategy equality check ( #38617 )
...
* refactor: remove redundant resizing strategy equality check
Upstream already checks this.
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: remove devtools_settings.h from iwc header
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: remove unused <vectro> from iwc header
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2023-06-07 09:28:42 +02:00
trop[bot]
3f3435bea7
fix: account for BrowserView bounds in setting autofill popup bounds ( #38610 )
...
fix: account for BrowserView bounds in setting autofill popup bounds
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-06-06 21:50:52 +02:00
trop[bot]
d142292485
refactor: use process_util.h helpers ( #38606 )
...
refactor: use process_util.h helpers
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Milan Burda <milan.burda@gmail.com >
2023-06-06 15:48:33 -04:00
trop[bot]
42a5affba8
fix: file selection when disallowed on macOS ( #38590 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-06-05 16:21:41 +02:00
trop[bot]
f89974fe4b
refactor: use direct aggregation in NativeWindowViews ( #38576 )
...
* refactor: in NativeWindowViews, aggregate root_view_ directly
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: in NativeWindowViews, aggregate keyboard_event_handler_ directly
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* refactor: make NativeWindowClientView::window_ a raw_ref
Xref: https://chromium.googlesource.com/chromium/src/+/main/styleguide/c++/c++.md\#non_owning-pointers-in-class-fields
Prefer const raw_ref<T> whenever the held pointer will never be null
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: make lint happy
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2023-06-05 15:42:25 +02:00
trop[bot]
b9453eb6d8
chore: remove unused electron::api::View code ( #38569 )
...
chore: remove unused electron::api::View methods
Remove code that was added in 2c8dc9echarles@charleskerr.com >
2023-06-03 16:18:27 -05:00
trop[bot]
e12b30b6ce
perf: avoid unnecessary base value clone ( #38564 )
2023-06-02 17:04:19 -05:00
Shelley Vohr
57147d1b8d
fix: navigator.connection not working as intended ( #38491 )
...
* fix: navigator.connection not working as intended
* chore: make network quality methods private
2023-05-31 11:06:25 -04:00
Shelley Vohr
663497dc6b
chore: make contentTracing.stopRecording() failure clearer ( #38488 )
...
chore: make contentTracing.stopRecording() failure clearer
2023-05-31 09:54:41 -04:00
Shelley Vohr
40e724e5dd
fix: DCHECK minimizing parent window with non-modal child ( #38460 )
2023-05-31 11:57:44 +02:00
John Kleinschmidt
b4ec363b3d
feat: add USB protected classes handler ( #38263 )
...
* feat: add USB protected classes handler
* chore: apply review suggestions
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: update docs
* chore: apply review suggestions
* update doc per suggestion
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2023-05-30 12:35:25 -04:00
Charles Kerr
0203bd3305
refactor: prefer base::Contains() over find() + end() ( #38443 )
...
* refactor: use base::Contains() in KeyWeakMap::Has()
* refactor: use base::Contains() in WebRequest::RequestFilter::MatchesType()
* refactor: use base::Contains() in BaseWindow::AddBrowserView()
* refactor: use base::Contains() in DeepFreeze()
* refactor: use base::Contains() in Clipboard::Read()
* Revert "refactor: use base::Contains() in BaseWindow::AddBrowserView()"
This reverts commit 60152359d3978451ebdd7c8eed602c2fb8a9cafa.
* refactor: use base::Contains() in BaseWindow::AddBrowserView()
* refactor: use base::Contains() in IsDevToolsFileSystemAdded()
* refactor: use base::Contains() in MessagePort::DisentanglePorts()
* refactor: use base::Contains() in PowerSaveBlocker::IsStarted()
* refactor: use base::Contains() in SpellCheckClient::OnSpellCheckDone()
* refactor: use base::Contains() in ShowTaskDialogWstr()
* refactor: use base::Contains() in PrintViewManagerElectron::ScriptedPrint()
* refactor: use base::Contains() in PrintViewManagerElectron::DidGetPrintedPagesCount()
* refactor: use base::Contains() in NativeWindow::AddDraggableRegionProvider()
* refactor: use base::Contains() in ElectronBindings::ActivateUVLoop()
* refactor: use base::Contains() in NativeWindowViews::IsVisibleOnAllWorkspaces()
* refactor: use base::Contains() in HidChooserController::OnDeviceAdded()
* refactor: use base::Contains() in ElectronSandboxedRendererClient::WillReleaseScriptContext()
* refactor: use base::Contains() in ElectronRendererClient::WillDestroyWorkerContextOnWorkerThread()
* refactor: use base::Contains() in GlobalShortcut::OnKeyPressed()
2023-05-30 10:28:43 +02:00
Shelley Vohr
56138d879e
fix: Windows FrameView always appearing inactive ( #38468 )
2023-05-28 18:39:13 -04:00
Charles Kerr
a20896f519
refactor: remove InspectableWebContents::GetAll() ( #38442 )
...
It is unused and also keeps a persistent std::list<>, so remove it.
2023-05-25 17:23:19 +09:00
Milan Burda
06cc9caeaa
build: remove enable_desktop_capturer flag ( #38412 )
...
feat: remove enable_desktop_capturer flag
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-05-24 15:32:31 -04:00
Milan Burda
2f8e68f8b3
chore: remove ViewsDelegate::IsWindowInMetro() override ( #38409 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2023-05-24 20:00:52 +02:00
Shelley Vohr
16cd486356
fix: MediaDevices missing DisplayMediaInformation ( #38390 )
...
fix: MediaDevices missing DisplayMediaInformation
2023-05-24 11:17:08 -04:00
Cheng Zhao
dec9a1d9db
chore: remove dead draggable region code ( #38404 )
2023-05-24 10:03:07 +02:00
Charles Kerr
b6c80ba646
fix: dangling_raw_ptr warning in electron_api_web_contents ( #38403 )
...
fix: dangling_raw_ptr warning in electron_api_web_contents
2023-05-23 21:52:07 -04:00
Charles Kerr
30e992dec4
chore: bump chromium to 115.0.5786.0 (main) ( #38301 )
...
* chore: bump chromium in DEPS to 115.0.5772.0
* chore: update disable_color_correct_rendering.patch
no manual changes; patch succeeded with fuzz 2.
* chore: update chromium/build_libc_as_static_library.patch
no manual changes; patch succeeded with fuzz 2 (offset 1 line).
* chore: update chromium/feat_configure_launch_options_for_service_process.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4518747
patch manually reapplied due to upstream code shear
* chore: update chromium/chore_patch_out_profile_methods_in_profile_selections_cc.patch
https://chromium-review.googlesource.com/c/chromium/src/+/4502965
patch manually reapplied due to upstream code shear
* chore: update bundle_locations #include location
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4525355
* chore: Remove `extension_name` from DesktopStreamsRegistry
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4514081
* chore: bump chromium in DEPS to 115.0.5778.0
* chore: add chromium/chore_patch_out_profile_methods_in_chrome_browser_pdf.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4482679
Another instance of patching out upstream references to Profile code
* refactor: add WebViewGuestDelegate::GetGuestDelegateWeakPtr()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4515455
This approach copied from GuestViewBase::GetGuestDelegateWeakPtr() approach in that same commit.
* fixup! chore: update bundle_locations #include location
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4525355
Sync namespace use to upstream base::mac -> base::apple changes
* fixup! chore: update bundle_locations #include location
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4525355
Sync namespace use to upstream base::mac -> base::apple changes
* chore: update chromium/mas_disable_remote_accessibility.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4530546
patch manually reapplied due to upstream code shear
* chore: update chromium/printing.patch
no manual changes; patch succeeded with fuzz
* chore: update chromium/build_add_electron_tracing_category.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4517872
no manual changes; patch succeeded with fuzz
* chore: update chromium/feat_ensure_mas_builds_of_the_same_application_can_use_safestorage.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4529098
patch manually reapplied due to upstream code shear
* chromium/build_only_use_the_mas_build_config_in_the_required_components.patch
https://chromium-review.googlesource.com/c/chromium/src/+/4529098
patch manually reapplied due to upstream code shear
* chore: update chromium/mas-cgdisplayusesforcetogray.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4529475
no manual changes; patch succeeded with fuzz
* chore: update chromium/build_only_use_the_mas_build_config_in_the_required_components.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4429011
no manual changes; patch succeeded with fuzz
* chore: remove chromium/cherry-pick-48a136e77e6d.patch
already present upstream
* chore: remove chromium/cherry-pick-e6e23ba00379.patch
already present upstream
* [Code Health] Remove value based RegisterPref for Dict and List
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4533537
* Remove `cxx17_backports.h` and adjust unittest file
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4534916
Notes: mostly just removing #include and s/base::clamp/std::clamp/
* refactor: add FakeBrowserProcess helper class
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4424072
Used in ElectronBrowserMainParts' fake_browser_process_ field. Previously
this was an BrowserProcessImpl instance, but upstream 4424072 makes that
an abstract base class. `FakeBrowserProcess` is a thin subclass with the
minimum code needed to make it concrete.
`ElectronBrowserMainParts::fake_browser_process_` is now a `shared_ptr`
instead of a `unique_ptr` so we can avoid exposing `FakeBrowserProcess`
in the header.
* fixup! refactor: add FakeBrowserProcess helper class
remove unnecessary unique_ptr
* fix: Browser::SetDockIcon() when !Browser.is_ready()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4410741
An alternative fix for https://github.com/electron/electron/pull/36279 .
The previous fix was to call `SetSupportedScales()` ourselves (1b1609ahttps://chromium-review.googlesource.com/c/chromium/src/+/4517404
patch manually reapplied due to upstream code shear
* chore: update patches
* chore: add dep: resource_coordinator:mojo_bindings
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4521464
* fixup! chore: add dep: resource_coordinator:mojo_bindings
chore: make lint happy
* chore: patch out Profile methods in titlebar_config
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4508143 (primary)
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4534461 (followup)
* chore: bump chromium in DEPS to 115.0.5780.0
* chore: update chromium/disable_hidden.patch
no manual changes; patch succeeded with fuzz
* chore: update chromium/sysroot.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4535715
no manual changes; patch succeeded with fuzz
* chore: update chromium/feat_enable_offscreen_rendering_with_viz_compositor.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4403623
patch manually reapplied due to upstream code shear
* chore: update chromium/refactor_expose_cursor_changes_to_the_webcontentsobserver.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4547380
patch manually reapplied due to upstream code shear
* chore: update patches
* fixup! fix: Browser::SetDockIcon() when !Browser.is_ready()
chore: iwyu image.h
* chore: bump chromium in DEPS to 115.0.5782.0
* chore: bump chromium in DEPS to 115.0.5784.0
* 4514181: CR2023: Update filled cr-input styles.
https://chromium-review.googlesource.com/c/chromium/src/+/4514181
* 4521894: Remove SiteInstanceDeleting usage outside of tests.
https://chromium-review.googlesource.com/c/chromium/src/+/4521894
* 4525355: Move backup_util and bundle_locations to base/apple
https://chromium-review.googlesource.com/c/chromium/src/+/4525355
* 4484743: webauthn: add underlying support for calling iCloud Keychain on macOS.
https://chromium-review.googlesource.com/c/chromium/src/+/4484743
* chore: fixup patch indices
* 4546398: Convert /chrome/browser to use ARC
https://chromium-review.googlesource.com/c/chromium/src/+/4546398
* chore: bump chromium in DEPS to 115.0.5786.0
* chore: update patches
* 4540682: Initialize PDF SDK with policy in chrome_pdf::RenderPDFPageToDC()
https://chromium-review.googlesource.com/c/chromium/src/+/4540682
* Don't import ObjC++ fn headers into electron_api_app
* 4535715: Refactor sysroot-creator.sh
https://chromium-review.googlesource.com/c/chromium/src/+/4535715
* fixup! refactor: add FakeBrowserProcess helper class
* 4531903: [string][test] Create/Copy strings to old space before externalization
https://chromium-review.googlesource.com/c/v8/v8/+/4531903
* 59645: Add APIs to support RSA keys with large e.
https://boringssl-review.googlesource.com/c/boringssl/+/59645
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2023-05-23 21:58:58 +02:00
Milan Burda
2acb97aa85
chore: eliminate a few uses of base::AdaptCallbackForRepeating() ( #38293 )
2023-05-18 17:01:44 -04:00
