github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-02-26 03:01:17 -05:00
Code Issues Packages Projects Releases Wiki Activity
27,597 Commits 353 Branches 3,511 Tags
v26.4.3
Commit Graph

3057 Commits

Author SHA1 Message Date
trop[bot]
c00c8debcc fix: navigator.keyboard.lock() fullscreen exit handling (#40387) 
fix: navigator.keyboard.lock() fullscreen exit handling

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2023-10-31 16:53:29 -04:00
Shelley Vohr
3703625ad7 fix: failing build with enable_electron_extensions=false (#40269) 2023-10-19 10:50:30 +09:00
trop[bot]
bec47bca0b chore: implement no-op chrome.action extension APIs (#40259) 
chore: implement no-op chrome.action extension APIs

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2023-10-18 19:42:23 -04:00
trop[bot]
4be7b10550 fix: Windows Toast notification dismissal from Action Center (#40242) 
* fix: Windows Toast notification dismissal from Action Center

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

* docs: note Toast behavior in event

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

* chore: address feedback from review

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2023-10-18 11:32:19 +02:00
trop[bot]
2270fc8d4d fix: incorrect wco bounds in macOS fullscreen (#40218) 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2023-10-16 16:38:35 +02:00
trop[bot]
677d05a3d6 fix: webContents.capturePage() for hidden windows on Windows/Linux (#40187) 
fix: capturePage for hidden windows on Windows/Linux

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2023-10-12 13:54:45 +02:00
trop[bot]
0da1d6d4cc fix: crash when calling non-reentrant function in loadURL (#40163) 
fix: crash when calling non-reentrant function in loadURL

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2023-10-10 11:48:37 -04:00
trop[bot]
33c963dac3 fix: crashed events deprecation (#40112) 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Milan Burda <milan.burda@gmail.com>
 2023-10-06 14:31:17 -04:00
trop[bot]
6228c075f7 fix: all children showing when showing child window (#40107) 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2023-10-06 09:56:58 -04:00
trop[bot]
2ac8897896 fix: toggling DevTools while minimized on Windows (#40118) 
fix: toggling devtools while minimized on Windows

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2023-10-06 09:55:11 -04:00
George Xu
040f3be041 feat: expose app accessibility transparency settings api (#40073) 2023-10-04 16:36:27 -07:00
trop[bot]
7f53717e48 fix: propagate layout call to all children of InspectableWebContentsViewViews (#40036) 
Propagate layout call to all children of InspectableWebContentsViewViews.

When BrowserView bounds are set from js, those might not trigger layout
immediately, sometimes propagating InvalidateLayout call to parent.
View is marked as needing layout, expecting to receive it from parent on
next layout call. The problem is that BrowserView's view is added as child
of InspectableWebContentsViews which does not call setBounds (which
would trigger layout) on all of it's children when doing it's layout,
so it skips propagating Layout call to its children BrowserViews views,
even though those were marked as needing layout.
Call base class View::Layout which will iterate over views' children
and call Layout on those that were marked as needing them.

Fixes #39993.

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Marek Haranczyk <marek@openfin.co>
 2023-09-28 18:55:06 -04:00
trop[bot]
1091ba2bd2 fix: rounded corners on vibrant macOS modals (#39998) 
* fix: rounded corners on vibrant macOS modals

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

* Update shell/browser/native_window_mac.mm

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

* Update shell/browser/native_window_mac.mm

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

* Update shell/browser/native_window_mac.mm

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
 2023-09-28 12:49:47 -04:00
trop[bot]
d7da2b9561 feat: support chrome.scripting extension APIs (#39676) 
feat: support chrome.scripting extension APIs

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2023-09-28 11:29:05 -04:00
trop[bot]
13bdefa549 feat: enable dark mode on GTK UIs (#40011) 
feat: port DarkModeManagerLinux

This is needed after https://bugs.chromium.org/p/chromium/issues/detail?id=998903
and replaces the previous workaround to detect dark mode on GTK.
Detect system dark theme preference via xdg settings portal:
https://flatpak.github.io/xdg-desktop-portal/#gdbus-org.freedesktop.portal.Settings

Closes: https://github.com/electron/electron/issues/38961
Closes: https://github.com/electron/electron/issues/28838

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Robert Günzler <r@gnzler.io>
 2023-09-28 10:33:05 +02:00
trop[bot]
9c2984f7b5 build: fix with enable_pdf_viewer = false (#39999) 
build: fix with enable_pdf_viewer = false

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2023-09-27 19:33:58 +02:00
trop[bot]
70231825c7 refactor: use type enum in file stats for asar archive (#39969) 
refactor: use type enum in file stats for asar archive (#39889)

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Milan Burda <milan.burda@gmail.com>
 2023-09-25 09:54:40 -04:00
trop[bot]
985f0a441d fix: app.runningUnderARM64Translation() always returning true on Windows ARM64 (#39932) 
fix: app.runningUnderARM64Translation() always returning true on ARM64

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Milan Burda <milan.burda@gmail.com>
 2023-09-23 10:01:44 +02:00
Shelley Vohr
77da40381c fix: ensure BrowserView bounds are always relative to window (#39850) 2023-09-14 10:39:46 -04:00
trop[bot]
4e9c583230 fix: keyCodes being incorrectly converted in webContents.sendInputEvent() (#39821) 
fix: sendInputEvent keyCodes being incorrectly converted

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2023-09-12 16:03:39 +02:00
trop[bot]
6ecae84da3 fix: ensure app load is limited to real asar files when appropriate (#39808) 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
 2023-09-11 21:16:56 -07:00
trop[bot]
eda2ceda1e fix: fullscreen crashing with no roundedCorners and no frame (#39795) 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2023-09-11 14:16:42 +02:00
trop[bot]
01aafab563 fix: prevent errors when extensions listen for chrome.tabs events (#39772) 
* fix: prevent errors when extensions listen for chrome.tabs events

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

* chore: mark events unsupported in Electron

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2023-09-11 09:37:13 +02:00
trop[bot]
325549ffce fix: make titlebar opaque while fullscreen (#39780) 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
 2023-09-08 17:07:10 -07:00
trop[bot]
a3acea9fd6 fix: devtools allow restoring saved dock state on Windows (#39768) 
* fix: devtools allow restoring saved dock state on Windows

Co-authored-by: deepak1556 <hop2deep@gmail.com>

* chore: address feedback

Co-authored-by: deepak1556 <hop2deep@gmail.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
 2023-09-07 12:27:46 +02:00
trop[bot]
81bd81667c feat: add more extensions manifest key options (#39673) 
feat: add more manifest key options

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2023-08-31 10:38:54 -04:00
trop[bot]
1ddffe909e feat: enable WaylandWindowDecorations by default (#39645) 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Athul Iddya <athul@iddya.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
 2023-08-31 10:37:31 -04:00
trop[bot]
1b9842b9b5 fix: ensure windows respect fullscreenability with different resizability values (#39641) 
* fix: ensure child windows respect fullscreenability/resizability when parent is fullscreen

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

* test: add an extra resize test

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2023-08-28 11:05:05 +09:00
trop[bot]
bf1dbaffcc feat: allow headers to be sent with webContents.downloadURL() (#39562) 
feat: allow headers to be sent with webContents.downloadURL()

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2023-08-24 11:06:51 -04:00
trop[bot]
a6649ffb61 fix: instantiate tab video tracks from BrowserCaptureMediaStreamTrack (#39618) 
return BrowserCaptureMediaStreamTrack instead of MediaStreamTrack

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: brhenrique <bruno.d@miro.com>
 2023-08-23 09:54:54 -04:00
trop[bot]
5da1b91546 fix: chrome.tabs 'url' and 'title' are privileged information (#39607) 
fix: tabs url and title are privileged information

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2023-08-22 17:28:57 +02:00
trop[bot]
1047532f1d fix: dangling raw_ptr in ElectronBrowserMainParts dtor (#39594) 
* fix: dangling raw_ptr in ElectronBrowserMainParts dtor

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* fixup! fix: dangling raw_ptr in ElectronBrowserMainParts dtor

Browser::WhenReady() holds a reference to JsEnv isolate so must come after

Co-authored-by: Charles Kerr <charles@charleskerr.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
 2023-08-21 15:54:27 +02:00
trop[bot]
6838404ecb fix: explorer restart does not recreated thumbnail toolbar buttons (#39587) 
fix: explorer restart does not recreated thumbnail toolbar buttons.

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: harada <harada@thinkridge.com>
 2023-08-21 17:03:02 +09:00
trop[bot]
ee01054bb5 fix: use tiled edges to calculate frame inset sizes in Linux (#39571) 
Adapt to the window frame size calculation changes in CL 3970920 by
setting the inset sizes to 0 for tiled edges.

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Athul Iddya <athul@iddya.com>
 2023-08-21 10:50:46 +09:00
trop[bot]
2e27e273ed fix: destruction order of js env fields (#39548) 
isolate_ depends on isolate_holder_ and so must be destroyed first.

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
 2023-08-17 11:03:15 +02:00
trop[bot]
04994de9e6 feat: support dns-result-order Node.js cli flag (#39501) 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
 2023-08-16 14:07:15 -04:00
trop[bot]
9dea18c1db fix: crash when calling BrowserWindow.moveTop() on modal children (#39527) 
fix: crash when calling moveTop() on modal children

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2023-08-16 09:56:33 -05:00
trop[bot]
3d760afa36 refactor: clean up Node.js cli arg parsing (#39510) 
* refactor: clean up Node.js arg parsing

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

* chore: feedback from review

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2023-08-16 09:45:06 +02:00
trop[bot]
64c5505b36 refactor: update WebContentsZoomController (#39495) 
refactor: update WebContentsZoomController

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2023-08-15 12:18:37 +02:00
electron-roller[bot]
0a478f9ef0 chore: bump chromium to 116.0.5845.82 (26-x-y) (#39458) 
* chore: bump chromium in DEPS to 116.0.5845.82

* chore: update patches

* fix: set allowFileAccess on devtools extensions correctly

Ref: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4714725

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
 2023-08-14 16:37:11 +02:00
trop[bot]
ceb5230395 fix: use nested run loop in clipboard.readImage (#39487) 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
 2023-08-14 14:49:17 +02:00
trop[bot]
5f1ada46f5 feat: support minimum_chrome_version manifest key (#39357) 
feat: support minimum_chrome_version extension key

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2023-08-14 10:06:41 +02:00
trop[bot]
ca899eb3cb feat: add support for chrome.tabs.query (#39431) 
* feat: add support for tabs.query

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

* fix: scope to webContents in current session

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

* test: add test for session behavior

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2023-08-14 10:05:59 +02:00
trop[bot]
c709e04bed chore: update _api_features manifest requirements (#39436) 
chore: update api_resources manifest requirements

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2023-08-14 10:03:52 +02:00
trop[bot]
f9e35e4aaa feat: allow more Node.js cli flags in main process (#39373) 
* feat: allow more Node.js cli flags in main process

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

* docs: update cli switch documentation

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2023-08-09 19:27:22 -04:00
Shelley Vohr
d2ca670f3f fix: macOS tray button selection with VoiceOver (#39439) 2023-08-09 21:41:43 +02:00
trop[bot]
4930f71a76 chore: update chrome.runtime.getPlatformInfo impl (#39416) 
chore: update chrome.runtime.getPlatformInfo impl

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2023-08-09 19:03:12 +02:00
trop[bot]
1c458c5eaf chore: remove i18n JSON spec (#39414) 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2023-08-09 09:36:46 -04:00
trop[bot]
fd8d4a8b94 fix: crash when closing active macOS native tab (#39410) 
fix: crash when closing current active macOS native tab

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
 2023-08-08 22:28:38 +02:00
trop[bot]
35126e06b6 fix: removeBrowserView draggable region removal (#39406) 
fix: removeBrowserView draggable region removal

Closes https://github.com/electron/electron/issues/39377.

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2023-08-08 13:49:14 +02:00