trop[bot]
1cd7a71bb1
fix: WCO maximize button visibility when non-maximizable ( #41807 )
...
fix: WCO button visibility when non-maximizable
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-04-09 19:20:32 -04:00
David Sanders
feb81b6841
build: add Markdown lint check for unescaped angle brackets ( #41800 )
2024-04-09 12:07:48 +02:00
trop[bot]
a3d9e4be58
build: add missing header for content::SyntheticGestureTarget ( #41798 )
...
IWYU: add missing header for `content::SyntheticGestureTarget`
GNU libstdc++ does not allow using std::unique_ptr on incomplete types,
leading to a compile error.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Bruno Pitrus <brunopitrus@hotmail.com >
2024-04-08 21:00:18 +02:00
Pedro Pontes
ec4683cd91
chore: cherry-pick 1 change from Release-2-M123 ( #41775 )
2024-04-05 13:03:04 -04:00
Erick Zhao
a02e0f0f02
docs: update node.js version for Electron 29 ( #41774 )
2024-04-04 16:25:34 -04:00
Alice Zhao
97eee463fa
feat: add navigationHistory.getEntryAtIndex(int index) method ( #41661 )
...
* feat: add `navigationHistory.getEntryAtIndex(int index)` method (#41577 )
* chore: remove code not related to this pr:
* test: fix flaky tests by replacing real urls with data urls
* test: remove hardcoded url
2024-04-04 13:09:19 -04:00
electron-roller[bot]
ed9a12cba7
chore: bump chromium to 122.0.6261.156 (29-x-y) ( #41765 )
...
* chore: bump chromium in DEPS to 122.0.6261.156
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-04-03 15:53:09 -04:00
trop[bot]
fe4d3a2484
docs: add missing headers option to ClientRequest options ( #41730 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2024-04-01 11:33:37 -04:00
Pedro Pontes
ad9a90ec53
chore: cherry-pick 8 changes from Release-1-M123 ( #41746 )
...
* chore: cherry-pick 8 changes from Release-1-M123
* chore: update patches
---------
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2024-04-01 11:20:34 -04:00
trop[bot]
8647232c48
feat(serial): allow Bluetooth ports to be requested by service class ID ( #41735 )
...
* feat(serial): allow Bluetooth ports to be requested by service class ID
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fix: bluetooth dependency
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-04-01 10:55:37 -04:00
trop[bot]
f9e28e3e50
fix: Storage.{get|set|clear}Cookies via CDP not working ( #41739 )
...
* fix: Storage.{get|set|clear}Cookies via CDP not working
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: simplify BrowserContext plumbing
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-03-29 09:51:43 -05:00
trop[bot]
3698f89205
fix: don't do self-destroy in LibnotifyNotification::Dismiss() ( #41707 )
...
Callers of Notification::Dismiss() assume that the notification
instance is not deleted after the call, but this was not the case
for LibnotifyNotification:
- Destroy() would get `this` deleted.
- notify_notification_close() in portal environment triggers
LibnotifyNotification::OnNotificationClosed(), and finally calls
Destroy()
This patch removes all Destroy() in Dismiss(), and adds a boolean
to tell whether notify_notification_close() is running, to avoid crash
under portal environment.
Fixes #40461 .
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: taoky <me@taoky.moe >
2024-03-28 12:10:03 +01:00
electron-roller[bot]
238cc80cef
chore: bump chromium to 122.0.6261.148 (29-x-y) ( #41711 )
...
chore: bump chromium in DEPS to 122.0.6261.148
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2024-03-27 10:59:00 -05:00
trop[bot]
3b025ec0c7
test: add test and api_feature definition for chrome.scripting.globalParams ( #41699 )
...
chore: add test and api_feature for chrome.scripting.globalParams
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-03-27 10:20:29 +01:00
trop[bot]
d2c14f1c6c
fix: crash on extension unload when script validation finishes ( #41701 )
...
https://chromium-review.googlesource.com/c/chromium/src/+/5225796
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-03-27 10:19:48 +01:00
Erick Zhao
0d3f50fc12
docs: backslash escape parametrized TypeScript types ( #41692 )
2024-03-26 12:28:42 +01:00
trop[bot]
d3da708f5c
fix: WTF-8 decoding issue in node:fs ( #41680 )
...
fix: WTF-8 decoding issue in node:fs
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-03-25 14:39:29 +01:00
trop[bot]
e64c123d80
fix: normalize path before calling showItemInFolder and openPath ( #41672 )
...
* fix: normalize path before calling ShowItemInFolder
Co-authored-by: piotrpdev <piotrpdev@gmail.com >
* fix: normalize path before calling OpenPath
Co-authored-by: piotrpdev <piotrpdev@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: piotrpdev <piotrpdev@gmail.com >
2024-03-24 20:14:53 +01:00
trop[bot]
9ce58dd0ea
ci: use CircleCI hosted macOS arm64 runners for testing ( #41655 )
...
* ci: use CircleCI hosted macOS arm64 runners for testing
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* chore: update patches
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2024-03-21 19:02:13 -04:00
trop[bot]
4da7bff05f
docs: nodejs trademark policy link broken ( #41653 )
...
* Fix broken Trademark Policy link
Co-authored-by: kghamilton89 <kghamilton@protonmail.com >
* add durable link
Per codebyter: https://github.com/electron/electron/pull/41558#discussion_r1522938560
Co-authored-by: Kenneth Gerald Hamilton <29099829+kghamilton89@users.noreply.github.com >
* chore: update patches
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: kghamilton89 <kghamilton@protonmail.com >
Co-authored-by: Kenneth Gerald Hamilton <29099829+kghamilton89@users.noreply.github.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2024-03-21 19:01:32 -04:00
electron-roller[bot]
53a7faa029
chore: bump chromium to 122.0.6261.139 (29-x-y) ( #41634 )
...
* chore: bump chromium in DEPS to 122.0.6261.139
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-03-21 09:39:44 -04:00
Pedro Pontes
d2177e4d08
chore: cherry-pick 1 change from Release-0-M123 ( #41631 )
2024-03-21 12:58:16 +01:00
trop[bot]
07f50757a3
fix: serial-port-added should respect filters ( #41636 )
...
fix: serial-port-added should respect filters
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-03-21 12:57:07 +01:00
trop[bot]
98283d1dae
fix: missing badge text on Windows ( #41628 )
...
https://chromium-review.googlesource.com/c/chromium/src/+/5053607
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-03-19 11:36:21 -07:00
trop[bot]
d0fdc28c0e
fix: account for potentially swapped FrameTreeNodeId in WebFrameMain ( #41593 )
...
fix: account for potentially swapped FrameTreeNodeId in WebFrameMain
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-03-14 13:02:40 -04:00
electron-roller[bot]
99dd9e2138
chore: bump chromium to 122.0.6261.130 (29-x-y) ( #41598 )
...
chore: bump chromium in DEPS to 122.0.6261.130
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2024-03-14 10:58:47 -04:00
electron-roller[bot]
c5a2873f8f
chore: bump chromium to 122.0.6261.129 (29-x-y) ( #41583 )
...
chore: bump chromium in DEPS to 122.0.6261.129
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2024-03-13 14:15:29 -04:00
Keeley Hammond
1e34cdda96
fix: remove DXDiag telemetry code ( #41574 )
...
* fix: remove dxdiag telemetry
* fix: update methods in GPU info manager
* fix: update gpu_notify_when_dxdiag_request_fails
2024-03-12 21:51:20 -07:00
Calvin
880aee0aa7
chore: cherry-pick 2607ddacd643 from chromium ( #41573 )
...
* chore: cherry-pick 2607ddacd643 from chromium
* chore: update patches
---------
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2024-03-12 16:17:11 -07:00
trop[bot]
c00489396b
fix: chrome://process-internals failing to load ( #41542 )
...
fix: chrome://process-internals failing to load
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-03-12 20:35:47 +01:00
trop[bot]
30587d9700
docs: nativeImage api cleanup ( #41569 )
...
* docs: `nativeImage` api cleanup
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* Update docs/api/native-image.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* Update native-image.md
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* Update docs/api/native-image.md
Co-authored-by: Felix Rieseberg <fr@makenotion.com >
Co-authored-by: Erick Zhao <erick@hotmail.ca >
* Update link to app icon
Co-authored-by: Alice Zhao <66543449+alicelovescake@users.noreply.github.com >
Co-authored-by: Erick Zhao <erick@hotmail.ca >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2024-03-12 19:41:48 +01:00
trop[bot]
ede0ebcc73
docs: Update code signing documentation ( #41554 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Felix Rieseberg <fr@makenotion.com >
2024-03-12 12:45:38 -04:00
electron-roller[bot]
5966b42ac5
chore: bump chromium to 122.0.6261.112 (29-x-y) ( #41552 )
...
chore: bump chromium in DEPS to 122.0.6261.112
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2024-03-08 14:31:35 -05:00
John Kleinschmidt
33e61a19ef
test: disable CapturableScreen tests on Windows x64 ( #41544 )
...
* test: disable CapturableScreen tests on Windows x64
(cherry picked from commit 60a288a2cad545ae049b
2024-03-08 09:29:28 -05:00
trop[bot]
a90c5b1b08
docs: correct release timeline inaccuracy ( #41516 )
...
docs: correct timeline inaccuracy
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-03-07 11:38:05 +01:00
electron-roller[bot]
06e01e5b76
chore: bump chromium to 122.0.6261.111 (29-x-y) ( #41532 )
...
chore: bump chromium in DEPS to 122.0.6261.111
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2024-03-07 10:17:44 +01:00
trop[bot]
96d053677d
chore: add missing gin::Wrappable GetTypeName overrides ( #41530 )
...
chore: add missing gin::Wrappable GetTypeName overrides
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-03-06 11:02:30 -05:00
trop[bot]
8fe14665a0
fix: user-did-{resign|become}-active events on macOS ( #41527 )
...
fix: user-did-{resign|become}-active events on macOS
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-03-06 15:57:59 +01:00
Cheng Zhao
c9384a609e
chore: update src_preload_function_for_environment.patch ( #41501 )
2024-03-04 10:00:39 -05:00
trop[bot]
fd2620bda4
fix: webContents.print options should be optional ( #41479 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-03-01 17:08:55 -05:00
electron-roller[bot]
dc04802296
chore: bump chromium to 122.0.6261.95 (29-x-y) ( #41489 )
...
chore: bump chromium in DEPS to 122.0.6261.95
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2024-03-01 16:52:04 -05:00
electron-roller[bot]
90ca4e5f80
chore: bump chromium to 122.0.6261.94 (29-x-y) ( #41451 )
...
* chore: bump chromium in DEPS to 122.0.6261.94
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-02-28 11:32:54 -08:00
trop[bot]
5013150cfd
ci: add logging to uploading to GitHub releases ( #41458 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2024-02-28 12:54:24 +09:00
electron-roller[bot]
2d9c5a62c6
chore: bump chromium to 122.0.6261.70 (29-x-y) ( #41446 )
...
chore: bump chromium in DEPS to 122.0.6261.70
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2024-02-27 15:12:14 -05:00
electron-roller[bot]
23f690ffd0
chore: bump chromium to 122.0.6261.69 (29-x-y) ( #41425 )
...
* chore: bump chromium in DEPS to 122.0.6261.69
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2024-02-26 11:35:30 +01:00
trop[bot]
8f4e94694e
chore: fix import from patches.py in script/lib/git.py ( #41437 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Milan Burda <milan.burda@gmail.com >
2024-02-26 10:05:30 +01:00
trop[bot]
af47434dc8
feat: add support for configuring system network context proxies ( #41416 )
...
* feat: add support for configuring system network context proxies
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* chore: add specs
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* chore: fix lint
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* fix: address review feedback
Co-authored-by: deepak1556 <hop2deep@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2024-02-23 14:56:30 -06:00
trop[bot]
8ab99e2d8e
refactor: prefer using base::NoDestructor to base::{Singleton,LazyInstance} ( #41423 )
...
refactor: prefer using base::NoDestructor to base::{Singleton,LazyInstance}
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2024-02-23 09:02:58 -06:00
trop[bot]
ffcccdcf37
perf: omit unnecessary work from ElectronRenderFrameObserver::ShouldNotifyClient() ( #41381 )
...
perf: omit unnecessary work from ElectronRenderFrameObserver::ShouldNotifyClient()
- (perf) GetBlinkPreferences() returns a const&, so we can use that
reference instead of making a temporary copy
- (perf) Don't create url object unless it's needed.
- (refactor) Move is_main_world() and is_isolated_world() from the
header into an anonymous namespace in the .cc file so they can
be inlined and made constexpr
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2024-02-22 11:51:37 -05:00
trop[bot]
ce2ac1c0c2
fix: use ScreenCaptureKit exclusively on macOS 14.4 and higher ( #41403 )
...
This fixes a nasty warning / permission dialog that pops up to end-users
when consuming legacy APIs. Chrome has flipped these flags via field trials
as have other Electron apps. It should just be the default.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org >
2024-02-22 14:31:53 +01:00
