Bump v20.0.0-nightly.20220425

This reverts commit f48a921d14.

.circleci/config.yml

@@ -14,7 +14,7 @@ parameters:
     type: boolean
     default: false
   
-  upload-to-storage:
+  upload-to-s3:
     type: string
     default: '1'
 

.github/workflows/electron_woa_testing.yml

@@ -1,178 +0,0 @@
-name: Electron WOA Testing
-
-on:
-  push:    
-    branches: '**'
-  workflow_dispatch:
-    inputs:
-      appveyor_job_id:
-        description: 'Job Id of Appveyor WOA job to test'
-        type: text
-        required: true
-
-jobs:
-  electron-woa-init:
-    if: ${{ github.event_name == 'push' && github.repository == 'electron/electron' }}
-    runs-on: ubuntu-latest
-    steps:
-        - name: Dummy step for push event
-          run: |
-            echo "This job is a needed initialization step for Electron WOA testing.  Another test result will appear once the electron-woa-testing build is done."
-
-  electron-woa-testing:    
-    if: ${{ github.event_name == 'workflow_dispatch' && github.repository == 'electron/electron' }}    
-    runs-on: [self-hosted, woa]  
-    permissions:
-      checks: write
-      pull-requests: write
-    steps:
-    - uses: LouisBrunner/checks-action@v1.1.1
-      with:
-        token: ${{ secrets.GITHUB_TOKEN }}
-        name: electron-woa-testing
-        status: in_progress
-        details_url: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}    
-        output: |
-          {"summary":"Test In Progress","text_description":"See job details here: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"}        
-    - name: Clean Workspace
-      run: |
-        Remove-Item * -Recurse -Force
-      shell: powershell
-    - name: Checkout
-      uses: actions/checkout@v3
-      with:
-        path: src\electron
-        fetch-depth: 0
-    - name: Yarn install
-      run: |
-        cd src\electron
-        node script/yarn.js install --frozen-lockfile
-    - name: Download and extract dist.zip for test
-      run: |
-        $localArtifactPath = "$pwd\dist.zip"
-        $serverArtifactPath = "https://ci.appveyor.com/api/buildjobs/${{ inputs.appveyor_job_id }}/artifacts/dist.zip"
-        Invoke-RestMethod -Method Get -Uri $serverArtifactPath -OutFile $localArtifactPath -Headers @{ "Authorization" = "Bearer ${{ secrets.APPVEYOR_TOKEN }}" }
-        & "${env:ProgramFiles(x86)}\7-Zip\7z.exe" x -osrc\out\Default -y $localArtifactPath
-      shell: powershell
-    - name: Download and extract native test executables for test
-      run: |
-        $localArtifactPath = "src\out\Default\shell_browser_ui_unittests.exe"
-        $serverArtifactPath = "https://ci.appveyor.com/api/buildjobs/${{ inputs.appveyor_job_id }}/artifacts/shell_browser_ui_unittests.exe"
-        Invoke-RestMethod -Method Get -Uri $serverArtifactPath -OutFile $localArtifactPath -Headers @{ "Authorization" = "Bearer ${{ secrets.APPVEYOR_TOKEN }}" }
-      shell: powershell
-    - name: Download and extract ffmpeg.zip for test
-      run: |
-        $localArtifactPath = "$pwd\ffmpeg.zip"
-        $serverArtifactPath = "https://ci.appveyor.com/api/buildjobs/${{ inputs.appveyor_job_id }}/artifacts/ffmpeg.zip"
-        Invoke-RestMethod -Method Get -Uri $serverArtifactPath -OutFile $localArtifactPath -Headers @{ "Authorization" = "Bearer ${{ secrets.APPVEYOR_TOKEN }}" }
-        & "${env:ProgramFiles(x86)}\7-Zip\7z.exe" x -osrc\out\ffmpeg $localArtifactPath
-      shell: powershell
-    - name: Download node headers for test
-      run: |
-        $localArtifactPath = "src\node_headers.zip"
-        $serverArtifactPath = "https://ci.appveyor.com/api/buildjobs/${{ inputs.appveyor_job_id }}/artifacts/node_headers.zip"
-        Invoke-RestMethod -Method Get -Uri $serverArtifactPath -OutFile $localArtifactPath -Headers @{ "Authorization" = "Bearer ${{ secrets.APPVEYOR_TOKEN }}" }
-        cd src
-        & "${env:ProgramFiles(x86)}\7-Zip\7z.exe" x -y node_headers.zip
-      shell: powershell
-    - name: Download electron.lib for test
-      run: |
-        $localArtifactPath = "src\out\Default\electron.lib"
-        $serverArtifactPath = "https://ci.appveyor.com/api/buildjobs/${{ inputs.appveyor_job_id }}/artifacts/electron.lib"
-        Invoke-RestMethod -Method Get -Uri $serverArtifactPath -OutFile $localArtifactPath -Headers @{ "Authorization" = "Bearer ${{ secrets.APPVEYOR_TOKEN }}" }
-      shell: powershell
-    # Uncomment the following block if pdb files are needed to debug issues
-    # - name: Download pdb files for detailed stacktraces
-    #   if: ${{ github.event_name == 'workflow_dispatch' }}
-    #   run: |
-    #     try {
-    #       $localArtifactPath = "src\pdb.zip"
-    #       $serverArtifactPath = "https://ci.appveyor.com/api/buildjobs/${{ inputs.appveyor_job_id }}/artifacts/pdb.zip"
-    #       Invoke-RestMethod -Method Get -Uri $serverArtifactPath -OutFile $localArtifactPath -Headers @{ "Authorization" = "Bearer ${{ secrets.APPVEYOR_TOKEN }}" }
-    #       cd src
-    #       & "${env:ProgramFiles(x86)}\7-Zip\7z.exe" x -y pdb.zip
-    #     } catch {
-    #       Write-Host "There was an exception encountered while downloading pdb files:" $_.Exception.Message
-    #     } finally {
-    #       $global:LASTEXITCODE = 0
-    #     }
-    #   shell: powershell
-    - name: Setup node headers
-      run: |
-        New-Item src\out\Default\gen\node_headers\Release -Type directory
-        Copy-Item -path src\out\Default\electron.lib -destination src\out\Default\gen\node_headers\Release\node.lib
-      shell: powershell
-    - name: Run Electron Main process tests
-      run: |
-        cd src
-        set npm_config_nodedir=%cd%\out\Default\gen\node_headers
-        set npm_config_arch=arm64
-        cd electron
-        node script/yarn test --runners=main --enable-logging --disable-features=CalculateNativeWinOcclusion  
-      env:
-        ELECTRON_ENABLE_STACK_DUMPING: true
-        ELECTRON_OUT_DIR: Default
-        IGNORE_YARN_INSTALL_ERROR: 1
-        ELECTRON_TEST_RESULTS_DIR: junit
-        MOCHA_MULTI_REPORTERS: 'mocha-junit-reporter, tap'
-        MOCHA_REPORTER: mocha-multi-reporters
-        ELECTRON_SKIP_NATIVE_MODULE_TESTS: true
-    - name: Run Electron Remote based tests
-      if: ${{ success() || failure() }}
-      run: |
-        cd src
-        set npm_config_nodedir=%cd%\out\Default\gen\node_headers
-        set npm_config_arch=arm64
-        cd electron
-        node script/yarn test --runners=remote --enable-logging --disable-features=CalculateNativeWinOcclusion
-      env:
-        ELECTRON_OUT_DIR: Default
-        IGNORE_YARN_INSTALL_ERROR: 1
-        ELECTRON_TEST_RESULTS_DIR: junit
-        MOCHA_MULTI_REPORTERS: 'mocha-junit-reporter, tap'
-        MOCHA_REPORTER: mocha-multi-reporters
-        ELECTRON_SKIP_NATIVE_MODULE_TESTS: true
-    - name: Verify ffmpeg
-      run: |
-        cd src
-        echo "Verifying non proprietary ffmpeg"
-        python electron\script\verify-ffmpeg.py --build-dir out\Default --source-root %cd% --ffmpeg-path out\ffmpeg
-      shell: cmd
-    - name: Kill processes left running from last test run
-      if: ${{ always() }}
-      run: |
-        Get-Process | Where Name -Like "electron*" | Stop-Process
-        Get-Process | Where Name -Like "msedge*" | Stop-Process
-      shell: powershell
-    - name: Delete user app data directories
-      if: ${{ always() }}
-      run: |
-        Remove-Item -path $env:APPDATA/Electron* -Recurse -Force -ErrorAction Ignore
-      shell: powershell
-    - uses: LouisBrunner/checks-action@v1.1.1
-      if: ${{ success() }}
-      with:
-        token: ${{ secrets.GITHUB_TOKEN }}
-        name: electron-woa-testing
-        conclusion: "${{ job.status }}"
-        details_url: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
-        output: |
-          {"summary":"${{ job.status }}","text_description":"See job details here: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"}
-    - uses: LouisBrunner/checks-action@v1.1.1
-      if: ${{ success() }}
-      with:
-        token: ${{ secrets.GITHUB_TOKEN }}
-        name: electron-woa-testing
-        conclusion: "${{ job.status }}"
-        details_url: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
-        output: |
-          {"summary":"Job Succeeded","text_description":"See job details here: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"}          
-    - uses: LouisBrunner/checks-action@v1.1.1
-      if: ${{ ! success() }}
-      with:
-        token: ${{ secrets.GITHUB_TOKEN }}
-        name: electron-woa-testing
-        conclusion: "${{ job.status }}"
-        details_url: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
-        output: |
-          {"summary":"Job Failed","text_description":"See job details here: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"}                    

.markdownlint.json

@@ -23,5 +23,7 @@
     "br_spaces": 0
   },
   "single-h1": false,
-  "no-inline-html": false
+  "no-inline-html": {
+    "allowed_elements": ["br"]
+  }
 }

BUILD.gn

@@ -79,11 +79,15 @@ if (is_linux) {
     ]
   }
 
+  # Generates electron_gtk_stubs.h header which contains
+  # stubs for extracting function ptrs from the gtk library.
+  # Function signatures for which stubs are required should be
+  # declared in electron_gtk.sigs, currently this file contains
+  # signatures for the functions used with native file chooser
+  # implementation. In future, this file can be extended to contain
+  # gtk4 stubs to switch gtk version in runtime.
   generate_stubs("electron_gtk_stubs") {
-    sigs = [
-      "shell/browser/ui/electron_gdk_pixbuf.sigs",
-      "shell/browser/ui/electron_gtk.sigs",
-    ]
+    sigs = [ "shell/browser/ui/electron_gtk.sigs" ]
     extra_header = "shell/browser/ui/electron_gtk.fragment"
     output_name = "electron_gtk_stubs"
     public_deps = [ "//ui/gtk:gtk_config" ]
@@ -362,11 +366,11 @@ source_set("electron_lib") {
     "shell/common/api:mojo",
     "//base:base_static",
     "//base/allocator:buildflags",
+    "//chrome:strings",
     "//chrome/app:command_ids",
     "//chrome/app/resources:platform_locale_settings",
     "//components/autofill/core/common:features",
     "//components/certificate_transparency",
-    "//components/embedder_support:browser_util",
     "//components/language/core/browser",
     "//components/net_log",
     "//components/network_hints/browser",
@@ -907,7 +911,10 @@ if (is_mac) {
       assert(defined(invoker.helper_name_suffix))
 
       output_name = electron_helper_name + invoker.helper_name_suffix
-      deps = [ ":electron_framework+link" ]
+      deps = [
+        ":electron_framework+link",
+        "//base/allocator:early_zone_registration_mac",
+      ]
       if (!is_mas_build) {
         deps += [ "//sandbox/mac:seatbelt" ]
       }
@@ -1067,6 +1074,7 @@ if (is_mac) {
       ":electron_app_plist",
       ":electron_app_resources",
       ":electron_fuses",
+      "//base/allocator:early_zone_registration_mac",
       "//electron/buildflags",
     ]
     if (is_mas_build) {
@@ -1273,10 +1281,6 @@ if (is_mac) {
       if (!is_component_build && is_component_ffmpeg) {
         configs += [ "//build/config/gcc:rpath_for_built_shared_libraries" ]
       }
-
-      if (is_linux) {
-        deps += [ "//sandbox/linux:chrome_sandbox" ]
-      }
     }
   }
 

DEPS

@@ -2,7 +2,7 @@ gclient_gn_args_from = 'src'
 
 vars = {
   'chromium_version':
-    '102.0.5005.167',
+    '102.0.4999.0',
   'node_version':
     'v16.14.2',
   'nan_version':

ELECTRON_VERSION

@@ -1 +1 @@
-19.0.15
+20.0.0-nightly.20220425

appveyor.yml

@@ -11,7 +11,7 @@
 #  - "TARGET_ARCH" Choose from {'ia32', 'x64', 'arm', 'arm64', 'mips64el'}.
 #      Is used in some publishing scripts, but does NOT affect the Electron binary.
 #      Must match 'target_cpu' passed to "GN_EXTRA_ARGS" and "NPM_CONFIG_ARCH" value.
-#  - "UPLOAD_TO_STORAGE" Set it to '1' upload a release to the Azure bucket.
+#  - "UPLOAD_TO_S3" Set it to '1' upload a release to the S3 bucket.
 #      Otherwise the release will be uploaded to the Github Releases.
 #      (The value is only checked if "ELECTRON_RELEASE" is defined.)
 #
@@ -23,10 +23,6 @@
 # https://www.appveyor.com/docs/build-configuration/#secure-variables
 # https://www.appveyor.com/docs/build-configuration/#custom-environment-variables
 
-# Uncomment these lines to enable RDP
-#on_finish:
-#  - ps: $blockRdp = $true; iex ((new-object net.webclient).DownloadString('https://raw.githubusercontent.com/appveyor/ci/master/scripts/enable-rdp.ps1'))
-
 version: 1.0.{build}
 build_cloud: electron-16-core
 image: vs2019bt-16.16.11
@@ -38,6 +34,16 @@ environment:
   MOCHA_REPORTER: mocha-multi-reporters
   MOCHA_MULTI_REPORTERS: mocha-appveyor-reporter, tap
   GOMA_FALLBACK_ON_AUTH_FAILURE: true
+notifications:
+  - provider: Webhook
+    url: https://electron-mission-control.herokuapp.com/rest/appveyor-hook
+    method: POST
+    headers:
+      x-mission-control-secret:
+        secure: 90BLVPcqhJPG7d24v0q/RRray6W3wDQ8uVQlQjOHaBWkw1i8FoA1lsjr2C/v1dVok+tS2Pi6KxDctPUkwIb4T27u4RhvmcPzQhVpfwVJAG9oNtq+yKN7vzHfg7k/pojEzVdJpQLzeJGcSrZu7VY39Q==
+    on_build_success: false
+    on_build_failure: true
+    on_build_status_changed: false
 build_script:
   - ps: >-
       if(($env:APPVEYOR_PULL_REQUEST_HEAD_REPO_NAME -split "/")[0] -eq ($env:APPVEYOR_REPO_NAME -split "/")[0]) {
@@ -174,16 +180,19 @@ build_script:
   - python %LOCAL_GOMA_DIR%\goma_ctl.py stat
   - python3 electron/build/profile_toolchain.py --output-json=out/Default/windows_toolchain_profile.json
   - 7z a node_headers.zip out\Default\gen\node_headers
+  # Temporarily disable symbol generation on 32-bit Windows due to failures  
   - ps: >-
-      if ($env:GN_CONFIG -eq 'release') {
+      if ($env:GN_CONFIG -eq 'release' -And $env:TARGET_ARCH -ne 'ia32') {
         # Needed for msdia140.dll on 64-bit windows
         $env:Path += ";$pwd\third_party\llvm-build\Release+Asserts\bin"
         ninja -C out/Default electron:electron_symbols
       }
   - ps: >-
       if ($env:GN_CONFIG -eq 'release') {
-        python electron\script\zip-symbols.py
-        appveyor-retry appveyor PushArtifact out/Default/symbols.zip
+        if ($env:TARGET_ARCH -ne 'ia32') {
+          python electron\script\zip-symbols.py
+          appveyor-retry appveyor PushArtifact out/Default/symbols.zip
+        }
       } else {
         # It's useful to have pdb files when debugging testing builds that are
         # built on CI.
@@ -220,17 +229,19 @@ deploy_script:
   - cd electron
   - ps: >-
       if (Test-Path Env:\ELECTRON_RELEASE) {
-        if (Test-Path Env:\UPLOAD_TO_STORAGE) {
-          Write-Output "Uploading Electron release distribution to azure"
-          & python script\release\uploaders\upload.py --verbose --upload_to_storage
+        if (Test-Path Env:\UPLOAD_TO_S3) {
+          Write-Output "Uploading Electron release distribution to s3"
+          & python script\release\uploaders\upload.py --verbose --upload_to_s3
         } else {
           Write-Output "Uploading Electron release distribution to github releases"
           & python script\release\uploaders\upload.py --verbose
         }
       } elseif (Test-Path Env:\TEST_WOA) {
-        node script/release/ci-release-build.js --job=electron-woa-testing --ci=GHA --appveyorJobId=$env:APPVEYOR_JOB_ID $env:APPVEYOR_REPO_BRANCH
+        node script/release/ci-release-build.js --job=electron-woa-testing --ci=VSTS --armTest --appveyorJobId=$env:APPVEYOR_JOB_ID $env:APPVEYOR_REPO_BRANCH
       }
 on_finish:
+  # Uncomment this lines to enable RDP
+  #- ps: $blockRdp = $true; iex ((new-object net.webclient).DownloadString('https://raw.githubusercontent.com/appveyor/ci/master/scripts/enable-rdp.ps1'))
   - cd ..
   - if exist out\Default\windows_toolchain_profile.json ( appveyor-retry appveyor PushArtifact out\Default\windows_toolchain_profile.json )
   - if exist out\Default\dist.zip (appveyor-retry appveyor PushArtifact out\Default\dist.zip)
@@ -245,4 +256,5 @@ on_finish:
       if ((Test-Path "pdb.zip") -And ($env:GN_CONFIG -ne 'release')) {
         appveyor-retry appveyor PushArtifact pdb.zip
       }
+
   - if exist electron\electron.log ( appveyor-retry appveyor PushArtifact electron\electron.log )

azure-pipelines-arm.yml

@@ -0,0 +1,121 @@
+steps:
+- task: CopyFiles@2
+  displayName: 'Copy Files to: src/electron'
+  inputs:
+    TargetFolder: src/electron
+
+- bash: |
+    cd src/electron
+    node script/yarn.js install --frozen-lockfile
+  displayName: 'Yarn install'
+
+- bash: |
+    export ZIP_DEST=$PWD/src/out/Default
+    echo "##vso[task.setvariable variable=ZIP_DEST]$ZIP_DEST"
+    mkdir -p $ZIP_DEST
+    cd src/electron
+    node script/download-circleci-artifacts.js --buildNum=$CIRCLE_BUILD_NUM --name=dist.zip --dest=$ZIP_DEST
+    cd $ZIP_DEST
+    unzip -o dist.zip
+    xattr -cr Electron.app    
+  displayName: 'Download and unzip dist files for test'
+  env:
+    CIRCLE_TOKEN: $(CIRCLECI_TOKEN)
+
+- bash: |
+    export FFMPEG_ZIP_DEST=$PWD/src/out/ffmpeg
+    mkdir -p $FFMPEG_ZIP_DEST
+    cd src/electron
+    node script/download-circleci-artifacts.js --buildNum=$CIRCLE_BUILD_NUM --name=ffmpeg.zip --dest=$FFMPEG_ZIP_DEST
+    cd $FFMPEG_ZIP_DEST
+    unzip -o ffmpeg.zip
+  displayName: 'Download and unzip ffmpeg for test'
+  env:
+    CIRCLE_TOKEN: $(CIRCLECI_TOKEN)
+
+- bash: |
+   export NODE_HEADERS_DEST=$PWD/src/out/Default/gen
+   mkdir -p $NODE_HEADERS_DEST
+   cd src/electron
+   node script/download-circleci-artifacts.js --buildNum=$CIRCLE_BUILD_NUM --name=node_headers.tar.gz --dest=$NODE_HEADERS_DEST
+   cd $NODE_HEADERS_DEST
+   tar xzf node_headers.tar.gz
+  displayName: 'Download and untar node header files for test'
+  env:
+    CIRCLE_TOKEN: $(CIRCLECI_TOKEN)
+
+- bash: |
+   export CROSS_ARCH_SNAPSHOTS=$PWD/src/out/Default/cross-arch-snapshots
+   mkdir -p $CROSS_ARCH_SNAPSHOTS
+   cd src/electron
+   node script/download-circleci-artifacts.js --buildNum=$CIRCLE_BUILD_NUM --name=cross-arch-snapshots/snapshot_blob.bin --dest=$CROSS_ARCH_SNAPSHOTS
+   node script/download-circleci-artifacts.js --buildNum=$CIRCLE_BUILD_NUM --name=cross-arch-snapshots/v8_context_snapshot.arm64.bin --dest=$CROSS_ARCH_SNAPSHOTS
+  displayName: 'Download cross arch snapshot files'
+  env:
+    CIRCLE_TOKEN: $(CIRCLECI_TOKEN)
+
+- bash: |
+    cd src
+    export ELECTRON_OUT_DIR=Default
+    export npm_config_arch=arm64
+    (cd electron && node script/yarn test --enable-logging --runners main)
+  displayName: 'Run Electron main tests'
+  timeoutInMinutes: 20
+  env:
+    ELECTRON_DISABLE_SECURITY_WARNINGS: 1
+    IGNORE_YARN_INSTALL_ERROR: 1
+    ELECTRON_TEST_RESULTS_DIR: junit
+
+- bash: |
+    cd src
+    export ELECTRON_OUT_DIR=Default
+    export npm_config_arch=arm64
+    (cd electron && node script/yarn test --enable-logging --runners remote)
+  displayName: 'Run Electron remote tests'
+  timeoutInMinutes: 20
+  condition: succeededOrFailed()
+  env:
+    ELECTRON_DISABLE_SECURITY_WARNINGS: 1
+    IGNORE_YARN_INSTALL_ERROR: 1
+    ELECTRON_TEST_RESULTS_DIR: junit
+
+- bash: |
+    cd src
+    python electron/script/verify-ffmpeg.py --source-root "$PWD" --build-dir out/Default --ffmpeg-path out/ffmpeg
+  displayName: Verify non proprietary ffmpeg
+  timeoutInMinutes: 5
+  condition: succeededOrFailed()
+  env:
+    TARGET_ARCH: arm64
+
+- bash: |
+    cd src
+    echo Verify cross arch snapshot
+    python electron/script/verify-mksnapshot.py --source-root "$PWD" --build-dir out/Default --snapshot-files-dir $PWD/out/Default/cross-arch-snapshots
+  displayName: Verify cross arch snapshot
+  timeoutInMinutes: 5
+  condition: succeededOrFailed()
+
+- task: PublishTestResults@2
+  displayName: 'Publish Test Results'
+  inputs:
+    testResultsFiles: '*.xml'
+
+    searchFolder: '$(System.DefaultWorkingDirectory)/src/junit/'
+
+  condition: succeededOrFailed()
+
+- bash: killall Electron || echo "No Electron processes left running"
+  displayName: 'Kill processes left running from last test run'
+  condition: always()
+
+- bash: |
+    rm -rf ~/Library/Application\ Support/Electron*
+    rm -rf ~/Library/Application\ Support/electron*
+  displayName: 'Delete user app data directories'
+  condition: always()
+
+- task: mspremier.PostBuildCleanup.PostBuildCleanup-task.PostBuildCleanup@3
+  displayName: 'Clean Agent Directories'
+
+  condition: always()

azure-pipelines-woa.yml

@@ -0,0 +1,130 @@
+workspace:
+  clean: all
+
+steps:
+- checkout: self
+  path: src\electron
+
+- script: |
+    node script/yarn.js install --frozen-lockfile
+  displayName: 'Yarn install'
+
+- powershell: |
+    $localArtifactPath = "$pwd\dist.zip"
+    $serverArtifactPath = "$env:APPVEYOR_URL/buildjobs/$env:APPVEYOR_JOB_ID/artifacts/dist.zip"
+    Invoke-RestMethod -Method Get -Uri $serverArtifactPath -OutFile $localArtifactPath -Headers @{ "Authorization" = "Bearer $env:APPVEYOR_TOKEN" }
+    & "${env:ProgramFiles(x86)}\7-Zip\7z.exe" x -o$(Pipeline.Workspace)\src\out\Default -y $localArtifactPath
+  displayName: 'Download and extract dist.zip for test'
+  env:
+    APPVEYOR_TOKEN: $(APPVEYOR_TOKEN)
+
+- powershell: |
+    $localArtifactPath = "$(Pipeline.Workspace)\src\out\Default\shell_browser_ui_unittests.exe"
+    $serverArtifactPath = "$env:APPVEYOR_URL/buildjobs/$env:APPVEYOR_JOB_ID/artifacts/shell_browser_ui_unittests.exe"
+    Invoke-RestMethod -Method Get -Uri $serverArtifactPath -OutFile $localArtifactPath -Headers @{ "Authorization" = "Bearer $env:APPVEYOR_TOKEN" }
+  displayName: 'Download and extract native test executables for test'
+  env:
+    APPVEYOR_TOKEN: $(APPVEYOR_TOKEN)
+
+- powershell: |
+    $localArtifactPath = "$pwd\ffmpeg.zip"
+    $serverArtifactPath = "$env:APPVEYOR_URL/buildjobs/$env:APPVEYOR_JOB_ID/artifacts/ffmpeg.zip"
+    Invoke-RestMethod -Method Get -Uri $serverArtifactPath -OutFile $localArtifactPath -Headers @{ "Authorization" = "Bearer $env:APPVEYOR_TOKEN" }
+    & "${env:ProgramFiles(x86)}\7-Zip\7z.exe" x -o$(Pipeline.Workspace)\src\out\ffmpeg $localArtifactPath
+  displayName: 'Download and extract ffmpeg.zip for test'
+  env:
+    APPVEYOR_TOKEN: $(APPVEYOR_TOKEN)
+
+- powershell: |
+    $localArtifactPath = "$(Pipeline.Workspace)\src\node_headers.zip"
+    $serverArtifactPath = "$env:APPVEYOR_URL/buildjobs/$env:APPVEYOR_JOB_ID/artifacts/node_headers.zip"
+    Invoke-RestMethod -Method Get -Uri $serverArtifactPath -OutFile $localArtifactPath -Headers @{ "Authorization" = "Bearer $env:APPVEYOR_TOKEN" }
+    cd $(Pipeline.Workspace)\src
+    & "${env:ProgramFiles(x86)}\7-Zip\7z.exe" x -y node_headers.zip
+  displayName: 'Download node headers for test'
+  env:
+    APPVEYOR_TOKEN: $(APPVEYOR_TOKEN)
+
+- powershell: |
+    $localArtifactPath = "$(Pipeline.Workspace)\src\out\Default\electron.lib"
+    $serverArtifactPath = "$env:APPVEYOR_URL/buildjobs/$env:APPVEYOR_JOB_ID/artifacts/electron.lib"
+    Invoke-RestMethod -Method Get -Uri $serverArtifactPath -OutFile $localArtifactPath -Headers @{ "Authorization" = "Bearer $env:APPVEYOR_TOKEN" }
+  displayName: 'Download electron.lib for test'
+  env:
+    APPVEYOR_TOKEN: $(APPVEYOR_TOKEN)
+
+# Uncomment the following block if pdb files are needed to debug issues
+# - powershell: |
+#     try {
+#       $localArtifactPath = "$(Pipeline.Workspace)\src\pdb.zip"
+#       $serverArtifactPath = "$env:APPVEYOR_URL/buildjobs/$env:APPVEYOR_JOB_ID/artifacts/pdb.zip"
+#       Invoke-RestMethod -Method Get -Uri $serverArtifactPath -OutFile $localArtifactPath -Headers @{ "Authorization" = "Bearer $env:APPVEYOR_TOKEN" }
+#       cd $(Pipeline.Workspace)\src
+#       & "${env:ProgramFiles(x86)}\7-Zip\7z.exe" x -y pdb.zip
+#     } catch {
+#       Write-Host "There was an exception encountered while downloading pdb files:" $_.Exception.Message
+#     } finally {
+#       $global:LASTEXITCODE = 0
+#     }
+#   displayName: 'Download pdb files for detailed stacktraces'
+#   env:
+#     APPVEYOR_TOKEN: $(APPVEYOR_TOKEN)
+
+- powershell: |
+    New-Item $(Pipeline.Workspace)\src\out\Default\gen\node_headers\Release -Type directory
+    Copy-Item -path $(Pipeline.Workspace)\src\out\Default\electron.lib -destination $(Pipeline.Workspace)\src\out\Default\gen\node_headers\Release\node.lib
+  displayName: 'Setup node headers'
+
+- script: |
+    cd $(Pipeline.Workspace)\src
+    set npm_config_nodedir=%cd%\out\Default\gen\node_headers
+    set npm_config_arch=arm64
+    cd electron
+    node script/yarn test --runners=main --enable-logging --disable-features=CalculateNativeWinOcclusion
+  displayName: 'Run Electron Main process tests'
+  env:
+    ELECTRON_ENABLE_STACK_DUMPING: true
+    ELECTRON_OUT_DIR: Default
+    IGNORE_YARN_INSTALL_ERROR: 1
+    ELECTRON_TEST_RESULTS_DIR: junit
+    MOCHA_MULTI_REPORTERS: 'mocha-junit-reporter, tap'
+    MOCHA_REPORTER: mocha-multi-reporters
+
+- script: |
+    cd $(Pipeline.Workspace)\src
+    set npm_config_nodedir=%cd%\out\Default\gen\node_headers
+    set npm_config_arch=arm64
+    cd electron
+    node script/yarn test --runners=remote --enable-logging --disable-features=CalculateNativeWinOcclusion
+  displayName: 'Run Electron Remote based tests'
+  env:
+    ELECTRON_OUT_DIR: Default
+    IGNORE_YARN_INSTALL_ERROR: 1
+    ELECTRON_TEST_RESULTS_DIR: junit
+    MOCHA_MULTI_REPORTERS: 'mocha-junit-reporter, tap'
+    MOCHA_REPORTER: mocha-multi-reporters
+  condition: succeededOrFailed()
+
+- task: PublishTestResults@2
+  displayName: 'Publish Test Results'
+  inputs:
+    testResultsFiles: '*.xml'
+    searchFolder: '$(Pipeline.Workspace)/src/junit/'
+  condition: always()
+
+- script: |
+    cd $(Pipeline.Workspace)\src
+    echo "Verifying non proprietary ffmpeg"
+    python electron\script\verify-ffmpeg.py --build-dir out\Default --source-root %cd% --ffmpeg-path out\ffmpeg
+  displayName: 'Verify ffmpeg'
+
+- powershell: |
+    Get-Process | Where Name –Like "electron*" | Stop-Process
+    Get-Process | Where Name –Like "msedge*" | Stop-Process
+  displayName: 'Kill processes left running from last test run'
+  condition: always()
+
+- powershell: |
+    Remove-Item -path $env:APPDATA/Electron* -Recurse -Force -ErrorAction Ignore
+  displayName: 'Delete user app data directories'
+  condition: always()

build/args/all.gn

@@ -2,7 +2,7 @@ is_electron_build = true
 root_extra_deps = [ "//electron" ]
 
 # Registry of NMVs --> https://github.com/nodejs/node/blob/master/doc/abi_version_registry.json
-node_module_version = 106
+node_module_version = 107
 
 v8_promise_internal_field_count = 1
 v8_embedder_string = "-electron.0"
@@ -21,9 +21,6 @@ proprietary_codecs = true
 ffmpeg_branding = "Chrome"
 
 enable_basic_printing = true
-
-# Removes DLLs from the build, which are only meant to be used for Chromium development.
-# See https://github.com/electron/electron/pull/17985
 angle_enable_vulkan_validation_layers = false
 dawn_enable_vulkan_validation_layers = false
 
@@ -32,9 +29,16 @@ dawn_enable_vulkan_validation_layers = false
 # See https://chromium-review.googlesource.com/c/chromium/src/+/2774898.
 enable_pseudolocales = false
 
-is_cfi = false
-
 # Make application name configurable at runtime for cookie crypto
 allow_runtime_configurable_key_storage = true
 
+# CET shadow stack is incompatible with v8, until v8 is CET compliant
+# enabling this flag causes main process crashes where CET is enabled
+# Ref: https://source.chromium.org/chromium/chromium/src/+/45fba672185aae233e75d6ddc81ea1e0b30db050:v8/BUILD.gn;l=357
 enable_cet_shadow_stack = false
+
+# For similar reasons, disable CFI, which is not well supported in V8.
+# Chromium doesn't have any problems with this because they do not run
+# V8 in the browser process.
+# Ref: https://source.chromium.org/chromium/chromium/src/+/45fba672185aae233e75d6ddc81ea1e0b30db050:v8/BUILD.gn;l=281
+is_cfi = false

build/extract_symbols.gni

@@ -24,11 +24,7 @@ template("extract_symbols") {
     assert(defined(invoker.binary), "Need binary to dump")
     assert(defined(invoker.symbol_dir), "Need directory for symbol output")
 
-    if (host_os == "win" && target_cpu == "x86") {
-      dump_syms_label = "//third_party/breakpad:dump_syms(//build/toolchain/win:win_clang_x64)"
-    } else {
-      dump_syms_label = "//third_party/breakpad:dump_syms($host_toolchain)"
-    }
+    dump_syms_label = "//third_party/breakpad:dump_syms($host_toolchain)"
     dump_syms_binary = get_label_info(dump_syms_label, "root_out_dir") +
                        "/dump_syms$_host_executable_suffix"
 

chromium_src/BUILD.gn

@@ -55,14 +55,6 @@ static_library("chrome") {
     "//chrome/browser/process_singleton.h",
     "//chrome/browser/process_singleton_internal.cc",
     "//chrome/browser/process_singleton_internal.h",
-    "//chrome/browser/themes/browser_theme_pack.cc",
-    "//chrome/browser/themes/browser_theme_pack.h",
-    "//chrome/browser/themes/custom_theme_supplier.cc",
-    "//chrome/browser/themes/custom_theme_supplier.h",
-    "//chrome/browser/themes/theme_properties.cc",
-    "//chrome/browser/themes/theme_properties.h",
-    "//chrome/browser/ui/color/chrome_color_mixers.cc",
-    "//chrome/browser/ui/color/chrome_color_mixers.h",
     "//chrome/browser/ui/exclusive_access/exclusive_access_bubble_type.cc",
     "//chrome/browser/ui/exclusive_access/exclusive_access_bubble_type.h",
     "//chrome/browser/ui/exclusive_access/exclusive_access_controller_base.cc",
@@ -77,11 +69,7 @@ static_library("chrome") {
     "//chrome/browser/ui/exclusive_access/keyboard_lock_controller.h",
     "//chrome/browser/ui/exclusive_access/mouse_lock_controller.cc",
     "//chrome/browser/ui/exclusive_access/mouse_lock_controller.h",
-    "//chrome/browser/ui/frame/window_frame_util.cc",
-    "//chrome/browser/ui/frame/window_frame_util.h",
     "//chrome/browser/ui/native_window_tracker.h",
-    "//chrome/browser/ui/ui_features.cc",
-    "//chrome/browser/ui/ui_features.h",
     "//chrome/browser/ui/views/eye_dropper/eye_dropper.cc",
     "//chrome/browser/ui/views/eye_dropper/eye_dropper.h",
     "//chrome/browser/ui/views/eye_dropper/eye_dropper_view.cc",
@@ -119,8 +107,6 @@ static_library("chrome") {
       "//chrome/browser/ui/view_ids.h",
       "//chrome/browser/win/chrome_process_finder.cc",
       "//chrome/browser/win/chrome_process_finder.h",
-      "//chrome/browser/win/titlebar_config.cc",
-      "//chrome/browser/win/titlebar_config.h",
       "//chrome/browser/win/titlebar_config.h",
       "//chrome/child/v8_crashpad_support_win.cc",
       "//chrome/child/v8_crashpad_support_win.h",
@@ -142,7 +128,6 @@ static_library("chrome") {
 
   public_deps = [
     "//chrome/browser:dev_ui_browser_resources",
-    "//chrome/browser/ui/color:mixers",
     "//chrome/common",
     "//chrome/common:version_header",
     "//components/keyed_service/content",

docs/README.md

@@ -69,6 +69,9 @@ an issue:
   * [Windows Store](tutorial/windows-store-guide.md)
   * [Snapcraft](tutorial/snapcraft.md)
 * [Updates](tutorial/updates.md)
+  * [Deploying an Update Server](tutorial/updates.md#deploying-an-update-server)
+  * [Implementing Updates in Your App](tutorial/updates.md#implementing-updates-in-your-app)
+  * [Applying Updates](tutorial/updates.md#applying-updates)
 * [Getting Support](tutorial/support.md)
 
 ## Detailed Tutorials

docs/api/app.md

@@ -484,6 +484,7 @@ Returns:
 * `argv` string[] - An array of the second instance's command line arguments
 * `workingDirectory` string - The second instance's working directory
 * `additionalData` unknown - A JSON object of additional data passed from the second instance
+* `ackCallback` unknown - A function that can be used to send data back to the second instance
 
 This event will be emitted inside the primary instance of your application
 when a second instance has been executed and calls `app.requestSingleInstanceLock()`.
@@ -495,12 +496,35 @@ non-minimized.
 
 **Note:** If the second instance is started by a different user than the first, the `argv` array will not include the arguments.
 
+**Note:** `ackCallback` allows the user to send data back to the
+second instance during the `app.requestSingleInstanceLock()` flow.
+This callback can be used for cases where the second instance
+needs to obtain additional information from the first instance
+before quitting.
+
+Currently, the limit on the message size is kMaxMessageLength,
+or around 32kB. To be safe, keep the amount of data passed to 31kB at most.
+
+In order to call the callback, `event.preventDefault()` must be called, first.
+If the callback is not called in either case, `null` will be sent back.
+If `event.preventDefault()` is not called, but `ackCallback` is called
+by the user in the event, then the behaviour is undefined.
+
 This event is guaranteed to be emitted after the `ready` event of `app`
 gets emitted.
 
 **Note:** Extra command line arguments might be added by Chromium,
 such as `--original-process-start-time`.
 
+### Event: 'first-instance-ack'
+
+Returns:
+
+* `event` Event
+* `additionalData` unknown - A JSON object of additional data passed from the first instance, in response to the first instance's `second-instance` event.
+
+This event will be emitted within the second instance during the call to `app.requestSingleInstanceLock()`, when the first instance calls the `ackCallback` provided by the `second-instance` event handler.
+
 ## Methods
 
 The `app` object has the following methods:
@@ -582,6 +606,10 @@ You should seek to use the `steal` option as sparingly as possible.
 
 Hides all application windows without minimizing them.
 
+### `app.isHidden()` _macOS_
+
+Returns `boolean` - `true` if the application—including all of its windows—is hidden (e.g. with `Command-H`), `false` otherwise.
+
 ### `app.show()` _macOS_
 
 Shows application windows after they were hidden. Does not automatically focus
@@ -609,7 +637,6 @@ Returns `string` - The current application directory.
     * `~/Library/Application Support` on macOS
   * `userData` The directory for storing your app's configuration files, which by
     default it is the `appData` directory appended with your app's name.
-  * `cache`
   * `temp` Temporary directory.
   * `exe` The current executable file.
   * `module` The `libchromiumcontent` library.
@@ -837,8 +864,6 @@ Returns `Object`:
 
 * `categories` [JumpListCategory[]](structures/jump-list-category.md) | `null` - Array of `JumpListCategory` objects.
 
-Returns `string`
-
 Sets or removes a custom Jump List for the application, and returns one of the
 following strings:
 
@@ -961,6 +986,13 @@ starts:
 const { app } = require('electron')
 let myWindow = null
 
+app.on('first-instance-ack', (event, additionalData) => {
+  // Print out the ack received from the first instance.
+  // Note this event handler must come before the requestSingleInstanceLock call.
+  // Expected output: '{"myAckKey":"myAckValue"}'
+  console.log(JSON.stringify(additionalData))
+})
+
 const additionalData = { myKey: 'myValue' }
 const gotTheLock = app.requestSingleInstanceLock(additionalData)
 
@@ -968,14 +1000,19 @@ if (!gotTheLock) {
   app.quit()
 } else {
   app.on('second-instance', (event, commandLine, workingDirectory, additionalData) => {
+    // We must call preventDefault if we're sending back data.
+    event.preventDefault()
     // Print out data received from the second instance.
-    console.log(additionalData)
+    // Expected output: '{"myKey":"myValue"}'
+    console.log(JSON.stringify(additionalData))
 
     // Someone tried to run a second instance, we should focus our window.
     if (myWindow) {
       if (myWindow.isMinimized()) myWindow.restore()
       myWindow.focus()
     }
+    const ackData = { myAckKey: 'myAckValue' }
+    ackCallback(ackData)
   })
 
   // Create myWindow, load the rest of the app, etc...

docs/api/browser-view.md

@@ -11,6 +11,9 @@ relative to its owning window. It is meant to be an alternative to the
 
 Process: [Main](../glossary.md#main-process)
 
+This module cannot be used until the `ready` event of the `app`
+module is emitted.
+
 ### Example
 
 ```javascript

docs/api/browser-window.md

@@ -4,6 +4,9 @@
 
 Process: [Main](../glossary.md#main-process)
 
+This module cannot be used until the `ready` event of the `app`
+module is emitted.
+
 ```javascript
 // In the main process.
 const { BrowserWindow } = require('electron')
@@ -243,8 +246,7 @@ It creates a new `BrowserWindow` with native properties as set by the `options`.
   * `trafficLightPosition` [Point](structures/point.md) (optional) _macOS_ -
     Set a custom position for the traffic light buttons in frameless windows.
   * `roundedCorners` boolean (optional) _macOS_ - Whether frameless window
-    should have rounded corners on macOS. Default is `true`. Setting this property
-    to `false` will prevent the window from being fullscreenable.
+    should have rounded corners on macOS. Default is `true`.
   * `fullscreenWindowTitle` boolean (optional) _macOS_ _Deprecated_ - Shows
     the title in the title bar in full screen mode on macOS for `hiddenInset`
     titleBarStyle. Default is `false`.

docs/api/context-bridge.md

@@ -35,7 +35,7 @@ page you load in your renderer executes code in this world.
 
 When `contextIsolation` is enabled in your `webPreferences` (this is the default behavior since Electron 12.0.0), your `preload` scripts run in an
 "Isolated World".  You can read more about context isolation and what it affects in the
-[security](../tutorial/security.md#3-enable-context-isolation-for-remote-content) docs.
+[security](../tutorial/security.md#3-enable-context-isolation) docs.
 
 ## Methods
 

docs/api/safe-storage.md

@@ -18,8 +18,8 @@ The `safeStorage` module has the following methods:
 
 Returns `boolean` - Whether encryption is available.
 
-On Linux, returns true if the app has emitted the `ready` event and the secret key is available.
-On MacOS, returns true if Keychain is available.
+On Linux, returns true if the secret key is
+available. On MacOS, returns true if Keychain is available.
 On Windows, returns true once the app has emitted the `ready` event.
 
 ### `safeStorage.encryptString(plainText)`

docs/api/session.md

@@ -1025,7 +1025,7 @@ is emitted.
 
 #### `ses.getStoragePath()`
 
-Returns `string | null` - The absolute file system path where data for this
+A `string | null` indicating the absolute file system path where data for this
 session is persisted on disk.  For in memory sessions this returns `null`.
 
 ### Instance Properties

docs/api/tray.md

@@ -25,20 +25,15 @@ app.whenReady().then(() => {
 })
 ```
 
-__Platform Considerations__
-
-If you want to keep exact same behaviors on all platforms, you should not
-rely on the `click` event; instead, always attach a context menu to the tray icon.
-
-__Linux__
+__Platform limitations:__
 
+* On Linux the app indicator will be used if it is supported, otherwise
+  `GtkStatusIcon` will be used instead.
 * On Linux distributions that only have app indicator support, you have to
   install `libappindicator1` to make the tray icon work.
-* The app indicator will be used if it is supported, otherwise
-  `GtkStatusIcon` will be used instead.
 * App indicator will only be shown when it has a context menu.
-* The `click` event is ignored when using the app indicator.
-* In order for changes made to individual `MenuItem`s to take effect,
+* When app indicator is used on Linux, the `click` event is ignored.
+* On Linux in order for changes made to individual `MenuItem`s to take effect,
   you have to call `setContextMenu` again. For example:
 
 ```javascript
@@ -60,16 +55,10 @@ app.whenReady().then(() => {
 })
 ```
 
-__MacOS__
+* On Windows it is recommended to use `ICO` icons to get best visual effects.
 
-* Icons passed to the Tray constructor should be [Template Images](native-image.md#template-image).
-* To make sure your icon isn't grainy on retina monitors, be sure your `@2x` image is 144dpi.
-* If you are bundling your application (e.g., with webpack for development), be sure that the file names are not being mangled or hashed. The filename needs to end in Template, and the `@2x` image needs to have the same filename as the standard image, or MacOS will not magically invert your image's colors or use the high density image.
-* 16x16 (72dpi) and 32x32@2x (144dpi) work well for most icons.
-
-__Windows__
-
-* It is recommended to use `ICO` icons to get best visual effects.
+If you want to keep exact same behaviors on all platforms, you should not
+rely on the `click` event and always attach a context menu to the tray icon.
 
 ### `new Tray(image, [guid])`
 

docs/api/web-contents.md

@@ -1635,8 +1635,6 @@ Opens the devtools.
 When `contents` is a `<webview>` tag, the `mode` would be `detach` by default,
 explicitly passing an empty `mode` can force using last used dock state.
 
-On Windows, if Windows Control Overlay is enabled, Devtools will be opened with `mode: 'detach'`.
-
 #### `contents.closeDevTools()`
 
 Closes the devtools.

docs/api/web-frame-main.md

@@ -16,7 +16,7 @@ win.loadURL('https://twitter.com')
 
 win.webContents.on(
   'did-frame-navigate',
-  (event, url, httpResponseCode, httpStatusText, isMainFrame, frameProcessId, frameRoutingId) => {
+  (event, url, isMainFrame, frameProcessId, frameRoutingId) => {
     const frame = webFrameMain.fromId(frameProcessId, frameRoutingId)
     if (frame) {
       const code = 'document.body.innerHTML = document.body.innerHTML.replaceAll("heck", "h*ck")'

docs/breaking-changes.md

@@ -36,10 +36,7 @@ requires unsafe mode), so Electron is unable to support this feature on Linux.
 
 ## Planned Breaking API Changes (19.0)
 
-### Removed: IA32 Linux binaries
-
-This is a result of Chromium 102.0.4999.0 dropping support for IA32 Linux.
-This concludes the [removal of support for IA32 Linux](#removed-ia32-linux-support).
+None
 
 ## Planned Breaking API Changes (18.0)
 
@@ -375,7 +372,7 @@ value.
 In Electron 12, `contextIsolation` will be enabled by default.  To restore
 the previous behavior, `contextIsolation: false` must be specified in WebPreferences.
 
-We [recommend having contextIsolation enabled](tutorial/security.md#3-enable-context-isolation-for-remote-content) for the security of your application.
+We [recommend having contextIsolation enabled](tutorial/security.md#3-enable-context-isolation) for the security of your application.
 
 Another implication is that `require()` cannot be used in the renderer process unless
 `nodeIntegration` is `true` and `contextIsolation` is `false`.
@@ -1206,10 +1203,6 @@ not present, then the native module will fail to load on Windows, with an error
 message like `Cannot find module`. See the [native module
 guide](/docs/tutorial/using-native-node-modules.md) for more.
 
-### Removed: IA32 Linux support
-
-Electron 18 will no longer run on 32-bit Linux systems. See [discontinuing support for 32-bit Linux](https://www.electronjs.org/blog/linux-32bit-support) for more information.
-
 ## Breaking API Changes (3.0)
 
 The following list includes the breaking API changes in Electron 3.0.

docs/fiddles/tutorial-first-app/index.html

@@ -1,21 +0,0 @@
-<!DOCTYPE html>
-<html>
-  <head>
-    <meta charset="UTF-8" />
-    <meta
-      http-equiv="Content-Security-Policy"
-      content="default-src 'self'; script-src 'self'"
-    />
-    <meta
-      http-equiv="X-Content-Security-Policy"
-      content="default-src 'self'; script-src 'self'"
-    />
-    <title>Hello from Electron renderer!</title>
-  </head>
-  <body>
-    <h1>Hello from Electron renderer!</h1>
-    <p>👋</p>
-    <p id="info"></p>
-  </body>
-  <script src="./renderer.js"></script>
-</html>

docs/fiddles/tutorial-first-app/main.js

@@ -1,26 +0,0 @@
-const { app, BrowserWindow } = require('electron');
-
-const createWindow = () => {
-  const win = new BrowserWindow({
-    width: 800,
-    height: 600,
-  });
-
-  win.loadFile('index.html');
-};
-
-app.whenReady().then(() => {
-  createWindow();
-
-  app.on('activate', () => {
-    if (BrowserWindow.getAllWindows().length === 0) {
-      createWindow();
-    }
-  });
-});
-
-app.on('window-all-closed', () => {
-  if (process.platform !== 'darwin') {
-    app.quit();
-  }
-});

docs/fiddles/tutorial-preload/index.html

@@ -1,21 +0,0 @@
-<!DOCTYPE html>
-<html>
-  <head>
-    <meta charset="UTF-8" />
-    <meta
-      http-equiv="Content-Security-Policy"
-      content="default-src 'self'; script-src 'self'"
-    />
-    <meta
-      http-equiv="X-Content-Security-Policy"
-      content="default-src 'self'; script-src 'self'"
-    />
-    <title>Hello from Electron renderer!</title>
-  </head>
-  <body>
-    <h1>Hello from Electron renderer!</h1>
-    <p>👋</p>
-    <p id="info"></p>
-  </body>
-  <script src="./renderer.js"></script>
-</html>

docs/fiddles/tutorial-preload/main.js

@@ -1,30 +0,0 @@
-const { app, BrowserWindow } = require('electron');
-const path = require('path');
-
-const createWindow = () => {
-  const win = new BrowserWindow({
-    width: 800,
-    height: 600,
-    webPreferences: {
-      preload: path.join(__dirname, 'preload.js'),
-    },
-  });
-
-  win.loadFile('index.html');
-};
-
-app.whenReady().then(() => {
-  createWindow();
-
-  app.on('activate', () => {
-    if (BrowserWindow.getAllWindows().length === 0) {
-      createWindow();
-    }
-  });
-});
-
-app.on('window-all-closed', () => {
-  if (process.platform !== 'darwin') {
-    app.quit();
-  }
-});

docs/fiddles/tutorial-preload/preload.js

@@ -1,7 +0,0 @@
-const { contextBridge } = require('electron');
-
-contextBridge.exposeInMainWorld('versions', {
-  node: () => process.versions.node,
-  chrome: () => process.versions.chrome,
-  electron: () => process.versions.electron,
-});

docs/fiddles/tutorial-preload/renderer.js

@@ -1,2 +0,0 @@
-const information = document.getElementById('info');
-information.innerText = `This app is using Chrome (v${versions.chrome()}), Node.js (v${versions.node()}), and Electron (v${versions.electron()})`;

docs/tutorial/application-distribution.md

@@ -1,26 +1,26 @@
----
-title: 'Application Packaging'
-description: 'To distribute your app with Electron, you need to package and rebrand it. To do this, you can either use specialized tooling or manual approaches.'
-slug: application-distribution
-hide_title: false
----
+# Application Distribution
 
-To distribute your app with Electron, you need to package and rebrand it. To do this, you
-can either use specialized tooling or manual approaches.
+## Overview
+
+To distribute your app with Electron, you need to package and rebrand it.
+To do this, you can either use specialized tooling or manual approaches.
 
 ## With tooling
 
-There are a couple tools out there that exist to package and distribute your Electron app.
-We recommend using [Electron Forge](https://www.electronforge.io). You can check out
-its documentation directly, or refer to the [Packaging and Distribution](./tutorial-5-packaging.md)
-part of the Electron tutorial.
+You can use the following tools to distribute your application:
 
-## Manual packaging
+* [electron-forge](https://github.com/electron-userland/electron-forge)
+* [electron-builder](https://github.com/electron-userland/electron-builder)
+* [electron-packager](https://github.com/electron/electron-packager)
 
-If you prefer the manual approach, there are 2 ways to distribute your application:
+These tools will take care of all the steps you need to take to end up with a
+distributable Electron application, such as bundling your application,
+rebranding the executable, and setting the right icons.
 
-- With prebuilt binaries
-- With an app source code archive
+You can check the example of how to package your app with `electron-forge` in
+the [Quick Start guide](quick-start.md#package-and-distribute-your-application).
+
+## Manual distribution
 
 ### With prebuilt binaries
 
@@ -29,19 +29,21 @@ binaries](https://github.com/electron/electron/releases). Next, the folder
 containing your app should be named `app` and placed in Electron's resources
 directory as shown in the following examples.
 
-:::note
-The location of Electron's prebuilt binaries is indicated
+> *NOTE:* the location of Electron's prebuilt binaries is indicated
 with `electron/` in the examples below.
-:::
 
-```plain title='macOS'
+*On macOS:*
+
+```plaintext
 electron/Electron.app/Contents/Resources/app/
 ├── package.json
 ├── main.js
 └── index.html
 ```
 
-```plain title='Windows and Linux'
+*On Windows and Linux:*
+
+```plaintext
 electron/resources/app
 ├── package.json
 ├── main.js
@@ -52,7 +54,7 @@ Then execute `Electron.app` on macOS, `electron` on Linux, or `electron.exe`
 on Windows, and Electron will start as your app. The `electron` directory
 will then be your distribution to deliver to users.
 
-### With an app source code archive (asar)
+### With an app source code archive
 
 Instead of shipping your app by copying all of its source files, you can
 package your app into an [asar] archive to improve the performance of reading
@@ -63,12 +65,16 @@ To use an `asar` archive to replace the `app` folder, you need to rename the
 archive to `app.asar`, and put it under Electron's resources directory like
 below, and Electron will then try to read the archive and start from it.
 
-```plain title='macOS'
+*On macOS:*
+
+```plaintext
 electron/Electron.app/Contents/Resources/
 └── app.asar
 ```
 
-```plain title='Windows'
+*On Windows and Linux:*
+
+```plaintext
 electron/resources/
 └── app.asar
 ```
@@ -81,44 +87,47 @@ You can find more details on how to use `asar` in the
 After bundling your app into Electron, you will want to rebrand Electron
 before distributing it to users.
 
-- **Windows:** You can rename `electron.exe` to any name you like, and edit
-  its icon and other information with tools like [rcedit](https://github.com/electron/rcedit).
-- **Linux:** You can rename the `electron` executable to any name you like.
-- **macOS:** You can rename `Electron.app` to any name you want, and you also have to rename
-  the `CFBundleDisplayName`, `CFBundleIdentifier` and `CFBundleName` fields in the
-  following files:
+#### macOS
 
-  - `Electron.app/Contents/Info.plist`
-  - `Electron.app/Contents/Frameworks/Electron Helper.app/Contents/Info.plist`
+You can rename `Electron.app` to any name you want, and you also have to rename
+the `CFBundleDisplayName`, `CFBundleIdentifier` and `CFBundleName` fields in the
+following files:
 
-  You can also rename the helper app to avoid showing `Electron Helper` in the
-  Activity Monitor, but make sure you have renamed the helper app's executable
-  file's name.
+* `Electron.app/Contents/Info.plist`
+* `Electron.app/Contents/Frameworks/Electron Helper.app/Contents/Info.plist`
 
-  The structure of a renamed app would be like:
+You can also rename the helper app to avoid showing `Electron Helper` in the
+Activity Monitor, but make sure you have renamed the helper app's executable
+file's name.
 
-```plain
+The structure of a renamed app would be like:
+
+```plaintext
 MyApp.app/Contents
 ├── Info.plist
 ├── MacOS/
-│   └── MyApp
+│   └── MyApp
 └── Frameworks/
     └── MyApp Helper.app
         ├── Info.plist
         └── MacOS/
-            └── MyApp Helper
+            └── MyApp Helper
 ```
 
-:::note
+#### Windows
 
-it is also possible to rebrand Electron by changing the product name and
+You can rename `electron.exe` to any name you like, and edit its icon and other
+information with tools like [rcedit](https://github.com/electron/rcedit).
+
+#### Linux
+
+You can rename the `electron` executable to any name you like.
+
+### Rebranding by rebuilding Electron from source
+
+It is also possible to rebrand Electron by changing the product name and
 building it from source. To do this you need to set the build argument
 corresponding to the product name (`electron_product_name = "YourProductName"`)
 in the `args.gn` file and rebuild.
 
-Keep in mind this is not recommended as setting up the environment to compile
-from source is not trivial and takes significant time.
-
-:::
-
 [asar]: https://github.com/electron/asar

docs/tutorial/code-signing.md

@@ -1,20 +1,14 @@
----
-title: 'Code Signing'
-description: 'Code signing is a security technology that you use to certify that an app was created by you.'
-slug: code-signing
-hide_title: false
----
+# Code Signing
 
 Code signing is a security technology that you use to certify that an app was
-created by you. You should sign your application so it does not trigger any
-operating system security checks.
+created by you.
 
-On macOS, the system can detect any change to the app, whether the change is
+On macOS the system can detect any change to the app, whether the change is
 introduced accidentally or by malicious code.
 
 On Windows, the system assigns a trust level to your code signing certificate
 which if you don't have, or if your trust level is low, will cause security
-dialogs to appear when users start using your application. Trust level builds
+dialogs to appear when users start using your application.  Trust level builds
 over time so it's better to start code signing as early as possible.
 
 While it is possible to distribute unsigned apps, it is not recommended. Both
@@ -22,19 +16,20 @@ Windows and macOS will, by default, prevent either the download or the execution
 of unsigned applications. Starting with macOS Catalina (version 10.15), users
 have to go through multiple manual steps to open unsigned applications.
 
-![macOS Catalina Gatekeeper warning: The app cannot be opened because the developer cannot be verified](../images/gatekeeper.png)
+![macOS Catalina Gatekeeper warning: The app cannot be opened because the
+developer cannot be verified](../images/gatekeeper.png)
 
 As you can see, users get two options: Move the app straight to the trash or
 cancel running it. You don't want your users to see that dialog.
 
 If you are building an Electron app that you intend to package and distribute,
-it should be code signed.
+it should be code-signed.
 
-## Signing & notarizing macOS builds
+# Signing & notarizing macOS builds
 
-Properly preparing macOS applications for release requires two steps. First, the
-app needs to be code signed. Then, the app needs to be uploaded to Apple for a
-process called **notarization**, where automated systems will further verify that
+Properly preparing macOS applications for release requires two steps: First, the
+app needs to be code-signed. Then, the app needs to be uploaded to Apple for a
+process called "notarization", where automated systems will further verify that
 your app isn't doing anything to endanger its users.
 
 To start the process, ensure that you fulfill the requirements for signing and
@@ -47,18 +42,18 @@ notarizing your app:
 Electron's ecosystem favors configuration and freedom, so there are multiple
 ways to get your application signed and notarized.
 
-### Using Electron Forge
+## `electron-forge`
 
 If you're using Electron's favorite build tool, getting your application signed
 and notarized requires a few additions to your configuration. [Forge](https://electronforge.io) is a
 collection of the official Electron tools, using [`electron-packager`],
 [`electron-osx-sign`], and [`electron-notarize`] under the hood.
 
-Let's take a look at an example `package.json` configuration with all required fields. Not all of them are
-required: the tools will be clever enough to automatically find a suitable `identity`, for instance,
-but we recommend that you are explicit.
+Let's take a look at an example configuration with all required fields. Not all
+of them are required: the tools will be clever enough to automatically find a
+suitable `identity`, for instance, but we recommend that you are explicit.
 
-```json title="package.json" {7}
+```json
 {
   "name": "my-app",
   "version": "0.0.1",
@@ -74,7 +69,7 @@ but we recommend that you are explicit.
         },
         "osxNotarize": {
           "appleId": "felix@felix.fun",
-          "appleIdPassword": "my-apple-id-password"
+          "appleIdPassword": "my-apple-id-password",
         }
       }
     }
@@ -82,11 +77,11 @@ but we recommend that you are explicit.
 }
 ```
 
-The `entitlements.plist` file referenced here needs the following macOS-specific entitlements
+The `plist` file referenced here needs the following macOS-specific entitlements
 to assure the Apple security mechanisms that your app is doing these things
 without meaning any harm:
 
-```xml title="entitlements.plist"
+```xml
 <?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
 <plist version="1.0">
@@ -109,7 +104,7 @@ file](https://github.com/electron/fiddle/blob/master/forge.config.js).
 If you plan to access the microphone or camera within your app using Electron's APIs, you'll also
 need to add the following entitlements:
 
-```xml title="entitlements.plist"
+```xml
 <key>com.apple.security.device.audio-input</key>
 <true/>
 <key>com.apple.security.device.camera</key>
@@ -118,26 +113,28 @@ need to add the following entitlements:
 
 If these are not present in your app's entitlements when you invoke, for example:
 
-```js title="main.js"
+```js
 const { systemPreferences } = require('electron')
+
 const microphone = systemPreferences.askForMediaAccess('microphone')
 ```
 
 Your app may crash. See the Resource Access section in [Hardened Runtime](https://developer.apple.com/documentation/security/hardened_runtime) for more information and entitlements you may need.
 
-### Using Electron Builder
+## `electron-builder`
 
 Electron Builder comes with a custom solution for signing your application. You
 can find [its documentation here](https://www.electron.build/code-signing).
 
-### Using Electron Packager
+## `electron-packager`
 
 If you're not using an integrated build pipeline like Forge or Builder, you
 are likely using [`electron-packager`], which includes [`electron-osx-sign`] and
 [`electron-notarize`].
 
 If you're using Packager's API, you can pass [in configuration that both signs
-and notarizes your application](https://electron.github.io/electron-packager/main/interfaces/electronpackager.options.html).
+and notarizes your
+application](https://electron.github.io/electron-packager/main/interfaces/electronpackager.options.html).
 
 ```js
 const packager = require('electron-packager')
@@ -158,11 +155,11 @@ packager({
 })
 ```
 
-The `entitlements.plist` file referenced here needs the following macOS-specific entitlements
+The `plist` file referenced here needs the following macOS-specific entitlements
 to assure the Apple security mechanisms that your app is doing these things
 without meaning any harm:
 
-```xml title="entitlements.plist"
+```xml
 <?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
 <plist version="1.0">
@@ -178,11 +175,11 @@ without meaning any harm:
 Up until Electron 12, the `com.apple.security.cs.allow-unsigned-executable-memory` entitlement was required
 as well. However, it should not be used anymore if it can be avoided.
 
-### Signing Mac App Store applications
+## Mac App Store
 
 See the [Mac App Store Guide].
 
-## Signing Windows builds
+# Signing Windows builds
 
 Before signing Windows builds, you must do the following:
 
@@ -193,140 +190,31 @@ Before signing Windows builds, you must do the following:
 You can get a code signing certificate from a lot of resellers. Prices vary, so
 it may be worth your time to shop around. Popular resellers include:
 
-- [digicert](https://www.digicert.com/code-signing/microsoft-authenticode.htm)
-- [Sectigo](https://sectigo.com/ssl-certificates-tls/code-signing)
-- Amongst others, please shop around to find one that suits your needs! 😄
+* [digicert](https://www.digicert.com/code-signing/microsoft-authenticode.htm)
+* [Sectigo](https://sectigo.com/ssl-certificates-tls/code-signing)
+* Amongst others, please shop around to find one that suits your needs, Google
+  is your friend 😄
 
-:::caution Keep your certificate password private
-Your certificate password should be a **secret**. Do not share it publicly or
-commit it to your source code.
-:::
+There are a number of tools for signing your packaged app:
 
-### Using Electron Forge
+* [`electron-winstaller`] will generate an installer for windows and sign it for
+  you
+* [`electron-forge`] can sign installers it generates through the
+  Squirrel.Windows or MSI targets.
+* [`electron-builder`] can sign some of its windows targets
 
-Once you have a code signing certificate file (`.pfx`), you can sign
-[Squirrel.Windows][maker-squirrel] and [MSI][maker-msi] installers in Electron Forge
-with the `certificateFile` and `certificatePassword` fields in their respective
-configuration objects.
-
-For example, if you keep your Forge config in your `package.json` file and are
-creating a Squirrel.Windows installer:
-
-```json {9-15} title='package.json'
-{
-  "name": "my-app",
-  "version": "0.0.1",
-  //...
-  "config": {
-    "forge": {
-      "packagerConfig": {},
-      "makers": [
-        {
-          "name": "@electron-forge/maker-squirrel",
-          "config": {
-            "certificateFile": "./cert.pfx",
-            "certificatePassword": "this-is-a-secret"
-          }
-        }
-      ]
-    }
-  }
-  //...
-}
-```
-
-### Using electron-winstaller (Squirrel.Windows)
-
-[`electron-winstaller`] is a package that can generate Squirrel.Windows installers for your
-Electron app. This is the tool used under the hood by Electron Forge's
-[Squirrel.Windows Maker][maker-squirrel]. If you're not using Electron Forge and want to use
-`electron-winstaller` directly, use the `certificateFile` and `certificatePassword` configuration
-options when creating your installer.
-
-```js {10-11}
-const electronInstaller = require('electron-winstaller')
-// NB: Use this syntax within an async function, Node does not have support for
-//     top-level await as of Node 12.
-try {
-  await electronInstaller.createWindowsInstaller({
-    appDirectory: '/tmp/build/my-app-64',
-    outputDirectory: '/tmp/build/installer64',
-    authors: 'My App Inc.',
-    exe: 'myapp.exe',
-    certificateFile: './cert.pfx',
-    certificatePassword: 'this-is-a-secret',
-  })
-  console.log('It worked!')
-} catch (e) {
-  console.log(`No dice: ${e.message}`)
-}
-```
-
-For full configuration options, check out the [`electron-winstaller`] repository!
-
-### Using electron-wix-msi (WiX MSI)
-
-[`electron-wix-msi`] is a package that can generate MSI installers for your
-Electron app. This is the tool used under the hood by Electron Forge's [MSI Maker][maker-msi].
-
-If you're not using Electron Forge and want to use `electron-wix-msi` directly, use the
-`certificateFile` and `certificatePassword` configuration options
-or pass in parameters directly to [SignTool.exe] with the `signWithParams` option.
-
-```js {12-13}
-import { MSICreator } from 'electron-wix-msi'
-
-// Step 1: Instantiate the MSICreator
-const msiCreator = new MSICreator({
-  appDirectory: '/path/to/built/app',
-  description: 'My amazing Kitten simulator',
-  exe: 'kittens',
-  name: 'Kittens',
-  manufacturer: 'Kitten Technologies',
-  version: '1.1.2',
-  outputDirectory: '/path/to/output/folder',
-  certificateFile: './cert.pfx',
-  certificatePassword: 'this-is-a-secret',
-})
-
-// Step 2: Create a .wxs template file
-const supportBinaries = await msiCreator.create()
-
-// 🆕 Step 2a: optionally sign support binaries if you
-// sign you binaries as part of of your packaging script
-supportBinaries.forEach(async (binary) => {
-  // Binaries are the new stub executable and optionally
-  // the Squirrel auto updater.
-  await signFile(binary)
-})
-
-// Step 3: Compile the template to a .msi file
-await msiCreator.compile()
-```
-
-For full configuration options, check out the [`electron-wix-msi`] repository!
-
-### Using Electron Builder
-
-Electron Builder comes with a custom solution for signing your application. You
-can find [its documentation here](https://www.electron.build/code-signing).
-
-### Signing Windows Store applications
+## Windows Store
 
 See the [Windows Store Guide].
 
-[apple developer program]: https://developer.apple.com/programs/
+[Apple Developer Program]: https://developer.apple.com/programs/
 [`electron-builder`]: https://github.com/electron-userland/electron-builder
 [`electron-forge`]: https://github.com/electron-userland/electron-forge
 [`electron-osx-sign`]: https://github.com/electron-userland/electron-osx-sign
 [`electron-packager`]: https://github.com/electron/electron-packager
 [`electron-notarize`]: https://github.com/electron/electron-notarize
 [`electron-winstaller`]: https://github.com/electron/windows-installer
-[`electron-wix-msi`]: https://github.com/felixrieseberg/electron-wix-msi
-[xcode]: https://developer.apple.com/xcode
+[Xcode]: https://developer.apple.com/xcode
 [signing certificates]: https://github.com/electron/electron-osx-sign/wiki/1.-Getting-Started#certificates
-[mac app store guide]: ./mac-app-store-submission-guide.md
-[windows store guide]: ./windows-store-guide.md
-[maker-squirrel]: https://www.electronforge.io/config/makers/squirrel.windows
-[maker-msi]: https://www.electronforge.io/config/makers/wix-msi
-[signtool.exe]: https://docs.microsoft.com/en-us/dotnet/framework/tools/signtool-exe
+[Mac App Store Guide]: mac-app-store-submission-guide.md
+[Windows Store Guide]: windows-store-guide.md

docs/tutorial/distribution-overview.md

@@ -1,54 +0,0 @@
----
-title: 'Distribution Overview'
-description: 'To distribute your app with Electron, you need to package and rebrand it. To do this, you can either use specialized tooling or manual approaches.'
-slug: distribution-overview
-hide_title: false
----
-
-Once your app is ready for production, there are a couple steps you need to take before
-you can deliver it to your users.
-
-## Packaging
-
-To distribute your app with Electron, you need to package all your resources and assets
-into an executable and rebrand it. To do this, you can either use specialized tooling
-or do it manually. See the [Application Packaging][application-packaging] tutorial
-for more information.
-
-## Code signing
-
-Code signing is a security technology that you use to certify that an app was
-created by you. You should sign your application so it does not trigger the
-security checks of your user's operating system.
-
-To get started with each operating system's code signing process, please read the
-[Code Signing][code-signing] docs.
-
-## Publishing
-
-Once your app is packaged and signed, you can freely distribute your app directly
-to users by uploading your installers online.
-
-To reach more users, you can also choose to upload your app to each operating system's
-digital distribution platform (i.e. app store). These require another build step aside
-from your direct download app. For more information, check out each individual app store guide:
-
-- [Mac App Store][mac-app]
-- [Windows Store][windows-store]
-- [Snapcraft (Linux)][snapcraft]
-
-## Updating
-
-Electron's auto-updater allows you to deliver application updates to users
-without forcing them to manually download new versions of your application.
-Check out the [Updating Applications][updates] guide for details on implementing automatic updates
-with Electron.
-
-<!-- Link labels -->
-
-[application-packaging]: ./application-distribution.md
-[code-signing]: ./code-signing.md
-[mac-app]: ./mac-app-store-submission-guide.md
-[windows-store]: ./windows-store-guide.md
-[snapcraft]: ./snapcraft.md
-[updates]: ./updates.md

docs/tutorial/electron-timelines.md

@@ -22,12 +22,11 @@ check out our [Electron Versioning](./electron-versioning.md) doc.
 | 12.0.0 | -- | 2020-Nov-19 | 2021-Mar-02 | M89 | v14.16 | 🚫 |
 | 13.0.0 | -- | 2021-Mar-04 | 2021-May-25 | M91 | v14.16 | 🚫 |
 | 14.0.0 | -- | 2021-May-27 | 2021-Aug-31 | M93 | v14.17 | 🚫 |
-| 15.0.0 | 2021-Jul-20 | 2021-Sep-01 | 2021-Sep-21 | M94 | v16.5 | 🚫 |
-| 16.0.0 | 2021-Sep-23 | 2021-Oct-20 | 2021-Nov-16 | M96 | v16.9 | 🚫 |
+| 15.0.0 | 2021-Jul-20 | 2021-Sep-01 | 2021-Sep-21 | M94 | v16.5 | ✅ |
+| 16.0.0 | 2021-Sep-23 | 2021-Oct-20 | 2021-Nov-16 | M96 | v16.9 | ✅ |
 | 17.0.0 | 2021-Nov-18 | 2022-Jan-06 | 2022-Feb-01 | M98 | v16.13 | ✅ |
 | 18.0.0 | 2022-Feb-03 | 2022-Mar-03 | 2022-Mar-29 | M100 | v16.13 | ✅ |
-| 19.0.0 | 2022-Mar-31 | 2022-Apr-26 | 2022-May-24 | M102 | v16.14 | ✅ |
-| 20.0.0 | 2022-May-26 | 2022-Jun-21 | 2022-Aug-02 | M104 | TBD | ✅ |
+| 19.0.0 | 2022-Mar-31 | 2022-Apr-26 | 2022-May-24 | M102 | TBD | ✅ |
 
 **Notes:**
 

docs/tutorial/examples.md

@@ -1,56 +0,0 @@
----
-title: 'Examples Overview'
-description: 'A set of examples for common Electron features'
-slug: examples
-hide_title: false
----
-
-# Examples Overview
-
-In this section, we have collected a set of guides for common features
-that you may want to implement in your Electron application. Each guide
-contains a practical example in a minimal, self-contained example app.
-The easiest way to run these examples is by downloading [Electron Fiddle][fiddle].
-
-Once Fiddle is installed, you can press on the "Open in Fiddle" button that you
-will find below code samples like the following one:
-
-```fiddle docs/fiddles/quick-start
-window.addEventListener('DOMContentLoaded', () => {
-  const replaceText = (selector, text) => {
-    const element = document.getElementById(selector)
-    if (element) element.innerText = text
-  }
-
-  for (const type of ['chrome', 'node', 'electron']) {
-    replaceText(`${type}-version`, process.versions[type])
-  }
-})
-```
-
-If there is still something that you do not know how to do, please take a look at the [API][app]
-as there is a chance it might be documented just there (and also open an issue requesting the
-guide!).
-
-<!-- guide-table-start -->
-
-| Guide                 | Description                                                                                                         |
-| :-------------------- | ------------------------------------------------------------------------------------------------------------------- |
-| [Message ports]       | This guide provides some examples of how you might use MessagePorts in your app to communicate different processes. |
-| [Device access]       | Learn how to access the device hardware (Bluetooth, USB, Serial).                                                   |
-| [Keyboard shortcuts]  | Configure local and global keyboard shortcuts for your Electron application.                                        |
-| [Multithreading]      | With Web Workers, it is possible to run JavaScript in OS-level threads                                              |
-| [Offscreen rendering] | Offscreen rendering lets you obtain the content of a BrowserWindow in a bitmap, so it can be rendered anywhere.     |
-| [Spellchecker]        | Learn how to use the built-in spellchecker, set languages, etc.                                                     |
-| [Web embeds]          | Discover the different ways to embed third-party web content in your application.                                   |
-
-<!-- guide-table-end -->
-
-## How to...?
-
-You can find the full list of "How to?" in the sidebar. If there is
-something that you would like to do that is not documented, please join
-our [Discord server][] and let us know!
-
-[discord server]: https://discord.com/invite/electron
-[fiddle]: https://www.electronjs.org/fiddle

docs/tutorial/in-app-purchases.md

@@ -116,7 +116,7 @@ inAppPurchase.getProducts(PRODUCT_IDS).then(products => {
     console.log(`The price of ${product.localizedTitle} is ${product.formattedPrice}.`)
   })
 
-  // Ask the user which product he/she wants to purchase.
+  // Ask the user which product they want to purchase.
   const selectedProduct = products[0]
   const selectedQuantity = 1
 

docs/tutorial/introduction.md

@@ -1,11 +1,10 @@
----
-title: 'Introduction'
-description: 'Welcome to the Electron documentation! If this is your first time developing an Electron app, read through this Getting Started section to get familiar with the basics. Otherwise, feel free to explore our guides and API documentation!'
-slug: /latest/
-hide_title: false
----
+# Introduction
 
-# What is Electron?
+Welcome to the Electron documentation! If this is your first time developing
+an Electron app, read through this Getting Started section to get familiar with the
+basics. Otherwise, feel free to explore our guides and API documentation!
+
+## What is Electron?
 
 Electron is a framework for building desktop applications using JavaScript,
 HTML, and CSS. By embedding [Chromium][chromium] and [Node.js][node] into its
@@ -13,12 +12,20 @@ binary, Electron allows you to maintain one JavaScript codebase and create
 cross-platform apps that work on Windows, macOS, and Linux — no native development
 experience required.
 
-## Getting started
+## Prerequisites
 
-We recommend you to start with the [tutorial], which guides you through the
-process of developing an Electron app and distributing it to users.
-The [examples] and [API documentation] are also good places to browse around
-and discover new things.
+These docs operate under the assumption that the reader is familiar with both
+Node.js and general web development. If you need to get more comfortable with
+either of these areas, we recommend the following resources:
+
+* [Getting started with the Web (MDN)][mdn-guide]
+* [Introduction to Node.js][node-guide]
+
+Moreover, you'll have a better time understanding how Electron works if you get
+acquainted with Chromium's process model. You can get a brief overview of
+Chrome architecture with the [Chrome comic][comic], which was released alongside
+Chrome's launch back in 2008. Although it's been over a decade since then, the
+core principles introduced in the comic remain helpful to understand Electron.
 
 ## Running examples with Electron Fiddle
 
@@ -32,45 +39,21 @@ a code block. If you have Fiddle installed, this button will open a
 `fiddle.electronjs.org` link that will automatically load the example into Fiddle,
 no copy-pasting required.
 
-```fiddle docs/fiddles/quick-start
-```
-
-## What is in the docs?
-
-All the official documentation is available from the sidebar. These
-are the different categories and what you can expect on each one:
-
-- **Tutorial**: An end-to-end guide on how to create and publish your first Electron
-  application.
-- **Processes in Electron**: In-depth reference on Electron processes and how to work with them.
-- **Best Practices**: Important checklists to keep in mind when developing an Electron app.
-- **Examples**: Quick references to add features to your Electron app.
-- **Development**: Miscellaneous development guides.
-- **Distribution**: Learn how to distribute your app to end users.
-- **Testing and debugging**: How to debug JavaScript, write tests, and other tools used
-  to create quality Electron applications.
-- **References**: Useful links to better understand how the Electron project works
-  and is organized.
-- **Contributing**: Compiling Electron and making contributions can be daunting.
-  We try to make it easier in this section.
-
 ## Getting help
 
 Are you getting stuck anywhere? Here are a few links to places to look:
 
-- If you need help with developing your app, our [community Discord server][discord]
-  is a great place to get advice from other Electron app developers.
-- If you suspect you're running into a bug with the `electron` package, please check
-  the [GitHub issue tracker][issue-tracker] to see if any existing issues match your
-  problem. If not, feel free to fill out our bug report template and submit a new issue.
+* If you need help with developing your app, our [community Discord server][discord]
+is a great place to get advice from other Electron app developers.
+* If you suspect you're running into a bug with the `electron` package, please check
+the [GitHub issue tracker][issue-tracker] to see if any existing issues match your
+problem. If not, feel free to fill out our bug report template and submit a new issue.
 
-<!-- Links -->
-
-[tutorial]: tutorial-1-prerequisites.md
-[api documentation]: ../api/app.md
 [chromium]: https://www.chromium.org/
-[discord]: https://discord.com/invite/APGC3k5yaH
-[examples]: examples.md
+[node]: https://nodejs.org/
+[mdn-guide]: https://developer.mozilla.org/en-US/docs/Learn/Getting_started_with_the_web
+[node-guide]: https://nodejs.dev/learn
+[comic]: https://www.google.com/googlebooks/chrome/
 [fiddle]: https://electronjs.org/fiddle
 [issue-tracker]: https://github.com/electron/electron/issues
-[node]: https://nodejs.org/
+[discord]: https://discord.gg/electronjs

docs/tutorial/message-ports.md

@@ -8,7 +8,8 @@ your app.
 
 Here is a very brief example of what a MessagePort is and how it works:
 
-```js title='renderer.js (Renderer Process)'
+```js
+// renderer.js ///////////////////////////////////////////////////////////////
 // MessagePorts are created in pairs. A connected pair of message ports is
 // called a channel.
 const channel = new MessageChannel()
@@ -27,7 +28,8 @@ port2.postMessage({ answer: 42 })
 ipcRenderer.postMessage('port', null, [port1])
 ```
 
-```js title='main.js (Main Process)'
+```js
+// main.js ///////////////////////////////////////////////////////////////////
 // In the main process, we receive the port.
 ipcMain.on('port', (event) => {
   // When we receive a MessagePort in the main process, it becomes a
@@ -82,84 +84,14 @@ process, you can listen for the `close` event by calling `port.on('close',
 
 ## Example use cases
 
-### Setting up a MessageChannel between two renderers
-
-In this example, the main process sets up a MessageChannel, then sends each port
-to a different renderer. This allows renderers to send messages to each other
-without needing to use the main process as an in-between.
-
-```js title='main.js (Main Process)'
-const { BrowserWindow, app, MessageChannelMain } = require('electron')
-
-app.whenReady().then(async () => {
-  // create the windows.
-  const mainWindow = new BrowserWindow({
-    show: false,
-    webPreferences: {
-      contextIsolation: false,
-      preload: 'preloadMain.js'
-    }
-  })
-
-  const secondaryWindow = BrowserWindow({
-    show: false,
-    webPreferences: {
-      contextIsolation: false,
-      preload: 'preloadSecondary.js'
-    }
-  })
-
-  // set up the channel.
-  const { port1, port2 } = new MessageChannelMain()
-
-  // once the webContents are ready, send a port to each webContents with postMessage.
-  mainWindow.once('ready-to-show', () => {
-    mainWindow.webContents.postMessage('port', null, [port1])
-  })
-
-  secondaryWindow.once('ready-to-show', () => {
-    secondaryWindow.webContents.postMessage('port', null, [port2])
-  })
-})
-```
-
-Then, in your preload scripts you receive the port through IPC and set up the
-listeners.
-
-```js title='preloadMain.js and preloadSecondary.js (Preload scripts)'
-const { ipcRenderer } = require('electron')
-
-ipcRenderer.on('port', e => {
-  // port received, make it globally available.
-  window.electronMessagePort = e.ports[0]
-
-  window.electronMessagePort.onmessage = messageEvent => {
-    // handle message
-  }
-})
-```
-
-In this example messagePort is bound to the `window` object directly. It is better
-to use `contextIsolation` and set up specific contextBridge calls for each of your
-expected messages, but for the simplicity of this example we don't. You can find an
-example of context isolation further down this page at [Communicating directly between the main process and the main world of a context-isolated page](#communicating-directly-between-the-main-process-and-the-main-world-of-a-context-isolated-page)
-
-That means window.messagePort is globally available and you can call
-`postMessage` on it from anywhere in your app to send a message to the other
-renderer.
-
-```js title='renderer.js (Renderer Process)'
-// elsewhere in your code to send a message to the other renderers message handler
-window.electronMessagePort.postmessage('ping')
-```
-
 ### Worker process
 
 In this example, your app has a worker process implemented as a hidden window.
 You want the app page to be able to communicate directly with the worker
 process, without the performance overhead of relaying via the main process.
 
-```js title='main.js (Main Process)'
+```js
+// main.js ///////////////////////////////////////////////////////////////////
 const { BrowserWindow, app, ipcMain, MessageChannelMain } = require('electron')
 
 app.whenReady().then(async () => {
@@ -197,7 +129,8 @@ app.whenReady().then(async () => {
 })
 ```
 
-```html  title='worker.html'
+```html
+<!-- worker.html ------------------------------------------------------------>
 <script>
 const { ipcRenderer } = require('electron')
 
@@ -220,7 +153,8 @@ ipcRenderer.on('new-client', (event) => {
 </script>
 ```
 
-```html  title='app.html'
+```html
+<!-- app.html --------------------------------------------------------------->
 <script>
 const { ipcRenderer } = require('electron')
 
@@ -248,7 +182,9 @@ Electron's built-in IPC methods only support two modes: fire-and-forget
 can implement a "response stream", where a single request responds with a
 stream of data.
 
-```js title='renderer.js (Renderer Process)'
+```js
+// renderer.js ///////////////////////////////////////////////////////////////
+
 const makeStreamingRequest = (element, callback) => {
   // MessageChannels are lightweight--it's cheap to create a new one for each
   // request.
@@ -277,7 +213,9 @@ makeStreamingRequest(42, (data) => {
 // We will see "got response data: 42" 10 times.
 ```
 
-```js  title='main.js (Main Process)'
+```js
+// main.js ///////////////////////////////////////////////////////////////////
+
 ipcMain.on('give-me-a-stream', (event, msg) => {
   // The renderer has sent us a MessagePort that it wants us to send our
   // response over.
@@ -304,7 +242,8 @@ the renderer are delivered to the isolated world, rather than to the main
 world. Sometimes you want to deliver messages to the main world directly,
 without having to step through the isolated world.
 
-```js title='main.js (Main Process)'
+```js
+// main.js ///////////////////////////////////////////////////////////////////
 const { BrowserWindow, app, MessageChannelMain } = require('electron')
 const path = require('path')
 
@@ -339,7 +278,8 @@ app.whenReady().then(async () => {
 })
 ```
 
-```js title='preload.js (Preload Script)'
+```js
+// preload.js ////////////////////////////////////////////////////////////////
 const { ipcRenderer } = require('electron')
 
 // We need to wait until the main world is ready to receive the message before
@@ -357,7 +297,8 @@ ipcRenderer.on('main-world-port', async (event) => {
 })
 ```
 
-```html title='index.html'
+```html
+<!-- index.html ------------------------------------------------------------->
 <script>
 window.onmessage = (event) => {
   // event.source === window means the message is coming from the preload

docs/tutorial/process-model.md

@@ -1,17 +1,10 @@
----
-title: 'Process Model'
-description: 'Electron inherits its multi-process architecture from Chromium, which makes the framework architecturally very similar to a modern web browser. This guide will expand on the concepts applied in the tutorial.'
-slug: process-model
-hide_title: false
----
-
 # Process Model
 
 Electron inherits its multi-process architecture from Chromium, which makes the framework
-architecturally very similar to a modern web browser. This guide will expand on the
-concepts applied in the [Tutorial][tutorial].
+architecturally very similar to a modern web browser. In this guide, we'll expound on
+the conceptual knowledge of Electron that we applied in the minimal [quick start app][].
 
-[tutorial]: ./tutorial-1-prerequisites.md
+[quick start app]: ./quick-start.md
 
 ## Why not a single process?
 
@@ -34,10 +27,10 @@ visualizes this model:
 ![Chrome's multi-process architecture](../images/chrome-processes.png)
 
 Electron applications are structured very similarly. As an app developer, you control
-two types of processes: [main](#the-main-process) and [renderer](#the-renderer-process).
-These are analogous to Chrome's own browser and renderer processes outlined above.
+two types of processes: main and renderer. These are analogous to Chrome's own browser
+and renderer processes outlined above.
 
-[chrome comic]: https://www.google.com/googlebooks/chrome/
+[Chrome Comic]: https://www.google.com/googlebooks/chrome/
 
 ## The main process
 
@@ -47,7 +40,7 @@ to `require` modules and use all of Node.js APIs.
 
 ### Window management
 
-The main process' primary purpose is to create and manage application windows with the
+The primary purpose of the main process is to create and manage application windows with the
 [`BrowserWindow`][browser-window] module.
 
 Each instance of the `BrowserWindow` class creates an application window that loads
@@ -75,7 +68,7 @@ When a `BrowserWindow` instance is destroyed, its corresponding renderer process
 terminated as well.
 
 [browser-window]: ../api/browser-window.md
-[web-embed]: ../tutorial/web-embeds.md
+[web-embed]: ./web-embeds.md
 [web-contents]: ../api/web-contents.md
 [event-emitter]: https://nodejs.org/api/events.html#events_class_eventemitter
 
@@ -97,7 +90,7 @@ app.on('window-all-closed', () => {
 ```
 
 [app]: ../api/app.md
-[quick-start-lifecycle]: ../tutorial/quick-start.md#manage-your-windows-lifecycle
+[quick-start-lifecycle]: ./quick-start.md#manage-your-windows-lifecycle
 
 ### Native APIs
 
@@ -112,7 +105,7 @@ For a full list of Electron's main process modules, check out our API documentat
 
 Each Electron app spawns a separate renderer process for each open `BrowserWindow`
 (and each web embed). As its name implies, a renderer is responsible for
-_rendering_ web content. For all intents and purposes, code ran in renderer processes
+*rendering* web content. For all intents and purposes, code ran in renderer processes
 should behave according to web standards (insofar as Chromium does, at least).
 
 Therefore, all user interfaces and app functionality within a single browser
@@ -122,22 +115,18 @@ web.
 Although explaining every web spec is out of scope for this guide, the bare minimum
 to understand is:
 
-- An HTML file is your entry point for the renderer process.
-- UI styling is added through Cascading Style Sheets (CSS).
-- Executable JavaScript code can be added through `<script>` elements.
+* An HTML file is your entry point for the renderer process.
+* UI styling is added through Cascading Style Sheets (CSS).
+* Executable JavaScript code can be added through `<script>` elements.
 
 Moreover, this also means that the renderer has no direct access to `require`
 or other Node.js APIs. In order to directly include NPM modules in the renderer,
 you must use the same bundler toolchains (for example, `webpack` or `parcel`) that you
 use on the web.
 
-:::warning
-
-Renderer processes can be spawned with a full Node.js environment for ease of
-development. Historically, this used to be the default, but this feature was disabled
-for security reasons.
-
-:::
+> Note: Renderer processes can be spawned with a full Node.js environment for ease of
+> development. Historically, this used to be the default, but this feature was disabled
+> for security reasons.
 
 At this point, you might be wondering how your renderer process user interfaces
 can interact with Node.js and Electron's native desktop functionality if these
@@ -146,9 +135,8 @@ way to import Electron's content scripts.
 
 ## Preload scripts
 
-<!-- Note: This guide doesn't take sandboxing into account, which might fundamentally
+<!-- Note: This guide doesn't take sandboxing into account, which might fundamentally 
 change the statements here. -->
-
 Preload scripts contain code that executes in a renderer process before its web content
 begins loading. These scripts run within the renderer context, but are granted more
 privileges by having access to Node.js APIs.
@@ -161,8 +149,8 @@ const { BrowserWindow } = require('electron')
 //...
 const win = new BrowserWindow({
   webPreferences: {
-    preload: 'path/to/preload.js',
-  },
+    preload: 'path/to/preload.js'
+  }
 })
 //...
 ```
@@ -177,7 +165,7 @@ the [`contextIsolation`][context-isolation] default.
 
 ```js title='preload.js'
 window.myAPI = {
-  desktop: true,
+  desktop: true
 }
 ```
 
@@ -196,7 +184,7 @@ securely:
 const { contextBridge } = require('electron')
 
 contextBridge.exposeInMainWorld('myAPI', {
-  desktop: true,
+  desktop: true
 })
 ```
 
@@ -207,15 +195,14 @@ console.log(window.myAPI)
 
 This feature is incredibly useful for two main purposes:
 
-- By exposing [`ipcRenderer`][ipcrenderer] helpers to the renderer, you can use
+* By exposing [`ipcRenderer`][ipcRenderer] helpers to the renderer, you can use
   inter-process communication (IPC) to trigger main process tasks from the
   renderer (and vice-versa).
-- If you're developing an Electron wrapper for an existing web app hosted on a remote
+* If you're developing an Electron wrapper for an existing web app hosted on a remote
   URL, you can add custom properties onto the renderer's `window` global that can
   be used for desktop-only logic on the web client's side.
 
 [window-mdn]: https://developer.mozilla.org/en-US/docs/Web/API/Window
 [context-isolation]: ./context-isolation.md
 [context-bridge]: ../api/context-bridge.md
-[ipcrenderer]: ../api/ipc-renderer.md
-[tutorial]: ./tutorial-1-prerequisites.md
+[ipcRenderer]: ../api/ipc-renderer.md

docs/tutorial/quick-start.md

@@ -131,6 +131,7 @@ folder of your project:
     <meta charset="UTF-8">
     <!-- https://developer.mozilla.org/en-US/docs/Web/HTTP/CSP -->
     <meta http-equiv="Content-Security-Policy" content="default-src 'self'; script-src 'self'">
+    <meta http-equiv="X-Content-Security-Policy" content="default-src 'self'; script-src 'self'">
     <title>Hello World!</title>
   </head>
   <body>
@@ -426,6 +427,7 @@ window.addEventListener('DOMContentLoaded', () => {
     <meta charset="UTF-8">
     <!-- https://developer.mozilla.org/en-US/docs/Web/HTTP/CSP -->
     <meta http-equiv="Content-Security-Policy" content="default-src 'self'; script-src 'self'">
+    <meta http-equiv="X-Content-Security-Policy" content="default-src 'self'; script-src 'self'">
     <title>Hello World!</title>
   </head>
   <body>

docs/tutorial/security.md

@@ -99,7 +99,7 @@ You should at least follow these steps to improve the security of your applicati
 
 1. [Only load secure content](#1-only-load-secure-content)
 2. [Disable the Node.js integration in all renderers that display remote content](#2-do-not-enable-nodejs-integration-for-remote-content)
-3. [Enable context isolation in all renderers that display remote content](#3-enable-context-isolation-for-remote-content)
+3. [Enable context isolation in all renderers](#3-enable-context-isolation)
 4. [Enable process sandboxing](#4-enable-process-sandboxing)
 5. [Use `ses.setPermissionRequestHandler()` in all sessions that load remote content](#5-handle-session-permission-requests-from-remote-content)
 6. [Do not disable `webSecurity`](#6-do-not-disable-websecurity)
@@ -225,7 +225,7 @@ do consume Node.js modules or features. Preload scripts continue to have access
 to `require` and other Node.js features, allowing developers to expose a custom
 API to remotely loaded content via the [contextBridge API](../api/context-bridge.md).
 
-### 3. Enable Context Isolation for remote content
+### 3. Enable Context Isolation
 
 :::info
 This recommendation is the default behavior in Electron since 12.0.0.

docs/tutorial/tutorial-1-prerequisites.md

@@ -1,143 +0,0 @@
----
-title: 'Prerequisites'
-description: 'This guide will step you through the process of creating a barebones Hello World app in Electron, similar to electron/electron-quick-start.'
-slug: tutorial-prerequisites
-hide_title: false
----
-
-:::info Follow along the tutorial
-
-This is **part 1** of the Electron tutorial.
-
-1. **[Prerequisites][prerequisites]**
-1. [Building your First App][building your first app]
-1. [Using Preload Scripts][preload]
-1. [Adding Features][features]
-1. [Packaging Your Application][packaging]
-1. [Publishing and Updating][updates]
-
-:::
-
-Electron is a framework for building desktop applications using JavaScript,
-HTML, and CSS. By embedding [Chromium][chromium] and [Node.js][node] into a
-single binary file, Electron allows you to create cross-platform apps that
-work on Windows, macOS, and Linux with a single JavaScript codebase.
-
-This tutorial will guide you through the process of developing a desktop
-application with Electron and distributing it to end users.
-
-## Assumptions
-
-Electron is a native wrapper layer for web apps and is run in a Node.js environment.
-Therefore, this tutorial assumes you are generally familiar with Node and
-front-end web development basics. If you need to do some background reading before
-continuing, we recommend the following resources:
-
-- [Getting started with the Web (MDN Web Docs)][mdn-guide]
-- [Introduction to Node.js][node-guide]
-
-## Required tools
-
-### Code editor
-
-You will need a text editor to write your code. We recommend using [Visual Studio Code],
-although you can choose whichever one you prefer.
-
-### Command line
-
-Throughout the tutorial, we will ask you to use various command-line interfaces (CLIs). You can
-type these commands into your system's default terminal:
-
-- Windows: Command Prompt or PowerShell
-- macOS: Terminal
-- Linux: varies depending on distribution (e.g. GNOME Terminal, Konsole)
-
-Most code editors also come with an integrated terminal, which you can also use.
-
-### Git and GitHub
-
-Git is a commonly-used version control system for source code, and GitHub is a collaborative
-development platform built on top of it. Although neither is strictly necessary to building
-an Electron application, we will use GitHub releases to set up automatic updates later
-on in the tutorial. Therefore, we'll require you to:
-
-- [Create a GitHub account](https://github.com/join)
-- [Install Git](https://github.com/git-guides/install-git)
-
-If you're unfamiliar with how Git works, we recommend reading GitHub's [Git guides]. You can also
-use the [GitHub Desktop] app if you prefer using a visual interface over the command line.
-
-We recommend that you create a local Git repository and publish it to GitHub before starting
-the tutorial, and commit your code after every step.
-
-:::info Installing Git via GitHub Desktop
-
-GitHub Desktop will install the latest version of Git on your system if you don't already have
-it installed.
-
-:::
-
-### Node.js and npm
-
-To begin developing an Electron app, you need to install the [Node.js][node-download]
-runtime and its bundled npm package manager onto your system. We recommend that you
-use the latest long-term support (LTS) version.
-
-:::tip
-
-Please install Node.js using pre-built installers for your platform.
-You may encounter incompatibility issues with different development tools otherwise.
-If you are using macOS, we recommend using a package manager like [Homebrew] or
-[nvm] to avoid any directory permission issues.
-
-:::
-
-To check that Node.js was installed correctly, you can use the `-v` flag when
-running the `node` and `npm` commands. These should print out the installed
-versions.
-
-```sh
-$ node -v
-v16.14.2
-$ npm -v
-8.7.0
-```
-
-:::caution
-
-Although you need Node.js installed locally to scaffold an Electron project,
-Electron **does not use your system's Node.js installation to run its code**. Instead, it
-comes bundled with its own Node.js runtime. This means that your end users do not
-need to install Node.js themselves as a prerequisite to running your app.
-
-To check which version of Node.js is running in your app, you can access the global
-[`process.versions`] variable in the main process or preload script. You can also reference
-the list of versions in the [electron/releases] repository.
-
-:::
-
-<!-- Links -->
-
-[chromium]: https://www.chromium.org/
-[electron/releases]: https://github.com/electron/releases/blob/master/readme.md#releases
-[homebrew]: https://brew.sh/
-[mdn-guide]: https://developer.mozilla.org/en-US/docs/Learn/
-[node]: https://nodejs.org/
-[node-guide]: https://nodejs.dev/learn
-[node-download]: https://nodejs.org/en/download/
-[nvm]: https://github.com/nvm-sh/nvm
-[process-model]: ./process-model.md
-[`process.versions`]: https://nodejs.org/api/process.html#processversions
-[github]: https://github.com/
-[git guides]: https://github.com/git-guides/
-[github desktop]: https://desktop.github.com/
-[visual studio code]: https://code.visualstudio.com/
-
-<!-- Tutorial links -->
-
-[prerequisites]: tutorial-1-prerequisites.md
-[building your first app]: tutorial-2-first-app.md
-[preload]: tutorial-3-preload.md
-[features]: tutorial-4-adding-features.md
-[packaging]: tutorial-5-packaging.md
-[updates]: tutorial-6-publishing-updating.md

docs/tutorial/tutorial-2-first-app.md

@@ -1,480 +0,0 @@
----
-title: 'Building your First App'
-description: 'This guide will step you through the process of creating a barebones Hello World app in Electron, similar to electron/electron-quick-start.'
-slug: tutorial-first-app
-hide_title: false
----
-
-:::info Follow along the tutorial
-
-This is **part 2** of the Electron tutorial.
-
-1. [Prerequisites][prerequisites]
-1. **[Building your First App][building your first app]**
-1. [Using Preload Scripts][preload]
-1. [Adding Features][features]
-1. [Packaging Your Application][packaging]
-1. [Publishing and Updating][updates]
-
-:::
-
-## Learning goals
-
-In this part of the tutorial, you will learn how to set up your Electron project
-and write a minimal starter application. By the end of this section,
-you should be able to run a working Electron app in development mode from
-your terminal.
-
-## Setting up your project
-
-:::caution Avoid WSL
-
-If you are on a Windows machine, please do not use [Windows Subsystem for Linux][wsl] (WSL)
-when following this tutorial as you will run into issues when trying to execute the
-application.
-
-<!--https://www.electronforge.io/guides/developing-with-wsl-->
-
-:::
-
-### Initializing your npm project
-
-Electron apps are scaffolded using npm, with the package.json file
-as an entry point. Start by creating a folder and initializing an npm package
-within it with `npm init`.
-
-```sh npm2yarn
-mkdir my-electron-app && cd my-electron-app
-npm init
-```
-
-This command will prompt you to configure some fields in your package.json.
-There are a few rules to follow for the purposes of this tutorial:
-
-- _entry point_ should be `main.js` (you will be creating that file soon).
-- _author_, _license_, and _description_ can be any value, but will be necessary for
-  [packaging][packaging] later on.
-
-Then, install Electron into your app's **devDependencies**, which is the list of external
-development-only package dependencies not required in production.
-
-:::info Why is Electron a devDependency?
-
-This may seem counter-intuitive since your production code is running Electron APIs.
-However, packaged apps will come bundled with the Electron binary, eliminating the need to specify
-it as a production dependency.
-
-:::
-
-```sh npm2yarn
-npm install electron --save-dev
-```
-
-Your package.json file should look something like this after initializing your package
-and installing Electron. You should also now have a `node_modules` folder containing
-the Electron executable, as well as a `package-lock.json` lockfile that specifies
-the exact dependency versions to install.
-
-```json title='package.json'
-{
-  "name": "my-electron-app",
-  "version": "1.0.0",
-  "description": "Hello World!",
-  "main": "main.js",
-  "author": "Jane Doe",
-  "license": "MIT",
-  "devDependencies": {
-    "electron": "19.0.0"
-  }
-}
-```
-
-:::info Advanced Electron installation steps
-
-If installing Electron directly fails, please refer to our [Advanced Installation][installation]
-documentation for instructions on download mirrors, proxies, and troubleshooting steps.
-
-:::
-
-### Adding a .gitignore
-
-The [`.gitignore`][gitignore] file specifies which files and directories to avoid tracking
-with Git. You should place a copy of [GitHub's Node.js gitignore template][gitignore-template]
-into your project's root folder to avoid committing your project's `node_modules` folder.
-
-## Running an Electron app
-
-:::tip Further reading
-
-Read [Electron's process model][process-model] documentation to better
-understand how Electron's multiple processes work together.
-
-:::
-
-The [`main`][package-json-main] script you defined in package.json is the entry point of any
-Electron application. This script controls the **main process**, which runs in a Node.js
-environment and is responsible for controlling your app's lifecycle, displaying native
-interfaces, performing privileged operations, and managing renderer processes
-(more on that later).
-
-Before creating your first Electron app, you will first use a trivial script to ensure your
-main process entry point is configured correctly. Create a `main.js` file in the root folder
-of your project with a single line of code:
-
-```js title='main.js'
-console.log(`Hello from Electron 👋`)
-```
-
-Because Electron's main process is a Node.js runtime, you can execute arbitrary Node.js code
-with the `electron` command (you can even use it as a [REPL]). To execute this script,
-add `electron .` to the `start` command in the [`scripts`][package-scripts]
-field of your package.json. This command will tell the Electron executable to look for the main
-script in the current directory and run it in dev mode.
-
-```json {8-10} title='package.json'
-{
-  "name": "my-electron-app",
-  "version": "1.0.0",
-  "description": "Hello World!",
-  "main": "main.js",
-  "author": "Jane Doe",
-  "license": "MIT",
-  "scripts": {
-    "start": "electron ."
-  },
-  "devDependencies": {
-    "electron": "^19.0.0"
-  }
-}
-```
-
-```sh npm2yarn
-npm run start
-```
-
-Your terminal should print out `Hello from Electron 👋`. Congratulations,
-you have executed your first line of code in Electron! Next, you will learn
-how to create user interfaces with HTML and load that into a native window.
-
-## Loading a web page into a BrowserWindow
-
-In Electron, each window displays a web page that can be loaded either from a local HTML
-file or a remote web address. For this example, you will be loading in a local file. Start
-by creating a barebones web page in an `index.html` file in the root folder of your project:
-
-```html title='index.html'
-<!DOCTYPE html>
-<html>
-  <head>
-    <meta charset="UTF-8" />
-    <!-- https://developer.mozilla.org/en-US/docs/Web/HTTP/CSP -->
-    <meta
-      http-equiv="Content-Security-Policy"
-      content="default-src 'self'; script-src 'self'"
-    />
-    <meta
-      http-equiv="X-Content-Security-Policy"
-      content="default-src 'self'; script-src 'self'"
-    />
-    <title>Hello from Electron renderer!</title>
-  </head>
-  <body>
-    <h1>Hello from Electron renderer!</h1>
-    <p>👋</p>
-  </body>
-</html>
-```
-
-Now that you have a web page, you can load it into an Electron [BrowserWindow][browser-window].
-Replace the contents your `main.js` file with the following code. We will explain each
-highlighted block separately.
-
-```js {1,3-10,12-14} title='main.js' showLineNumbers
-const { app, BrowserWindow } = require('electron')
-
-const createWindow = () => {
-  const win = new BrowserWindow({
-    width: 800,
-    height: 600,
-  })
-
-  win.loadFile('index.html')
-}
-
-app.whenReady().then(() => {
-  createWindow()
-})
-```
-
-### Importing modules
-
-```js title='main.js (Line 1)'
-const { app, BrowserWindow } = require('electron')
-```
-
-In the first line, we are importing two Electron modules
-with CommonJS module syntax:
-
-- [app][app], which controls your application's event lifecycle.
-- [BrowserWindow][browser-window], which creates and manages app windows.
-
-:::info Capitalization conventions
-
-You might have noticed the capitalization difference between the **a**pp
-and **B**rowser**W**indow modules. Electron follows typical JavaScript conventions here,
-where PascalCase modules are instantiable class constructors (e.g. BrowserWindow, Tray,
-Notification) whereas camelCase modules are not instantiable (e.g. app, ipcRenderer, webContents).
-
-:::
-
-:::warning ES Modules in Electron
-
-[ECMAScript modules](https://nodejs.org/api/esm.html) (i.e. using `import` to load a module)
-are currently not directly supported in Electron. You can find more information about the
-state of ESM in Electron in [electron/electron#21457](https://github.com/electron/electron/issues/21457).
-
-:::
-
-### Writing a reusable function to instantiate windows
-
-The `createWindow()` function loads your web page into a new BrowserWindow instance:
-
-```js title='main.js (Lines 3-10)'
-const createWindow = () => {
-  const win = new BrowserWindow({
-    width: 800,
-    height: 600,
-  })
-
-  win.loadFile('index.html')
-}
-```
-
-### Calling your function when the app is ready
-
-```js title='main.js (Lines 12-14)'
-app.whenReady().then(() => {
-  createWindow()
-})
-```
-
-Many of Electron's core modules are Node.js [event emitters] that adhere to Node's asynchronous
-event-driven architecture. The app module is one of these emitters.
-
-In Electron, BrowserWindows can only be created after the app module's [`ready`][app-ready] event
-is fired. You can wait for this event by using the [`app.whenReady()`][app-when-ready] API and
-calling `createWindow()` once its promise is fulfilled.
-
-:::info
-
-You typically listen to Node.js events by using an emitter's `.on` function.
-
-```diff
-+ app.on('ready').then(() => {
-- app.whenReady().then(() => {
-  createWindow()
-})
-```
-
-However, Electron exposes `app.whenReady()` as a helper specifically for the `ready` event to
-avoid subtle pitfalls with directly listening to that event in particular.
-See [electron/electron#21972](https://github.com/electron/electron/pull/21972) for details.
-
-:::
-
-At this point, running your Electron application's `start` command should successfully
-open a window that displays your web page!
-
-Each web page your app displays in a window will run in a separate process called a
-**renderer** process (or simply _renderer_ for short). Renderer processes have access
-to the same JavaScript APIs and tooling you use for typical front-end web
-development, such as using [webpack] to bundle and minify your code or [React][react]
-to build your user interfaces.
-
-## Managing your app's window lifecycle
-
-Application windows behave differently on each operating system. Rather than
-enforce these conventions by default, Electron gives you the choice to implement
-them in your app code if you wish to follow them. You can implement basic window
-conventions by listening for events emitted by the app and BrowserWindow modules.
-
-:::tip Process-specific control flow
-
-Checking against Node's [`process.platform`][node-platform] variable can help you
-to run code conditionally on certain platforms. Note that there are only three
-possible platforms that Electron can run in: `win32` (Windows), `linux` (Linux),
-and `darwin` (macOS).
-
-:::
-
-### Quit the app when all windows are closed (Windows & Linux)
-
-On Windows and Linux, closing all windows will generally quit an application entirely.
-To implement this pattern in your Electron app, listen for the app module's
-[`window-all-closed`][window-all-closed] event, and call [`app.quit()`][app-quit]
-to exit your app if the user is not on macOS.
-
-```js
-app.on('window-all-closed', () => {
-  if (process.platform !== 'darwin') app.quit()
-})
-```
-
-### Open a window if none are open (macOS)
-
-In contrast, macOS apps generally continue running even without any windows open.
-Activating the app when no windows are available should open a new one.
-
-To implement this feature, listen for the app module's [`activate`][activate]
-event, and call your existing `createWindow()` method if no BrowserWindows are open.
-
-Because windows cannot be created before the `ready` event, you should only listen for
-`activate` events after your app is initialized. Do this by only listening for activate
-events inside your existing `whenReady()` callback.
-
-```js
-app.whenReady().then(() => {
-  createWindow()
-
-  app.on('activate', () => {
-    if (BrowserWindow.getAllWindows().length === 0) createWindow()
-  })
-})
-```
-
-## Final starter code
-
-```fiddle docs/fiddles/tutorial-first-app
-
-```
-
-## Optional: Debugging from VS Code
-
-If you want to debug your application using VS Code, you need to attach VS Code to
-both the main and renderer processes. Here is a sample configuration for you to
-run. Create a launch.json configuration in a new `.vscode` folder in your project:
-
-```json title='.vscode/launch.json'
-{
-  "version": "0.2.0",
-  "compounds": [
-    {
-      "name": "Main + renderer",
-      "configurations": ["Main", "Renderer"],
-      "stopAll": true
-    }
-  ],
-  "configurations": [
-    {
-      "name": "Renderer",
-      "port": 9222,
-      "request": "attach",
-      "type": "pwa-chrome",
-      "webRoot": "${workspaceFolder}"
-    },
-    {
-      "name": "Main",
-      "type": "pwa-node",
-      "request": "launch",
-      "cwd": "${workspaceFolder}",
-      "runtimeExecutable": "${workspaceFolder}/node_modules/.bin/electron",
-      "windows": {
-        "runtimeExecutable": "${workspaceFolder}/node_modules/.bin/electron.cmd"
-      },
-      "args": [".", "--remote-debugging-port=9222"],
-      "outputCapture": "std",
-      "console": "integratedTerminal"
-    }
-  ]
-}
-```
-
-The "Main + renderer" option will appear when you select "Run and Debug"
-from the sidebar, allowing you to set breakpoints and inspect all the variables among
-other things in both the main and renderer processes.
-
-What we have done in the `launch.json` file is to create 3 configurations:
-
-- `Main` is used to start the main process and also expose port 9222 for remote debugging
-  (`--remote-debugging-port=9222`). This is the port that we will use to attach the debugger
-  for the `Renderer`. Because the main process is a Node.js process, the type is set to
-  `pwa-node` (`pwa-` is the prefix that tells VS Code to use the latest JavaScript debugger).
-- `Renderer` is used to debug the renderer process. Because the main process is the one
-  that creates the process, we have to "attach" to it (`"request": "attach"`) instead of
-  creating a new one.
-  The renderer process is a web one, so the debugger we have to use is `pwa-chrome`.
-- `Main + renderer` is a [compound task] that executes the previous ones simultaneously.
-
-:::caution
-
-Because we are attaching to a process in `Renderer`, it is possible that the first lines of
-your code will be skipped as the debugger will not have had enough time to connect before they are
-being executed.
-You can work around this by refreshing the page or setting a timeout before executing the code
-in development mode.
-
-:::
-
-:::info Further reading
-
-If you want to dig deeper in the debugging area, the following guides provide more information:
-
-- [Application Debugging]
-- [DevTools Extensions][devtools extension]
-
-:::
-
-## Summary
-
-Electron applications are set up using npm packages. The Electron executable should be installed
-in your project's `devDependencies` and can be run in development mode using a script in your
-package.json file.
-
-The executable runs the JavaScript entry point found in the `main` property of your package.json.
-This file controls Electron's **main process**, which runs an instance of Node.js and is
-responsible for your app's lifecycle, displaying native interfaces, performing privileged operations,
-and managing renderer processes.
-
-**Renderer processes** (or renderers for short) are responsible for display graphical content. You can
-load a web page into a renderer by pointing it to either a web address or a local HTML file.
-Renderers behave very similarly to regular web pages and have access to the same web APIs.
-
-In the next section of the tutorial, we will be learning how to augment the renderer process with
-privileged APIs and how to communicate between processes.
-
-<!-- Links -->
-
-[activate]: ../api/app.md#event-activate-macos
-[advanced-installation]: installation.md
-[app]: ../api/app.md
-[app-quit]: ../api/app.md#appquit
-[app-ready]: ../api/app.md#event-ready
-[app-when-ready]: ../api/app.md#appwhenready
-[application debugging]: ./application-debugging.md
-[browser-window]: ../api/browser-window.md
-[commonjs]: https://nodejs.org/docs/../api/modules.html#modules_modules_commonjs_modules
-[compound task]: https://code.visualstudio.com/Docs/editor/tasks#_compound-tasks
-[devtools extension]: ./devtools-extension.md
-[event emitters]: https://nodejs.org/api/events.html#events
-[gitignore]: https://git-scm.com/docs/gitignore
-[gitignore-template]: https://github.com/github/gitignore/blob/main/Node.gitignore
-[installation]: ./installation.md
-[node-platform]: https://nodejs.org/api/process.html#process_process_platform
-[package-json-main]: https://docs.npmjs.com/cli/v7/configuring-npm/package-json#main
-[package-scripts]: https://docs.npmjs.com/cli/v7/using-npm/scripts
-[process-model]: process-model.md
-[react]: https://reactjs.org
-[repl]: ./repl.md
-[sandbox]: ./sandbox.md
-[webpack]: https://webpack.js.org
-[window-all-closed]: ../api/app.md#event-window-all-closed
-[wsl]: https://docs.microsoft.com/en-us/windows/wsl/about#what-is-wsl-2
-
-<!-- Tutorial links -->
-
-[prerequisites]: tutorial-1-prerequisites.md
-[building your first app]: tutorial-2-first-app.md
-[preload]: tutorial-3-preload.md
-[features]: tutorial-4-adding-features.md
-[packaging]: tutorial-5-packaging.md
-[updates]: tutorial-6-publishing-updating.md

docs/tutorial/tutorial-3-preload.md

@@ -1,271 +0,0 @@
----
-title: 'Using Preload Scripts'
-description: 'This guide will step you through the process of creating a barebones Hello World app in Electron, similar to electron/electron-quick-start.'
-slug: tutorial-preload
-hide_title: false
----
-
-:::info Follow along the tutorial
-
-This is **part 3** of the Electron tutorial.
-
-1. [Prerequisites][prerequisites]
-1. [Building your First App][building your first app]
-1. **[Using Preload Scripts][preload]**
-1. [Adding Features][features]
-1. [Packaging Your Application][packaging]
-1. [Publishing and Updating][updates]
-
-:::
-
-## Learning goals
-
-In this part of the tutorial, you will learn what a preload script is and how to use one
-to securely expose privileged APIs into the renderer process. You will also learn how to
-communicate between main and renderer processes with Electron's inter-process
-communication (IPC) modules.
-
-## What is a preload script?
-
-Electron's main process is a Node.js environment that has full operating system access.
-On top of [Electron modules][modules], you can also access [Node.js built-ins][node-api],
-as well as any packages installed via npm. On the other hand, renderer processes run web
-pages and do not run Node.js by default for security reasons.
-
-To bridge Electron's different process types together, we will need to use a special script
-called a **preload**.
-
-## Augmenting the renderer with a preload script
-
-A BrowserWindow's preload script runs in a context that has access to both the HTML DOM
-and a Node.js environment. Preload scripts are injected before a web page loads in the renderer,
-similar to a Chrome extension's [content scripts][content-script]. To add features to your renderer
-that require privileged access, you can define [global] objects through the
-[contextBridge][contextbridge] API.
-
-To demonstrate this concept, you will create a preload script that exposes your app's
-versions of Chrome, Node, and Electron into the renderer.
-
-Add a new `preload.js` script that exposes selected properties of Electron's `process.versions`
-object to the renderer process in a `versions` global variable.
-
-```js title="preload.js"
-const { contextBridge } = require('electron')
-
-contextBridge.exposeInMainWorld('versions', {
-  node: () => process.versions.node,
-  chrome: () => process.versions.chrome,
-  electron: () => process.versions.electron,
-  // we can also expose variables, not just functions
-})
-```
-
-To attach this script to your renderer process, pass its path to the
-`webPreferences.preload` option in the BrowserWindow constructor:
-
-```js {8-10} title="main.js"
-const { app, BrowserWindow } = require('electron')
-const path = require('path')
-
-const createWindow = () => {
-  const win = new BrowserWindow({
-    width: 800,
-    height: 600,
-    webPreferences: {
-      preload: path.join(__dirname, 'preload.js'),
-    },
-  })
-
-  win.loadFile('index.html')
-}
-
-app.whenReady().then(() => {
-  createWindow()
-})
-```
-
-:::info
-
-There are two Node.js concepts that are used here:
-
-- The [`__dirname`][dirname] string points to the path of the currently executing script
-  (in this case, your project's root folder).
-- The [`path.join`][path-join] API joins multiple path segments together, creating a
-  combined path string that works across all platforms.
-
-:::
-
-At this point, the renderer has access to the `versions` global, so let's display that
-information in the window. This variable can be accessed via `window.versions` or simply
-`versions`. Create a `renderer.js` script that uses the [`document.getElementById`]
-DOM API to replace the displayed text for the HTML element with `info` as its `id` property.
-
-```js title="renderer.js"
-const information = document.getElementById('info')
-information.innerText = `This app is using Chrome (v${versions.chrome()}), Node.js (v${versions.node()}), and Electron (v${versions.electron()})`
-```
-
-Then, modify your `index.html` by adding a new element with `info` as its `id` property,
-and attach your `renderer.js` script:
-
-```html {18,20} title="index.html"
-<!DOCTYPE html>
-<html>
-  <head>
-    <meta charset="UTF-8" />
-    <meta
-      http-equiv="Content-Security-Policy"
-      content="default-src 'self'; script-src 'self'"
-    />
-    <meta
-      http-equiv="X-Content-Security-Policy"
-      content="default-src 'self'; script-src 'self'"
-    />
-    <title>Hello from Electron renderer!</title>
-  </head>
-  <body>
-    <h1>Hello from Electron renderer!</h1>
-    <p>👋</p>
-    <p id="info"></p>
-  </body>
-  <script src="./renderer.js"></script>
-</html>
-```
-
-After following the above steps, your app should look something like this:
-
-![Electron app showing This app is using Chrome (v102.0.5005.63), Node.js (v16.14.2), and Electron (v19.0.3)](../images/preload-example.png)
-
-And the code should look like this:
-
-```fiddle docs/fiddles/tutorial-preload
-
-```
-
-## Communicating between processes
-
-As we have mentioned above, Electron's main and renderer process have distinct responsibilities
-and are not interchangeable. This means it is not possible to access the Node.js APIs directly
-from the renderer process, nor the HTML Document Object Model (DOM) from the main process.
-
-The solution for this problem is to use Electron's `ipcMain` and `ipcRenderer` modules for
-inter-process communication (IPC). To send a message from your web page to the main process,
-you can set up a main process handler with `ipcMain.handle` and
-then expose a function that calls `ipcRenderer.invoke` to trigger the handler in your preload script.
-
-To illustrate, we will add a global function to the renderer called `ping()`
-that will return a string from the main process.
-
-First, set up the `invoke` call in your preload script:
-
-```js {1,7} title="preload.js"
-const { contextBridge, ipcRenderer } = require('electron')
-
-contextBridge.exposeInMainWorld('versions', {
-  node: () => process.versions.node,
-  chrome: () => process.versions.chrome,
-  electron: () => process.versions.electron,
-  ping: () => ipcRenderer.invoke('ping'),
-  // we can also expose variables, not just functions
-})
-```
-
-:::caution IPC security
-
-Notice how we wrap the `ipcRenderer.invoke('ping')` call in a helper function rather
-than expose the `ipcRenderer` module directly via context bridge. You **never** want to
-directly expose the entire `ipcRenderer` module via preload. This would give your renderer
-the ability to send arbitrary IPC messages to the main process, which becomes a powerful
-attack vector for malicious code.
-
-:::
-
-Then, set up your `handle` listener in the main process. We do this _before_
-loading the HTML file so that the handler is guaranteed to be ready before
-you send out the `invoke` call from the renderer.
-
-```js {1,11} title="main.js"
-const { ipcMain } = require('electron')
-
-const createWindow = () => {
-  const win = new BrowserWindow({
-    width: 800,
-    height: 600,
-    webPreferences: {
-      preload: path.join(__dirname, 'preload.js'),
-    },
-  })
-  ipcMain.handle('ping', () => 'pong')
-  win.loadFile('index.html')
-}
-```
-
-Once you have the sender and receiver set up, you can now send messages from the renderer
-to the main process through the `'ping'` channel you just defined.
-
-```js title='renderer.js'
-const func = async () => {
-  const response = await window.versions.ping()
-  console.log(response) // prints out 'pong'
-}
-
-func()
-```
-
-:::info
-
-For more in-depth explanations on using the `ipcRenderer` and `ipcMain` modules,
-check out the full [Inter-Process Communication][ipc] guide.
-
-:::
-
-## Summary
-
-A preload script contains code that runs before your web page is loaded into the browser
-window. It has access to both DOM APIs and Node.js environment, and is often used to
-expose privileged APIs to the renderer via the `contextBridge` API.
-
-Because the main and renderer processes have very different responsibilities, Electron
-apps often use the preload script to set up inter-process communication (IPC) interfaces
-to pass arbitrary messages between the two kinds of processes.
-
-In the next part of the tutorial, we will be showing you resources on adding more
-functionality to your app, then teaching you distributing your app to users.
-
-<!-- Links -->
-
-[advanced-installation]: ./installation.md
-[application debugging]: ./application-debugging.md
-[app]: ../api/app.md
-[app-ready]: ../api/app.md#event-ready
-[app-when-ready]: ../api/app.md#appwhenready
-[browser-window]: ../api/browser-window.md
-[commonjs]: https://nodejs.org/docs/latest/api/modules.html#modules_modules_commonjs_modules
-[compound task]: https://code.visualstudio.com/Docs/editor/tasks#_compound-tasks
-[content-script]: https://developer.chrome.com/docs/extensions/mv3/content_scripts/
-[contextbridge]: ../api/context-bridge.md
-[context-isolation]: ./context-isolation.md
-[`document.getelementbyid`]: https://developer.mozilla.org/en-US/docs/Web/API/Document/getElementById
-[devtools-extension]: ./devtools-extension.md
-[dirname]: https://nodejs.org/api/modules.html#modules_dirname
-[global]: https://developer.mozilla.org/en-US/docs/Glossary/Global_object
-[ipc]: ./ipc.md
-[mdn-csp]: https://developer.mozilla.org/en-US/docs/Web/HTTP/CSP
-[modules]: ../api/app.md
-[node-api]: https://nodejs.org/dist/latest/docs/api/
-[package-json-main]: https://docs.npmjs.com/cli/v7/configuring-npm/package-json#main
-[package-scripts]: https://docs.npmjs.com/cli/v7/using-npm/scripts
-[path-join]: https://nodejs.org/api/path.html#path_path_join_paths
-[process-model]: ./process-model.md
-[react]: https://reactjs.org
-[sandbox]: ./sandbox.md
-[webpack]: https://webpack.js.org
-
-<!-- Tutorial links -->
-
-[prerequisites]: tutorial-1-prerequisites.md
-[building your first app]: tutorial-2-first-app.md
-[preload]: tutorial-3-preload.md
-[features]: tutorial-4-adding-features.md
-[packaging]: tutorial-5-packaging.md
-[updates]: tutorial-6-publishing-updating.md

docs/tutorial/tutorial-4-adding-features.md

@@ -1,77 +0,0 @@
----
-title: 'Adding Features'
-description: 'In this step of the tutorial, we will share some resources you should read to add features to your application'
-slug: tutorial-adding-features
-hide_title: false
----
-
-:::info Follow along the tutorial
-
-This is **part 4** of the Electron tutorial.
-
-1. [Prerequisites][prerequisites]
-1. [Building your First App][building your first app]
-1. [Using Preload Scripts][preload]
-1. **[Adding Features][features]**
-1. [Packaging Your Application][packaging]
-1. [Publishing and Updating][updates]
-
-:::
-
-## Adding application complexity
-
-If you have been following along, you should have a functional Electron application
-with a static user interface. From this starting point, you can generally progress
-in developing your app in two broad directions:
-
-1. Adding complexity to your renderer process' web app code
-1. Deeper integrations with the operating system and Node.js
-
-It is important to understand the distinction between these two broad concepts. For the
-first point, Electron-specific resources are not necessary. Building a pretty to-do
-list in Electron is just pointing your Electron BrowserWindow to a pretty
-to-do list web app. Ultimately, you are building your renderer's UI using the same tools
-(HTML, CSS, JavaScript) that you would on the web. Therefore, Electron's docs will
-not go in-depth on how to use standard web tools.
-
-On the other hand, Electron also provides a rich set of tools that allow
-you to integrate with the desktop environment, from creating tray icons to adding
-global shortcuts to displaying native menus. It also gives you all the power of a
-Node.js environment in the main process. This set of capabilities separates
-Electron applications from running a website in a browser tab, and are the
-focus of Electron's documentation.
-
-## How-to examples
-
-Electron's documentation has many tutorials to help you with more advanced topics
-and deeper operating system integrations. To get started, check out the
-[How-To Examples][how-to] doc.
-
-:::note Let us know if something is missing!
-
-If you can't find what you are looking for, please let us know on [GitHub] or in
-our [Discord server][discord]!
-
-:::
-
-## What's next?
-
-For the rest of the tutorial, we will be shifting away from application code
-and giving you a look at how you can get your app from your developer machine
-into end users' hands.
-
-<!-- Link labels -->
-
-[discord]: https://discord.com/invite/APGC3k5yaH
-[github]: https://github.com/electron/electronjs.org-new/issues/new
-[how to]: ./examples.md
-[node-platform]: https://nodejs.org/api/process.html#process_process_platform
-
-<!-- Tutorial links -->
-
-[prerequisites]: tutorial-1-prerequisites.md
-[building your first app]: tutorial-2-first-app.md
-[preload]: tutorial-3-preload.md
-[features]: tutorial-4-adding-features.md
-[packaging]: tutorial-5-packaging.md
-[updates]: tutorial-6-publishing-updating.md

docs/tutorial/tutorial-5-packaging.md

@@ -1,225 +0,0 @@
----
-title: 'Packaging Your Application'
-description: 'To distribute your app with Electron, you need to package it and create installers.'
-slug: tutorial-packaging
-hide_title: false
----
-
-import Tabs from '@theme/Tabs';
-import TabItem from '@theme/TabItem';
-
-:::info Follow along the tutorial
-
-This is **part 5** of the Electron tutorial.
-
-1. [Prerequisites][prerequisites]
-1. [Building your First App][building your first app]
-1. [Using Preload Scripts][preload]
-1. [Adding Features][features]
-1. **[Packaging Your Application][packaging]**
-1. [Publishing and Updating][updates]
-
-:::
-
-## Learning goals
-
-In this part of the tutorial, we'll be going over the basics of packaging and distributing
-your app with [Electron Forge].
-
-## Using Electron Forge
-
-Electron does not have any tooling for packaging and distribution bundled into its core
-modules. Once you have a working Electron app in dev mode, you need to use
-additional tooling to create a packaged app you can distribute to your users (also known
-as a **distributable**). Distributables can be either installers (e.g. MSI on Windows) or
-portable executable files (e.g. `.app` on macOS).
-
-Electron Forge is an all-in-one tool that handles the packaging and distribution of Electron
-apps. Under the hood, it combines a lot of existing Electron tools (e.g. [`electron-packager`],
-[`@electron/osx-sign`], [`electron-winstaller`], etc.) into a single interface so you do not
-have to worry about wiring them all together.
-
-### Importing your project into Forge
-
-You can install Electron Forge's CLI in your project's `devDependencies` and import your
-existing project with a handy conversion script.
-
-```sh npm2yarn
-npm install --save-dev @electron-forge/cli
-npx electron-forge import
-```
-
-Once the conversion script is done, Forge should have added a few scripts
-to your `package.json` file.
-
-```json title='package.json'
-  //...
-  "scripts": {
-    "start": "electron-forge start",
-    "package": "electron-forge package",
-    "make": "electron-forge make"
-  },
-  //...
-```
-
-:::info CLI documentation
-
-For more information on `make` and other Forge APIs, check out
-the [Electron Forge CLI documentation].
-
-:::
-
-You should also notice that your package.json now has a few more packages installed
-under your `devDependencies`, and contains an added `config.forge` field with an array
-of makers configured. **Makers** are Forge plugins that create distributables from
-your source code. You should see multiple makers in the pre-populated configuration,
-one for each target platform.
-
-### Creating a distributable
-
-To create a distributable, use your project's new `make` script, which runs the
-`electron-forge make` command.
-
-```sh npm2yarn
-npm run make
-```
-
-This `make` command contains two steps:
-
-1. It will first run `electron-forge package` under the hood, which bundles your app
-   code together with the Electron binary. The packaged code is generated into a folder.
-1. It will then use this packaged app folder to create a separate distributable for each
-   configured maker.
-
-After the script runs, you should see an `out` folder containing both the distributable
-and a folder containing the packaged application code.
-
-```plain title='macOS output example'
-out/
-├── out/make/zip/darwin/x64/my-electron-app-darwin-x64-1.0.0.zip
-├── ...
-└── out/my-electron-app-darwin-x64/my-electron-app.app/Contents/MacOS/my-electron-app
-```
-
-The distributable in the `out/make` folder should be ready to launch! You have now
-created your first bundled Electron application.
-
-:::tip Distributable formats
-
-Electron Forge can be configured to create distributables in different OS-specific formats
-(e.g. DMG, deb, MSI, etc.). See Forge's [Makers] documentation for all configuration options.
-
-:::
-
-:::note Packaging without Electron Forge
-
-If you want to manually package your code, or if you're just interested understanding the
-mechanics behind packaging an Electron app, check out the full [Application Packaging]
-documentation.
-
-:::
-
-## Important: signing your code
-
-In order to distribute desktop applications to end users, we _highly recommended_ for you
-to **code sign** your Electron app. Code signing is an important part of shipping
-desktop applications, and is mandatory for the auto-update step in the final part
-of the tutorial.
-
-Code signing is a security technology that you use to certify that a desktop app was
-created by a known source. Windows and macOS have their own OS-specific code signing
-systems that will make it difficult for users to download or launch unsigned applications.
-
-If you already have code signing certificates for Windows and macOS, you can set your
-credentials in your Forge configuration. Otherwise, please refer to the full
-[Code Signing] documentation to learn how to purchase a certificate and for more information
-on the desktop app code signing process.
-
-On macOS, code signing is done at the app packaging level. On Windows, distributable installers
-are signed instead.
-
-<Tabs>
-  <TabItem value="macos" label="macOS" default>
-
-```json title='package.json' {6-18}
-{
-  //...
-  "config": {
-    "forge": {
-      //...
-      "packagerConfig": {
-        "osxSign": {
-          "identity": "Developer ID Application: Felix Rieseberg (LT94ZKYDCJ)",
-          "hardened-runtime": true,
-          "entitlements": "entitlements.plist",
-          "entitlements-inherit": "entitlements.plist",
-          "signature-flags": "library"
-        },
-        "osxNotarize": {
-          "appleId": "felix@felix.fun",
-          "appleIdPassword": "this-is-a-secret"
-        }
-      }
-      //...
-    }
-  }
-  //...
-}
-```
-
-  </TabItem>
-  <TabItem value="windows" label="Windows">
-
-```json title='package.json'  {6-14}
-{
-  //...
-  "config": {
-    "forge": {
-      //...
-      "makers": [
-        {
-          "name": "@electron-forge/maker-squirrel",
-          "config": {
-            "certificateFile": "./cert.pfx",
-            "certificatePassword": "this-is-a-secret"
-          }
-        }
-      ]
-      //...
-    }
-  }
-  //...
-}
-```
-
-  </TabItem>
-</Tabs>
-
-## Summary
-
-Electron applications need to be packaged to be distributed to users. In this tutorial,
-you imported your app into Electron Forge and configured it to package your app and
-generate installers.
-
-In order for your application to be trusted by the user's system, you need to digitally
-certify that the distributable is authentic and untampered by code signing it. Your app
-can be signed through Forge once you configure it to use your code signing certificate
-information.
-
-[`@electron/osx-sign`]: https://github.com/electron/osx-sign
-[application packaging]: ./application-distribution.md
-[code signing]: ./code-signing.md
-[`electron-packager`]: https://github.com/electron/electron-packager
-[`electron-winstaller`]: https://github.com/electron/windows-installer
-[electron forge]: https://www.electronforge.io
-[electron forge cli documentation]: https://www.electronforge.io/cli#commands
-[makers]: https://www.electronforge.io/config/makers
-
-<!-- Tutorial links -->
-
-[prerequisites]: tutorial-1-prerequisites.md
-[building your first app]: tutorial-2-first-app.md
-[preload]: tutorial-3-preload.md
-[features]: tutorial-4-adding-features.md
-[packaging]: tutorial-5-packaging.md
-[updates]: tutorial-6-publishing-updating.md

docs/tutorial/tutorial-6-publishing-updating.md

@@ -1,251 +0,0 @@
----
-title: 'Publishing and Updating'
-description: "There are several ways to update an Electron application. The easiest and officially supported one is taking advantage of the built-in Squirrel framework and Electron's autoUpdater module."
-slug: tutorial-publishing-updating
-hide_title: false
----
-
-:::info Follow along the tutorial
-
-This is **part 6** of the Electron tutorial.
-
-1. [Prerequisites][prerequisites]
-1. [Building your First App][building your first app]
-1. [Using Preload Scripts][preload]
-1. [Adding Features][features]
-1. [Packaging Your Application][packaging]
-1. **[Publishing and Updating][updates]**
-
-:::
-
-## Learning goals
-
-If you've been following along, this is the last step of the tutorial! In this part,
-you will publish your app to GitHub releases and integrate automatic updates
-into your app code.
-
-## Using update.electronjs.org
-
-The Electron maintainers provide a free auto-updating service for open-source apps
-at https://update.electronjs.org. Its requirements are:
-
-- Your app runs on macOS or Windows
-- Your app has a public GitHub repository
-- Builds are published to [GitHub releases]
-- Builds are [code signed][code-signed]
-
-At this point, we'll assume that you have already pushed all your
-code to a public GitHub repository.
-
-:::info Alternative update services
-
-If you're using an alternate repository host (e.g. GitLab or Bitbucket) or if
-you need to keep your code repository private, please refer to our
-[step-by-step guide][update-server] on hosting your own Electron update server.
-
-:::
-
-## Publishing a GitHub release
-
-Electron Forge has [Publisher] plugins that can automate the distribution
-of your packaged application to various sources. In this tutorial, we will
-be using the GitHub Publisher, which will allow us to publish
-our code to GitHub releases.
-
-### Generating a personal access token
-
-Forge cannot publish to any repository on GitHub without permission. You
-need to pass in an authenticated token that gives Forge access to
-your GitHub releases. The easiest way to do this is to
-[create a new personal access token (PAT)][new-pat]
-with the `public_repo` scope, which gives write access to your public repositories.
-**Make sure to keep this token a secret.**
-
-### Setting up the GitHub Publisher
-
-#### Installing the module
-
-Forge's [GitHub Publisher] is a plugin that
-needs to be installed in your project's `devDependencies`:
-
-```sh npm2yarn
-npm install --save-dev @electron-forge/publisher-github
-```
-
-#### Configuring the publisher in Forge
-
-Once you have it installed, you need to set it up in your Forge
-configuration. A full list of options is documented in the Forge's
-[`PublisherGitHubConfig`] API docs.
-
-```json title='package.json' {6-16}
-{
-  //...
-  "config": {
-    "forge": {
-      "publishers": [
-        {
-          "name": "@electron-forge/publisher-github",
-          "config": {
-            "repository": {
-              "owner": "github-user-name",
-              "name": "github-repo-name"
-            },
-            "prerelease": false,
-            "draft": true
-          }
-        }
-      ]
-    }
-  }
-  //...
-}
-```
-
-:::tip Drafting releases before publishing
-
-Notice that you have configured Forge to publish your release as a draft.
-This will allow you to see the release with its generated artifacts
-without actually publishing it to your end users. You can manually
-publish your releases via GitHub after writing release notes and
-double-checking that your distributables work.
-
-:::
-
-#### Setting up your authentication token
-
-You also need to make the Publisher aware of your authentication token.
-By default, it will use the value stored in the `GITHUB_TOKEN` environment
-variable.
-
-### Running the publish command
-
-Add Forge's [publish command] to your npm scripts.
-
-```json {6} title='package.json'
-  //...
-  "scripts": {
-    "start": "electron-forge start",
-    "package": "electron-forge package",
-    "make": "electron-forge make",
-    "publish": "electron-forge publish"
-  },
-  //...
-```
-
-This command will run your configured makers and publish the output distributables to a new
-GitHub release.
-
-```sh npm2yarn
-npm run publish
-```
-
-By default, this will only publish a single distributable for your host operating system and
-architecture. You can publish for different architectures by passing in the `--arch` flag to your
-Forge commands.
-
-The name of this release will correspond to the `version` field in your project's package.json file.
-
-:::tip Tagging releases
-
-Optionally, you can also [tag your releases in Git][git-tag] so that your
-release is associated with a labeled point in your code history. npm comes
-with a handy [`npm version`](https://docs.npmjs.com/cli/v8/commands/npm-version)
-command that can handle the version bumping and tagging for you.
-
-:::
-
-#### Bonus: Publishing in GitHub Actions
-
-Publishing locally can be painful, especially because you can only create distributables
-for your host operating system (i.e. you can't publish a Window `.exe` file from macOS).
-
-A solution for this would be to publish your app via automation workflows
-such as [GitHub Actions], which can run tasks in the
-cloud on Ubuntu, macOS, and Windows. This is the exact approach taken by [Electron Fiddle].
-You can refer to Fiddle's [Build and Release pipeline][fiddle-build]
-and [Forge configuration][fiddle-forge-config]
-for more details.
-
-## Instrumenting your updater code
-
-Now that we have a functional release system via GitHub releases, we now need to tell our
-Electron app to download an update whenever a new release is out. Electron apps do this
-via the [autoUpdater] module, which reads from an update server feed to check if a new version
-is available for download.
-
-The update.electronjs.org service provides an updater-compatible feed. For example, Electron
-Fiddle v0.28.0 will check the endpoint at https://update.electronjs.org/electron/fiddle/darwin/v0.28.0
-to see if a newer GitHub release is available.
-
-After your release is published to GitHub, the update.electronjs.org service should work
-for your application. The only step left is to configure the feed with the autoUpdater module.
-
-To make this process easier, the Electron team maintains the [`update-electron-app`] module,
-which sets up the autoUpdater boilerplate for update.electronjs.org in one function
-call — no configuration required. This module will search for the update.electronjs.org
-feed that matches your project's package.json `"repository"` field.
-
-First, install the module as a runtime dependency.
-
-```sh npm2yarn
-npm install update-electron-app
-```
-
-Then, import the module and call it immediately in the main process.
-
-```js title='main.js'
-require('update-electron-app')()
-```
-
-And that is all it takes! Once your application is packaged, it will update itself for each new
-GitHub release that you publish.
-
-## Summary
-
-In this tutorial, we configured Electron Forge's GitHub Publisher to upload your app's
-distributables to GitHub releases. Since distributables cannot always be generated
-between platforms, we recommend setting up your building and publishing flow
-in a Continuous Integration pipeline if you do not have access to machines.
-
-Electron applications can self-update by pointing the autoUpdater module to an update server feed.
-update.electronjs.org is a free update server provided by Electron for open-source applications
-published on GitHub releases. Configuring your Electron app to use this service is as easy as
-installing and importing the `update-electron-app` module.
-
-If your application is not eligible for update.electronjs.org, you should instead deploy your
-own update server and configure the autoUpdater module yourself.
-
-:::info 🌟 You're done!
-
-From here, you have officially completed our tutorial to Electron. Feel free to explore the
-rest of our docs and happy developing! If you have questions, please stop by our community
-[Discord server].
-
-:::
-
-[autoupdater]: ../api/auto-updater.md
-[code-signed]: ./code-signing.md
-[discord server]: https://discord.com/invite/APGC3k5yaH
-[electron fiddle]: https://electronjs.org/fiddle
-[fiddle-build]: https://github.com/electron/fiddle/blob/master/.github/workflows/build.yaml
-[fiddle-forge-config]: https://github.com/electron/fiddle/blob/master/forge.config.js
-[github actions]: https://github.com/features/actions
-[github publisher]: https://www.electronforge.io/config/publishers/github
-[github releases]: https://docs.github.com/en/repositories/releasing-projects-on-github/managing-releases-in-a-repository
-[git tag]: https://git-scm.com/book/en/v2/Git-Basics-Tagging
-[new-pat]: https://github.com/settings/tokens/new
-[publish command]: https://www.electronforge.io/cli#publish
-[publisher]: https://www.electronforge.io/config/publishers
-[`publishergithubconfig`]: https://js.electronforge.io/publisher/github/interfaces/publishergithubconfig
-[`update-electron-app`]: https://github.com/electron/update-electron-app
-[update-server]: ./updates.md
-
-<!-- Tutorial links -->
-
-[prerequisites]: tutorial-1-prerequisites.md
-[building your first app]: tutorial-2-first-app.md
-[preload]: tutorial-3-preload.md
-[features]: tutorial-4-adding-features.md
-[packaging]: tutorial-5-packaging.md
-[updates]: tutorial-6-publishing-updating.md

docs/tutorial/updates.md

@@ -1,16 +1,11 @@
----
-title: 'Updating Applications'
-description: "There are several ways to update an Electron application. The easiest and officially supported one is taking advantage of the built-in Squirrel framework and Electron's autoUpdater module."
-slug: updates
-hide_title: false
----
+# Updating Applications
 
-There are several ways to provide automatic updates to your Electron application.
-The easiest and officially supported one is taking advantage of the built-in
+There are several ways to update an Electron application. The easiest and
+officially supported one is taking advantage of the built-in
 [Squirrel](https://github.com/Squirrel) framework and
 Electron's [autoUpdater](../api/auto-updater.md) module.
 
-## Using update.electronjs.org
+## Using `update.electronjs.org`
 
 The Electron team maintains [update.electronjs.org], a free and open-source
 webservice that Electron apps can use to self-update. The service is designed
@@ -18,77 +13,72 @@ for Electron apps that meet the following criteria:
 
 - App runs on macOS or Windows
 - App has a public GitHub repository
-- Builds are published to [GitHub Releases][gh-releases]
-- Builds are [code-signed](./code-signing.md)
+- Builds are published to GitHub Releases
+- Builds are code-signed
 
 The easiest way to use this service is by installing [update-electron-app],
 a Node.js module preconfigured for use with update.electronjs.org.
 
-Install the module using your Node.js package manager of choice:
+Install the module:
 
-```sh npm2yarn
+```sh
 npm install update-electron-app
 ```
 
-Then, invoke the updater from your app's main process file:
+Invoke the updater from your app's main process file:
 
-```js title="main.js"
+```js
 require('update-electron-app')()
 ```
 
 By default, this module will check for updates at app startup, then every ten
-minutes. When an update is found, it will automatically be downloaded in the background.
-When the download completes, a dialog is displayed allowing the user to restart the app.
+minutes. When an update is found, it will automatically be downloaded in the background. When the download completes, a dialog is displayed allowing the user
+to restart the app.
 
 If you need to customize your configuration, you can
-[pass options to update-electron-app][update-electron-app]
+[pass options to `update-electron-app`][update-electron-app]
 or
 [use the update service directly][update.electronjs.org].
 
-## Using other update services
+## Deploying an Update Server
 
 If you're developing a private Electron application, or if you're not
 publishing releases to GitHub Releases, it may be necessary to run your own
 update server.
 
-### Step 1: Deploying an update server
-
 Depending on your needs, you can choose from one of these:
 
 - [Hazel][hazel] – Update server for private or open-source apps which can be
-  deployed for free on [Vercel][vercel]. It pulls from [GitHub Releases][gh-releases]
-  and leverages the power of GitHub's CDN.
+deployed for free on [Vercel][vercel]. It pulls from [GitHub Releases][gh-releases]
+and leverages the power of GitHub's CDN.
 - [Nuts][nuts] – Also uses [GitHub Releases][gh-releases], but caches app
-  updates on disk and supports private repositories.
+updates on disk and supports private repositories.
 - [electron-release-server][electron-release-server] – Provides a dashboard for
-  handling releases and does not require releases to originate on GitHub.
+handling releases and does not require releases to originate on GitHub.
 - [Nucleus][nucleus] – A complete update server for Electron apps maintained by
-  Atlassian. Supports multiple applications and channels; uses a static file store
-  to minify server cost.
+Atlassian. Supports multiple applications and channels; uses a static file store
+to minify server cost.
 
-Once you've deployed your update server, you can instrument your app code to receive and
-apply the updates with Electron's [autoUpdater] module.
+## Implementing Updates in Your App
 
-### Step 2: Receiving updates in your app
+Once you've deployed your update server, continue with importing the required
+modules in your code. The following code might vary for different server
+software, but it works like described when using
+[Hazel][hazel].
 
-First, import the required modules in your main process code. The following code might
-vary for different server software, but it works like described when using [Hazel][hazel].
+**Important:** Please ensure that the code below will only be executed in
+your packaged app, and not in development. You can use
+[electron-is-dev](https://github.com/sindresorhus/electron-is-dev) to check for
+the environment.
 
-:::warning Check your execution environment!
-
-Please ensure that the code below will only be executed in your packaged app, and not in development.
-You can use the [app.isPackaged](../api/app.md#appispackaged-readonly) API to check the environment.
-
-:::
-
-```javascript title='main.js'
+```javascript
 const { app, autoUpdater, dialog } = require('electron')
 ```
 
-Next, construct the URL of the update server feed and tell
+Next, construct the URL of the update server and tell
 [autoUpdater](../api/auto-updater.md) about it:
 
-```javascript title='main.js'
+```javascript
 const server = 'https://your-deployment-url.com'
 const url = `${server}/update/${process.platform}/${app.getVersion()}`
 
@@ -97,32 +87,32 @@ autoUpdater.setFeedURL({ url })
 
 As the final step, check for updates. The example below will check every minute:
 
-```javascript title='main.js'
+```javascript
 setInterval(() => {
   autoUpdater.checkForUpdates()
 }, 60000)
 ```
 
-Once your application is [packaged](./application-distribution.md),
+Once your application is [packaged](../tutorial/application-distribution.md),
 it will receive an update for each new
 [GitHub Release](https://help.github.com/articles/creating-releases/) that you
 publish.
 
-### Step 3: Notifying users when updates are available
+## Applying Updates
 
 Now that you've configured the basic update mechanism for your application, you
 need to ensure that the user will get notified when there's an update. This
-can be achieved using the [autoUpdater API events](../api/auto-updater.md#events):
+can be achieved using the autoUpdater API
+[events](../api/auto-updater.md#events):
 
-```javascript title="main.js"
+```javascript
 autoUpdater.on('update-downloaded', (event, releaseNotes, releaseName) => {
   const dialogOpts = {
     type: 'info',
     buttons: ['Restart', 'Later'],
     title: 'Application Update',
     message: process.platform === 'win32' ? releaseNotes : releaseName,
-    detail:
-      'A new version has been downloaded. Restart the application to apply the updates.',
+    detail: 'A new version has been downloaded. Restart the application to apply the updates.'
   }
 
   dialog.showMessageBox(dialogOpts).then((returnValue) => {
@@ -135,22 +125,16 @@ Also make sure that errors are
 [being handled](../api/auto-updater.md#event-error). Here's an example
 for logging them to `stderr`:
 
-```javascript title="main.js"
-autoUpdater.on('error', (message) => {
+```javascript
+autoUpdater.on('error', message => {
   console.error('There was a problem updating the application')
   console.error(message)
 })
 ```
 
-:::info Handling updates manually
+## Handling Updates Manually
 
-Because the requests made by autoUpdate aren't under your direct control, you may find situations
-that are difficult to handle (such as if the update server is behind authentication). The `url`
-field supports the `file://` protocol, which means that with some effort, you can sidestep the
-server-communication aspect of the process by loading your update from a local directory.
-[Here's an example of how this could work](https://github.com/electron/electron/issues/5020#issuecomment-477636990).
-
-:::
+Because the requests made by Auto Update aren't under your direct control, you may find situations that are difficult to handle (such as if the update server is behind authentication). The `url` field does support files, which means that with some effort, you can sidestep the server-communication aspect of the process. [Here's an example of how this could work](https://github.com/electron/electron/issues/5020#issuecomment-477636990).
 
 [vercel]: https://vercel.com
 [hazel]: https://github.com/vercel/hazel

docs/tutorial/windows-taskbar.md

@@ -41,9 +41,10 @@ as quoted from [MSDN][msdn-jumplist]:
 > confuse the user who does not expect that portion of the destination list to
 > change.
 
-![Taskbar JumpList](../images/windows-taskbar-jumplist.png)
+![IE](https://i-msdn.sec.s-msft.com/dynimg/IC420539.png)
 
-> NOTE: The screenshot above is an example of general tasks for Microsoft Edge
+> NOTE: The screenshot above is an example of general tasks of
+Internet Explorer
 
 Unlike the dock menu in macOS which is a real menu, user tasks in Windows work
 like application shortcuts. For example, when a user clicks a task, the program
@@ -108,7 +109,7 @@ As quoted from [MSDN][msdn-thumbnail]:
 > For example, Windows Media Player might offer standard media transport controls
 > such as play, pause, mute, and stop.
 
-![Thumbnail toolbar](../images/windows-taskbar-thumbnail-toolbar.png)
+![player](https://i-msdn.sec.s-msft.com/dynimg/IC420540.png)
 
 > NOTE: The screenshot above is an example of thumbnail toolbar of Windows
 Media Player
@@ -175,7 +176,7 @@ As quoted from [MSDN][msdn-icon-overlay]:
 > network status, messenger status, or new mail. The user should not be
 > presented with constantly changing overlays or animations.
 
-![Overlay on taskbar button](../images/windows-taskbar-icon-overlay.png)
+![Overlay on taskbar button](https://i-msdn.sec.s-msft.com/dynimg/IC420441.png)
 
 > NOTE: The screenshot above is an example of overlay on a taskbar button
 

electron_paks.gni

@@ -54,6 +54,8 @@ template("electron_extra_paks") {
                            ])
     output = "${invoker.output_dir}/resources.pak"
     sources = [
+      "$root_gen_dir/chrome/browser_resources.pak",
+      "$root_gen_dir/chrome/common_resources.pak",
       "$root_gen_dir/chrome/dev_ui_browser_resources.pak",
       "$root_gen_dir/components/components_resources.pak",
       "$root_gen_dir/content/browser/resources/media/media_internals_resources.pak",
@@ -65,10 +67,13 @@ template("electron_extra_paks") {
       "$root_gen_dir/net/net_resources.pak",
       "$root_gen_dir/third_party/blink/public/resources/blink_resources.pak",
       "$root_gen_dir/third_party/blink/public/resources/inspector_overlay_resources.pak",
+      "$root_gen_dir/ui/resources/webui_resources.pak",
       "$target_gen_dir/electron_resources.pak",
     ]
     deps = [
       "//chrome/browser:dev_ui_browser_resources",
+      "//chrome/browser:resources",
+      "//chrome/common:resources",
       "//components/resources",
       "//content:content_resources",
       "//content:dev_ui_content_resources",
@@ -172,22 +177,26 @@ template("electron_paks") {
     }
 
     source_patterns = [
+      "${root_gen_dir}/chrome/locale_settings_",
       "${root_gen_dir}/chrome/platform_locale_settings_",
+      "${root_gen_dir}/chrome/generated_resources_",
+      "${root_gen_dir}/components/strings/components_locale_settings_",
       "${root_gen_dir}/components/strings/components_strings_",
+      "${root_gen_dir}/device/bluetooth/strings/bluetooth_strings_",
+      "${root_gen_dir}/services/strings/services_strings_",
       "${root_gen_dir}/third_party/blink/public/strings/blink_accessibility_strings_",
       "${root_gen_dir}/third_party/blink/public/strings/blink_strings_",
-      "${root_gen_dir}/device/bluetooth/strings/bluetooth_strings_",
-      "${root_gen_dir}/extensions/strings/extensions_strings_",
-      "${root_gen_dir}/services/strings/services_strings_",
       "${root_gen_dir}/ui/strings/app_locale_settings_",
       "${root_gen_dir}/ui/strings/ax_strings_",
       "${root_gen_dir}/ui/strings/ui_strings_",
     ]
     deps = [
+      "//chrome/app:generated_resources",
+      "//chrome/app/resources:locale_settings",
       "//chrome/app/resources:platform_locale_settings",
+      "//components/strings:components_locale_settings",
       "//components/strings:components_strings",
       "//device/bluetooth/strings",
-      "//extensions/strings",
       "//services/strings",
       "//third_party/blink/public/strings",
       "//third_party/blink/public/strings:accessibility_strings",

electron_resources.grd

@@ -11,15 +11,8 @@
     <output filename="electron_resources.pak" type="data_package" />
   </outputs>
   <release seq="1" allow_pseudo="false">
-    <messages fallback_to_english="true">
-      <!-- TODO(deepak1556): Add translations,
-           check https://www.chromium.org/developers/design-documents/ui-localization -->
-      <part file="electron_strings.grdp" />
-    </messages>
     <includes>
       <include name="IDR_CONTENT_SHELL_DEVTOOLS_DISCOVERY_PAGE" file="${target_gen_dir}/shell_devtools_discovery_page.html" use_base_dir="false" type="BINDATA" />
-      <include name="IDR_PDF_MANIFEST" file="../chrome/browser/resources/pdf/manifest.json" type="BINDATA" />
-      <include name="IDR_CRYPTOTOKEN_MANIFEST" file="../chrome/browser/resources/cryptotoken/manifest.json" type="BINDATA" />
     </includes>
   </release>
 </grit>

electron_strings.grdp

@@ -1,163 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<grit-part>
-  <!-- Windows Caption Buttons -->
-  <message name="IDS_APP_ACCNAME_CLOSE" desc="The accessible name for the Close button.">
-    Close
-  </message>
-  <message name="IDS_APP_ACCNAME_MINIMIZE" desc="The accessible name for the Minimize button.">
-    Minimize
-  </message>
-  <message name="IDS_APP_ACCNAME_MAXIMIZE" desc="The accessible name for the Maximize button.">
-    Maximize
-  </message>
-  <message name="IDS_APP_ACCNAME_RESTORE" desc="The accessible name for the Restore button.">
-    Restore
-  </message>
-
-  <!-- Printing Service -->
-  <message name="IDS_UTILITY_PROCESS_PRINTING_SERVICE_NAME" desc="The name of the utility process used for printing conversions.">
-    Printing Service
-  </message>
-  <message name="IDS_PRINT_INVALID_PRINTER_SETTINGS" desc="Message to display when selected printer is not reachable or its settings are invalid.">
-    The selected printer is not available or not installed correctly. <ph name="BR">&lt;br&gt;</ph> Check your printer or try selecting another printer.
-  </message>
-  <message name="IDS_DEFAULT_PRINT_DOCUMENT_TITLE" desc="Default title for a print document">
-    Untitled Document
-  </message>
-  <message name="IDS_UTILITY_PROCESS_PRINT_BACKEND_SERVICE_NAME" desc="The name of the utility process used for backend interactions with printer drivers.">
-    Print Backend Service
-  </message>
-
-  <!-- Desktop Capturer API -->
-  <message name="IDS_DESKTOP_MEDIA_PICKER_SINGLE_SCREEN_NAME" desc="Name for screens in the desktop media picker UI when there is only one monitor.">
-    Entire Screen
-  </message>
-  <message name="IDS_DESKTOP_MEDIA_PICKER_MULTIPLE_SCREEN_NAME" desc="Name for screens in the desktop media picker UI when there are multiple monitors.">
-    {SCREEN_INDEX, plural, =1{Screen #} other{Screen #}}
-  </message>
-
-  <!-- File Select Helper-->
-  <message name="IDS_IMAGE_FILES" desc="The description of the image file extensions in the select file dialog.">
-    Image Files
-  </message>
-  <message name="IDS_AUDIO_FILES" desc="The description of the audio file extensions in the select file dialog.">
-    Audio Files
-  </message>
-  <message name="IDS_VIDEO_FILES" desc="The description of the video file extensions in the select file dialog.">
-    Video Files
-  </message>
-  <message name="IDS_CUSTOM_FILES" desc="The description of the custom file extensions in the select file dialog.">
-    Custom Files
-  </message>
-  <message name="IDS_DEFAULT_DOWNLOAD_FILENAME" desc="Default name for downloaded files when we have no idea what they could be.">
-    download
-  </message>
-
-  <!-- Picture-in-Picture -->
-  <if expr="is_macosx">
-    <message name="IDS_PICTURE_IN_PICTURE_TITLE_TEXT" desc="Title of the Picture-in-Picture window. This appears in the system tray and window header.">
-      Picture in Picture
-    </message>
-  </if>
-  <if expr="not is_macosx">
-    <message name="IDS_PICTURE_IN_PICTURE_TITLE_TEXT" desc="Title of the Picture-in-Picture window. This appears in the system tray and window header.">
-      Picture in picture
-    </message>
-  </if>
-  <message name="IDS_PICTURE_IN_PICTURE_PAUSE_CONTROL_TEXT" desc="Text label of the pause control button. The button appears when the user hovers over the Picture-in-Picture window and the video is currently playing.">
-    Pause
-  </message>
-  <message name="IDS_PICTURE_IN_PICTURE_PLAY_CONTROL_TEXT" desc="Text label of the play control button. The button appears when the user hovers over the Picture-in-Picture window and the video is currently paused.">
-    Play
-  </message>
-  <message name="IDS_PICTURE_IN_PICTURE_REPLAY_CONTROL_TEXT" desc="Text label of the replay control button. The button appears when the user hovers over the Picture-in-Picture window and the video is ended.">
-    Play from the beginning
-  </message>
-  <message name="IDS_PICTURE_IN_PICTURE_BACK_TO_TAB_CONTROL_TEXT" desc="Text label of the back to tab control button. The button appears when the user hovers over the Picture-in-Picture window.">
-    Back to video player
-  </message>
-  <message name="IDS_PICTURE_IN_PICTURE_MUTE_CONTROL_TEXT" desc="Text label of the mute control button. The button appears when the user hovers over the Picture-in-Picture window and the video is currently unmuted.">
-    Mute
-  </message>
-  <message name="IDS_PICTURE_IN_PICTURE_UNMUTE_CONTROL_TEXT" desc="Text label of the mute control button. The button appears when the user hovers over the Picture-in-Picture window and the video is currently muted.">
-    Unmute
-  </message>
-  <message name="IDS_PICTURE_IN_PICTURE_SKIP_AD_CONTROL_TEXT" desc="Text label of the skip ad control button. The button appears when the user hovers over the Picture-in-Picture window.">
-    Skip Ad
-  </message>
-  <message name="IDS_PICTURE_IN_PICTURE_MUTE_MICROPHONE_TEXT" desc="Text label of the mute microphone control button. The button appears when the user hovers over the Picture-in-Picture window.">
-    Mute microphone
-  </message>
-  <message name="IDS_PICTURE_IN_PICTURE_UNMUTE_MICROPHONE_TEXT" desc="Text label of the unmute microphone control button. The button appears when the user hovers over the Picture-in-Picture window.">
-    Unmute microphone
-  </message>
-  <message name="IDS_PICTURE_IN_PICTURE_TURN_ON_CAMERA_TEXT" desc="Text label of the turn on camera control button. The button appears when the user hovers over the Picture-in-Picture window.">
-    Turn on camera
-  </message>
-  <message name="IDS_PICTURE_IN_PICTURE_TURN_OFF_CAMERA_TEXT" desc="Text label of the turn off camera control button. The button appears when the user hovers over the Picture-in-Picture window.">
-    Turn off camera
-  </message>
-  <message name="IDS_PICTURE_IN_PICTURE_HANG_UP_TEXT" desc="Text label of the hang up control button. The button appears when the user hovers over the Picture-in-Picture window.">
-    Hang up
-  </message>
-  <message name="IDS_PICTURE_IN_PICTURE_CLOSE_CONTROL_TEXT" desc="Text label of the close control button. The button appears when the user hovers over the Picture-in-Picture window.">
-    Close
-  </message>
-  <message name="IDS_PICTURE_IN_PICTURE_RESIZE_HANDLE_TEXT" desc="Text label of the resize handle. The button appears when the user hovers over the Picture-in-Picture window.">
-    Resize
-  </message>
-  <message name="IDS_PICTURE_IN_PICTURE_PLAY_PAUSE_CONTROL_ACCESSIBLE_TEXT" desc="Accessible text label used for the controls button in the Picture-in-Picture window. The button toggles between play and pause controls.">
-    Toggle video to play or pause
-  </message>
-  <message name="IDS_PICTURE_IN_PICTURE_MUTE_CONTROL_ACCESSIBLE_TEXT" desc="Accessible text label used for the controls button in the Picture-in-Picture window. The button toggles mute state.">
-    Toggle mute
-  </message>
-  <message name="IDS_PICTURE_IN_PICTURE_NEXT_TRACK_CONTROL_ACCESSIBLE_TEXT" desc="Accessible text label used for the controls button in the Picture-in-Picture window. The button invokes next track action.">
-    Next track
-  </message>
-  <message name="IDS_PICTURE_IN_PICTURE_PREVIOUS_TRACK_CONTROL_ACCESSIBLE_TEXT" desc="Accessible text label used for the controls button in the Picture-in-Picture window. The button invokes previous track action.">
-    Previous track
-  </message>
-  <message name="IDS_SPELLCHECK_DICTIONARY" use_name_for_id="true">
-    en-US
-  </message>
-  <message name="IDS_ACCEPT_LANGUAGES" use_name_for_id="true">
-    en-US,en
-  </message>
-  <if expr="is_win">
-    <message name="IDS_UTILITY_PROCESS_UTILITY_WIN_NAME" desc="The name of the utility process used to handle Windows utility operations.">
-      Windows Utilities
-    </message>
-  </if>
-  <message name="IDS_DOWNLOAD_MORE_ACTIONS"
-          desc="Tooltip of a button on the downloads page that shows a menu with actions like 'Open downloads folder' or 'Clear all'">
-    More actions
-  </message>
-  <!-- Badging -->
-  <message name="IDS_SATURATED_BADGE_CONTENT" desc="The content to display when the application's badge is too large to display to indicate that the badge is more than a given maximum. This string should be as short as possible, preferably only one character beyond the content">
-    <ph name="MAXIMUM_VALUE">$1<ex>99</ex></ph>+
-  </message>
-  <message name="IDS_BADGE_UNREAD_NOTIFICATIONS_SATURATED" desc="The accessibility text which will be read by a screen reader when the notification count is too large to display (e.g. greater than 99).">
-    {MAX_UNREAD_NOTIFICATIONS, plural, =1 {More than 1 unread notification} other {More than # unread notifications}}
-  </message>
-  <message name="IDS_BADGE_UNREAD_NOTIFICATIONS_UNSPECIFIED" desc="The accessibility text which will be read by a screen reader when there are some unspecified number of notifications, or user attention is required">
-    Unread Notifications
-  </message>
-  <message name="IDS_BADGE_UNREAD_NOTIFICATIONS" desc="The accessibility text which will be read by a screen reader when there are notifcatications">
-    {UNREAD_NOTIFICATIONS, plural, =1 {1 Unread Notification} other {# Unread Notifications}}
-  </message>
-  <message name="IDS_HID_CHOOSER_ITEM_WITHOUT_NAME" desc="User option displaying the device IDs for a Human Interface Device (HID) without a device name.">
-        Unknown Device (<ph name="DEVICE_ID">$1<ex>1234:abcd</ex></ph>) </message>
-  <if expr="is_win">
-    <then>
-      <message name="IDS_AX_UNLABELED_IMAGE_ROLE_DESCRIPTION" desc="Accessibility role description for a graphic (image) on a web page or PDF that does not have a description for blind users." is_accessibility_with_no_ui="true">
-        Unlabeled graphic
-      </message>
-    </then>
-    <else>
-      <message name="IDS_AX_UNLABELED_IMAGE_ROLE_DESCRIPTION" desc="Accessibility role description for an image on a web page or PDF that does not have a description for blind users." is_accessibility_with_no_ui="true">
-        Unlabeled image
-      </message>
-    </else>
-  </if>
-</grit-part>

filenames.gni

@@ -23,7 +23,6 @@ filenames = {
 
   lib_sources_linux = [
     "shell/browser/browser_linux.cc",
-    "shell/browser/electron_browser_main_parts_linux.cc",
     "shell/browser/lib/power_observer_linux.cc",
     "shell/browser/lib/power_observer_linux.h",
     "shell/browser/linux/unity_service.cc",
@@ -86,8 +85,6 @@ filenames = {
     "shell/browser/ui/message_box_win.cc",
     "shell/browser/ui/tray_icon_win.cc",
     "shell/browser/ui/views/electron_views_delegate_win.cc",
-    "shell/browser/ui/views/win_icon_painter.cc",
-    "shell/browser/ui/views/win_icon_painter.h",
     "shell/browser/ui/views/win_frame_view.cc",
     "shell/browser/ui/views/win_frame_view.h",
     "shell/browser/ui/views/win_caption_button.cc",

lib/browser/api/web-contents.ts

@@ -504,7 +504,6 @@ WebContents.prototype._callWindowOpenHandler = function (event: Electron.Event,
   if (!this._windowOpenHandler) {
     return defaultResponse;
   }
-
   const response = this._windowOpenHandler(details);
 
   if (typeof response !== 'object') {
@@ -667,15 +666,7 @@ WebContents.prototype._init = function () {
         postBody,
         disposition
       };
-
-      let result: ReturnType<typeof this._callWindowOpenHandler>;
-      try {
-        result = this._callWindowOpenHandler(event, details);
-      } catch (err) {
-        event.preventDefault();
-        throw err;
-      }
-
+      const result = this._callWindowOpenHandler(event, details);
       const options = result.browserWindowConstructorOptions;
       if (!event.defaultPrevented) {
         openGuestWindow({
@@ -706,15 +697,7 @@ WebContents.prototype._init = function () {
         referrer,
         postBody
       };
-
-      let result: ReturnType<typeof this._callWindowOpenHandler>;
-      try {
-        result = this._callWindowOpenHandler(event, details);
-      } catch (err) {
-        event.preventDefault();
-        throw err;
-      }
-
+      const result = this._callWindowOpenHandler(event, details);
       windowOpenOutlivesOpenerOption = result.outlivesOpener;
       windowOpenOverriddenOptions = result.browserWindowConstructorOptions;
       if (!event.defaultPrevented) {

lib/browser/guest-window-manager.ts

@@ -78,19 +78,6 @@ export function openGuestWindow ({ event, embedder, guest, referrer, disposition
     ...browserWindowOptions
   });
 
-  if (!guest) {
-    // When we open a new window from a link (via OpenURLFromTab),
-    // the browser process is responsible for initiating navigation
-    // in the new window.
-    window.loadURL(url, {
-      httpReferrer: referrer,
-      ...(postData && {
-        postData,
-        extraHeaders: formatPostDataHeaders(postData as Electron.UploadRawData[])
-      })
-    });
-  }
-
   handleWindowLifecycleEvents({ embedder, frameName, guest: window, outlivesOpener });
 
   embedder.emit('did-create-window', window, { url, frameName, options: browserWindowOptions, disposition, referrer, postData });
@@ -256,15 +243,6 @@ export function makeWebPreferences ({ embedder, secureOverrideWebPreferences = {
   };
 }
 
-function formatPostDataHeaders (postData: PostData) {
-  if (!postData) return;
-
-  const { contentType, boundary } = parseContentTypeFormat(postData);
-  if (boundary != null) { return `content-type: ${contentType}; boundary=${boundary}`; }
-
-  return `content-type: ${contentType}`;
-}
-
 const MULTIPART_CONTENT_TYPE = 'multipart/form-data';
 const URL_ENCODED_CONTENT_TYPE = 'application/x-www-form-urlencoded';
 

lib/renderer/security-warnings.ts

@@ -1,8 +1,7 @@
+import { webFrame } from 'electron';
 import { ipcRendererInternal } from '@electron/internal/renderer/ipc-renderer-internal';
 import { IPC_MESSAGES } from '@electron/internal/common/ipc-messages';
 
-const { mainFrame: webFrame } = process._linkedBinding('electron_renderer_web_frame');
-
 let shouldLog: boolean | null = null;
 
 const { platform, execPath, env } = process;

package.json

@@ -1,6 +1,6 @@
 {
   "name": "electron",
-  "version": "19.0.15",
+  "version": "20.0.0-nightly.20220425",
   "repository": "https://github.com/electron/electron",
   "description": "Build cross platform desktop apps with JavaScript, HTML, and CSS",
   "devDependencies": {
@@ -77,7 +77,7 @@
   "scripts": {
     "asar": "asar",
     "generate-version-json": "node script/generate-version-json.js",
-    "lint": "node ./script/lint.js && npm run lint:docs",
+    "lint": "node ./script/lint.js && npm run lint:clang-format && npm run lint:docs",
     "lint:js": "node ./script/lint.js --js",
     "lint:clang-format": "python3 script/run-clang-format.py -r -c shell/ || (echo \"\\nCode not formatted correctly.\" && exit 1)",
     "lint:clang-tidy": "ts-node ./script/run-clang-tidy.ts",
@@ -94,7 +94,6 @@
     "gn-typescript-definitions": "npm run create-typescript-definitions && shx cp electron.d.ts",
     "pre-flight": "pre-flight",
     "gn-check": "node ./script/gn-check.js",
-    "gn-format": "python3 script/run-gn-format.py",
     "precommit": "lint-staged",
     "preinstall": "node -e 'process.exit(0)'",
     "prepack": "check-for-leaks",
@@ -125,7 +124,7 @@
     ],
     "*.{gn,gni}": [
       "npm run gn-check",
-      "npm run gn-format"
+      "python3 script/run-gn-format.py"
     ],
     "*.py": [
       "node script/lint.js --py --fix --only --"

patches/angle/.patches

@@ -1,2 +0,0 @@
-m104_vulkan_fix_garbage_collection_vs_outside-rp-only_flush.patch
-m104_vulkan_fix_xfb_buffer_redefine_to_smaller_size.patch

patches/angle/m104_vulkan_fix_garbage_collection_vs_outside-rp-only_flush.patch

@@ -1,287 +0,0 @@
-From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
-From: Shahbaz Youssefi <syoussefi@chromium.org>
-Date: Thu, 4 Aug 2022 12:28:12 -0400
-Subject: M104: Vulkan: Fix garbage collection vs outside-RP-only flush
-
-In https://chromium-review.googlesource.com/c/angle/angle/+/3379231, an
-optimization was implemented such that the excessive recorded texture
-uploads would get flushed early and submitted.  This caused a
-use-after-free bug in the following situation:
-
-* Draw with pipeline A
-* Delete A <--- this puts A in the Context garbage list
-* Upload a lot of data
-
-At this point, the flush threshold could pass and the commands recorded
-outside of the render pass up to this point would be submitted.
-Associated with this submission was the current garbage, including
-pipeline A.  However, the render pass that uses pipeline A is still not
-submitted.
-
-Now if after some time the render pass is still open, but the "completed
-commands" are checked (another set of uploads causing another
-submission, a query status check, etc), the garbage can be cleaned up.
-
-When the render pass closes next and is submitted, the implementation
-attempts to use the pipeline, which is already deleted.
-
-In this change, outside-render-pass-only submissions no longer reference
-the current garbage.  This has the side effect that the temporary
-buffers used for uploading texture data won't be released early.  A
-future optimization may want to separate the garbage list in ContextVk
-to render pass and outside render pass garbage.
-
-Bug: chromium:1337538
-Change-Id: Ibfc11f2b0d166b0c325fced725f23d6b9328ff98
-Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3821371
-Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
-
-diff --git a/src/libANGLE/renderer/vulkan/ContextVk.cpp b/src/libANGLE/renderer/vulkan/ContextVk.cpp
-index 90ecf42b2cc22cee5b74296d7a2f73b77f9a0f2c..41c06dc42810d6c55565686c87adf20367024f05 100644
---- a/src/libANGLE/renderer/vulkan/ContextVk.cpp
-+++ b/src/libANGLE/renderer/vulkan/ContextVk.cpp
-@@ -2614,14 +2614,16 @@ void ContextVk::addOverlayUsedBuffersCount(vk::CommandBufferHelperCommon *comman
-     }
- }
- 
--angle::Result ContextVk::submitFrame(const vk::Semaphore *signalSemaphore, Serial *submitSerialOut)
-+angle::Result ContextVk::submitFrame(const vk::Semaphore *signalSemaphore,
-+                                     Submit submission,
-+                                     Serial *submitSerialOut)
- {
-     getShareGroupVk()->acquireResourceUseList(
-         std::move(mOutsideRenderPassCommands->getResourceUseList()));
-     getShareGroupVk()->acquireResourceUseList(std::move(mResourceUseList));
-     getShareGroupVk()->acquireResourceUseList(std::move(mRenderPassCommands->getResourceUseList()));
- 
--    ANGLE_TRY(submitCommands(signalSemaphore, submitSerialOut));
-+    ANGLE_TRY(submitCommands(signalSemaphore, submission, submitSerialOut));
- 
-     onRenderPassFinished(RenderPassClosureReason::AlreadySpecifiedElsewhere);
-     return angle::Result::Continue;
-@@ -2633,10 +2635,11 @@ angle::Result ContextVk::submitFrameOutsideCommandBufferOnly(Serial *submitSeria
-     getShareGroupVk()->acquireResourceUseList(
-         std::move(mOutsideRenderPassCommands->getResourceUseList()));
- 
--    return submitCommands(nullptr, submitSerialOut);
-+    return submitCommands(nullptr, Submit::OutsideRenderPassCommandsOnly, submitSerialOut);
- }
- 
- angle::Result ContextVk::submitCommands(const vk::Semaphore *signalSemaphore,
-+                                        Submit submission,
-                                         Serial *submitSerialOut)
- {
-     if (mCurrentWindowSurface)
-@@ -2655,10 +2658,18 @@ angle::Result ContextVk::submitCommands(const vk::Semaphore *signalSemaphore,
-         dumpCommandStreamDiagnostics();
-     }
- 
-+    // Clean up garbage only when submitting all commands.  Otherwise there may be garbage
-+    // associated with commands that are not yet flushed.
-+    vk::GarbageList garbage;
-+    if (submission == Submit::AllCommands)
-+    {
-+        garbage = std::move(mCurrentGarbage);
-+    }
-+
-     ANGLE_TRY(mRenderer->submitFrame(this, hasProtectedContent(), mContextPriority,
-                                      std::move(mWaitSemaphores),
-                                      std::move(mWaitSemaphoreStageMasks), signalSemaphore,
--                                     std::move(mCurrentGarbage), &mCommandPools, submitSerialOut));
-+                                     std::move(garbage), &mCommandPools, submitSerialOut));
- 
-     getShareGroupVk()->releaseResourceUseLists(*submitSerialOut);
-     // Now that we have processed resourceUseList, some of pending garbage may no longer pending
-@@ -6128,7 +6139,7 @@ angle::Result ContextVk::flushAndGetSerial(const vk::Semaphore *signalSemaphore,
-         mHasInFlightStreamedVertexBuffers.reset();
-     }
- 
--    ANGLE_TRY(submitFrame(signalSemaphore, submitSerialOut));
-+    ANGLE_TRY(submitFrame(signalSemaphore, Submit::AllCommands, submitSerialOut));
- 
-     resetPerFramePerfCounters();
- 
-diff --git a/src/libANGLE/renderer/vulkan/ContextVk.h b/src/libANGLE/renderer/vulkan/ContextVk.h
-index 6c6a3797c6e9a387abf13442613088bd5f4341ec..8ed00be4eb19fea01bb2ada65d2c05ad1d3284f4 100644
---- a/src/libANGLE/renderer/vulkan/ContextVk.h
-+++ b/src/libANGLE/renderer/vulkan/ContextVk.h
-@@ -1078,9 +1078,19 @@ class ContextVk : public ContextImpl, public vk::Context, public MultisampleText
- 
-     void writeAtomicCounterBufferDriverUniformOffsets(uint32_t *offsetsOut, size_t offsetsSize);
- 
--    angle::Result submitFrame(const vk::Semaphore *signalSemaphore, Serial *submitSerialOut);
-+    enum class Submit
-+    {
-+        OutsideRenderPassCommandsOnly,
-+        AllCommands,
-+    };
-+
-+    angle::Result submitFrame(const vk::Semaphore *signalSemaphore,
-+                              Submit submission,
-+                              Serial *submitSerialOut);
-     angle::Result submitFrameOutsideCommandBufferOnly(Serial *submitSerialOut);
--    angle::Result submitCommands(const vk::Semaphore *signalSemaphore, Serial *submitSerialOut);
-+    angle::Result submitCommands(const vk::Semaphore *signalSemaphore,
-+                                 Submit submission,
-+                                 Serial *submitSerialOut);
- 
-     angle::Result synchronizeCpuGpuTime();
-     angle::Result traceGpuEventImpl(vk::OutsideRenderPassCommandBuffer *commandBuffer,
-diff --git a/src/tests/gl_tests/VulkanPerformanceCounterTest.cpp b/src/tests/gl_tests/VulkanPerformanceCounterTest.cpp
-index a5021e3248933815e3ac43cc0477671109befb1e..1a4e35592d0573991cc54136c80a9299714162a4 100644
---- a/src/tests/gl_tests/VulkanPerformanceCounterTest.cpp
-+++ b/src/tests/gl_tests/VulkanPerformanceCounterTest.cpp
-@@ -18,6 +18,7 @@
- #include "test_utils/gl_raii.h"
- #include "util/random_utils.h"
- #include "util/shader_utils.h"
-+#include "util/test_utils.h"
- 
- using namespace angle;
- 
-@@ -561,22 +562,21 @@ TEST_P(VulkanPerformanceCounterTest, NewTextureDoesNotBreakRenderPass)
- TEST_P(VulkanPerformanceCounterTest, SubmittingOutsideCommandBufferDoesNotBreakRenderPass)
- {
-     initANGLEFeatures();
--    // http://anglebug.com/6354
- 
--    size_t kMaxBufferToImageCopySize     = 1 << 28;
--    uint32_t kNumSubmits                 = 2;
--    uint32_t expectedRenderPassCount     = getPerfCounters().renderPasses + 1;
--    uint32_t expectedSubmitCommandsCount = getPerfCounters().submittedCommands + kNumSubmits;
-+    constexpr size_t kMaxBufferToImageCopySize     = 1 << 28;
-+    constexpr uint32_t kNumSubmits                 = 2;
-+    uint32_t expectedRenderPassCount               = getPerfCounters().renderPasses + 1;
-+    uint32_t expectedSubmitCommandsCount           = getPerfCounters().submittedCommands + kNumSubmits;
- 
-     // Step 1: Set up a simple 2D texture.
-     GLTexture texture;
--    GLsizei texDim         = 256;
--    uint32_t pixelSizeRGBA = 4;
--    uint32_t textureSize   = texDim * texDim * pixelSizeRGBA;
--    std::vector<GLColor> kInitialData(texDim * texDim, GLColor::green);
-+    constexpr GLsizei kTexDim         = 256;
-+    constexpr uint32_t kPixelSizeRGBA = 4;
-+    constexpr uint32_t kTextureSize   = kTexDim * kTexDim * kPixelSizeRGBA;
-+    std::vector<GLColor> kInitialData(kTexDim * kTexDim, GLColor::green);
- 
-     glBindTexture(GL_TEXTURE_2D, texture);
--    glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, texDim, texDim, 0, GL_RGBA, GL_UNSIGNED_BYTE,
-+    glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, kTexDim, kTexDim, 0, GL_RGBA, GL_UNSIGNED_BYTE,
-                  kInitialData.data());
-     glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST);
-     glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST);
-@@ -603,13 +603,12 @@ TEST_P(VulkanPerformanceCounterTest, SubmittingOutsideCommandBufferDoesNotBreakR
- 
-     // Step 2: Load a new 2D Texture multiple times with the same Program and Framebuffer. The total
-     // size of the loaded textures must exceed the threshold to submit the outside command buffer.
--    auto maxLoadCount =
--        static_cast<size_t>((kMaxBufferToImageCopySize / textureSize) * kNumSubmits + 1);
--    for (size_t loadCount = 0; loadCount < maxLoadCount; loadCount++)
-+    constexpr size_t kMaxLoadCount = kMaxBufferToImageCopySize / kTextureSize * kNumSubmits + 1;
-+    for (size_t loadCount = 0; loadCount < kMaxLoadCount; loadCount++)
-     {
-         GLTexture newTexture;
-         glBindTexture(GL_TEXTURE_2D, newTexture);
--        glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, texDim, texDim, 0, GL_RGBA, GL_UNSIGNED_BYTE,
-+        glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, kTexDim, kTexDim, 0, GL_RGBA, GL_UNSIGNED_BYTE,
-                      kInitialData.data());
-         glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST);
-         glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST);
-@@ -623,6 +622,96 @@ TEST_P(VulkanPerformanceCounterTest, SubmittingOutsideCommandBufferDoesNotBreakR
-     EXPECT_EQ(getPerfCounters().submittedCommands, expectedSubmitCommandsCount);
- }
- 
-+// Tests that submitting the outside command buffer due to texture upload size does not result in
-+// garbage collection of render pass resources..
-+TEST_P(VulkanPerformanceCounterTest, SubmittingOutsideCommandBufferDoesNotCollectRenderPassGarbage)
-+{
-+    ANGLE_SKIP_TEST_IF(!IsGLExtensionEnabled("GL_EXT_disjoint_timer_query"));
-+
-+    initANGLEFeatures();
-+
-+    uint64_t expectedRenderPassCount = getPerfCounters().renderPasses + 1;
-+    uint64_t submitCommandsCount     = getPerfCounters().vkQueueSubmitCallsTotal;
-+
-+    // Set up a simple 2D texture.
-+    GLTexture texture;
-+    constexpr GLsizei kTexDim = 256;
-+    std::vector<GLColor> kInitialData(kTexDim * kTexDim, GLColor::green);
-+
-+    glBindTexture(GL_TEXTURE_2D, texture);
-+    glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, kTexDim, kTexDim, 0, GL_RGBA, GL_UNSIGNED_BYTE,
-+                 kInitialData.data());
-+    glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST);
-+    glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST);
-+
-+    auto quadVerts = GetQuadVertices();
-+
-+    GLBuffer vertexBuffer;
-+    glBindBuffer(GL_ARRAY_BUFFER, vertexBuffer);
-+    glBufferData(GL_ARRAY_BUFFER, quadVerts.size() * sizeof(quadVerts[0]), quadVerts.data(),
-+                 GL_STATIC_DRAW);
-+
-+    ANGLE_GL_PROGRAM(program, essl1_shaders::vs::Texture2D(), essl1_shaders::fs::Texture2D());
-+    glUseProgram(program);
-+
-+    GLint posLoc = glGetAttribLocation(program, essl1_shaders::PositionAttrib());
-+    ASSERT_NE(-1, posLoc);
-+
-+    glVertexAttribPointer(posLoc, 3, GL_FLOAT, GL_FALSE, 0, nullptr);
-+    glEnableVertexAttribArray(posLoc);
-+    ASSERT_GL_NO_ERROR();
-+
-+    // Issue a timestamp query, just for the sake of using it as a means of knowing when a
-+    // submission is finished.  In the Vulkan backend, querying the status of the query results in a
-+    // check of completed submissions, at which point associated garbage is also destroyed.
-+    GLQuery query;
-+    glQueryCounterEXT(query, GL_TIMESTAMP_EXT);
-+
-+    // Issue a draw call, and delete the program
-+    glDrawArrays(GL_TRIANGLES, 0, 6);
-+    ASSERT_GL_NO_ERROR();
-+    program.reset();
-+
-+    ANGLE_GL_PROGRAM(program2, essl1_shaders::vs::Texture2D(), essl1_shaders::fs::Texture2D());
-+    glUseProgram(program2);
-+    ASSERT_EQ(posLoc, glGetAttribLocation(program2, essl1_shaders::PositionAttrib()));
-+
-+    // Issue uploads until there's an implicit submission
-+    while (getPerfCounters().vkQueueSubmitCallsTotal == submitCommandsCount)
-+    {
-+        GLTexture newTexture;
-+        glBindTexture(GL_TEXTURE_2D, newTexture);
-+        glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, kTexDim, kTexDim, 0, GL_RGBA, GL_UNSIGNED_BYTE,
-+                     kInitialData.data());
-+        glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST);
-+        glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST);
-+
-+        glDrawArrays(GL_TRIANGLES, 0, 6);
-+        ASSERT_GL_NO_ERROR();
-+    }
-+
-+    ++submitCommandsCount;
-+    EXPECT_EQ(getPerfCounters().vkQueueSubmitCallsTotal, submitCommandsCount);
-+
-+    // Busy wait until the query results are available.
-+    GLuint ready = GL_FALSE;
-+    while (ready == GL_FALSE)
-+    {
-+        angle::Sleep(0);
-+        glGetQueryObjectuivEXT(query, GL_QUERY_RESULT_AVAILABLE_EXT, &ready);
-+    }
-+
-+    // At this point, the render pass should still not be submitted, and the pipeline that is
-+    // deleted should still not be garbage collected.  Submit the commands and ensure there is no
-+    // crash.
-+    EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor::green);
-+    ++submitCommandsCount;
-+
-+    // Verify counters.
-+    EXPECT_EQ(getPerfCounters().renderPasses, expectedRenderPassCount);
-+    EXPECT_EQ(getPerfCounters().vkQueueSubmitCallsTotal, submitCommandsCount);
-+}
-+
- // Tests that RGB texture should not break renderpass.
- TEST_P(VulkanPerformanceCounterTest, SampleFromRGBTextureDoesNotBreakRenderPass)
- {

patches/angle/m104_vulkan_fix_xfb_buffer_redefine_to_smaller_size.patch

@@ -1,122 +0,0 @@
-From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
-From: Shahbaz Youssefi <syoussefi@chromium.org>
-Date: Tue, 26 Jul 2022 21:07:04 -0400
-Subject: M104: Vulkan: Fix xfb buffer redefine to smaller size
-
-In 89e11878b275b15735eaf273ababfa6fd43a2e3d, a use-after-free bug was
-fixed where glBufferData redefined a buffer, leading to a change in
-storage.  This was only tested for the case where the new buffer was
-larger than the old buffer.
-
-When the new buffer is smaller however, another issue remains where the
-buffer size as cached by the transform feedback object used the old
-object's size.  This is worked around in this change, with a fix for the
-real issue (that the buffer state is updated after calling into the
-backend instead of before) coming up.
-
-Bug: chromium:1345042
-Change-Id: I7bafd51b6203a419e5ef123da26b9e1eaf079bf1
-Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3812556
-Reviewed-by: Ian Elliott <ianelliott@google.com>
-
-diff --git a/src/libANGLE/renderer/vulkan/BufferVk.cpp b/src/libANGLE/renderer/vulkan/BufferVk.cpp
-index 9c9cee78d890f5cc13d8762aa03de9dcf9c00abf..ceb065822984cf44bd4319fb97cb7e4dd49517b2 100644
---- a/src/libANGLE/renderer/vulkan/BufferVk.cpp
-+++ b/src/libANGLE/renderer/vulkan/BufferVk.cpp
-@@ -798,6 +798,7 @@ angle::Result BufferVk::updateBuffer(ContextVk *contextVk,
-     }
-     return angle::Result::Continue;
- }
-+
- angle::Result BufferVk::directUpdate(ContextVk *contextVk,
-                                      const uint8_t *data,
-                                      size_t size,
-diff --git a/src/libANGLE/renderer/vulkan/ContextVk.cpp b/src/libANGLE/renderer/vulkan/ContextVk.cpp
-index 41c06dc42810d6c55565686c87adf20367024f05..1319bf771339210dcb9a3e0ccd0936112c746582 100644
---- a/src/libANGLE/renderer/vulkan/ContextVk.cpp
-+++ b/src/libANGLE/renderer/vulkan/ContextVk.cpp
-@@ -799,7 +799,8 @@ ContextVk::ContextVk(const gl::State &state, gl::ErrorSet *errorSet, RendererVk
-                                                    DIRTY_BIT_DRIVER_UNIFORMS_BINDING,
-                                                    DIRTY_BIT_VIEWPORT,
-                                                    DIRTY_BIT_SCISSOR};
--    if (getFeatures().supportsTransformFeedbackExtension.enabled)
-+    if (getFeatures().supportsTransformFeedbackExtension.enabled ||
-+        getFeatures().emulateTransformFeedback.enabled)
-     {
-         mNewGraphicsCommandBufferDirtyBits.set(DIRTY_BIT_TRANSFORM_FEEDBACK_BUFFERS);
-     }
-diff --git a/src/libANGLE/renderer/vulkan/TransformFeedbackVk.cpp b/src/libANGLE/renderer/vulkan/TransformFeedbackVk.cpp
-index dbaa4eeedbf36c4a3f6cb818b50bdcac856766c2..f785fe5f7c36033163a77a7e29957ebca6edaf79 100644
---- a/src/libANGLE/renderer/vulkan/TransformFeedbackVk.cpp
-+++ b/src/libANGLE/renderer/vulkan/TransformFeedbackVk.cpp
-@@ -362,7 +362,8 @@ void TransformFeedbackVk::onSubjectStateChange(angle::SubjectIndex index,
-         ASSERT(bufferVk->isBufferValid());
-         mBufferHelpers[index] = &bufferVk->getBuffer();
-         mBufferOffsets[index] = binding.getOffset() + mBufferHelpers[index]->getOffset();
--        mBufferSizes[index]   = gl::GetBoundBufferAvailableSize(binding);
-+        mBufferSizes[index]   = std::min<VkDeviceSize>(gl::GetBoundBufferAvailableSize(binding),
-+                                                     mBufferHelpers[index]->getSize());
-         mBufferObserverBindings[index].bind(bufferVk);
- 
-         mXFBBuffersDesc.updateTransformFeedbackBuffer(
-diff --git a/src/tests/angle_end2end_tests_expectations.txt b/src/tests/angle_end2end_tests_expectations.txt
-index af74f258fb3d901dac8a738ca9be53511963137b..22230db0ecb77f16cb2cc494a74225731401a47d 100644
---- a/src/tests/angle_end2end_tests_expectations.txt
-+++ b/src/tests/angle_end2end_tests_expectations.txt
-@@ -161,6 +161,7 @@
- 6738 MAC AMD OPENGL : Texture3DTestES3.PixelUnpackStateTex* = SKIP
- 1296467 MAC OPENGL : VertexAttributeTestES3.emptyBuffer/* = SKIP
- 7203 MAC INTEL OPENGL : CopyTextureTest.CopyToMipmap/* = SKIP
-+7530 MAC NVIDIA OPENGL : TransformFeedbackTest.RenderOnceChangeXfbBufferRenderAgain/* = SKIP
- 
- // BlitFramebufferTest.ScissoredMultisampleStencil failures
- 3496 MAC INTEL OPENGL : BlitFramebufferTest.ScissoredMultisampleStencil/* = SKIP
-diff --git a/src/tests/gl_tests/TransformFeedbackTest.cpp b/src/tests/gl_tests/TransformFeedbackTest.cpp
-index a4e4f86157232de46c6e06ee7b5a6dfa2b8a2261..dc944d4249e0a26708d01bd0bde7efc4d68db3e3 100644
---- a/src/tests/gl_tests/TransformFeedbackTest.cpp
-+++ b/src/tests/gl_tests/TransformFeedbackTest.cpp
-@@ -403,7 +403,6 @@ TEST_P(TransformFeedbackTest, RecordAndDraw)
- // Test that transform feedback can cover multiple render passes.
- TEST_P(TransformFeedbackTest, SpanMultipleRenderPasses)
- {
--
-     // TODO(anglebug.com/4533) This fails after the upgrade to the 26.20.100.7870 driver.
-     ANGLE_SKIP_TEST_IF(IsWindows() && IsIntel() && IsVulkan());
- 
-@@ -4105,6 +4104,36 @@ TEST_P(TransformFeedbackTest, ResumingTransformFeedbackAfterDeletebuffer)
-     ASSERT_GL_ERROR(GL_INVALID_OPERATION);
- }
- 
-+// Test that redefining the transform feedback buffer and starting a new render pass works.
-+TEST_P(TransformFeedbackTest, RenderOnceChangeXfbBufferRenderAgain)
-+{
-+    std::vector<std::string> tfVaryings;
-+    tfVaryings.push_back("gl_Position");
-+    ANGLE_GL_PROGRAM_TRANSFORM_FEEDBACK(drawColor, essl3_shaders::vs::Simple(),
-+                                        essl3_shaders::fs::Red(), tfVaryings,
-+                                        GL_INTERLEAVED_ATTRIBS);
-+
-+    GLBuffer buffer;
-+    glBindBufferBase(GL_TRANSFORM_FEEDBACK_BUFFER, 0, buffer);
-+    glBufferData(GL_TRANSFORM_FEEDBACK_BUFFER, 10'000'000, nullptr, GL_DYNAMIC_READ);
-+
-+    glUseProgram(drawColor);
-+    glBeginTransformFeedback(GL_TRIANGLES);
-+
-+    drawQuad(drawColor, essl3_shaders::PositionAttrib(), 0.5f);
-+
-+    // Break the render pass
-+    EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor::red);
-+
-+    // Redefine the transform feedback buffer
-+    glBufferData(GL_TRANSFORM_FEEDBACK_BUFFER, 40, nullptr, GL_DYNAMIC_READ);
-+
-+    // Start a new render pass
-+    drawQuad(drawColor, essl3_shaders::PositionAttrib(), 0.5f);
-+
-+    glEndTransformFeedback();
-+}
-+
- GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST(TransformFeedbackTest);
- ANGLE_INSTANTIATE_TEST_ES3(TransformFeedbackTest);
- 

patches/chromium/.patches

@@ -21,15 +21,11 @@ resource_file_conflict.patch
 scroll_bounce_flag.patch
 mas_blink_no_private_api.patch
 mas_no_private_api.patch
-mas-cfisobjc.patch
 mas-cgdisplayusesforcetogray.patch
-mas-audiodeviceduck.patch
 mas_disable_remote_layer.patch
 mas_disable_remote_accessibility.patch
 mas_disable_custom_window_frame.patch
-mas_avoid_usage_of_abort_report_np.patch
-mas_avoid_usage_of_pthread_fchdir_np.patch
-mas_avoid_usage_of_setapplicationisdaemon_and.patch
+mas_avoid_usage_of_private_macos_apis.patch
 mas_use_public_apis_to_determine_if_a_font_is_a_system_font.patch
 chrome_key_systems.patch
 add_didinstallconditionalfeatures.patch
@@ -58,7 +54,6 @@ feat_add_set_theme_source_to_allow_apps_to.patch
 add_webmessageportconverter_entangleandinjectmessageportchannel.patch
 ignore_rc_check.patch
 remove_usage_of_incognito_apis_in_the_spellchecker.patch
-chore_use_electron_resources_not_chrome_for_spellchecker.patch
 allow_disabling_blink_scheduler_throttling_per_renderview.patch
 hack_plugin_response_interceptor_to_point_to_electron.patch
 feat_add_support_for_overriding_the_base_spellchecker_download_url.patch
@@ -80,7 +75,6 @@ skip_atk_toolchain_check.patch
 worker_feat_add_hook_to_notify_script_ready.patch
 chore_provide_iswebcontentscreationoverridden_with_full_params.patch
 fix_properly_honor_printing_page_ranges.patch
-fix_use_electron_generated_resources.patch
 chore_expose_v8_initialization_isolate_callbacks.patch
 export_gin_v8platform_pageallocator_for_usage_outside_of_the_gin.patch
 fix_export_zlib_symbols.patch
@@ -102,12 +96,11 @@ chore_do_not_use_chrome_windows_in_cryptotoken_webrequestsender.patch
 process_singleton.patch
 fix_expose_decrementcapturercount_in_web_contents_impl.patch
 add_ui_scopedcliboardwriter_writeunsaferawdata.patch
-feat_add_data_parameter_to_processsingleton.patch
-mas_gate_private_enterprise_APIs.patch
 load_v8_snapshot_in_browser_process.patch
-fix_adapt_exclusive_access_for_electron_needs.patch
+fix_patch_out_permissions_checks_in_exclusive_access.patch
 fix_aspect_ratio_with_max_size.patch
 fix_dont_delete_SerialPortManager_on_main_thread.patch
+feat_add_data_transfer_to_requestsingleinstancelock.patch
 fix_crash_when_saving_edited_pdf_files.patch
 port_autofill_colors_to_the_color_pipeline.patch
 build_disable_partition_alloc_on_mac.patch
@@ -115,23 +108,3 @@ fix_non-client_mouse_tracking_and_message_bubbling_on_windows.patch
 build_make_libcxx_abi_unstable_false_for_electron.patch
 introduce_ozoneplatform_electron_can_call_x11_property.patch
 make_gtk_getlibgtk_public.patch
-build_disable_print_content_analysis.patch
-feat_move_firstpartysets_to_content_browser_client.patch
-custom_protocols_plzserviceworker.patch
-posix_replace_doubleforkandexec_with_forkandspawn.patch
-cherry-pick-22c61cfae5d1.patch
-remove_default_window_title.patch
-keep_handling_scroll_update_if_you_can.patch
-chore_add_electron_deps_to_gitignores.patch
-chore_allow_chromium_to_handle_synthetic_mouse_events_for_touch.patch
-disable_gpu_acceleration_on_vmware_on_linux.patch
-add_maximized_parameter_to_linuxui_getwindowframeprovider.patch
-cherry-pick-94a8bdafc8c6.patch
-fix_mac_build_with_enable_plugins_false.patch
-fix_windows_build_with_enable_plugins_false.patch
-cherry-pick-54e32332750c.patch
-cherry-pick-60d8559e150a.patch
-cherry-pick-54a7927b19f9.patch
-cherry-pick-bd9724c9fe63.patch
-cherry-pick-c643d18a078d.patch
-feat_add_set_can_resize_mutator.patch

patches/chromium/add_didinstallconditionalfeatures.patch

@@ -23,10 +23,10 @@ index eb6f4c87c4479d5f4fb8e3f85a231fb9cc744a63..11298b413021b4d438195482db253a93
                                          int32_t world_id) {}
    virtual void DidClearWindowObject() {}
 diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
-index f217de19126feeeafee01b2be31ced936696ce20..95966ce7f0eeb0a7f2822bef69b540ac6bfe298d 100644
+index 596dc721842c707844a771d64337e9cf0d82bfcc..b9eea3470139e1833b2b23d3b535b11235e2bc8e 100644
 --- a/content/renderer/render_frame_impl.cc
 +++ b/content/renderer/render_frame_impl.cc
-@@ -4489,6 +4489,12 @@ void RenderFrameImpl::DidCreateScriptContext(v8::Local<v8::Context> context,
+@@ -4465,6 +4465,12 @@ void RenderFrameImpl::DidCreateScriptContext(v8::Local<v8::Context> context,
      observer.DidCreateScriptContext(context, world_id);
  }
  
@@ -79,10 +79,10 @@ index a6ba8411384855c82712960375bc949c5c2bd522..fc86ca807c9c1bda9236160580b09415
    if (World().IsMainWorld()) {
      GetFrame()->Loader().DispatchDidClearWindowObjectInMainWorld();
 diff --git a/third_party/blink/renderer/core/frame/local_frame_client.h b/third_party/blink/renderer/core/frame/local_frame_client.h
-index f36d04ff77481bd30e0de3f6d45c54dfece4067c..d30f569cd68716b9e963cf0fb5da3f7e65cc215a 100644
+index bca4cbb2b2ba84fe58b5cfeaf190add5803e27c9..b6c9dd3a2a1c9b6667c563d5da86ccb4871ae81f 100644
 --- a/third_party/blink/renderer/core/frame/local_frame_client.h
 +++ b/third_party/blink/renderer/core/frame/local_frame_client.h
-@@ -303,6 +303,8 @@ class CORE_EXPORT LocalFrameClient : public FrameClient {
+@@ -301,6 +301,8 @@ class CORE_EXPORT LocalFrameClient : public FrameClient {
  
    virtual void DidCreateScriptContext(v8::Local<v8::Context>,
                                        int32_t world_id) = 0;
@@ -92,7 +92,7 @@ index f36d04ff77481bd30e0de3f6d45c54dfece4067c..d30f569cd68716b9e963cf0fb5da3f7e
                                          int32_t world_id) = 0;
    virtual bool AllowScriptExtensions() = 0;
 diff --git a/third_party/blink/renderer/core/frame/local_frame_client_impl.cc b/third_party/blink/renderer/core/frame/local_frame_client_impl.cc
-index 5a83dcdf50acc27da2b1fbb3e515cb4316305a3a..86f31acc40a2dd296c34f3ecf5ef6ccd97cbc18c 100644
+index b690ada2d46146b6da38cbb2c688f249ae558464..b03774140883c5bb7de6358f3df95ab8774b9dc7 100644
 --- a/third_party/blink/renderer/core/frame/local_frame_client_impl.cc
 +++ b/third_party/blink/renderer/core/frame/local_frame_client_impl.cc
 @@ -275,6 +275,13 @@ void LocalFrameClientImpl::DidCreateScriptContext(
@@ -110,7 +110,7 @@ index 5a83dcdf50acc27da2b1fbb3e515cb4316305a3a..86f31acc40a2dd296c34f3ecf5ef6ccd
      v8::Local<v8::Context> context,
      int32_t world_id) {
 diff --git a/third_party/blink/renderer/core/frame/local_frame_client_impl.h b/third_party/blink/renderer/core/frame/local_frame_client_impl.h
-index ac81fdc1ac99ca02458a10c0d258b846a8a9955e..ed838db2474790437ff4b57e23a1e289afce4d47 100644
+index 420d82ed07017deba3298c5454666c09240dd23d..15407fb95dcf25875eb76a41fe1834c1f0a53528 100644
 --- a/third_party/blink/renderer/core/frame/local_frame_client_impl.h
 +++ b/third_party/blink/renderer/core/frame/local_frame_client_impl.h
 @@ -80,6 +80,8 @@ class CORE_EXPORT LocalFrameClientImpl final : public LocalFrameClient {
@@ -123,10 +123,10 @@ index ac81fdc1ac99ca02458a10c0d258b846a8a9955e..ed838db2474790437ff4b57e23a1e289
                                  int32_t world_id) override;
  
 diff --git a/third_party/blink/renderer/core/loader/empty_clients.h b/third_party/blink/renderer/core/loader/empty_clients.h
-index aab6a77b18f83adeac065083f83b94b7ff251282..0d0e272a162be8d1bee9e0122e3e7a59b0ad32a3 100644
+index 8087d1f62e9b1a8ac33a9e92c10a7cb8b8363e08..845c3329674d99dd385316dbfd1287fa3566a60e 100644
 --- a/third_party/blink/renderer/core/loader/empty_clients.h
 +++ b/third_party/blink/renderer/core/loader/empty_clients.h
-@@ -359,6 +359,8 @@ class CORE_EXPORT EmptyLocalFrameClient : public LocalFrameClient {
+@@ -357,6 +357,8 @@ class CORE_EXPORT EmptyLocalFrameClient : public LocalFrameClient {
  
    void DidCreateScriptContext(v8::Local<v8::Context>,
                                int32_t world_id) override {}

patches/chromium/add_maximized_parameter_to_linuxui_getwindowframeprovider.patch

@@ -1,176 +0,0 @@
-From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
-From: msizanoen1 <msizanoen@qtmlabs.xyz>
-Date: Tue, 19 Jul 2022 05:11:06 +0200
-Subject: Add maximized parameter to LinuxUI::GetWindowFrameProvider
-
-This allows ClientFrameViewLinux to instruct the toolkit to draw the window
-decorations in maximized mode where needed, preventing empty space caused
-by decoration shadows and rounded titlebars around the window while maximized.
-
-diff --git a/ui/gtk/gtk_ui.cc b/ui/gtk/gtk_ui.cc
-index c037fa8db6d4a5ebeb7257627db206e9bab57ecc..14eddfd043e748400a9ee81ce5346a53f10ea03c 100644
---- a/ui/gtk/gtk_ui.cc
-+++ b/ui/gtk/gtk_ui.cc
-@@ -757,13 +757,15 @@ std::unique_ptr<views::NavButtonProvider> GtkUi::CreateNavButtonProvider() {
-   return nullptr;
- }
- 
--views::WindowFrameProvider* GtkUi::GetWindowFrameProvider(bool solid_frame) {
-+views::WindowFrameProvider* GtkUi::GetWindowFrameProvider(bool solid_frame, bool maximized) {
-   if (!GtkCheckVersion(3, 14))
-     return nullptr;
-   auto& provider =
--      solid_frame ? solid_frame_provider_ : transparent_frame_provider_;
-+      maximized
-+        ? (solid_frame ? solid_maximized_frame_provider_ : transparent_maximized_frame_provider_)
-+        : (solid_frame ? solid_frame_provider_ : transparent_frame_provider_);
-   if (!provider)
--    provider = std::make_unique<gtk::WindowFrameProviderGtk>(solid_frame);
-+    provider = std::make_unique<gtk::WindowFrameProviderGtk>(solid_frame, maximized);
-   return provider.get();
- }
- 
-diff --git a/ui/gtk/gtk_ui.h b/ui/gtk/gtk_ui.h
-index 8e609b8311c6b69ef7b6753117542d9e60b2c8ab..a329822c3285599954d77dd5a8e33ccc10e5f626 100644
---- a/ui/gtk/gtk_ui.h
-+++ b/ui/gtk/gtk_ui.h
-@@ -107,7 +107,7 @@ class GtkUi : public views::LinuxUI {
-   bool PreferDarkTheme() const override;
-   bool AnimationsEnabled() const override;
-   std::unique_ptr<views::NavButtonProvider> CreateNavButtonProvider() override;
--  views::WindowFrameProvider* GetWindowFrameProvider(bool solid_frame) override;
-+  views::WindowFrameProvider* GetWindowFrameProvider(bool solid_frame, bool maximized) override;
-   base::flat_map<std::string, std::string> GetKeyboardLayoutMap() override;
-   std::string GetCursorThemeName() override;
-   int GetCursorThemeSize() override;
-@@ -218,6 +218,8 @@ class GtkUi : public views::LinuxUI {
-   // while Chrome is running.
-   std::unique_ptr<views::WindowFrameProvider> solid_frame_provider_;
-   std::unique_ptr<views::WindowFrameProvider> transparent_frame_provider_;
-+  std::unique_ptr<views::WindowFrameProvider> solid_maximized_frame_provider_;
-+  std::unique_ptr<views::WindowFrameProvider> transparent_maximized_frame_provider_;
- };
- 
- }  // namespace gtk
-diff --git a/ui/gtk/window_frame_provider_gtk.cc b/ui/gtk/window_frame_provider_gtk.cc
-index e4dbdad327eb77994ffd7f068c67336a19897915..d3ae0636455489a7c7443df85cb769952c98aca2 100644
---- a/ui/gtk/window_frame_provider_gtk.cc
-+++ b/ui/gtk/window_frame_provider_gtk.cc
-@@ -38,16 +38,18 @@ std::string GetThemeName() {
-   return theme_string;
- }
- 
--GtkCssContext WindowContext(bool solid_frame, bool focused) {
-+GtkCssContext WindowContext(bool solid_frame, bool maximized, bool focused) {
-   std::string selector = "#window.background.";
-   selector += solid_frame ? "solid-csd" : "csd";
-+  if (maximized)
-+    selector += ".maximized";
-   if (!focused)
-     selector += ":inactive";
-   return AppendCssNodeToStyleContext({}, selector);
- }
- 
--GtkCssContext DecorationContext(bool solid_frame, bool focused) {
--  auto context = WindowContext(solid_frame, focused);
-+GtkCssContext DecorationContext(bool solid_frame, bool maximized, bool focused) {
-+  auto context = WindowContext(solid_frame, maximized, focused);
-   // GTK4 renders the decoration directly on the window.
-   if (!GtkCheckVersion(4))
-     context = AppendCssNodeToStyleContext(context, "#decoration");
-@@ -64,8 +66,8 @@ GtkCssContext DecorationContext(bool solid_frame, bool focused) {
-   return context;
- }
- 
--GtkCssContext HeaderContext(bool solid_frame, bool focused) {
--  auto context = WindowContext(solid_frame, focused);
-+GtkCssContext HeaderContext(bool solid_frame, bool maximized, bool focused) {
-+  auto context = WindowContext(solid_frame, maximized, focused);
-   context =
-       AppendCssNodeToStyleContext(context, "#headerbar.header-bar.titlebar");
-   if (!focused)
-@@ -110,8 +112,8 @@ int ComputeTopCornerRadius() {
-   // need to experimentally determine the corner radius by rendering a sample.
-   // Additionally, in GTK4, the headerbar corners get clipped by the window
-   // rather than the headerbar having its own rounded corners.
--  auto context = GtkCheckVersion(4) ? DecorationContext(false, false)
--                                    : HeaderContext(false, false);
-+  auto context = GtkCheckVersion(4) ? DecorationContext(false, false, false)
-+                                    : HeaderContext(false, false, false);
-   ApplyCssToContext(context, R"(window, headerbar {
-     background-image: none;
-     background-color: black;
-@@ -169,8 +171,8 @@ void WindowFrameProviderGtk::Asset::CloneFrom(
-   unfocused_bitmap = src.unfocused_bitmap;
- }
- 
--WindowFrameProviderGtk::WindowFrameProviderGtk(bool solid_frame)
--    : solid_frame_(solid_frame) {}
-+WindowFrameProviderGtk::WindowFrameProviderGtk(bool solid_frame, bool maximized)
-+    : solid_frame_(solid_frame), maximized_(maximized) {}
- 
- WindowFrameProviderGtk::~WindowFrameProviderGtk() = default;
- 
-@@ -264,7 +266,7 @@ void WindowFrameProviderGtk::PaintWindowFrame(gfx::Canvas* canvas,
-       top_area_height_dip * scale - asset.frame_thickness_px.top();
- 
-   auto header = PaintHeaderbar({client_bounds_px.width(), top_area_height_px},
--                               HeaderContext(solid_frame_, focused), scale);
-+                               HeaderContext(solid_frame_, maximized_, focused), scale);
-   image = gfx::ImageSkia::CreateFrom1xBitmap(header);
-   // In GTK4, the headerbar gets clipped by the window.
-   if (GtkCheckVersion(4)) {
-@@ -296,7 +298,7 @@ void WindowFrameProviderGtk::MaybeUpdateBitmaps(float scale) {
- 
-   gfx::Rect frame_bounds_dip(kMaxFrameSizeDip, kMaxFrameSizeDip,
-                              2 * kMaxFrameSizeDip, 2 * kMaxFrameSizeDip);
--  auto focused_context = DecorationContext(solid_frame_, true);
-+  auto focused_context = DecorationContext(solid_frame_, maximized_, true);
-   frame_bounds_dip.Inset(-GtkStyleContextGetPadding(focused_context));
-   frame_bounds_dip.Inset(-GtkStyleContextGetBorder(focused_context));
-   gfx::Size bitmap_size(BitmapSizePx(asset), BitmapSizePx(asset));
-@@ -304,7 +306,7 @@ void WindowFrameProviderGtk::MaybeUpdateBitmaps(float scale) {
-       PaintBitmap(bitmap_size, frame_bounds_dip, focused_context, scale);
-   asset.unfocused_bitmap =
-       PaintBitmap(bitmap_size, frame_bounds_dip,
--                  DecorationContext(solid_frame_, false), scale);
-+                  DecorationContext(solid_frame_, maximized_, false), scale);
- 
-   // In GTK4, there's no way to obtain the frame thickness from CSS values
-   // directly, so we must determine it experimentally based on the drawn
-diff --git a/ui/gtk/window_frame_provider_gtk.h b/ui/gtk/window_frame_provider_gtk.h
-index d3039d73161378197557947aece88d2710c1e486..f7d4605938210b0b75517bb7bcab28b588a16520 100644
---- a/ui/gtk/window_frame_provider_gtk.h
-+++ b/ui/gtk/window_frame_provider_gtk.h
-@@ -14,7 +14,7 @@ namespace gtk {
- 
- class WindowFrameProviderGtk : public views::WindowFrameProvider {
-  public:
--  explicit WindowFrameProviderGtk(bool solid_frame);
-+  explicit WindowFrameProviderGtk(bool solid_frame, bool maximized);
- 
-   WindowFrameProviderGtk(const WindowFrameProviderGtk&) = delete;
-   WindowFrameProviderGtk& operator=(const WindowFrameProviderGtk&) = delete;
-@@ -69,6 +69,9 @@ class WindowFrameProviderGtk : public views::WindowFrameProvider {
- 
-   // Cached bitmaps and metrics.  The scale is rounded to percent.
-   base::flat_map<int, Asset> assets_;
-+
-+  // Whether to draw the window decorations as maximized.
-+  bool maximized_;
- };
- 
- }  // namespace gtk
-diff --git a/ui/views/linux_ui/linux_ui.h b/ui/views/linux_ui/linux_ui.h
-index 5f312e01508c49033bf2d05b9dc083e524f37e5f..7590acd760ba4f36e5a77c1972afc5fc08e616ff 100644
---- a/ui/views/linux_ui/linux_ui.h
-+++ b/ui/views/linux_ui/linux_ui.h
-@@ -189,7 +189,7 @@ class VIEWS_EXPORT LinuxUI : public ui::LinuxInputMethodContextFactory,
-   // if transparency is unsupported and the frame should be rendered opaque.
-   // The returned object is not owned by the caller and will remain alive until
-   // the process ends.
--  virtual WindowFrameProvider* GetWindowFrameProvider(bool solid_frame) = 0;
-+  virtual WindowFrameProvider* GetWindowFrameProvider(bool solid_frame, bool maximized) = 0;
- 
-   // Returns a map of KeyboardEvent code to KeyboardEvent key values.
-   virtual base::flat_map<std::string, std::string> GetKeyboardLayoutMap() = 0;

patches/chromium/allow_disabling_blink_scheduler_throttling_per_renderview.patch

@@ -6,10 +6,10 @@ Subject: allow disabling blink scheduler throttling per RenderView
 This allows us to disable throttling for hidden windows.
 
 diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc
-index a9267b633e126f057e914b895f280ed658ff279d..179b5449f53c2d7b9024fb08fe1b1f6c03c6d5b0 100644
+index 32df5050f5a66c4b4f0981d3777a3b5a4fac9629..d8d9982bc6bd6e472677707b326a5dafa9b7fcf5 100644
 --- a/content/browser/renderer_host/render_view_host_impl.cc
 +++ b/content/browser/renderer_host/render_view_host_impl.cc
-@@ -665,6 +665,11 @@ void RenderViewHostImpl::SetBackgroundOpaque(bool opaque) {
+@@ -660,6 +660,11 @@ void RenderViewHostImpl::SetBackgroundOpaque(bool opaque) {
    GetWidget()->GetAssociatedFrameWidget()->SetBackgroundOpaque(opaque);
  }
  
@@ -22,11 +22,11 @@ index a9267b633e126f057e914b895f280ed658ff279d..179b5449f53c2d7b9024fb08fe1b1f6c
    return is_active();
  }
 diff --git a/content/browser/renderer_host/render_view_host_impl.h b/content/browser/renderer_host/render_view_host_impl.h
-index 3f0df3df3dd74ced71869ce01abf7b159387b8f4..85b169530a21bcfc016d1439a71d35378077774d 100644
+index a099eed10dd061994bff696519099c3ef7437a46..a1f1e9b55272e70b4acd5d1f1515fba7d91538fa 100644
 --- a/content/browser/renderer_host/render_view_host_impl.h
 +++ b/content/browser/renderer_host/render_view_host_impl.h
 @@ -137,6 +137,7 @@ class CONTENT_EXPORT RenderViewHostImpl
-   bool IsRenderViewLiveForTesting() const override;
+   bool IsRenderViewLive() const override;
    void WriteIntoTrace(perfetto::TracedProto<TraceProto> context) const override;
  
 +  void SetSchedulerThrottling(bool allowed) override;
@@ -34,7 +34,7 @@ index 3f0df3df3dd74ced71869ce01abf7b159387b8f4..85b169530a21bcfc016d1439a71d3537
    void SendRendererPreferencesToRenderer(
        const blink::RendererPreferences& preferences);
 diff --git a/content/public/browser/render_view_host.h b/content/public/browser/render_view_host.h
-index 3b01b3419c4361d5d75ad1c37e5baa3a1967bd09..35c82d931242a1180091267c18e0255840acc5ce 100644
+index a6fe708878eb9afba9a68e0be71ba2c0b2a84d7d..5cc81ceb44d0a8baee3ebcc63aa4137b1e9ef08e 100644
 --- a/content/public/browser/render_view_host.h
 +++ b/content/public/browser/render_view_host.h
 @@ -80,6 +80,9 @@ class CONTENT_EXPORT RenderViewHost {
@@ -61,10 +61,10 @@ index fd145f0aa562d6b63fb1d3a8a9241ae1aa1ce7a0..54d30fb9db8b48b94abdb815c487f618
    // ADDING NEW FUNCTIONS? Please keep private functions alphabetized and put
    // it in the same order in the .cc file as it was in the header.
 diff --git a/third_party/blink/public/mojom/page/page.mojom b/third_party/blink/public/mojom/page/page.mojom
-index 39bfc2200e924d0c589cfd07f085f182ef6853a6..bddff6d5ad3f6d08c4dc48e66ebc5319b1a5ec28 100644
+index befd736a9cf362514b9a2ee475dc4a814c85a87b..24b2617f56673a3075697802cf5b574b0c766610 100644
 --- a/third_party/blink/public/mojom/page/page.mojom
 +++ b/third_party/blink/public/mojom/page/page.mojom
-@@ -108,4 +108,7 @@ interface PageBroadcast {
+@@ -97,4 +97,7 @@ interface PageBroadcast {
  
    // Sent to whole page, but should only be used by the main frame.
    SetPageBaseBackgroundColor(skia.mojom.SkColor? color);
@@ -73,7 +73,7 @@ index 39bfc2200e924d0c589cfd07f085f182ef6853a6..bddff6d5ad3f6d08c4dc48e66ebc5319
 +  SetSchedulerThrottling(bool allowed);
  };
 diff --git a/third_party/blink/public/web/web_view.h b/third_party/blink/public/web/web_view.h
-index 5e4032ccf916f969cd669af7d983becddb57c72b..a858c9f2fa609ae756a2e70d0362f2de372dd5be 100644
+index a1427a6a95583ae853284b97cab77d577172e60e..4645764213c82e73532f7c61ed03f919f8241393 100644
 --- a/third_party/blink/public/web/web_view.h
 +++ b/third_party/blink/public/web/web_view.h
 @@ -364,6 +364,7 @@ class WebView {
@@ -85,10 +85,10 @@ index 5e4032ccf916f969cd669af7d983becddb57c72b..a858c9f2fa609ae756a2e70d0362f2de
    // Visibility -----------------------------------------------------------
  
 diff --git a/third_party/blink/renderer/core/exported/web_view_impl.cc b/third_party/blink/renderer/core/exported/web_view_impl.cc
-index 6504c73f614bebad7b899c8b76c4b3034b7dab7a..f76a0ee0778d7b4e4df69a4c43b4a6bfdc89294d 100644
+index d7b5e40a26026b7f4640c2f405fadab4a800e267..b2a2e38397fdf3e9bb52c4532a1d14463ed4110d 100644
 --- a/third_party/blink/renderer/core/exported/web_view_impl.cc
 +++ b/third_party/blink/renderer/core/exported/web_view_impl.cc
-@@ -3689,6 +3689,13 @@ PageScheduler* WebViewImpl::Scheduler() const {
+@@ -3688,6 +3688,13 @@ PageScheduler* WebViewImpl::Scheduler() const {
    return GetPage()->GetPageScheduler();
  }
  
@@ -102,7 +102,7 @@ index 6504c73f614bebad7b899c8b76c4b3034b7dab7a..f76a0ee0778d7b4e4df69a4c43b4a6bf
  void WebViewImpl::SetVisibilityState(
      mojom::blink::PageVisibilityState visibility_state,
      bool is_initial_state) {
-@@ -3700,7 +3707,8 @@ void WebViewImpl::SetVisibilityState(
+@@ -3699,7 +3706,8 @@ void WebViewImpl::SetVisibilityState(
    }
    GetPage()->SetVisibilityState(visibility_state, is_initial_state);
    GetPage()->GetPageScheduler()->SetPageVisible(
@@ -113,10 +113,10 @@ index 6504c73f614bebad7b899c8b76c4b3034b7dab7a..f76a0ee0778d7b4e4df69a4c43b4a6bf
  
  mojom::blink::PageVisibilityState WebViewImpl::GetVisibilityState() {
 diff --git a/third_party/blink/renderer/core/exported/web_view_impl.h b/third_party/blink/renderer/core/exported/web_view_impl.h
-index 5c9609a6a8d1e18981ac14ad5321fa82c3eb38e0..0a2564a8e45210ba58438e95caa70d01fac22aee 100644
+index 08a54c62b7f4eeb6a8b0e0cb192723e1aecad915..1eeb122ac5db86c53d328a308dc2b7a4a5ca9fed 100644
 --- a/third_party/blink/renderer/core/exported/web_view_impl.h
 +++ b/third_party/blink/renderer/core/exported/web_view_impl.h
-@@ -420,6 +420,7 @@ class CORE_EXPORT WebViewImpl final : public WebView,
+@@ -419,6 +419,7 @@ class CORE_EXPORT WebViewImpl final : public WebView,
    LocalDOMWindow* PagePopupWindow() const;
  
    PageScheduler* Scheduler() const override;
@@ -124,7 +124,7 @@ index 5c9609a6a8d1e18981ac14ad5321fa82c3eb38e0..0a2564a8e45210ba58438e95caa70d01
    void SetVisibilityState(mojom::blink::PageVisibilityState visibility_state,
                            bool is_initial_state) override;
    mojom::blink::PageVisibilityState GetVisibilityState() override;
-@@ -855,6 +856,8 @@ class CORE_EXPORT WebViewImpl final : public WebView,
+@@ -854,6 +855,8 @@ class CORE_EXPORT WebViewImpl final : public WebView,
    // If true, we send IPC messages when |preferred_size_| changes.
    bool send_preferred_size_changes_ = false;
  

patches/chromium/blink_local_frame.patch

@@ -15,10 +15,10 @@ Refs changes in:
 This patch reverts the changes to fix associated crashes in Electron.
 
 diff --git a/third_party/blink/renderer/core/frame/frame.cc b/third_party/blink/renderer/core/frame/frame.cc
-index a519c49a01987feab4dadbc4ba48b73e943fa404..c8d2a65cb428e85c33675668cc106f0af124dfee 100644
+index 0396836ad4ae67e26b6920afbcd702ccb24d391e..f207eda80b6cd1d3a739cc27499691ad1ac8e13e 100644
 --- a/third_party/blink/renderer/core/frame/frame.cc
 +++ b/third_party/blink/renderer/core/frame/frame.cc
-@@ -123,14 +123,6 @@ bool Frame::Detach(FrameDetachType type) {
+@@ -122,14 +122,6 @@ bool Frame::Detach(FrameDetachType type) {
  
    DCHECK(!IsDetached());
  
@@ -33,7 +33,7 @@ index a519c49a01987feab4dadbc4ba48b73e943fa404..c8d2a65cb428e85c33675668cc106f0a
    if (type == FrameDetachType::kRemove) {
      if (provisional_frame_) {
        provisional_frame_->Detach(FrameDetachType::kRemove);
-@@ -154,6 +146,14 @@ bool Frame::Detach(FrameDetachType type) {
+@@ -153,6 +145,14 @@ bool Frame::Detach(FrameDetachType type) {
      GetWindowProxyManager()->ClearForSwap();
    }
  
@@ -49,7 +49,7 @@ index a519c49a01987feab4dadbc4ba48b73e943fa404..c8d2a65cb428e85c33675668cc106f0a
    // its owning reference back to our owning LocalFrame.
    client_->Detached(type);
 diff --git a/third_party/blink/renderer/core/frame/local_frame.cc b/third_party/blink/renderer/core/frame/local_frame.cc
-index 3efc0a04ae3fa60dce4aeb9a296c8dd1bb43320a..5dac7c18f39abefcc318ba2a7b8fad449189d0b6 100644
+index b95ed440737ccdf32607c90831d13a482315d515..73f7aeee21f0116e46dad91cb9a088ab5adda6e3 100644
 --- a/third_party/blink/renderer/core/frame/local_frame.cc
 +++ b/third_party/blink/renderer/core/frame/local_frame.cc
 @@ -543,10 +543,6 @@ bool LocalFrame::DetachImpl(FrameDetachType type) {

patches/chromium/build_disable_print_content_analysis.patch

@@ -1,28 +0,0 @@
-From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
-From: VerteDinde <vertedinde@electronjs.org>
-Date: Sun, 1 May 2022 18:01:42 -0700
-Subject: build: disable print_content_analysis
-
-Print Content Analysis enables enterprise users to scan to-be-printed
-pages and documents for sensitive data if the OnPrintEnterpriseConnector
-policy is enabled. A conversation with the Chromium team confirmed
-this feature was intended for enterprise Chrome users and not embedders,
-so we're disabling it to prevent build issues/additional unneeded files.
-
-This patch can be removed when enable_print_content_analysis can be more
-easily enabled or disabled by default with buildflags.
-
-diff --git a/printing/buildflags/buildflags.gni b/printing/buildflags/buildflags.gni
-index 559ac76d4e4b9d9c1824c4da186a6b0f7619fcca..72855e0c5fadb286b67144b34ff71f45e1434c73 100644
---- a/printing/buildflags/buildflags.gni
-+++ b/printing/buildflags/buildflags.gni
-@@ -36,8 +36,7 @@ declare_args() {
- 
-   # Enable snapshotting a page when printing for its content to be analyzed for
-   # sensitive content by enterprise users.
--  enable_print_content_analysis =
--      is_chromeos_ash || is_chromeos_lacros || is_win || is_linux || is_mac
-+  enable_print_content_analysis = is_chromeos_ash || is_chromeos_lacros
- }
- 
- declare_args() {

patches/chromium/build_do_not_depend_on_packed_resource_integrity.patch

@@ -33,10 +33,10 @@ index 3c40d999a9545051e91a9f0ad3bf7ca2a95d80c4..b5a20be5e22238e7e1969bdaf52c0b05
          "//base",
          "//build:branding_buildflags",
 diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn
-index 948d05358b89895faa97a7d383bfac66a45464a8..43859d267010103daf80525a5af0f312a577411c 100644
+index 02e4b0e27f4a0d3409327ba929f78b129dc06385..dce624825dc8e9e545c15a0cb0427aa33877aa3e 100644
 --- a/chrome/browser/BUILD.gn
 +++ b/chrome/browser/BUILD.gn
-@@ -4560,7 +4560,7 @@ static_library("browser") {
+@@ -4552,7 +4552,7 @@ static_library("browser") {
  
      # On Windows, the hashes are embedded in //chrome:chrome_initial rather
      # than here in :chrome_dll.
@@ -46,10 +46,10 @@ index 948d05358b89895faa97a7d383bfac66a45464a8..43859d267010103daf80525a5af0f312
        sources += [ "certificate_viewer_stub.cc" ]
      }
 diff --git a/chrome/test/BUILD.gn b/chrome/test/BUILD.gn
-index 641f52eb7952858738a6623b480f767261e5d009..6d0c624ea62a9125ef7e5579da197de2327a12ff 100644
+index 060e49987d27be37afb2b85e658525d4edc08df6..3333bb6be0d07eff9d4ef5aea446c44c00b3d3af 100644
 --- a/chrome/test/BUILD.gn
 +++ b/chrome/test/BUILD.gn
-@@ -6002,7 +6002,6 @@ test("unit_tests") {
+@@ -5995,7 +5995,6 @@ test("unit_tests") {
  
      deps += [
        "//chrome:other_version",
@@ -57,7 +57,7 @@ index 641f52eb7952858738a6623b480f767261e5d009..6d0c624ea62a9125ef7e5579da197de2
        "//chrome//services/util_win:unit_tests",
        "//chrome/app:chrome_dll_resources",
        "//chrome/browser:chrome_process_finder",
-@@ -6025,6 +6024,10 @@ test("unit_tests") {
+@@ -6018,6 +6017,10 @@ test("unit_tests") {
        "//ui/resources",
      ]
  
@@ -68,7 +68,7 @@ index 641f52eb7952858738a6623b480f767261e5d009..6d0c624ea62a9125ef7e5579da197de2
      ldflags = [
        "/DELAYLOAD:api-ms-win-core-winrt-error-l1-1-0.dll",
        "/DELAYLOAD:api-ms-win-core-winrt-l1-1-0.dll",
-@@ -6712,7 +6715,6 @@ test("unit_tests") {
+@@ -6706,7 +6709,6 @@ test("unit_tests") {
      }
  
      deps += [
@@ -76,7 +76,7 @@ index 641f52eb7952858738a6623b480f767261e5d009..6d0c624ea62a9125ef7e5579da197de2
        "//chrome/browser:cart_db_content_proto",
        "//chrome/browser:coupon_db_content_proto",
        "//chrome/browser/media/router:test_support",
-@@ -6760,6 +6762,11 @@ test("unit_tests") {
+@@ -6754,6 +6756,11 @@ test("unit_tests") {
      if (is_chromeos) {
        deps += [ "//ui/chromeos" ]
      }

patches/chromium/can_create_window.patch

@@ -9,10 +9,10 @@ potentially prevent a window from being created.
 TODO(loc): this patch is currently broken.
 
 diff --git a/content/browser/renderer_host/render_frame_host_impl.cc b/content/browser/renderer_host/render_frame_host_impl.cc
-index ec886101b6e5347bdd832684a5c3b2cc3179c657..0287e414f4020147ddee297f7c1447c32a118905 100644
+index 9b08d7bbbda75390813ff07e0dc83bb9d16992a6..b47dc4a90a0294c5d7e73f01c496fd2b4f621400 100644
 --- a/content/browser/renderer_host/render_frame_host_impl.cc
 +++ b/content/browser/renderer_host/render_frame_host_impl.cc
-@@ -6943,6 +6943,7 @@ void RenderFrameHostImpl::CreateNewWindow(
+@@ -6939,6 +6939,7 @@ void RenderFrameHostImpl::CreateNewWindow(
            last_committed_origin_, params->window_container_type,
            params->target_url, params->referrer.To<Referrer>(),
            params->frame_name, params->disposition, *params->features,
@@ -21,10 +21,10 @@ index ec886101b6e5347bdd832684a5c3b2cc3179c657..0287e414f4020147ddee297f7c1447c3
            &no_javascript_access);
  
 diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
-index 335e70179a03ee379082525bb4c7d596983bd633..faa795be3a6cbc7ae13d9a42a1bdbd01ac0406a9 100644
+index d0092176fd24acb0657819d666e4f76ec65012ec..df03de0a810bbce796d5bc421b92000e02dbd449 100644
 --- a/content/browser/web_contents/web_contents_impl.cc
 +++ b/content/browser/web_contents/web_contents_impl.cc
-@@ -3947,6 +3947,14 @@ FrameTree* WebContentsImpl::CreateNewWindow(
+@@ -3943,6 +3943,14 @@ FrameTree* WebContentsImpl::CreateNewWindow(
    }
    auto* new_contents_impl = new_contents.get();
  
@@ -39,7 +39,7 @@ index 335e70179a03ee379082525bb4c7d596983bd633..faa795be3a6cbc7ae13d9a42a1bdbd01
    new_contents_impl->GetController().SetSessionStorageNamespace(
        partition_config, session_storage_namespace);
  
-@@ -3991,12 +3999,6 @@ FrameTree* WebContentsImpl::CreateNewWindow(
+@@ -3987,12 +3995,6 @@ FrameTree* WebContentsImpl::CreateNewWindow(
      AddWebContentsDestructionObserver(new_contents_impl);
    }
  
@@ -102,7 +102,7 @@ index ae3dda4b9b40bb0d4c1a10eaedda9270d3543a8b..9b988bb631ab759739ae01c918efb1d5
        bool opener_suppressed,
        bool* no_javascript_access);
 diff --git a/content/public/browser/web_contents_delegate.cc b/content/public/browser/web_contents_delegate.cc
-index 9bbc7cf6d9542a3f013313e0c497839da2beb9d1..c01e06b08b1cca7a663e30476a551904ce9c6db8 100644
+index f132199113778f6b50972419b61a187e6272300c..7bb1680553c405a9016cfd67eca5fa3c6439b692 100644
 --- a/content/public/browser/web_contents_delegate.cc
 +++ b/content/public/browser/web_contents_delegate.cc
 @@ -26,6 +26,17 @@ namespace content {
@@ -124,7 +124,7 @@ index 9bbc7cf6d9542a3f013313e0c497839da2beb9d1..c01e06b08b1cca7a663e30476a551904
                                                   const OpenURLParams& params) {
    return nullptr;
 diff --git a/content/public/browser/web_contents_delegate.h b/content/public/browser/web_contents_delegate.h
-index 04aa4d993b331396ee20464f6e1d2da10c91c834..2556c044b6e28501a5fac9b0040e623b8f35f497 100644
+index 85335ff06c87ea3986360fad18df6cf01a4a7cca..eeafde1fa6067804665954525eafdd482d8eb3f3 100644
 --- a/content/public/browser/web_contents_delegate.h
 +++ b/content/public/browser/web_contents_delegate.h
 @@ -16,6 +16,7 @@
@@ -150,7 +150,7 @@ index 04aa4d993b331396ee20464f6e1d2da10c91c834..2556c044b6e28501a5fac9b0040e623b
    // typically happens when popups are created.
    virtual void WebContentsCreated(WebContents* source_contents,
 diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
-index 89b07508aef80680a847c106fea0e2fa58ff964b..6630af3583a6bac6135d46644280d6444fe981b8 100644
+index f7fbc40e8df8b996d6079f2e691771529ca42497..5580f245477b713d0f1f92ca9d15de847c4f8c92 100644
 --- a/content/renderer/render_view_impl.cc
 +++ b/content/renderer/render_view_impl.cc
 @@ -33,6 +33,7 @@
@@ -220,10 +220,10 @@ index 84d32491a56528a84b4395fba1d54cdbb38d522b..09998a83c449ef8cd9f360fbcdcf7edc
  
  }  // namespace blink
 diff --git a/third_party/blink/renderer/core/frame/local_dom_window.cc b/third_party/blink/renderer/core/frame/local_dom_window.cc
-index 2e2ba228a7f179b7cf9c43434bd20ca20b1f1af6..de9f95426ad2dcc99bc4961a0e57539d287408e4 100644
+index 00af75f5295251fb19c874d2b7d877c4a53f7f12..c0042534907dfca1789b8dde2ffa11956d3e029e 100644
 --- a/third_party/blink/renderer/core/frame/local_dom_window.cc
 +++ b/third_party/blink/renderer/core/frame/local_dom_window.cc
-@@ -2074,6 +2074,7 @@ DOMWindow* LocalDOMWindow::open(v8::Isolate* isolate,
+@@ -2076,6 +2076,7 @@ DOMWindow* LocalDOMWindow::open(v8::Isolate* isolate,
  
    WebWindowFeatures window_features =
        GetWindowFeaturesFromString(features, incumbent_window);

patches/chromium/cherry-pick-22c61cfae5d1.patch

@@ -1,97 +0,0 @@
-From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
-From: Austin Sullivan <asully@chromium.org>
-Date: Thu, 12 May 2022 04:52:20 +0000
-Subject: FSA: Sanitize .url files
-
-Bug: 1307930
-Change-Id: I7ed3cca5942a5334ba761d269bdd8961fa9d13fe
-Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3638698
-Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
-Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
-Auto-Submit: Austin Sullivan <asully@chromium.org>
-Cr-Commit-Position: refs/heads/main@{#1002495}
-
-diff --git a/content/browser/file_system_access/file_system_chooser.cc b/content/browser/file_system_access/file_system_chooser.cc
-index f8cd9d51222c70166a82cdd6dd4b7d0c24970606..8c38f004109aa967e1e5439a17dc35d3013e8ecf 100644
---- a/content/browser/file_system_access/file_system_chooser.cc
-+++ b/content/browser/file_system_access/file_system_chooser.cc
-@@ -275,13 +275,15 @@ bool FileSystemChooser::IsShellIntegratedExtension(
-   base::FilePath::StringType extension_lower =
-       base::ToLowerASCII(GetLastExtension(extension));
- 
--  // .lnk and .scf files may be used to execute arbitrary code (see
-+  // '.lnk' and '.scf' files may be used to execute arbitrary code (see
-   // https://nvd.nist.gov/vuln/detail/CVE-2010-2568 and
--  // https://crbug.com/1227995, respectively). .local files are used by Windows
--  // to determine which DLLs to load for an application.
-+  // https://crbug.com/1227995, respectively). '.local' files are used by
-+  // Windows to determine which DLLs to load for an application. '.url' files
-+  // can be used to read arbirtary files (see https://crbug.com/1307930).
-   if ((extension_lower == FILE_PATH_LITERAL("lnk")) ||
-       (extension_lower == FILE_PATH_LITERAL("local")) ||
--      (extension_lower == FILE_PATH_LITERAL("scf"))) {
-+      (extension_lower == FILE_PATH_LITERAL("scf")) ||
-+      (extension_lower == FILE_PATH_LITERAL("url"))) {
-     return true;
-   }
- 
-diff --git a/content/browser/file_system_access/file_system_chooser_browsertest.cc b/content/browser/file_system_access/file_system_chooser_browsertest.cc
-index 9ea4db7807f6bbac799452fd138848b2a650d6fd..79dda31bd228e785d54e5486bb4417a75ee62b3a 100644
---- a/content/browser/file_system_access/file_system_chooser_browsertest.cc
-+++ b/content/browser/file_system_access/file_system_chooser_browsertest.cc
-@@ -1556,13 +1556,21 @@ IN_PROC_BROWSER_TEST_F(FileSystemChooserBrowserTest, SuggestedName) {
-   name_infos.push_back({"not_matching.jpg", ListValueOf(".txt"), false,
-                         "not_matching.jpg", false});
- 
--  // ".lnk", ".local", and ".scf" extensions should be sanitized.
--  name_infos.push_back({"dangerous_extension.local", ListValueOf(".local"),
--                        true, "dangerous_extension.download", false});
-+  // ".lnk", ".local", ".scf", and ".url" extensions should be sanitized.
-   name_infos.push_back({"dangerous_extension.lnk", ListValueOf(".lnk"), true,
-                         "dangerous_extension.download", false});
-+  name_infos.push_back({"dangerous_extension.lnk", ListValueOf(".LNK"), true,
-+                        "dangerous_extension.download", false});
-+  name_infos.push_back({"dangerous_extension.LNK", ListValueOf(".lnk"), true,
-+                        "dangerous_extension.download", false});
-+  name_infos.push_back({"dangerous_extension.LNK", ListValueOf(".LNK"), true,
-+                        "dangerous_extension.download", false});
-+  name_infos.push_back({"dangerous_extension.local", ListValueOf(".local"),
-+                        true, "dangerous_extension.download", false});
-   name_infos.push_back({"dangerous_extension.scf", ListValueOf(".scf"), true,
-                         "dangerous_extension.download", false});
-+  name_infos.push_back({"dangerous_extension.url", ListValueOf(".url"), true,
-+                        "dangerous_extension.download", false});
-   // Compound extensions ending in a dangerous extension should be sanitized.
-   name_infos.push_back({"dangerous_extension.png.local", ListValueOf(".local"),
-                         true, "dangerous_extension.png.download", false});
-@@ -1570,6 +1578,8 @@ IN_PROC_BROWSER_TEST_F(FileSystemChooserBrowserTest, SuggestedName) {
-                         true, "dangerous_extension.png.download", false});
-   name_infos.push_back({"dangerous_extension.png.scf", ListValueOf(".scf"),
-                         true, "dangerous_extension.png.download", false});
-+  name_infos.push_back({"dangerous_extension.png.url", ListValueOf(".url"),
-+                        true, "dangerous_extension.png.download", false});
-   // Compound extensions not ending in a dangerous extension should not be
-   // sanitized.
-   name_infos.push_back({"dangerous_extension.local.png", ListValueOf(".png"),
-@@ -1578,6 +1588,8 @@ IN_PROC_BROWSER_TEST_F(FileSystemChooserBrowserTest, SuggestedName) {
-                         true, "dangerous_extension.lnk.png", true});
-   name_infos.push_back({"dangerous_extension.scf.png", ListValueOf(".png"),
-                         true, "dangerous_extension.scf.png", true});
-+  name_infos.push_back({"dangerous_extension.url.png", ListValueOf(".png"),
-+                        true, "dangerous_extension.url.png", true});
-   // Invalid characters should be sanitized.
-   name_infos.push_back({R"(inv*l:d\\ch%rבאמת!a<ters🤓.txt)",
-                         ListValueOf(".txt"), true,
-diff --git a/content/browser/file_system_access/file_system_chooser_unittest.cc b/content/browser/file_system_access/file_system_chooser_unittest.cc
-index 9b27d6305bd00a19d94b5ec49f21a7ecff7ddc48..3082c088f9733de9335437278c0d023954a953d9 100644
---- a/content/browser/file_system_access/file_system_chooser_unittest.cc
-+++ b/content/browser/file_system_access/file_system_chooser_unittest.cc
-@@ -189,7 +189,7 @@ TEST_F(FileSystemChooserTest, IgnoreShellIntegratedExtensions) {
-   accepts.emplace_back(blink::mojom::ChooseFileSystemEntryAcceptsOption::New(
-       u"", std::vector<std::string>({}),
-       std::vector<std::string>(
--          {"lnk", "foo.lnk", "foo.bar.local", "text", "local", "scf"})));
-+          {"lnk", "foo.lnk", "foo.bar.local", "text", "local", "scf", "url"})));
-   SyncShowDialog(std::move(accepts), /*include_accepts_all=*/false);
- 
-   ASSERT_TRUE(dialog_params.file_types);

patches/chromium/cherry-pick-54a7927b19f9.patch

@@ -1,276 +0,0 @@
-From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
-From: Aaron Leventhal <aleventhal@google.com>
-Date: Tue, 26 Jul 2022 17:36:04 +0000
-Subject: Merge 104: Speculative fix for IsValidCodePointInIndex() range crash
-
-(cherry picked from commit b4d1ce62d7783a9b31a0a2bec1b886a9a6519a40)
-
-Bug: 1333970
-Change-Id: I5a4c78e708357074fdec1f7a18fa928e39f9c51a
-Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3757922
-Auto-Submit: Aaron Leventhal <aleventhal@chromium.org>
-Reviewed-by: Nektarios Paisios <nektar@chromium.org>
-Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
-Cr-Original-Commit-Position: refs/heads/main@{#1025405}
-Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3788215
-Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
-Cr-Commit-Position: refs/branch-heads/5112@{#1206}
-Cr-Branched-From: b13d3fe7b3c47a56354ef54b221008afa754412e-refs/heads/main@{#1012729}
-
-diff --git a/content/browser/accessibility/browser_accessibility_manager.cc b/content/browser/accessibility/browser_accessibility_manager.cc
-index 65213c9e3569d6a9f8d74eb655d48c1df5c9356b..d33fb5d5a3e6f741b03270f63aa34e5d58cac850 100644
---- a/content/browser/accessibility/browser_accessibility_manager.cc
-+++ b/content/browser/accessibility/browser_accessibility_manager.cc
-@@ -394,6 +394,10 @@ const ui::AXTreeData& BrowserAccessibilityManager::GetTreeData() const {
-   return ax_tree()->data();
- }
- 
-+std::string BrowserAccessibilityManager::ToString() const {
-+  return GetTreeData().ToString();
-+}
-+
- void BrowserAccessibilityManager::OnWindowFocused() {
-   if (IsRootTree())
-     FireFocusEventsIfNeeded();
-diff --git a/content/browser/accessibility/browser_accessibility_manager.h b/content/browser/accessibility/browser_accessibility_manager.h
-index 92d62b5832d4fc87830b1c2bad7c7b972f1de74e..ca696fd855dcfe45e80e6c070546b19b19d42f69 100644
---- a/content/browser/accessibility/browser_accessibility_manager.h
-+++ b/content/browser/accessibility/browser_accessibility_manager.h
-@@ -225,6 +225,8 @@ class CONTENT_EXPORT BrowserAccessibilityManager
-   // Get the AXTreeData for this frame.
-   const ui::AXTreeData& GetTreeData() const;
- 
-+  std::string ToString() const override;
-+
-   // Called to notify the accessibility manager that its associated native
-   // view got focused.
-   virtual void OnWindowFocused();
-diff --git a/extensions/renderer/api/automation/automation_ax_tree_wrapper.cc b/extensions/renderer/api/automation/automation_ax_tree_wrapper.cc
-index 93f59054158d089fd2754a8b99c0dc5407716e58..c50d65a55b4cadf8a5579ae7aca79f671088796f 100644
---- a/extensions/renderer/api/automation/automation_ax_tree_wrapper.cc
-+++ b/extensions/renderer/api/automation/automation_ax_tree_wrapper.cc
-@@ -4,6 +4,7 @@
- 
- #include "extensions/renderer/api/automation/automation_ax_tree_wrapper.h"
- 
-+#include "automation_ax_tree_wrapper.h"
- #include "base/containers/contains.h"
- #include "base/containers/cxx20_erase.h"
- #include "base/no_destructor.h"
-@@ -573,4 +574,8 @@ ui::AXNode* AutomationAXTreeWrapper::GetParentNodeFromParentTreeAsAXNode()
-   return owner_->GetParent(tree_.root(), &wrapper);
- }
- 
-+std::string AutomationAXTreeWrapper::ToString() const {
-+  return "<AutomationAXTreeWrapper>";
-+}
-+
- }  // namespace extensions
-diff --git a/extensions/renderer/api/automation/automation_ax_tree_wrapper.h b/extensions/renderer/api/automation/automation_ax_tree_wrapper.h
-index afb92e41edb824bf7c642fd2bb542daac653abf8..2c64b5eaac8d2521b0c9ff754b36c057f73f9e90 100644
---- a/extensions/renderer/api/automation/automation_ax_tree_wrapper.h
-+++ b/extensions/renderer/api/automation/automation_ax_tree_wrapper.h
-@@ -116,6 +116,7 @@ class AutomationAXTreeWrapper : public ui::AXTreeObserver,
-   ui::AXTreeID GetParentTreeID() const override;
-   ui::AXNode* GetRootAsAXNode() const override;
-   ui::AXNode* GetParentNodeFromParentTreeAsAXNode() const override;
-+  std::string ToString() const override;
- 
-  private:
-   // AXTreeObserver overrides.
-diff --git a/ui/accessibility/ax_node_position_unittest.cc b/ui/accessibility/ax_node_position_unittest.cc
-index b0f06a0912447e5fa9bad9e62b2523817490ea02..3081258496dacc4f26976dfd99ea005a70bcd210 100644
---- a/ui/accessibility/ax_node_position_unittest.cc
-+++ b/ui/accessibility/ax_node_position_unittest.cc
-@@ -9105,8 +9105,12 @@ TEST_F(AXPositionTest,
-   EXPECT_TRUE(test_position->IsNullPosition());
- }
- 
-+// TODO(crbug.com/1333970) It is not legal to call
-+// AsLeafTextPositionBeforeCharacter or AsLeafTextPositionAfterCharacter with
-+// a text position using out-of-range offsets. It's necessary to call
-+// AsValidPosition() first. Therefore, this test currently triggers a DCHECK.
- TEST_F(AXPositionTest,
--       AsLeafTextPositionBeforeAndAfterCharacterWithInvalidPosition) {
-+       DISABLED_AsLeafTextPositionBeforeAndAfterCharacterWithInvalidPosition) {
-   AXNodeData root_data;
-   root_data.id = 1;
-   root_data.role = ax::mojom::Role::kRootWebArea;
-diff --git a/ui/accessibility/ax_position.h b/ui/accessibility/ax_position.h
-index 9eaf0df84b04e88d9f78e95523732d90ecd0fe22..d23bb61a0713a44e864e6b940c78433d81490776 100644
---- a/ui/accessibility/ax_position.h
-+++ b/ui/accessibility/ax_position.h
-@@ -26,6 +26,7 @@
- #include "base/strings/string_util.h"
- #include "base/strings/utf_string_conversions.h"
- #include "third_party/abseil-cpp/absl/types/optional.h"
-+#include "ui/accessibility/ax_common.h"
- #include "ui/accessibility/ax_enum_util.h"
- #include "ui/accessibility/ax_enums.mojom.h"
- #include "ui/accessibility/ax_node.h"
-@@ -383,16 +384,33 @@ class AXPosition {
-     return str + " annotated_text=" + base::UTF16ToUTF8(annotated_text);
-   }
- 
-+  // Helper for logging the position, the AXTreeManager and the anchor node.
-+  std::string ToDebugString() const {
-+    if (IsNullPosition()) {
-+      return "* Position: null";
-+    }
-+    DCHECK(GetAnchor());
-+    DCHECK(GetManager());
-+    std::ostringstream str;
-+    str << "* Position: " << ToString()
-+        << "\n* Manager: " << GetManager()->ToString()
-+        << "\n* Anchor node: " << *GetAnchor();
-+    return str.str();
-+  }
-+
-   AXPositionKind kind() const { return kind_; }
-   AXTreeID tree_id() const { return tree_id_; }
-   AXNodeID anchor_id() const { return anchor_id_; }
- 
-+  AXTreeManager* GetManager() const {
-+    return AXTreeManagerMap::GetInstance().GetManager(tree_id());
-+  }
-+
-   AXNode* GetAnchor() const {
-     if (tree_id_ == AXTreeIDUnknown() || anchor_id_ == kInvalidAXNodeID)
-       return nullptr;
- 
--    const AXTreeManager* manager =
--        AXTreeManagerMap::GetInstance().GetManager(tree_id());
-+    const AXTreeManager* manager = GetManager();
-     if (manager)
-       return manager->GetNodeFromTree(anchor_id());
- 
-@@ -2569,13 +2587,6 @@ class AXPosition {
-       return Clone();
- 
-     AXPositionInstance text_position = AsTextPosition();
--    // The following situation should not be possible but there are existing
--    // crashes in the field.
--    //
--    // TODO(nektar): Remove this workaround as soon as the source of the bug
--    // is identified.
--    if (text_position->text_offset_ > text_position->MaxTextOffset())
--      return CreateNullPosition();
- 
-     // In case the input affinity is upstream, reset it to downstream.
-     //
-@@ -2593,6 +2604,16 @@ class AXPosition {
-     if (!text_position->IsIgnored() && !text_position->AtEndOfAnchor()) {
-       std::unique_ptr<base::i18n::BreakIterator> grapheme_iterator =
-           text_position->GetGraphemeIterator();
-+      // The following situation should not be possible but there are existing
-+      // crashes in the field.
-+      //
-+      // TODO(nektar): Remove this workaround as soon as the source of the bug
-+      // is identified.
-+      if (text_position->text_offset_ < 0 ||
-+          text_position->text_offset_ > text_position->MaxTextOffset()) {
-+        SANITIZER_NOTREACHED() << "Offset range error:\n" << ToDebugString();
-+        return CreateNullPosition();
-+      }
-       DCHECK_GE(text_position->text_offset_, 0);
-       DCHECK_LE(text_position->text_offset_, text_position->MaxTextOffset());
-       while (!text_position->AtStartOfAnchor() &&
-@@ -2645,9 +2666,11 @@ class AXPosition {
-       //
-       // TODO(nektar): Remove this workaround as soon as the source of the bug
-       // is identified.
--      if (text_position->text_offset_ > text_position->MaxTextOffset())
-+      if (text_position->text_offset_ < 0 ||
-+          text_position->text_offset_ > text_position->MaxTextOffset()) {
-+        SANITIZER_NOTREACHED() << "Offset range error:\n" << ToDebugString();
-         return CreateNullPosition();
--
-+      }
-       DCHECK_GE(text_position->text_offset_, 0);
-       DCHECK_LE(text_position->text_offset_, text_position->MaxTextOffset());
-       while (!text_position->AtEndOfAnchor() &&
-diff --git a/ui/accessibility/ax_tree_manager.h b/ui/accessibility/ax_tree_manager.h
-index 1081ed8fc3388ae7b6f535f2cd7437ac2e3db184..52f892c1acf3a50a24716bb361dd1ca231bd57a1 100644
---- a/ui/accessibility/ax_tree_manager.h
-+++ b/ui/accessibility/ax_tree_manager.h
-@@ -51,6 +51,11 @@ class AX_EXPORT AXTreeManager {
-   // Called when the tree manager is about to be removed from the tree map,
-   // `AXTreeManagerMap`.
-   virtual void WillBeRemovedFromMap() {}
-+
-+  // For debugging.
-+  // TODO(benjamin.beaudry) Instead of this, implement GetTreeData() on all
-+  // AXTreeManager subclasses, and have callers use GetTreeData().ToString();
-+  virtual std::string ToString() const = 0;
- };
- 
- }  // namespace ui
-diff --git a/ui/accessibility/test_ax_tree_manager.cc b/ui/accessibility/test_ax_tree_manager.cc
-index 15627a472481b46c66c3d40efa3895ab14cb89ef..5ee1750a265db3e9291c5f5a9beb1a4228278af2 100644
---- a/ui/accessibility/test_ax_tree_manager.cc
-+++ b/ui/accessibility/test_ax_tree_manager.cc
-@@ -116,4 +116,8 @@ AXNode* TestAXTreeManager::GetParentNodeFromParentTreeAsAXNode() const {
-   return nullptr;
- }
- 
-+std::string TestAXTreeManager::ToString() const {
-+  return "<TestAXTreeManager>";
-+}
-+
- }  // namespace ui
-diff --git a/ui/accessibility/test_ax_tree_manager.h b/ui/accessibility/test_ax_tree_manager.h
-index c155aeb4f164129a3b484386f0e4802a361df80a..dabc5650132d01f121f8a9763afc499800bfbd9c 100644
---- a/ui/accessibility/test_ax_tree_manager.h
-+++ b/ui/accessibility/test_ax_tree_manager.h
-@@ -53,6 +53,7 @@ class AX_EXPORT TestAXTreeManager : public AXTreeManager {
-   AXTreeID GetParentTreeID() const override;
-   AXNode* GetRootAsAXNode() const override;
-   AXNode* GetParentNodeFromParentTreeAsAXNode() const override;
-+  std::string ToString() const override;
- 
-  private:
-   std::unique_ptr<AXTree> tree_;
-diff --git a/ui/views/accessibility/views_ax_tree_manager.cc b/ui/views/accessibility/views_ax_tree_manager.cc
-index 9ddd02d0e05d56247cbeb48d97b26227090a40d3..269002feff50b3c95f7216ba3e5c339bc7e641a4 100644
---- a/ui/views/accessibility/views_ax_tree_manager.cc
-+++ b/ui/views/accessibility/views_ax_tree_manager.cc
-@@ -4,8 +4,6 @@
- 
- #include "ui/views/accessibility/views_ax_tree_manager.h"
- 
--#include <string>
--
- #include "base/bind.h"
- #include "base/callback.h"
- #include "base/check.h"
-@@ -105,6 +103,10 @@ ui::AXNode* ViewsAXTreeManager::GetParentNodeFromParentTreeAsAXNode() const {
-   return nullptr;
- }
- 
-+std::string ViewsAXTreeManager::ToString() const {
-+  return "<ViewsAXTreeManager>";
-+}
-+
- void ViewsAXTreeManager::OnViewEvent(View* view, ax::mojom::Event event) {
-   DCHECK(view);
-   AXAuraObjWrapper* wrapper = cache_.GetOrCreate(view);
-diff --git a/ui/views/accessibility/views_ax_tree_manager.h b/ui/views/accessibility/views_ax_tree_manager.h
-index 3c28a84ddcbddccc8e9d4ae6fd2a30cd4c29bc65..6a6a769f5280ac901df551a85c4de69fa4e8eeed 100644
---- a/ui/views/accessibility/views_ax_tree_manager.h
-+++ b/ui/views/accessibility/views_ax_tree_manager.h
-@@ -7,6 +7,7 @@
- 
- #include <memory>
- #include <set>
-+#include <string>
- #include <vector>
- 
- #include "base/callback_forward.h"
-@@ -89,6 +90,7 @@ class VIEWS_EXPORT ViewsAXTreeManager : public ui::AXTreeManager,
-   ui::AXTreeID GetParentTreeID() const override;
-   ui::AXNode* GetRootAsAXNode() const override;
-   ui::AXNode* GetParentNodeFromParentTreeAsAXNode() const override;
-+  std::string ToString() const override;
- 
-   // AXActionHandlerBase implementation.
-   void PerformAction(const ui::AXActionData& data) override;

patches/chromium/cherry-pick-54e32332750c.patch

@@ -1,141 +0,0 @@
-From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
-From: Min Qin <qinmin@chromium.org>
-Date: Tue, 12 Jul 2022 19:48:53 +0000
-Subject: Sanitize default file name in windows select file dialog
-
-On windows, '%' is a special character and can be used for environment
-variables. So if the default file name is '%DATADIR%', it can actually
-refer to another directory and thus causing weird behaviors.
-And '%' cannot be escaped when used in the file dialog. Both "^%" and
-"%%" don't work. This CL mitigates the issue by replacing '%' with '_'.
-This only affects the default file name when showing the dialog. Power
-users can still change the file name by adding '%' if needed.
-
-BUG=1308422
-
-(cherry picked from commit 9cdce354cb3b0da5b4b311638973d407be7712b6)
-
-Change-Id: Ibb275f5c3c2c9458c20d1e97ad527f7c95184eaa
-Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3688608
-Reviewed-by: Robert Liao <robliao@chromium.org>
-Commit-Queue: Min Qin <qinmin@chromium.org>
-Cr-Original-Commit-Position: refs/heads/main@{#1014602}
-Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3758469
-Cr-Commit-Position: refs/branch-heads/5112@{#822}
-Cr-Branched-From: b13d3fe7b3c47a56354ef54b221008afa754412e-refs/heads/main@{#1012729}
-
-diff --git a/ui/shell_dialogs/execute_select_file_win.cc b/ui/shell_dialogs/execute_select_file_win.cc
-index 063d4c7c96cba45448d4d7b0e7a8ddd3a6f67937..162dbc3aeb4ead16a415228b40fb67008e89fe63 100644
---- a/ui/shell_dialogs/execute_select_file_win.cc
-+++ b/ui/shell_dialogs/execute_select_file_win.cc
-@@ -10,6 +10,7 @@
- #include "base/callback.h"
- #include "base/files/file.h"
- #include "base/files/file_util.h"
-+#include "base/strings/string_tokenizer.h"
- #include "base/strings/string_util.h"
- #include "base/win/com_init_util.h"
- #include "base/win/registry.h"
-@@ -50,7 +51,7 @@ bool SetDefaultPath(IFileDialog* file_dialog,
-     default_folder = default_path;
-   } else {
-     default_folder = default_path.DirName();
--    default_file_name = default_path.BaseName();
-+    default_file_name = GetSanitizedFileName(default_path.BaseName());
-   }
- 
-   // Do not fail the file dialog operation if the specified folder is invalid.
-@@ -371,6 +372,33 @@ std::wstring AppendExtensionIfNeeded(const std::wstring& filename,
-   return return_value;
- }
- 
-+base::FilePath GetSanitizedFileName(const base::FilePath& file_name) {
-+  base::StringTokenizerT<std::wstring, std::wstring::const_iterator> t(
-+      file_name.value(), L"%");
-+  t.set_options(base::StringTokenizer::RETURN_EMPTY_TOKENS);
-+  std::wstring result;
-+  bool token_valid = t.GetNext();
-+  while (token_valid) {
-+    // Append substring before the first "%".
-+    result.append(t.token());
-+    // Done if we are reaching the end delimiter,
-+    if (!t.GetNext()) {
-+      break;
-+    }
-+    std::wstring string_after_first_percent = t.token();
-+    token_valid = t.GetNext();
-+    // If there are no other "%", append the string after
-+    // the first "%". Otherwise, remove the string between
-+    // the "%" and continue handing the remaining string.
-+    if (!token_valid) {
-+      result.append(L"%");
-+      result.append(string_after_first_percent);
-+      break;
-+    }
-+  }
-+  return base::FilePath(result);
-+}
-+
- void ExecuteSelectFile(
-     SelectFileDialog::Type type,
-     const std::u16string& title,
-diff --git a/ui/shell_dialogs/execute_select_file_win.h b/ui/shell_dialogs/execute_select_file_win.h
-index dc808af395333a2bd81c2bd73faac4c6063fd409..8fa96906c0288d0021c1500bd442a35c0c29dfd2 100644
---- a/ui/shell_dialogs/execute_select_file_win.h
-+++ b/ui/shell_dialogs/execute_select_file_win.h
-@@ -26,6 +26,12 @@ SHELL_DIALOGS_EXPORT std::wstring AppendExtensionIfNeeded(
-     const std::wstring& filter_selected,
-     const std::wstring& suggested_ext);
- 
-+// Given a file name, return the sanitized version by removing substrings that
-+// are embedded in double '%' characters as those are reserved for environment
-+// variables. Implementation detail exported for unit tests.
-+SHELL_DIALOGS_EXPORT base::FilePath GetSanitizedFileName(
-+    const base::FilePath& file_name);
-+
- // Describes a filter for a file dialog.
- struct FileFilterSpec {
-   // A human readable description of this filter. E.g. "HTML Files."
-diff --git a/ui/shell_dialogs/execute_select_file_win_unittest.cc b/ui/shell_dialogs/execute_select_file_win_unittest.cc
-index df5e8a89d9b0854626a99750a56e3f2500dba812..b6c604fa5a798ba6e448e892ca7a9212cce507fc 100644
---- a/ui/shell_dialogs/execute_select_file_win_unittest.cc
-+++ b/ui/shell_dialogs/execute_select_file_win_unittest.cc
-@@ -50,3 +50,38 @@ TEST(ShellDialogsWin, AppendExtensionIfNeeded) {
-                                           test_cases[i].suggested_ext));
-   }
- }
-+
-+TEST(ShellDialogsWin, GetSanitizedFileName) {
-+  struct GetSanitizedFileNameTestCase {
-+    const wchar_t* filename;
-+    const wchar_t* sanitized_filename;
-+  } test_cases[] = {
-+      {L"", L""},
-+      {L"a.txt", L"a.txt"},
-+
-+      // Only 1 "%" in file name.
-+      {L"%", L"%"},
-+      {L"%.txt", L"%.txt"},
-+      {L"ab%c.txt", L"ab%c.txt"},
-+      {L"abc.t%", L"abc.t%"},
-+
-+      // 2 "%" in file name.
-+      {L"%%", L""},
-+      {L"%c%", L""},
-+      {L"%c%d", L"d"},
-+      {L"d%c%.txt", L"d.txt"},
-+      {L"ab%c.t%", L"ab"},
-+      {L"abc.%t%", L"abc."},
-+
-+      // More than 2 "%" in file name.
-+      {L"%ab%c%.txt", L"c%.txt"},
-+      {L"%abc%.%txt%", L"."},
-+      {L"%ab%c%.%txt%", L"ctxt%"},
-+  };
-+
-+  for (size_t i = 0; i < std::size(test_cases); ++i) {
-+    SCOPED_TRACE(base::StringPrintf("i=%zu", i));
-+    EXPECT_EQ(base::FilePath(test_cases[i].sanitized_filename),
-+              ui::GetSanitizedFileName(base::FilePath(test_cases[i].filename)));
-+  }
-+}

patches/chromium/cherry-pick-60d8559e150a.patch

@@ -1,41 +0,0 @@
-From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
-From: Lei Zhang <thestig@chromium.org>
-Date: Tue, 12 Jul 2022 18:52:14 +0000
-Subject: M104: Better define "first result" in PDFiumEngine::AddFindResult().
-
-Currently, changing the PDF layout confuses AddFindResult() and causes
-it to fail a DCHECK(). Adjust AddFindResult() to avoid the failing
-DCHECK().
-
-This is a cherry-pick of https://crrev.com/1021389 without the test
-changes.
-
-Bug: 1339745
-Change-Id: I25c2b6b436700f9aeca4924fef662ad2909f0a8c
-Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3758626
-Reviewed-by: K. Moon <kmoon@chromium.org>
-Commit-Queue: Lei Zhang <thestig@chromium.org>
-Cr-Commit-Position: refs/branch-heads/5112@{#820}
-Cr-Branched-From: b13d3fe7b3c47a56354ef54b221008afa754412e-refs/heads/main@{#1012729}
-
-diff --git a/pdf/pdfium/pdfium_engine.cc b/pdf/pdfium/pdfium_engine.cc
-index c015d4b06a44c9121576d14160b84e871081fa33..0afe3c60715c948c7e376f81646c11b29cc01486 100644
---- a/pdf/pdfium/pdfium_engine.cc
-+++ b/pdf/pdfium/pdfium_engine.cc
-@@ -1971,7 +1971,7 @@ void PDFiumEngine::SearchUsingICU(const std::u16string& term,
- }
- 
- void PDFiumEngine::AddFindResult(const PDFiumRange& result) {
--  bool first_result = find_results_.empty();
-+  bool first_result = find_results_.empty() && !resume_find_index_.has_value();
-   // Figure out where to insert the new location, since we could have
-   // started searching midway and now we wrapped.
-   size_t result_index;
-@@ -1988,7 +1988,6 @@ void PDFiumEngine::AddFindResult(const PDFiumRange& result) {
-   UpdateTickMarks();
-   client_->NotifyNumberOfFindResultsChanged(find_results_.size(), false);
-   if (first_result) {
--    DCHECK(!resume_find_index_);
-     DCHECK(!current_find_index_);
-     SelectFindResult(/*forward=*/true);
-   }

patches/chromium/cherry-pick-94a8bdafc8c6.patch

@@ -1,414 +0,0 @@
-From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
-From: Keren Zhu <kerenzhu@chromium.org>
-Date: Thu, 9 Jun 2022 14:50:26 +0000
-Subject: Fix use-after-free vulnerability in ComboboxModel
-MIME-Version: 1.0
-Content-Type: text/plain; charset=UTF-8
-Content-Transfer-Encoding: 8bit
-
-Stop the Combobox from observing the model when the model gets
-destroyed. This is done by adding a virtual OnComboboxModelDestroying()
-to the base observer class and calling it in ~ComboboxModel().
-
-This fix will prevent the use-after-free that happens when the combobox outlives the model, usually because the model lifetime
-is managed by non-UI component.
-
-Bug: 1264288
-Change-Id: Ia00881a9b674bbc83bbf54dd228490c1cc1290bc
-Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3693825
-Commit-Queue: Keren Zhu <kerenzhu@chromium.org>
-Reviewed-by: Matthias Körber <koerber@google.com>
-Auto-Submit: Keren Zhu <kerenzhu@chromium.org>
-Reviewed-by: Peter Boström <pbos@chromium.org>
-Cr-Commit-Position: refs/heads/main@{#1012504}
-
-diff --git a/chrome/browser/ui/bookmarks/recently_used_folders_combo_model.cc b/chrome/browser/ui/bookmarks/recently_used_folders_combo_model.cc
-index 323f85651611ff98e45884e3b0b7211eaa25039b..0d0bb0d21b1d96841a30bfea336af918b6da83f8 100644
---- a/chrome/browser/ui/bookmarks/recently_used_folders_combo_model.cc
-+++ b/chrome/browser/ui/bookmarks/recently_used_folders_combo_model.cc
-@@ -130,16 +130,6 @@ int RecentlyUsedFoldersComboModel::GetDefaultIndex() const {
-   return it == items_.end() ? 0 : static_cast<int>(it - items_.begin());
- }
- 
--void RecentlyUsedFoldersComboModel::AddObserver(
--    ui::ComboboxModelObserver* observer) {
--  observers_.AddObserver(observer);
--}
--
--void RecentlyUsedFoldersComboModel::RemoveObserver(
--    ui::ComboboxModelObserver* observer) {
--  observers_.RemoveObserver(observer);
--}
--
- void RecentlyUsedFoldersComboModel::BookmarkModelLoaded(BookmarkModel* model,
-                                                         bool ids_reassigned) {}
- 
-@@ -176,7 +166,7 @@ void RecentlyUsedFoldersComboModel::OnWillRemoveBookmarks(
-     }
-   }
-   if (changed) {
--    for (ui::ComboboxModelObserver& observer : observers_)
-+    for (ui::ComboboxModelObserver& observer : observers())
-       observer.OnComboboxModelChanged(this);
-   }
- }
-@@ -219,7 +209,7 @@ void RecentlyUsedFoldersComboModel::BookmarkAllUserNodesRemoved(
-     }
-   }
-   if (changed) {
--    for (ui::ComboboxModelObserver& observer : observers_)
-+    for (ui::ComboboxModelObserver& observer : observers())
-       observer.OnComboboxModelChanged(this);
-   }
- }
-diff --git a/chrome/browser/ui/bookmarks/recently_used_folders_combo_model.h b/chrome/browser/ui/bookmarks/recently_used_folders_combo_model.h
-index 8682e750f4407e615264986024e2a7dd0bae038f..0c02c685a02875c7b91ca9e6228864bc04e45c10 100644
---- a/chrome/browser/ui/bookmarks/recently_used_folders_combo_model.h
-+++ b/chrome/browser/ui/bookmarks/recently_used_folders_combo_model.h
-@@ -38,8 +38,6 @@ class RecentlyUsedFoldersComboModel : public ui::ComboboxModel,
-   std::u16string GetItemAt(int index) const override;
-   bool IsItemSeparatorAt(int index) const override;
-   int GetDefaultIndex() const override;
--  void AddObserver(ui::ComboboxModelObserver* observer) override;
--  void RemoveObserver(ui::ComboboxModelObserver* observer) override;
- 
-   // Overriden from bookmarks::BookmarkModelObserver:
-   void BookmarkModelLoaded(bookmarks::BookmarkModel* model,
-@@ -90,8 +88,6 @@ class RecentlyUsedFoldersComboModel : public ui::ComboboxModel,
-   const raw_ptr<bookmarks::BookmarkModel> bookmark_model_;
- 
-   const raw_ptr<const bookmarks::BookmarkNode> parent_node_;
--
--  base::ObserverList<ui::ComboboxModelObserver> observers_;
- };
- 
- #endif  // CHROME_BROWSER_UI_BOOKMARKS_RECENTLY_USED_FOLDERS_COMBO_MODEL_H_
-diff --git a/chrome/browser/ui/bookmarks/recently_used_folders_combo_model_unittest.cc b/chrome/browser/ui/bookmarks/recently_used_folders_combo_model_unittest.cc
-index 60455386b7d5f1da72c92424ccf95fd971e7590a..3bfe6852b8a54a53aafea5eeec2da850097b2f0a 100644
---- a/chrome/browser/ui/bookmarks/recently_used_folders_combo_model_unittest.cc
-+++ b/chrome/browser/ui/bookmarks/recently_used_folders_combo_model_unittest.cc
-@@ -41,6 +41,8 @@ class TestComboboxModelObserver : public ui::ComboboxModelObserver {
-     changed_ = true;
-   }
- 
-+  void OnComboboxModelDestroying(ui::ComboboxModel* model) override {}
-+
-  private:
-   bool changed_;
- };
-diff --git a/components/autofill/core/browser/ui/address_combobox_model.cc b/components/autofill/core/browser/ui/address_combobox_model.cc
-index c7e6f906ff32cb198f8723d6678971ae6cff28a2..d52dc0e925c54634452f86ca90792b318776e895 100644
---- a/components/autofill/core/browser/ui/address_combobox_model.cc
-+++ b/components/autofill/core/browser/ui/address_combobox_model.cc
-@@ -84,14 +84,6 @@ int AddressComboboxModel::GetDefaultIndex() const {
-   return ui::ComboboxModel::GetDefaultIndex();
- }
- 
--void AddressComboboxModel::AddObserver(ui::ComboboxModelObserver* observer) {
--  observers_.AddObserver(observer);
--}
--
--void AddressComboboxModel::RemoveObserver(ui::ComboboxModelObserver* observer) {
--  observers_.RemoveObserver(observer);
--}
--
- int AddressComboboxModel::AddNewProfile(const AutofillProfile& profile) {
-   profiles_cache_.push_back(std::make_unique<AutofillProfile>(profile));
-   UpdateAddresses();
-@@ -131,7 +123,7 @@ void AddressComboboxModel::UpdateAddresses() {
-   for (size_t i = 0; i < profiles_cache_.size(); ++i)
-     addresses_.emplace_back(profiles_cache_[i]->guid(), labels[i]);
- 
--  for (auto& observer : observers_) {
-+  for (auto& observer : observers()) {
-     observer.OnComboboxModelChanged(this);
-   }
- }
-diff --git a/components/autofill/core/browser/ui/address_combobox_model.h b/components/autofill/core/browser/ui/address_combobox_model.h
-index 02d65209d2729deae608481411e1539ba08f5f7e..3a41b30c92543633da29e40e2c64cc4597e322d2 100644
---- a/components/autofill/core/browser/ui/address_combobox_model.h
-+++ b/components/autofill/core/browser/ui/address_combobox_model.h
-@@ -40,8 +40,6 @@ class AddressComboboxModel : public ui::ComboboxModel {
-   std::u16string GetItemAt(int index) const override;
-   bool IsItemSeparatorAt(int index) const override;
-   int GetDefaultIndex() const override;
--  void AddObserver(ui::ComboboxModelObserver* observer) override;
--  void RemoveObserver(ui::ComboboxModelObserver* observer) override;
- 
-   // Adds |profile| to model and return its combobox index. The lifespan of
-   // |profile| beyond this call is undefined so a copy must be made.
-@@ -72,9 +70,6 @@ class AddressComboboxModel : public ui::ComboboxModel {
- 
-   // If non empty, the guid of the address that should be selected by default.
-   std::string default_selected_guid_;
--
--  // To be called when the data for the given country code was loaded.
--  base::ObserverList<ui::ComboboxModelObserver> observers_;
- };
- 
- }  // namespace autofill
-diff --git a/components/autofill/core/browser/ui/region_combobox_model.cc b/components/autofill/core/browser/ui/region_combobox_model.cc
-index 6439ccb1f074f1c3965dfb2b45ab6f6636437c17..42626aff427f1b3f3400aba399e3f9c89faa06ba 100644
---- a/components/autofill/core/browser/ui/region_combobox_model.cc
-+++ b/components/autofill/core/browser/ui/region_combobox_model.cc
-@@ -67,14 +67,6 @@ bool RegionComboboxModel::IsItemSeparatorAt(int index) const {
-   return regions_[index].first.empty();
- }
- 
--void RegionComboboxModel::AddObserver(ui::ComboboxModelObserver* observer) {
--  observers_.AddObserver(observer);
--}
--
--void RegionComboboxModel::RemoveObserver(ui::ComboboxModelObserver* observer) {
--  observers_.RemoveObserver(observer);
--}
--
- void RegionComboboxModel::OnRegionDataLoaded(
-     const std::vector<const ::i18n::addressinput::RegionData*>& regions) {
-   // The RegionDataLoader will eventually self destruct after this call.
-@@ -95,7 +87,7 @@ void RegionComboboxModel::OnRegionDataLoaded(
-     failed_to_load_data_ = true;
-   }
- 
--  for (auto& observer : observers_) {
-+  for (auto& observer : observers()) {
-     observer.OnComboboxModelChanged(this);
-   }
- }
-diff --git a/components/autofill/core/browser/ui/region_combobox_model.h b/components/autofill/core/browser/ui/region_combobox_model.h
-index d1b5d8b9db0c4d9d15e4f2a50a6cba38b33f1be8..52cffd5d00649f8e2be7189bca128ba4c3e8a97d 100644
---- a/components/autofill/core/browser/ui/region_combobox_model.h
-+++ b/components/autofill/core/browser/ui/region_combobox_model.h
-@@ -54,8 +54,6 @@ class RegionComboboxModel : public ui::ComboboxModel {
-   int GetItemCount() const override;
-   std::u16string GetItemAt(int index) const override;
-   bool IsItemSeparatorAt(int index) const override;
--  void AddObserver(ui::ComboboxModelObserver* observer) override;
--  void RemoveObserver(ui::ComboboxModelObserver* observer) override;
- 
-  private:
-   // Callback for the RegionDataLoader.
-@@ -72,9 +70,6 @@ class RegionComboboxModel : public ui::ComboboxModel {
-   // List of <code, name> pairs for ADDRESS_HOME_STATE combobox values;
-   std::vector<std::pair<std::string, std::string>> regions_;
- 
--  // To be called when the data for the given country code was loaded.
--  base::ObserverList<ui::ComboboxModelObserver> observers_;
--
-   // Weak pointer factory.
-   base::WeakPtrFactory<RegionComboboxModel> weak_factory_{this};
- };
-diff --git a/ui/base/models/combobox_model.cc b/ui/base/models/combobox_model.cc
-index d307ee0ec592ae01a1d04cef85c0a492b7f7e29e..413adebd0349e304006de0cc0c4e2a4536ebbf06 100644
---- a/ui/base/models/combobox_model.cc
-+++ b/ui/base/models/combobox_model.cc
-@@ -4,10 +4,18 @@
- 
- #include "ui/base/models/combobox_model.h"
- 
-+#include "ui/base/models/combobox_model_observer.h"
- #include "ui/base/models/image_model.h"
- 
- namespace ui {
- 
-+ComboboxModel::ComboboxModel() = default;
-+
-+ComboboxModel::~ComboboxModel() {
-+  for (auto& observer : observers_)
-+    observer.OnComboboxModelDestroying(this);
-+}
-+
- std::u16string ComboboxModel::GetDropDownTextAt(int index) const {
-   return GetItemAt(index);
- }
-@@ -36,4 +44,12 @@ bool ComboboxModel::IsItemEnabledAt(int index) const {
-   return true;
- }
- 
-+void ComboboxModel::AddObserver(ComboboxModelObserver* observer) {
-+  observers_.AddObserver(observer);
-+}
-+
-+void ComboboxModel::RemoveObserver(ComboboxModelObserver* observer) {
-+  observers_.RemoveObserver(observer);
-+}
-+
- }  // namespace ui
-diff --git a/ui/base/models/combobox_model.h b/ui/base/models/combobox_model.h
-index 5264aaa5550859fce39a8485feff16c8fd83d897..eeff7dc8444e77fd598eb7ce05ab18259a9d7ef5 100644
---- a/ui/base/models/combobox_model.h
-+++ b/ui/base/models/combobox_model.h
-@@ -8,6 +8,7 @@
- #include <string>
- 
- #include "base/component_export.h"
-+#include "base/observer_list.h"
- 
- namespace ui {
- 
-@@ -17,7 +18,8 @@ class ImageModel;
- // A data model for a combo box.
- class COMPONENT_EXPORT(UI_BASE) ComboboxModel {
-  public:
--  virtual ~ComboboxModel() {}
-+  ComboboxModel();
-+  virtual ~ComboboxModel();
- 
-   // Returns the number of items in the combo box.
-   virtual int GetItemCount() const = 0;
-@@ -52,9 +54,17 @@ class COMPONENT_EXPORT(UI_BASE) ComboboxModel {
-   // Returns true if the item at |index| is enabled.
-   virtual bool IsItemEnabledAt(int index) const;
- 
--  // Adds/removes an observer. Override if model supports mutation.
--  virtual void AddObserver(ComboboxModelObserver* observer) {}
--  virtual void RemoveObserver(ComboboxModelObserver* observer) {}
-+  // Adds/removes an observer.
-+  void AddObserver(ComboboxModelObserver* observer);
-+  void RemoveObserver(ComboboxModelObserver* observer);
-+
-+ protected:
-+  base::ObserverList<ui::ComboboxModelObserver>& observers() {
-+    return observers_;
-+  }
-+
-+ private:
-+  base::ObserverList<ui::ComboboxModelObserver> observers_;
- };
- 
- }  // namespace ui
-diff --git a/ui/base/models/combobox_model_observer.h b/ui/base/models/combobox_model_observer.h
-index 5e00ab68a0c14d0b48317ca287e3f105351a102c..44325ff0aa94b75eb662be1637f44aa5524a33e8 100644
---- a/ui/base/models/combobox_model_observer.h
-+++ b/ui/base/models/combobox_model_observer.h
-@@ -16,10 +16,13 @@ class ComboboxModel;
- class COMPONENT_EXPORT(UI_BASE) ComboboxModelObserver
-     : public base::CheckedObserver {
-  public:
--  // Invoked when |model| has changed in some way. The observer should assume
-+  // Invoked when `model` has changed in some way. The observer should assume
-   // everything changed.
-   virtual void OnComboboxModelChanged(ComboboxModel* model) = 0;
- 
-+  // Invoked when `model` is destroyed. The observer should stop observing.
-+  virtual void OnComboboxModelDestroying(ComboboxModel* model) = 0;
-+
-  protected:
-   ~ComboboxModelObserver() override = default;
- };
-diff --git a/ui/views/controls/combobox/combobox.cc b/ui/views/controls/combobox/combobox.cc
-index aa135250e469d2405fba618c96b0bf38acaf59f0..b8d41cfeb67f3b4c098b2b329b2dfa7fe246dabb 100644
---- a/ui/views/controls/combobox/combobox.cc
-+++ b/ui/views/controls/combobox/combobox.cc
-@@ -578,6 +578,10 @@ void Combobox::OnComboboxModelChanged(ui::ComboboxModel* model) {
-   OnContentSizeMaybeChanged();
- }
- 
-+void Combobox::OnComboboxModelDestroying(ui::ComboboxModel* model) {
-+  SetModel(nullptr);
-+}
-+
- const base::RepeatingClosure& Combobox::GetCallback() const {
-   return callback_;
- }
-diff --git a/ui/views/controls/combobox/combobox.h b/ui/views/controls/combobox/combobox.h
-index fc77f8e49cead5fb689fba3d56c65c1b8e69f298..1a3f533256eca91e4fd4552ee5425b7ca8e7ad7e 100644
---- a/ui/views/controls/combobox/combobox.h
-+++ b/ui/views/controls/combobox/combobox.h
-@@ -131,6 +131,7 @@ class VIEWS_EXPORT Combobox : public View,
-  protected:
-   // Overridden from ComboboxModelObserver:
-   void OnComboboxModelChanged(ui::ComboboxModel* model) override;
-+  void OnComboboxModelDestroying(ui::ComboboxModel* model) override;
- 
-   // Getters to be used by metadata.
-   const base::RepeatingClosure& GetCallback() const;
-diff --git a/ui/views/controls/combobox/combobox_unittest.cc b/ui/views/controls/combobox/combobox_unittest.cc
-index 7ce20acc4b3ecd6470d5f017f9171d0be35c09d2..91661f33074d3453b4f28a410ecc918b793f86c6 100644
---- a/ui/views/controls/combobox/combobox_unittest.cc
-+++ b/ui/views/controls/combobox/combobox_unittest.cc
-@@ -84,13 +84,6 @@ class TestComboboxModel : public ui::ComboboxModel {
-     return 0;
-   }
- 
--  void AddObserver(ui::ComboboxModelObserver* observer) override {
--    observers_.AddObserver(observer);
--  }
--  void RemoveObserver(ui::ComboboxModelObserver* observer) override {
--    observers_.RemoveObserver(observer);
--  }
--
-   void SetSeparators(const std::set<int>& separators) {
-     separators_ = separators;
-     OnModelChanged();
-@@ -103,11 +96,10 @@ class TestComboboxModel : public ui::ComboboxModel {
- 
-  private:
-   void OnModelChanged() {
--    for (auto& observer : observers_)
-+    for (auto& observer : observers())
-       observer.OnComboboxModelChanged(this);
-   }
- 
--  base::ObserverList<ui::ComboboxModelObserver> observers_;
-   std::set<int> separators_;
-   int item_count_ = kItemCount;
- };
-@@ -134,20 +126,13 @@ class VectorComboboxModel : public ui::ComboboxModel {
-   }
-   bool IsItemSeparatorAt(int index) const override { return false; }
-   int GetDefaultIndex() const override { return default_index_; }
--  void AddObserver(ui::ComboboxModelObserver* observer) override {
--    observers_.AddObserver(observer);
--  }
--  void RemoveObserver(ui::ComboboxModelObserver* observer) override {
--    observers_.RemoveObserver(observer);
--  }
- 
-   void ValuesChanged() {
--    for (auto& observer : observers_)
-+    for (auto& observer : observers())
-       observer.OnComboboxModelChanged(this);
-   }
- 
-  private:
--  base::ObserverList<ui::ComboboxModelObserver> observers_;
-   int default_index_ = 0;
-   const raw_ptr<std::vector<std::string>> values_;
- };
-@@ -884,6 +869,15 @@ TEST_F(ComboboxTest, SetTooltipTextNotifiesAccessibilityEvent) {
-   EXPECT_EQ(test_tooltip_text, ASCIIToUTF16(name));
- }
- 
-+// Regression test for crbug.com/1264288.
-+// Should fail in ASan build before the fix.
-+TEST_F(ComboboxTest, NoCrashWhenComboboxOutlivesModel) {
-+  auto model = std::make_unique<TestComboboxModel>();
-+  auto combobox = std::make_unique<TestCombobox>(model.get());
-+  model.reset();
-+  combobox.reset();
-+}
-+
- namespace {
- 
- using ComboboxDefaultTest = ViewsTestBase;
-diff --git a/ui/views/controls/editable_combobox/editable_combobox.cc b/ui/views/controls/editable_combobox/editable_combobox.cc
-index b5301bfb0a3c8da3daa1d3646c2f4872cef2cdab..faac607fefcc8caf572eb83456e7520146c1d0ad 100644
---- a/ui/views/controls/editable_combobox/editable_combobox.cc
-+++ b/ui/views/controls/editable_combobox/editable_combobox.cc
-@@ -190,10 +190,15 @@ class EditableCombobox::EditableComboboxMenuModel
-     return combobox_model_->GetDropDownIconAt(items_shown_[index].index);
-   }
- 
-+  // ComboboxModelObserver:
-   void OnComboboxModelChanged(ui::ComboboxModel* model) override {
-     UpdateItemsShown();
-   }
- 
-+  void OnComboboxModelDestroying(ui::ComboboxModel* model) override {
-+    observation_.Reset();
-+  }
-+
-   int GetItemCount() const override { return items_shown_.size(); }
- 
-  private:

patches/chromium/cherry-pick-bd9724c9fe63.patch

@@ -1,203 +0,0 @@
-From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
-From: Min Qin <qinmin@chromium.org>
-Date: Tue, 28 Jun 2022 16:27:43 +0000
-Subject: passing update_first_party_url_on_redirect=false for fetch
-
-Background fetch doesn't work like regular download as it is not
-considered a top frame navigation. This CL let background fetch to
-pass update_first_party_url_on_redirect=false to DownloadURLParameters,
-and handle it properly w.r.t samesite cookies.
-
-BUG=1268580
-
-(cherry picked from commit bf1e93c6af21dad12088b615feda07a90a85c158)
-
-Change-Id: I3a1cc33be8578d5d8c796dbbb21fa35a47bdda36
-Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3712307
-Reviewed-by: Rayan Kanso <rayankans@chromium.org>
-Commit-Queue: Min Qin <qinmin@chromium.org>
-Cr-Original-Commit-Position: refs/heads/main@{#1016316}
-Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3727786
-Cr-Commit-Position: refs/branch-heads/5112@{#397}
-Cr-Branched-From: b13d3fe7b3c47a56354ef54b221008afa754412e-refs/heads/main@{#1012729}
-
-diff --git a/components/background_fetch/background_fetch_delegate_base.cc b/components/background_fetch/background_fetch_delegate_base.cc
-index 5f88192eb4e92d4c41c79db188b8b9982f005258..26f7716ae83b70cdcf7cdb23652c2c56d7dc27bf 100644
---- a/components/background_fetch/background_fetch_delegate_base.cc
-+++ b/components/background_fetch/background_fetch_delegate_base.cc
-@@ -101,6 +101,7 @@ void BackgroundFetchDelegateBase::DownloadUrl(
-                           weak_ptr_factory_.GetWeakPtr());
-   params.traffic_annotation =
-       net::MutableNetworkTrafficAnnotationTag(traffic_annotation);
-+  params.request_params.update_first_party_url_on_redirect = false;
- 
-   JobDetails* job_details = GetJobDetails(job_id);
-   if (job_details->job_state == JobDetails::State::kPendingWillStartPaused ||
-diff --git a/components/download/content/internal/download_driver_impl.cc b/components/download/content/internal/download_driver_impl.cc
-index 2b2da55b06e3b4859f439d5b3bf7013b981b75a0..b207ce5c6bd3c332a34885e1dc58cc11d91fe31c 100644
---- a/components/download/content/internal/download_driver_impl.cc
-+++ b/components/download/content/internal/download_driver_impl.cc
-@@ -229,6 +229,8 @@ void DownloadDriverImpl::Start(
-     download_url_params->set_isolation_info(
-         request_params.isolation_info.value());
-   }
-+  download_url_params->set_update_first_party_url_on_redirect(
-+      request_params.update_first_party_url_on_redirect);
- 
-   download_manager_coordinator_->DownloadUrl(std::move(download_url_params));
- }
-diff --git a/components/download/internal/common/download_utils.cc b/components/download/internal/common/download_utils.cc
-index 11f524861320eae8ab694022d97a6fe2ac7366ce..454326720b5c88cc61e4527790797fd7f522014d 100644
---- a/components/download/internal/common/download_utils.cc
-+++ b/components/download/internal/common/download_utils.cc
-@@ -386,8 +386,10 @@ std::unique_ptr<network::ResourceRequest> CreateResourceRequest(
-     // cross-site URL has been visited before.
-     url::Origin origin = url::Origin::Create(params->url());
-     request->trusted_params->isolation_info = net::IsolationInfo::Create(
--        net::IsolationInfo::RequestType::kMainFrame, origin, origin,
--        net::SiteForCookies::FromOrigin(origin));
-+        params->update_first_party_url_on_redirect()
-+            ? net::IsolationInfo::RequestType::kMainFrame
-+            : net::IsolationInfo::RequestType::kOther,
-+        origin, origin, net::SiteForCookies::FromOrigin(origin));
-     request->site_for_cookies = net::SiteForCookies::FromUrl(params->url());
-   }
- 
-@@ -395,7 +397,8 @@ std::unique_ptr<network::ResourceRequest> CreateResourceRequest(
-   request->referrer = params->referrer();
-   request->referrer_policy = params->referrer_policy();
-   request->is_outermost_main_frame = true;
--  request->update_first_party_url_on_redirect = true;
-+  request->update_first_party_url_on_redirect =
-+      params->update_first_party_url_on_redirect();
- 
-   // Downloads should be treated as navigations from Fetch spec perspective.
-   // See also:
-diff --git a/components/download/public/background_service/download_params.h b/components/download/public/background_service/download_params.h
-index 8b911276e757ee889ed05a3fd60cc365ad8f1982..a976d470094462be735e81cf097f32b34c258270 100644
---- a/components/download/public/background_service/download_params.h
-+++ b/components/download/public/background_service/download_params.h
-@@ -126,6 +126,12 @@ struct RequestParams {
-   // be invalidate during download resumption in new browser session. Not
-   // supported on iOS.
-   absl::optional<net::IsolationInfo> isolation_info;
-+
-+  // First-party URL redirect policy: During server redirects, whether the
-+  // first-party URL for cookies will need to be changed. Download is normally
-+  // considered a main frame navigation. However, this is not true for
-+  // background fetch.
-+  bool update_first_party_url_on_redirect = true;
- };
- 
- // The parameters that describe a download request made to the DownloadService.
-diff --git a/components/download/public/common/download_url_parameters.cc b/components/download/public/common/download_url_parameters.cc
-index 3dec7148d86cd3892670df8b95dcb78d49616e89..25ea6f13e0df9f23364b75c48b870d8ea6a53e92 100644
---- a/components/download/public/common/download_url_parameters.cc
-+++ b/components/download/public/common/download_url_parameters.cc
-@@ -34,7 +34,8 @@ DownloadUrlParameters::DownloadUrlParameters(
-       traffic_annotation_(traffic_annotation),
-       download_source_(DownloadSource::UNKNOWN),
-       require_safety_checks_(true),
--      has_user_gesture_(false) {}
-+      has_user_gesture_(false),
-+      update_first_party_url_on_redirect_(true) {}
- 
- DownloadUrlParameters::~DownloadUrlParameters() = default;
- 
-diff --git a/components/download/public/common/download_url_parameters.h b/components/download/public/common/download_url_parameters.h
-index ba0a03cb035a79651967ac2882f89f577bd0c012..61eb9af8a00c3e4adf700178994a9e6e864bcf0c 100644
---- a/components/download/public/common/download_url_parameters.h
-+++ b/components/download/public/common/download_url_parameters.h
-@@ -279,6 +279,11 @@ class COMPONENTS_DOWNLOAD_EXPORT DownloadUrlParameters {
-     has_user_gesture_ = has_user_gesture;
-   }
- 
-+  void set_update_first_party_url_on_redirect(
-+      bool update_first_party_url_on_redirect) {
-+    update_first_party_url_on_redirect_ = update_first_party_url_on_redirect;
-+  }
-+
-   OnStartedCallback& callback() { return callback_; }
-   bool content_initiated() const { return content_initiated_; }
-   const std::string& last_modified() const { return last_modified_; }
-@@ -335,6 +340,9 @@ class COMPONENTS_DOWNLOAD_EXPORT DownloadUrlParameters {
-     return isolation_info_;
-   }
-   bool has_user_gesture() const { return has_user_gesture_; }
-+  bool update_first_party_url_on_redirect() const {
-+    return update_first_party_url_on_redirect_;
-+  }
- 
-   // STATE CHANGING: All save_info_ sub-objects will be in an indeterminate
-   // state following this call.
-@@ -383,6 +391,7 @@ class COMPONENTS_DOWNLOAD_EXPORT DownloadUrlParameters {
-   bool require_safety_checks_;
-   absl::optional<net::IsolationInfo> isolation_info_;
-   bool has_user_gesture_;
-+  bool update_first_party_url_on_redirect_;
- };
- 
- }  // namespace download
-diff --git a/content/browser/download/download_browsertest.cc b/content/browser/download/download_browsertest.cc
-index 6dcc861171b7034d7426c5c683cafca689e3d7ea..500521ce2c383d40c13a9359ba4c49d3417670f7 100644
---- a/content/browser/download/download_browsertest.cc
-+++ b/content/browser/download/download_browsertest.cc
-@@ -3763,6 +3763,58 @@ IN_PROC_BROWSER_TEST_F(DownloadContentTest, UpdateSiteForCookies) {
-                                 site_a.GetURL("a.test", "/")));
- }
- 
-+// Tests that if `update_first_party_url_on_redirect` is set to false, download
-+// will not behave like a top-level frame navigation and SameSite=Strict cookies
-+// will not be set on a redirection.
-+IN_PROC_BROWSER_TEST_F(
-+    DownloadContentTest,
-+    SiteForCookies_DownloadUrl_NotUpdateFirstPartyUrlOnRedirect) {
-+  net::EmbeddedTestServer site_a;
-+  net::EmbeddedTestServer site_b;
-+
-+  base::StringPairs cookie_headers;
-+  cookie_headers.push_back(std::make_pair(
-+      std::string("Set-Cookie"), std::string("A=strict; SameSite=Strict")));
-+  cookie_headers.push_back(std::make_pair(std::string("Set-Cookie"),
-+                                          std::string("B=lax; SameSite=Lax")));
-+
-+  // This will request a URL on b.test, which redirects to a url that sets the
-+  // cookies on a.test.
-+  site_a.RegisterRequestHandler(CreateBasicResponseHandler(
-+      "/sets-samesite-cookies", net::HTTP_OK, cookie_headers,
-+      "application/octet-stream", "abcd"));
-+  ASSERT_TRUE(site_a.Start());
-+  site_b.RegisterRequestHandler(
-+      CreateRedirectHandler("/redirected-download",
-+                            site_a.GetURL("a.test", "/sets-samesite-cookies")));
-+  ASSERT_TRUE(site_b.Start());
-+
-+  // Download the file.
-+  SetupEnsureNoPendingDownloads();
-+  std::unique_ptr<download::DownloadUrlParameters> download_parameters(
-+      DownloadRequestUtils::CreateDownloadForWebContentsMainFrame(
-+          shell()->web_contents(),
-+          site_b.GetURL("b.test", "/redirected-download"),
-+          TRAFFIC_ANNOTATION_FOR_TESTS));
-+  download_parameters->set_update_first_party_url_on_redirect(false);
-+  std::unique_ptr<DownloadTestObserver> observer(CreateWaiter(shell(), 1));
-+  DownloadManagerForShell(shell())->DownloadUrl(std::move(download_parameters));
-+  observer->WaitForFinished();
-+
-+  // Get the important info from other threads and check it.
-+  EXPECT_TRUE(EnsureNoPendingDownloads());
-+
-+  std::vector<download::DownloadItem*> downloads;
-+  DownloadManagerForShell(shell())->GetAllDownloads(&downloads);
-+  ASSERT_EQ(1u, downloads.size());
-+  ASSERT_EQ(download::DownloadItem::COMPLETE, downloads[0]->GetState());
-+
-+  // Check that the cookies were not set on a.test.
-+  EXPECT_EQ("",
-+            content::GetCookies(shell()->web_contents()->GetBrowserContext(),
-+                                site_a.GetURL("a.test", "/")));
-+}
-+
- // Verifies that isolation info set in DownloadUrlParameters can be populated.
- IN_PROC_BROWSER_TEST_F(DownloadContentTest,
-                        SiteForCookies_DownloadUrl_IsolationInfoPopulated) {

patches/chromium/cherry-pick-c643d18a078d.patch

@@ -1,25 +0,0 @@
-From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
-From: Rayan Kanso <rayankans@google.com>
-Date: Tue, 7 Jun 2022 13:13:36 +0000
-Subject: Don't expose URL chain in case of CO redirect
-
-Bug: 1278255
-Change-Id: If853327b853e29792e5c8d1dfaeecf21d6fec004
-Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3693143
-Reviewed-by: Susanne Westphal <swestphal@google.com>
-Commit-Queue: Rayan Kanso <rayankans@chromium.org>
-Cr-Commit-Position: refs/heads/main@{#1011409}
-
-diff --git a/content/browser/background_fetch/storage/mark_request_complete_task.cc b/content/browser/background_fetch/storage/mark_request_complete_task.cc
-index 32a818ba8723f020fa536eb93a31c16b76ed92a1..d729dfc5d505c4c23872ef535a8b09f1af065914 100644
---- a/content/browser/background_fetch/storage/mark_request_complete_task.cc
-+++ b/content/browser/background_fetch/storage/mark_request_complete_task.cc
-@@ -104,6 +104,8 @@ void MarkRequestCompleteTask::StoreResponse(base::OnceClosure done_closure) {
-   BackgroundFetchCrossOriginFilter filter(
-       registration_id_.storage_key().origin(), *request_info_);
-   if (!filter.CanPopulateBody()) {
-+    // Don't expose the initial URL in case of cross-origin redirects.
-+    response_->url_list.resize(1);
-     failure_reason_ = proto::BackgroundFetchRegistration::FETCH_ERROR;
-     // No point writing the response to the cache since it won't be exposed.
-     CreateAndStoreCompletedRequest(std::move(done_closure));

patches/chromium/chore_add_electron_deps_to_gitignores.patch

@@ -1,47 +0,0 @@
-From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
-From: Samuel Attard <sattard@salesforce.com>
-Date: Tue, 26 Jul 2022 00:05:29 -0700
-Subject: chore: add electron deps to gitignores
-
-Makes things like "git status" quicker when developing electron locally
-
-diff --git a/.gitignore b/.gitignore
-index cc0150c39bf635fa09d3efe9bfea2997b0b8263a..cdca4c4a9cccb7de0b13c8b803d6c74ba4d63d3a 100644
---- a/.gitignore
-+++ b/.gitignore
-@@ -224,6 +224,7 @@ vs-chromium-project.txt
- /delegate_execute
- /device/serial/device_serial_mojo.xml
- /docs/website
-+/electron
- /google_apis/gcm/gcm.xml
- /google_apis/internal
- /googleurl
-diff --git a/third_party/.gitignore b/third_party/.gitignore
-index 567e1de3c31b2275e07b897c2644c91aef9ca076..a6744fa9d31781c6ee866ba6291588caf44e8559 100644
---- a/third_party/.gitignore
-+++ b/third_party/.gitignore
-@@ -83,6 +83,7 @@
- /directxsdk
- /dom_distiller_js/dist
- /eigen3/src
-+/electron_node
- /elfutils/src
- /emoji-segmenter/src
- /emoji-metadata/src
-@@ -177,6 +178,7 @@
- /mocha
- /mockito/src
- /nacl_sdk_binaries/
-+/nan
- /nasm
- /nearby/src
- /neon_2_sse/src
-@@ -239,6 +241,7 @@
- /speex
- /sqlite/src
- /sqlite4java/lib/
-+/squirrel.mac
- /subresource-filter-ruleset/data/UnindexedRules
- /swift-format
- /swiftshader/

patches/chromium/chore_allow_chromium_to_handle_synthetic_mouse_events_for_touch.patch

@@ -1,76 +0,0 @@
-From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
-From: deepak1556 <hop2deep@gmail.com>
-Date: Fri, 29 Jul 2022 00:29:35 +0900
-Subject: chore: allow chromium to handle synthetic mouse events for touch
-
-With WCO, allow chromium to handle synthetic mouse events generated for touch
-actions in the non-client caption area.
-
-diff --git a/ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc b/ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc
-index 9fd052c00a484cd1acd2031fda79e6307fd01b60..016dfe880a48168154c08839afa540880c2d52be 100644
---- a/ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc
-+++ b/ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc
-@@ -1169,6 +1169,10 @@ void DesktopWindowTreeHostWin::HandleWindowScaleFactorChanged(
-   }
- }
- 
-+bool DesktopWindowTreeHostWin::HandleMouseEventForCaption(UINT message) const {
-+  return false;
-+}
-+
- DesktopNativeCursorManager*
- DesktopWindowTreeHostWin::GetSingletonDesktopNativeCursorManager() {
-   return new DesktopNativeCursorManagerWin();
-diff --git a/ui/views/widget/desktop_aura/desktop_window_tree_host_win.h b/ui/views/widget/desktop_aura/desktop_window_tree_host_win.h
-index 444581249014a8ce301591f269dbb194f0520732..9377f26b081b717db6b50c13ce3795907cf2fcd2 100644
---- a/ui/views/widget/desktop_aura/desktop_window_tree_host_win.h
-+++ b/ui/views/widget/desktop_aura/desktop_window_tree_host_win.h
-@@ -262,6 +262,7 @@ class VIEWS_EXPORT DesktopWindowTreeHostWin
-   void HandleWindowSizeChanging() override;
-   void HandleWindowSizeUnchanged() override;
-   void HandleWindowScaleFactorChanged(float window_scale_factor) override;
-+  bool HandleMouseEventForCaption(UINT message) const override;
- 
-   Widget* GetWidget();
-   const Widget* GetWidget() const;
-diff --git a/ui/views/win/hwnd_message_handler.cc b/ui/views/win/hwnd_message_handler.cc
-index 01ff95be00b3911749f66a136b2b5a6c02156bd3..23e8794c0551c377269ebecd6684206fc7087553 100644
---- a/ui/views/win/hwnd_message_handler.cc
-+++ b/ui/views/win/hwnd_message_handler.cc
-@@ -3064,15 +3064,19 @@ LRESULT HWNDMessageHandler::HandleMouseEventInternal(UINT message,
-       SetMsgHandled(FALSE);
-     // We must let Windows handle the caption buttons if it's drawing them, or
-     // they won't work.
-+    bool simulate_mouse_event_for_caption = false;
-     if (delegate_->GetFrameMode() == FrameMode::SYSTEM_DRAWN &&
-         (hittest == HTCLOSE || hittest == HTMINBUTTON ||
-          hittest == HTMAXBUTTON)) {
--      SetMsgHandled(FALSE);
-+      simulate_mouse_event_for_caption =
-+          delegate_->HandleMouseEventForCaption(message);
-+      if (!simulate_mouse_event_for_caption)
-+        SetMsgHandled(FALSE);
-     }
-     // Let resize events fall through. Ignore everything else, as we're either
-     // letting Windows handle it above or we've already handled the equivalent
-     // touch message.
--    if (!IsHitTestOnResizeHandle(hittest))
-+    if (!IsHitTestOnResizeHandle(hittest) && !simulate_mouse_event_for_caption)
-       return 0;
-   }
- 
-diff --git a/ui/views/win/hwnd_message_handler_delegate.h b/ui/views/win/hwnd_message_handler_delegate.h
-index 5dbb192d0840ca0ded61397c399b774a8cb05cce..098a9c3140e9e140fdc8f0dc9cf4e8ec84451221 100644
---- a/ui/views/win/hwnd_message_handler_delegate.h
-+++ b/ui/views/win/hwnd_message_handler_delegate.h
-@@ -258,6 +258,10 @@ class VIEWS_EXPORT HWNDMessageHandlerDelegate {
-   // Called when the window scale factor has changed.
-   virtual void HandleWindowScaleFactorChanged(float window_scale_factor) = 0;
- 
-+  // Called when synthetic mouse event is generated for touch event on
-+  // caption buttons.
-+  virtual bool HandleMouseEventForCaption(UINT message) const = 0;
-+
-  protected:
-   virtual ~HWNDMessageHandlerDelegate() = default;
- };

patches/chromium/chore_provide_iswebcontentscreationoverridden_with_full_params.patch

@@ -108,7 +108,7 @@ index 6688ba8ba2fb7d930773144cdbc43f1f6fa2b685..22015c7b9b50e1264551ce226757f90e
    }
  
 diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
-index 7548e63c57dc8463cb59614122e32c574ae17437..a9e1c335e3fae4fa795059c9b28bd5d404184c2e 100644
+index 70ee9049e3cb73f55bed81c3e08037df2f4c9e07..8d230826aaf867d9046a6b9ac93a60f4750e52be 100644
 --- a/chrome/browser/ui/browser.cc
 +++ b/chrome/browser/ui/browser.cc
 @@ -1786,12 +1786,11 @@ bool Browser::IsWebContentsCreationOverridden(
@@ -246,10 +246,10 @@ index c6bd5c19f8a7ceec17c9e32af5296a9617f3a619..02199b439fba7fdc617b7f7980d958b7
    void AddNewContents(content::WebContents* source,
                        std::unique_ptr<content::WebContents> new_contents,
 diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
-index add5ba98f4409460b93aa2f8c49eb49a1f59470a..4b77c71375a7375e168c9bee93a73c3af6fe1252 100644
+index b9309e1cbc4a8b701534aa8be2827c40d98d6678..c1b1bfc8333e93456178842db392eabff96bf4c9 100644
 --- a/content/browser/web_contents/web_contents_impl.cc
 +++ b/content/browser/web_contents/web_contents_impl.cc
-@@ -3895,8 +3895,7 @@ FrameTree* WebContentsImpl::CreateNewWindow(
+@@ -3891,8 +3891,7 @@ FrameTree* WebContentsImpl::CreateNewWindow(
  
    if (delegate_ && delegate_->IsWebContentsCreationOverridden(
                         source_site_instance, params.window_container_type,
@@ -260,7 +260,7 @@ index add5ba98f4409460b93aa2f8c49eb49a1f59470a..4b77c71375a7375e168c9bee93a73c3a
          static_cast<WebContentsImpl*>(delegate_->CreateCustomWebContents(
              opener, source_site_instance, is_new_browsing_instance,
 diff --git a/content/public/browser/web_contents_delegate.cc b/content/public/browser/web_contents_delegate.cc
-index c01e06b08b1cca7a663e30476a551904ce9c6db8..9f50a8721560f734270308776f2f37ad49a8cb91 100644
+index 7bb1680553c405a9016cfd67eca5fa3c6439b692..3aa2cca04340098859e1072eaa80a46a8e0463b1 100644
 --- a/content/public/browser/web_contents_delegate.cc
 +++ b/content/public/browser/web_contents_delegate.cc
 @@ -134,8 +134,7 @@ bool WebContentsDelegate::IsWebContentsCreationOverridden(
@@ -274,7 +274,7 @@ index c01e06b08b1cca7a663e30476a551904ce9c6db8..9f50a8721560f734270308776f2f37ad
  }
  
 diff --git a/content/public/browser/web_contents_delegate.h b/content/public/browser/web_contents_delegate.h
-index 2556c044b6e28501a5fac9b0040e623b8f35f497..4c6cd654551b2f5cfd59a5271a8d95a9e6862d3c 100644
+index eeafde1fa6067804665954525eafdd482d8eb3f3..b17f371aa489a5b61c28fbcd316b19815f072df9 100644
 --- a/content/public/browser/web_contents_delegate.h
 +++ b/content/public/browser/web_contents_delegate.h
 @@ -317,8 +317,7 @@ class CONTENT_EXPORT WebContentsDelegate {

patches/chromium/chore_use_electron_resources_not_chrome_for_spellchecker.patch

@@ -1,58 +0,0 @@
-From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
-From: Samuel Attard <sattard@slack-corp.com>
-Date: Wed, 23 Oct 2019 14:17:18 -0700
-Subject: chore: use electron resources not chrome for spellchecker
-
-spellchecker uses a few IDS_ resources.  We need to load these from
-Electrons grit header instead of Chromes
-
-diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn
-index af2fd82cbc458b396107a161d9c3dd31077e57a7..948d05358b89895faa97a7d383bfac66a45464a8 100644
---- a/chrome/browser/BUILD.gn
-+++ b/chrome/browser/BUILD.gn
-@@ -7182,6 +7182,7 @@ static_library("browser") {
-     deps += [
-       "//components/spellcheck/browser",
-       "//components/spellcheck/common",
-+      "//electron:resources",
-     ]
- 
-     if (!is_android) {
-diff --git a/chrome/browser/spellchecker/spellcheck_factory.cc b/chrome/browser/spellchecker/spellcheck_factory.cc
-index 7c3b6a69acb16186add5d467dbc22360d90d46d4..703e2ce60f4f35f9c71e8b503ffd62f9ea8f365a 100644
---- a/chrome/browser/spellchecker/spellcheck_factory.cc
-+++ b/chrome/browser/spellchecker/spellcheck_factory.cc
-@@ -7,7 +7,7 @@
- #include "build/build_config.h"
- #include "chrome/browser/profiles/incognito_helpers.h"
- #include "chrome/browser/spellchecker/spellcheck_service.h"
--#include "chrome/grit/locale_settings.h"
-+#include "electron/grit/electron_resources.h"
- #include "components/keyed_service/content/browser_context_dependency_manager.h"
- #include "components/pref_registry/pref_registry_syncable.h"
- #include "components/prefs/pref_service.h"
-diff --git a/components/language/core/browser/BUILD.gn b/components/language/core/browser/BUILD.gn
-index fdba4ca90882656d6ba369dae48d5dfc13991cb8..fb3b759362275aafd4ed01a7865a4dd0dfaad727 100644
---- a/components/language/core/browser/BUILD.gn
-+++ b/components/language/core/browser/BUILD.gn
-@@ -30,6 +30,7 @@ static_library("browser") {
-     "//components/pref_registry",
-     "//components/prefs",
-     "//components/strings",
-+    "//electron:resources",
-     "//ui/base",
-   ]
- }
-diff --git a/components/language/core/browser/language_prefs.cc b/components/language/core/browser/language_prefs.cc
-index 26f86d67c32b2a022698ae5ea5509912d2ccfacb..d48844d49308d67ee7bfa823335c7443173badbe 100644
---- a/components/language/core/browser/language_prefs.cc
-+++ b/components/language/core/browser/language_prefs.cc
-@@ -22,7 +22,7 @@
- #include "components/pref_registry/pref_registry_syncable.h"
- #include "components/prefs/pref_service.h"
- #include "components/prefs/scoped_user_pref_update.h"
--#include "components/strings/grit/components_locale_settings.h"
-+#include "electron/grit/electron_resources.h"
- #include "ui/base/l10n/l10n_util.h"
- 
- namespace language {

patches/chromium/custom_protocols_plzserviceworker.patch

@@ -1,53 +0,0 @@
-From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
-From: deepak1556 <hop2deep@gmail.com>
-Date: Fri, 20 May 2022 00:29:34 +0900
-Subject: custom_protocols_plzserviceworker.patch
-
-Allow registering custom protocols to handle service worker main script fetching with PlzServiceWorker.
-
-Refs https://bugs.chromium.org/p/chromium/issues/detail?id=996511
-
-diff --git a/content/browser/service_worker/service_worker_context_wrapper.cc b/content/browser/service_worker/service_worker_context_wrapper.cc
-index f827745b9800d4f11a17e405b0eb22601d7e4dd4..0cecbfb2a6fd3daa71338c94bda4b1f45eb51d5e 100644
---- a/content/browser/service_worker/service_worker_context_wrapper.cc
-+++ b/content/browser/service_worker/service_worker_context_wrapper.cc
-@@ -1591,6 +1591,28 @@ ServiceWorkerContextWrapper::GetLoaderFactoryForBrowserInitiatedRequest(
-       loader_factory_bundle_info =
-           context()->loader_factory_bundle_for_update_check()->Clone();
- 
-+  // Give the embedder a chance to register custom schemes that can
-+  // handle loading the service worker main script.
-+  // Previous registration triggered by
-+  // ServiceWorkerContextWrapper::CreateNonNetworkPendingURLLoaderFactoryBundleForUpdateCheck
-+  // happens early on browser startup before the JS in the main process
-+  // is run by the embedder.
-+  auto* factory_bundle = static_cast<blink::PendingURLLoaderFactoryBundle*>(
-+          loader_factory_bundle_info.get());
-+  ContentBrowserClient::NonNetworkURLLoaderFactoryMap non_network_factories;
-+  GetContentClient()
-+      ->browser()
-+      ->RegisterNonNetworkServiceWorkerUpdateURLLoaderFactories(
-+          storage_partition_->browser_context(), &non_network_factories);
-+  for (auto& pair : non_network_factories) {
-+    const std::string& scheme = pair.first;
-+    mojo::PendingRemote<network::mojom::URLLoaderFactory>& factory_remote =
-+        pair.second;
-+
-+    factory_bundle->pending_scheme_specific_factories().emplace(
-+        scheme, std::move(factory_remote));
-+  }
-+
-   if (base::FeatureList::IsEnabled(
-           features::kEnableServiceWorkersForChromeUntrusted) &&
-       scope.scheme_piece() == kChromeUIUntrustedScheme) {
-@@ -1611,9 +1633,7 @@ ServiceWorkerContextWrapper::GetLoaderFactoryForBrowserInitiatedRequest(
-             browser_context(), scope_origin)) {
-       config->RegisterURLDataSource(browser_context());
- 
--      static_cast<blink::PendingURLLoaderFactoryBundle*>(
--          loader_factory_bundle_info.get())
--          ->pending_scheme_specific_factories()
-+      factory_bundle->pending_scheme_specific_factories()
-           .emplace(kChromeUIUntrustedScheme,
-                    CreateWebUIServiceWorkerLoaderFactory(
-                        browser_context(), kChromeUIUntrustedScheme,

patches/chromium/desktop_media_list.patch

@@ -82,18 +82,9 @@ index 1e4a652634fbde2ca9a256baca840bbc5a0e001f..546f5bc3a2f79035f0eec196d9e704b8
    const Source& GetSource(int index) const override;
    DesktopMediaList::Type GetMediaListType() const override;
 diff --git a/chrome/browser/media/webrtc/native_desktop_media_list.cc b/chrome/browser/media/webrtc/native_desktop_media_list.cc
-index 6d8c9d940bb4488ffedc1eb8c543c065bb3953c9..2026b926eee56f6b235963b23ab86b2743eaed90 100644
+index 6d8c9d940bb4488ffedc1eb8c543c065bb3953c9..d5092cb0245a4b8dc26073741f0bc6657b943bdd 100644
 --- a/chrome/browser/media/webrtc/native_desktop_media_list.cc
 +++ b/chrome/browser/media/webrtc/native_desktop_media_list.cc
-@@ -18,7 +18,7 @@
- #include "build/build_config.h"
- #include "build/chromeos_buildflags.h"
- #include "chrome/browser/media/webrtc/desktop_media_list.h"
--#include "chrome/grit/generated_resources.h"
-+#include "electron/grit/electron_resources.h"
- #include "content/public/browser/browser_task_traits.h"
- #include "content/public/browser/browser_thread.h"
- #include "content/public/common/content_features.h"
 @@ -127,8 +127,9 @@ BOOL CALLBACK AllHwndCollector(HWND hwnd, LPARAM param) {
  #endif  // BUILDFLAG(IS_WIN)
  

patches/chromium/disable_color_correct_rendering.patch

@@ -20,15 +20,14 @@ to deal with color spaces. That is being tracked at
 https://crbug.com/634542 and https://crbug.com/711107.
 
 diff --git a/cc/trees/layer_tree_host_impl.cc b/cc/trees/layer_tree_host_impl.cc
-index 14e13169de8b5e808e3284792237bef9939b1e00..67839f87fb0dcb2eed9bc001806020befbed5f66 100644
+index 14e13169de8b5e808e3284792237bef9939b1e00..7628a96dc8b2c9e8128cd462138d3487304c6e10 100644
 --- a/cc/trees/layer_tree_host_impl.cc
 +++ b/cc/trees/layer_tree_host_impl.cc
-@@ -1894,6 +1894,10 @@ void LayerTreeHostImpl::SetIsLikelyToRequireADraw(
+@@ -1894,6 +1894,9 @@ void LayerTreeHostImpl::SetIsLikelyToRequireADraw(
  TargetColorParams LayerTreeHostImpl::GetTargetColorParams(
      gfx::ContentColorUsage content_color_usage) const {
    TargetColorParams params;
 +  if (!settings_.enable_color_correct_rendering) {
-+    params.color_space = gfx::ColorSpace();
 +    return params;
 +  }
  
@@ -241,10 +240,10 @@ index 8cd9a960ca1de81857af60daa91596c1dbb17786..7455afe4d81eac31fe3792a4459834a7
      sandbox::policy::switches::kGpuSandboxAllowSysVShm,
      sandbox::policy::switches::kGpuSandboxFailuresFatal,
 diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc
-index 09f72f1fbd7b782c5bf52245482b358103f0c243..80d9fd40efed1edc90e7bdf1db534acb876206ca 100644
+index 927e182bbba7a3700fd20c8c964da7cc162c4210..f099940c5b8fd92c04401cfbd231c04cb413d286 100644
 --- a/content/browser/renderer_host/render_process_host_impl.cc
 +++ b/content/browser/renderer_host/render_process_host_impl.cc
-@@ -198,6 +198,7 @@
+@@ -197,6 +197,7 @@
  #include "ui/accessibility/accessibility_switches.h"
  #include "ui/base/ui_base_switches.h"
  #include "ui/display/display_switches.h"
@@ -252,7 +251,7 @@ index 09f72f1fbd7b782c5bf52245482b358103f0c243..80d9fd40efed1edc90e7bdf1db534acb
  #include "ui/gl/gl_switches.h"
  #include "url/gurl.h"
  #include "url/origin.h"
-@@ -3219,6 +3220,7 @@ void RenderProcessHostImpl::PropagateBrowserCommandLineToRenderer(
+@@ -3213,6 +3214,7 @@ void RenderProcessHostImpl::PropagateBrowserCommandLineToRenderer(
    // Propagate the following switches to the renderer command line (along
    // with any associated values) if present in the browser command line.
    static const char* const kSwitchNames[] = {
@@ -260,21 +259,8 @@ index 09f72f1fbd7b782c5bf52245482b358103f0c243..80d9fd40efed1edc90e7bdf1db534acb
      switches::kDisableInProcessStackTraces,
      sandbox::policy::switches::kDisableSeccompFilterSandbox,
      sandbox::policy::switches::kNoSandbox,
-diff --git a/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc b/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc
-index 396b2983f403b0684f952a5fbd2d0abf947328f0..35c44065ba8980c06bb35e64aa33cc5b3f290953 100644
---- a/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc
-+++ b/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc
-@@ -6194,7 +6194,7 @@ void WebGLRenderingContextBase::TexImageHelperImageBitmap(
-                                      : SkColorSpace::MakeSRGB();
-   const bool needs_color_conversion =
-       !SkColorSpace::Equals(unpack_color_space.get(), image_color_space.get());
--  if (needs_color_conversion) {
-+  if (needs_color_conversion && unpack_color_space) {
-     image = image->ConvertToColorSpace(unpack_color_space,
-                                        image->GetSkColorInfo().colorType());
-     if (!image) {
 diff --git a/third_party/blink/renderer/platform/graphics/canvas_color_params.cc b/third_party/blink/renderer/platform/graphics/canvas_color_params.cc
-index 648f25d99884b99f49e26cd9f280a8a6ae63e1c7..e42f8ba89070477b06777c7a0c37d30c8c5e4ed1 100644
+index 648f25d99884b99f49e26cd9f280a8a6ae63e1c7..0f87961ecd8c24e3ba82c6bae187a12c9b112bd4 100644
 --- a/third_party/blink/renderer/platform/graphics/canvas_color_params.cc
 +++ b/third_party/blink/renderer/platform/graphics/canvas_color_params.cc
 @@ -4,6 +4,7 @@
@@ -293,18 +279,7 @@ index 648f25d99884b99f49e26cd9f280a8a6ae63e1c7..e42f8ba89070477b06777c7a0c37d30c
  
  namespace blink {
  
-@@ -19,6 +21,10 @@ namespace blink {
- // Level 4 specification.
- gfx::ColorSpace PredefinedColorSpaceToGfxColorSpace(
-     PredefinedColorSpace color_space) {
-+  auto* cmd_line = base::CommandLine::ForCurrentProcess();
-+  if (cmd_line->HasSwitch(switches::kDisableColorCorrectRendering)) {
-+    return gfx::ColorSpace();
-+  }
-   switch (color_space) {
-     case PredefinedColorSpace::kSRGB:
-       return gfx::ColorSpace::CreateSRGB();
-@@ -118,6 +124,11 @@ uint8_t CanvasColorParams::BytesPerPixel() const {
+@@ -118,6 +120,11 @@ uint8_t CanvasColorParams::BytesPerPixel() const {
  }
  
  gfx::ColorSpace CanvasColorParams::GetStorageGfxColorSpace() const {

patches/chromium/disable_gpu_acceleration_on_vmware_on_linux.patch

@@ -1,40 +0,0 @@
-From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
-From: Zhenyao Mo <zmo@chromium.org>
-Date: Mon, 23 May 2022 21:43:16 +0000
-Subject: Disable GPU acceleration on VMware on Linux
-
-TEST=manual
-R=sunnyps@chromium.org
-
-Bug: 1327939
-Change-Id: Ib09b6623665ffecf0af1f9f8bc3ebef1ac042b2f
-Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3661941
-Auto-Submit: Zhenyao Mo <zmo@chromium.org>
-Commit-Queue: Zhenyao Mo <zmo@chromium.org>
-Commit-Queue: Maggie Chen <magchen@chromium.org>
-Reviewed-by: Maggie Chen <magchen@chromium.org>
-Cr-Commit-Position: refs/heads/main@{#1006613}
-
-diff --git a/gpu/config/software_rendering_list.json b/gpu/config/software_rendering_list.json
-index 8ed8faf0a0733568a81d955a5546d864d24f78b5..73b6e998f753cee5d77e6bd5983ed46702f13580 100644
---- a/gpu/config/software_rendering_list.json
-+++ b/gpu/config/software_rendering_list.json
-@@ -1699,6 +1699,18 @@
-       "features": [
-         "accelerated_video_encode"
-       ]
-+    },
-+    {
-+      "id": 176,
-+      "description": "VMware is buggy on Linux",
-+      "cr_bugs": [1327939],
-+      "os": {
-+        "type": "linux"
-+      },
-+      "vendor_id": "0x15ad",
-+      "features": [
-+        "all"
-+      ]
-     }
-   ]
- }

patches/chromium/disable_unload_metrics.patch

@@ -24,10 +24,10 @@ This patch temporarily disables the metrics so we can have green CI, and we
 should continue seeking for a real fix.
 
 diff --git a/content/browser/renderer_host/navigator.cc b/content/browser/renderer_host/navigator.cc
-index c289c888bc9d74d3f696714650b65aa373be27b4..aad7ec5ed0b6f6ab5cdfe0d7902d952c7c9e36c6 100644
+index cd286b4925b3d2d9e74caecee759360488f2b8ba..0bc714a78e58719824ffeba8ced7854474fa6e92 100644
 --- a/content/browser/renderer_host/navigator.cc
 +++ b/content/browser/renderer_host/navigator.cc
-@@ -1286,6 +1286,7 @@ void Navigator::RecordNavigationMetrics(
+@@ -1177,6 +1177,7 @@ void Navigator::RecordNavigationMetrics(
              .InMilliseconds());
    }
  
@@ -35,7 +35,7 @@ index c289c888bc9d74d3f696714650b65aa373be27b4..aad7ec5ed0b6f6ab5cdfe0d7902d952c
    // If this is a same-process navigation and we have timestamps for unload
    // durations, fill those metrics out as well.
    if (params.unload_start && params.unload_end &&
-@@ -1332,6 +1333,7 @@ void Navigator::RecordNavigationMetrics(
+@@ -1223,6 +1224,7 @@ void Navigator::RecordNavigationMetrics(
           first_before_unload_start_time)
              .InMilliseconds());
    }

patches/chromium/don_t_use_potentially_null_getwebframe_-_view_when_get_blink.patch

@@ -11,10 +11,10 @@ This regressed in https://chromium-review.googlesource.com/c/chromium/src/+/2572
 Upstream: https://chromium-review.googlesource.com/c/chromium/src/+/2598393
 
 diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
-index 95966ce7f0eeb0a7f2822bef69b540ac6bfe298d..34c2bdc5d4dda2fb0bdf2a8c3e5f8f9a5e11b977 100644
+index b9eea3470139e1833b2b23d3b535b11235e2bc8e..fbc1f6d8387e33cb7daafc96b7514897f067f008 100644
 --- a/content/renderer/render_frame_impl.cc
 +++ b/content/renderer/render_frame_impl.cc
-@@ -2398,7 +2398,7 @@ const blink::WebView* RenderFrameImpl::GetWebView() const {
+@@ -2377,7 +2377,7 @@ const blink::WebView* RenderFrameImpl::GetWebView() const {
  }
  
  const blink::web_pref::WebPreferences& RenderFrameImpl::GetBlinkPreferences() {

patches/chromium/expose_setuseragent_on_networkcontext.patch

@@ -33,10 +33,10 @@ index 14c71cc69388da46f62d9835e2a06fef0870da02..9481ea08401ae29ae9c1d960491b05b3
  
  }  // namespace net
 diff --git a/services/network/network_context.cc b/services/network/network_context.cc
-index f06a04983571623b542dba11933c4c95c3dcf398..606573a33573884baa173b796e1870b8defcda2a 100644
+index 98268925da14d61256f8dee3aa899f17ce7acaf6..1abdc204e278383818dc073f96c90e91ec1f3fb9 100644
 --- a/services/network/network_context.cc
 +++ b/services/network/network_context.cc
-@@ -1407,6 +1407,13 @@ void NetworkContext::SetNetworkConditions(
+@@ -1404,6 +1404,13 @@ void NetworkContext::SetNetworkConditions(
                                        std::move(network_conditions));
  }
  
@@ -51,7 +51,7 @@ index f06a04983571623b542dba11933c4c95c3dcf398..606573a33573884baa173b796e1870b8
    // This may only be called on NetworkContexts created with the constructor
    // that calls MakeURLRequestContext().
 diff --git a/services/network/network_context.h b/services/network/network_context.h
-index 2cd8707b120deb41683e13def5d446fd3bf93afe..c654d54cbb1427e700d918a94390c022b5b1cb14 100644
+index 58671094857cdfe5d853c8a284d51bc1b8a09660..7af71839aa1bc970370a91cd35f3cbefe06e67e5 100644
 --- a/services/network/network_context.h
 +++ b/services/network/network_context.h
 @@ -302,6 +302,7 @@ class COMPONENT_EXPORT(NETWORK_SERVICE) NetworkContext

patches/chromium/extend_apply_webpreferences.patch

@@ -12,10 +12,10 @@ Ideally we could add an embedder observer pattern here but that can be
 done in future work.
 
 diff --git a/third_party/blink/renderer/core/exported/web_view_impl.cc b/third_party/blink/renderer/core/exported/web_view_impl.cc
-index f76a0ee0778d7b4e4df69a4c43b4a6bfdc89294d..45baa4d62cb4e5aebedebba993ddbc9f06711d35 100644
+index b2a2e38397fdf3e9bb52c4532a1d14463ed4110d..9f0f209f279cc3dbe35efc12eb1e51449dfda470 100644
 --- a/third_party/blink/renderer/core/exported/web_view_impl.cc
 +++ b/third_party/blink/renderer/core/exported/web_view_impl.cc
-@@ -159,6 +159,7 @@
+@@ -160,6 +160,7 @@
  #include "third_party/blink/renderer/core/timing/window_performance.h"
  #include "third_party/blink/renderer/platform/fonts/font_cache.h"
  #include "third_party/blink/renderer/platform/fonts/generic_font_family_settings.h"
@@ -23,7 +23,7 @@ index f76a0ee0778d7b4e4df69a4c43b4a6bfdc89294d..45baa4d62cb4e5aebedebba993ddbc9f
  #include "third_party/blink/renderer/platform/graphics/image.h"
  #include "third_party/blink/renderer/platform/graphics/paint/cull_rect.h"
  #include "third_party/blink/renderer/platform/graphics/paint/paint_record_builder.h"
-@@ -1776,6 +1777,7 @@ void WebView::ApplyWebPreferences(const web_pref::WebPreferences& prefs,
+@@ -1777,6 +1778,7 @@ void WebView::ApplyWebPreferences(const web_pref::WebPreferences& prefs,
  #if BUILDFLAG(IS_MAC)
    web_view_impl->SetMaximumLegibleScale(
        prefs.default_maximum_page_scale_factor);

patches/chromium/feat_add_data_parameter_to_processsingleton.patch

@@ -1,348 +0,0 @@
-From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
-From: Raymond Zhao <raymondzhao@microsoft.com>
-Date: Tue, 7 Sep 2021 14:54:25 -0700
-Subject: feat: Add data parameter to ProcessSingleton
-
-This patch adds an additional_data parameter to the constructor of
-ProcessSingleton, so that the second instance can send additional
-data over to the first instance while requesting the ProcessSingleton
-lock.
-
-On the Electron side, we then expose an extra parameter to the
-app.requestSingleInstanceLock API so that users can pass in a JSON
-object for the second instance to send to the first instance.
-
-diff --git a/chrome/browser/process_singleton.h b/chrome/browser/process_singleton.h
-index 5a64220aaf1309832dc0ad543e353de67fe0a779..e75c4f0d7cf1cac2e5862eb858800359e2001eb6 100644
---- a/chrome/browser/process_singleton.h
-+++ b/chrome/browser/process_singleton.h
-@@ -18,6 +18,7 @@
- #include "base/files/file_path.h"
- #include "base/memory/ref_counted.h"
- #include "base/process/process.h"
-+#include "base/containers/span.h"
- #include "ui/gfx/native_widget_types.h"
- 
- #if BUILDFLAG(IS_POSIX) && !BUILDFLAG(IS_ANDROID)
-@@ -99,22 +100,25 @@ class ProcessSingleton {
-   // handled within the current browser instance or false if the remote process
-   // should handle it (i.e., because the current process is shutting down).
-   using NotificationCallback =
--      base::RepeatingCallback<bool(const base::CommandLine& command_line,
--                                   const base::FilePath& current_directory)>;
-+       base::RepeatingCallback<bool(const base::CommandLine& command_line,
-+                                   const base::FilePath& current_directory,
-+                                   const std::vector<const uint8_t> additional_data)>;
- 
- #if BUILDFLAG(IS_WIN)
-   ProcessSingleton(const std::string& program_name,
-                    const base::FilePath& user_data_dir,
-+                   const base::span<const uint8_t> additional_data,
-                    bool is_sandboxed,
-                    const NotificationCallback& notification_callback);
- #else
-   ProcessSingleton(const base::FilePath& user_data_dir,
-+                   const base::span<const uint8_t> additional_data,
-                    const NotificationCallback& notification_callback);
-+#endif
- 
-   ProcessSingleton(const ProcessSingleton&) = delete;
-   ProcessSingleton& operator=(const ProcessSingleton&) = delete;
- 
--#endif
-   ~ProcessSingleton();
- 
-   // Notify another process, if available. Otherwise sets ourselves as the
-@@ -177,7 +181,10 @@ class ProcessSingleton {
- #endif
- 
-  private:
--  NotificationCallback notification_callback_;  // Handler for notifications.
-+  // A callback to run when the first instance receives data from the second.
-+  NotificationCallback notification_callback_;
-+  // Custom data to pass to the other instance during notify.
-+  base::span<const uint8_t> additional_data_;
- 
- #if BUILDFLAG(IS_WIN)
-   bool EscapeVirtualization(const base::FilePath& user_data_dir);
-diff --git a/chrome/browser/process_singleton_posix.cc b/chrome/browser/process_singleton_posix.cc
-index be2c417c07a4206fac4a9a6c03e516fd0493c942..9a1f7b80e9ec538977f9b492829646a62d2a67cd 100644
---- a/chrome/browser/process_singleton_posix.cc
-+++ b/chrome/browser/process_singleton_posix.cc
-@@ -612,6 +612,7 @@ class ProcessSingleton::LinuxWatcher
-   // |reader| is for sending back ACK message.
-   void HandleMessage(const std::string& current_dir,
-                      const std::vector<std::string>& argv,
-+                     const std::vector<const uint8_t> additional_data,
-                      SocketReader* reader);
- 
-  private:
-@@ -666,13 +667,16 @@ void ProcessSingleton::LinuxWatcher::StartListening(int socket) {
- }
- 
- void ProcessSingleton::LinuxWatcher::HandleMessage(
--    const std::string& current_dir, const std::vector<std::string>& argv,
-+    const std::string& current_dir,
-+    const std::vector<std::string>& argv,
-+    const std::vector<const uint8_t> additional_data,
-     SocketReader* reader) {
-   DCHECK(ui_task_runner_->BelongsToCurrentThread());
-   DCHECK(reader);
- 
-   if (parent_->notification_callback_.Run(base::CommandLine(argv),
--                                          base::FilePath(current_dir))) {
-+                                          base::FilePath(current_dir),
-+                                          std::move(additional_data))) {
-     // Send back "ACK" message to prevent the client process from starting up.
-     reader->FinishWithACK(kACKToken, std::size(kACKToken) - 1);
-   } else {
-@@ -720,7 +724,8 @@ void ProcessSingleton::LinuxWatcher::SocketReader::
-     }
-   }
- 
--  // Validate the message.  The shortest message is kStartToken\0x\0x
-+  // Validate the message.  The shortest message kStartToken\0\00
-+  // The shortest message with additional data is kStartToken\0\00\00\0.
-   const size_t kMinMessageLength = std::size(kStartToken) + 4;
-   if (bytes_read_ < kMinMessageLength) {
-     buf_[bytes_read_] = 0;
-@@ -750,10 +755,28 @@ void ProcessSingleton::LinuxWatcher::SocketReader::
-   tokens.erase(tokens.begin());
-   tokens.erase(tokens.begin());
- 
-+  size_t num_args;
-+  base::StringToSizeT(tokens[0], &num_args);
-+  std::vector<std::string> command_line(tokens.begin() + 1, tokens.begin() + 1 + num_args);
-+
-+  std::vector<const uint8_t> additional_data;
-+  if (tokens.size() >= 3 + num_args) {
-+    size_t additional_data_size;
-+    base::StringToSizeT(tokens[1 + num_args], &additional_data_size);
-+    std::string remaining_args = base::JoinString(
-+        base::make_span(tokens.begin() + 2 + num_args, tokens.end()),
-+        std::string(1, kTokenDelimiter));
-+    const uint8_t* additional_data_bits =
-+        reinterpret_cast<const uint8_t*>(remaining_args.c_str());
-+    additional_data = std::vector<const uint8_t>(
-+        additional_data_bits, additional_data_bits + additional_data_size);
-+  }
-+
-   // Return to the UI thread to handle opening a new browser tab.
-   ui_task_runner_->PostTask(
-       FROM_HERE, base::BindOnce(&ProcessSingleton::LinuxWatcher::HandleMessage,
--                                parent_, current_dir, tokens, this));
-+                                parent_, current_dir, command_line,
-+                                std::move(additional_data), this));
-   fd_watch_controller_.reset();
- 
-   // LinuxWatcher::HandleMessage() is in charge of destroying this SocketReader
-@@ -782,8 +805,10 @@ void ProcessSingleton::LinuxWatcher::SocketReader::FinishWithACK(
- //
- ProcessSingleton::ProcessSingleton(
-     const base::FilePath& user_data_dir,
-+    const base::span<const uint8_t> additional_data,
-     const NotificationCallback& notification_callback)
-     : notification_callback_(notification_callback),
-+      additional_data_(additional_data),
-       current_pid_(base::GetCurrentProcId()),
-       watcher_(new LinuxWatcher(this)) {
-   socket_path_ = user_data_dir.Append(chrome::kSingletonSocketFilename);
-@@ -902,7 +927,8 @@ ProcessSingleton::NotifyResult ProcessSingleton::NotifyOtherProcessWithTimeout(
-              sizeof(socket_timeout));
- 
-   // Found another process, prepare our command line
--  // format is "START\0<current dir>\0<argv[0]>\0...\0<argv[n]>".
-+  // format is "START\0<current-dir>\0<n-args>\0<argv[0]>\0...\0<argv[n]>
-+  // \0<additional-data-length>\0<additional-data>".
-   std::string to_send(kStartToken);
-   to_send.push_back(kTokenDelimiter);
- 
-@@ -912,11 +938,21 @@ ProcessSingleton::NotifyResult ProcessSingleton::NotifyOtherProcessWithTimeout(
-   to_send.append(current_dir.value());
- 
-   const std::vector<std::string>& argv = cmd_line.argv();
-+  to_send.push_back(kTokenDelimiter);
-+  to_send.append(base::NumberToString(argv.size()));
-   for (auto it = argv.begin(); it != argv.end(); ++it) {
-     to_send.push_back(kTokenDelimiter);
-     to_send.append(*it);
-   }
- 
-+  size_t data_to_send_size = additional_data_.size_bytes();
-+  if (data_to_send_size) {
-+    to_send.push_back(kTokenDelimiter);
-+    to_send.append(base::NumberToString(data_to_send_size));
-+    to_send.push_back(kTokenDelimiter);
-+    to_send.append(reinterpret_cast<const char*>(additional_data_.data()), data_to_send_size);
-+  }
-+
-   // Send the message
-   if (!WriteToSocket(socket.fd(), to_send.data(), to_send.length())) {
-     // Try to kill the other process, because it might have been dead.
-diff --git a/chrome/browser/process_singleton_win.cc b/chrome/browser/process_singleton_win.cc
-index ec725b44296266bea1a51aea889463a0bba8449c..beb2925f2fd7a1a93435bf4b1a40b5c71b49e449 100644
---- a/chrome/browser/process_singleton_win.cc
-+++ b/chrome/browser/process_singleton_win.cc
-@@ -80,10 +80,12 @@ BOOL CALLBACK BrowserWindowEnumeration(HWND window, LPARAM param) {
- 
- bool ParseCommandLine(const COPYDATASTRUCT* cds,
-                       base::CommandLine* parsed_command_line,
--                      base::FilePath* current_directory) {
-+                      base::FilePath* current_directory,
-+                      std::vector<const uint8_t>* parsed_additional_data) {
-   // We should have enough room for the shortest command (min_message_size)
-   // and also be a multiple of wchar_t bytes. The shortest command
--  // possible is L"START\0\0" (empty current directory and command line).
-+  // possible is L"START\0\0" (empty command line, current directory,
-+  // and additional data).
-   static const int min_message_size = 7;
-   if (cds->cbData < min_message_size * sizeof(wchar_t) ||
-       cds->cbData % sizeof(wchar_t) != 0) {
-@@ -133,6 +135,37 @@ bool ParseCommandLine(const COPYDATASTRUCT* cds,
-     const std::wstring cmd_line =
-         msg.substr(second_null + 1, third_null - second_null);
-     *parsed_command_line = base::CommandLine::FromString(cmd_line);
-+
-+    const std::wstring::size_type fourth_null =
-+        msg.find_first_of(L'\0', third_null + 1);
-+    if (fourth_null == std::wstring::npos ||
-+        fourth_null == msg.length()) {
-+      // No additional data was provided.
-+      return true;
-+    }
-+
-+    // Get length of the additional data.
-+    const std::wstring additional_data_length_string =
-+        msg.substr(third_null + 1, fourth_null - third_null);
-+    size_t additional_data_length;
-+    base::StringToSizeT(additional_data_length_string, &additional_data_length);
-+
-+    const std::wstring::size_type fifth_null =
-+        msg.find_first_of(L'\0', fourth_null + 1);
-+    if (fifth_null == std::wstring::npos ||
-+        fifth_null == msg.length()) {
-+      LOG(WARNING) << "Invalid format for start command, we need a string in 6 "
-+        "parts separated by NULLs";
-+    }
-+
-+    // Get the actual additional data.
-+    const std::wstring additional_data =
-+        msg.substr(fourth_null + 1, fifth_null - fourth_null);
-+    const uint8_t* additional_data_bytes =
-+        reinterpret_cast<const uint8_t*>(additional_data.c_str());
-+    *parsed_additional_data = std::vector<const uint8_t>(additional_data_bytes,
-+        additional_data_bytes + additional_data_length);
-+
-     return true;
-   }
-   return false;
-@@ -154,13 +187,14 @@ bool ProcessLaunchNotification(
- 
-   base::CommandLine parsed_command_line(base::CommandLine::NO_PROGRAM);
-   base::FilePath current_directory;
--  if (!ParseCommandLine(cds, &parsed_command_line, &current_directory)) {
-+  std::vector<const uint8_t> additional_data;
-+  if (!ParseCommandLine(cds, &parsed_command_line, &current_directory, &additional_data)) {
-     *result = TRUE;
-     return true;
-   }
- 
--  *result = notification_callback.Run(parsed_command_line, current_directory) ?
--      TRUE : FALSE;
-+  *result = notification_callback.Run(parsed_command_line,
-+      current_directory, std::move(additional_data)) ? TRUE : FALSE;
-   return true;
- }
- 
-@@ -261,9 +295,11 @@ bool ProcessSingleton::EscapeVirtualization(
- ProcessSingleton::ProcessSingleton(
-     const std::string& program_name,
-     const base::FilePath& user_data_dir,
-+    const base::span<const uint8_t> additional_data,
-     bool is_app_sandboxed,
-     const NotificationCallback& notification_callback)
-     : notification_callback_(notification_callback),
-+      additional_data_(additional_data),
-       program_name_(program_name),
-       is_app_sandboxed_(is_app_sandboxed),
-       is_virtualized_(false),
-@@ -290,7 +326,7 @@ ProcessSingleton::NotifyResult ProcessSingleton::NotifyOtherProcess() {
-     return PROCESS_NONE;
-   }
- 
--  switch (chrome::AttemptToNotifyRunningChrome(remote_window_)) {
-+  switch (chrome::AttemptToNotifyRunningChrome(remote_window_, additional_data_)) {
-     case chrome::NOTIFY_SUCCESS:
-       return PROCESS_NOTIFIED;
-     case chrome::NOTIFY_FAILED:
-diff --git a/chrome/browser/win/chrome_process_finder.cc b/chrome/browser/win/chrome_process_finder.cc
-index b64ed1d155a30582e48c9cdffcee9d0f25a53a6a..cfdb2d75532d270e3dd548eb7475a6cdbddf1016 100644
---- a/chrome/browser/win/chrome_process_finder.cc
-+++ b/chrome/browser/win/chrome_process_finder.cc
-@@ -36,7 +36,9 @@ HWND FindRunningChromeWindow(const base::FilePath& user_data_dir) {
-   return base::win::MessageWindow::FindWindow(user_data_dir.value());
- }
- 
--NotifyChromeResult AttemptToNotifyRunningChrome(HWND remote_window) {
-+NotifyChromeResult AttemptToNotifyRunningChrome(
-+    HWND remote_window,
-+    const base::span<const uint8_t> additional_data) {
-   TRACE_EVENT0("startup", "AttemptToNotifyRunningChrome");
- 
-   DCHECK(remote_window);
-@@ -50,7 +52,8 @@ NotifyChromeResult AttemptToNotifyRunningChrome(HWND remote_window) {
-   }
- 
-   // Send the command line to the remote chrome window.
--  // Format is "START\0<<<current directory>>>\0<<<commandline>>>".
-+  // Format is
-+  // "START\0<current-directory>\0<command-line>\0<additional-data-length>\0<additional-data>".
-   std::wstring to_send(L"START\0", 6);  // want the NULL in the string.
-   base::FilePath cur_dir;
-   if (!base::GetCurrentDirectory(&cur_dir)) {
-@@ -64,6 +67,22 @@ NotifyChromeResult AttemptToNotifyRunningChrome(HWND remote_window) {
-       base::CommandLine::ForCurrentProcess()->GetCommandLineString());
-   to_send.append(L"\0", 1);  // Null separator.
- 
-+  size_t additional_data_size = additional_data.size_bytes();
-+  if (additional_data_size) {
-+    // Send over the size, because the reinterpret cast to wchar_t could
-+    // add padding.
-+    to_send.append(base::UTF8ToWide(base::NumberToString(additional_data_size)));
-+    to_send.append(L"\0", 1);  // Null separator.
-+
-+    size_t padded_size = additional_data_size / sizeof(wchar_t);
-+    if (additional_data_size % sizeof(wchar_t) != 0) {
-+      padded_size++;
-+    }
-+    to_send.append(reinterpret_cast<const wchar_t*>(additional_data.data()),
-+                   padded_size);
-+    to_send.append(L"\0", 1);  // Null separator.
-+  }
-+
-   // Allow the current running browser window to make itself the foreground
-   // window (otherwise it will just flash in the taskbar).
-   ::AllowSetForegroundWindow(process_id);
-diff --git a/chrome/browser/win/chrome_process_finder.h b/chrome/browser/win/chrome_process_finder.h
-index 5516673cee019f6060077091e59498bf9038cd6e..8edea5079b46c2cba67833114eb9c21d85cfc22d 100644
---- a/chrome/browser/win/chrome_process_finder.h
-+++ b/chrome/browser/win/chrome_process_finder.h
-@@ -7,6 +7,7 @@
- 
- #include <windows.h>
- 
-+#include "base/containers/span.h"
- #include "base/time/time.h"
- 
- namespace base {
-@@ -27,7 +28,9 @@ HWND FindRunningChromeWindow(const base::FilePath& user_data_dir);
- // Attempts to send the current command line to an already running instance of
- // Chrome via a WM_COPYDATA message.
- // Returns true if a running Chrome is found and successfully notified.
--NotifyChromeResult AttemptToNotifyRunningChrome(HWND remote_window);
-+NotifyChromeResult AttemptToNotifyRunningChrome(
-+    HWND remote_window,
-+    const base::span<const uint8_t> additional_data);
- 
- // Changes the notification timeout to |new_timeout|, returns the old timeout.
- base::TimeDelta SetNotificationTimeoutForTesting(base::TimeDelta new_timeout);

patches/chromium/feat_add_data_transfer_to_requestsingleinstancelock.patch

@@ -0,0 +1,600 @@
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: Raymond Zhao <raymondzhao@microsoft.com>
+Date: Tue, 7 Sep 2021 14:54:25 -0700
+Subject: feat: Add data transfer mechanism to requestSingleInstanceLock flow
+
+This patch adds code that allows for the second instance to send
+additional data to the first instance, and for the first instance
+to send additional data back to the second instance, during the
+app.requestSingleInstanceLock call.
+
+Firstly, this patch adds an additional_data parameter
+to the constructor of ProcessSingleton, so that the second instance
+can send additional data over to the first instance
+while requesting the ProcessSingleton lock.
+
+Then, we add additional processing to the second-instance event, both
+so the first instance can receive additional data from the second
+instance, but also so the second instance can send back additional
+data to the first instance if needed.
+
+diff --git a/chrome/browser/process_singleton.h b/chrome/browser/process_singleton.h
+index 5a64220aaf1309832dc0ad543e353de67fe0a779..5b701b1361707b610ed60c344e441e67ca701362 100644
+--- a/chrome/browser/process_singleton.h
++++ b/chrome/browser/process_singleton.h
+@@ -18,6 +18,7 @@
+ #include "base/files/file_path.h"
+ #include "base/memory/ref_counted.h"
+ #include "base/process/process.h"
++#include "base/containers/span.h"
+ #include "ui/gfx/native_widget_types.h"
+ 
+ #if BUILDFLAG(IS_POSIX) && !BUILDFLAG(IS_ANDROID)
+@@ -93,6 +94,9 @@ class ProcessSingleton {
+ 
+   static constexpr int kNumNotifyResults = LAST_VALUE + 1;
+ 
++  using NotificationAckCallback =
++      base::RepeatingCallback<void(const base::span<const uint8_t>* ack_data)>;
++
+   // Implement this callback to handle notifications from other processes. The
+   // callback will receive the command line and directory with which the other
+   // Chrome process was launched. Return true if the command line will be
+@@ -100,21 +104,27 @@ class ProcessSingleton {
+   // should handle it (i.e., because the current process is shutting down).
+   using NotificationCallback =
+       base::RepeatingCallback<bool(const base::CommandLine& command_line,
+-                                   const base::FilePath& current_directory)>;
++                                   const base::FilePath& current_directory,
++                                   const std::vector<uint8_t> additional_data,
++                                   const NotificationAckCallback& ack_callback)>;
+ 
+ #if BUILDFLAG(IS_WIN)
+   ProcessSingleton(const std::string& program_name,
+                    const base::FilePath& user_data_dir,
++                   const base::span<const uint8_t> additional_data,
+                    bool is_sandboxed,
+-                   const NotificationCallback& notification_callback);
++                   const NotificationCallback& notification_callback,
++                   const NotificationAckCallback& ack_notification_callback);
+ #else
+   ProcessSingleton(const base::FilePath& user_data_dir,
+-                   const NotificationCallback& notification_callback);
++                   const base::span<const uint8_t> additional_data,
++                   const NotificationCallback& notification_callback,
++                   const NotificationAckCallback& ack_notification_callback);
++#endif
+ 
+   ProcessSingleton(const ProcessSingleton&) = delete;
+   ProcessSingleton& operator=(const ProcessSingleton&) = delete;
+ 
+-#endif
+   ~ProcessSingleton();
+ 
+   // Notify another process, if available. Otherwise sets ourselves as the
+@@ -177,7 +187,13 @@ class ProcessSingleton {
+ #endif
+ 
+  private:
+-  NotificationCallback notification_callback_;  // Handler for notifications.
++  // A callback to run when the first instance receives data from the second.
++  NotificationCallback notification_callback_;
++  // A callback to run when the second instance
++  // receives an acknowledgement from the first.
++  NotificationAckCallback notification_ack_callback_;
++  // Custom data to pass to the other instance during notify.
++  base::span<const uint8_t> additional_data_;
+ 
+ #if BUILDFLAG(IS_WIN)
+   bool EscapeVirtualization(const base::FilePath& user_data_dir);
+@@ -190,6 +206,7 @@ class ProcessSingleton {
+   HANDLE lock_file_;
+   base::FilePath user_data_dir_;
+   ShouldKillRemoteProcessCallback should_kill_remote_process_callback_;
++  HANDLE ack_pipe_;
+ #elif BUILDFLAG(IS_POSIX) && !BUILDFLAG(IS_ANDROID)
+   // Return true if the given pid is one of our child processes.
+   // Assumes that the current pid is the root of all pids of the current
+diff --git a/chrome/browser/process_singleton_posix.cc b/chrome/browser/process_singleton_posix.cc
+index be2c417c07a4206fac4a9a6c03e516fd0493c942..78f74b0b21242553b6af98628dc48190f7d1137d 100644
+--- a/chrome/browser/process_singleton_posix.cc
++++ b/chrome/browser/process_singleton_posix.cc
+@@ -146,7 +146,7 @@ const char kACKToken[] = "ACK";
+ const char kShutdownToken[] = "SHUTDOWN";
+ const char kTokenDelimiter = '\0';
+ const int kMaxMessageLength = 32 * 1024;
+-const int kMaxACKMessageLength = std::size(kShutdownToken) - 1;
++const int kMaxACKMessageLength = kMaxMessageLength;
+ 
+ bool g_disable_prompt = false;
+ bool g_skip_is_chrome_process_check = false;
+@@ -612,6 +612,7 @@ class ProcessSingleton::LinuxWatcher
+   // |reader| is for sending back ACK message.
+   void HandleMessage(const std::string& current_dir,
+                      const std::vector<std::string>& argv,
++                     const std::vector<uint8_t> additional_data,
+                      SocketReader* reader);
+ 
+  private:
+@@ -636,6 +637,9 @@ class ProcessSingleton::LinuxWatcher
+   // The ProcessSingleton that owns us.
+   ProcessSingleton* const parent_;
+ 
++  bool ack_callback_called_ = false;
++  void AckCallback(SocketReader* reader, const base::span<const uint8_t>* response);
++
+   std::set<std::unique_ptr<SocketReader>, base::UniquePtrComparator> readers_;
+ };
+ 
+@@ -666,16 +670,21 @@ void ProcessSingleton::LinuxWatcher::StartListening(int socket) {
+ }
+ 
+ void ProcessSingleton::LinuxWatcher::HandleMessage(
+-    const std::string& current_dir, const std::vector<std::string>& argv,
++    const std::string& current_dir,
++    const std::vector<std::string>& argv,
++    const std::vector<uint8_t> additional_data,
+     SocketReader* reader) {
+   DCHECK(ui_task_runner_->BelongsToCurrentThread());
+   DCHECK(reader);
+ 
+-  if (parent_->notification_callback_.Run(base::CommandLine(argv),
+-                                          base::FilePath(current_dir))) {
+-    // Send back "ACK" message to prevent the client process from starting up.
+-    reader->FinishWithACK(kACKToken, std::size(kACKToken) - 1);
+-  } else {
++  auto wrapped_ack_callback =
++      base::BindRepeating(&ProcessSingleton::LinuxWatcher::AckCallback,
++                          base::Unretained(this), reader);
++  ack_callback_called_ = false;
++  if (!parent_->notification_callback_.Run(base::CommandLine(argv),
++                                          base::FilePath(current_dir),
++                                          std::move(additional_data),
++                                          wrapped_ack_callback)) {
+     LOG(WARNING) << "Not handling interprocess notification as browser"
+                     " is shutting down";
+     // Send back "SHUTDOWN" message, so that the client process can start up
+@@ -685,6 +694,22 @@ void ProcessSingleton::LinuxWatcher::HandleMessage(
+   }
+ }
+ 
++void ProcessSingleton::LinuxWatcher::AckCallback(
++    SocketReader* reader,
++    const base::span<const uint8_t>* response) {
++  // Send back "ACK" message to prevent the client process from starting up.
++  if (!ack_callback_called_) {
++    ack_callback_called_ = true;
++    std::string ack_message;
++    ack_message.append(kACKToken, std::size(kACKToken) - 1);
++    if (response && response->size_bytes()) {
++      ack_message.append(reinterpret_cast<const char*>(response->data()),
++                         response->size_bytes());
++    }
++    reader->FinishWithACK(ack_message.c_str(), ack_message.size());
++  }
++}
++
+ void ProcessSingleton::LinuxWatcher::RemoveSocketReader(SocketReader* reader) {
+   DCHECK_CURRENTLY_ON(BrowserThread::IO);
+   DCHECK(reader);
+@@ -720,7 +745,8 @@ void ProcessSingleton::LinuxWatcher::SocketReader::
+     }
+   }
+ 
+-  // Validate the message.  The shortest message is kStartToken\0x\0x
++  // Validate the message.  The shortest message kStartToken\0\00
++  // The shortest message with additional data is kStartToken\0\00\00\0.
+   const size_t kMinMessageLength = std::size(kStartToken) + 4;
+   if (bytes_read_ < kMinMessageLength) {
+     buf_[bytes_read_] = 0;
+@@ -750,10 +776,28 @@ void ProcessSingleton::LinuxWatcher::SocketReader::
+   tokens.erase(tokens.begin());
+   tokens.erase(tokens.begin());
+ 
++  size_t num_args;
++  base::StringToSizeT(tokens[0], &num_args);
++  std::vector<std::string> command_line(tokens.begin() + 1, tokens.begin() + 1 + num_args);
++
++  std::vector<uint8_t> additional_data;
++  if (tokens.size() >= 3 + num_args) {
++    size_t additional_data_size;
++    base::StringToSizeT(tokens[1 + num_args], &additional_data_size);
++    std::string remaining_args = base::JoinString(
++        base::make_span(tokens.begin() + 2 + num_args, tokens.end()),
++        std::string(1, kTokenDelimiter));
++    const uint8_t* additional_data_bits =
++        reinterpret_cast<const uint8_t*>(remaining_args.c_str());
++    additional_data = std::vector<uint8_t>(additional_data_bits,
++        additional_data_bits + additional_data_size);
++  }
++
+   // Return to the UI thread to handle opening a new browser tab.
+   ui_task_runner_->PostTask(
+       FROM_HERE, base::BindOnce(&ProcessSingleton::LinuxWatcher::HandleMessage,
+-                                parent_, current_dir, tokens, this));
++                                parent_, current_dir, command_line,
++                                std::move(additional_data), this));
+   fd_watch_controller_.reset();
+ 
+   // LinuxWatcher::HandleMessage() is in charge of destroying this SocketReader
+@@ -782,8 +826,12 @@ void ProcessSingleton::LinuxWatcher::SocketReader::FinishWithACK(
+ //
+ ProcessSingleton::ProcessSingleton(
+     const base::FilePath& user_data_dir,
+-    const NotificationCallback& notification_callback)
++    const base::span<const uint8_t> additional_data,
++    const NotificationCallback& notification_callback,
++    const NotificationAckCallback& notification_ack_callback)
+     : notification_callback_(notification_callback),
++      notification_ack_callback_(notification_ack_callback),
++      additional_data_(additional_data),
+       current_pid_(base::GetCurrentProcId()),
+       watcher_(new LinuxWatcher(this)) {
+   socket_path_ = user_data_dir.Append(chrome::kSingletonSocketFilename);
+@@ -902,7 +950,8 @@ ProcessSingleton::NotifyResult ProcessSingleton::NotifyOtherProcessWithTimeout(
+              sizeof(socket_timeout));
+ 
+   // Found another process, prepare our command line
+-  // format is "START\0<current dir>\0<argv[0]>\0...\0<argv[n]>".
++  // format is "START\0<current-dir>\0<n-args>\0<argv[0]>\0...\0<argv[n]>
++  // \0<additional-data-length>\0<additional-data>".
+   std::string to_send(kStartToken);
+   to_send.push_back(kTokenDelimiter);
+ 
+@@ -912,11 +961,21 @@ ProcessSingleton::NotifyResult ProcessSingleton::NotifyOtherProcessWithTimeout(
+   to_send.append(current_dir.value());
+ 
+   const std::vector<std::string>& argv = cmd_line.argv();
++  to_send.push_back(kTokenDelimiter);
++  to_send.append(base::NumberToString(argv.size()));
+   for (auto it = argv.begin(); it != argv.end(); ++it) {
+     to_send.push_back(kTokenDelimiter);
+     to_send.append(*it);
+   }
+ 
++  size_t data_to_send_size = additional_data_.size_bytes();
++  if (data_to_send_size) {
++    to_send.push_back(kTokenDelimiter);
++    to_send.append(base::NumberToString(data_to_send_size));
++    to_send.push_back(kTokenDelimiter);
++    to_send.append(reinterpret_cast<const char*>(additional_data_.data()), data_to_send_size);
++  }
++
+   // Send the message
+   if (!WriteToSocket(socket.fd(), to_send.data(), to_send.length())) {
+     // Try to kill the other process, because it might have been dead.
+@@ -958,6 +1017,17 @@ ProcessSingleton::NotifyResult ProcessSingleton::NotifyOtherProcessWithTimeout(
+       linux_ui->NotifyWindowManagerStartupComplete();
+ #endif
+ 
++    size_t ack_data_len = len - (std::size(kACKToken) - 1);
++    if (ack_data_len) {
++      const uint8_t* raw_ack_data =
++          reinterpret_cast<const uint8_t*>(buf + std::size(kACKToken) - 1);
++      base::span<const uint8_t> ack_data =
++          base::make_span(raw_ack_data, raw_ack_data + ack_data_len);
++      notification_ack_callback_.Run(&ack_data);
++    } else {
++      notification_ack_callback_.Run(nullptr);
++    }
++
+     // Assume the other process is handling the request.
+     return PROCESS_NOTIFIED;
+   }
+diff --git a/chrome/browser/process_singleton_win.cc b/chrome/browser/process_singleton_win.cc
+index ec725b44296266bea1a51aea889463a0bba8449c..a3d4dd1efc950033855a1f2783f941384b249a5d 100644
+--- a/chrome/browser/process_singleton_win.cc
++++ b/chrome/browser/process_singleton_win.cc
+@@ -21,6 +21,7 @@
+ #include "base/strings/string_number_conversions.h"
+ #include "base/strings/utf_string_conversions.h"
+ #include "base/time/time.h"
++#include "base/timer/timer.h"
+ #include "base/trace_event/base_tracing.h"
+ #include "base/win/registry.h"
+ #include "base/win/scoped_handle.h"
+@@ -45,6 +46,14 @@
+ namespace {
+ 
+ const char kLockfile[] = "lockfile";
++const LPCWSTR kPipeName = L"\\\\.\\pipe\\electronAckPipe";
++const DWORD kPipeTimeout = 10000;
++const DWORD kMaxMessageLength = 32 * 1024;
++
++std::unique_ptr<std::vector<uint8_t>> g_ack_data;
++base::OneShotTimer g_ack_timer;
++HANDLE g_write_ack_pipe;
++bool g_write_ack_callback_called = false;
+ 
+ // A helper class that acquires the given |mutex| while the AutoLockMutex is in
+ // scope.
+@@ -80,10 +89,12 @@ BOOL CALLBACK BrowserWindowEnumeration(HWND window, LPARAM param) {
+ 
+ bool ParseCommandLine(const COPYDATASTRUCT* cds,
+                       base::CommandLine* parsed_command_line,
+-                      base::FilePath* current_directory) {
++                      base::FilePath* current_directory,
++                      std::vector<uint8_t>* parsed_additional_data) {
+   // We should have enough room for the shortest command (min_message_size)
+   // and also be a multiple of wchar_t bytes. The shortest command
+-  // possible is L"START\0\0" (empty current directory and command line).
++  // possible is L"START\0\0" (empty command line, current directory,
++  // and additional data).
+   static const int min_message_size = 7;
+   if (cds->cbData < min_message_size * sizeof(wchar_t) ||
+       cds->cbData % sizeof(wchar_t) != 0) {
+@@ -133,11 +144,82 @@ bool ParseCommandLine(const COPYDATASTRUCT* cds,
+     const std::wstring cmd_line =
+         msg.substr(second_null + 1, third_null - second_null);
+     *parsed_command_line = base::CommandLine::FromString(cmd_line);
++
++    const std::wstring::size_type fourth_null =
++        msg.find_first_of(L'\0', third_null + 1);
++    if (fourth_null == std::wstring::npos ||
++        fourth_null == msg.length()) {
++      // No additional data was provided.
++      return true;
++    }
++
++    // Get length of the additional data.
++    const std::wstring additional_data_length_string =
++        msg.substr(third_null + 1, fourth_null - third_null);
++    size_t additional_data_length;
++    base::StringToSizeT(additional_data_length_string, &additional_data_length);
++
++    const std::wstring::size_type fifth_null =
++        msg.find_first_of(L'\0', fourth_null + 1);
++    if (fifth_null == std::wstring::npos ||
++        fifth_null == msg.length()) {
++      LOG(WARNING) << "Invalid format for start command, we need a string in 6 "
++        "parts separated by NULLs";
++    }
++
++    // Get the actual additional data.
++    const std::wstring additional_data =
++        msg.substr(fourth_null + 1, fifth_null - fourth_null);
++    const uint8_t* additional_data_bytes =
++        reinterpret_cast<const uint8_t*>(additional_data.c_str());
++    *parsed_additional_data = std::vector<uint8_t>(additional_data_bytes,
++        additional_data_bytes + additional_data_length);
++
+     return true;
+   }
+   return false;
+ }
+ 
++void StoreAck(const base::span<const uint8_t>* ack_data) {
++  if (ack_data) {
++    g_ack_data = std::make_unique<std::vector<uint8_t>>(ack_data->begin(),
++                                                        ack_data->end());
++  } else {
++    g_ack_data = nullptr;
++  }
++}
++
++void SendBackAck() {
++  // This is the first instance sending the ack back to the second instance.
++  if (!g_write_ack_callback_called) {
++    g_write_ack_callback_called = true;
++    const uint8_t* data_buffer = nullptr;
++    DWORD data_to_send_size = 0;
++    if (g_ack_data) {
++      data_buffer = g_ack_data->data();
++      DWORD ack_data_size = g_ack_data->size() * sizeof(uint8_t);
++      data_to_send_size = (ack_data_size < kMaxMessageLength) ? ack_data_size : kMaxMessageLength;
++    }
++
++    ::ConnectNamedPipe(g_write_ack_pipe, NULL);
++
++    DWORD bytes_written = 0;
++    ::WriteFile(g_write_ack_pipe,
++      (LPCVOID)data_buffer,
++      data_to_send_size,
++      &bytes_written,
++      NULL);
++    DCHECK(bytes_written == data_to_send_size);
++
++    ::FlushFileBuffers(g_write_ack_pipe);
++    ::DisconnectNamedPipe(g_write_ack_pipe);
++
++    if (g_ack_data) {
++      g_ack_data.reset();
++    }
++  }
++}
++
+ bool ProcessLaunchNotification(
+     const ProcessSingleton::NotificationCallback& notification_callback,
+     UINT message,
+@@ -151,16 +233,23 @@ bool ProcessLaunchNotification(
+ 
+   // Handle the WM_COPYDATA message from another process.
+   const COPYDATASTRUCT* cds = reinterpret_cast<COPYDATASTRUCT*>(lparam);
+-
+   base::CommandLine parsed_command_line(base::CommandLine::NO_PROGRAM);
+   base::FilePath current_directory;
+-  if (!ParseCommandLine(cds, &parsed_command_line, &current_directory)) {
++  std::vector<uint8_t> additional_data;
++  if (!ParseCommandLine(cds, &parsed_command_line, &current_directory,
++                        &additional_data)) {
+     *result = TRUE;
+     return true;
+   }
+ 
+-  *result = notification_callback.Run(parsed_command_line, current_directory) ?
+-      TRUE : FALSE;
++  g_write_ack_callback_called = false;
++  *result = notification_callback.Run(parsed_command_line, current_directory,
++                                      std::move(additional_data),
++                                      base::BindRepeating(&StoreAck))
++                ? TRUE
++                : FALSE;
++  g_ack_timer.Start(FROM_HERE, base::Seconds(0),
++                    base::BindOnce(&SendBackAck));
+   return true;
+ }
+ 
+@@ -261,9 +350,13 @@ bool ProcessSingleton::EscapeVirtualization(
+ ProcessSingleton::ProcessSingleton(
+     const std::string& program_name,
+     const base::FilePath& user_data_dir,
++    const base::span<const uint8_t> additional_data,
+     bool is_app_sandboxed,
+-    const NotificationCallback& notification_callback)
++    const NotificationCallback& notification_callback,
++    const NotificationAckCallback& notification_ack_callback)
+     : notification_callback_(notification_callback),
++      notification_ack_callback_(notification_ack_callback),
++      additional_data_(additional_data),
+       program_name_(program_name),
+       is_app_sandboxed_(is_app_sandboxed),
+       is_virtualized_(false),
+@@ -278,6 +371,37 @@ ProcessSingleton::~ProcessSingleton() {
+     ::CloseHandle(lock_file_);
+ }
+ 
++void ReadAck(const ProcessSingleton::NotificationAckCallback& ack_callback) {
++  // We are reading the ack from the first instance.
++  // First, wait for the pipe.
++  ::WaitNamedPipe(kPipeName, NMPWAIT_USE_DEFAULT_WAIT);
++
++  HANDLE read_ack_pipe = ::CreateFile(kPipeName,
++    GENERIC_READ,
++    FILE_SHARE_READ,
++    NULL,
++    OPEN_EXISTING,
++    FILE_ATTRIBUTE_NORMAL,
++    NULL);
++  CHECK(read_ack_pipe != INVALID_HANDLE_VALUE);
++
++  DWORD bytes_read;
++  uint8_t read_ack_buffer[kMaxMessageLength];
++  ::ReadFile(read_ack_pipe,
++    (LPVOID)read_ack_buffer,
++    kMaxMessageLength,
++    &bytes_read,
++    NULL);
++
++  if (!bytes_read) {
++    ack_callback.Run(nullptr);
++  } else {
++    base::span<const uint8_t> out_span(read_ack_buffer, read_ack_buffer + bytes_read);
++    ack_callback.Run(&out_span);
++  }
++  ::CloseHandle(read_ack_pipe);
++}
++
+ // Code roughly based on Mozilla.
+ ProcessSingleton::NotifyResult ProcessSingleton::NotifyOtherProcess() {
+   TRACE_EVENT0("startup", "ProcessSingleton::NotifyOtherProcess");
+@@ -290,8 +414,9 @@ ProcessSingleton::NotifyResult ProcessSingleton::NotifyOtherProcess() {
+     return PROCESS_NONE;
+   }
+ 
+-  switch (chrome::AttemptToNotifyRunningChrome(remote_window_)) {
++  switch (chrome::AttemptToNotifyRunningChrome(remote_window_, additional_data_)) {
+     case chrome::NOTIFY_SUCCESS:
++      ReadAck(notification_ack_callback_);
+       return PROCESS_NOTIFIED;
+     case chrome::NOTIFY_FAILED:
+       remote_window_ = NULL;
+@@ -429,6 +554,18 @@ bool ProcessSingleton::Create() {
+           << "Lock file can not be created! Error code: " << error;
+ 
+       if (lock_file_ != INVALID_HANDLE_VALUE) {
++        // We are the first instance. Create a pipe to send out ack data.
++        ack_pipe_ = ::CreateNamedPipe(kPipeName,
++          PIPE_ACCESS_OUTBOUND,
++          PIPE_TYPE_BYTE | PIPE_REJECT_REMOTE_CLIENTS,
++          PIPE_UNLIMITED_INSTANCES,
++          kMaxMessageLength,
++          0,
++          kPipeTimeout,
++          NULL);
++        CHECK(ack_pipe_ != INVALID_HANDLE_VALUE);
++        g_write_ack_pipe = ack_pipe_;
++
+         // Set the window's title to the path of our user data directory so
+         // other Chrome instances can decide if they should forward to us.
+         TRACE_EVENT0("startup", "ProcessSingleton::Create:CreateWindow");
+@@ -456,6 +593,7 @@ bool ProcessSingleton::Create() {
+ }
+ 
+ void ProcessSingleton::Cleanup() {
++  ::CloseHandle(ack_pipe_);
+ }
+ 
+ void ProcessSingleton::OverrideShouldKillRemoteProcessCallbackForTesting(
+diff --git a/chrome/browser/win/chrome_process_finder.cc b/chrome/browser/win/chrome_process_finder.cc
+index b64ed1d155a30582e48c9cdffcee9d0f25a53a6a..ce851d09d501ebcc6d6c4065e746e869d5275b2b 100644
+--- a/chrome/browser/win/chrome_process_finder.cc
++++ b/chrome/browser/win/chrome_process_finder.cc
+@@ -36,9 +36,10 @@ HWND FindRunningChromeWindow(const base::FilePath& user_data_dir) {
+   return base::win::MessageWindow::FindWindow(user_data_dir.value());
+ }
+ 
+-NotifyChromeResult AttemptToNotifyRunningChrome(HWND remote_window) {
++NotifyChromeResult AttemptToNotifyRunningChrome(
++    HWND remote_window,
++    const base::span<const uint8_t> additional_data) {
+   TRACE_EVENT0("startup", "AttemptToNotifyRunningChrome");
+-
+   DCHECK(remote_window);
+   DWORD process_id = 0;
+   DWORD thread_id = GetWindowThreadProcessId(remote_window, &process_id);
+@@ -50,7 +51,8 @@ NotifyChromeResult AttemptToNotifyRunningChrome(HWND remote_window) {
+   }
+ 
+   // Send the command line to the remote chrome window.
+-  // Format is "START\0<<<current directory>>>\0<<<commandline>>>".
++  // Format is
++  // "START\0<current-directory>\0<command-line>\0<additional-data-length>\0<additional-data>".
+   std::wstring to_send(L"START\0", 6);  // want the NULL in the string.
+   base::FilePath cur_dir;
+   if (!base::GetCurrentDirectory(&cur_dir)) {
+@@ -64,6 +66,22 @@ NotifyChromeResult AttemptToNotifyRunningChrome(HWND remote_window) {
+       base::CommandLine::ForCurrentProcess()->GetCommandLineString());
+   to_send.append(L"\0", 1);  // Null separator.
+ 
++  size_t additional_data_size = additional_data.size_bytes();
++  if (additional_data_size) {
++    // Send over the size, because the reinterpret cast to wchar_t could
++    // add padding.
++    to_send.append(base::UTF8ToWide(base::NumberToString(additional_data_size)));
++    to_send.append(L"\0", 1);  // Null separator.
++
++    size_t padded_size = additional_data_size / sizeof(wchar_t);
++    if (additional_data_size % sizeof(wchar_t) != 0) {
++      padded_size++;
++    }
++    to_send.append(reinterpret_cast<const wchar_t*>(additional_data.data()),
++                   padded_size);
++    to_send.append(L"\0", 1);  // Null separator.
++  }
++
+   // Allow the current running browser window to make itself the foreground
+   // window (otherwise it will just flash in the taskbar).
+   ::AllowSetForegroundWindow(process_id);
+diff --git a/chrome/browser/win/chrome_process_finder.h b/chrome/browser/win/chrome_process_finder.h
+index 5516673cee019f6060077091e59498bf9038cd6e..8edea5079b46c2cba67833114eb9c21d85cfc22d 100644
+--- a/chrome/browser/win/chrome_process_finder.h
++++ b/chrome/browser/win/chrome_process_finder.h
+@@ -7,6 +7,7 @@
+ 
+ #include <windows.h>
+ 
++#include "base/containers/span.h"
+ #include "base/time/time.h"
+ 
+ namespace base {
+@@ -27,7 +28,9 @@ HWND FindRunningChromeWindow(const base::FilePath& user_data_dir);
+ // Attempts to send the current command line to an already running instance of
+ // Chrome via a WM_COPYDATA message.
+ // Returns true if a running Chrome is found and successfully notified.
+-NotifyChromeResult AttemptToNotifyRunningChrome(HWND remote_window);
++NotifyChromeResult AttemptToNotifyRunningChrome(
++    HWND remote_window,
++    const base::span<const uint8_t> additional_data);
+ 
+ // Changes the notification timeout to |new_timeout|, returns the old timeout.
+ base::TimeDelta SetNotificationTimeoutForTesting(base::TimeDelta new_timeout);

patches/chromium/feat_add_set_can_resize_mutator.patch

@@ -1,27 +0,0 @@
-From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
-From: Raymond Zhao <7199958+rzhao271@users.noreply.github.com>
-Date: Tue, 2 Aug 2022 09:30:36 -0700
-Subject: feat: Add set_can_resize mutator
-
-Adds a set_can_resize mutator to WidgetDelegate that
-doesn't emit the OnSizeConstraintsChanged event.
-This way, we can call set_can_resize from Electron before
-the widget is initialized to set the value earlier,
-and in turn, avoid showing a frame at startup
-for frameless applications.
-
-diff --git a/ui/views/widget/widget_delegate.h b/ui/views/widget/widget_delegate.h
-index 3375d6c3629235413362c4ed3d8c5a0eb53e23cd..8f4002ef6f5aa9b2cd8c1c911806772518d71f4b 100644
---- a/ui/views/widget/widget_delegate.h
-+++ b/ui/views/widget/widget_delegate.h
-@@ -328,6 +328,10 @@ class VIEWS_EXPORT WidgetDelegate {
-   // be cycled through with keyboard focus.
-   virtual void GetAccessiblePanes(std::vector<View*>* panes) {}
- 
-+  // A setter for the can_resize parameter that doesn't
-+  // emit any events.
-+  void set_can_resize(bool can_resize) { params_.can_resize = can_resize; }
-+
-   // Setters for data parameters of the WidgetDelegate. If you use these
-   // setters, there is no need to override the corresponding virtual getters.
-   void SetAccessibleRole(ax::mojom::Role role);

patches/chromium/feat_enable_offscreen_rendering_with_viz_compositor.patch

@@ -503,7 +503,7 @@ index 583e3e2525c753a0962d481fc67a3582df75d0e9..9416ec929bebcff7f07088e635376ef2
    waiting_on_draw_ack_ = true;
  
 diff --git a/components/viz/service/frame_sinks/root_compositor_frame_sink_impl.cc b/components/viz/service/frame_sinks/root_compositor_frame_sink_impl.cc
-index 4e38e0f49054cef3fd1a712c89608ce39003edeb..427882f8ed0d85c6e4170b213c3a3678b60a62df 100644
+index df92bab44402330869b44aa76bb40fc20e33b16a..2b3fbaee17c0a8bb7b04cd4c4edb13626dd1bb27 100644
 --- a/components/viz/service/frame_sinks/root_compositor_frame_sink_impl.cc
 +++ b/components/viz/service/frame_sinks/root_compositor_frame_sink_impl.cc
 @@ -84,7 +84,8 @@ RootCompositorFrameSinkImpl::Create(
@@ -621,7 +621,7 @@ index 80bff73a5886e8e79d7d91de5e27bc747fcfce02..8bc43d1359fa2551713992d6ccb73949
    raw_ptr<Layer> root_layer_ = nullptr;
  
 diff --git a/ui/gfx/ca_layer_params.h b/ui/gfx/ca_layer_params.h
-index 12e115cd6a128d8d150abc786d4d38b1d5119d91..b6320de28750333bee7ee83393849f4eb0a956ac 100644
+index c5fb29b30b9c5b7483998c567ed9a479d8743939..dc10d78315f76a3914ccd6e2e99af97fa909918b 100644
 --- a/ui/gfx/ca_layer_params.h
 +++ b/ui/gfx/ca_layer_params.h
 @@ -6,6 +6,7 @@
@@ -632,7 +632,7 @@ index 12e115cd6a128d8d150abc786d4d38b1d5119d91..b6320de28750333bee7ee83393849f4e
  #include "ui/gfx/geometry/size.h"
  #include "ui/gfx/gfx_export.h"
  
-@@ -51,6 +52,8 @@ struct GFX_EXPORT CALayerParams {
+@@ -41,6 +42,8 @@ struct GFX_EXPORT CALayerParams {
    gfx::ScopedRefCountedIOSurfaceMachPort io_surface_mach_port;
  #endif
  

patches/chromium/feat_expose_raw_response_headers_from_urlloader.patch

@@ -17,43 +17,43 @@ headers, moving forward we should find a way in upstream to provide
 access to these headers for loader clients created on the browser process.
 
 diff --git a/services/network/public/cpp/resource_request.cc b/services/network/public/cpp/resource_request.cc
-index a15e3c4bed344364f9c43e3f0b5c494d58dff789..24e3b291f8c25de2a0b82184fd731538b6586f86 100644
+index 87868727a78223baef9ffd2591f49fced240ef4e..f6a6ff28f33e2d1c065f2abeb96733b2d28a6ea1 100644
 --- a/services/network/public/cpp/resource_request.cc
 +++ b/services/network/public/cpp/resource_request.cc
 @@ -233,6 +233,7 @@ bool ResourceRequest::EqualsForTesting(const ResourceRequest& request) const {
           do_not_prompt_for_login == request.do_not_prompt_for_login &&
-          is_outermost_main_frame == request.is_outermost_main_frame &&
+          is_main_frame == request.is_main_frame &&
           transition_type == request.transition_type &&
 +         report_raw_headers == request.report_raw_headers &&
           previews_state == request.previews_state &&
           upgrade_if_insecure == request.upgrade_if_insecure &&
           is_revalidating == request.is_revalidating &&
 diff --git a/services/network/public/cpp/resource_request.h b/services/network/public/cpp/resource_request.h
-index 2ff43cc1ef683707001bf22c9b030bf6e7223e0f..cfaf9170666f04407adb5738ce6723900d234735 100644
+index 8b9a7b36f53a4cfcd159ac18c06d1724072013c8..ef0191bae8a07e531ae129cf32b22f4930c5e266 100644
 --- a/services/network/public/cpp/resource_request.h
 +++ b/services/network/public/cpp/resource_request.h
-@@ -158,6 +158,7 @@ struct COMPONENT_EXPORT(NETWORK_CPP_BASE) ResourceRequest {
+@@ -156,6 +156,7 @@ struct COMPONENT_EXPORT(NETWORK_CPP_BASE) ResourceRequest {
    bool do_not_prompt_for_login = false;
-   bool is_outermost_main_frame = false;
+   bool is_main_frame = false;
    int transition_type = 0;
 +  bool report_raw_headers = false;
    int previews_state = 0;
    bool upgrade_if_insecure = false;
    bool is_revalidating = false;
 diff --git a/services/network/public/cpp/url_request_mojom_traits.cc b/services/network/public/cpp/url_request_mojom_traits.cc
-index 4f2740ebf2dc4bee423cdbb72cae128f28a03f12..d3f531429598b3666aaba655356155c470e8b645 100644
+index 1fcf54cac11c38352e14774cd08bcaa162443e9c..5356da11391d52a8f9aaa57a27616cee6dc0f2b6 100644
 --- a/services/network/public/cpp/url_request_mojom_traits.cc
 +++ b/services/network/public/cpp/url_request_mojom_traits.cc
 @@ -209,6 +209,7 @@ bool StructTraits<
    out->do_not_prompt_for_login = data.do_not_prompt_for_login();
-   out->is_outermost_main_frame = data.is_outermost_main_frame();
+   out->is_main_frame = data.is_main_frame();
    out->transition_type = data.transition_type();
 +  out->report_raw_headers = data.report_raw_headers();
    out->previews_state = data.previews_state();
    out->upgrade_if_insecure = data.upgrade_if_insecure();
    out->is_revalidating = data.is_revalidating();
 diff --git a/services/network/public/cpp/url_request_mojom_traits.h b/services/network/public/cpp/url_request_mojom_traits.h
-index 069768e7ca727fc2ad8f5379900ad4a959a87f4f..3e6bc18564e2a3cdbac9af686636f75d64082464 100644
+index 3a1c5bd943c110514e4da06491190476d6e6de38..6a80fb16242865d398bcbcd380893ccc9a3fe167 100644
 --- a/services/network/public/cpp/url_request_mojom_traits.h
 +++ b/services/network/public/cpp/url_request_mojom_traits.h
 @@ -269,6 +269,9 @@ struct COMPONENT_EXPORT(NETWORK_CPP_BASE)
@@ -67,7 +67,7 @@ index 069768e7ca727fc2ad8f5379900ad4a959a87f4f..3e6bc18564e2a3cdbac9af686636f75d
      return request.previews_state;
    }
 diff --git a/services/network/public/mojom/url_request.mojom b/services/network/public/mojom/url_request.mojom
-index ef3e8e68621402db5a97977f49ac74c438b0a563..aa1c1bcf7ca30adde4c25ed9bd8ed8a70eb919e0 100644
+index 79b5d03ded03ced9e6ff4d17d10935004bfb0062..923883fd010f9621c790dd5381a7e1f0cb36e740 100644
 --- a/services/network/public/mojom/url_request.mojom
 +++ b/services/network/public/mojom/url_request.mojom
 @@ -312,6 +312,9 @@ struct URLRequest {
@@ -103,7 +103,7 @@ index 4c4cc16db82d7434573f7740855fbe72d68815e6..f71290800b6bb51a39b1f86be36f02d6
    string mime_type;
  
 diff --git a/services/network/url_loader.cc b/services/network/url_loader.cc
-index 85e984259a1e067c76d57e5e54eb3ed1d9694ec0..dbe9e809898ee720c0670e9c6db73c38658613b2 100644
+index 4c11fd542a66f514a6c36e684a34d0a62053c1f4..6852fd470c79e2fb041bf57a01e2b0b913cb94db 100644
 --- a/services/network/url_loader.cc
 +++ b/services/network/url_loader.cc
 @@ -469,6 +469,7 @@ URLLoader::URLLoader(
@@ -123,7 +123,7 @@ index 85e984259a1e067c76d57e5e54eb3ed1d9694ec0..dbe9e809898ee720c0670e9c6db73c38
      url_request_->SetResponseHeadersCallback(base::BindRepeating(
          &URLLoader::SetRawResponseHeaders, base::Unretained(this)));
    }
-@@ -1428,6 +1429,19 @@ void URLLoader::OnResponseStarted(net::URLRequest* url_request, int net_error) {
+@@ -1411,6 +1412,19 @@ void URLLoader::OnResponseStarted(net::URLRequest* url_request, int net_error) {
    }
  
    response_ = BuildResponseHead();
@@ -144,7 +144,7 @@ index 85e984259a1e067c76d57e5e54eb3ed1d9694ec0..dbe9e809898ee720c0670e9c6db73c38
  
    // Parse and remove the Trust Tokens response headers, if any are expected,
 diff --git a/services/network/url_loader.h b/services/network/url_loader.h
-index e235b3cc8657e081063709f6d2cd6e0b2e99f2b2..15b77b8648b905711df8551b1645b14dd7d6fd87 100644
+index 53822d17b20f4e6d163d0dc84eea6c455254a5f7..c494a63b0c1dcb39120e8aabc84a60ebbf2ff224 100644
 --- a/services/network/url_loader.h
 +++ b/services/network/url_loader.h
 @@ -502,6 +502,8 @@ class COMPONENT_EXPORT(NETWORK_SERVICE) URLLoader

patches/chromium/feat_move_firstpartysets_to_content_browser_client.patch

@@ -1,874 +0,0 @@
-From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
-From: VerteDinde <keeleymhammond@gmail.com>
-Date: Sun, 8 May 2022 17:21:12 -0700
-Subject: feat: replace ad-hoc SetPublicFirstPartySets calls with method in
- ContentBrowserClient
-
-Cherry-picked from upstream Chromium. This patch can be removed when the
-fix is inherited from the next Chromium roll backport.
-
-This essentially requires
-embedders to indicate whether they will
-(maybe asynchronously) call SetPublicFirstPartySets during startup, or
-not. This makes it easier to initialize First-Party Sets properly, since
-it is now done via a pull-based interface rather than a push-based
-interface (which would require code in every embedder in order to
-set up the First-Party Sets backend). Now, there is a single place (in
-content) that handles every embedder that won't need to explicitly call
-SetPublicFirstPartySets at some point (e.g. after initializing
-Component Updater, in Chrome's case).
-
-Bug: 1321908
-Change-Id: I47eaaaf77e548079e1bd6360fd573e877aa79b32
-Reviewed-on:
-https://chromium-review.googlesource.com/c/chromium/src/+/3623985
-Reviewed-by: Avi Drissman <avi@chromium.org>
-Commit-Queue: Chris Fredrickson <cfredric@chromium.org>
-Cr-Commit-Position: refs/heads/main@{#999047}
-
-Patch-Filename:
-feat_move_firstpartysets_to_content_browser_client.patch
-
-diff --git a/chrome/browser/chrome_browser_main.cc b/chrome/browser/chrome_browser_main.cc
-index e07874dc5a2fab83dff0a07d35aeb0cad7a1a67c..9f635870282f0f2a9b8bfaaa59e34f91675dcda3 100644
---- a/chrome/browser/chrome_browser_main.cc
-+++ b/chrome/browser/chrome_browser_main.cc
-@@ -1601,10 +1601,6 @@ int ChromeBrowserMainParts::PreMainMessageLoopRunImpl() {
-   // called inside PostProfileInit and depends on it.
-   if (!parsed_command_line().HasSwitch(switches::kDisableComponentUpdate)) {
-     component_updater::RegisterComponentsForUpdate();
--  } else {
--    // Initialize First-Party Sets even if component updater is disabled.
--    content::FirstPartySetsHandler::GetInstance()->SetPublicFirstPartySets(
--        base::File());
-   }
- 
-   // TODO(stevenjb): Move WIN and MACOSX specific code to appropriate Parts.
-diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
-index 3943c32ab29e785f401c2a5b31f1f6ed832514f0..939c28a029418bc353795aa1a007508680f42e57 100644
---- a/chrome/browser/chrome_content_browser_client.cc
-+++ b/chrome/browser/chrome_content_browser_client.cc
-@@ -6462,6 +6462,12 @@ bool ChromeContentBrowserClient::IsFirstPartySetsEnabled() {
-   return local_state->GetBoolean(first_party_sets::kFirstPartySetsEnabled);
- }
- 
-+bool ChromeContentBrowserClient::WillProvidePublicFirstPartySets() {
-+  return !base::CommandLine::ForCurrentProcess()->HasSwitch(
-+             switches::kDisableComponentUpdate) &&
-+         base::FeatureList::IsEnabled(features::kFirstPartySets);
-+}
-+
- base::Value::Dict ChromeContentBrowserClient::GetFirstPartySetsOverrides() {
-   if (!g_browser_process) {
-     // If browser process doesn't exist (e.g. in minimal mode on Android),
-diff --git a/chrome/browser/chrome_content_browser_client.h b/chrome/browser/chrome_content_browser_client.h
-index f0415a5099cdf181ab620fb6400db4f524c2c892..016b8276feeb6c35c88bc779ae84eea38d66f57d 100644
---- a/chrome/browser/chrome_content_browser_client.h
-+++ b/chrome/browser/chrome_content_browser_client.h
-@@ -772,6 +772,7 @@ class ChromeContentBrowserClient : public content::ContentBrowserClient {
- 
-   bool IsFindInPageDisabledForOrigin(const url::Origin& origin) override;
-   bool IsFirstPartySetsEnabled() override;
-+  bool WillProvidePublicFirstPartySets() override;
-   base::Value::Dict GetFirstPartySetsOverrides() override;
- 
-   bool ShouldPreconnectNavigation(
-diff --git a/content/browser/first_party_sets/first_party_set_parser.cc b/content/browser/first_party_sets/first_party_set_parser.cc
-index b03570f072f407a1d2c6a58646db0f48a845429d..3ac5c0d206c7910e5ae653004e96780c14c8315d 100644
---- a/content/browser/first_party_sets/first_party_set_parser.cc
-+++ b/content/browser/first_party_sets/first_party_set_parser.cc
-@@ -323,4 +323,4 @@ FirstPartySetParser::ParseSetsFromEnterprisePolicy(
-   return absl::nullopt;
- }
- 
--}  // namespace content
-+}  // namespace content
-\ No newline at end of file
-diff --git a/content/browser/first_party_sets/first_party_set_parser.h b/content/browser/first_party_sets/first_party_set_parser.h
-index 491a8b508ef0d093f37608d2fde615427b9319df..3f33b1604fecbff0d4db8739ad138d95223b579c 100644
---- a/content/browser/first_party_sets/first_party_set_parser.h
-+++ b/content/browser/first_party_sets/first_party_set_parser.h
-@@ -102,4 +102,4 @@ class CONTENT_EXPORT FirstPartySetParser {
- 
- }  // namespace content
- 
--#endif  // CONTENT_BROWSER_FIRST_PARTY_SETS_FIRST_PARTY_SET_PARSER_H_
-+#endif  // CONTENT_BROWSER_FIRST_PARTY_SETS_FIRST_PARTY_SET_PARSER_H_
-\ No newline at end of file
-diff --git a/content/browser/first_party_sets/first_party_sets_handler_impl.cc b/content/browser/first_party_sets/first_party_sets_handler_impl.cc
-index e5d277236b6393d35e8cf5a69c7f6d16f3394582..bb6840eecabfab9e9f0ae6b0fdc4e4436d1ea3b1 100644
---- a/content/browser/first_party_sets/first_party_sets_handler_impl.cc
-+++ b/content/browser/first_party_sets/first_party_sets_handler_impl.cc
-@@ -74,7 +74,8 @@ FirstPartySetsHandler* FirstPartySetsHandler::GetInstance() {
- // static
- FirstPartySetsHandlerImpl* FirstPartySetsHandlerImpl::GetInstance() {
-   static base::NoDestructor<FirstPartySetsHandlerImpl> instance(
--      GetContentClient()->browser()->IsFirstPartySetsEnabled());
-+      GetContentClient()->browser()->IsFirstPartySetsEnabled(),
-+      GetContentClient()->browser()->WillProvidePublicFirstPartySets());
-   return instance.get();
- }
- 
-@@ -89,8 +90,12 @@ FirstPartySetsHandler::ValidateEnterprisePolicy(
-       policy, /*out_sets=*/nullptr);
- }
- 
--FirstPartySetsHandlerImpl::FirstPartySetsHandlerImpl(bool enabled)
--    : enabled_(enabled) {
-+FirstPartySetsHandlerImpl::FirstPartySetsHandlerImpl(
-+    bool enabled,
-+    bool embedder_will_provide_public_sets)
-+    : enabled_(enabled),
-+      embedder_will_provide_public_sets_(enabled &&
-+                                         embedder_will_provide_public_sets) {
-   sets_loader_ = std::make_unique<FirstPartySetsLoader>(
-       base::BindOnce(&FirstPartySetsHandlerImpl::SetCompleteSets,
-                      // base::Unretained(this) is safe here because
-@@ -112,12 +117,23 @@ void FirstPartySetsHandlerImpl::Init(const base::FilePath& user_data_dir,
-                                      const std::string& flag_value,
-                                      SetsReadyOnceCallback on_sets_ready) {
-   DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
-+  DCHECK(!initialized_);
-+  DCHECK(persisted_sets_path_.empty());
-+  DCHECK(on_sets_ready_.is_null());
-+
-+  initialized_ = true;
-   on_sets_ready_ = std::move(on_sets_ready);
-   SetPersistedSets(user_data_dir);
--  SetManuallySpecifiedSet(flag_value);
- 
--  if (!IsEnabled())
-+  if (IsEnabled()) {
-+    DCHECK(!on_sets_ready_.is_null());
-+    sets_loader_->SetManuallySpecifiedSet(flag_value);
-+    if (!embedder_will_provide_public_sets_) {
-+      sets_loader_->SetComponentSets(base::File());
-+    }
-+  } else {
-     SetCompleteSets({});
-+  }
- }
- 
- bool FirstPartySetsHandlerImpl::IsEnabled() const {
-@@ -127,16 +143,17 @@ bool FirstPartySetsHandlerImpl::IsEnabled() const {
- 
- void FirstPartySetsHandlerImpl::SetPublicFirstPartySets(base::File sets_file) {
-   DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
--  if (!IsEnabled()) {
--    sets_loader_->DisposeFile(std::move(sets_file));
--    return;
--  }
-+  DCHECK(enabled_);
-+  DCHECK(embedder_will_provide_public_sets_);
-   sets_loader_->SetComponentSets(std::move(sets_file));
- }
- 
- void FirstPartySetsHandlerImpl::ResetForTesting() {
-   DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
-+  initialized_ = false;
-   enabled_ = GetContentClient()->browser()->IsFirstPartySetsEnabled();
-+  embedder_will_provide_public_sets_ =
-+      GetContentClient()->browser()->WillProvidePublicFirstPartySets();
- 
-   // Initializes the `sets_loader_` member with a callback to SetCompleteSets
-   // and the result of content::GetFirstPartySetsOverrides.
-@@ -153,19 +170,16 @@ void FirstPartySetsHandlerImpl::ResetForTesting() {
-   raw_persisted_sets_ = absl::nullopt;
- }
- 
--void FirstPartySetsHandlerImpl::SetManuallySpecifiedSet(
--    const std::string& flag_value) {
--  DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
--  if (!IsEnabled())
--    return;
--  sets_loader_->SetManuallySpecifiedSet(flag_value);
--}
--
- void FirstPartySetsHandlerImpl::SetPersistedSets(
-     const base::FilePath& user_data_dir) {
-   DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
-+  DCHECK(!raw_persisted_sets_.has_value());
-+  DCHECK(persisted_sets_path_.empty());
-   if (user_data_dir.empty()) {
-     VLOG(1) << "Empty path. Failed loading serialized First-Party Sets file.";
-+    // We have to continue, in case the embedder has enabled FPS but has not
-+    // provided a directory to store persisted sets.
-+    OnReadPersistedSetsFile("");
-     return;
-   }
-   persisted_sets_path_ = user_data_dir.Append(kPersistedFirstPartySetsFileName);
-@@ -184,19 +198,36 @@ void FirstPartySetsHandlerImpl::SetPersistedSets(
- void FirstPartySetsHandlerImpl::OnReadPersistedSetsFile(
-     const std::string& raw_persisted_sets) {
-   DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
--  DCHECK(!persisted_sets_path_.empty());
-+  DCHECK(!raw_persisted_sets_.has_value());
-   raw_persisted_sets_ = raw_persisted_sets;
-   UmaHistogramTimes(
--      "Cookie.FirstPartySets.InitializationDuration.ReadPersistedSets",
-+      "Cookie.FirstPartySets.InitializationDuration.ReadPersistedSets2",
-       construction_timer_.Elapsed());
--  ClearSiteDataOnChangedSetsIfReady();
-+
-+  if (sets_.has_value()) {
-+    ClearSiteDataOnChangedSets();
-+
-+    if (IsEnabled()) {
-+      DCHECK(!on_sets_ready_.is_null());
-+      std::move(on_sets_ready_).Run(sets_.value());
-+    }
-+  }
- }
- 
- void FirstPartySetsHandlerImpl::SetCompleteSets(
-     base::flat_map<net::SchemefulSite, net::SchemefulSite> sets) {
-   DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
-+  DCHECK(!sets_.has_value());
-   sets_ = std::move(sets);
--  ClearSiteDataOnChangedSetsIfReady();
-+
-+  if (raw_persisted_sets_.has_value()) {
-+    ClearSiteDataOnChangedSets();
-+
-+    if (IsEnabled()) {
-+      DCHECK(!on_sets_ready_.is_null());
-+      std::move(on_sets_ready_).Run(sets_.value());
-+    }
-+  }
- }
- 
- // static
-@@ -229,10 +260,10 @@ base::flat_set<net::SchemefulSite> FirstPartySetsHandlerImpl::ComputeSetsDiff(
-   return result;
- }
- 
--void FirstPartySetsHandlerImpl::ClearSiteDataOnChangedSetsIfReady() {
-+void FirstPartySetsHandlerImpl::ClearSiteDataOnChangedSets() const {
-   DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
--  if (!raw_persisted_sets_.has_value() || !sets_.has_value())
--    return;
-+  DCHECK(sets_.has_value());
-+  DCHECK(raw_persisted_sets_.has_value());
- 
-   base::flat_set<net::SchemefulSite> diff =
-       ComputeSetsDiff(FirstPartySetParser::DeserializeFirstPartySets(
-@@ -241,14 +272,13 @@ void FirstPartySetsHandlerImpl::ClearSiteDataOnChangedSetsIfReady() {
- 
-   // TODO(shuuran@chromium.org): Implement site state clearing.
- 
--  if (!on_sets_ready_.is_null() && IsEnabledAndReady())
--    std::move(on_sets_ready_).Run(sets_.value());
--
--  base::ThreadPool::PostTask(
--      FROM_HERE, {base::MayBlock(), base::TaskPriority::BEST_EFFORT},
--      base::BindOnce(
--          &MaybeWriteSetsToDisk, persisted_sets_path_,
--          FirstPartySetParser::SerializeFirstPartySets(sets_.value())));
-+  if (!persisted_sets_path_.empty()) {
-+    base::ThreadPool::PostTask(
-+        FROM_HERE, {base::MayBlock(), base::TaskPriority::BEST_EFFORT},
-+        base::BindOnce(
-+            &MaybeWriteSetsToDisk, persisted_sets_path_,
-+            FirstPartySetParser::SerializeFirstPartySets(sets_.value())));
-+  }
- }
- 
- bool FirstPartySetsHandlerImpl::IsEnabledAndReady() const {
-@@ -256,4 +286,4 @@ bool FirstPartySetsHandlerImpl::IsEnabledAndReady() const {
-   return IsEnabled() && sets_.has_value();
- }
- 
--}  // namespace content
-+}  // namespace content
-\ No newline at end of file
-diff --git a/content/browser/first_party_sets/first_party_sets_handler_impl.h b/content/browser/first_party_sets/first_party_sets_handler_impl.h
-index a60adcd16b5b8911965f9a22c2e70b5044150758..829cd96245cbe39eeddecf2e0403f2ba1ab88793 100644
---- a/content/browser/first_party_sets/first_party_sets_handler_impl.h
-+++ b/content/browser/first_party_sets/first_party_sets_handler_impl.h
-@@ -55,10 +55,9 @@ class CONTENT_EXPORT FirstPartySetsHandlerImpl : public FirstPartySetsHandler {
-   // persisted sets, since we may still need to clear data from a previous
-   // invocation of Chromium which had First-Party Sets enabled.
-   //
--  // TODO(https://crbug.com/1309188): Init() should be called in the
--  // BrowserMainLoop::PreMainMessageLoopRun(). But just in case it's
--  // accidentally called from other places, make sure it's no-op for the
--  // following calls.
-+  // If First-Party Sets is enabled, `on_sets_ready` must not be null.
-+  //
-+  // Must be called exactly once.
-   void Init(const base::FilePath& user_data_dir,
-             const std::string& flag_value,
-             SetsReadyOnceCallback on_sets_ready);
-@@ -78,6 +77,11 @@ class CONTENT_EXPORT FirstPartySetsHandlerImpl : public FirstPartySetsHandler {
-     enabled_ = enabled;
-   }
- 
-+  void SetEmbedderWillProvidePublicSetsForTesting(bool will_provide) {
-+    DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
-+    embedder_will_provide_public_sets_ = enabled_ && will_provide;
-+  }
-+
-   // Compares the map `old_sets` to `current_sets` and returns the set of sites
-   // that: 1) were in `old_sets` but are no longer in `current_sets`, i.e. leave
-   // the FPSs; or, 2) mapped to a different owner site.
-@@ -92,41 +96,38 @@ class CONTENT_EXPORT FirstPartySetsHandlerImpl : public FirstPartySetsHandler {
-  private:
-   friend class base::NoDestructor<FirstPartySetsHandlerImpl>;
- 
--  explicit FirstPartySetsHandlerImpl(bool enabled);
-+  FirstPartySetsHandlerImpl(bool enabled,
-+                            bool embedder_will_provide_public_sets);
- 
-   // This method reads the persisted First-Party Sets from the file under
--  // `user_data_dir`.
-+  // `user_data_dir`. Must be called exactly once.
-   void SetPersistedSets(const base::FilePath& user_data_dir);
- 
--  // Stores the read persisted sets in `raw_persisted_sets_`.
-+  // Stores the read persisted sets in `raw_persisted_sets_`. Must be called
-+  // exactly once.
-   void OnReadPersistedSetsFile(const std::string& raw_persisted_sets);
- 
--  // Parses and sets the First-Party Set that was provided via the
--  // `kUseFirstPartySet` flag/switch.
--  //
--  // Has no effect if `kFirstPartySets` is disabled, or
--  // `SetPublicFirstPartySets` is not called.
--  void SetManuallySpecifiedSet(const std::string& flag_value);
--
--  // Sets the current First-Party Sets data.
-+  // Sets the current First-Party Sets data. Must be called exactly once.
-   void SetCompleteSets(FlattenedSets sets);
- 
--  // Checks the required inputs have been received, and if so:
-+  // Does the following:
-   // 1) computes the diff between the `sets_` and the parsed
-   // `raw_persisted_sets_`;
-   // 2) clears the site data of the set of sites based on the diff;
--  // 3) calls `on_sets_ready_` if conditions are met;
--  // 4) writes the current First-Party Sets to the file in
-+  // 3) writes the current First-Party Sets to the file in
-   // `persisted_sets_path_`.
-   //
-   // TODO(shuuran@chromium.org): Implement the code to clear site state.
--  void ClearSiteDataOnChangedSetsIfReady();
-+  void ClearSiteDataOnChangedSets() const;
- 
-   // Returns true if:
-   // * First-Party Sets are enabled;
-   // * `sets_` is ready to be used.
-   bool IsEnabledAndReady() const;
- 
-+  // Whether Init has been called already or not.
-+  bool initialized_ = false;
-+
-   // Represents the mapping of site -> site, where keys are members of sets, and
-   // values are owners of the sets. Owners are explicitly represented as members
-   // of the set.
-@@ -144,6 +145,7 @@ class CONTENT_EXPORT FirstPartySetsHandlerImpl : public FirstPartySetsHandler {
-   base::FilePath persisted_sets_path_ GUARDED_BY_CONTEXT(sequence_checker_);
- 
-   bool enabled_ GUARDED_BY_CONTEXT(sequence_checker_);
-+  bool embedder_will_provide_public_sets_ GUARDED_BY_CONTEXT(sequence_checker_);
- 
-   // We use a OnceCallback to ensure we only pass along the sets once
-   // during Chrome's lifetime (modulo reconfiguring the network service).
-@@ -160,4 +162,4 @@ class CONTENT_EXPORT FirstPartySetsHandlerImpl : public FirstPartySetsHandler {
- 
- }  // namespace content
- 
--#endif  // CONTENT_BROWSER_FIRST_PARTY_SETS_FIRST_PARTY_SETS_HANDLER_IMPL_H_
-+#endif  // CONTENT_BROWSER_FIRST_PARTY_SETS_FIRST_PARTY_SETS_HANDLER_IMPL_H_
-\ No newline at end of file
-diff --git a/content/browser/first_party_sets/first_party_sets_handler_impl_unittest.cc b/content/browser/first_party_sets/first_party_sets_handler_impl_unittest.cc
-index 0c0eeda67a8a4bdc9876f5ad3fe78c06c4f18b5d..3e92801eb25e339e6b3a43b5fadab8f1b78b23f9 100644
---- a/content/browser/first_party_sets/first_party_sets_handler_impl_unittest.cc
-+++ b/content/browser/first_party_sets/first_party_sets_handler_impl_unittest.cc
-@@ -367,14 +367,6 @@ TEST_F(FirstPartySetsHandlerImplDisabledTest, IgnoresValid) {
-             FAIL();  // Should not be called.
-           }));
- 
--  // Set required inputs to be able to receive the merged sets from
--  // FirstPartySetsLoader.
--  const std::string input =
--      "{\"owner\": \"https://example.test\",\"members\": "
--      "[\"https://aaaa.test\"]}";
--  ASSERT_TRUE(base::JSONReader::Read(input));
--  SetPublicFirstPartySetsAndWait(input);
--
-   env().RunUntilIdle();
- 
-   // TODO(shuuran@chromium.org): test site state is cleared.
-@@ -397,9 +389,6 @@ TEST_F(FirstPartySetsHandlerImplDisabledTest,
-             FAIL();  // Should not be called.
-           }));
- 
--  SetPublicFirstPartySetsAndWait(R"({"owner": "https://example.test", )"
--                                 R"("members": ["https://member.test"]})");
--
-   EXPECT_EQ(
-       FirstPartySetsHandlerImpl::GetInstance()->GetSetsIfEnabledAndReady(),
-       absl::nullopt);
-@@ -413,11 +402,6 @@ class FirstPartySetsHandlerImplEnabledTest
- };
- 
- TEST_F(FirstPartySetsHandlerImplEnabledTest, PersistedSetsNotReady) {
--  const std::string input = R"({"owner": "https://foo.test", )"
--                            R"("members": ["https://member2.test"]})";
--  ASSERT_TRUE(base::JSONReader::Read(input));
--  SetPublicFirstPartySetsAndWait(input);
--
-   // Empty `user_data_dir` will fail loading persisted sets.
-   FirstPartySetsHandlerImpl::GetInstance()->Init(
-       /*user_data_dir=*/{},
-@@ -431,6 +415,8 @@ TEST_F(FirstPartySetsHandlerImplEnabledTest, PersistedSetsNotReady) {
- }
- 
- TEST_F(FirstPartySetsHandlerImplEnabledTest, PublicFirstPartySetsNotReady) {
-+  FirstPartySetsHandlerImpl::GetInstance()
-+      ->SetEmbedderWillProvidePublicSetsForTesting(true);
-   ASSERT_TRUE(base::WriteFile(persisted_sets_path_, "{}"));
- 
-   // Persisted sets are expected to be loaded with the provided path.
-@@ -447,6 +433,8 @@ TEST_F(FirstPartySetsHandlerImplEnabledTest, PublicFirstPartySetsNotReady) {
- 
- TEST_F(FirstPartySetsHandlerImplEnabledTest,
-        Successful_PersistedSetsFileNotExist) {
-+  FirstPartySetsHandlerImpl::GetInstance()
-+      ->SetEmbedderWillProvidePublicSetsForTesting(true);
-   const std::string input = R"({"owner": "https://foo.test", )"
-                             R"("members": ["https://member2.test"]})";
-   ASSERT_TRUE(base::JSONReader::Read(input));
-@@ -479,6 +467,8 @@ TEST_F(FirstPartySetsHandlerImplEnabledTest,
- }
- 
- TEST_F(FirstPartySetsHandlerImplEnabledTest, Successful_PersistedSetsEmpty) {
-+  FirstPartySetsHandlerImpl::GetInstance()
-+      ->SetEmbedderWillProvidePublicSetsForTesting(true);
-   ASSERT_TRUE(base::WriteFile(persisted_sets_path_, "{}"));
- 
-   const std::string input = R"({"owner": "https://foo.test", )"
-@@ -514,6 +504,8 @@ TEST_F(FirstPartySetsHandlerImplEnabledTest, Successful_PersistedSetsEmpty) {
- 
- TEST_F(FirstPartySetsHandlerImplEnabledTest,
-        GetSetsIfEnabledAndReady_AfterSetsReady) {
-+  FirstPartySetsHandlerImpl::GetInstance()
-+      ->SetEmbedderWillProvidePublicSetsForTesting(true);
-   ASSERT_TRUE(base::WriteFile(persisted_sets_path_, "{}"));
- 
-   const std::string input = R"({"owner": "https://example.test", )"
-@@ -549,6 +541,8 @@ TEST_F(FirstPartySetsHandlerImplEnabledTest,
- 
- TEST_F(FirstPartySetsHandlerImplEnabledTest,
-        GetSetsIfEnabledAndReady_BeforeSetsReady) {
-+  FirstPartySetsHandlerImpl::GetInstance()
-+      ->SetEmbedderWillProvidePublicSetsForTesting(true);
-   ASSERT_TRUE(base::WriteFile(persisted_sets_path_, "{}"));
- 
-   // Call GetSetsIfEnabledAndReady before the sets are ready.
-diff --git a/content/browser/first_party_sets/first_party_sets_loader.cc b/content/browser/first_party_sets/first_party_sets_loader.cc
-index 52acedfde41b85acfc9246121ccfd6e63290270e..c229815ff14160c4f325fb51473e3b4baf5a9891 100644
---- a/content/browser/first_party_sets/first_party_sets_loader.cc
-+++ b/content/browser/first_party_sets/first_party_sets_loader.cc
-@@ -20,6 +20,7 @@
- #include "base/strings/string_split.h"
- #include "base/task/thread_pool.h"
- #include "base/values.h"
-+#include "content/browser/first_party_sets/addition_overlaps_union_find.h"
- #include "content/browser/first_party_sets/first_party_set_parser.h"
- #include "net/base/schemeful_site.h"
- #include "third_party/abseil-cpp/absl/types/optional.h"
-@@ -66,6 +67,37 @@ std::string ReadSetsFile(base::File sets_file) {
-   return base::ReadStreamToString(file.get(), &raw_sets) ? raw_sets : "";
- }
- 
-+// Creates a set of SchemefulSites present with the given list of SingleSets.
-+base::flat_set<net::SchemefulSite> FlattenSingleSetList(
-+    const std::vector<content::FirstPartySetsLoader::SingleSet>& sets) {
-+  std::vector<net::SchemefulSite> sites;
-+  for (const content::FirstPartySetsLoader::SingleSet& set : sets) {
-+    sites.push_back(set.first);
-+    sites.insert(sites.end(), set.second.begin(), set.second.end());
-+  }
-+  return sites;
-+}
-+
-+// Populates the `policy_set_overlaps` out-parameter by checking
-+// `existing_sets`. If `site` is equal to an existing site e in `sets`, then
-+// `policy_set_index` will be added to the list of set indices at
-+// `policy_set_overlaps`[e].
-+void AddIfPolicySetOverlaps(
-+    const net::SchemefulSite& site,
-+    size_t policy_set_index,
-+    FirstPartySetsLoader::FlattenedSets existing_sets,
-+    base::flat_map<net::SchemefulSite, base::flat_set<size_t>>&
-+        policy_set_overlaps) {
-+  // Check `site` for membership in `existing_sets`.
-+  if (auto it = existing_sets.find(site); it != existing_sets.end()) {
-+    // Add the index of `site`'s policy set to the list of policy set indices
-+    // that also overlap with site_owner.
-+    auto [site_and_sets, inserted] =
-+        policy_set_overlaps.insert({it->second, {}});
-+    site_and_sets->second.insert(policy_set_index);
-+  }
-+}
-+
- }  // namespace
- 
- FirstPartySetsLoader::FirstPartySetsLoader(
-@@ -89,7 +121,7 @@ void FirstPartySetsLoader::SetManuallySpecifiedSet(
-   manually_specified_set_ = {CanonicalizeSet(base::SplitString(
-       flag_value, ",", base::TRIM_WHITESPACE, base::SPLIT_WANT_NONEMPTY))};
-   UmaHistogramTimes(
--      "Cookie.FirstPartySets.InitializationDuration.ReadCommandLineSet",
-+      "Cookie.FirstPartySets.InitializationDuration.ReadCommandLineSet2",
-       construction_timer_.Elapsed());
- 
-   MaybeFinishLoading();
-@@ -127,7 +159,7 @@ void FirstPartySetsLoader::OnReadSetsFile(const std::string& raw_sets) {
- 
-   component_sets_parse_progress_ = Progress::kFinished;
-   UmaHistogramTimes(
--      "Cookie.FirstPartySets.InitializationDuration.ReadComponentSets",
-+      "Cookie.FirstPartySets.InitializationDuration.ReadComponentSets2",
-       construction_timer_.Elapsed());
-   MaybeFinishLoading();
- }
-@@ -144,33 +176,141 @@ void FirstPartySetsLoader::DisposeFile(base::File sets_file) {
-   }
- }
- 
-+std::vector<FirstPartySetsLoader::SingleSet>
-+FirstPartySetsLoader::NormalizeAdditionSets(
-+    const FlattenedSets& existing_sets,
-+    const std::vector<SingleSet>& addition_sets) {
-+  // Create a mapping from an owner site in `existing_sets` to all policy sets
-+  // that intersect with the set that it owns.
-+  base::flat_map<net::SchemefulSite, base::flat_set<size_t>>
-+      policy_set_overlaps;
-+  for (size_t set_idx = 0; set_idx < addition_sets.size(); set_idx++) {
-+    const net::SchemefulSite& owner = addition_sets[set_idx].first;
-+    AddIfPolicySetOverlaps(owner, set_idx, existing_sets, policy_set_overlaps);
-+    for (const net::SchemefulSite& member : addition_sets[set_idx].second) {
-+      AddIfPolicySetOverlaps(member, set_idx, existing_sets,
-+                             policy_set_overlaps);
-+    }
-+  }
-+
-+  AdditionOverlapsUnionFind union_finder(addition_sets.size());
-+  for (auto& [public_site, policy_set_indices] : policy_set_overlaps) {
-+    // Union together all overlapping policy sets to determine which one will
-+    // take ownership.
-+    for (size_t representative : policy_set_indices) {
-+      union_finder.Union(*policy_set_indices.begin(), representative);
-+    }
-+  }
-+
-+  // The union-find data structure now knows which policy set should be given
-+  // the role of representative for each entry in policy_set_overlaps.
-+  // AdditionOverlapsUnionFind::SetsMapping returns a map from representative
-+  // index to list of its children.
-+  std::vector<SingleSet> normalized_additions;
-+  for (auto& [rep, children] : union_finder.SetsMapping()) {
-+    SingleSet normalized = addition_sets[rep];
-+    for (size_t child_set_idx : children) {
-+      // Update normalized to absorb the child_set_idx-th addition set.
-+      const SingleSet& child_set = addition_sets[child_set_idx];
-+      normalized.second.insert(child_set.first);
-+      normalized.second.insert(child_set.second.begin(),
-+                               child_set.second.end());
-+    }
-+    normalized_additions.push_back(normalized);
-+  }
-+  return normalized_additions;
-+}
-+
- void FirstPartySetsLoader::ApplyManuallySpecifiedSet() {
-   DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
--  DCHECK_EQ(component_sets_parse_progress_, Progress::kFinished);
--  DCHECK(manually_specified_set_.has_value());
-+  DCHECK(HasAllInputs());
-   if (!manually_specified_set_.value().has_value())
-     return;
-+  ApplyReplacementOverrides({manually_specified_set_->value()});
-+  RemoveAllSingletons();
-+}
-+
-+void FirstPartySetsLoader::ApplyReplacementOverrides(
-+    const std::vector<SingleSet>& override_sets) {
-+  DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
-+  DCHECK(HasAllInputs());
-+
-+  base::flat_set<net::SchemefulSite> all_override_sites =
-+      FlattenSingleSetList(override_sets);
-+
-+  // Erase the intersection between |sets_| and the list of |override_sets| and
-+  // any members whose owner was in the intersection.
-+  base::EraseIf(
-+      sets_, [&all_override_sites](
-+                 const std::pair<net::SchemefulSite, net::SchemefulSite>& p) {
-+        return all_override_sites.contains(p.first) ||
-+               all_override_sites.contains(p.second);
-+      });
-+
-+  // Next, we must add each site in the override_sets to |sets_|.
-+  for (auto& [owner, members] : override_sets) {
-+    sets_.emplace(owner, owner);
-+    for (const net::SchemefulSite& member : members) {
-+      sets_.emplace(member, owner);
-+    }
-+  }
-+}
-+
-+void FirstPartySetsLoader::ApplyAdditionOverrides(
-+    const std::vector<SingleSet>& new_sets) {
-+  DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
-+  DCHECK(HasAllInputs());
-+
-+  if (new_sets.empty())
-+    return;
- 
--  const net::SchemefulSite& manual_owner =
--      manually_specified_set_.value()->first;
--  const base::flat_set<net::SchemefulSite>& manual_members =
--      manually_specified_set_.value()->second;
-+  std::vector<SingleSet> normalized_additions =
-+      NormalizeAdditionSets(sets_, new_sets);
- 
--  const auto was_manually_provided =
--      [&manual_members, &manual_owner](const net::SchemefulSite& site) {
--        return site == manual_owner || manual_members.contains(site);
--      };
-+  FlattenedSets flattened_additions;
-+  for (const auto& [owner, members] : normalized_additions) {
-+    for (const net::SchemefulSite& member : members)
-+      flattened_additions.emplace(member, owner);
-+    flattened_additions.emplace(owner, owner);
-+  }
- 
--  // Erase the intersection between the manually-specified set and the
--  // CU-supplied set, and any members whose owner was in the intersection.
--  base::EraseIf(sets_, [&was_manually_provided](const auto& p) {
--    return was_manually_provided(p.first) || was_manually_provided(p.second);
--  });
-+  // Identify intersections between addition sets and existing sets. This will
-+  // be used to reparent existing sets if they intersect with an addition set.
-+  //
-+  // Since we reparent every member of an existing set (regardless of whether
-+  // the intersection was via one of its members or its owner), we just keep
-+  // track of the set itself, via its owner.
-+  base::flat_map<net::SchemefulSite, net::SchemefulSite> owners_in_intersection;
-+  for (const auto& [site, owner] : flattened_additions) {
-+    // Found an overlap with an existing set. Add the existing owner to the
-+    // map.
-+    if (auto it = sets_.find(site); it != sets_.end()) {
-+      owners_in_intersection[it->second] = owner;
-+    }
-+  }
-+
-+  // Update the (site, owner) mappings in sets_ such that if owner is in the
-+  // intersection, then the site is mapped to owners_in_intersection[owner].
-+  //
-+  // This reparents existing sets to their owner given by the normalized
-+  // addition sets.
-+  for (auto& [site, owner] : sets_) {
-+    if (auto owner_entry = owners_in_intersection.find(owner);
-+        owner_entry != owners_in_intersection.end()) {
-+      owner = owner_entry->second;
-+    }
-+  }
- 
--  // Now remove singleton sets. We already removed any sites that were part
--  // of the intersection, or whose owner was part of the intersection. This
--  // leaves sites that *are* owners, which no longer have any (other)
--  // members.
-+  // Since the intersection between sets_ and flattened_additions has already
-+  // been updated above, we can insert flattened_additions into sets_ without
-+  // affecting any existing mappings in sets_.
-+  sets_.insert(flattened_additions.begin(), flattened_additions.end());
-+}
-+
-+void FirstPartySetsLoader::RemoveAllSingletons() {
-+  DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
-+  // Now remove singleton sets, which are sets that just contain sites that
-+  // *are* owners, but no longer have any (other) members.
-   std::set<net::SchemefulSite> owners_with_members;
-   for (const auto& it : sets_) {
-     if (it.first != it.second)
-@@ -179,21 +319,29 @@ void FirstPartySetsLoader::ApplyManuallySpecifiedSet() {
-   base::EraseIf(sets_, [&owners_with_members](const auto& p) {
-     return p.first == p.second && !base::Contains(owners_with_members, p.first);
-   });
-+}
- 
--  // Next, we must add the manually-added set to the parsed value.
--  for (const net::SchemefulSite& member : manual_members) {
--    sets_.emplace(member, manual_owner);
--  }
--  sets_.emplace(manual_owner, manual_owner);
-+void FirstPartySetsLoader::ApplyAllPolicyOverrides() {
-+  DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
-+  DCHECK(HasAllInputs());
-+  ApplyReplacementOverrides(policy_overrides_.replacements);
-+  ApplyAdditionOverrides(policy_overrides_.additions);
-+  RemoveAllSingletons();
- }
- 
- void FirstPartySetsLoader::MaybeFinishLoading() {
-   DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
--  if (component_sets_parse_progress_ != Progress::kFinished ||
--      !manually_specified_set_.has_value())
-+  if (!HasAllInputs())
-     return;
-   ApplyManuallySpecifiedSet();
-+  ApplyAllPolicyOverrides();
-   std::move(on_load_complete_).Run(std::move(sets_));
- }
- 
--}  // namespace content
-+bool FirstPartySetsLoader::HasAllInputs() const {
-+  DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
-+  return component_sets_parse_progress_ == Progress::kFinished &&
-+         manually_specified_set_.has_value();
-+}
-+
-+}  // namespace content
-\ No newline at end of file
-diff --git a/content/browser/first_party_sets/first_party_sets_loader.h b/content/browser/first_party_sets/first_party_sets_loader.h
-index c27d2300c4c3533df91a8e814e89827bbd7d72ae..8588fe5f9922b36c9fe8e16ac16d02ccf00c8723 100644
---- a/content/browser/first_party_sets/first_party_sets_loader.h
-+++ b/content/browser/first_party_sets/first_party_sets_loader.h
-@@ -57,6 +57,19 @@ class CONTENT_EXPORT FirstPartySetsLoader {
-   // Close the file on thread pool that allows blocking.
-   void DisposeFile(base::File sets_file);
- 
-+  // Handles addition sets which overlap by intersecting with the same existing
-+  // set, known as a transitive-overlap.
-+  //
-+  // This uses a Union-Find algorithm to select the earliest-provided addition
-+  // set as the representative of all other addition sets that
-+  // transitively-overlap with it.
-+  //
-+  // The "earliest-provided" tie-breaker is determined using a set's index in
-+  // `addition_sets`.
-+  static std::vector<SingleSet> NormalizeAdditionSets(
-+      const FlattenedSets& existing_sets,
-+      const std::vector<SingleSet>& addition_sets);
-+
-  private:
-   // Parses the contents of `raw_sets` as a collection of First-Party Set
-   // declarations, and assigns to `sets_`.
-@@ -67,10 +80,42 @@ class CONTENT_EXPORT FirstPartySetsLoader {
-   // `SetManuallySpecifiedSet`, and the public sets via `SetComponentSets`.
-   void ApplyManuallySpecifiedSet();
- 
-+  // Removes the intersection between `sets_` and `override_sets` from the
-+  // `sets_` member variable, and then adds the `override_sets` into `sets_`.
-+  void ApplyReplacementOverrides(const std::vector<SingleSet>& override_sets);
-+
-+  // Updates the intersection between `sets_` and `override_sets` within the
-+  // `sets_` member variable, and then adds the `override_sets` into
-+  // `sets_`.
-+  //
-+  // The applied update ensures that invariants of First-Party Sets are
-+  // maintained, and that all sets in sets_ are disjoint.
-+  //
-+  // This will add in the `override_sets` into `sets_` without removing
-+  // any existing sites from the list of First-Party Sets.
-+  void ApplyAdditionOverrides(const std::vector<SingleSet>& override_sets);
-+
-+  // Removes all singletons (owners that have no members) from sets_.
-+  void RemoveAllSingletons();
-+
-+  // Applies the First-Party Sets overrides provided by policy.
-+  //
-+  // Must not be called until the loader has already received the public sets
-+  // via `SetComponentSets` and the CLI-provided sets have been applied to
-+  // `sets_`.
-+  //
-+  // Applies "Replacement" overrides before applying "Addition" overrides.
-+  void ApplyAllPolicyOverrides();
-+
-   // Checks the required inputs have been received, and if so, invokes the
-   // callback `on_load_complete_`, after merging sets appropriately.
-   void MaybeFinishLoading();
- 
-+  // Returns true if all sources are present (Component Updater sets, CLI set,
-+  // and Policy sets). The Policy sets are provided at construction time, so
-+  // this effectively checks that the other two sources are ready.
-+  bool HasAllInputs() const;
-+
-   // Represents the mapping of site -> site, where keys are members of sets,
-   // and values are owners of the sets (explicitly including an entry of owner
-   // -> owner).
-@@ -117,4 +162,4 @@ class CONTENT_EXPORT FirstPartySetsLoader {
- 
- }  // namespace content
- 
--#endif  // CONTENT_BROWSER_FIRST_PARTY_SETS_FIRST_PARTY_SETS_LOADER_H_
-+#endif  // CONTENT_BROWSER_FIRST_PARTY_SETS_FIRST_PARTY_SETS_LOADER_H_
-\ No newline at end of file
-diff --git a/content/public/browser/content_browser_client.cc b/content/public/browser/content_browser_client.cc
-index 16fb4946cb3ea2d097e8ed05bb340cc3f0782ed6..b751bf43d41a149579047faeec958646ecc3a5e0 100644
---- a/content/public/browser/content_browser_client.cc
-+++ b/content/public/browser/content_browser_client.cc
-@@ -1327,6 +1327,10 @@ bool ContentBrowserClient::IsFirstPartySetsEnabled() {
-   return base::FeatureList::IsEnabled(features::kFirstPartySets);
- }
- 
-+bool ContentBrowserClient::WillProvidePublicFirstPartySets() {
-+  return false;
-+}
-+
- base::Value::Dict ContentBrowserClient::GetFirstPartySetsOverrides() {
-   return base::Value::Dict();
- }
-diff --git a/content/public/browser/content_browser_client.h b/content/public/browser/content_browser_client.h
-index 4db1e6c2dbea27249ca15d5660b7fcd8c6736ad1..8aac2a95a3ac66f0b0c180f46ec29ca7341a1d4c 100644
---- a/content/public/browser/content_browser_client.h
-+++ b/content/public/browser/content_browser_client.h
-@@ -2227,6 +2227,16 @@ class CONTENT_EXPORT ContentBrowserClient {
-   // should not change in a single browser session.
-   virtual bool IsFirstPartySetsEnabled();
- 
-+  // Returns true iff the embedder will provide a list of First-Party Sets via
-+  // content::FirstPartySetsHandler::SetPublicFirstPartySets during startup, at
-+  // some point. If `IsFirstPartySetsEnabled()` returns false, this method will
-+  // still be called, but its return value will be ignored.
-+  //
-+  // If this method returns false but `IsFirstPartySetsEnabled()` returns true
-+  // (e.g. in tests), an empty list will be used instead of waiting for the
-+  // embedder to call content::FirstPartySetsHandler::SetPublicFirstPartySets.
-+  virtual bool WillProvidePublicFirstPartySets();
-+
-   // Returns a base::Value::Dict containing the value of the First-Party Sets
-   // Overrides enterprise policy.
-   // If the policy was not present or it was invalid, this returns an empty
-diff --git a/content/public/browser/first_party_sets_handler.h b/content/public/browser/first_party_sets_handler.h
-index 8bd62717732a4afe1e8c02fd5ceb39bd1790e3e0..3ff5dea5612fe3329c7c612818f1436a980ea9e3 100644
---- a/content/public/browser/first_party_sets_handler.h
-+++ b/content/public/browser/first_party_sets_handler.h
-@@ -72,7 +72,9 @@ class CONTENT_EXPORT FirstPartySetsHandler {
-   //
-   // Embedder should call this method as early as possible during browser
-   // startup if First-Party Sets are enabled, since no First-Party Sets queries
--  // are answered until initialization is complete.
-+  // are answered until initialization is complete. Must not be called if
-+  // `ContentBrowserClient::WillProvidePublicFirstPartySets` returns false or
-+  // `ContentBrowserClient::IsFrstpartySetsEnabled` returns false.
-   virtual void SetPublicFirstPartySets(base::File sets_file) = 0;
- 
-   // Resets the state on the instance for testing.
-diff --git a/content/shell/browser/shell_browser_main_parts.cc b/content/shell/browser/shell_browser_main_parts.cc
-index 89040432c9f56d8285d8e9f59e1e0280abc25199..bd412789695f49253f67f237b2a92b8dee298e7a 100644
---- a/content/shell/browser/shell_browser_main_parts.cc
-+++ b/content/shell/browser/shell_browser_main_parts.cc
-@@ -189,8 +189,6 @@ int ShellBrowserMainParts::PreMainMessageLoopRun() {
-   net::NetModule::SetResourceProvider(PlatformResourceProvider);
-   ShellDevToolsManagerDelegate::StartHttpHandler(browser_context_.get());
-   InitializeMessageLoopContext();
--  // The First-Party Sets feature always expects to be initialized
--  FirstPartySetsHandler::GetInstance()->SetPublicFirstPartySets(base::File());
-   return 0;
- }
- 

patches/chromium/fix_expose_decrementcapturercount_in_web_contents_impl.patch

@@ -8,7 +8,7 @@ we invoke it in order to expose contents.decrementCapturerCount([stayHidden, sta
 to users. We should try to upstream this.
 
 diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h
-index 2a29af8d9aa67768ec521e87190174397a25b722..7a5ce3038427756c26e38c91c5b3211a9a8999dd 100644
+index 07355cb194bd429a693e587072d11432d6c0888a..b74b4209931c6acd6bc2e93a100c3e65a834ead9 100644
 --- a/content/browser/web_contents/web_contents_impl.h
 +++ b/content/browser/web_contents/web_contents_impl.h
 @@ -1828,7 +1828,7 @@ class CONTENT_EXPORT WebContentsImpl : public WebContents,

patches/chromium/fix_mac_build_with_enable_plugins_false.patch

@@ -1,119 +0,0 @@
-From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
-From: Lei Zhang <thestig@chromium.org>
-Date: Thu, 23 Jun 2022 17:54:12 +0000
-Subject: Fix Mac build with enable_plugins=false.
-
-Remove spurious includes of plugin headers, and add appropriate #ifs.
-
-Bug: 1027360
-Change-Id: I445252f5de14dff8e89ab371429a24ad3e57ca97
-Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3719213
-Reviewed-by: Robert Sesek <rsesek@chromium.org>
-Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
-Commit-Queue: Lei Zhang <thestig@chromium.org>
-Cr-Commit-Position: refs/heads/main@{#1017248}
-
-diff --git a/chrome/browser/app_controller_mac.mm b/chrome/browser/app_controller_mac.mm
-index 480244fb50f636f519485693b8d1a4cf5033c3b0..f426e30ff371c35382512d7ec7846ca6cf58515e 100644
---- a/chrome/browser/app_controller_mac.mm
-+++ b/chrome/browser/app_controller_mac.mm
-@@ -108,7 +108,6 @@
- #include "components/prefs/pref_service.h"
- #include "components/sessions/core/tab_restore_service.h"
- #include "content/public/browser/download_manager.h"
--#include "content/public/browser/plugin_service.h"
- #include "extensions/browser/extension_registry.h"
- #include "extensions/browser/extension_system.h"
- #include "net/base/filename_util.h"
-diff --git a/content/browser/sandbox_mac_unittest.mm b/content/browser/sandbox_mac_unittest.mm
-index 05e9b29d7a039094fb6fd63fb8b152439f089d41..b860c1e54f0ced814fb269087924d2f695f816f3 100644
---- a/content/browser/sandbox_mac_unittest.mm
-+++ b/content/browser/sandbox_mac_unittest.mm
-@@ -30,6 +30,7 @@
- #include "content/browser/sandbox_parameters_mac.h"
- #include "content/common/mac/font_loader.h"
- #include "crypto/openssl_util.h"
-+#include "ppapi/buildflags/buildflags.h"
- #include "sandbox/mac/seatbelt.h"
- #include "sandbox/mac/seatbelt_exec.h"
- #include "sandbox/policy/mac/sandbox_mac.h"
-@@ -93,7 +94,9 @@ void ExecuteInAllSandboxTypes(const std::string& multiprocess_main,
-         sandbox::mojom::Sandbox::kCdm,
-         sandbox::mojom::Sandbox::kGpu,
-         sandbox::mojom::Sandbox::kNaClLoader,
-+#if BUILDFLAG(ENABLE_PLUGINS)
-         sandbox::mojom::Sandbox::kPpapi,
-+#endif
-         sandbox::mojom::Sandbox::kPrintBackend,
-         sandbox::mojom::Sandbox::kPrintCompositor,
-         sandbox::mojom::Sandbox::kRenderer,
-diff --git a/content/browser/sandbox_parameters_mac.mm b/content/browser/sandbox_parameters_mac.mm
-index 76a22420f605994ebe0a7ffa9a7f2a0535c2440f..cf8b251180177c3ea4f8ddb2450f0483d201ba2b 100644
---- a/content/browser/sandbox_parameters_mac.mm
-+++ b/content/browser/sandbox_parameters_mac.mm
-@@ -20,7 +20,6 @@
- #include "base/strings/sys_string_conversions.h"
- #include "base/system/sys_info.h"
- #include "content/public/browser/content_browser_client.h"
--#include "content/public/browser/plugin_service.h"
- #include "content/public/common/content_client.h"
- #include "content/public/common/content_features.h"
- #include "content/public/common/content_switches.h"
-@@ -34,6 +33,7 @@
- #include "third_party/abseil-cpp/absl/types/optional.h"
- 
- #if BUILDFLAG(ENABLE_PLUGINS)
-+#include "content/public/browser/plugin_service.h"
- #include "content/public/common/pepper_plugin_info.h"
- #endif
- 
-@@ -229,11 +229,11 @@ void SetupSandboxParameters(sandbox::mojom::Sandbox sandbox_type,
-     case sandbox::mojom::Sandbox::kNetwork:
-       SetupNetworkSandboxParameters(client);
-       break;
--    case sandbox::mojom::Sandbox::kPpapi:
- #if BUILDFLAG(ENABLE_PLUGINS)
-+    case sandbox::mojom::Sandbox::kPpapi:
-       SetupPPAPISandboxParameters(client);
--#endif
-       break;
-+#endif
-     case sandbox::mojom::Sandbox::kNoSandbox:
-       CHECK(false) << "Unhandled parameters for sandbox_type "
-                    << static_cast<int>(sandbox_type);
-diff --git a/sandbox/policy/mac/sandbox_mac.mm b/sandbox/policy/mac/sandbox_mac.mm
-index 34f8b003c96b9fff00b666ae184b5076e5d6fd45..11392b99ecad98f2cf39e67d545fe1947ede1593 100644
---- a/sandbox/policy/mac/sandbox_mac.mm
-+++ b/sandbox/policy/mac/sandbox_mac.mm
-@@ -12,6 +12,7 @@
- #include "base/files/scoped_file.h"
- #include "base/logging.h"
- #include "base/posix/eintr_wrapper.h"
-+#include "ppapi/buildflags/buildflags.h"
- #include "printing/buildflags/buildflags.h"
- #include "sandbox/policy/mac/audio.sb.h"
- #include "sandbox/policy/mac/cdm.sb.h"
-@@ -69,9 +70,11 @@
-     case sandbox::mojom::Sandbox::kNetwork:
-       profile += kSeatbeltPolicyString_network;
-       break;
-+#if BUILDFLAG(ENABLE_PLUGINS)
-     case sandbox::mojom::Sandbox::kPpapi:
-       profile += kSeatbeltPolicyString_ppapi;
-       break;
-+#endif
- #if BUILDFLAG(ENABLE_PRINTING)
-     case sandbox::mojom::Sandbox::kPrintBackend:
-       profile += kSeatbeltPolicyString_print_backend;
-diff --git a/ui/views_content_client/views_content_client_main_parts_mac.mm b/ui/views_content_client/views_content_client_main_parts_mac.mm
-index 044600ad464fc48a805bf3e47811808983d43fef..df23f797e4f0898d9dc7742e05d286f540bfdacb 100644
---- a/ui/views_content_client/views_content_client_main_parts_mac.mm
-+++ b/ui/views_content_client/views_content_client_main_parts_mac.mm
-@@ -12,7 +12,6 @@
- #include "base/mac/scoped_nsobject.h"
- #include "base/path_service.h"
- #include "content/public/browser/context_factory.h"
--#include "content/public/browser/plugin_service.h"
- #include "content/public/common/content_paths.h"
- #include "content/public/common/result_codes.h"
- #include "content/shell/browser/shell_application_mac.h"