Compare commits

...

3 Commits

Author SHA1 Message Date
Keeley Hammond
4b9d5edeb6 chore: consolidate patches 2024-02-28 10:17:46 -08:00
Keeley Hammond
dfa24cbced feat: add original revert SameParty cookie attribute removal 2024-02-28 01:59:20 -08:00
Keeley Hammond
9fa383345c fix: revert SameParty cookie attribute removal 2024-02-28 00:36:08 -08:00
3 changed files with 6103 additions and 2 deletions

View File

@@ -131,3 +131,4 @@ fix_suppress_clang_-wimplicit-const-int-float-conversion_in.patch
cherry-pick-e7ffe20ebfac.patch
fix_getcursorscreenpoint_wrongly_returns_0_0.patch
fix_add_support_for_skipping_first_2_no-op_refreshes_in_thumb_cap.patch
revert_same_party_cookie_attribute_removal.patch

File diff suppressed because it is too large Load Diff

View File

@@ -308,6 +308,9 @@ v8::Local<v8::Promise> Cookies::Set(v8::Isolate* isolate,
}
bool secure = details.FindBool("secure").value_or(
same_site == net::CookieSameSite::NO_RESTRICTION);
bool same_party =
details.FindBool("sameParty")
.value_or(secure && same_site != net::CookieSameSite::STRICT_MODE);
GURL url(url_string ? *url_string : "");
if (!url.is_valid()) {
@@ -323,8 +326,8 @@ v8::Local<v8::Promise> Cookies::Set(v8::Isolate* isolate,
path ? *path : "", ParseTimeProperty(details.FindDouble("creationDate")),
ParseTimeProperty(details.FindDouble("expirationDate")),
ParseTimeProperty(details.FindDouble("lastAccessDate")), secure,
http_only, same_site, net::COOKIE_PRIORITY_DEFAULT, std::nullopt,
&status);
http_only, same_site, net::COOKIE_PRIORITY_DEFAULT, same_party,
std::nullopt, &status);
if (!canonical_cookie || !canonical_cookie->IsCanonical()) {
promise.RejectWithErrorMessage(InclusionStatusToString(