mirror of
https://github.com/electron/electron.git
synced 2026-05-02 03:00:22 -04:00
* build: add oxfmt for code formatting and import sorting
Adds oxfmt as a devDependency alongside oxlint and wires it into the
lint pipeline. The .oxfmtrc.json config matches Electron's current JS
style (single quotes, semicolons, 2-space indent, trailing commas off,
printWidth 100) and configures sortImports with custom groups that
mirror the import/order pathGroups previously enforced by ESLint:
@electron/internal, @electron/*, and {electron,electron/**} each get
their own ordered group ahead of external modules.
- `yarn lint:fmt` runs `oxfmt --check` over JS/TS sources and is
chained into `yarn lint` so CI enforces it automatically.
- `yarn format` runs `oxfmt --write` for local fix-up.
- lint-staged invokes `oxfmt --write` on staged .js/.ts/.mjs/.cjs
files before oxlint, so formatting is applied at commit time.
The next commit applies the formatter to the existing codebase so the
check actually passes.
* chore: apply oxfmt formatting to JS and TS sources
Runs `yarn format` across lib/, spec/, script/, build/, default_app/,
and npm/ to bring the codebase in line with the .oxfmtrc.json settings
added in the previous commit. This is a pure formatting pass: import
statements are sorted into the groups defined by the config, method
chains longer than printWidth are broken, single-quoted strings
containing apostrophes are switched to double quotes, and a handful of
single-statement `if` bodies are re-wrapped and get braces added by
`oxlint --fix` to satisfy the `curly: multi-line` rule.
No behavior changes.
123 lines
4.5 KiB
TypeScript
123 lines
4.5 KiB
TypeScript
import timers = require('timers');
|
|
import * as util from 'util';
|
|
|
|
import type * as stream from 'stream';
|
|
|
|
type AnyFn = (...args: any[]) => any;
|
|
|
|
// setImmediate and process.nextTick makes use of uv_check and uv_prepare to
|
|
// run the callbacks, however since we only run uv loop on requests, the
|
|
// callbacks wouldn't be called until something else activated the uv loop,
|
|
// which would delay the callbacks for arbitrary long time. So we should
|
|
// initiatively activate the uv loop once setImmediate and process.nextTick is
|
|
// called.
|
|
const wrapWithActivateUvLoop = function <T extends AnyFn>(func: T): T {
|
|
return wrap(func, function (func) {
|
|
return function (this: any, ...args: any[]) {
|
|
process.activateUvLoop();
|
|
return func.apply(this, args);
|
|
};
|
|
}) as T;
|
|
};
|
|
|
|
/**
|
|
* Casts to any below for func are due to Typescript not supporting symbols
|
|
* in index signatures
|
|
*
|
|
* Refs: https://github.com/Microsoft/TypeScript/issues/1863
|
|
*/
|
|
function wrap<T extends AnyFn>(func: T, wrapper: (fn: AnyFn) => T) {
|
|
const wrapped = wrapper(func);
|
|
if ((func as any)[util.promisify.custom]) {
|
|
(wrapped as any)[util.promisify.custom] = wrapper((func as any)[util.promisify.custom]);
|
|
}
|
|
return wrapped;
|
|
}
|
|
|
|
// process.nextTick and setImmediate make use of uv_check and uv_prepare to
|
|
// run the callbacks, however since we only run uv loop on requests, the
|
|
// callbacks wouldn't be called until something else activated the uv loop,
|
|
// which would delay the callbacks for arbitrary long time. So we should
|
|
// initiatively activate the uv loop once process.nextTick and setImmediate is
|
|
// called.
|
|
process.nextTick = wrapWithActivateUvLoop(process.nextTick);
|
|
global.setImmediate = timers.setImmediate = wrapWithActivateUvLoop(timers.setImmediate);
|
|
global.clearImmediate = timers.clearImmediate;
|
|
|
|
// setTimeout needs to update the polling timeout of the event loop, when
|
|
// called under Chromium's event loop the node's event loop won't get a chance
|
|
// to update the timeout, so we have to force the node's event loop to
|
|
// recalculate the timeout in the process.
|
|
timers.setTimeout = wrapWithActivateUvLoop(timers.setTimeout);
|
|
timers.setInterval = wrapWithActivateUvLoop(timers.setInterval);
|
|
|
|
// Update the global version of the timer apis to use the above wrapper
|
|
// only in the process that runs node event loop alongside chromium
|
|
// event loop. We skip renderer with nodeIntegration here because node globals
|
|
// are deleted in these processes, see renderer/init.js for reference.
|
|
if (process.type === 'browser' || process.type === 'utility') {
|
|
global.setTimeout = timers.setTimeout;
|
|
global.setInterval = timers.setInterval;
|
|
}
|
|
|
|
if (process.platform === 'win32') {
|
|
// Always returns EOF for stdin stream.
|
|
const { Readable } = require('stream') as typeof stream;
|
|
const stdin = new Readable();
|
|
stdin.push(null);
|
|
Object.defineProperty(process, 'stdin', {
|
|
configurable: false,
|
|
enumerable: true,
|
|
get() {
|
|
return stdin;
|
|
}
|
|
});
|
|
}
|
|
|
|
const Module = require('module') as NodeJS.ModuleInternal;
|
|
|
|
// Make a fake Electron module that we will insert into the module cache
|
|
const makeElectronModule = (name: string) => {
|
|
const electronModule = new Module('electron', null);
|
|
electronModule.id = 'electron';
|
|
electronModule.loaded = true;
|
|
electronModule.filename = name;
|
|
Object.defineProperty(electronModule, 'exports', {
|
|
get: () => require('electron')
|
|
});
|
|
Module._cache[name] = electronModule;
|
|
};
|
|
|
|
makeElectronModule('electron');
|
|
makeElectronModule('electron/common');
|
|
if (process.type === 'browser') {
|
|
makeElectronModule('electron/main');
|
|
} else if (process.type === 'renderer') {
|
|
makeElectronModule('electron/renderer');
|
|
} else if (process.type === 'utility') {
|
|
makeElectronModule('electron/utility');
|
|
}
|
|
|
|
const originalResolveFilename = Module._resolveFilename;
|
|
|
|
// 'electron/{common,main,renderer,utility}' are module aliases
|
|
// of the 'electron' module for TypeScript purposes, i.e., the types for
|
|
// 'electron/main' consist of only main process modules, etc. It is intentional
|
|
// that these can be `require()`-ed from both the main process as well as the
|
|
// renderer process regardless of the names, they're superficial for TypeScript
|
|
// only.
|
|
const electronModuleNames = new Set([
|
|
'electron',
|
|
'electron/main',
|
|
'electron/renderer',
|
|
'electron/common',
|
|
'electron/utility'
|
|
]);
|
|
Module._resolveFilename = function (request, parent, isMain, options) {
|
|
if (electronModuleNames.has(request)) {
|
|
return 'electron';
|
|
} else {
|
|
return originalResolveFilename(request, parent, isMain, options);
|
|
}
|
|
};
|