mirror of
https://github.com/electron/electron.git
synced 2026-01-08 07:04:01 -05:00
* chore: bump chromium in DEPS to 144.0.7543.0 * Pass PipScreenCaptureCoordinatorProxy to ScreenCaptureKitDeviceMac https://chromium-review.googlesource.com/c/chromium/src/+/7157590 * chore: update patches * chore: update filenames.libcxx.gni * 7142359: Spanification of process_singleton_posix.cc https: //chromium-review.googlesource.com/c/chromium/src/+/7142359 Co-Authored-By: Charles Kerr <70381+ckerr@users.noreply.github.com> * Move logging::LoggingSettings to base/logging/logging_settings.h https://chromium-review.googlesource.com/c/chromium/src/+/7173024 * chore: bump chromium in DEPS to 144.0.7545.0 * 7159368: update PluginService API for sync GetPlugins Upstream removed async PluginService APIs: - GetPluginsAsync() removed, use synchronous GetPlugins() - RegisterInternalPlugin() now takes single argument (remove add_at_beginning) - RefreshPlugins() removed entirely Updated ElectronPluginInfoHostImpl to use synchronous plugin loading and simplified ElectronBrowserMainParts internal plugin registration. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7159368 Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7159328 Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7159056 (cherry picked from commit88cdf50b0a) * 7159184: add missing base/files/file_path.h include Add explicit include for base/files/file_path.h in electron_browser_context.h. After removal of superfluous Mojo includes from content headers, base::FilePath is no longer transitively included via content/public/browser/browser_context.h. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7159184 (cherry picked from commit6ca8ea03ec) * 7126479: add ShouldForceRefreshTextCheckService parameter to SpellCheckClient Upstream added a force-refresh parameter to WebTextCheckClient::RequestCheckingOfText to bypass spell check cache. Add the new ShouldForceRefreshTextCheckService parameter to SpellCheckClient's override (currently unused in Electron). Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7126479 (cherry picked from commit879c0401c4) * 7083663: remove fingerprinting_protection_ruleset_service override Upstream deleted external references to Fingerprinting Protection Filter (FPF) component. Remove the fingerprinting_protection_ruleset_service() override from BrowserProcessImpl as the method no longer exists in the base class. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7083663 (cherry picked from commit8350d152f9) * 7155287: implement WebContentsView::GetSize and Resize Upstream delegated WebContents::GetSize() and Resize() to WebContentsView, making them pure virtual. Add const qualifier to GetSize() and implement the Resize() override in OffScreenWebContentsView (no-op for offscreen). Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7155287 (cherry picked from commit084eaa568e) * 7184238: add OnUnconfirmedTapConvertedToTap override Upstream added OnUnconfirmedTapConvertedToTap as a pure virtual method to RenderWidgetHostViewBase to inform root view when child frame converts an unconfirmed tap. Add empty override for offscreen rendering. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7184238 (cherry picked from commitef03400d9a) * 7143586: add widget parameter to OnCommandsChanged GlobalAcceleratorListener::OnCommandsChanged gained a gfx::AcceleratedWidget parameter for window association in the GlobalShortcutListenerLinux implementation. Pass gfx::kNullAcceleratedWidget for Electron's usage. Ref: : Pass parent handle to GlobalAcceleratorListenerLinux::BindShortcuts | https://chromium-review.googlesource.com/c/chromium/src/+/7143586 (cherry picked from commit38306e2bfc) Co-Authored-By: Samuel Attard <MarshallOfSound@users.noreply.github.com> * chore: update patches Co-Authored-By: Samuel Attard <MarshallOfSound@users.noreply.github.com> * chore: bump chromium in DEPS to 144.0.7547.0 * chore: update patches * 7189232: Add support for UnownedUserData in GlobalFeatures https: //chromium-review.googlesource.com/c/chromium/src/+/7189232 * Refactor: Use std::u16string for extension load error messages https://chromium-review.googlesource.com/c/chromium/src/+/7185844 * fixup Add support for UnownedUserData in GlobalFeatures * 7165650: Remove ResourceContext https://chromium-review.googlesource.com/c/chromium/src/+/7165650 * fixup BUILD.gn for lint * 7202164: Reland "Reland "Remove GenericScopedHandle:IsValid"" https://chromium-review.googlesource.com/c/chromium/src/+/7202164 * advance deprecation of v8::ReturnValue<void>::Set(Local<S>). 7168624: [runtime][api] Relax requirements for setter/definer/deleter callbacks | https://chromium-review.googlesource.com/c/v8/v8/+/7168624 * fixup advance deprecation of v8::ReturnValue<void>::Set(Local<S>) * chore: skip setting LPAC ACLs * Revert "chore: skip setting LPAC ACLs" This reverts commite187aec488. * chore: revert Convert to UNSAFE_TODO in sandbox revert https://chromium-review.googlesource.com/c/chromium/src/+/7131661 to see if it fixes the Windows sandbox issue. * Revert "chore: revert Convert to UNSAFE_TODO in sandbox" This reverts commit57afbfefe5. * chore: Revert "Enable network sandbox by default on Windows" see if this fixes the Windows sandbox issue * Enable network sandbox by default on Windows https://chromium-review.googlesource.com/c/chromium/src/+/7204292 * Revert "chore: Revert "Enable network sandbox by default on Windows"" This reverts commit530ab6af82. * fixup! Enable network sandbox by default on Windows | https://chromium-review.googlesource.com/c/chromium/src/+/7204292 * fixup!: Correct flag name, add kLocalNetworkAccessChecks to all platforms --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> Co-authored-by: Charles Kerr <70381+ckerr@users.noreply.github.com> Co-authored-by: Samuel Attard <sattard@anthropic.com> Co-authored-by: Samuel Attard <MarshallOfSound@users.noreply.github.com> Co-authored-by: John Kleinschmidt <kleinschmidtorama@gmail.com> Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
129 lines
4.6 KiB
C++
129 lines
4.6 KiB
C++
// Copyright (c) 2019 GitHub, Inc.
|
|
// Use of this source code is governed by the MIT license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "electron/shell/browser/feature_list.h"
|
|
|
|
#include <string>
|
|
|
|
#include "base/base_switches.h"
|
|
#include "base/command_line.h"
|
|
#include "base/feature_list.h"
|
|
#include "base/metrics/field_trial.h"
|
|
#include "components/spellcheck/common/spellcheck_features.h"
|
|
#include "content/common/features.h"
|
|
#include "content/public/common/content_features.h"
|
|
#include "electron/buildflags/buildflags.h"
|
|
#include "media/base/media_switches.h"
|
|
#include "net/base/features.h"
|
|
#include "printing/buildflags/buildflags.h"
|
|
#include "sandbox/policy/features.h"
|
|
#include "services/network/public/cpp/features.h"
|
|
#include "third_party/blink/public/common/features.h"
|
|
#include "ui/accessibility/ax_features.mojom-features.h"
|
|
|
|
#if BUILDFLAG(IS_MAC)
|
|
#include "device/base/features.h" // nogncheck
|
|
#endif
|
|
|
|
#if BUILDFLAG(ENABLE_PDF_VIEWER)
|
|
#include "pdf/pdf_features.h"
|
|
#endif
|
|
|
|
#if BUILDFLAG(IS_LINUX)
|
|
#include "printing/printing_features.h"
|
|
#endif
|
|
|
|
#if BUILDFLAG(IS_WIN)
|
|
#include "ui/views/views_features.h"
|
|
#endif
|
|
|
|
namespace electron {
|
|
|
|
void InitializeFeatureList() {
|
|
auto* cmd_line = base::CommandLine::ForCurrentProcess();
|
|
auto enable_features =
|
|
cmd_line->GetSwitchValueASCII(::switches::kEnableFeatures);
|
|
auto disable_features =
|
|
cmd_line->GetSwitchValueASCII(::switches::kDisableFeatures);
|
|
// Disable creation of spare renderer process with site-per-process mode,
|
|
// it interferes with our process preference tracking for non sandboxed mode.
|
|
// Can be reenabled when our site instance policy is aligned with chromium
|
|
// when node integration is enabled.
|
|
disable_features +=
|
|
std::string(",") + features::kSpareRendererForSitePerProcess.name +
|
|
// See https://chromium-review.googlesource.com/c/chromium/src/+/6487926
|
|
// this breaks PDFs locally as we don't have GLIC infra enabled.
|
|
std::string(",") + ax::mojom::features::kScreenAIOCREnabled.name +
|
|
// See https://chromium-review.googlesource.com/c/chromium/src/+/6626905
|
|
// Needed so that ElectronBrowserClient::RegisterPendingSiteInstance does
|
|
// not throw a check.
|
|
std::string(", TraceSiteInstanceGetProcessCreation") +
|
|
// See https://chromium-review.googlesource.com/c/chromium/src/+/6910012
|
|
// Needed until we rework some of our logic and checks to enable this
|
|
// properly.
|
|
std::string(",") + network::features::kLocalNetworkAccessChecks.name;
|
|
|
|
#if BUILDFLAG(IS_WIN)
|
|
// Refs https://issues.chromium.org/issues/401996981
|
|
// TODO(deepak1556): Remove this once test added in
|
|
// https://github.com/electron/electron/pull/12904
|
|
// can work without this feature.
|
|
enable_features += std::string(",") +
|
|
views::features::kEnableTransparentHwndEnlargement.name;
|
|
|
|
// See https://chromium-review.googlesource.com/c/chromium/src/+/7204292
|
|
// This feature causes the following sandbox failure on Windows:
|
|
// sandbox\policy\win\sandbox_win.cc:777 Sandbox cannot access executable
|
|
// electron.exe. Check filesystem permissions are valid.
|
|
// See https://bit.ly/31yqMJR.: Access is denied. (0x5)
|
|
disable_features +=
|
|
std::string(",") + sandbox::policy::features::kNetworkServiceSandbox.name;
|
|
#endif
|
|
|
|
#if BUILDFLAG(IS_MAC)
|
|
disable_features +=
|
|
// MacWebContentsOcclusion is causing some odd visibility
|
|
// issues with multiple web contents
|
|
std::string(",") + features::kMacWebContentsOcclusion.name;
|
|
#endif
|
|
|
|
#if BUILDFLAG(ENABLE_PDF_VIEWER)
|
|
// Enable window.showSaveFilePicker api for saving pdf files.
|
|
// Refs https://issues.chromium.org/issues/373852607
|
|
enable_features +=
|
|
std::string(",") + chrome_pdf::features::kPdfUseShowSaveFilePicker.name;
|
|
#endif
|
|
|
|
std::string platform_specific_enable_features =
|
|
EnablePlatformSpecificFeatures();
|
|
if (platform_specific_enable_features.size() > 0) {
|
|
enable_features += std::string(",") + platform_specific_enable_features;
|
|
}
|
|
std::string platform_specific_disable_features =
|
|
DisablePlatformSpecificFeatures();
|
|
if (platform_specific_disable_features.size() > 0) {
|
|
disable_features += std::string(",") + platform_specific_disable_features;
|
|
}
|
|
base::FeatureList::InitInstance(enable_features, disable_features);
|
|
}
|
|
|
|
void InitializeFieldTrials() {
|
|
auto* cmd_line = base::CommandLine::ForCurrentProcess();
|
|
auto force_fieldtrials =
|
|
cmd_line->GetSwitchValueASCII(::switches::kForceFieldTrials);
|
|
|
|
base::FieldTrialList::CreateTrialsFromString(force_fieldtrials);
|
|
}
|
|
|
|
#if !BUILDFLAG(IS_MAC)
|
|
std::string EnablePlatformSpecificFeatures() {
|
|
return "";
|
|
}
|
|
std::string DisablePlatformSpecificFeatures() {
|
|
return "";
|
|
}
|
|
#endif
|
|
|
|
} // namespace electron
|