mirror of
https://github.com/electron/electron.git
synced 2026-04-10 03:01:51 -04:00
* chore: bump chromium in DEPS to 127.0.6526.0
* chore: update network_service_allow_remote_certificate_verification_logic.patch
manually apply patch due to minor upstream shear
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5598454
* chore: update fix_move_autopipsettingshelper_behind_branding_buildflag.patch
No manual changes; patch applied with fuzz 1
* chore: update refactor_expose_file_system_access_blocklist.patch
No manual changes; patch applied with fuzz 2
* chore: update revert_heap_add_checks_position_info.patch
No manual changes; patch applied with fuzz 1
* chore: e patches all
* chore: bump chromium in DEPS to 127.0.6527.0
* chore: update patches
* chore: bump chromium in DEPS to 127.0.6529.0
* chore: bump chromium in DEPS to 127.0.6531.0
* chore: update patches
* 5596349: Remove PDF OCR toggle from settings.
https://chromium-review.googlesource.com/c/chromium/src/+/5596349
* 5585932: [video-pip] Add minimize button to video picture-in-picture window
https://chromium-review.googlesource.com/c/chromium/src/+/5585932
* 5604487: Reland "[api] Deprecate v8::FunctionCallbackInfo::Holder() for real"
https://chromium-review.googlesource.com/c/v8/v8/+/5604487
* 5581721: [DEPS] Update clang-format location
https://chromium-review.googlesource.com/c/chromium/src/+/5581721
* 5597904: [Windows] Remove ConvertToLongPath from Sandbox Utilities.
https://chromium-review.googlesource.com/c/chromium/src/+/5597904
ResolveNTFunctionPtr was removed in this CL.
* fix: visibility state specs on macOS
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5605407
* Revert "fix: visibility state specs on macOS"
This reverts commit 1eee30a33d.
* temp: disable occlusion checker on macOS
* chore: bump chromium in DEPS to 128.0.6535.0
* chore: update patches
* [Extensions] Move some scriptings files out of the API directory.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5606682
* fix[node]: do not use soon-to-be-deprecated V8 API
* fix: update api_remove_allcan_read_write.patch
* chore: update patches
* chore: update patches
* chore: fix lf mismatch in api_remove_allcan_read_write.patch
* chore: update patches
* chore: bump chromium in DEPS to 128.0.6538.0
* chore: update v8 patches
* chore: update patches
* ui/gl/features.gni: Set use_egl=true unconditionally.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5569748
Refs https://issues.chromium.org/issues/344606399
* chore: bump chromium in DEPS to 128.0.6540.0
* chore: bump chromium in DEPS to 128.0.6541.0
* chore: update patches
* chore: fix nan read/write patch
* chore: bump chromium in DEPS to 128.0.6543.0
* 5626254: Use sandbox_type instead of process_type | https://chromium-review.googlesource.com/c/chromium/src/+/5626254
* chore: update patches
* rework nan patches
* 5621488: Apply consistent naming conventions to zoom values | https://chromium-review.googlesource.com/c/chromium/src/+/5621488
* chore: bump chromium in DEPS to 128.0.6544.0
* 5605693: Remove files from third_party/ninja | https://chromium-review.googlesource.com/c/chromium/src/+/5605693
* chore: update patches
* chore: maybe fix nan patch, part 3
* chore: delete nan patch
* chore: re-add nan patch (attempt 2)
* chore: add test patch
* fixup! add test patch
* chore: bump chromium in DEPS to 128.0.6549.0
* chore: bump chromium in DEPS to 128.0.6551.0
* 5637699: Add command line to ASAN Additional Info section | https://chromium-review.googlesource.com/c/chromium/src/+/5637699
* chore: update patches
* chore: bump chromium in DEPS to 128.0.6553.0
* chore: bump chromium in DEPS to 128.0.6555.0
* fix: add property query interceptors
* chore: bump chromium in DEPS to 128.0.6557.0
* 5583182: Automatic Fullscreen: Prototype Permissions API query support | https://chromium-review.googlesource.com/c/chromium/src/+/5583182
* 5613297: Move render input router and related dependencies to //components/input | https://chromium-review.googlesource.com/c/chromium/src/+/5613297
* chore: update patches
* test: skip methodswithdata-test.js nan test
* chore: bump chromium in DEPS to 128.0.6558.0
* chore: update patches
* build: reference correct ninja cipd ref
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5605693
* update libcxx filenames
* refactor: CursorManager moved to //components/input
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5613297
* refactor: spanify mojo Read/WriteData methods
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5619291
* refactor: remove constexpr from KeyboardCodeFromKeyIdentifier
Ref: unknown
Added TODO to investigate after
* chore: update patches
* refactor: improve type safety of a11y ids
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5614590
* chore: disable tls node tests that don't apply given boringssl tls configuration
Ref: https://boringssl-review.googlesource.com/c/boringssl/+/68487
* chore: add patch to fix nan v8 incompat with NamedPropertyHandlerConfiguration and IndexedPropertyHandlerConfiguration
Ref: https://chromium-review.googlesource.com/c/v8/v8/+/5630388
* fix: limit subspan length per feedback
* Fix incorrect CalculateInsetsInDIP check
* 5645742: Reland "Reland "Add toolchains without PartitionAlloc-Everywhere for dump_syms et al""
https://chromium-review.googlesource.com/c/chromium/src/+/5645742
* chore: more Windows logging
* 5617471: Add NPU blocking to chromium blocklist
https://chromium-review.googlesource.com/c/chromium/src/+/5617471
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
Co-authored-by: Alice Zhao <alice@makenotion.com>
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
Co-authored-by: VerteDinde <vertedinde@electronjs.org>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
68 lines
2.4 KiB
Diff
68 lines
2.4 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Shelley Vohr <shelley.vohr@gmail.com>
|
|
Date: Mon, 17 Jan 2022 23:47:54 +0100
|
|
Subject: fix: crash when saving edited PDF files
|
|
|
|
This commit fixes a crash that persists any time a user attempts to
|
|
download an edited PDF. This was happening because the logic flow for
|
|
downloading of any edited PDF triggers a call to
|
|
chrome.fileSystem.chooseEntry, which we do not support and which
|
|
therefore causes unmapped page access crashes.
|
|
|
|
This patch can be removed should we choose to support chrome.fileSystem
|
|
or support it enough to fix the crash.
|
|
|
|
diff --git a/chrome/browser/resources/pdf/pdf_viewer.ts b/chrome/browser/resources/pdf/pdf_viewer.ts
|
|
index 6168e69b59168c471bf349a4fd3b83b1fdb8b17a..7969930eecd6cc9f165681cd73fc62234b9c38d5 100644
|
|
--- a/chrome/browser/resources/pdf/pdf_viewer.ts
|
|
+++ b/chrome/browser/resources/pdf/pdf_viewer.ts
|
|
@@ -998,7 +998,15 @@ export class PdfViewerElement extends PdfViewerBaseElement {
|
|
dataArray = [result.dataToSave];
|
|
}
|
|
|
|
+ const a = document.createElement('a');
|
|
+ a.download = this.attachments_[index].name;
|
|
const blob = new Blob(dataArray);
|
|
+ // <if expr="not _google_chrome">
|
|
+ a.href = URL.createObjectURL(blob);
|
|
+ a.click();
|
|
+ URL.revokeObjectURL(a.href);
|
|
+ // </if>
|
|
+ // <if expr="_google_chrome">
|
|
const fileName = this.attachments_[index].name;
|
|
chrome.fileSystem.chooseEntry(
|
|
{type: 'saveFile', suggestedName: fileName},
|
|
@@ -1020,6 +1028,7 @@ export class PdfViewerElement extends PdfViewerBaseElement {
|
|
// </if>
|
|
});
|
|
});
|
|
+ // </if>
|
|
}
|
|
|
|
/**
|
|
@@ -1127,8 +1136,15 @@ export class PdfViewerElement extends PdfViewerBaseElement {
|
|
fileName = fileName + '.pdf';
|
|
}
|
|
|
|
- // Create blob before callback to avoid race condition.
|
|
+ const a = document.createElement('a');
|
|
+ a.download = fileName;
|
|
const blob = new Blob([result.dataToSave], {type: 'application/pdf'});
|
|
+ // <if expr="not _google_chrome">
|
|
+ a.href = URL.createObjectURL(blob);
|
|
+ a.click();
|
|
+ URL.revokeObjectURL(a.href);
|
|
+ // </if>
|
|
+ // <if expr="_google_chrome">
|
|
chrome.fileSystem.chooseEntry(
|
|
{
|
|
type: 'saveFile',
|
|
@@ -1153,6 +1169,7 @@ export class PdfViewerElement extends PdfViewerBaseElement {
|
|
// </if>
|
|
});
|
|
});
|
|
+ // </if>
|
|
|
|
// <if expr="enable_ink">
|
|
// Saving in Annotation mode is destructive: crbug.com/919364
|