trop[bot] c150a1e004 refactor: extract-constant static Windows registry keys in Browser code (#47589) ...

* refactor: extract-constant for registry key in GetProcessExecPath()

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* refactor: extract-constant for registry key in Browser::SetLoginItemSettings()

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* refactor: extract-constant for registry key in Browser::SetLoginItemSettings()

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* refactor: extract-constant for registry key in Browser::GetLoginItemSettings()

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* chore: document the symbolic constants

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* refactor: prefer base::wcstring_view::c_str() to data() to make zero-termination clearer

Co-authored-by: Charles Kerr <charles@charleskerr.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>

2025-06-27 15:12:00 -05:00

..

api

refactor: remove stray .c_str() calls for absl::StrFormat() (#47578)

2025-06-26 11:41:48 -05:00

badging

chore: bump chromium to 133.0.6920.0 (main) (#45055)

2025-01-10 10:52:34 -06:00

bluetooth

chore: bump chromium to 131.0.6734.0 (main) (#43769)

2024-09-25 06:19:39 -05:00

extensions

refactor: remove stray .c_str() calls for absl::StrFormat() (#47578)

2025-06-26 11:41:48 -05:00

file_system_access

chore: bump chromium to 138.0.7175.0 (main) (#46986)

2025-05-13 14:51:20 -04:00

hid

refactor: remove stray .c_str() calls for absl::StrFormat() (#47578)

2025-06-26 11:41:48 -05:00

lib

fix: bluetooth crash in select-bluetooth-device event (#46745)

2025-04-25 10:26:19 -05:00

linux

refactor: remove introduce_ozoneplatform_electron_can_call_x11_property.patch (#47075)

2025-05-14 13:38:35 +09:00

mac

refactor: match upstream macOS a11y handling (#47144)

2025-05-20 11:06:57 -04:00

media

chore: iwyu mojom-forward header files (#43741)

2024-09-17 12:58:56 -07:00

net

refactor: remove stray .c_str() calls for absl::StrFormat() (#47578)

2025-06-26 11:41:48 -05:00

notifications

refactor: use std::map::try_emplace() over std::map::insert() (#46761)

2025-04-25 13:11:53 -05:00

osr

refactor: remove CreateViewForWidget patch (#46981)

2025-05-14 21:43:23 +09:00

plugins

perf: avoid unnecessary vector copy in GetMimeTypeToExtensionIdMap() (#46373)

2025-03-31 21:52:49 -05:00

printing

fix: misc-use-internal-linkage warnings (#44843)

2024-11-27 10:40:39 -06:00

resources

build: add NSPrefersDisplaySafeAreaCompatibilityMode = false to Info.plist (#45318)

2025-01-28 14:58:48 +01:00

serial

chore: bump chromium to 139.0.7219.0 (main) (#47348)

2025-06-16 12:46:06 -05:00

ui

refactor: remove stray .c_str() calls for absl::StrFormat() (#47578)

2025-06-26 11:41:48 -05:00

usb

refactor: use base::ObserverList::Notify() (#46875)

2025-05-02 11:10:52 +02:00

webauthn

chore: bump chromium to 134.0.6988.0 (main) (#45334)

2025-02-06 15:30:54 -05:00

win

chore: remove unused #includes (#42971)

2024-07-22 11:31:32 +02:00

animation_util_mac.mm

feat: replace BrowserView with WebContentsView (#35658)

2023-12-13 13:01:03 -08:00

animation_util.h

feat: replace BrowserView with WebContentsView (#35658)

2023-12-13 13:01:03 -08:00

auto_updater_mac.mm

chore: bump chromium to 120.0.6099.0 (main) (#40316)

2023-11-01 10:02:12 -04:00

auto_updater.cc

build: make is_mas_build a generated header instead of config (#43737)

2024-09-17 01:38:56 -07:00

auto_updater.h

fix: modernize-use-equals-default warnings (#44935)

2024-12-03 16:25:48 -06:00

background_throttling_source.h

fix: disable background throttling also in the viz::DisplayScheduler (#38924)

2023-09-26 16:00:46 -04:00

browser_linux.cc

chore: bump chromium to 137.0.7149.0 (main) (#46777)

2025-04-28 11:39:12 -04:00

browser_mac.mm

build: make is_mas_build a generated header instead of config (#43737)

2024-09-17 01:38:56 -07:00

browser_observer.h

fix: modernize-use-equals-default warnings (#44935)

2024-12-03 16:25:48 -06:00

browser_process_impl.cc

chore: bump chromium to 139.0.7219.0 (main) (#47348)

2025-06-16 12:46:06 -05:00

browser_process_impl.h

chore: bump chromium to 134.0.6998.10 (main) (#45564)

2025-02-11 17:26:39 -06:00

browser_win.cc

refactor: extract-constant static Windows registry keys in Browser code (#47589)

2025-06-27 15:12:00 -05:00

browser.cc

refactor: use base::ObserverList::Notify() (#46875)

2025-05-02 11:10:52 +02:00

browser.h

chore: bump chromium to 135.0.7015.0 (main) (#45500)

2025-02-18 11:51:27 -05:00

certificate_manager_model.cc

refactor: remove deprecated BrowserContext::ResourceContext (#41221)

2024-02-05 18:12:34 -06:00

certificate_manager_model.h

chore: more iwyu (#43063)

2024-07-29 12:42:57 -05:00

child_web_contents_tracker.cc

chore: bump chromium to 99.0.4767.0 (main) (#31986)

2022-01-10 17:31:39 -05:00

child_web_contents_tracker.h

chore: add ELECTRON_ prefix to C++ include guards (#31925)

2021-11-22 16:34:31 +09:00

cookie_change_notifier.cc

chore: more iwyu (#43063)

2024-07-29 12:42:57 -05:00

cookie_change_notifier.h

chore: more iwyu (#43063)

2024-07-29 12:42:57 -05:00

draggable_region_provider.h

refactor: move draggable regions to WebContents (#36230)

2022-11-07 10:15:57 -08:00

electron_api_ipc_handler_impl.cc

refactor: dispatch IPC messages from Session (#45452)

2025-02-17 16:36:28 -05:00

electron_api_ipc_handler_impl.h

refactor: dispatch IPC messages from Session (#45452)

2025-02-17 16:36:28 -05:00

electron_api_sw_ipc_handler_impl.cc

refactor: dispatch IPC messages from Session (#45452)

2025-02-17 16:36:28 -05:00

electron_api_sw_ipc_handler_impl.h

refactor: dispatch IPC messages from Session (#45452)

2025-02-17 16:36:28 -05:00

electron_autofill_driver_factory.cc

refactor: use std::map::try_emplace() over std::map::insert() (#46761)

2025-04-25 13:11:53 -05:00

electron_autofill_driver_factory.h

perf: use absl::flat_hash_map instead of std::unordered_map (#46202)

2025-03-24 10:09:14 +01:00

electron_autofill_driver.cc

feat: replace BrowserView with WebContentsView (#35658)

2023-12-13 13:01:03 -08:00

electron_autofill_driver.h

chore: more iwyu (#43063)

2024-07-29 12:42:57 -05:00

electron_browser_client.cc

chore: bump chromium to 138.0.7190.0 (main) (#47107)

2025-06-03 11:19:20 -04:00

electron_browser_client.h

chore: bump chromium to 138.0.7175.0 (main) (#46986)

2025-05-13 14:51:20 -04:00

electron_browser_context.cc

refactor: use gin_helper::Dictionary::ValueOrDefault() (#46982)

2025-05-08 14:17:22 -05:00

electron_browser_context.h

refactor: remove unused method ElectronBrowserContext::GetWeakPtr() (#46170)

2025-03-22 10:15:15 -05:00

electron_browser_main_parts_linux.cc

chore: bump chromium to 138.0.7154.0 (main) (#46872)

2025-05-01 23:53:40 -05:00

electron_browser_main_parts_mac.mm

chore: remove more unused #include calls (#43000)

2024-07-25 11:25:45 +02:00

electron_browser_main_parts_posix.cc

chore: bump chromium to 137.0.7128.1 (main) (#46482)

2025-04-22 15:53:29 -04:00

electron_browser_main_parts.cc

chore: bump chromium to 138.0.7178.0 (main) (#47086)

2025-05-15 12:47:07 -05:00

electron_browser_main_parts.h

chore: iwyu mojom-forward header files (#43741)

2024-09-17 12:58:56 -07:00

electron_crypto_module_delegate_nss.cc

fix: -Wunsafe-buffer-usage warning in ChunkedDataPipeReadableStream (#44211)

2024-10-14 10:46:24 +02:00

electron_crypto_module_delegate_nss.h

feat: Implement password delegate for NSS (#41205)

2024-07-17 09:48:03 -04:00

electron_download_manager_delegate.cc

refactor: use gin_helper::Dictionary::ValueOrDefault() (#46982)

2025-05-08 14:17:22 -05:00

electron_download_manager_delegate.h

refactor: track downloads by guid (#45675)

2025-02-19 16:49:34 -06:00

electron_gpu_client.cc

chore: bump chromium to 100.0.4857.0 (main) (#32419)

2022-02-09 18:58:52 -08:00

electron_gpu_client.h

chore: add ELECTRON_ prefix to C++ include guards (#31925)

2021-11-22 16:34:31 +09:00

electron_navigation_throttle.cc

chore: bump chromium to 138.0.7190.0 (main) (#47107)

2025-06-03 11:19:20 -04:00

electron_navigation_throttle.h

chore: bump chromium to 138.0.7190.0 (main) (#47107)

2025-06-03 11:19:20 -04:00

electron_pdf_document_helper_client.cc

chore: bump chromium to 133.0.6846.0 (main) (#44665)

2024-11-19 19:52:20 -08:00

electron_pdf_document_helper_client.h

chore: bump chromium to 134.0.6998.10 (main) (#45564)

2025-02-11 17:26:39 -06:00

electron_permission_manager.cc

chore: bump chromium to 137.0.7141.0 (main) (#46725)

2025-04-24 17:18:38 +09:00

electron_permission_manager.h

chore: bump chromium to 137.0.7141.0 (main) (#46725)

2025-04-24 17:18:38 +09:00

electron_plugin_info_host_impl.cc

chore: bump chromium to 129.0.6650.0 (main) (#43266)

2024-08-12 10:28:33 +02:00

electron_plugin_info_host_impl.h

chore: bump chromium to 129.0.6650.0 (main) (#43266)

2024-08-12 10:28:33 +02:00

electron_speech_recognition_manager_delegate.cc

refactor: do not subclass ElectronSpeechRecognitionManagerDelegate from SpeechRecognitionEventListener (#42806)

2024-07-10 15:32:50 +02:00

electron_speech_recognition_manager_delegate.h

refactor: do not subclass ElectronSpeechRecognitionManagerDelegate from SpeechRecognitionEventListener (#42806)

2024-07-10 15:32:50 +02:00

electron_web_contents_utility_handler_impl.cc

chore: bump chromium to 137.0.7128.1 (main) (#46482)

2025-04-22 15:53:29 -04:00

electron_web_contents_utility_handler_impl.h

refactor: remove unused system header includes (#46015)

2025-03-14 10:59:15 -05:00

electron_web_ui_controller_factory.cc

refactor: remove unnecessary const_cast (#46543)

2025-04-08 12:58:28 -05:00

electron_web_ui_controller_factory.h

chore: add ELECTRON_ prefix to C++ include guards (#31925)

2021-11-22 16:34:31 +09:00

event_emitter_mixin.h

chore: migrate base::StringPiece to std::string_view (#40915)

2024-01-10 19:00:37 -06:00

extended_web_contents_observer.h

fix: modernize-use-equals-default warnings (#44935)

2024-12-03 16:25:48 -06:00

fake_location_provider.cc

chore: remove unused base/ includes (#43688)

2024-09-12 16:05:37 +02:00

fake_location_provider.h

chore: bump chromium to 116.0.5845.0 (main) (#38827)

2023-06-22 10:51:15 +02:00

feature_list_mac.mm

feat: add support for system picker in setDisplayMediaRequestHandler (#43581)

2024-09-10 16:05:57 -07:00

feature_list.cc

chore: bump chromium to 138.0.7160.0 (main) (#46915)

2025-05-05 13:58:40 -04:00

feature_list.h

feat: add support for system picker in setDisplayMediaRequestHandler (#43581)

2024-09-10 16:05:57 -07:00

file_select_helper_mac.mm

refactor: replace remaining NULL with nullptr (#40053)

2023-10-03 12:26:35 -07:00

file_select_helper.cc

refactor: return-braced-init-list pt 2 of 2 (#44870)

2024-11-29 11:44:33 -06:00

file_select_helper.h

chore: remove more unused #include calls (#43000)

2024-07-25 11:25:45 +02:00

font_defaults.cc

fix: resolve font list in default prefernce values (#45905)

2025-03-07 18:22:03 +09:00

font_defaults.h

fix: resolve font list in default prefernce values (#45905)

2025-03-07 18:22:03 +09:00

javascript_environment.cc

chore: bump chromium to 136.0.7095.0 (main) (#46118)

2025-04-03 19:02:49 -05:00

javascript_environment.h

chore: bump chromium to 136.0.7095.0 (main) (#46118)

2025-04-03 19:02:49 -05:00

login_handler.cc

chore: bump chromium to 135.0.7027.0 (main) (#45677)

2025-02-21 14:46:51 -08:00

login_handler.h

chore: bump chromium to 135.0.7027.0 (main) (#45677)

2025-02-21 14:46:51 -08:00

microtasks_runner.cc

perf: remove isolate scope from DidProcessTask() (#44439)

2024-10-29 23:25:40 -05:00

microtasks_runner.h

chore: enable check raw ptr fields (#38167)

2023-05-11 16:07:39 -04:00

native_window_features.cc

chore: bump chromium to 127.0.6521.0 (main) (#42118)

2024-06-07 17:18:35 -04:00

native_window_features.h

fix: Add support for Wayland window decorations (#29618)

2022-01-26 13:59:09 -08:00

native_window_mac.h

fix: revert moving IsClosed() and IsClosable() into NativeWindow::Close() (#47482)

2025-06-16 16:41:19 -07:00

native_window_mac.mm

fix: revert moving IsClosed() and IsClosable() into NativeWindow::Close() (#47482)

2025-06-16 16:41:19 -07:00

native_window_observer.h

refactor: pass gfx::ResizeEdge by value (#46935)

2025-05-06 11:57:53 -05:00

native_window_views_win.cc

feat: support customizing window accent color on Windows (#47285)

2025-06-24 14:43:02 +02:00

native_window_views.cc

feat: support customizing window accent color on Windows (#47285)

2025-06-24 14:43:02 +02:00

native_window_views.h

feat: support customizing window accent color on Windows (#47285)

2025-06-24 14:43:02 +02:00

native_window.cc

refactor: simplify titlebar overlay initialization (#47480)

2025-06-23 11:24:05 +02:00

native_window.h

fix: revert moving IsClosed() and IsClosable() into NativeWindow::Close() (#47482)

2025-06-16 16:41:19 -07:00

network_hints_handler_impl.cc

chore: bump chromium to 133.0.6920.0 (main) (#45055)

2025-01-10 10:52:34 -06:00

network_hints_handler_impl.h

chore: enable check raw ptr fields (#38167)

2023-05-11 16:07:39 -04:00

preload_script.cc

refactor: move gin::Converter<PreloadScript> impl to a .cc file (#47445)

2025-06-13 10:15:32 +02:00

preload_script.h

refactor: move gin::Converter<PreloadScript> impl to a .cc file (#47445)

2025-06-13 10:15:32 +02:00

protocol_registry.cc

perf: prefer GURL string_view getters (#43443)

2024-08-23 17:15:45 -05:00

protocol_registry.h

perf: prefer GURL string_view getters (#43443)

2024-08-23 17:15:45 -05:00

relauncher_linux.cc

chore: bump chromium to 137.0.7128.1 (main) (#46482)

2025-04-22 15:53:29 -04:00

relauncher_mac.cc

chore: remove unused #includes (#42971)

2024-07-22 11:31:32 +02:00

relauncher_win.cc

refactor: reduce scope of relauncher's internal constants (#44860)

2024-11-30 06:54:40 -06:00

relauncher.cc

refactor: remove unused system header includes (#46015)

2025-03-14 10:59:15 -05:00

relauncher.h

refactor: reduce scope of relauncher's internal constants (#44860)

2024-11-30 06:54:40 -06:00

session_preferences.cc

feat: service worker preload scripts for improved extensions support (#44411)

2025-01-31 09:32:45 -05:00

session_preferences.h

feat: service worker preload scripts for improved extensions support (#44411)

2025-01-31 09:32:45 -05:00

special_storage_policy.cc

chore: remove unused base/ includes (#43688)

2024-09-12 16:05:37 +02:00

special_storage_policy.h

chore: bump chromium to 106.0.5216.0 (main) (#34993)

2022-08-17 11:35:53 -07:00

web_contents_permission_helper.cc

chore: bump chromium to 137.0.7128.1 (main) (#46482)

2025-04-22 15:53:29 -04:00

web_contents_permission_helper.h

chore: bump chromium to 137.0.7128.1 (main) (#46482)

2025-04-22 15:53:29 -04:00

web_contents_preferences.cc

feat: Corner Smoothing CSS rule (Reland) (#46278)

2025-03-31 11:22:23 -05:00

web_contents_preferences.h

feat: Corner Smoothing CSS rule (Reland) (#46278)

2025-03-31 11:22:23 -05:00

web_contents_zoom_controller.cc

refactor: use base::ObserverList::Notify() (#46875)

2025-05-02 11:10:52 +02:00

web_contents_zoom_controller.h

chore: more iwyu (#43063)

2024-07-29 12:42:57 -05:00

web_contents_zoom_observer.h

chore: more iwyu (#43063)

2024-07-29 12:42:57 -05:00

web_view_guest_delegate.cc

refactor: remove CreateViewForWidget patch (#46981)

2025-05-14 21:43:23 +09:00

web_view_guest_delegate.h

refactor: prefer to inherit observer classes privately (#41360)

2024-05-21 14:21:31 -05:00

web_view_manager.cc

chore: bump chromium to 121.0.6147.0 (main) (#40523)

2023-11-28 13:40:12 -08:00

web_view_manager.h

perf: use flat_set, flat_map for small, trivially-moved containers (#40817)

2024-01-05 12:18:31 +01:00

window_list_observer.h

fix: modernize-use-equals-default warnings (#44935)

2024-12-03 16:25:48 -06:00

window_list.cc

fix: revert moving IsClosed() and IsClosable() into NativeWindow::Close() (#47482)

2025-06-16 16:41:19 -07:00

window_list.h

refactor: migrate deprecated LazyInstance code to NoDestructor (#40927)

2024-01-10 14:01:49 -06:00

zoom_level_delegate.cc

refactor: remove unused system header includes (#46015)

2025-03-14 10:59:15 -05:00

zoom_level_delegate.h

chore: more iwyu (#43063)

2024-07-29 12:42:57 -05:00