github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-05-02 03:00:22 -04:00
Code Issues Packages Projects Releases Wiki Activity
Files
v39.8.2
electron/shell/browser
History
trop[bot] da140aea7c fix: prevent traffic light buttons flashing on deminiaturize (#50208) 
* fix: prevent traffic light buttons flashing on deminiaturize

When a window with a custom `trafficLightPosition` is minimized and
restored, macOS re-layouts the title bar container during the
deminiaturize animation, causing the traffic light buttons to briefly
appear at their default position before being repositioned.

Fix this by hiding the buttons container in `windowWillMiniaturize` and
restoring them (with a redraw to the correct position) in
`windowDidDeminiaturize`.

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

* chore: address feedback from review

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2026-03-11 15:37:00 -04:00
..
api
fix: bind offscreen paint callback to child WebContents (#50184)
2026-03-10 14:00:14 -04:00
badging
chore: bump chromium to 133.0.6920.0 (main) (#45055)
2025-01-10 10:52:34 -06:00
bluetooth
chore: bump chromium to 139.0.7256.0 (main) (#47481)
2025-06-26 00:12:49 +09:00
extensions
chore: bump chromium to 142.0.7444.23 (39-x-y) (#48307)
2025-10-14 11:25:30 -04:00
file_system_access
fix: possible crash in FileSystem API (#49634)
2026-02-04 16:12:59 +01:00
hid
fix: use requesting frame origin in permission helper and device choosers (#50147)
2026-03-09 22:16:08 -07:00
lib
chore: bump chromium to 141.0.7346.0 (main) (#47983)
2025-08-11 12:57:31 +09:00
linux
fix: screen.getCursorScreenPoint() crash on Wayland (#50106)
2026-03-08 19:20:30 +01:00
mac
fix: deliver Universal Links when NSUserActivity.userInfo is nil (#50004)
2026-03-02 11:26:07 -05:00
media
chore: iwyu mojom-forward header files (#43741)
2024-09-17 12:58:56 -07:00
net
fix: validate response header names and values before AddHeader (#50129)
2026-03-09 11:40:51 -04:00
notifications
fix: run toast creation on background thread (#49130)
2025-12-02 20:41:24 -08:00
osr
fix: bind offscreen paint callback to child WebContents (#50184)
2026-03-10 14:00:14 -04:00
plugins
fix: compilation error when disabling extensions and pdf_viewer (#47964)
2025-08-07 11:18:32 -04:00
printing
fix: compilation error when disabling extensions and pdf_viewer (#47964)
2025-08-07 11:18:32 -04:00
resources
fix: address upstream Chromium shift to enable CoreAudio Tap API for audio capture used in electron's desktopCapturer (🍏 macOS). (#49740)
2026-02-11 11:05:24 +01:00
serial
fix: use requesting frame origin in permission helper and device choosers (#50147)
2026-03-09 22:16:08 -07:00
ui
fix: prevent traffic light buttons flashing on deminiaturize (#50208)
2026-03-11 15:37:00 -04:00
usb
fix: use requesting frame origin in permission helper and device choosers (#50147)
2026-03-09 22:16:08 -07:00
webauthn
chore: bump chromium to 134.0.6988.0 (main) (#45334)
2025-02-06 15:30:54 -05:00
win
chore: bump chromium to 142.0.7417.0 (39-x-y) (#48363)
2025-09-24 11:56:54 -04:00
animation_util_mac.mm
feat: replace BrowserView with WebContentsView (#35658)
2023-12-13 13:01:03 -08:00
animation_util.h
feat: replace BrowserView with WebContentsView (#35658)
2023-12-13 13:01:03 -08:00
auto_updater_mac.mm
chore: bump chromium to 141.0.7390.7 (39-x-y) (#48276)
2025-09-08 17:08:42 -04:00
auto_updater.cc
chore: bump chromium to 141.0.7390.7 (39-x-y) (#48276)
2025-09-08 17:08:42 -04:00
auto_updater.h
chore: bump chromium to 141.0.7390.7 (39-x-y) (#48276)
2025-09-08 17:08:42 -04:00
background_throttling_source.h
fix: disable background throttling also in the viz::DisplayScheduler (#38924)
2023-09-26 16:00:46 -04:00
browser_linux.cc
fix: validate protocol scheme names in setAsDefaultProtocolClient (#50156)
2026-03-10 07:27:59 -04:00
browser_mac.mm
fix: validate protocol scheme names in setAsDefaultProtocolClient (#50156)
2026-03-10 07:27:59 -04:00
browser_observer.h
fix: modernize-use-equals-default warnings (#44935)
2024-12-03 16:25:48 -06:00
browser_process_impl.cc
chore: bump chromium to 139.0.7256.0 (main) (#47481)
2025-06-26 00:12:49 +09:00
browser_process_impl.h
chore: bump chromium to 134.0.6998.10 (main) (#45564)
2025-02-11 17:26:39 -06:00
browser_win.cc
fix: validate protocol scheme names in setAsDefaultProtocolClient (#50156)
2026-03-10 07:27:59 -04:00
browser.cc
fix: validate protocol scheme names in setAsDefaultProtocolClient (#50156)
2026-03-10 07:27:59 -04:00
browser.h
fix: validate protocol scheme names in setAsDefaultProtocolClient (#50156)
2026-03-10 07:27:59 -04:00
certificate_manager_model.cc
refactor: remove deprecated BrowserContext::ResourceContext (#41221)
2024-02-05 18:12:34 -06:00
certificate_manager_model.h
chore: more iwyu (#43063)
2024-07-29 12:42:57 -05:00
child_web_contents_tracker.cc
…
child_web_contents_tracker.h
…
cookie_change_notifier.cc
chore: more iwyu (#43063)
2024-07-29 12:42:57 -05:00
cookie_change_notifier.h
chore: more iwyu (#43063)
2024-07-29 12:42:57 -05:00
draggable_region_provider.h
refactor: move draggable regions to WebContents (#36230)
2022-11-07 10:15:57 -08:00
electron_api_ipc_handler_impl.cc
fix: handle empty event scenario in ipc callbacks (#48992)
2025-11-18 09:17:20 -05:00
electron_api_ipc_handler_impl.h
refactor: allocate gin_helper::internal::Event on cpp heap (#48161)
2025-08-27 09:30:50 +09:00
electron_api_sw_ipc_handler_impl.cc
fix: handle empty event scenario in ipc callbacks (#48992)
2025-11-18 09:17:20 -05:00
electron_api_sw_ipc_handler_impl.h
refactor: allocate gin_helper::internal::Event on cpp heap (#48161)
2025-08-27 09:30:50 +09:00
electron_autofill_driver_factory.cc
refactor: use std::map::try_emplace() over std::map::insert() (#46761)
2025-04-25 13:11:53 -05:00
electron_autofill_driver_factory.h
perf: use absl::flat_hash_map instead of std::unordered_map (#46202)
2025-03-24 10:09:14 +01:00
electron_autofill_driver.cc
feat: replace BrowserView with WebContentsView (#35658)
2023-12-13 13:01:03 -08:00
electron_autofill_driver.h
chore: more iwyu (#43063)
2024-07-29 12:42:57 -05:00
electron_browser_client.cc
chore: bump chromium to 142.0.7444.23 (39-x-y) (#48307)
2025-10-14 11:25:30 -04:00
electron_browser_client.h
chore: bump chromium to 141.0.7390.7 (39-x-y) (#48276)
2025-09-08 17:08:42 -04:00
electron_browser_context.cc
chore: bump chromium to 141.0.7390.7 (39-x-y) (#48276)
2025-09-08 17:08:42 -04:00
electron_browser_context.h
chore: bump chromium to 141.0.7390.7 (39-x-y) (#48276)
2025-09-08 17:08:42 -04:00
electron_browser_main_parts_mac.mm
chore: remove more unused #include calls (#43000)
2024-07-25 11:25:45 +02:00
electron_browser_main_parts_posix.cc
chore: bump chromium to 137.0.7128.1 (main) (#46482)
2025-04-22 15:53:29 -04:00
electron_browser_main_parts.cc
fix: revert enabling WASM trap handlers in all Node.js processes (#48975)
2025-11-14 18:56:50 -08:00
electron_browser_main_parts.h
fix: initialze featurelist before parsing features (#48442)
2025-10-02 20:58:57 -05:00
electron_crypto_module_delegate_nss.cc
refactor: allocate gin_helper::internal::Event on cpp heap (#48161)
2025-08-27 09:30:50 +09:00
electron_crypto_module_delegate_nss.h
feat: Implement password delegate for NSS (#41205)
2024-07-17 09:48:03 -04:00
electron_download_manager_delegate.cc
fix: potential UAF in OnDownloadPathGenerated (#50009)
2026-03-02 18:36:42 -05:00
electron_download_manager_delegate.h
refactor: track downloads by guid (#45675)
2025-02-19 16:49:34 -06:00
electron_gpu_client.cc
…
electron_gpu_client.h
…
electron_navigation_throttle.cc
chore: bump chromium to 140.0.7281.0 (main) (#47616)
2025-07-14 13:42:37 -07:00
electron_navigation_throttle.h
chore: bump chromium to 138.0.7190.0 (main) (#47107)
2025-06-03 11:19:20 -04:00
electron_pdf_document_helper_client.cc
chore: bump chromium to 140.0.7314.0 (main) (#47882)
2025-07-28 15:31:54 -07:00
electron_pdf_document_helper_client.h
chore: bump chromium to 142.0.7417.0 (39-x-y) (#48363)
2025-09-24 11:56:54 -04:00
electron_permission_manager.cc
fix: prevent use-after-free in permission request callbacks (#50035)
2026-03-03 09:13:37 -05:00
electron_permission_manager.h
fix: prevent use-after-free in permission request callbacks (#50035)
2026-03-03 09:13:37 -05:00
electron_plugin_info_host_impl.cc
chore: bump chromium to 129.0.6650.0 (main) (#43266)
2024-08-12 10:28:33 +02:00
electron_plugin_info_host_impl.h
chore: bump chromium to 129.0.6650.0 (main) (#43266)
2024-08-12 10:28:33 +02:00
electron_preconnect_manager_delegate.cc
chore: bump chromium to 140.0.7314.0 (main) (#47882)
2025-07-28 15:31:54 -07:00
electron_preconnect_manager_delegate.h
chore: bump chromium to 140.0.7339.2 (main) (#47929)
2025-08-06 20:14:23 -04:00
electron_speech_recognition_manager_delegate.cc
chore: bump chromium to 140.0.7339.2 (main) (#47929)
2025-08-06 20:14:23 -04:00
electron_speech_recognition_manager_delegate.h
chore: bump chromium to 140.0.7339.2 (main) (#47929)
2025-08-06 20:14:23 -04:00
electron_web_contents_utility_handler_impl.cc
chore: bump chromium to 137.0.7128.1 (main) (#46482)
2025-04-22 15:53:29 -04:00
electron_web_contents_utility_handler_impl.h
refactor: remove unused system header includes (#46015)
2025-03-14 10:59:15 -05:00
electron_web_ui_controller_factory.cc
refactor: remove unnecessary const_cast (#46543)
2025-04-08 12:58:28 -05:00
electron_web_ui_controller_factory.h
…
event_emitter_mixin.h
refactor: allocate gin_helper::internal::Event on cpp heap (#48161)
2025-08-27 09:30:50 +09:00
extended_web_contents_observer.h
fix: modernize-use-equals-default warnings (#44935)
2024-12-03 16:25:48 -06:00
fake_location_provider.cc
chore: remove unused base/ includes (#43688)
2024-09-12 16:05:37 +02:00
fake_location_provider.h
chore: bump chromium to 116.0.5845.0 (main) (#38827)
2023-06-22 10:51:15 +02:00
feature_list_mac.mm
feat: add support for system picker in setDisplayMediaRequestHandler (#43581)
2024-09-10 16:05:57 -07:00
feature_list.cc
refactor: remove spellcheck::kWinDelaySpellcheckServiceInit patch (#48857)
2025-11-10 11:54:00 -05:00
feature_list.h
feat: add support for system picker in setDisplayMediaRequestHandler (#43581)
2024-09-10 16:05:57 -07:00
file_select_helper_mac.mm
refactor: replace remaining NULL with nullptr (#40053)
2023-10-03 12:26:35 -07:00
file_select_helper.cc
refactor: return-braced-init-list pt 2 of 2 (#44870)
2024-11-29 11:44:33 -06:00
file_select_helper.h
chore: remove more unused #include calls (#43000)
2024-07-25 11:25:45 +02:00
font_defaults.cc
chore: bump chromium to 141.0.7390.7 (39-x-y) (#48276)
2025-09-08 17:08:42 -04:00
font_defaults.h
fix: resolve font list in default prefernce values (#45905)
2025-03-07 18:22:03 +09:00
javascript_environment.cc
chore: bump chromium to 136.0.7095.0 (main) (#46118)
2025-04-03 19:02:49 -05:00
javascript_environment.h
chore: bump chromium to 136.0.7095.0 (main) (#46118)
2025-04-03 19:02:49 -05:00
login_handler.cc
feat: support WebSocket authentication handling (#49065)
2026-01-13 08:52:14 -05:00
login_handler.h
feat: support WebSocket authentication handling (#49065)
2026-01-13 08:52:14 -05:00
microtasks_runner.cc
perf: remove isolate scope from DidProcessTask() (#44439)
2024-10-29 23:25:40 -05:00
microtasks_runner.h
chore: enable check raw ptr fields (#38167)
2023-05-11 16:07:39 -04:00
native_window_features.cc
chore: bump chromium to 127.0.6521.0 (main) (#42118)
2024-06-07 17:18:35 -04:00
native_window_features.h
…
native_window_mac.h
fix: prevent traffic light buttons flashing on deminiaturize (#50208)
2026-03-11 15:37:00 -04:00
native_window_mac.mm
fix: prevent traffic light buttons flashing on deminiaturize (#50208)
2026-03-11 15:37:00 -04:00
native_window_observer.h
refactor: pass gfx::ResizeEdge by value (#46935)
2025-05-06 11:57:53 -05:00
native_window_views_win.cc
fix: accentColor set distinguishes the frame (#48450)
2025-10-03 15:31:36 -05:00
native_window_views.cc
fix: menu bar hiding on two setFullscreen(false) (#49995)
2026-03-04 14:06:35 -05:00
native_window_views.h
chore: bump chromium to 142.0.7444.23 (39-x-y) (#48307)
2025-10-14 11:25:30 -04:00
native_window.cc
fix: the parent window remained interactive after the modal window was opened (#48865)
2025-11-10 13:55:25 +01:00
native_window.h
feat: add {get|set}AccentColor on Windows (#47741)
2025-08-01 22:29:02 +02:00
network_hints_handler_impl.cc
refactor: allocate api::Session on cpp heap (#48141)
2025-08-25 18:52:06 +09:00
network_hints_handler_impl.h
chore: enable check raw ptr fields (#38167)
2023-05-11 16:07:39 -04:00
preload_script.cc
refactor: move gin::Converter<PreloadScript> impl to a .cc file (#47445)
2025-06-13 10:15:32 +02:00
preload_script.h
refactor: move gin::Converter<PreloadScript> impl to a .cc file (#47445)
2025-06-13 10:15:32 +02:00
protocol_registry.cc
perf: prefer GURL string_view getters (#43443)
2024-08-23 17:15:45 -05:00
protocol_registry.h
perf: prefer GURL string_view getters (#43443)
2024-08-23 17:15:45 -05:00
relauncher_linux.cc
chore: bump chromium to 141.0.7390.7 (39-x-y) (#48276)
2025-09-08 17:08:42 -04:00
relauncher_mac.cc
chore: remove unused #includes (#42971)
2024-07-22 11:31:32 +02:00
relauncher_win.cc
fix: use proper quoting for exe paths and args on Windows (#50074)
2026-03-04 13:37:46 -06:00
relauncher.cc
refactor: remove unused system header includes (#46015)
2025-03-14 10:59:15 -05:00
relauncher.h
refactor: reduce scope of relauncher's internal constants (#44860)
2024-11-30 06:54:40 -06:00
session_preferences.cc
feat: service worker preload scripts for improved extensions support (#44411)
2025-01-31 09:32:45 -05:00
session_preferences.h
feat: service worker preload scripts for improved extensions support (#44411)
2025-01-31 09:32:45 -05:00
special_storage_policy.cc
chore: remove unused base/ includes (#43688)
2024-09-12 16:05:37 +02:00
special_storage_policy.h
chore: bump chromium to 106.0.5216.0 (main) (#34993)
2022-08-17 11:35:53 -07:00
web_contents_permission_helper.cc
fix: use requesting frame origin in permission helper and device choosers (#50147)
2026-03-09 22:16:08 -07:00
web_contents_permission_helper.h
chore: bump chromium to 137.0.7128.1 (main) (#46482)
2025-04-22 15:53:29 -04:00
web_contents_preferences.cc
chore: remove unused commandLineSwitches flag (#50013)
2026-03-03 10:45:35 +01:00
web_contents_preferences.h
chore: remove unused commandLineSwitches flag (#50013)
2026-03-03 10:45:35 +01:00
web_contents_zoom_controller.cc
refactor: use base::ObserverList::Notify() (#46875)
2025-05-02 11:10:52 +02:00
web_contents_zoom_controller.h
chore: more iwyu (#43063)
2024-07-29 12:42:57 -05:00
web_contents_zoom_observer.h
chore: more iwyu (#43063)
2024-07-29 12:42:57 -05:00
web_view_guest_delegate.cc
chore: bump chromium to 140.0.7281.0 (main) (#47616)
2025-07-14 13:42:37 -07:00
web_view_guest_delegate.h
chore: bump chromium to 140.0.7281.0 (main) (#47616)
2025-07-14 13:42:37 -07:00
web_view_manager.cc
chore: bump chromium to 121.0.6147.0 (main) (#40523)
2023-11-28 13:40:12 -08:00
web_view_manager.h
perf: use flat_set, flat_map for small, trivially-moved containers (#40817)
2024-01-05 12:18:31 +01:00
window_list_observer.h
fix: modernize-use-equals-default warnings (#44935)
2024-12-03 16:25:48 -06:00
window_list.cc
perf: avoid copying a vector when calling ConvertToWeakPtrVector() (#47593)
2025-06-29 21:32:03 +02:00
window_list.h
refactor: migrate deprecated LazyInstance code to NoDestructor (#40927)
2024-01-10 14:01:49 -06:00
zoom_level_delegate.cc
chore: bump chromium to 140.0.7261.0 (main) (#47561)
2025-06-30 12:30:05 -04:00
zoom_level_delegate.h
chore: more iwyu (#43063)
2024-07-29 12:42:57 -05:00