ci: update version string in docs

docs/python/requirements-docs.txt

@@ -1,4 +1,4 @@
-ezkl==11.5.0
+ezkl==11.4.2
 sphinx
 sphinx-rtd-theme
 sphinxcontrib-napoleon

docs/python/src/conf.py

@@ -1,7 +1,7 @@
 import ezkl
 
 project = 'ezkl'
-release = '11.5.0'
+release = '11.4.2'
 version = release
 
 

src/commands.rs

@@ -379,9 +379,9 @@ pub enum Commands {
         #[arg(long = "target", default_value = DEFAULT_CALIBRATION_TARGET, value_hint = clap::ValueHint::Other)]
         /// Target for calibration. Set to "resources" to optimize for computational resource. Otherwise, set to "accuracy" to optimize for accuracy.
         target: CalibrationTarget,
-        /// the lookup safety margin to use for calibration. if the max lookup is 2^k, then the max lookup will be ceil(2^k * lookup_safety_margin). larger = safer but slower
+        /// the lookup safety margin to use for calibration. if the max lookup is 2^k, then the max lookup will be 2^k * lookup_safety_margin. larger = safer but slower
         #[arg(long, default_value = DEFAULT_LOOKUP_SAFETY_MARGIN, value_hint = clap::ValueHint::Other)]
-        lookup_safety_margin: f64,
+        lookup_safety_margin: i64,
         /// Optional scales to specifically try for calibration. Example, --scales 0,4
         #[arg(long, value_delimiter = ',', allow_hyphen_values = true, value_hint = clap::ValueHint::Other)]
         scales: Option<Vec<crate::Scale>>,

src/execute.rs

@@ -1013,7 +1013,7 @@ pub(crate) async fn calibrate(
     data: PathBuf,
     settings_path: PathBuf,
     target: CalibrationTarget,
-    lookup_safety_margin: f64,
+    lookup_safety_margin: i64,
     scales: Option<Vec<crate::Scale>>,
     scale_rebase_multiplier: Vec<u32>,
     only_range_check_rebase: bool,

src/graph/mod.rs

@@ -1034,10 +1034,10 @@ impl GraphCircuit {
         Ok(data)
     }
 
-    fn calc_safe_lookup_range(min_max_lookup: Range, lookup_safety_margin: f64) -> Range {
+    fn calc_safe_lookup_range(min_max_lookup: Range, lookup_safety_margin: i64) -> Range {
         (
-            (lookup_safety_margin * min_max_lookup.0 as f64).floor() as i64,
-            (lookup_safety_margin * min_max_lookup.1 as f64).ceil() as i64,
+            lookup_safety_margin * min_max_lookup.0,
+            lookup_safety_margin * min_max_lookup.1,
         )
     }
 
@@ -1070,7 +1070,7 @@ impl GraphCircuit {
         min_max_lookup: Range,
         max_range_size: i64,
         max_logrows: Option<u32>,
-        lookup_safety_margin: f64,
+        lookup_safety_margin: i64,
     ) -> Result<(), GraphError> {
         // load the max logrows
         let max_logrows = max_logrows.unwrap_or(MAX_PUBLIC_SRS);
@@ -1080,13 +1080,9 @@ impl GraphCircuit {
 
         let safe_lookup_range = Self::calc_safe_lookup_range(min_max_lookup, lookup_safety_margin);
 
-        // check if subtraction overflows
-
-        let lookup_size =
-            (safe_lookup_range.1.saturating_sub(safe_lookup_range.0)).saturating_abs();
+        let lookup_size = (safe_lookup_range.1 - safe_lookup_range.0).abs();
         // check if has overflowed max lookup input
-
-        if lookup_size > (MAX_LOOKUP_ABS as f64 / lookup_safety_margin).floor() as i64 {
+        if lookup_size > MAX_LOOKUP_ABS / lookup_safety_margin {
             return Err(GraphError::LookupRangeTooLarge(
                 lookup_size.unsigned_abs() as usize
             ));

src/python.rs

@@ -887,7 +887,7 @@ fn calibrate_settings(
     model: PathBuf,
     settings: PathBuf,
     target: CalibrationTarget,
-    lookup_safety_margin: f64,
+    lookup_safety_margin: i64,
     scales: Option<Vec<crate::Scale>>,
     scale_rebase_multiplier: Vec<u32>,
     max_logrows: Option<u32>,
@@ -1491,7 +1491,7 @@ fn encode_evm_calldata<'a>(
 ///     The path to the SRS file
 ///
 /// render_vk_separately: bool
-///     Whether the verifier key should be rendered as a separate contract. We recommend disabling selector compression if this is enabled. To save the verifier key as a separate contract, set this to true and then call the create_evm_vk command
+///     Whether the verifier key should be rendered as a separate contract. We recommend disabling selector compression if this is enabled. To save the verifier key as a separate contract, set this to true and then call the create-evm-vk command
 ///
 /// Returns
 /// -------
@@ -1533,56 +1533,6 @@ fn create_evm_verifier(
     })
 }
 
-/// Creates an Evm verifer key. This command should be called after create_evm_verifier with the render_vk_separately arg set to true. By rendering a verification key separately you can reuse the same verifier for similar circuit setups with different verifying keys, helping to reduce the amount of state our verifiers store on the blockchain.
-///
-/// Arguments
-/// ---------
-/// vk_path: str
-///     The path to the verification key file
-///
-/// settings_path: str
-///     The path to the settings file
-///
-/// sol_code_path: str
-///     The path to the create the solidity verifying key.
-///
-/// abi_path: str
-///     The path to create the ABI for the solidity verifier
-///
-/// srs_path: str
-///     The path to the SRS file
-///
-/// Returns
-/// -------
-/// bool
-///
-#[pyfunction(signature = (
-    vk_path=PathBuf::from(DEFAULT_VK),
-    settings_path=PathBuf::from(DEFAULT_SETTINGS),
-    sol_code_path=PathBuf::from(DEFAULT_VK_SOL),
-    abi_path=PathBuf::from(DEFAULT_VERIFIER_ABI),
-    srs_path=None
-))]
-fn create_evm_vk(
-    py: Python,
-    vk_path: PathBuf,
-    settings_path: PathBuf,
-    sol_code_path: PathBuf,
-    abi_path: PathBuf,
-    srs_path: Option<PathBuf>,
-) -> PyResult<Bound<'_, PyAny>> {
-    pyo3_asyncio::tokio::future_into_py(py, async move {
-        crate::execute::create_evm_vk(vk_path, srs_path, settings_path, sol_code_path, abi_path)
-            .await
-            .map_err(|e| {
-                let err_str = format!("Failed to run create_evm_verifier: {}", e);
-                PyRuntimeError::new_err(err_str)
-            })?;
-
-        Ok(true)
-    })
-}
-
 /// Creates an EVM compatible data attestation verifier, you will need solc installed in your environment to run this
 ///
 /// Arguments
@@ -1812,7 +1762,7 @@ fn deploy_da_evm(
 /// Arguments
 /// ---------
 /// addr_verifier: str
-///     The verifier contract's address as a hex string
+///     The path to verifier contract's address
 ///
 /// proof_path: str
 ///     The path to the proof file (generated using the prove command)
@@ -1824,7 +1774,7 @@ fn deploy_da_evm(
 ///     does the verifier use data attestation ?
 ///
 /// addr_vk: str
-///     The addess of the separate VK contract (if the verifier key is rendered as a separate contract)
+///
 /// Returns
 /// -------
 /// bool
@@ -1975,7 +1925,6 @@ fn ezkl(_py: Python<'_>, m: &PyModule) -> PyResult<()> {
     m.add_function(wrap_pyfunction!(compile_circuit, m)?)?;
     m.add_function(wrap_pyfunction!(verify_aggr, m)?)?;
     m.add_function(wrap_pyfunction!(create_evm_verifier, m)?)?;
-    m.add_function(wrap_pyfunction!(create_evm_vk, m)?)?;
     m.add_function(wrap_pyfunction!(deploy_evm, m)?)?;
     m.add_function(wrap_pyfunction!(deploy_vk_evm, m)?)?;
     m.add_function(wrap_pyfunction!(deploy_da_evm, m)?)?;

tests/python/binding_tests.py

@@ -423,74 +423,6 @@ async def test_create_evm_verifier():
     assert res == True
     assert os.path.isfile(sol_code_path)
 
-async def test_create_evm_verifier_separate_vk():
-    """
-    Create EVM a verifier with solidity code and separate vk
-    In order to run this test you will need to install solc in your environment
-    """
-    vk_path = os.path.join(folder_path, 'test_evm.vk')
-    settings_path = os.path.join(folder_path, 'settings.json')
-    sol_code_path = os.path.join(folder_path, 'test_separate.sol')
-    vk_code_path = os.path.join(folder_path, 'test_vk.sol')
-    abi_path = os.path.join(folder_path, 'test_separate.abi')
-    abi_vk_path = os.path.join(folder_path, 'test_vk_separate.abi')
-    proof_path = os.path.join(folder_path, 'test_evm.pf')
-    calldata_path = os.path.join(folder_path, 'calldata.bytes')
-
-    # # res is now a vector of bytes
-    # res = ezkl.encode_evm_calldata(proof_path, calldata_path)
-
-    # assert os.path.isfile(calldata_path)
-    # assert len(res) > 0
-
-
-    res = await ezkl.create_evm_verifier(
-        vk_path,
-        settings_path,
-        sol_code_path,
-        abi_path,
-        srs_path=srs_path,
-        render_vk_seperately=True
-    )
-
-    res = await ezkl.create_evm_vk(
-        vk_path,
-        settings_path,
-        vk_code_path,
-        abi_vk_path,
-        srs_path=srs_path,
-    )
-
-    assert res == True
-    assert os.path.isfile(sol_code_path)
-
-
-async def test_deploy_evm_separate_vk():
-    """
-    Test deployment of the separate verifier smart contract + vk
-    In order to run this you will need to install solc in your environment
-    """
-    addr_path_verifier = os.path.join(folder_path, 'address_separate.json')
-    addr_path_vk = os.path.join(folder_path, 'address_vk.json')
-    sol_code_path = os.path.join(folder_path, 'test_separate.sol')
-    vk_code_path = os.path.join(folder_path, 'test_vk.sol')
-
-    # TODO: without optimization there will be out of gas errors
-    # sol_code_path = os.path.join(folder_path, 'test.sol')
-
-    res = await ezkl.deploy_evm(
-        addr_path_verifier,
-        sol_code_path,
-        rpc_url=anvil_url,
-    )
-
-    res = await ezkl.deploy_vk_evm(
-        addr_path_vk,
-        vk_code_path,
-        rpc_url=anvil_url,
-    )
-
-    assert res == True
 
 async def test_deploy_evm():
     """
@@ -571,47 +503,6 @@ async def test_verify_evm():
 
     assert res == True
 
-async def test_verify_evm_separate_vk():
-    """
-    Verifies an evm proof
-    In order to run this you will need to install solc in your environment
-    """
-    proof_path = os.path.join(folder_path, 'test_evm.pf')
-    addr_path_verifier = os.path.join(folder_path, 'address_separate.json')
-    addr_path_vk = os.path.join(folder_path, 'address_vk.json')
-    proof_path = os.path.join(folder_path, 'test_evm.pf')
-    calldata_path = os.path.join(folder_path, 'calldata_separate.bytes')
-
-    with open(addr_path_verifier, 'r') as file:
-        addr_verifier = file.read().rstrip()
-
-    print(addr_verifier)
-
-    with open(addr_path_vk, 'r') as file:
-        addr_vk = file.read().rstrip()
-
-    print(addr_vk)
-
-    # res is now a vector of bytes
-    res = ezkl.encode_evm_calldata(proof_path, calldata_path, addr_vk=addr_vk)
-
-    assert os.path.isfile(calldata_path)
-    assert len(res) > 0
-
-    # TODO: without optimization there will be out of gas errors
-    # sol_code_path = os.path.join(folder_path, 'test.sol')
-
-    res = await ezkl.verify_evm(
-        addr_verifier,
-        proof_path,
-        rpc_url=anvil_url,
-        addr_vk=addr_vk,
-        # sol_code_path
-        # optimizer_runs
-    )
-
-    assert res == True
-
 
 async def test_aggregate_and_verify_aggr():
     data_path = os.path.join(