refactor: allow for negative stride downsample

docs/advanced_security/quantization_backdoors.md

@@ -1,20 +1,52 @@
-# EZKL Security Note: Quantization-Induced Model Backdoors
+# EZKL Security Note: Quantization-Activated Model Backdoors
 
-> Note: this only affects a situation where a party separate to an application's developer has access to the model's weights and can modify them. This is a common scenario in adversarial machine learning research, but can be less common in real-world applications. If you're building your models in house and deploying them yourself, this is less of a concern. If you're building a permisionless system where anyone can submit models, this is more of a concern.
+## Model backdoors and provenance
 
-Models processed through EZKL's quantization step can harbor backdoors that are dormant in the original full-precision model but activate during quantization. These backdoors force specific outputs when triggered, with impact varying by application.
+Machine learning models inherently suffer from robustness issues, which can lead to various
+kinds of attacks, from backdoors to evasion attacks. These vulnerabilities are a direct byproductof how machine learning models learn and cannot be remediated.
 
-Key Factors:
+We say a model has a backdoor whenever a specific attacker-chosen trigger in the input leads
+to the model misbehaving. For instance, if we have an image classifier discriminating cats from dogs, the ability to turn any image of a cat into an image classified as a dog by changing a specific pixel pattern constitutes a backdoor.
 
-- Larger models increase attack feasibility through more parameter capacity
-- Smaller quantization scales facilitate attacks by allowing greater weight modifications
-- Rebase ratio of 1 enables exploitation of convolutional layer consistency
+Backdoors can be introduced using many different vectors. An attacker can introduce a
+backdoor using traditional security vulnerabilities. For instance, they could directly alter the file containing model weights or dynamically hack the Python code of the model. In addition, backdoors can be introduced by the training data through a process known as poisoning. In this case, an attacker adds malicious data points to the dataset before the model is trained so that the model learns to associate the backdoor trigger with the intended misbehavior.
 
-Limitations: 
+All these vectors constitute a whole range of provenance challenges, as any component of an
+AI system can virtually be an entrypoint for a backdoor. Although provenance is already a
+concern with traditional code, the issue is exacerbated with AI, as retraining a model is
+cost-prohibitive. It is thus impractical to translate the “recompile it yourself” thinking to AI.
 
-- Attack effectiveness depends on calibration settings and internal rescaling operations. 
+## Quantization activated backdoors
+
+Backdoors are a generic concern in AI that is outside the scope of EZKL. However, EZKL may
+activate a specific subset of backdoors. Several academic papers have demonstrated the
+possibility, both in theory and in practice, of implanting undetectable and inactive backdoors in a full precision model that can be reactivated by quantization.
+
+An external attacker may trick the user of an application running EZKL into loading a model
+containing a quantization backdoor. This backdoor is active in the resulting model and circuit but not in the full-precision model supplied to EZKL, compromising the integrity of the target application and the resulting proof.
+
+### When is this a concern for me as a user?
+
+Any untrusted component in your AI stack may be a backdoor vector. In practice, the most
+sensitive parts include:
+
+- Datasets downloaded from the web or containing crowdsourced data
+- Models downloaded from the web even after finetuning
+- Untrusted software dependencies (well-known frameworks such as PyTorch can typically
+be considered trusted)
+- Any component loaded through an unsafe serialization format, such as Pickle.
+Because backdoors are inherent to ML and cannot be eliminated, reviewing the provenance of
+these sensitive components is especially important.
+
+### Responsibilities of the user and EZKL
+
+As EZKL cannot prevent backdoored models from being used, it is the responsibility of the user to review the provenance of all the components in their AI stack to ensure that no backdoor could have been implanted. EZKL shall not be held responsible for misleading prediction proofs resulting from using a backdoored model or for any harm caused to a system or its users due to a misbehaving model.
+
+### Limitations:
+
+- Attack effectiveness depends on calibration settings and internal rescaling operations.
 - Further research needed on backdoor persistence through witness/proof stages.
-- Can be mitigated by evaluating the quantized model (using `ezkl gen-witness`), rather than relying on the evaluation of the original model. 
+- Can be mitigated by evaluating the quantized model (using `ezkl gen-witness`), rather than relying on the evaluation of the original model in pytorch or onnx-runtime as difference in evaluation could reveal a backdoor.
 
 References:
 

docs/python/src/conf.py

@@ -1,7 +1,7 @@
 import ezkl
 
 project = 'ezkl'
-release = '20.2.4'
+release = '0.0.0'
 version = release
 
 

src/circuit/ops/base.rs

@@ -21,7 +21,10 @@ pub enum BaseOp {
 
 /// Matches a [BaseOp] to an operation over inputs
 impl BaseOp {
-    /// forward func
+    /// forward func for non-accumulating operations
+    /// # Panics
+    /// Panics if called on an accumulating operation
+    /// # Examples
     pub fn nonaccum_f<
         T: TensorType + Add<Output = T> + Sub<Output = T> + Mul<Output = T> + Neg<Output = T>,
     >(
@@ -37,7 +40,9 @@ impl BaseOp {
         }
     }
 
-    /// forward func
+    /// forward func for accumulating operations
+    /// # Panics
+    /// Panics if called on a non-accumulating operation
     pub fn accum_f<
         T: TensorType + Add<Output = T> + Sub<Output = T> + Mul<Output = T> + Neg<Output = T>,
     >(

src/circuit/ops/layouts.rs

@@ -4914,7 +4914,7 @@ pub(crate) fn downsample<F: PrimeField + TensorType + PartialOrd + std::hash::Ha
     region: &mut RegionCtx<F>,
     values: &[ValTensor<F>; 1],
     axis: &usize,
-    stride: &usize,
+    stride: &isize,
     modulo: &usize,
 ) -> Result<ValTensor<F>, CircuitError> {
     let input = region.assign(&config.custom_gates.inputs[0], &values[0])?;

src/circuit/ops/mod.rs

@@ -159,6 +159,8 @@ impl std::str::FromStr for InputType {
 
 #[cfg(all(feature = "ezkl", not(target_arch = "wasm32")))]
 impl From<DatumType> for InputType {
+    /// # Panics
+    /// Panics if the datum type is not supported
     fn from(datum_type: DatumType) -> Self {
         match datum_type {
             DatumType::Bool => InputType::Bool,
@@ -317,13 +319,8 @@ impl<F: PrimeField + TensorType + PartialOrd + std::hash::Hash> Constant<F> {
 }
 
 impl<
-        F: PrimeField
-            + TensorType
-            + PartialOrd
-            + std::hash::Hash
-            + Serialize
-            + for<'de> Deserialize<'de>,
-    > Op<F> for Constant<F>
+    F: PrimeField + TensorType + PartialOrd + std::hash::Hash + Serialize + for<'de> Deserialize<'de>,
+> Op<F> for Constant<F>
 {
     fn as_any(&self) -> &dyn Any {
         self

src/circuit/ops/poly.rs

@@ -49,7 +49,7 @@ pub enum PolyOp {
     },
     Downsample {
         axis: usize,
-        stride: usize,
+        stride: isize,
         modulo: usize,
     },
     DeConv {
@@ -108,13 +108,8 @@ pub enum PolyOp {
 }
 
 impl<
-        F: PrimeField
-            + TensorType
-            + PartialOrd
-            + std::hash::Hash
-            + Serialize
-            + for<'de> Deserialize<'de>,
-    > Op<F> for PolyOp
+    F: PrimeField + TensorType + PartialOrd + std::hash::Hash + Serialize + for<'de> Deserialize<'de>,
+> Op<F> for PolyOp
 {
     /// Returns a reference to the Any trait.
     fn as_any(&self) -> &dyn Any {
@@ -188,7 +183,8 @@ impl<
             } => {
                 format!(
                     "DECONV (stride={:?}, padding={:?}, output_padding={:?}, group={}, data_format={:?}, kernel_format={:?})",
-                    stride, padding, output_padding, group, data_format, kernel_format)
+                    stride, padding, output_padding, group, data_format, kernel_format
+                )
             }
             PolyOp::Concat { axis } => format!("CONCAT (axis={})", axis),
             PolyOp::Slice { axis, start, end } => {

src/graph/utilities.rs

@@ -1,14 +1,14 @@
-use super::errors::GraphError;
 #[cfg(all(feature = "ezkl", not(target_arch = "wasm32")))]
 use super::VarScales;
+use super::errors::GraphError;
 use super::{Rescaled, SupportedOp, Visibility};
+use crate::circuit::Op;
 #[cfg(all(feature = "ezkl", not(target_arch = "wasm32")))]
 use crate::circuit::hybrid::HybridOp;
 #[cfg(all(feature = "ezkl", not(target_arch = "wasm32")))]
 use crate::circuit::lookup::LookupOp;
 #[cfg(all(feature = "ezkl", not(target_arch = "wasm32")))]
 use crate::circuit::poly::PolyOp;
-use crate::circuit::Op;
 use crate::fieldutils::IntegerRep;
 use crate::tensor::{Tensor, TensorError, TensorType};
 use halo2curves::bn256::Fr as Fp;
@@ -22,6 +22,7 @@ use std::sync::Arc;
 use tract_onnx::prelude::{DatumType, Node as OnnxNode, TypedFact, TypedOp};
 #[cfg(all(feature = "ezkl", not(target_arch = "wasm32")))]
 use tract_onnx::tract_core::ops::{
+    Downsample,
     array::{
         Gather, GatherElements, GatherNd, MultiBroadcastTo, OneHot, ScatterElements, ScatterNd,
         Slice, Topk,
@@ -31,7 +32,6 @@ use tract_onnx::tract_core::ops::{
     einsum::EinSum,
     element_wise::ElementWiseOp,
     nn::{LeakyRelu, Reduce, Softmax},
-    Downsample,
 };
 #[cfg(all(feature = "ezkl", not(target_arch = "wasm32")))]
 use tract_onnx::tract_hir::{
@@ -1398,7 +1398,7 @@ pub fn new_op_from_onnx(
 
             SupportedOp::Linear(PolyOp::Downsample {
                 axis: downsample_node.axis,
-                stride: downsample_node.stride as usize,
+                stride: downsample_node.stride,
                 modulo: downsample_node.modulo,
             })
         }

src/pfsys/mod.rs

@@ -17,16 +17,16 @@ use crate::{Commitments, EZKL_BUF_CAPACITY, EZKL_KEY_FORMAT};
 use clap::ValueEnum;
 use halo2_proofs::circuit::Value;
 use halo2_proofs::plonk::{
-    create_proof, keygen_pk, keygen_vk_custom, verify_proof, Circuit, ProvingKey, VerifyingKey,
+    Circuit, ProvingKey, VerifyingKey, create_proof, keygen_pk, keygen_vk_custom, verify_proof,
 };
+use halo2_proofs::poly::VerificationStrategy;
 use halo2_proofs::poly::commitment::{CommitmentScheme, Params, ParamsProver, Prover, Verifier};
 use halo2_proofs::poly::ipa::commitment::IPACommitmentScheme;
 use halo2_proofs::poly::kzg::commitment::KZGCommitmentScheme;
-use halo2_proofs::poly::VerificationStrategy;
 use halo2_proofs::transcript::{EncodedChallenge, TranscriptReadBuffer, TranscriptWriterBuffer};
+use halo2curves::CurveAffine;
 use halo2curves::ff::{FromUniformBytes, PrimeField, WithSmallOrderMulGroup};
 use halo2curves::serde::SerdeObject;
-use halo2curves::CurveAffine;
 use instant::Instant;
 use log::{debug, info, trace};
 #[cfg(not(feature = "det-prove"))]
@@ -51,6 +51,9 @@ use pyo3::types::PyDictMethods;
 
 use halo2curves::bn256::{Bn256, Fr, G1Affine};
 
+/// Converts a string to a `SerdeFormat`.
+/// # Panics
+/// Panics if the provided `s` is not a valid `SerdeFormat` (i.e. not one of "processed", "raw-bytes-unchecked", or "raw-bytes").
 fn serde_format_from_str(s: &str) -> halo2_proofs::SerdeFormat {
     match s {
         "processed" => halo2_proofs::SerdeFormat::Processed,
@@ -321,7 +324,7 @@ where
 }
 
 #[cfg(feature = "python-bindings")]
-use pyo3::{types::PyDict, PyObject, Python, ToPyObject};
+use pyo3::{PyObject, Python, ToPyObject, types::PyDict};
 #[cfg(feature = "python-bindings")]
 impl<F: PrimeField + SerdeObject + Serialize, C: CurveAffine + Serialize> ToPyObject for Snark<F, C>
 where
@@ -345,9 +348,9 @@ where
 }
 
 impl<
-        F: PrimeField + SerdeObject + Serialize + FromUniformBytes<64> + DeserializeOwned,
-        C: CurveAffine + Serialize + DeserializeOwned,
-    > Snark<F, C>
+    F: PrimeField + SerdeObject + Serialize + FromUniformBytes<64> + DeserializeOwned,
+    C: CurveAffine + Serialize + DeserializeOwned,
+> Snark<F, C>
 where
     C::Scalar: Serialize + DeserializeOwned,
     C::ScalarExt: Serialize + DeserializeOwned,

src/tensor/mod.rs

@@ -27,7 +27,7 @@ pub use var::*;
 
 use crate::{
     circuit::utils,
-    fieldutils::{integer_rep_to_felt, IntegerRep},
+    fieldutils::{IntegerRep, integer_rep_to_felt},
     graph::Visibility,
 };
 
@@ -415,7 +415,7 @@ impl<T: Clone + TensorType + PrimeField> Tensor<T> {
                 Err(_) => {
                     return Err(TensorError::FileLoadError(
                         "Failed to read tensor".to_string(),
-                    ))
+                    ));
                 }
             }
         }
@@ -1261,7 +1261,7 @@ impl<T: Clone + TensorType> Tensor<T> {
             None => {
                 return Err(TensorError::DimError(
                     "Cannot get last element of empty tensor".to_string(),
-                ))
+                ));
             }
         };
 
@@ -1286,7 +1286,7 @@ impl<T: Clone + TensorType> Tensor<T> {
             None => {
                 return Err(TensorError::DimError(
                     "Cannot get first element of empty tensor".to_string(),
-                ))
+                ));
             }
         };
 
@@ -1699,8 +1699,8 @@ impl<T: TensorType + Rem<Output = T> + std::marker::Send + std::marker::Sync + P
 
         lhs.par_iter_mut()
             .zip(rhs)
-            .map(|(o, r)| {
-                match T::zero() { Some(zero) => {
+            .map(|(o, r)| match T::zero() {
+                Some(zero) => {
                     if r != zero {
                         *o = o.clone() % r;
                         Ok(())
@@ -1709,11 +1709,10 @@ impl<T: TensorType + Rem<Output = T> + std::marker::Send + std::marker::Sync + P
                             "Cannot divide by zero in remainder".to_string(),
                         ))
                     }
-                } _ => {
-                    Err(TensorError::InvalidArgument(
-                        "Undefined zero value".to_string(),
-                    ))
-                }}
+                }
+                _ => Err(TensorError::InvalidArgument(
+                    "Undefined zero value".to_string(),
+                )),
             })
             .collect::<Result<Vec<_>, _>>()?;
 

src/tensor/ops.rs

@@ -535,30 +535,101 @@ pub fn mult<T: TensorType + Mul<Output = T> + std::marker::Send + std::marker::S
 /// let result = downsample(&x, 1, 2, 2).unwrap();
 /// let expected = Tensor::<IntegerRep>::new(Some(&[3, 6]), &[2, 1]).unwrap();
 /// assert_eq!(result, expected);
+/// let x = Tensor::<IntegerRep>::new(
+///     Some(&[1, 2, 3, 4, 5, 6]),
+///     &[2, 3],
+/// ).unwrap();
+///
+/// // Test case 1: Negative stride along dimension 0
+/// // This should flip the order along dimension 0
+/// let result = downsample(&x, 0, -1, 0).unwrap();
+/// let expected = Tensor::<IntegerRep>::new(
+///     Some(&[4, 5, 6, 1, 2, 3]), // Flipped order of rows
+///     &[2, 3]
+/// ).unwrap();
+/// assert_eq!(result, expected);
+///
+/// // Test case 2: Negative stride along dimension 1
+/// // This should flip the order along dimension 1
+/// let result = downsample(&x, 1, -1, 0).unwrap();
+/// let expected = Tensor::<IntegerRep>::new(
+///     Some(&[3, 2, 1, 6, 5, 4]), // Flipped order of columns
+///     &[2, 3]
+/// ).unwrap();
+/// assert_eq!(result, expected);
+///
+/// // Test case 3: Negative stride with stride magnitude > 1
+/// // This should both skip and flip
+/// let result = downsample(&x, 1, -2, 0).unwrap();
+/// let expected = Tensor::<IntegerRep>::new(
+///     Some(&[3, 1, 6, 4]), // Take every 2nd element in reverse
+///     &[2, 2]
+/// ).unwrap();
+/// assert_eq!(result, expected);
+///
+/// // Test case 4: Negative stride with non-zero modulo
+/// // This should start at (size - 1 - modulo) and reverse
+/// let result = downsample(&x, 1, -2, 1).unwrap();
+/// let expected = Tensor::<IntegerRep>::new(
+///     Some(&[2, 5]), // Start at second element from end, take every 2nd in reverse
+///     &[2, 1]
+/// ).unwrap();
+/// assert_eq!(result, expected);
+///
+/// // Create a larger test case for more complex downsampling
+/// let y = Tensor::<IntegerRep>::new(
+///     Some(&[1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12]),
+///     &[3, 4],
+/// ).unwrap();
+///
+/// // Test case 5: Negative stride with modulo on larger tensor
+/// let result = downsample(&y, 1, -2, 1).unwrap();
+/// let expected = Tensor::<IntegerRep>::new(
+///     Some(&[3, 1, 7, 5, 11, 9]), // Start at one after reverse, take every 2nd
+///     &[3, 2]
+/// ).unwrap();
+/// assert_eq!(result, expected);
+/// ```
 pub fn downsample<T: TensorType + Send + Sync>(
     input: &Tensor<T>,
     dim: usize,
-    stride: usize,
+    stride: isize, // Changed from usize to isize to support negative strides
     modulo: usize,
 ) -> Result<Tensor<T>, TensorError> {
-    let mut output_shape = input.dims().to_vec();
-    // now downsample along axis dim offset by modulo, rounding up (+1 if remaidner is non-zero)
-    let remainder = (input.dims()[dim] - modulo) % stride;
-    let div = (input.dims()[dim] - modulo) / stride;
-    output_shape[dim] = div + (remainder > 0) as usize;
-    let mut output = Tensor::<T>::new(None, &output_shape)?;
+    // Handle negative stride case
+    if stride == 0 {
+        return Err(TensorError::DimMismatch(
+            "downsample stride cannot be zero".to_string(),
+        ));
+    }
 
-    if modulo > input.dims()[dim] {
+    let stride_abs = stride.unsigned_abs();
+    let mut output_shape = input.dims().to_vec();
+
+    if modulo >= input.dims()[dim] {
         return Err(TensorError::DimMismatch("downsample".to_string()));
     }
 
-    // now downsample along axis dim offset by modulo
+    // Calculate output shape based on the absolute value of stride
+    let remainder = (input.dims()[dim] - modulo) % stride_abs;
+    let div = (input.dims()[dim] - modulo) / stride_abs;
+    output_shape[dim] = div + (remainder > 0) as usize;
+
+    let mut output = Tensor::<T>::new(None, &output_shape)?;
+
+    // Calculate indices based on stride direction
     let indices = (0..output_shape.len())
         .map(|i| {
             if i == dim {
                 let mut index = vec![0; output_shape[i]];
-                for (i, idx) in index.iter_mut().enumerate() {
-                    *idx = i * stride + modulo;
+                for (j, idx) in index.iter_mut().enumerate() {
+                    if stride > 0 {
+                        // Positive stride: move forward from modulo
+                        *idx = j * stride_abs + modulo;
+                    } else {
+                        // Negative stride: move backward from (size - 1 - modulo)
+                        *idx = (input.dims()[dim] - 1 - modulo) - j * stride_abs;
+                    }
                 }
                 index
             } else {

src/tensor/var.rs

@@ -2,7 +2,7 @@ use std::collections::HashSet;
 
 use log::{debug, error, warn};
 
-use crate::circuit::{region::ConstantsMap, CheckMode};
+use crate::circuit::{CheckMode, region::ConstantsMap};
 
 use super::*;
 /// A wrapper around Halo2's Column types that represents a tensor of variables in the circuit.
@@ -403,7 +403,10 @@ impl VarTensor {
         let mut assigned_coord = 0;
         let mut res: ValTensor<F> = match values {
             ValTensor::Instance { .. } => {
-                unimplemented!("cannot assign instance to advice columns with omissions")
+                error!(
+                    "assignment with omissions is not supported on instance columns. increase K if you require more rows."
+                );
+                Err(halo2_proofs::plonk::Error::Synthesis)
             }
             ValTensor::Value { inner: v, .. } => Ok::<ValTensor<F>, halo2_proofs::plonk::Error>(
                 v.enum_map(|coord, k| {
@@ -569,8 +572,13 @@ impl VarTensor {
         constants: &mut ConstantsMap<F>,
     ) -> Result<(ValTensor<F>, usize), halo2_proofs::plonk::Error> {
         match values {
-            ValTensor::Instance { .. } => unimplemented!("duplication is not supported on instance columns. increase K if you require more rows."),
-            ValTensor::Value { inner: v, dims , ..} => {
+            ValTensor::Instance { .. } => {
+                error!(
+                    "duplication is not supported on instance columns. increase K if you require more rows."
+                );
+                Err(halo2_proofs::plonk::Error::Synthesis)
+            }
+            ValTensor::Value { inner: v, dims, .. } => {
                 let duplication_freq = if single_inner_col {
                     self.col_size()
                 } else {
@@ -583,21 +591,20 @@ impl VarTensor {
                     self.num_inner_cols()
                 };
 
-                let duplication_offset = if single_inner_col {
-                    row
-                } else {
-                    offset
-                };
-
+                let duplication_offset = if single_inner_col { row } else { offset };
 
                 // duplicates every nth element to adjust for column overflow
-                let mut res: ValTensor<F> = v.duplicate_every_n(duplication_freq, num_repeats, duplication_offset).unwrap().into();
+                let mut res: ValTensor<F> = v
+                    .duplicate_every_n(duplication_freq, num_repeats, duplication_offset)
+                    .unwrap()
+                    .into();
 
                 let constants_map = res.create_constants_map();
                 constants.extend(constants_map);
 
                 let total_used_len = res.len();
-                res.remove_every_n(duplication_freq, num_repeats, duplication_offset).unwrap();
+                res.remove_every_n(duplication_freq, num_repeats, duplication_offset)
+                    .unwrap();
 
                 res.reshape(dims).unwrap();
                 res.set_scale(values.scale());
@@ -627,9 +634,13 @@ impl VarTensor {
         constants: &mut ConstantsMap<F>,
     ) -> Result<(ValTensor<F>, usize), halo2_proofs::plonk::Error> {
         match values {
-            ValTensor::Instance { .. } => unimplemented!("duplication is not supported on instance columns. increase K if you require more rows."),
-            ValTensor::Value { inner: v, dims , ..} => {
-
+            ValTensor::Instance { .. } => {
+                error!(
+                    "duplication is not supported on instance columns. increase K if you require more rows."
+                );
+                Err(halo2_proofs::plonk::Error::Synthesis)
+            }
+            ValTensor::Value { inner: v, dims, .. } => {
                 let duplication_freq = self.block_size();
 
                 let num_repeats = self.num_inner_cols();
@@ -637,17 +648,31 @@ impl VarTensor {
                 let duplication_offset = offset;
 
                 // duplicates every nth element to adjust for column overflow
-                let v = v.duplicate_every_n(duplication_freq, num_repeats, duplication_offset).unwrap();
+                let v = v
+                    .duplicate_every_n(duplication_freq, num_repeats, duplication_offset)
+                    .map_err(|e| {
+                        error!("Error duplicating values: {:?}", e);
+                        halo2_proofs::plonk::Error::Synthesis
+                    })?;
                 let mut res: ValTensor<F> = {
                     v.enum_map(|coord, k| {
-                    let cell = self.assign_value(region, offset, k.clone(), coord, constants)?;
-                    Ok::<_, halo2_proofs::plonk::Error>(cell)
-
-                })?.into()};
+                        let cell =
+                            self.assign_value(region, offset, k.clone(), coord, constants)?;
+                        Ok::<_, halo2_proofs::plonk::Error>(cell)
+                    })?
+                    .into()
+                };
                 let total_used_len = res.len();
-                res.remove_every_n(duplication_freq, num_repeats, duplication_offset).unwrap();
+                res.remove_every_n(duplication_freq, num_repeats, duplication_offset)
+                    .map_err(|e| {
+                        error!("Error duplicating values: {:?}", e);
+                        halo2_proofs::plonk::Error::Synthesis
+                    })?;
 
-                res.reshape(dims).unwrap();
+                res.reshape(dims).map_err(|e| {
+                    error!("Error duplicating values: {:?}", e);
+                    halo2_proofs::plonk::Error::Synthesis
+                })?;
                 res.set_scale(values.scale());
 
                 Ok((res, total_used_len))
@@ -681,61 +706,71 @@ impl VarTensor {
         let mut prev_cell = None;
 
         match values {
-            ValTensor::Instance { .. } => unimplemented!("duplication is not supported on instance columns. increase K if you require more rows."),
-            ValTensor::Value { inner: v, dims , ..} => {
-
+            ValTensor::Instance { .. } => {
+                error!(
+                    "duplication is not supported on instance columns. increase K if you require more rows."
+                );
+                Err(halo2_proofs::plonk::Error::Synthesis)
+            }
+            ValTensor::Value { inner: v, dims, .. } => {
                 let duplication_freq = self.col_size();
                 let num_repeats = 1;
                 let duplication_offset = row;
 
                 // duplicates every nth element to adjust for column overflow
-                let v = v.duplicate_every_n(duplication_freq, num_repeats, duplication_offset).unwrap();
-                let mut res: ValTensor<F> =
-                    v.enum_map(|coord, k| {
+                let v = v
+                    .duplicate_every_n(duplication_freq, num_repeats, duplication_offset)
+                    .unwrap();
+                let mut res: ValTensor<F> = v
+                    .enum_map(|coord, k| {
+                        let step = self.num_inner_cols();
 
-                    let step = self.num_inner_cols();
+                        let (x, y, z) = self.cartesian_coord(offset + coord * step);
+                        if matches!(check_mode, CheckMode::SAFE) && coord > 0 && z == 0 && y == 0 {
+                            // assert that duplication occurred correctly
+                            assert_eq!(
+                                Into::<IntegerRep>::into(k.clone()),
+                                Into::<IntegerRep>::into(v[coord - 1].clone())
+                            );
+                        };
 
-                    let (x, y, z) = self.cartesian_coord(offset + coord * step);
-                    if matches!(check_mode, CheckMode::SAFE) && coord > 0 && z == 0 && y == 0 {
-                        // assert that duplication occurred correctly
-                        assert_eq!(Into::<IntegerRep>::into(k.clone()), Into::<IntegerRep>::into(v[coord - 1].clone()));
-                    };
+                        let cell =
+                            self.assign_value(region, offset, k.clone(), coord * step, constants)?;
 
-                    let cell = self.assign_value(region, offset, k.clone(), coord * step, constants)?;
+                        let at_end_of_column = z == duplication_freq - 1;
+                        let at_beginning_of_column = z == 0;
 
-                    let at_end_of_column = z == duplication_freq - 1;
-                    let at_beginning_of_column = z == 0;
-
-                    if at_end_of_column {
-                        // if we are at the end of the column, we need to copy the cell to the next column
-                        prev_cell = Some(cell.clone());
-                    } else if coord > 0 && at_beginning_of_column  {
-                        if let Some(prev_cell) = prev_cell.as_ref() {
-                            let cell = if let Some(cell) = cell.cell() {
-                                cell
+                        if at_end_of_column {
+                            // if we are at the end of the column, we need to copy the cell to the next column
+                            prev_cell = Some(cell.clone());
+                        } else if coord > 0 && at_beginning_of_column {
+                            if let Some(prev_cell) = prev_cell.as_ref() {
+                                let cell = if let Some(cell) = cell.cell() {
+                                    cell
+                                } else {
+                                    error!("Error getting cell: {:?}", (x, y));
+                                    return Err(halo2_proofs::plonk::Error::Synthesis);
+                                };
+                                let prev_cell = if let Some(prev_cell) = prev_cell.cell() {
+                                    prev_cell
+                                } else {
+                                    error!("Error getting prev cell: {:?}", (x, y));
+                                    return Err(halo2_proofs::plonk::Error::Synthesis);
+                                };
+                                region.constrain_equal(prev_cell, cell)?;
                             } else {
-                                error!("Error getting cell: {:?}", (x,y));
+                                error!("Previous cell was not set");
                                 return Err(halo2_proofs::plonk::Error::Synthesis);
-                            };
-                            let prev_cell = if let Some(prev_cell) = prev_cell.cell() {
-                                prev_cell
-                            } else {
-                                error!("Error getting prev cell: {:?}", (x,y));
-                                return Err(halo2_proofs::plonk::Error::Synthesis);
-                            };
-                            region.constrain_equal(prev_cell,cell)?;
-                        } else {
-                            error!("Previous cell was not set");
-                            return Err(halo2_proofs::plonk::Error::Synthesis);
+                            }
                         }
-                    }
 
-                    Ok(cell)
-
-                })?.into();
+                        Ok(cell)
+                    })?
+                    .into();
 
                 let total_used_len = res.len();
-                res.remove_every_n(duplication_freq, num_repeats, duplication_offset).unwrap();
+                res.remove_every_n(duplication_freq, num_repeats, duplication_offset)
+                    .unwrap();
 
                 res.reshape(dims).unwrap();
                 res.set_scale(values.scale());
@@ -771,21 +806,30 @@ impl VarTensor {
                 VarTensor::Advice { inner: advices, .. } => {
                     ValType::PrevAssigned(region.assign_advice(|| "k", advices[x][y], z, || v)?)
                 }
-                _ => unimplemented!(),
+                _ => {
+                    error!("VarTensor was not initialized");
+                    return Err(halo2_proofs::plonk::Error::Synthesis);
+                }
             },
             // Handle copying previously assigned value
             ValType::PrevAssigned(v) => match &self {
                 VarTensor::Advice { inner: advices, .. } => {
                     ValType::PrevAssigned(v.copy_advice(|| "k", region, advices[x][y], z)?)
                 }
-                _ => unimplemented!(),
+                _ => {
+                    error!("VarTensor was not initialized");
+                    return Err(halo2_proofs::plonk::Error::Synthesis);
+                }
             },
             // Handle copying previously assigned constant
             ValType::AssignedConstant(v, val) => match &self {
                 VarTensor::Advice { inner: advices, .. } => {
                     ValType::AssignedConstant(v.copy_advice(|| "k", region, advices[x][y], z)?, val)
                 }
-                _ => unimplemented!(),
+                _ => {
+                    error!("VarTensor was not initialized");
+                    return Err(halo2_proofs::plonk::Error::Synthesis);
+                }
             },
             // Handle assigning evaluated value
             ValType::AssignedValue(v) => match &self {
@@ -794,7 +838,10 @@ impl VarTensor {
                         .assign_advice(|| "k", advices[x][y], z, || v)?
                         .evaluate(),
                 ),
-                _ => unimplemented!(),
+                _ => {
+                    error!("VarTensor was not initialized");
+                    return Err(halo2_proofs::plonk::Error::Synthesis);
+                }
             },
             // Handle constant value assignment with caching
             ValType::Constant(v) => {

tests/integration_tests.rs

@@ -1,12 +1,12 @@
 #[cfg(all(feature = "ezkl", not(target_arch = "wasm32")))]
 #[cfg(test)]
 mod native_tests {
-    
+
     // use ezkl::circuit::table::RESERVED_BLINDING_ROWS_PAD;
+    use ezkl::Commitments;
     use ezkl::graph::input::{FileSource, FileSourceInner, GraphData};
     use ezkl::graph::{DataSource, GraphSettings, GraphWitness};
     use ezkl::pfsys::Snark;
-    use ezkl::Commitments;
     use halo2_proofs::poly::kzg::commitment::KZGCommitmentScheme;
     use halo2curves::bn256::Bn256;
     use lazy_static::lazy_static;
@@ -522,7 +522,7 @@ mod native_tests {
             use crate::native_tests::run_js_tests;
             use crate::native_tests::render_circuit;
             use crate::native_tests::model_serialization_different_binaries;
-            
+
             use tempdir::TempDir;
             use ezkl::Commitments;
 
@@ -2293,7 +2293,12 @@ mod native_tests {
                 .expect("failed to execute process");
 
             if status.success() {
-                log::error!("Verification unexpectedly succeeded for modified proof {}. Flipped bit {} in byte {}", i, random_bit, random_byte);
+                log::error!(
+                    "Verification unexpectedly succeeded for modified proof {}. Flipped bit {} in byte {}",
+                    i,
+                    random_bit,
+                    random_byte
+                );
             }
 
             assert!(