v0.18.3

lerna.json

@@ -4,5 +4,5 @@
   ],
   "npmClient": "yarn",
   "useWorkspaces": true,
-  "version": "0.18.2"
+  "version": "0.18.3"
 }

packages/foam-vscode/CHANGELOG.md

@@ -4,6 +4,12 @@ All notable changes to the "foam-vscode" extension will be documented in this fi
 
 Check [Keep a Changelog](http://keepachangelog.com/) for recommendations on how to structure this file.
 
+## [0.18.3] - 2022-04-17
+
+Fixes and Improvements:
+- Better reporting when links fail to resolve
+- Failing link resolution during graph computation no longer fatal
+
 ## [0.18.2] - 2022-04-14
 
 Fixes and Improvements:

packages/foam-vscode/package.json

@@ -8,7 +8,7 @@
     "type": "git"
   },
   "homepage": "https://github.com/foambubble/foam",
-  "version": "0.18.2",
+  "version": "0.18.3",
   "license": "MIT",
   "publisher": "foam",
   "engines": {

packages/foam-vscode/src/core/model/graph.ts

@@ -107,8 +107,18 @@ export class FoamGraph implements IDisposable {
 
     for (const resource of this.workspace.resources()) {
       for (const link of resource.links) {
-        const targetUri = this.workspace.resolveLink(resource, link);
-        this.connect(resource.uri, targetUri, link);
+        try {
+          const targetUri = this.workspace.resolveLink(resource, link);
+          this.connect(resource.uri, targetUri, link);
+        } catch (e) {
+          Logger.error(
+            `Error while resolving link ${
+              link.rawText
+            } in ${resource.uri.toFsPath()}, skipping.`,
+            link,
+            e
+          );
+        }
       }
     }
 

packages/foam-vscode/src/core/services/markdown-link.ts

@@ -9,27 +9,31 @@ export abstract class MarkdownLink {
   );
 
   public static analyzeLink(link: ResourceLink) {
-    if (link.type === 'wikilink') {
-      const [, target, section, alias] = this.wikilinkRegex.exec(link.rawText);
-      return {
-        target: target?.replace(/\\/g, '') ?? '',
-        section: section ?? '',
-        alias: alias ?? '',
-      };
+    try {
+      if (link.type === 'wikilink') {
+        const [, target, section, alias] = this.wikilinkRegex.exec(
+          link.rawText
+        );
+        return {
+          target: target?.replace(/\\/g, '') ?? '',
+          section: section ?? '',
+          alias: alias ?? '',
+        };
+      }
+      if (link.type === 'link') {
+        const [, alias, target, section] = this.directLinkRegex.exec(
+          link.rawText
+        );
+        return {
+          target: target ?? '',
+          section: section ?? '',
+          alias: alias ?? '',
+        };
+      }
+      throw new Error(`Link of type ${link.type} is not supported`);
+    } catch (e) {
+      throw new Error(`Couldn't parse link ${link.rawText} - ${e}`);
     }
-    if (link.type === 'link') {
-      const [, alias, target, section] = this.directLinkRegex.exec(
-        link.rawText
-      );
-      return {
-        target: target ?? '',
-        section: section ?? '',
-        alias: alias ?? '',
-      };
-    }
-    throw new Error(
-      `Unexpected state: link of type ${link.type} is not supported`
-    );
   }
 
   public static createUpdateLinkEdit(