test

This reverts commit 85ca6d796510f0ed0564dc93bc3e9fd7f02e43dd.

DEVELOPER.md

@@ -207,6 +207,29 @@ variables for each source.
 * SQLite -  setup in the integration test, where we create a temporary database
   file
 
+## Link Checking and Fixing with Lychee
+
+We use **[lychee](https://github.com/lycheeverse/lychee-action)** for repository link checks.
+
+* To run the checker **locally**, see the [command-line usage guide](https://github.com/lycheeverse/lychee?tab=readme-ov-file#commandline-usage).
+
+
+
+###  Fixing Broken Links
+
+1.  **Update the Link:** Correct the broken URL or update the content where it is used.
+2.  **Ignore the Link:** If you can't fix the link (e.g., due to **external rate-limits** or if it's a **local-only URL**), tell Lychee to **ignore** it.
+
+    * List **regular expressions** or **direct links** in the **[.lycheeignore](https://github.com/googleapis/genai-toolbox/blob/main/.lycheeignore)** file, one entry per line.
+    * **Always add a comment** explaining **why** the link is being skipped to prevent link rot. **Example `.lycheeignore`:**
+       ```text
+       # These are email addresses, not standard web URLs, and usually cause check failures.
+       ^mailto:.*
+       ```
+> [!NOTE]
+> **GitHub Action Check**: The link checker runs against the raw Markdown files in the repository structure, treating links as relative file paths (e.g., ../content/page.md).<br>
+> **Hugo Server**: The static site generator resolves links based on the final clean URL structure (e.g., /page/) and the configured baseURL.<br>
+> **Crucial Difference**: A link that works as a file path for the GitHub Action (e.g., ./image.png) may break in the final HTML generated by Hugo if the URL path is different, and vice-versa. You must ensure your linking strategy—often using root-relative paths (/path/) or Hugo Page Bundles—works seamlessly for both.
 ### Other GitHub Checks
 
 * License header check (`.github/header-checker-lint.yml`) - Ensures files have

tests/alloydb/alloydb_integration_test.go

@@ -597,6 +597,7 @@ func runAlloyDBListInstancesTest(t *testing.T, vars map[string]string) {
 
 	// NOTE: If clusters or instances are added, removed or changed in the test project,
 	// the below lists must be updated for the tests to pass.
+	
 	wantForAllClustersSpecificLocation := []string{
 		fmt.Sprintf("projects/%s/locations/%s/clusters/alloydb-ai-nl-testing/instances/alloydb-ai-nl-testing-instance", vars["project"], vars["location"]),
 		fmt.Sprintf("projects/%s/locations/%s/clusters/alloydb-pg-testing/instances/alloydb-pg-testing-instance", vars["project"], vars["location"]),

tests/alloydbpg/alloydb_pg_integration_test.go

@@ -169,6 +169,7 @@ func TestAlloyDBPgToolEndpoints(t *testing.T) {
 		t.Fatalf("toolbox didn't start successfully: %s", err)
 	}
 
+	
 	// Get configs for tests
 	select1Want, failInvocationWant, createTableStatement, mcpSelect1Want := tests.GetPostgresWants()
 

tests/clickhouse/clickhouse_integration_test.go

@@ -345,6 +345,8 @@ func getClickHouseWants() (string, string, string, string, string) {
 	return select1Want, mcpSelect1Want, mcpMyFailToolWant, createTableStatement, nullWant
 }
 
+
+
 func TestClickHouseSQLTool(t *testing.T) {
 	_ = getClickHouseVars(t)
 	ctx, cancel := context.WithTimeout(context.Background(), time.Minute)

tests/couchbase/couchbase_integration_test.go

@@ -167,8 +167,26 @@ func setupCouchbaseCollection(t *testing.T, ctx context.Context, cluster *gocb.C
 		t.Fatalf("failed to connect to bucket: %v", err)
 	}
 
-	// Create scope if it doesn't exist
 	bucketMgr := bucket.CollectionsV2()
+	
+	// If the test failed before, the collection might still exist.
+	// We drop it here to start clean and prevent collection count bloat.
+    // Use a short context for this administrative operation.
+	dropCtx, dropCancel := context.WithTimeout(ctx, 10*time.Second)
+	defer dropCancel()
+	
+	// Attempt to drop the collection (ignore "not found" error, which is expected sometimes)
+	err = bucketMgr.DropCollection(scopeName, collectionName, &gocb.DropCollectionOptions{
+		Context: dropCtx,
+    })
+    
+    // Log a warning if drop failed but isn't due to "not found"
+	if err != nil && !strings.Contains(err.Error(), "not found") {
+		t.Logf("WARN: Pre-emptive drop of %s.%s failed: %v", scopeName, collectionName, err)
+	}
+	
+	
+	// Create scope if it doesn't exist
 	err = bucketMgr.CreateScope(scopeName, nil)
 	if err != nil && !strings.Contains(err.Error(), "already exists") {
 		t.Logf("failed to create scope (might already exist): %v", err)
@@ -223,10 +241,24 @@ func setupCouchbaseCollection(t *testing.T, ctx context.Context, cluster *gocb.C
 
 	// Return a cleanup function
 	return func(t *testing.T) {
+		// --- FIX: ROBUST TEARDOWN ---
+        // Use a dedicated context for cleanup.
+        cleanupCtx, cleanupCancel := context.WithTimeout(context.Background(), 10*time.Second)
+        defer cleanupCancel()
+		
 		// Drop the collection
-		err := bucketMgr.DropCollection(scopeName, collectionName, nil)
+		// err := bucketMgr.DropCollection(scopeName, collectionName, nil)
+		err := bucketMgr.DropCollection(scopeName, collectionName, &gocb.DropCollectionOptions{
+            Context: cleanupCtx,
+        })
+		// if err != nil {
+		// 	t.Logf("failed to drop collection: %v", err)
+		// }
 		if err != nil {
-			t.Logf("failed to drop collection: %v", err)
+            // Only log if it's not a "not found" error (which is fine during teardown)
+			if !strings.Contains(err.Error(), "not found") {
+                t.Logf("ERROR: Teardown failed to drop collection %s.%s: %v", scopeName, collectionName, err)
+            }
 		}
 	}
 }

tests/mindsdb/mindsdb_integration_test.go

@@ -225,7 +225,7 @@ func TestMindsDBToolEndpoints(t *testing.T) {
 	}
 	defer cleanup()
 
-	waitCtx, cancel := context.WithTimeout(ctx, 10*time.Second)
+	waitCtx, cancel := context.WithTimeout(ctx, 2*time.Minute)
 	defer cancel()
 	out, err := testutils.WaitForString(waitCtx, regexp.MustCompile(`Server ready to serve`), cmd.Out)
 	if err != nil {