github/ghidra
1
1
Fork 0
mirror of https://github.com/NationalSecurityAgency/ghidra.git synced 2026-01-10 14:38:02 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge remote-tracking branch 'origin/GP-5697_ghizard_PDB_provide_post-analysis_popup_when_PDB_not_found' into Ghidra_11.4

Browse Source
This commit is contained in:
Ryan Kurtz
2025-05-16 12:05:41 -04:00
parent 0b8985a257 2f51ec305c
commit 69608f2751
2 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
Ghidra/Features/PDB/src/main/java/ghidra/app/plugin/core/analysis/PdbAnalyzer.java
View File

@@ -87,7 +87,9 @@ public class PdbAnalyzer extends AbstractAnalyzer {
File pdbFile = PdbAnalyzerCommon.findPdb(this, program, searchUntrustedLocations, monitor);
if (pdbFile == null) {
// warnings have already been logged
// Warnings have already been logged, but nice to have a post-analysis pop-up that
// PDB analysis was not done
log.appendMsg(NAME, "Aborted: Could not find an appropriate PDB file; see log");
return false;
}
@@ -156,7 +158,7 @@ public class PdbAnalyzer extends AbstractAnalyzer {
* Normally the analyzer would locate the PDB file on its own, but if a
* headless script wishes to override the analyzer's behaivor, it can
* use this method to specify a file.
*
*
* @param program {@link Program}
* @param pdbFile the pdb file
*/
@@ -171,7 +173,7 @@ public class PdbAnalyzer extends AbstractAnalyzer {
* Normally when the analyzer attempts to locate a matching PDB file it
* will default to NOT searching untrusted symbol servers. A headless script could
* use this method to allow the analyzer to search untrusted symbol servers.
*
*
* @param program {@link Program}
* @param allowUntrusted boolean flag, true means analyzer can search untrusted symbol
* servers

4
Ghidra/Features/PDB/src/main/java/ghidra/app/plugin/core/analysis/PdbUniversalAnalyzer.java
View File

@@ -167,7 +167,9 @@ public class PdbUniversalAnalyzer extends AbstractAnalyzer {
pdbFile = PdbAnalyzerCommon.findPdb(this, program, searchUntrustedLocations, monitor);
}
if (pdbFile == null) {
// warnings have already been logged
// Warnings have already been logged, but nice to have a post-analysis pop-up that
// PDB analysis was not done
log.appendMsg(NAME, "Aborted: Could not find an appropriate PDB file; see log");
return false;
}