github/ghidra
1
1
Fork 0
mirror of https://github.com/NationalSecurityAgency/ghidra.git synced 2026-01-10 06:27:59 -05:00
Code Issues Packages Projects Releases Wiki Activity

GP-1495 added check for error decompiling function and put bad bookmarks if it happens.

Browse Source
This commit is contained in:
ghidra007
2021-11-16 11:48:08 -05:00
committed by ghidra1
parent 71c476bb6a
commit e2257ce96a
1 changed files with 18 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
Ghidra/Features/Decompiler/ghidra_scripts/classrecovery/RecoveredClassUtils.java
View File

@@ -3313,6 +3313,24 @@ public class RecoveredClassUtils {
// listing has void too, otherwise, leave it as is, probably a void
String returnType = getReturnTypeFromDecompiler(constructorFunction);
// Set error bookmark, add error message, and get the listing return type if the
// decompiler return type is null
if (returnType == null) {
String error = "Decompiler Error: The decompiler failed to decompile function at " +
constructorFunction.getEntryPoint().toString() +
" possibly due to the addition of " + className + " class structure.";
Msg.debug(this, error);
program.getBookmarkManager().setBookmark(constructorFunction.getEntryPoint(),
BookmarkType.ERROR, "Decompiler Error", error);
// get the return type from the listing and in some cases it will
// indicate the correct type to help determine the below type to add
returnType = constructorFunction.getReturnType().getDisplayName();
}
if (returnType.equals("void")) {
DataType voidDataType = new VoidDataType();
constructorFunction.setReturnType(voidDataType, SourceType.ANALYSIS);