mirror of
https://github.com/h5bp/html5-boilerplate.git
synced 2026-01-09 14:48:02 -05:00
node 18+ (#3104)
* node 18+ * Remove LGTM mention (service is no longer available) --------- Co-authored-by: Christian Oliff <christianoliff@pm.me>
This commit is contained in:
2
.github/workflows/test.yml
vendored
2
.github/workflows/test.yml
vendored
@@ -14,7 +14,7 @@ jobs:
|
|||||||
runs-on: ubuntu-latest
|
runs-on: ubuntu-latest
|
||||||
strategy:
|
strategy:
|
||||||
matrix:
|
matrix:
|
||||||
node-version: [16.x, 18.x]
|
node-version: [18.x, 20.x]
|
||||||
steps:
|
steps:
|
||||||
- name: Get npm cache directory
|
- name: Get npm cache directory
|
||||||
id: npm-cache
|
id: npm-cache
|
||||||
|
|||||||
@@ -50,8 +50,8 @@ Our branch protection rules are as follows:
|
|||||||
- We require a pull request (PR) with one approving reviewer to merge code
|
- We require a pull request (PR) with one approving reviewer to merge code
|
||||||
- In addition to the PR and approving reviewer, we require three status checks
|
- In addition to the PR and approving reviewer, we require three status checks
|
||||||
to pass before code can be merged
|
to pass before code can be merged
|
||||||
|
_ Build with Node 20
|
||||||
_ Build with Node 18
|
_ Build with Node 18
|
||||||
_ Build with Node 16 \* LGTM analysis: JavaScript
|
|
||||||
- We _allow_ force pushes for project admins. While force pushes can create
|
- We _allow_ force pushes for project admins. While force pushes can create
|
||||||
some head scratching moments for people who have cloned the repo and update
|
some head scratching moments for people who have cloned the repo and update
|
||||||
before and after the force push, the ability to clean up the `HEAD` of a
|
before and after the force push, the ability to clean up the `HEAD` of a
|
||||||
|
|||||||
@@ -39,8 +39,8 @@
|
|||||||
"strip-json-comments": "^5.0.1"
|
"strip-json-comments": "^5.0.1"
|
||||||
},
|
},
|
||||||
"engines": {
|
"engines": {
|
||||||
"node": ">=16",
|
"node": ">=18",
|
||||||
"npm": ">=8"
|
"npm": ">=10"
|
||||||
},
|
},
|
||||||
"h5bp-configs": {
|
"h5bp-configs": {
|
||||||
"directories": {
|
"directories": {
|
||||||
|
|||||||
Reference in New Issue
Block a user