github/hub-monorepo
1
1
Fork 0
mirror of https://github.com/farcasterxyz/hub-monorepo.git synced 2026-04-18 03:00:22 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: Dedup eth events retries by block number to save api calls (#917)

Browse Source
This commit is contained in:
Sanjay
2023-04-25 10:40:42 -07:00
committed by GitHub
parent a57e335da6
commit 4fc319812e
3 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/kind-bugs-wave.md Normal file
View File

@@ -0,0 +1,5 @@
---
'@farcaster/hubble': patch
---
Dedupe eth events when retrying to be more efficient with api calls

8
apps/hubble/src/eth/ethEventsProvider.ts
View File

@@ -54,6 +54,7 @@ export class EthEventsProvider {
private _idEventsByBlock: Map<number, Array<IdRegistryEvent>>;
private _nameEventsByBlock: Map<number, Array<NameRegistryEvent>>;
private _renewEventsByBlock: Map<number, Array<NameRegistryRenewEvent>>;
private _retryDedupMap: Map<number, boolean>;
private _lastBlockNumber: number;
@@ -87,6 +88,7 @@ export class EthEventsProvider {
this._nameEventsByBlock = new Map();
this._idEventsByBlock = new Map();
this._renewEventsByBlock = new Map();
this._retryDedupMap = new Map();
// Setup IdRegistry contract
this._idRegistryContract.on('Register', (to: string, id: bigint, _recovery, _url, event: ContractEventPayload) => {
@@ -240,6 +242,10 @@ export class EthEventsProvider {
* @param blockNumber
*/
public async retryEventsFromBlock(blockNumber: number) {
if (this._retryDedupMap.has(blockNumber)) {
return;
}
this._retryDedupMap.set(blockNumber, true);
await this.syncHistoricalIdEvents(IdRegistryEventType.REGISTER, blockNumber, blockNumber + 1, 1);
await this.syncHistoricalIdEvents(IdRegistryEventType.TRANSFER, blockNumber, blockNumber + 1, 1);
@@ -471,6 +477,8 @@ export class EthEventsProvider {
await this._hub.submitNameRegistryEvent(updatedEvent);
}
}
this._retryDedupMap.delete(cachedBlock);
}
}

2
apps/hubble/src/network/sync/multiPeerSyncEngine.test.ts
View File

@@ -327,7 +327,7 @@ describe('Multi peer sync engine', () => {
// Because do it without awaiting, we need to wait for the promise to resolve
await sleep(100);
expect(mockRPCProvider.getLogsCount).toBeGreaterThan(0);
expect(mockRPCProvider.getLogsCount).toEqual(3);
});
test('Merge with multiple signers', async () => {