mirror of
https://github.com/farcasterxyz/hub-monorepo.git
synced 2026-01-14 15:47:57 -05:00
@farcaster/shuttle@0.4.1
1466 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
Sanjay
|
fb54ef89bb |
fix(shuttle): Bump max receive size to fix resource exhaustion error (#2106)
## Motivation Stream processing was halting due to: ``` Hub event stream processing halted 8 RESOURCE_EXHAUSTED: Received message larger than max (5086178 vs 4194304) ``` ## Change Summary Describe the changes being made in 1-2 concise sentences. ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. - [x] All [commits have been signed](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#22-signing-commits) ## Additional Context If this is a relatively large or complex change, provide more details here that will help reviewers <!-- start pr-codex --> --- ## PR-Codex overview This PR updates the Shuttle package to version 0.4.1, fixing a resource exhaustion error and increasing the maximum receive size. ### Detailed summary - Updated Shuttle package version to 0.4.1 - Increased maximum receive message length to 10mb - Fixed resource exhaustion error > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->@farcaster/shuttle@0.4.1 |
||
|
Sanjay
|
00d88c6f7f |
chore: Release 1.13.4 (#2104)
## Motivation Release performance fixes for gossip ## Change Summary Describe the changes being made in 1-2 concise sentences. ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. - [x] All [commits have been signed](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#22-signing-commits) ## Additional Context If this is a relatively large or complex change, provide more details here that will help reviewers <!-- start pr-codex --> --- ## PR-Codex overview This PR updates the version of `@farcaster/hubble` to `1.13.4` in the package.json and includes patch changes related to fixing issues with mainnet bootstrap peers and gossip worker. ### Detailed summary - Updated version to `1.13.4` - Removed `nemes` from mainnet bootstrap peers - Fixed gossip worker spending too much time iterating peer store > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->@farcaster/hubble@1.13.4 |
||
|
Sanjay
|
366ce95c31 |
fix: Fix gossip worker spending too much time iterating peer store (#2103)
## Motivation
```
[Bottom up (heavy) profile]:
Note: percentage shows a share of a particular caller in the total
amount of its parent calls.
Callers occupying less than 1.0% are not shown.
ticks parent name
1460430 43.7% /home/sanjay/.nvm/versions/node/v18.15.0/bin/node
795879 54.5% /home/sanjay/.nvm/versions/node/v18.15.0/bin/node
224383 28.2% LazyCompile: *peerIdFromBytes file:///home/sanjay/hubble_dev/node_modules/@libp2p/peer-id/dist/src/index.js:153:32
224365 100.0% LazyCompile: *all file:///home/sanjay/hubble_dev/node_modules/@libp2p/peer-store/dist/src/store.js:170:15
224365 100.0% /home/sanjay/.nvm/versions/node/v18.15.0/bin/node
174182 21.9% LazyCompile: *load file:///home/sanjay/hubble_dev/node_modules/@libp2p/peer-store/dist/src/store.js:35:15
174145 100.0% /home/sanjay/.nvm/versions/node/v18.15.0/bin/node
90942 11.4% LazyCompile: *decode file:///home/sanjay/hubble_dev/node_modules/multiformats/src/bases/base.js:343:12
90931 100.0% LazyCompile: *all file:///home/sanjay/hubble_dev/node_modules/@libp2p/peer-store/dist/src/store.js:170:15
90931 100.0% /home/sanjay/.nvm/versions/node/v18.15.0/bin/node
79173 9.9% /home/sanjay/.nvm/versions/node/v18.15.0/bin/node
27262 34.4% LazyCompile: *cleanPath file:///home/sanjay/hubble_dev/node_modules/@libp2p/peer-store/node_modules/@multiformats/multiaddr/dist/src/codec.js:165:26
27252 100.0% LazyCompile: *bytesToMultiaddrParts file:///home/sanjay/hubble_dev/node_modules/@libp2p/peer-store/node_modules/@multiformats/multiaddr/dist/src/codec.js:56:38
27235 99.9% LazyCompile: *load file:///home/sanjay/hubble_dev/node_modules/@libp2p/peer-store/dist/src/store.js:35:15
15786 19.9% LazyCompile: *all file:///home/sanjay/hubble_dev/node_modules/@libp2p/peer-store/dist/src/store.js:170:15
15786 100.0% /home/sanjay/.nvm/versions/node/v18.15.0/bin/node
879 5.6% LazyCompile: *forEach file:///home/sanjay/hubble_dev/node_modules/@libp2p/peer-store/dist/src/index.js:24:18
12903 16.3% LazyCompile: *format file:///home/sanjay/hubble_dev/node_modules/multiformats/src/cid.js:20:23
12886 99.9% LazyCompile: *all file:///home/sanjay/hubble_dev/node_modules/@libp2p/peer-store/dist/src/store.js:170:15
12886 100.0% /home/sanjay/.nvm/versions/node/v18.15.0/bin/node
10342 13.1% LazyCompile: *peerIdFromBytes file:///home/sanjay/hubble_dev/node_modules/@libp2p/peer-id/dist/src/index.js:153:32
10341 100.0% LazyCompile: *all file:///home/sanjay/hubble_dev/node_modules/@libp2p/peer-store/dist/src/store.js:170:15
10341 100.0% /home/sanjay/.nvm/versions/node/v18.15.0/bin/node
7094 9.0% LazyCompile: *bytesToMultiaddrParts file:///home/sanjay/hubble_dev/node_modules/@libp2p/peer-store/node_modules/@multiformats/multiaddr/dist/src/codec.js:56:38
7092 100.0% LazyCompile: *load file:///home/sanjay/hubble_dev/node_modules/@libp2p/peer-store/dist/src/store.js:35:15
7092 100.0% /home/sanjay/.nvm/versions/node/v18.15.0/bin/node
3885 4.9% LazyCompile: *_peerIdToDatastoreKey file:///home/sanjay/hubble_dev/node_modules/@libp2p/peer-store/dist/src/store.js:21:26
3883 99.9% LazyCompile: *all file:///home/sanjay/hubble_dev/node_modules/@libp2p/peer-store/dist/src/store.js:170:15
3883 100.0% /home/sanjay/.nvm/versions/node/v18.15.0/bin/node
38786 4.9% LazyCompile: *fromString file:///home/sanjay/hubble_dev/node_modules/uint8arrays/dist/src/from-string.js:10:27
24315 62.7% LazyCompile: *Key file:///home/sanjay/hubble_dev/node_modules/interface-datastore/dist/src/key.js:29:16
24275 99.8% LazyCompile: *all file:///home/sanjay/hubble_dev/node_modules/@libp2p/peer-store/dist/src/store.js:170:15
24275 100.0% /home/sanjay/.nvm/versions/node/v18.15.0/bin/node
7340 18.9% LazyCompile: *_peerIdToDatastoreKey file:///home/sanjay/hubble_dev/node_modules/@libp2p/peer-store/dist/src/store.js:21:26
7338 100.0% LazyCompile: *all file:///home/sanjay/hubble_dev/node_modules/@libp2p/peer-store/dist/src/store.js:170:15
7338 100.0% /home/sanjay/.nvm/versions/node/v18.15.0/bin/node
7110 18.3% LazyCompile: *_allKeys file:///home/sanjay/hubble_dev/node_modules/datastore-core/dist/src/memory.js:32:14
7110 100.0% /home/sanjay/.nvm/versions/node/v18.15.0/bin/node
7010 98.6% LazyCompile: *next file:///home/sanjay/hubble_dev/node_modules/it-peekable/dist/src/index.js:17:15
98 1.4% Function: ^next file:///home/sanjay/hubble_dev/node_modules/it-peekable/dist/src/index.js:17:15
25814 3.2% LazyCompile: *toString file:///home/sanjay/hubble_dev/node_modules/uint8arrays/dist/src/to-string.js:9:25
24662 95.5% LazyCompile: *bytes2mh file:///home/sanjay/hubble_dev/node_modules/@libp2p/peer-store/node_modules/@multiformats/multiaddr/dist/src/convert.js:188:18
24661 100.0% LazyCompile: *bytesToMultiaddrParts file:///home/sanjay/hubble_dev/node_modules/@libp2p/peer-store/node_modules/@multiformats/multiaddr/dist/src/codec.js:56:38
```
## Change Summary
Describe the changes being made in 1-2 concise sentences.
## Merge Checklist
_Choose all relevant options below by adding an `x` now or at any time
before submitting for review_
- [x] PR title adheres to the [conventional
commits](https://www.conventionalcommits.org/en/v1.0.0/) standard
- [x] PR has a
[changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets)
- [x] PR has been tagged with a change label(s) (i.e. documentation,
feature, bugfix, or chore)
- [ ] PR includes
[documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs)
if necessary.
- [x] All [commits have been
signed](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#22-signing-commits)
## Additional Context
If this is a relatively large or complex change, provide more details
here that will help reviewers
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on optimizing the performance of the `peerStoreCount`
function in the `gossipNodeWorker.ts` file by addressing the issue of
blocking the event loop.
### Detailed summary
- Added a comment highlighting the performance-intensive nature of
`peerStoreCount` function
- Removed redundant `statsd().gauge` call in `handleContactInfo` method
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your
question}`
<!-- end pr-codex -->
|
||
|
Wasif Iqbal
|
3f0fb85c15 | fix: remove nemes from mainnet bootstrap peers (#2102) | ||
|
Sanjay
|
2bf0959f2e |
chore: Release 1.13.3 (#2091)
## Motivation Release 1.13.3 ## Change Summary Describe the changes being made in 1-2 concise sentences. ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. - [x] All [commits have been signed](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#22-signing-commits) ## Additional Context If this is a relatively large or complex change, provide more details here that will help reviewers@farcaster/hubble@1.13.3 @farcaster/hub-nodejs@0.11.18 @farcaster/core@0.14.17 |
||
|
Sanjay
|
b150e90001 |
fix: Use stricter socket timeout for gossip (#2090)
## Motivation Gossip metrics indicate the worker sometimes stalls for 5 mins before receiving messages in a burst. Likely due to one or more bad peers. The default socket timeout is 5 mins, set this to 30seconds to see if it helps. ## Change Summary Describe the changes being made in 1-2 concise sentences. ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. - [x] All [commits have been signed](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#22-signing-commits) ## Additional Context If this is a relatively large or complex change, provide more details here that will help reviewers <!-- start pr-codex --> --- ## PR-Codex overview This PR updates the `hubble` package to use a stricter socket timeout for gossip communication in the `gossipNodeWorker.ts` file. ### Detailed summary - Updated the socket timeout for gossip communication to be stricter (30 seconds). - Modified the `transports` configuration to include the new socket timeout settings. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
Shane da Silva
|
2e0779161b |
fix: Ensure we run yarn postinstall script for production build (#2089)
## Motivation We were still missing the patch in production. ## Change Summary Ensure we run `postinstall` in production as well. ## Merge Checklist - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [ ] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. - [x] All [commits have been signed](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#22-signing-commits) ## Additional Context If this is a relatively large or complex change, provide more details here that will help reviewers <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on optimizing the Docker build process by adding a `yarn postinstall` step after installing production dependencies. ### Detailed summary - Added `yarn postinstall` step after installing production dependencies in the Dockerfile. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
Wasif Iqbal
|
eacf29c98c |
fix: return better error message (#2077)
## Motivation Parameters that contained invalid cast URLs with valid cast URL prefixes were surfacing database error instead of not found error. The url itself did not contain parent casts, but because it contained a valid prefix, the database lookups were returning errors. For example, a valid URL may be: "https://warpcast.com/~/channel/japan777iine" An invalid URL may be: "https://warpcast.com/~/chanel-makeup" Since both URLs contain same prefix, _part_ of the invalid param gets processed. That "prefix" then yields an error when entries aren't found in the database. However, no entries found is expected, because the URL is garbage. Instead of surfacing the database error, we now correctly surface not found error. This should fix #2067 - Certain queries to Hub API caused db errors to surface, e.g: ``` { "code": 2, "details": "db.internal_error/could not get message with key: [1, 129, 11, 134, 0, 1, 111, 110, 101, 6, 78, 209, 172, 203, 162, 11, 104, 228, 239, 164, 151, 212, 243, 3, 81, 109, 55, 199, 100, 32]", "metadata": { "errcode": [ null ] } } ``` ## Change Summary **Empty URL** ``` { "errCode": "bad_request.invalid_param", "presentable": false, "name": "HubError", "code": 3, "details": "url < 1 byte", "metadata": { "errcode": [ "bad_request.invalid_param" ] } } ``` **Invalid URL** ``` { "errCode": "not_found", "presentable": false, "name": "HubError", "code": 2, "details": "could not get message with key: [1, 129, 11, 134, 0, 1, 111, 110, 101, 6, 78, 209, 172, 203, 162, 11, 104, 228, 239, 164, 151, 212, 243, 3, 81, 109, 55, 199, 100, 32]", "metadata": { "errcode": [ "not_found" ] } } ``` ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [ ] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. - [x] All [commits have been signed](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#22-signing-commits) ## Additional Context If this is a relatively large or complex change, provide more details here that will help reviewers <!-- start pr-codex --> --- ## PR-Codex overview The focus of this PR is to fix the issue where the HTTP endpoint returns "not found" instead of an internal database error. ### Detailed summary - Fixed the issue in the `cast_store.rs` file related to generating message primary key - Updated error handling in `message.rs` and `store.rs` files - Added a new function `not_found` in `store.rs` - Modified error conversion logic in `server.ts` to handle Rust errors > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
Aditi Srinivasan
|
2d26d3051b |
cli tool for computing sync health and exploring causes for message diffs (#2073)
## Motivation
We want a better metric than current number of messages (i.e. "sync
percent") for measuring sync health. It doesn't account for the fact
that there are valid reasons for temporary displacements in message
counts (i.e. compaction, small network delays). Instead, we want to take
some chunk of time in the past and count up messages in that chunk and
compare the counts as a somewhat more evolved sync metric.
## Change Summary
CLI command that computes sync health between one node and peers,
explores nonzero diffs, and prints out summarized, structured output.
```
❯ node build/cli.js sync-health --max-num-peers 50 --primary-node lamia.farcaster.xyz:2283 --start-time-ofday 11:30:00 --stop-time-ofday 11:35:00
❯ cat health.out | jq
{
"startTime": "2024-06-21T15:15:00.000Z",
"stopTime": "2024-06-21T15:17:00.000Z",
"primary": "hoyt.farcaster.xyz:2283",
"peer": "84.247.160.59:2283",
"primaryMessageCount": 5311,
"peerMessageCount": 4930,
"diff": 381,
"diffPercentage": 0.0717379024665788,
"numSuccessToPeer": 378,
"numErrorToPeer": 6,
"successTypesToPeer": [
null,
3,
2,
6
],
"errorMessagesToPeer": [
"no storage",
"invalid signer: signer 0x02c2f67b36cec88270462f95d7c553d13bc339be61c02db591c9144fcf2592dd not found for fid 681926"
],
"numSuccessToPrimary": 0,
"numErrorToPrimary": 0,
"successTypesToPrimary": [],
"errorMessagesToPrimary": []
}
```
## Merge Checklist
_Choose all relevant options below by adding an `x` now or at any time
before submitting for review_
- [x] PR title adheres to the [conventional
commits](https://www.conventionalcommits.org/en/v1.0.0/) standard
- [x] PR has a
[changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets)
- [ ] PR has been tagged with a change label(s) (i.e. documentation,
feature, bugfix, or chore)
- [x] PR includes
[documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs)
if necessary.
- [x] All [commits have been
signed](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#22-signing-commits)
## Additional Context
If this is a relatively large or complex change, provide more details
here that will help reviewers
<!-- start pr-codex -->
---
## PR-Codex overview
This PR introduces a CLI tool `hubble` for measuring sync health. It
includes commands to measure sync health and calculates message
statistics between nodes.
### Detailed summary
- Added `sync-health` command to measure sync health
- Introduced classes for message stats and sync health stats
- Implemented functions to query message counts and compute stats
- Added functions to pick peers and compute sync IDs
> The following files were skipped due to too many changes:
`apps/hubble/src/utils/syncHealth.ts`
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your
question}`
<!-- end pr-codex -->
|
||
|
Sanjay
|
ff4ec34429 |
chore: Release 1.13.2 (#2081)
## Motivation Release 1.13.2 ## Change Summary Describe the changes being made in 1-2 concise sentences. ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. - [x] All [commits have been signed](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#22-signing-commits) ## Additional Context If this is a relatively large or complex change, provide more details here that will help reviewers <!-- start pr-codex --> --- ## PR-Codex overview The focus of this PR is to update package versions and dependencies across multiple repositories. ### Detailed summary - Updated package versions to `0.14.16`, `0.8.11`, `0.11.17`, `0.4.0`, `1.13.2` - Updated dependencies in various packages - Added rpc to expose `LinkCompactStateMessage` with explicit handling of type > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->@farcaster/hubble@1.13.2 @farcaster/core@0.14.16 @farcaster/hub-nodejs@0.11.17 @farcaster/hub-web@0.8.11 @farcaster/shuttle@0.4.0 |
||
|
Wasif Iqbal
|
4c64539d19 |
feat: add FID storage rent statistics to db storage profile (#2076)
## Motivation add FID storage rent statistics to db storage profile ## Change Summary Describe the changes being made in 1-2 concise sentences. ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [ ] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [ ] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. - [x] All [commits have been signed](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#22-signing-commits) ## Additional Context If this is a relatively large or complex change, provide more details here that will help reviewers <!-- start pr-codex --> --- ## PR-Codex overview The focus of this PR is to enhance the profiling functionality in the `hubble` app by adding features related to storage rent statistics and on-chain event categorization. ### Detailed summary - Increased `profile` script memory allocation to 8192 MB - Added imports from `@farcaster/core` and `events` module - Updated `ValueStats` class calculations for min, max, and average - Added function to calculate current Farcaster timestamp - Introduced storage rent statistics calculation and categorization - Enhanced CSV output with storage rent statistics - Improved logging and error handling in the profiling process > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> --------- Co-authored-by: Sanjay Raveendran <sanjayprabhu@gmail.com> |
||
|
Shane da Silva
|
0f9ee6c774 |
fix: Ensure patch files are included in Docker environment during build (#2080)
## Motivation We weren't including these files, so `yarn postinstall` didn't work as expected. ## Change Summary Describe the changes being made in 1-2 concise sentences. ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [ ] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. - [x] All [commits have been signed](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#22-signing-commits) ## Additional Context If this is a relatively large or complex change, provide more details here that will help reviewers <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on adding a new directory `patches` to the Docker image, running `yarn install` with specific options, and executing `yarn postinstall`. ### Detailed summary - Added `patches` directory to Docker image - Ran `yarn install` with `--frozen-lockfile --network-timeout 1800000` - Executed `yarn postinstall` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
Cassandra Heart
|
6ceb8f54bf | fix: add patch to libp2p/peer-store to resolve broken peer id load failures (#2075) | ||
|
Cassandra Heart
|
ad28172904 |
feat: support compact state type for links in message reconciliation (#2074)
## Motivation Currently message reconciliation skips over LinkCompactState messages when fetching from hubs, and depending on the logic of the caller of that reconciler, it may make the caller mark the message as deleted (and subsequently perform deletions on the follows). ## Change Summary This change alters the hub message fetch to also call this RPC when reconciling links. Important: users of this version will have to have the corresponding RPC from #2068. ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [x] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. - [x] All [commits have been signed](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#22-signing-commits) ## Additional Context If this is a relatively large or complex change, provide more details here that will help reviewers <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on enhancing link reconciliation in the `shuttle` package by calling the compact state RPC. ### Detailed summary - Added a new method to retrieve link compact state messages by FID - Updated imports in integration tests - Implemented a test for reconciling messages and flagging incorrectly deleted messages > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
Sanjay
|
f25f133f30 |
chore: Segment bundle delay stats by message status (#2070)
## Motivation Segment bundle delay stats by message status ## Change Summary Describe the changes being made in 1-2 concise sentences. ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. - [x] All [commits have been signed](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#22-signing-commits) ## Additional Context If this is a relatively large or complex change, provide more details here that will help reviewers <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on segmenting bundle delay stats by message status in the `handleGossipMessage` function of `Hubble`. ### Detailed summary - Added tracking of bundle delay stats for invalid, success, and failure cases - Segmented bundle delay stats based on message status - Improved reporting logic for gossip messages in `handleGossipMessage` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
Aditi Srinivasan
|
27a1cfc84a |
fix: log before exiting in hubble cli (#2062)
## Motivation
When running the `yarn identity create` I didn't know if my id was
created and where it was stored based on the output of the command. I
ran `node build/cli.js identity create` without the `--no-warnings` and
still didn't see any difference. Flushing before exiting the process
fixed the issue. I validated with the verify command
```
node build/cli.js identity verify .hub/12D3KooWCbYEURXXG3554vgSrBEWah4YxCebNghwWL5TvLSS7mmG_id.protobuf
{"hostname":"Aditis-MBP","pid":65745,"time":1718476986530,"level":30,"msg":"Flushing rust log buffer. Writing logs directly from Rust","flush_next":true}
{"level":30,"time":1718476986530,"pid":65745,"hostname":"Aditis-MBP","msg":"Successfully Read peerId: 12D3KooWEfACVRKnbdsEbPmsiJNAwwtq6pu7MtV4TFv54j2Te8cu from ./.hub/default_id.protobuf"}
```
## Change Summary
Flush logs before exiting a process in the hubble cli tool.
## Merge Checklist
_Choose all relevant options below by adding an `x` now or at any time
before submitting for review_
- [x] PR title adheres to the [conventional
commits](https://www.conventionalcommits.org/en/v1.0.0/) standard
- [x] PR has a
[changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets)
- [x] PR has been tagged with a change label(s) (i.e. documentation,
feature, bugfix, or chore)
- [x] PR includes
[documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs)
if necessary.
- [x] All [commits have been
signed](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#22-signing-commits)
<!-- start pr-codex -->
---
## PR-Codex overview
The focus of this PR is to update the `cli.ts` file in the
`@farcaster/hubble` package to ensure logs are flushed before exiting.
### Detailed summary
- Updated `cli.ts` to use `flushAndExit` function for exiting with log
flush
- Replaced all `process.exit` calls with `return flushAndExit`
- Added `flushAndExit` function to flush logs before exiting
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your
question}`
<!-- end pr-codex -->
|
||
|
Cassandra Heart
|
dab95118e0 |
feat: expose LinkCompactState messages via rpc (#2068)
## Motivation Currently, our retrieval of Link messages only show adds/removes, compact state messages serving as silent tombstones. This is fine for getting a quick set of adds/removes as they currently apply, but may produce confusing state when looking at two hubs, where one has the message, and the other doesn't, and trying to reconcile why some messages are missing from the one with the LinkCompactState message and not the other. ## Change Summary This change adds a new rpc GetLinkCompactStateMessageByFid, which returns the relevant compact state message, if present. ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [x] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. - [x] All [commits have been signed](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#22-signing-commits) ## Additional Context If this is a relatively large or complex change, provide more details here that will help reviewers <!-- start pr-codex --> --- ## PR-Codex overview This PR standardizes the naming convention for `CastType` across multiple files and adds support for `LinkCompactStateMessage` handling in various store modules and RPC methods. ### Detailed summary - Standardized `CastType` naming convention to `cast` in multiple files - Added support for `LinkCompactStateMessage` in store modules and RPC methods > The following files were skipped due to too many changes: `apps/hubble/www/docs/docs/api.md`, `packages/hub-nodejs/src/generated/rpc.ts`, `packages/hub-web/src/generated/rpc.ts` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
Aditi Srinivasan
|
967172f140 |
docs: updated install and monitoring pages (#2066)
## Motivation I just went through setting up a node and updated the docs to hopefully mitigate some hiccups I ran into for anybody that does this in the future. ## Change Summary Updating the hub installation and monitoring docs. ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [ ] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [x] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. - [x] All [commits have been signed](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#22-signing-commits) |
||
|
Christopher Wallace
|
c9625021ae |
chore: Update message.ts (#2064)
## Motivation The comment describing CastType is duplicate of the Verification type. We are updating so it makes sense. ## Change Summary Updated from `Type of Protocol to disambiguate verification addresses` to `Type of Cast` ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [ ] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [ ] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. - [x] All [commits have been signed](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#22-signing-commits) <!-- start pr-codex --> --- ## PR-Codex overview This PR renames the `Type of Protocol to disambiguate verification addresses` enum to `Type of Cast` and updates the enum values accordingly. ### Detailed summary - Renamed enum `ProtocolType` to `CastType` - Updated enum values to `CAST` and `LONG_CAST` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
Aditi Srinivasan
|
fbf575bae0 |
fix: updated multinode docker compose (#2065)
## Motivation I tried running this multinode setup and ran into a couple issues with the config. This PR fixes them. ## Change Summary I just added arguments for the optimism rpc url (required) and removed --gossip-metrics-enabled which doesn't exist anymore. ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [ ] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [x] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. - [x] All [commits have been signed](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#22-signing-commits) |
||
|
dependabot[bot]
|
e6c4336564 |
chore(deps): bump @grpc/grpc-js from 1.8.21 to 1.8.22 in /packages/hub-nodejs/examples/write-data (#2052)
Bumps [@grpc/grpc-js](https://github.com/grpc/grpc-node) from 1.8.21 to 1.8.22. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/grpc/grpc-node/releases"><code>@grpc/grpc-js</code>'s releases</a>.</em></p> <blockquote> <h2><code>@grpc/grpc-js</code> 1.8.22</h2> <ul> <li>Avoid buffering significantly more than <code>grpc.max_receive_message_size</code> per received message.</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
Elias Rad
|
933c26b39c |
Fix typos (#2060)
This PR addresses several typographical errors across various files in
the project. The changes improve readability and maintain the
professional standard of the documentation and code comments.
Typographical errors, while minor, can detract from the overall quality
of the project. Correcting these errors ensures clarity and
professionalism, making the project more accessible and understandable
for current and future contributors.
Hope it helps.
<!-- start pr-codex -->
---
## PR-Codex overview
This PR improves consistency and clarity in the documentation by fixing
grammatical errors and updating wording for better readability.
### Detailed summary
- Fixed grammatical errors and improved wording for better clarity in
documentation
- Updated wording for consistency and readability in various sections of
the documentation
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your
question}`
<!-- end pr-codex -->
|
||
|
dependabot[bot]
|
77cd03bcb3 |
chore(deps): bump @grpc/grpc-js from 1.8.21 to 1.8.22 in /packages/hub-nodejs/examples/contract-signatures (#2053)
Bumps [@grpc/grpc-js](https://github.com/grpc/grpc-node) from 1.8.21 to 1.8.22. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/grpc/grpc-node/releases"><code>@grpc/grpc-js</code>'s releases</a>.</em></p> <blockquote> <h2><code>@grpc/grpc-js</code> 1.8.22</h2> <ul> <li>Avoid buffering significantly more than <code>grpc.max_receive_message_size</code> per received message.</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
dependabot[bot]
|
0239442083 |
chore(deps): bump braces from 3.0.2 to 3.0.3 in /packages/hub-nodejs/examples/contract-signatures (#2051)
Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
Shane da Silva
|
76c0504f7f |
chore: Lower level of shuttle logs to debug (#2063)
## Motivation These logs aren't strictly useful in a normal sense. ## Change Summary Lower them to debug log level to make the logs less noisy. ## Merge Checklist - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. - [x] All [commits have been signed](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#22-signing-commits) <!-- start pr-codex --> --- ## PR-Codex overview The focus of this PR is to lower the level of shuttle logs to debug in the `MessageReconciliation` class in the `shuttle` package. ### Detailed summary - Lowered the logging level to debug in `messageReconciliation.ts` for better debugging. - Replaced `this.log.info` with `this.log.debug` for certain log messages. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
Sanjay
|
e58e963d0a |
fix: Always log when updating contact info (#2058)
## Motivation We were only logging when we received a brand new contactInfo, we should be logging everytime we see a new or updated contactInfo ## Change Summary Describe the changes being made in 1-2 concise sentences. ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. - [x] All [commits have been signed](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#22-signing-commits) ## Additional Context If this is a relatively large or complex change, provide more details here that will help reviewers <!-- start pr-codex --> --- ## PR-Codex overview This PR updates the `syncEngine` in the Hubble app to always log when updating contact info. ### Detailed summary - Updated `addContactInfoForPeerId` method to always log when updating contact info - Replaced `Err` with `Ok` in test for adding newer contact info - Improved error handling for duplicate peer entries > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
Sanjay
|
926c2105c6 |
fix(shuttle): Fix shuttle hub-nodejs version dep to support long casts (#2050)
## Motivation Shuttle was depending on an older hub-nodejs version which didn't support long cast validation. ## Change Summary Describe the changes being made in 1-2 concise sentences. ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. - [x] All [commits have been signed](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#22-signing-commits) ## Additional Context If this is a relatively large or complex change, provide more details here that will help reviewers <!-- start pr-codex --> --- ## PR-Codex overview This PR updates the version of `@farcaster/hub-nodejs` dependency in `@farcaster/shuttle` package to `0.11.16` to support long casts. ### Detailed summary - Update `@farcaster/hub-nodejs` dependency to version `0.11.16` - Fix shuttle hub-nodejs version dep to support long casts > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->@farcaster/shuttle@0.3.3 |
||
|
dependabot[bot]
|
0e4f37fc17 |
chore(deps): bump @grpc/grpc-js from 1.8.21 to 1.8.22 (#2039)
Bumps [@grpc/grpc-js](https://github.com/grpc/grpc-node) from 1.8.21 to 1.8.22. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/grpc/grpc-node/releases"><code>@grpc/grpc-js</code>'s releases</a>.</em></p> <blockquote> <h2><code>@grpc/grpc-js</code> 1.8.22</h2> <ul> <li>Avoid buffering significantly more than <code>grpc.max_receive_message_size</code> per received message.</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
Sanjay
|
afad83edce |
feat(shuttle): Store cast type in message body (#2048)
## Motivation Store cast type in message body for shuttle ## Change Summary Describe the changes being made in 1-2 concise sentences. ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. - [x] All [commits have been signed](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#22-signing-commits) ## Additional Context If this is a relatively large or complex change, provide more details here that will help reviewers <!-- start pr-codex --> --- ## PR-Codex overview This PR updates `@farcaster/shuttle` to version 0.3.2. The main change is storing the cast type in the message body. ### Detailed summary - Updated package version to 0.3.2 - Added `CastType` to message body in `db.ts` - Added `type` field to message body in `utils.ts` - Updated `convertProtobufMessageBodyToJson` function in `utils.ts` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->@farcaster/shuttle@0.3.2 |
||
|
iwantanode
|
b27aa83f2e |
Docs improvements (#2046)
Hello
I fixed some typos in the code, code comments and docs,
Hope it helps.
Br,
Tudor
farcaster ACC: @tudor
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on improving code consistency by fixing typos and
grammatical errors across various files in the project.
### Detailed summary
- Fixed typos in function names and comments for better code readability
- Corrected grammatical errors in error messages and documentation for
clarity and consistency
- Updated wording for better understanding and adherence to project
standards
> The following files were skipped due to too many changes:
`apps/hubble/www/README.md`,
`apps/hubble/www/docs/docs/httpapi/httpapi.md`,
`apps/hubble/www/docs/docs/api.md`
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your
question}`
<!-- end pr-codex -->
|
||
|
dependabot[bot]
|
14b49acb5b |
chore(deps): bump braces from 3.0.2 to 3.0.3 (#2044)
Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
Sanjay
|
bca9618d98 |
chore: Release 1.13.1 (#2047)
## Motivation Patch release with support for long casts ## Change Summary Describe the changes being made in 1-2 concise sentences. ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [x] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. - [ ] All [commits have been signed](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#22-signing-commits) ## Additional Context If this is a relatively large or complex change, provide more details here that will help reviewers <!-- start pr-codex --> --- ## PR-Codex overview This PR updates package versions in different modules, introducing support for long casts and updating dependencies. ### Detailed summary - Bumped version to `0.14.15` in `@farcaster/core` - Added support for long casts - Updated dependencies in various packages - Incremented versions in `@farcaster/hub-web` and `@farcaster/hub-nodejs` - Increased version to `1.13.1` in `@farcaster/hubble` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->@farcaster/hubble@1.13.1 @farcaster/core@0.14.15 @farcaster/hub-nodejs@0.11.16 @farcaster/hub-web@0.8.10 |
||
|
Sanjay
|
c424e111b2 |
feat: Implement longer casts FIP (#2045)
## Motivation Implement https://github.com/farcasterxyz/protocol/discussions/182 ## Change Summary Describe the changes being made in 1-2 concise sentences. ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. - [x] All [commits have been signed](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#22-signing-commits) ## Additional Context If this is a relatively large or complex change, provide more details here that will help reviewers <!-- start pr-codex --> --- ## PR-Codex overview This PR adds support for long casts by introducing a new `CastType` enum and updating validations and tests. ### Detailed summary - Added `CastType` enum with `LONG_CAST` - Updated validations for long casts - Updated tests to support long casts > The following files were skipped due to too many changes: `packages/core/src/protobufs/generated/message.ts` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
Sanjay
|
deef9535f3 |
chore: Release 1.13 (#2043)
## Motivation Release 1.13 ## Change Summary Describe the changes being made in 1-2 concise sentences. ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. - [x] All [commits have been signed](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#22-signing-commits) ## Additional Context If this is a relatively large or complex change, provide more details here that will help reviewers <!-- start pr-codex --> --- ## PR-Codex overview This PR updates versions and dependencies across multiple packages. ### Detailed summary - Extended verifications signature max length - Updated dependencies in `hub-nodejs` and `shuttle` - Changed `farcaster/core` version to `0.14.14` - Released `hubble` version `1.13.0` - Updated `FARCASTER_VERSION` to `2024.6.12` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->@farcaster/hubble@1.13.0 @farcaster/hub-nodejs@0.11.15 @farcaster/shuttle@0.3.1 @farcaster/core@0.14.14 |
||
|
horsefacts
|
de52fbce0b |
feat: increase verification signature max length (#2038)
## Motivation Coinbase Smart Wallet signatures are 1088 bytes long. We've bumped this several times, so add some headroom on top. ## Change Summary Increase verification signature max length to 2048 bytes. ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [x] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. - [x] All [commits have been signed](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#22-signing-commits) <!-- start pr-codex --> --- ## PR-Codex overview This PR extends the maximum length of the `claimSignature` field in verifications to 2048 bytes for better validation accuracy. ### Detailed summary - Increased `claimSignature` max length from 512 to 2048 bytes in validations - Updated test cases to reflect the new max length of `claimSignature` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
Shane da Silva
|
1c90a6883a |
[chore] Remove remaining Envoy references (#2037)
## Motivation We no longer encourage using the grpc-web integration, therefore there's no need for Envoy to be used when deploying hubs any more. ## Change Summary Remove all references to Envoy. - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [ ] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. - [x] All [commits have been signed](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#22-signing-commits) <!-- start pr-codex --> --- ## PR-Codex overview The focus of this PR is to remove unused files related to Envoy in the `hubble` app and refactor some functions for better clarity. ### Detailed summary - Removed unused Envoy-related files (`README.md`, `envoy.yaml`, `envoy-start.sh`) - Refactored functions for fetching and storing files - Updated Docker installation message - Improved crontab setup logic > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
Shane da Silva
|
f80582103c |
[chore] Remove old replicator (#2036)
## Motivation This has been replaced by the Shuttle package. ## Change Summary Remove it to help prevent confusion. ## Merge Checklist - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [ ] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. - [x] All [commits have been signed](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#22-signing-commits) <!-- start pr-codex --> --- ## PR-Codex overview This PR removes the `replicator` module and all related files from the project. ### Detailed summary - Deleted `Dockerfile.replicator` - Removed `replicator` scripts and configurations - Eliminated `replicator` source code, jobs, processors, and migrations > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
Marius Scurtescu
|
37241d8247 |
feat: add docker heath checks to services (#1948)
## Motivation For each service in docker-compose.yml add a healtcheck entry. Issue: https://github.com/farcasterxyz/hub-monorepo/issues/1646 ## Change Summary - adding `healthcheck` commands to all 3 services in `apps/hubble/docker-compose.yml` - installing `curl` command into `farcasterxyz/hubble` docker image (`Dockerfile.hubble`), required by `healthcheck` ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [ ] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. - [x] All [commits have been signed](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#22-signing-commits) <!-- start pr-codex --> --- ## PR-Codex overview This PR enhances Docker health checks for `hubble` services with `curl` and `nc` commands. ### Detailed summary - Added `curl` health check for `hubble` service - Added `nc` health check for `statsd` service - Added `curl` health check for `grafana` service > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> --------- Co-authored-by: Shane da Silva <shane@dasilva.io> |
||
|
Shane da Silva
|
35d395f39c |
[chore] Add Node 22 to test matrix (#2033)
## Motivation We eventually want to release hubs on Node 22, since it's been out for a while. ## Merge Checklist - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [ ] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. - [x] All [commits have been signed](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#22-signing-commits) <!-- start pr-codex --> --- ## PR-Codex overview This PR updates the app version determination method, adjusts CI configurations for ARM support, and refactors the app version retrieval in `hubble.ts`. ### Detailed summary - Updated app version determination method in `hubble.ts` - Adjusted CI configurations for ARM support - Refactored app version retrieval using manual JSON parsing > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
Shane da Silva
|
877966972f |
[chore] Update TypeScript 5.0.2 to 5.4.5 (#2034)
## Motivation Stay up to date. ## Merge Checklist - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. - [x] All [commits have been signed](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#22-signing-commits) <!-- start pr-codex --> --- ## PR-Codex overview This PR updates the TypeScript version, exports multiple signatures for `farcasterTimeToDate`, and includes a new dependency for `uint8-varint`. ### Detailed summary - Updated TypeScript to version 5.4.5 - Exported multiple signatures for `farcasterTimeToDate` - Added `uint8-varint` dependency > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
Sanjay
|
1c2dde78f3 |
feat: Add HUB_OPTIONS env var to docker compose (#2032)
## Motivation Allow customizing docker compose startup commands via a HUB_OPTIONS env var ## Change Summary Describe the changes being made in 1-2 concise sentences. ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. - [x] All [commits have been signed](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#22-signing-commits) ## Additional Context If this is a relatively large or complex change, provide more details here that will help reviewers <!-- start pr-codex --> --- ## PR-Codex overview This PR updates the `docker-compose.yml` file for the `@farcaster/hubble` app to allow customizing HUB_OPTIONS environment variable. ### Detailed summary - Added `HUB_OPTIONS` environment variable to docker compose for `@farcaster/hubble` app - Removed specific values for `HUB_OPERATOR_FID` and `HUB_OPT_OUT_DIAGNOSTICS` in favor of `HUB_OPTIONS` customization > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
Sanjay
|
32ba027b08 |
chore: Release hub-nodejs and core packages (#2030)
## Motivation Publish version with the update builder ## Change Summary Describe the changes being made in 1-2 concise sentences. ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. - [x] All [commits have been signed](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#22-signing-commits) ## Additional Context If this is a relatively large or complex change, provide more details here that will help reviewers@farcaster/core@0.14.13 @farcaster/hub-nodejs@0.11.14 |
||
|
Cassandra Heart
|
911f8b23e6 |
chore: add builder for LinkCompactState (#2029)
## Motivation Describe why this issue should be fixed and link to any relevant design docs, issues or other relevant items. ## Change Summary Describe the changes being made in 1-2 concise sentences. ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. - [x] All [commits have been signed](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#22-signing-commits) ## Additional Context If this is a relatively large or complex change, provide more details here that will help reviewers <!-- start pr-codex --> --- ## PR-Codex overview This PR adds a missing builder for `LinkCompactState` and refactors the code to include the new builder function. ### Detailed summary - Added `makeLinkCompactState` function to build `LinkCompactStateMessage` - Added `makeLinkCompactStateData` function for creating data for `LinkCompactState` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
Sanjay
|
f36155a0cb |
chore: Release 1.12.3 (#2028)
## Motivation Release 1.12.3 ## Change Summary Describe the changes being made in 1-2 concise sentences. ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. - [x] All [commits have been signed](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#22-signing-commits) ## Additional Context If this is a relatively large or complex change, provide more details here that will help reviewers <!-- start pr-codex --> --- ## PR-Codex overview This PR updates versions in various packages and dependencies, including `@farcaster/hub-nodejs`, `@farcaster/shuttle`, `@farcaster/hubble`, and `@farcaster/replicator`. ### Detailed summary - Updated `@farcaster/hub-nodejs` to version 0.11.13 - Updated `@farcaster/shuttle` to version 0.3.0 - Updated `@farcaster/hubble` to version 1.12.3 - Updated `@farcaster/replicator` to version 0.3.8 - Added support for reverse reconciliation in `@farcaster/shuttle` - Improved error message handling for bad host address in `@farcaster/hub-nodejs` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->@farcaster/hubble@1.12.3 @farcaster/replicator@0.3.8 @farcaster/hub-nodejs@0.11.13 @farcaster/shuttle@0.3.0 |
||
|
Sanjay
|
bb707b1efa |
feat(shuttle): add support for reverse reconciliation (#2026)
## Motivation Fixes https://github.com/farcasterxyz/hub-monorepo/issues/2018 ## Change Summary Add support for reverse reconciliation where messages are present in the db but missing in the hub. ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. - [x] All [commits have been signed](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#22-signing-commits) ## Additional Context If this is a relatively large or complex change, provide more details here that will help reviewers <!-- start pr-codex --> --- ## PR-Codex overview This PR adds support for reverse reconciliation in the `@farcaster/shuttle` package. ### Detailed summary - Added a new `onDbMessage` callback function to `MessageReconciliation` class - Implemented reconciliation of messages in the database but not in the hub - Added `DBMessage` type for database messages with relevant fields > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
Shane da Silva
|
87c4f416e1 |
fix: Report better error message when hub address unspecified (#2024)
## Motivation We want a better error message in this case, since the default is unhelpful. Fixes #703. ## Merge Checklist - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [ ] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. - [x] All [commits have been signed](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#22-signing-commits) <!-- start pr-codex --> --- ## PR-Codex overview The focus of this PR is to improve error handling by providing more helpful error messages when an address is not specified in the `hub-nodejs` package. ### Detailed summary - Added better error message for unspecified address in `getSSLClient`, `getInsecureClient`, and `getAdminClient` functions. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
Jean Prat
|
1c9f25275e |
fix(replicator): respect fnames_username_unique constraint (#1971)
## Motivation When a fname is transfered, the fnames_username_unique prevents using delete_at but requires a deletion of the data. ## Change Summary Since hubble forgets about the old fname attachement, I choosed to delete it instead of changing the constraint. * fname <=> old fid is now deleted * userproof <=> old fid is now deleted ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [X] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [X] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [ ] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. - [X] All [commits have been signed](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#22-signing-commits) ## Additional Context closes farcasterxyz/hub-monorepo#1970 <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on respecting the `fnames_username_unique` constraint in `usernameProof.ts`. ### Detailed summary - Added patch to respect `fnames_username_unique` constraint - Updated `processUserNameProofRemove` to delete from and insert into `fnames` table based on conditions - Changed `updateTable` to `deleteFrom` in `processUserNameProofRemove` for `usernameProofs` table - Updated conditions in `processUserNameProofRemove` to include `fid` when deleting from `fnames` table > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
tom
|
f58ad34591 |
chore: fix typos (#2011)
## Motivation Fix some typos ## Change Summary Describe the changes being made in 1-2 concise sentences. ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [ ] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. - [ ] All [commits have been signed](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#22-signing-commits) ## Additional Context If this is a relatively large or complex change, provide more details here that will help reviewers <!-- start pr-codex --> --- ## PR-Codex overview This PR improves code consistency by fixing typos in comments across network-related files. ### Detailed summary - Fixed typos in comments in `gossipNode.ts`, `syncEngine.ts`, and `merkleTrie.ts`. - Updated comments for clarity and correctness. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
Ryan
|
7c24245cb8 |
chore: Add missing message type (#2002)
## Motivation Describe why this issue should be fixed and link to any relevant design docs, issues or other relevant items. Fix the OpenAPI spec ## Change Summary Describe the changes being made in 1-2 concise sentences. Remove empty whitespaces and register the type on the message type. I generated a go client and before this fix, it would not compile. ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [ ] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. - [ ] All [commits have been signed](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#22-signing-commits) ## Additional Context If this is a relatively large or complex change, provide more details here that will help reviewers <!-- start pr-codex --> --- ## PR-Codex overview This PR updates descriptions and schemas in the `spec.yaml` file for `UserData` and `OnChainEvents`. ### Detailed summary - Updated descriptions for `UserData` and `OnChainEvents` - Adjusted response schemas based on parameters - Added clarity on optional parameters and response types > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> |
||
|
Snoppy
|
37c291d15f |
chore: fix typos and link broken (#2015)
## Motivation fix some typos and link broken ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [ ] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [x] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. - [x] All [commits have been signed](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#22-signing-commits) ## Additional Context If this is a relatively large or complex change, provide more details here that will help reviewers <!-- start pr-codex --> --- ## PR-Codex overview This PR updates various files in the codebase to correct typos and improve consistency in naming conventions. ### Detailed summary - Updated `UserNameProofByName` to `user submitted username proofs` - Corrected typos in comments in `store_event_handler.rs` - Updated URL in `ViemLocalEip712Signer.md` - Fixed typo in comment in `cast_store.rs` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> Signed-off-by: snoppy <michaleli@foxmail.com> |